[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

PiotrZSL updated this revision to Diff 503888. PiotrZSL added a comment. Rebase + Move files to other locations due to structure change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137514/new/ https://reviews.llvm.org/D137514 Files:

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, tpr, dstuttard, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: MaskRay, wdng. https://reviews.llvm.org/D145721 Files:

[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

mikecrowe updated this revision to Diff 503884. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Re-upload using arc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145311/new/ https://reviews.llvm.org/D145311 Files:

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; I doubt the ignored

[PATCH] D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, ChuanqiXu, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D145310: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe updated this revision to Diff 503882. mikecrowe added a comment. Herald added a subscriber: PiotrZSL. Rebase on top of fb7ef637a84652dbd3d973a1ba7db9470181b5aa (which is a descendent of

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay abandoned this revision. MaskRay added a comment. Abandoned by a revert of D118493 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D143306

[PATCH] D145719: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe abandoned this revision. mikecrowe added a comment. Whoops. I accidentally uploaded https://reviews.llvm.org/D145719 as a new change. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145719/new/ https://reviews.llvm.org/D145719

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

rsundahl added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1205 unsigned Priority, const MCSymbol *KeySym) const { - // TODO(yln): Remove -lower-global-dtors-via-cxa-atexit fallback flag - // (LowerGlobalDtorsViaCxaAtExit) and always

[PATCH] D145719: [clang-tidy] Make readability-container-data-pointer use header

mikecrowe created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This requires operator[] to be added to the

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

efriedma added a comment. I think the point of the hasOneUse check is to avoid a possible miscompile; if a FREEZE has more than one use, all users need to see the same value. So not sure dropping the check is correct in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

jcranmer-intel added a comment. I'm studiously ignoring the Clang and LLVM codegen changes here, but otherwise, I think the direction of this change is generally good. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1377-1378 llvm_unreachable("unknown denormal mode");

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4182428 , @hoy wrote: > In D83906#4182287 , @dexonsmith > wrote: > >> In C++, you get linkonce_odr all over the place. It's basically all >> functions that are defined in C++

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c82050c5692: Add codegen for llvm exp/exp2 elementwise builtins (authored by bob80905). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/

[clang] 4c82050 - Add codegen for llvm exp/exp2 elementwise builtins

Author: Joshua Batista Date: 2023-03-09T12:14:59-08:00 New Revision: 4c82050c56926d840e4ccf253ad10e6ae3ee6cc7 URL: https://github.com/llvm/llvm-project/commit/4c82050c56926d840e4ccf253ad10e6ae3ee6cc7 DIFF:

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai added a comment. Another note regarding the motivating test case: Use of `vector double` should require VSX. We don't really seem to have the ability to turn this off early enough to catch this though. It would seem that in the front end, the target features depend on the compilation

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

nemanjai added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:491 +TARGET_BUILTIN(__builtin_altivec_vabsduh, "V8UsV8UsV8Us", "", "altivec") +TARGET_BUILTIN(__builtin_altivec_vabsduw, "V4UiV4UiV4Ui", "", "altivec") qiucf wrote: > shchenz

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4182287 , @dexonsmith wrote: > In C++, you get linkonce_odr all over the place. It's basically all functions > that are defined in C++ headers that are available for inlining. > On the other hand, the frontend knows the

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe99b5ad38381: [memprof] Add scripts to automate testdata regeneration. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES

[clang] e99b5ad - [memprof] Add scripts to automate testdata regeneration.

Author: Snehasish Kumar Date: 2023-03-09T19:54:23Z New Revision: e99b5ad38381ab263820b23a184d217a4112519c URL: https://github.com/llvm/llvm-project/commit/e99b5ad38381ab263820b23a184d217a4112519c DIFF: https://github.com/llvm/llvm-project/commit/e99b5ad38381ab263820b23a184d217a4112519c.diff

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish added a comment. I'll go ahead and push this. @dblaikie Let me know if you have any comments and I'll follow up separately. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a comment. In D145704#4182364 , @aaron.ballman wrote: > This variant comes with a .patch file added to the PR; that should be deleted > in the next round. Aside from that, the changes LGTM, but I'd like to give > precommit CI a

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a comment. In D145704#4182341 , @zahiraam wrote: > In D145704#4182268 , @aaron.ballman > wrote: > >> Thank you for working on this! Because this is fixing an ABI break, if we >> can land

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jhuber6 added a comment. I'm not a fan of the same warning being copied in 24 places. Why do we set `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out the `-fopenmp` or whatever it is for the HIP job? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish marked an inline comment as done. snehasish added a comment. In D145644#4182239 , @tejohnson wrote: > Generally lgtm, but why did the raw profiles change size from what is > currently committed? The reduction in size of the raw profiles is

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam updated this revision to Diff 503865. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Lex/Preprocessor.cpp clang/lib/Sema/SemaAttr.cpp

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a comment. In D145591#4182168 , @yaxunl wrote: > -x hip and -fopenmp has been a valid combination. -fopenmp with -x hip allows > non-offloading OpenMP directives in host code in HIP. It just ignores the > offloading directives. That brings

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

jyu2 added a comment. In D145093#4179927 , @ronlieb wrote: > seems to fail amdgpu buildbot > https://lab.llvm.org/buildbot/#/builders/193/builds/27692 I turn off the test run to amdgpu. And rechecked in with c5b060900e98

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added a comment. In D145704#4182268 , @aaron.ballman wrote: > Thank you for working on this! Because this is fixing an ABI break, if we can > land this in time for the release candidate I think we should try to add this > to 16.0 to limit

[clang] 8da99b4 - Revert "Revert "Add map info for dereference pointer.""

Author: Jennifer Yu Date: 2023-03-09T10:59:59-08:00 New Revision: 8da99b44b6a5a2c9033e38828858cbadad425204 URL: https://github.com/llvm/llvm-project/commit/8da99b44b6a5a2c9033e38828858cbadad425204 DIFF: https://github.com/llvm/llvm-project/commit/8da99b44b6a5a2c9033e38828858cbadad425204.diff

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit

yln created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. yln requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Remove the `-lower-global-dtors-via-cxa-atexit` escape hatch

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish updated this revision to Diff 503859. snehasish added a comment. Update the script in test/tool/llvm-profdata/Inputs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644 Files:

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4181981 , @hoy wrote: > That said, the LLVM optimizer does not strictly subsume the front-end because > of how it fails to handle `linkonce_odr` functions as in > https://reviews.llvm.org/D18634. I'm wondering how

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

aaron.ballman added a subscriber: tstellar. aaron.ballman added a comment. Thank you for working on this! Because this is fixing an ABI break, if we can land this in time for the release candidate I think we should try to add this to 16.0 to limit damage. CC @tstellar for his opinion. This

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

tejohnson added a comment. Generally lgtm, but why did the raw profiles change size from what is currently committed? Comment at: llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh:63 + delete[] f; + + // Loop ensures the two calls to recurse have stack

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish added inline comments. Comment at: llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh:63 + delete[] f; + + // Loop ensures the two calls to recurse have stack contexts that only differ @tejohnson Turns out the LLVM IR matching issue was

[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

snehasish updated this revision to Diff 503850. snehasish added a comment. Update the script for Transforms/PGOProfile/memprof.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145644/new/ https://reviews.llvm.org/D145644 Files:

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added a comment. In D145591#4182016 , @tra wrote: > It sounds like what we want is to make `-x hip` and `-fopenmp` mutually > exclusive, with a hard error when both are used. If you look at the problem > as "-fopenmp completely breaks HIP

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam added subscribers: Wilco1, kito-cheng, bjope. zahiraam added a comment. Tagging @davemgreen, @kito-cheng, @bjope and @Wilco1 for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Setting __FLT_EVAL_METHOD__ to -1 with fast-math will set

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

tra added a subscriber: jhuber6. tra added a comment. In D145591#4180908 , @mhalk wrote: > For example: when using `-x hip -fopenmp --offload-arch=...` (+ other > reasonable parameters) a HIP program with OpenMP target directives will > compile without

[PATCH] D145509: [HIP] Fix temporary files

yaxunl updated this revision to Diff 503826. yaxunl marked an inline comment as done. yaxunl added a comment. fix comments and tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145509/new/ https://reviews.llvm.org/D145509 Files: clang/include/clang/Driver/Driver.h

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 503819. ManuelJBrito added a comment. Rebase `avx-cast-builtins.c` was moved to D144903 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4180435 , @dexonsmith wrote: > Oh, de-refining is pretty nifty / evil. This patch has background: > https://reviews.llvm.org/D18634 > > Since 2016, the optimizer is not allowed to do IPA on functions that can be >

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D145517: MSVC: support version preference with search

compnerd added a comment. Sure thing, I can try to write up some details about that @hans! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145517/new/ https://reviews.llvm.org/D145517 ___ cfe-commits

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.org/D145671

[clang] 9dcf6b1 - [PS4/PS5] Remove C_INCLUDE_DIRS handling

Author: Paul Robinson Date: 2023-03-09T09:26:50-08:00 New Revision: 9dcf6b19daf8980a02a5b9206126b3eff7a37e01 URL: https://github.com/llvm/llvm-project/commit/9dcf6b19daf8980a02a5b9206126b3eff7a37e01 DIFF: https://github.com/llvm/llvm-project/commit/9dcf6b19daf8980a02a5b9206126b3eff7a37e01.diff

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

kzhuravl added a comment. In D145671#4181568 , @yaxunl wrote: > Did you go through the deprecation process for this option? We need to send a > documentation team first so that it is announced to the users. Then in the > next release we can deprecate

[PATCH] D145605: Revert two patches to fix GH58452 regression

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGacecf68c8b7c: Revert two patches to fix GH58452 regression (authored by erichkeane). Herald added a project: clang.

[clang] acecf68 - Revert two patches to fix GH58452 regression

Author: Erich Keane Date: 2023-03-09T09:16:53-08:00 New Revision: acecf68c8b7c3c625cfa00f00f8ddc8f15baae44 URL: https://github.com/llvm/llvm-project/commit/acecf68c8b7c3c625cfa00f00f8ddc8f15baae44 DIFF: https://github.com/llvm/llvm-project/commit/acecf68c8b7c3c625cfa00f00f8ddc8f15baae44.diff

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

rjmccall added a comment. There are *some* properties we can still assume about `linkonce_odr` functions despite them being replaceable at link time. The high-level language guarantee we're starting from is that the source semantics of all versions of the function are identical. The version

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 503796. qiongsiwu1 added a comment. Rename the `ReadOnlyPointers` option in the source to `XCOFFReadOnlyPointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman added a comment. In D143466#4181191 , @tbaeder wrote: > The tests you proposed need https://reviews.llvm.org/D143480 first so we can > cast up more than one level. Okay, how about we land that one first then come back to this one? I left

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1949 + // Pointer of derived type is already on the stack. + const CXXRecordDecl *FinalDecl = cast(BaseType->getDecl()); + const RecordDecl *CurDecl = DerivedType->getDecl();

[PATCH] D122677: [prototype] include-cleaner library

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:62 "misc-unused-alias-decls"); +CheckFactories.registerCheck("misc-unused-includes"); CheckFactories.registerCheck( Missing tests & documentation

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3189-3192 +if ((MI->isBuiltinMacro() || + SourceMgr.isWrittenInBuiltinFile(MI->getDefinitionLoc())) && +!(getLangOpts().ObjC && isObjCProtectedMacro(II))) +

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. In D141714#4175942 , @giulianobelinassi wrote: > Hi, Aron. > > Just to make myself clear: What I need to do is that the clang dumps for C > files are also accepted by GCC as input. FWIW, that's not a supported use for

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

yaxunl requested changes to this revision. yaxunl added a comment. This revision now requires changes to proceed. Did you go through the deprecation process for this option? We need to send a documentation team first so that it is announced to the users. Then in the next release we can

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. D145691 should fix the libc++ CI failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 ___ cfe-commits mailing list

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

jmmartinez added a comment. Just a few minor comments. Everything else seems good to me. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:698 + // an inlined function: if a local variable has a templated type with + // a function-local type as a template

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings added a comment. Thanks @MaskRay for taking a look and thanks @simon_tatham for the review of the change. This change affects existing code so I think it deserves its own commit, but I'll move it down the stack to before D142932 so that later

[clang] 0041f08 - [clang][Interp][NFC] Take a const Descriptor* in dtor,move,ctorFns

Author: Timm Bäder Date: 2023-03-09T16:08:59+01:00 New Revision: 0041f081962c60a96d45d9a3a964c2d00216c16d URL: https://github.com/llvm/llvm-project/commit/0041f081962c60a96d45d9a3a964c2d00216c16d DIFF: https://github.com/llvm/llvm-project/commit/0041f081962c60a96d45d9a3a964c2d00216c16d.diff

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

ahatanak added a comment. clang marks the called function `foo` in p1.cpp as nounwind here: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L1284 clang can also mark a function declaration as nounwind based on the information in the source code, for

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

kadircet added a comment. > @kadircet it is obvious that there is something in this diff that causes this > hesitancy in accepting it. I'm ready to keep iterating on the solution but I > need a clue what needs the improvement. Please comment. sorry for the late reply, i was on vacation and

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

artem.tamazov accepted this revision as: artem.tamazov. artem.tamazov added a comment. This revision is now accepted and ready to land. No objections from MIOpen side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/

[PATCH] D145509: [HIP] Fix temporary files

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:630 // Creates a temp file with $Prefix-%%.$Suffix const char *CreateTempFile(Compilation , StringRef Prefix, StringRef Suffix,

[PATCH] D145605: Revert two patches to fix GH58452 regression

erichkeane updated this revision to Diff 503756. erichkeane added a comment. clang-format fixes, going to make sure this passes CI, then commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145605/new/ https://reviews.llvm.org/D145605 Files: clang/include/clang/Sema/Sema.h

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3393 +break; + } else { +return; HazardyKnusperkeks wrote: > don't need `else` after `break`. > In fact I would

[clang] 1a4d0eb - [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

Author: ManuelJBrito Date: 2023-03-09T14:32:30Z New Revision: 1a4d0eb866be909fe16da5ebffe4122aa0693d8c URL: https://github.com/llvm/llvm-project/commit/1a4d0eb866be909fe16da5ebffe4122aa0693d8c DIFF: https://github.com/llvm/llvm-project/commit/1a4d0eb866be909fe16da5ebffe4122aa0693d8c.diff LOG:

[PATCH] D145034: [Clang][Sema] Start fixing handling of out-of-line definitions of constrained templates

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:141 + ClassTemplate->getInjectedClassNameSpecialization(); + if (Context.hasSameType(Injected, ContextType)) +return ClassTemplate->getTemplatedDecl();

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 503753. rymiel added a comment. Improve code flow in parseConstraintExpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files:

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > vedgy wrote: > > aaron.ballman wrote: > > > vedgy wrote: > > > > Assigning `true` to `int : 1` bit-fields in

[clang] dbde7cc - Switch from int to unsigned int; NFC

Author: Aaron Ballman Date: 2023-03-09T09:29:00-05:00 New Revision: dbde7cc17c3a5b6a35e5ec598ba7eaba6f75d90b URL: https://github.com/llvm/llvm-project/commit/dbde7cc17c3a5b6a35e5ec598ba7eaba6f75d90b DIFF: https://github.com/llvm/llvm-project/commit/dbde7cc17c3a5b6a35e5ec598ba7eaba6f75d90b.diff

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

alexander-shaposhnikov updated this revision to Diff 503750. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145034/new/ https://reviews.llvm.org/D145034 Files:

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans added a comment. In D145369#4181296 , @ilya-biryukov wrote: > I don't have a lot of experience in codegen, so will let Aaron and Richard do > the review. Thanks for checking! I don't have a lot of experience here either, so any review is much

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked an inline comment as not done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > aaron.ballman wrote: > > vedgy wrote: > > > Assigning `true` to `int : 1`

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added a comment. In D143418#4175887 , @vedgy wrote: > In D143418#4175628 , @aaron.ballman > wrote: > >> Hmmm, don't relaxed loads and stores still have the potential to be racey? I >> thought you

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy marked an inline comment as not done. vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** vedgy wrote: > Assigning `true` to `int : 1` bit-fields in C++ code produces a GCC

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

ilya-biryukov added a comment. I don't have a lot of experience in codegen, so will let Aaron and Richard do the review. However, still wanted to share one observation. The actual check that avoids emitting the destructors for variables seems more involved than just checking if the destructor

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503741. TIFitis added a comment. Added names for offload mapper variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. Found some minor cleanups but otherwise LGTM (feel free to fix when landing if you'd like). Comment at: clang/tools/libclang/CXType.cpp:380-384 if (const FieldDecl *FD = dyn_cast_or_null(D)) { if

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

Re: [clang] d4fcc69 - Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot

On Wed, Mar 8, 2023 at 11:57 PM via cfe-commits wrote: > > > Author: jinge90 > Date: 2023-03-09T13:14:36+08:00 > New Revision: d4fcc692ee15b2c6d249daabe31208d6a5afa025 > > URL: > https://github.com/llvm/llvm-project/commit/d4fcc692ee15b2c6d249daabe31208d6a5afa025 > DIFF: >

[clang] feec067 - Revert "Add __builtin_set_flt_rounds"

Author: Aaron Ballman Date: 2023-03-09T08:02:31-05:00 New Revision: feec067982abd806c2cf444956446b604bf7cf4c URL: https://github.com/llvm/llvm-project/commit/feec067982abd806c2cf444956446b604bf7cf4c DIFF: https://github.com/llvm/llvm-project/commit/feec067982abd806c2cf444956446b604bf7cf4c.diff

[clang] 9aa54db - Revert "Disable test for __builtin_set_flt_rounds to avoid breaking PPC buildbot"

Author: Aaron Ballman Date: 2023-03-09T08:01:55-05:00 New Revision: 9aa54db44c5b057669d507c0cd4689062750487e URL: https://github.com/llvm/llvm-project/commit/9aa54db44c5b057669d507c0cd4689062750487e DIFF: https://github.com/llvm/llvm-project/commit/9aa54db44c5b057669d507c0cd4689062750487e.diff

[PATCH] D145435: Choose style (file) from within code for use in IDEs

HazardyKnusperkeks added a comment. In D145435#4179662 , @owenpan wrote: > In D145435#4179308 , @bersbersbers > wrote: > >> In D145435#4173875 , @owenpan >> wrote: >>

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3393 +break; + } else { +return; don't need `else`

[PATCH] D143466: [clang][Interp] Fix initializing base class members

tbaeder marked an inline comment as done. tbaeder added a comment. The tests you proposed need https://reviews.llvm.org/D143480 first so we can cast up more than one level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/

[clang] 85e6617 - Revert "[X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS"

Author: ManuelJBrito Date: 2023-03-09T11:56:08Z New Revision: 85e6617b604a45f0ae5fc08f6cc2c4f6eb3d84a7 URL: https://github.com/llvm/llvm-project/commit/85e6617b604a45f0ae5fc08f6cc2c4f6eb3d84a7 DIFF: https://github.com/llvm/llvm-project/commit/85e6617b604a45f0ae5fc08f6cc2c4f6eb3d84a7.diff LOG:

[clang] 6836714 - Revert "[clang-format] Add -j to clang-format-diff to speed up formatting"

Author: Nikita Popov Date: 2023-03-09T12:32:10+01:00 New Revision: 68367141dd91ee71f50418f28ea358519cd6613d URL: https://github.com/llvm/llvm-project/commit/68367141dd91ee71f50418f28ea358519cd6613d DIFF: https://github.com/llvm/llvm-project/commit/68367141dd91ee71f50418f28ea358519cd6613d.diff

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2817933fdd4: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS (authored by ManuelJBrito). Changed prior to commit:

[clang] e281793 - [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

Author: ManuelJBrito Date: 2023-03-09T11:01:09Z New Revision: e2817933fdd4417673eb7f96a2842ae2dca8fc59 URL: https://github.com/llvm/llvm-project/commit/e2817933fdd4417673eb7f96a2842ae2dca8fc59 DIFF: https://github.com/llvm/llvm-project/commit/e2817933fdd4417673eb7f96a2842ae2dca8fc59.diff LOG:

[PATCH] D145567: [Driver] Rename multilib flags to tags

simon_tatham added inline comments. Comment at: clang/docs/Multilib.rst:71 + arguments into a standard set of simpler "tags". In many cases these tags will look like a command line argument with the leading ``-`` stripped off, + but where a suitable form for the tag

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG353155a1a507: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 353155a - [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

Author: Balázs Kéri Date: 2023-03-09T11:54:52+01:00 New Revision: 353155a1a507e2d04edf227b8665a6360b354762 URL: https://github.com/llvm/llvm-project/commit/353155a1a507e2d04edf227b8665a6360b354762 DIFF: https://github.com/llvm/llvm-project/commit/353155a1a507e2d04edf227b8665a6360b354762.diff

<    1   2   3   >