[PATCH] D145021: [Clang][AIX][p] Manually claim -p in front end

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59848b9ebae6: [Clang][AIX][p] Manually Claim -p in front end (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 59848b9 - [Clang][AIX][p] Manually Claim -p in front end

Author: Michael Francis Date: 2023-03-12T07:33:21Z New Revision: 59848b9ebae6a92a4342b1e8aa32feaf5c9c4b51 URL: https://github.com/llvm/llvm-project/commit/59848b9ebae6a92a4342b1e8aa32feaf5c9c4b51 DIFF: https://github.com/llvm/llvm-project/commit/59848b9ebae6a92a4342b1e8aa32feaf5c9c4b51.diff

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a subscriber: kristof.beyls. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/xray-function-index.cpp:1 +// RUN: %clang_cc1 -fxray-instrument -x c++ -std=c++11 -triple

[PATCH] D145860: [clang][Interp] Fix initializing fields after base class members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504407. bolshakov-a added a comment. Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

tbaeder updated this revision to Diff 504406. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145841/new/ https://reviews.llvm.org/D145841 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/records.cpp Index:

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145859: [Clang][CodeGen] Fix linkage of template parameter objects

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: rsmith, aaron.ballman. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a project: clang.

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504402. bolshakov-a added a comment. Rebase and replace "Clang 16" with "Clang 17" in `cxx_status.html` (Clang 16 RC has already been branched off, AFAIK). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

pengfei updated this revision to Diff 504401. pengfei added a comment. Fix lit failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

pengfei updated this revision to Diff 504400. pengfei added a comment. Fix typo & add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

pengfei planned changes to this revision. pengfei added a comment. In D145857#4186957 , @craig.topper wrote: > Did you test this? I kind of expected the triple would be normalized before > this. I’m not at a computer to check. No, I just tried with

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

craig.topper added a comment. Did you test this? I kind of expected the triple would be normalized before this. I’m not at a computer to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

pengfei created this revision. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Fixes #61347 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145857 Files:

[PATCH] D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const

ChrisThrasher created this revision. ChrisThrasher added a reviewer: JonasToth. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ChrisThrasher requested review of this revision. Herald added a project: clang-tools-extra.

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

tejohnson added a comment. In D53891#4186892 , @nikic wrote: > In D53891#2116541 , @hans wrote: > >> Would be possible to add some documentation for this flag? From a quick >> search it's not clear to me what it

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

nikic added a comment. Herald added a project: All. In D53891#2116541 , @hans wrote: > Would be possible to add some documentation for this flag? From a quick > search it's not clear to me what it does and when one is supposed to use it. Ping on adding

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

hoy added a comment. In D83906#4184916 , @dexonsmith wrote: > In D83906#4183453 , @hoy wrote: > >> Wondering if we can come up with a way to tell the optimizer about that, >> e.g., through a new module flag. When

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Apparently some Objective-C/gmodules LLDB tests aren't happy with this change Investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir updated this revision to Diff 504392. Amir added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 504391. royjacobson added a comment. Small cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files: clang/docs/ReleaseNotes.rst

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 504390. royjacobson added a comment. Handle 0-length unnamed bit fields as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files:

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

ianlevesque accepted this revision. ianlevesque added a comment. This revision is now accepted and ready to land. Good catch, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145848/new/ https://reviews.llvm.org/D145848

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4186805 , @dblaikie wrote: > Yeah, can't say this had occurred to me - but totally makes sense/reckon it's > OK. Any reason to limit this to lldb? I'd expect it'd probably "Just > Work(tm)" on any DWARF consumer?

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

This revision was automatically updated to reflect the committed changes. Closed by commit rG43c90f905a22: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath` (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 43c90f9 - [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

Author: Yaxun (Sam) Liu Date: 2023-03-11T13:33:17-05:00 New Revision: 43c90f905a2293dde1d6975e6747ce50063cd155 URL: https://github.com/llvm/llvm-project/commit/43c90f905a2293dde1d6975e6747ce50063cd155 DIFF:

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added a comment. In D143342#4186809 , @PiotrZSL wrote: > Code is fine, probably If would would write this, then I would bother to > split into C++20 and C++2B simply because `std::print` wouldn't compile if it > wouldn't be available. So I

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL added a comment. "Do you think that the change can land like in its current state first? Or would you prefer that the configuration option is added at the same time?" Code is fine, probably If would would write this, then I would bother to split into C++20 and C++2B simply because

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added a comment. Yeah, can't say this had occurred to me - but totally makes sense/reckon it's OK. Any reason to limit this to lldb? I'd expect it'd probably "Just Work(tm)" on any DWARF consumer? it doesn't hit any recursion issues? (I guess maybe skirts it due to the existing

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

Endill accepted this revision. Endill added a comment. This revision is now accepted and ready to land. LGTM I got confused at first why this fix is done in a function named `getSubobjectSizeInBits`, and why do we calculate size to produce a boolean value in the end. Then I realized that this

[PATCH] D145311: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use header

This revision was automatically updated to reflect the committed changes. Closed by commit rG988355808efc: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use string header (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 9883558 - [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use header

Author: Mike Crowe Date: 2023-03-11T17:46:56Z New Revision: 988355808efcf88719b0fa542779c47742756764 URL: https://github.com/llvm/llvm-project/commit/988355808efcf88719b0fa542779c47742756764 DIFF: https://github.com/llvm/llvm-project/commit/988355808efcf88719b0fa542779c47742756764.diff LOG:

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1e2469edcfc: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144206/new/

[clang-tools-extra] f1e2469 - [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

Author: Piotr Zegar Date: 2023-03-11T17:36:21Z New Revision: f1e2469edcfc160867e4ef73b2dcc259974c9d6a URL: https://github.com/llvm/llvm-project/commit/f1e2469edcfc160867e4ef73b2dcc259974c9d6a DIFF: https://github.com/llvm/llvm-project/commit/f1e2469edcfc160867e4ef73b2dcc259974c9d6a.diff LOG:

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 504381. to268 added a comment. Patch update: Reverting `auto` as a type specifier. I am currently figuring out what behavior the `auto` keyword need to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145311: [clang-tidy] Make abseil-redundant-strcat-calls checker use header

mikecrowe added a comment. In D145311#4184159 , @PiotrZSL wrote: > It's fine, absl::StrCat returns std::string. > So those changes are correct. Thanks. Would you like me to remove the unnecessary noise from the commit message then, or will you do that

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144206/new/ https://reviews.llvm.org/D144206

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fdcd5fbc09: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/

[clang] b1fdcd5 - [Flang] Allow compile *.f03, *.f08 file

Author: Shao-Ce SUN Date: 2023-03-12T01:11:42+08:00 New Revision: b1fdcd5fbc09f9f3e1c8a8b954aa8f9067401b31 URL: https://github.com/llvm/llvm-project/commit/b1fdcd5fbc09f9f3e1c8a8b954aa8f9067401b31 DIFF: https://github.com/llvm/llvm-project/commit/b1fdcd5fbc09f9f3e1c8a8b954aa8f9067401b31.diff

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

PiotrZSL added a comment. Ack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144206/new/ https://reviews.llvm.org/D144206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

PiotrZSL updated this revision to Diff 504377. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Review comments fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144206/new/ https://reviews.llvm.org/D144206 Files:

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson updated this revision to Diff 504376. royjacobson added a comment. Change to a simpler fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145852/new/ https://reviews.llvm.org/D145852 Files: clang/docs/ReleaseNotes.rst

[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As pointed out in https://github.com/llvm/llvm-project/issues/61336, objects with unnamed bitfields aren't be

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a union has explicit initializers for some members, we shouldn't delete its default constructor. Fixes

[clang] c0dc8f7 - [Clang][Doc] Fix inconsistent links in release notes

Author: Roy Jacobson Date: 2023-03-11T18:39:33+02:00 New Revision: c0dc8f7a29e70fb69456517aa32db43d45f9a124 URL: https://github.com/llvm/llvm-project/commit/c0dc8f7a29e70fb69456517aa32db43d45f9a124 DIFF: https://github.com/llvm/llvm-project/commit/c0dc8f7a29e70fb69456517aa32db43d45f9a124.diff

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504372. sunshaoce added a comment. Fix the issue of failing in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files:

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:295-298 + if (getCurLambda()) { +Diag(SuperLoc, diag::err_super_in_lambda_unsupported); +return true; + } rsmith wrote: > Will this also reject `__super` in a local class

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce reopened this revision. sunshaoce added a comment. This revision is now accepted and ready to land. Sorry! My previous tests were not comprehensive enough, which resulted in failures in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 56cc0bb - Revert "[Flang] Allow compile *.f03, *.f08 file"

Author: Shao-Ce SUN Date: 2023-03-12T00:06:09+08:00 New Revision: 56cc0bbe41fd41fb0766062ca0975eba64e92447 URL: https://github.com/llvm/llvm-project/commit/56cc0bbe41fd41fb0766062ca0975eba64e92447 DIFF: https://github.com/llvm/llvm-project/commit/56cc0bbe41fd41fb0766062ca0975eba64e92447.diff

[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

ilammy created this revision. ilammy added reviewers: MaskRay, ianlevesque, dberris. ilammy added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ilammy requested review of this revision. Herald added a subscriber: cfe-commits. Codegen can handle XRay for

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

ilammy created this revision. ilammy added reviewers: MaskRay, ianlevesque, dberris. ilammy added a project: clang. Herald added a subscriber: arphaman. Herald added a project: All. ilammy requested review of this revision. Herald added a subscriber: cfe-commits. This option has undergone several

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

aaronpuchert added a comment. Herald added a subscriber: pcwang-thead. Herald added a project: All. Basically this should be Ok. We set the `LLVM_HOST_TRIPLE` to match the GCC triple on almost all platforms now. But we'll need to patch `isGNUEnvironment` like D110900

[PATCH] D145190: [memprof] Record BuildIDs in the raw profile.

tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145190/new/ https://reviews.llvm.org/D145190 ___ cfe-commits mailing list

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG171794de533b: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM

[clang] 171794d - [Flang] Allow compile *.f03, *.f08 file

Author: Shao-Ce SUN Date: 2023-03-11T23:23:21+08:00 New Revision: 171794de533b400edb47f0e6df4375a7ae052fc8 URL: https://github.com/llvm/llvm-project/commit/171794de533b400edb47f0e6df4375a7ae052fc8 DIFF: https://github.com/llvm/llvm-project/commit/171794de533b400edb47f0e6df4375a7ae052fc8.diff

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504363. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Sorry, I just missed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added inline comments. Comment at: flang/test/Driver/supported-suffices/f08-suffix.f08:4 +! CHECK: "{{.*}}flang-new" "-fc1" {{.*}} "/tmp/{{.*}}.o" +! CHECK: "{{.*}}ld" {{.*}} "/tmp/{{.*}}.o" +program f08 This line will not appear without

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504362. sunshaoce added a comment. Address @awarzynski's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504360. sunshaoce added a comment. Remove -flang-experimental-exec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added a comment. I'd move these tests to flang/test/Driver/supported-suffices. That would help documenting what these tests actual check for. Also, one could be tempted to test for other suffices and then it would be nice to keep them in one place. Ta! Comment at:

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added a comment. In D145845#4186608 , @clementval wrote: > In D145845#4186607 , @awarzynski > wrote: > >> Thanks! >> >> In D145845#4186590 , @clementval >>

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce added a comment. Before $ /home/sunshaoce/dev/llvm-project/build/bin/flang-new /home/sunshaoce/dev/llvm-project/build/temp.f03 -flang-experimental-exec -o temp.out -### flang-new version 17.0.0 (https://github.com/llvm/llvm-project.git 890e6c871d31dca9e461c01118cf25fb303b9cad)

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce updated this revision to Diff 504359. sunshaoce added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp flang/test/Driver/f03-suffix.f03

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

clementval added a comment. In D145845#4186607 , @awarzynski wrote: > Thanks! > > In D145845#4186590 , @clementval > wrote: > >> Thanks. Can you add tests in `flang/test/Driver`? > > Hm, this is a `clangDriver`

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

awarzynski added a comment. Thanks! In D145845#4186590 , @clementval wrote: > Thanks. Can you add tests in `flang/test/Driver`? Hm, this is a `clangDriver` change rather than anything Flang specific 樂 . Btw, how does

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

clementval added a comment. Thanks. Can you add tests in `flang/test/Driver`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 ___ cfe-commits mailing list

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone. Herald added a project: All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Fix issue #61260 Repository: rG

[PATCH] D145310: [clang-tidy] Make readability-container-data-pointer use header

This revision was automatically updated to reflect the committed changes. Closed by commit rGefda335bf5be: [clang-tidy] Make readability-container-data-pointer use string header (authored by mikecrowe, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] efda335 - [clang-tidy] Make readability-container-data-pointer use header

Author: Mike Crowe Date: 2023-03-11T13:59:42Z New Revision: efda335bf5be11b5ad4f94f3319d859563542553 URL: https://github.com/llvm/llvm-project/commit/efda335bf5be11b5ad4f94f3319d859563542553 DIFF: https://github.com/llvm/llvm-project/commit/efda335bf5be11b5ad4f94f3319d859563542553.diff LOG:

[PATCH] D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing

carlosgalvezp added a comment. Looks good, just a small comment! Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/slicing.cpp:102 + +struct BaseA { +virtual ~BaseA() {} Please briefly document this test case, i.e. why in this case this

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster added a comment. If this patch is accepted, I don't have commit access. If someone could commit as "Andrew Kaster " that would be much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145843/new/

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Projects can now add the following

[PATCH] D145833: Switch ABI references to env/environment

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. IIRC, "abi" used to be what Arm called, but "env" is equally good. And it it's consistent with `Triple.h`, even better. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

hazohelet created this revision. hazohelet added reviewers: tbaeder, aaron.ballman, cjdb. Herald added a reviewer: NoQ. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch checks whether `-Wunreachable-code-fallthrough` is enabled

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

owenpan added a comment. In D145642#4186462 , @rymiel wrote: > Could you please clarify what you mean by "regressions" here? Isn't the > behaviour of this syntax broken to begin with? It doesn't change anything > about lambdas without

[PATCH] D145841: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

rymiel added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine);

[PATCH] D145840: [Docs] Added -fomit-frame-pointer and -fno-omit-frame-pointer flag documentation

aabhinavg created this revision. aabhinavg added reviewers: MaskRay, vitalybuka, aheejin. Herald added a project: All. aabhinavg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #61322 Repository: rG LLVM Github Monorepo