[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce updated this revision to Diff 505363. sunshaoce added a comment. Address @MaskRay's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D145151: clang: Handle MatrixType in hasFloatingRepresentation

arsenm closed this revision. arsenm added a comment. ffe12e765cb9ba77dc30ccec89fb163234b98541 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145151/new/ https://reviews.llvm.org/D145151

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm closed this revision. arsenm added a comment. dd8181055494d8f973dfaaba282bb1ae6eab4d40 Comment at: clang/lib/CodeGen/CGCall.cpp:3052 +AI->addAttrs( +

[clang] dd81810 - clang: Emit nofpclass(nan inf) for -ffinite-math-only

Author: Matt Arsenault Date: 2023-03-15T01:13:08-04:00 New Revision: dd8181055494d8f973dfaaba282bb1ae6eab4d40 URL: https://github.com/llvm/llvm-project/commit/dd8181055494d8f973dfaaba282bb1ae6eab4d40 DIFF:

[clang] ffe12e7 - clang: Handle MatrixType in hasFloatingRepresentation

Author: Matt Arsenault Date: 2023-03-15T01:13:08-04:00 New Revision: ffe12e765cb9ba77dc30ccec89fb163234b98541 URL: https://github.com/llvm/llvm-project/commit/ffe12e765cb9ba77dc30ccec89fb163234b98541 DIFF:

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:390 - if (isa(ElemType.getTypePtr())) { + if (ElemType->isRecordType()) { const Record *R = BasePtr.getElemRecord(); aaron.ballman wrote: > The difference between these two is

[PATCH] D142617: [clang][Interp] Check This pointer without creating InterpFrame

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142617/new/ https://reviews.llvm.org/D142617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 15aa965 - [clang-tools-extra] Use *{Set,Map}::contains (NFC)

Author: Kazu Hirata Date: 2023-03-14T21:30:29-07:00 New Revision: 15aa965363df5cf3a021b3841bcafbced3756ea2 URL: https://github.com/llvm/llvm-project/commit/15aa965363df5cf3a021b3841bcafbced3756ea2 DIFF: https://github.com/llvm/llvm-project/commit/15aa965363df5cf3a021b3841bcafbced3756ea2.diff

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

shafik added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7364 ReadingKindTracker ReadingKind(Read_Decl, *this); + Deserializing D(this); Curious, why do we need this here and below. Comment at:

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. It should be "Plan Changed" instead of "Abandoned". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144844/new/ https://reviews.llvm.org/D144844

[PATCH] D145765: Add __builtin_set_flt_rounds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xiongji90 marked an inline comment as not done. Closed by commit rGb38aa2971711: Add __builtin_set_flt_rounds (authored by xiongji90). Changed prior to commit:

[clang] b38aa29 - Add __builtin_set_flt_rounds

Author: jinge90 Date: 2023-03-15T11:13:55+08:00 New Revision: b38aa297171134cee3fbec3c9e1e4d64b2ec3e22 URL: https://github.com/llvm/llvm-project/commit/b38aa297171134cee3fbec3c9e1e4d64b2ec3e22 DIFF: https://github.com/llvm/llvm-project/commit/b38aa297171134cee3fbec3c9e1e4d64b2ec3e22.diff LOG:

[clang] f3b9912 - [clang-offload-bundler] Fix error with regex in bundler test

Author: Jacob Lambert Date: 2023-03-14T19:51:26-07:00 New Revision: f3b9912026894ecca8925c974dd7ca16b0f1e265 URL: https://github.com/llvm/llvm-project/commit/f3b9912026894ecca8925c974dd7ca16b0f1e265 DIFF: https://github.com/llvm/llvm-project/commit/f3b9912026894ecca8925c974dd7ca16b0f1e265.diff

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Got your points. Let's postpone this one. But I want to emphasize that this patch (and the thin PCM) will decrease the performance. While LTO can save the regression, LTO is not widely used. (ThinLTO can only mitigate this.) I mean

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

owenpan added a comment. In D141098#4192785 , @mehdi_amini wrote: > In D141098#4111809 , @owenpan wrote: > >> Can we just fix the buildbot so that it runs git-clang-format with >> `--binary`? Using

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. In D145965#4194514 , @iains wrote: > In D145965#4192051 , @iains wrote: > >> > > > >> I was thinking at one stage to add an 'Implementation' module Kind, but at >> the moment I do not

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

owenpan added a comment. In D125171#4193996 , @jrmolin wrote: > In D125171#4167866 , @owenpan wrote: > >> Please see >> https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. >

[clang] ea9d404 - [clang] Use *{Set,Map}::contains (NFC)

Author: Kazu Hirata Date: 2023-03-14T19:17:18-07:00 New Revision: ea9d404032be1541e82e965bada82935629a98c8 URL: https://github.com/llvm/llvm-project/commit/ea9d404032be1541e82e965bada82935629a98c8 DIFF: https://github.com/llvm/llvm-project/commit/ea9d404032be1541e82e965bada82935629a98c8.diff

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

owenpan added a comment. > The previous implementation of the option involved a hack which corrupted the > parenthesis state stack. Can you link the review (e.g. `Dnn`) of the previous implementation in the summary? > Specifically, this change fixes github issues #55708, #53212, #52846

[clang] 65fb636 - [clang-offload-bundler] Fix test failures and document typo

Author: Jacob Lambert Date: 2023-03-14T19:14:42-07:00 New Revision: 65fb636bd462687980935979f2f36ec992e15c84 URL: https://github.com/llvm/llvm-project/commit/65fb636bd462687980935979f2f36ec992e15c84 DIFF: https://github.com/llvm/llvm-project/commit/65fb636bd462687980935979f2f36ec992e15c84.diff

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

owenpan added a comment. Please see https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. Is there a way to fix the issue without adding a new option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

dyung added a comment. In D145770#4195018 , @dyung wrote: > @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, > can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/37475 > > I don't know if it

[clang] 768211f - Mark test modified in e48ae0d as XFAIL for PS4/PS5 until the author can investigate.

Author: Douglas Yung Date: 2023-03-14T18:33:55-07:00 New Revision: 768211f48f2d52fdd555a07f3dae8fbf1def88cc URL: https://github.com/llvm/llvm-project/commit/768211f48f2d52fdd555a07f3dae8fbf1def88cc DIFF: https://github.com/llvm/llvm-project/commit/768211f48f2d52fdd555a07f3dae8fbf1def88cc.diff

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; jdoerfert wrote: > yaxunl

[PATCH] D146104: Use *{Map,Set}::contains (NFC)

kazu created this revision. Herald added subscribers: PiotrZSL, Moerafaat, zero9178, steakhal, bzcheeseman, ayermolo, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, martong, Joonsoo, liufengdb, aartbik, mgester,

[PATCH] D142490: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGc41be8fc741d: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c41be8f - [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

Author: Shafik Yaghmour Date: 2023-03-14T16:37:58-07:00 New Revision: c41be8fc741dec82e6c628d0cad742285be293f6 URL: https://github.com/llvm/llvm-project/commit/c41be8fc741dec82e6c628d0cad742285be293f6 DIFF:

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

dyung added a comment. @lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/37475 I don't know if it matters, but this bot only builds the x86_64 target. Repository: rG LLVM Github Monorepo

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/ClangFormatStyleOptions.rst:3540 + someMethod(someOtherMethod( +

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:2031 + /// }; + /// } + unsigned DesignatedInitializerIndentWidth;

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/ClangFormatStyleOptions.rst:1372 +.. _AlwaysBreakBeforeFunctionParameters: + +**AlwaysBreakBeforeFunctionParameters**

[clang] d4a4d0d - clang/test/Driver/clang-offload-bundler-standardize.c REQUIRES asserts. (fixup D145770)

Author: NAKAMURA Takumi Date: 2023-03-15T08:08:51+09:00 New Revision: d4a4d0d7912796aa02878e2cd51da4d1fe8ce930 URL: https://github.com/llvm/llvm-project/commit/d4a4d0d7912796aa02878e2cd51da4d1fe8ce930 DIFF:

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 ___ cfe-commits mailing list

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2704 + +**DesignatedInitializerIndentWidth** (``Unsigned``) + The number of columns to use to indent designated initializers that start on a new line. Perhaps it would be better

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 505302. jp4a50 added a comment. Apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 created this revision. Herald added a project: All. jp4a50 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The option allows users to specify how many columns to use to indent designated initializers that start on a new line.

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505293. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 505290. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 505288. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184 + SmallString<128> MultilibPath(SysRootDir); + llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME); + phosek wrote: > Rather than hardcoding the filename

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505286. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D143587: [Docs] Multilib design

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/docs/Multilib.rst:241 + +multilib.yaml and -print-multi-selection-flags-experimental are new interfaces +to Clang. In order for them to be usable over time and across LLVM versions

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 505284. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 505283. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Decouple multilib versioning scheme from the Clang version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 505279. michaelplatings marked an inline comment as done. michaelplatings added a comment. Calculate the output for -print-multi-lib lazily. This necessitated returning to using std::vector to store flags to avoid reordering them. In theory the big-O

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm updated this revision to Diff 505274. arsenm marked an inline comment as done. arsenm added a comment. Update doxygen comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:108 case llvm::Triple::aarch64: [[fallthrough]]; + case llvm::Triple::riscv64: Remove `[[fallthrough]]` and just list the 3 `case` consecutively. Comment

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; yaxunl wrote: >

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

rsmith added a comment. Please also update the P2448 row in cxx_status.html and add release notes. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9410-9421 +def ext_incorrect_defaulted_comparison_constexpr : Extension<

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 505264. jp4a50 added a comment. Add new code sample to demonstrate behaviour of "LambdaBodyIndentation: OuterScope" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t asb wrote: >

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, make sure all tests pass, this one seems to fail according to build kite: OpenMP/target_map_codegen_hold.cpp Comment at:

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6a789ef9bb2: Remove -lower-global-dtors-via-cxa-atexit flag (authored by yln). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e6a789e - Remove -lower-global-dtors-via-cxa-atexit flag

Author: Julian Lettner Date: 2023-03-14T14:18:11-07:00 New Revision: e6a789ef9bb28222c91816a2cf00cfd6f706efd4 URL: https://github.com/llvm/llvm-project/commit/e6a789ef9bb28222c91816a2cf00cfd6f706efd4 DIFF:

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe48ae0dbd80d: [clang-offload-bundler] Standardize TargetID field for bundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/

[clang] e48ae0d - [clang-offload-bundler] Standardize TargetID field for bundler

Author: Jacob Lambert Date: 2023-03-14T14:12:31-07:00 New Revision: e48ae0dbd80d58ce8eded9e55f0b1262d52517af URL: https://github.com/llvm/llvm-project/commit/e48ae0dbd80d58ce8eded9e55f0b1262d52517af DIFF: https://github.com/llvm/llvm-project/commit/e48ae0dbd80d58ce8eded9e55f0b1262d52517af.diff

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. nontrivial-unswitch-markloopasdeleted.ll failure looks legit. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1127 +if

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

tupos added a comment. Hi, sorry for the long delay, but actually in this particular moment I was working on addressing the comments. Therefore, I will push the updated patch soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm updated this revision to Diff 505253. arsenm marked an inline comment as done. arsenm added a comment. Drop unnecessary part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D142490: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

shafik added inline comments. Comment at: clang/test/SemaCXX/statements.cpp:60-61 +int i; +int j = ({i;}); // expected-error {{invalid use of non-static data member 'i'}} +// expected-error@-1 {{cannot initialize a member subobject of type 'int'

[PATCH] D142490: [Clang] Fix ClassifyImplicitMemberAccess to handle cases where the access in an unevaluated context is not within a CXXRecordDecl or CXXMethodDecl

shafik updated this revision to Diff 505252. shafik marked 2 inline comments as done. shafik added a comment. - Switched to using auto in two if statements - Added Release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142490/new/ https://reviews.llvm.org/D142490 Files:

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains added a comment. In D145965#4192051 , @iains wrote: > > I was thinking at one stage to add an 'Implementation' module Kind, but at > the moment I do not think it is worth extending the size of the ModuleKind > enum bit field for this (since

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. Prior to P2448R2 we were more aggressive in diagnosing ill-formed `constexpr` functions. Many of these

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper updated this revision to Diff 505249. craig.topper added a comment. Add a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089 Files: clang/lib/Sema/SemaStmtAttr.cpp

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

mysterymath added a comment. It looks like these tests don't pass when LLVM_ENABLE_LINKER_BUILD_ID is set; I've issued a revert until this can be fixed to unblock the Fuchsia toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/

[clang] d505d20 - Revert "[LLVM][OHOS] Clang toolchain and targets"

Author: Daniel Thornburgh Date: 2023-03-14T13:46:21-07:00 New Revision: d505d20a62f4838d8ecb9385af8b8ccce9db67da URL: https://github.com/llvm/llvm-project/commit/d505d20a62f4838d8ecb9385af8b8ccce9db67da DIFF:

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

yln added a comment. I will land this later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, erichkeane. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. It's possible for `getCalleeDecl()` to return a null pointer. This was encountered by a user of

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505243. francii added a comment. Wildcard check for `-l`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

dblaikie added a comment. In D144844#4193727 , @iains wrote: > In D144844#4193568 , @dblaikie > wrote: > >> Seem to recall @iains and others were concerned about the number of modules >> flags - this one I'd be

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1778-1780 + void setLambdaNumbering(Decl *ContextDecl, unsigned IndexInContext, + unsigned ManglingNumber, + unsigned DeviceManglingNumber,

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

w2yehia accepted this revision. w2yehia added a comment. This revision is now accepted and ready to land. LGTM. Would be nice to get @daltenty 's approval too. Comment at: clang/test/Driver/aix-ld.c:1094 +// CHECK-RELOCATABLE-NOT: "[[SYSROOT]]/usr/lib{{/|}}crti.o" +//

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith updated this revision to Diff 505240. rsmith marked 6 inline comments as done. rsmith added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145737/new/ https://reviews.llvm.org/D145737 Files:

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. Herald added a subscriber: ChuanqiXu. Hey, are you still planning to work on this? Otherwise, is it okay if I take over this patch to implement this feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 505227. lamb-j added a comment. Updating commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770 Files: clang/docs/ClangOffloadBundler.rst

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf47404b012d6: [clang][docs] Clarify the semantics of -fexceptions (authored by asb). Herald added a project: clang. Repository: rG LLVM Github

[clang] f47404b - [clang][docs] Clarify the semantics of -fexceptions

Author: Alex Bradbury Date: 2023-03-14T19:52:32Z New Revision: f47404b012d66ed0b411a2b3742931a14e85c80b URL: https://github.com/llvm/llvm-project/commit/f47404b012d66ed0b411a2b3742931a14e85c80b DIFF: https://github.com/llvm/llvm-project/commit/f47404b012d66ed0b411a2b3742931a14e85c80b.diff

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

efriedma added a comment. Looks fine from a codegen perspective, assuming these are the semantics we want for -ffinite-math-only. Comment at: clang/lib/CodeGen/CGCall.cpp:3052 +AI->addAttrs( +llvm::AttrBuilder(getLLVMContext()).addNoFPClassAttr(Mask)); +

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Please update the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145770/new/ https://reviews.llvm.org/D145770

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505221. francii added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

aaron.ballman added a comment. In D129689#4194096 , @SebastianPerta wrote: > @cor3ntin can I close it? You can abandon this PR, it was handled by 0fecac18ffad476b5a4682770f6d8b1f0f176b40

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193172 , @junaire wrote: > I'm not certain if it's bad to say 'sorry', IMHO it's fine? > > Anyway, you can't just simply delete those words (in diagnostic messages and > regression tests), that doesn't work. To

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

aaron.ballman added a comment. Thank you for working on this Richard, that is a pretty subtle issue! I'm still wrapping my head around the changes (which mostly look reasonable to me), but I did have a few questions I ran into. Comment at:

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D145851#4194154 , @royjacobson wrote: > Fix the codegen test, add a standard ref to the comment. No worries, there is definitely somewhat

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193045 , @DavidSpickett wrote: > Is there some standard for writing warning messages? For llvm that is, it > would be worth looking through the getting started guides to see. I think the > majority of warnings

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

erichkeane added inline comments. Comment at: clang/test/CodeGen/union-non-trivial-member.cpp:23 + +// CHECK: define dso_local void @_Z1fv() {{.*}} { +// CHECK-NEXT: entry: Comment at: clang/test/CodeGen/union-non-trivial-member.cpp:24

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson marked 2 inline comments as done. royjacobson added inline comments. Comment at: clang/test/CodeGen/union-non-trivial-member.cpp:30 +// CHECK-NEXT: +// CHECK-NEXT: define linkonce_odr dso_local void @_ZN2UnionIntC2Ev(ptr noundef nonnull align 4 dereferenceable(4)

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4192816 , @mehdi_amini wrote: > You should look into the title and description of the commit: > https://cbea.ms/git-commit/ Is the title and description appropriate now? I can add more details to the

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson added a comment. Oops, sorry for the bad codegen test and thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 ___ cfe-commits

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

royjacobson updated this revision to Diff 505216. royjacobson added a comment. Fix the codegen test, add a standard ref to the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145851/new/ https://reviews.llvm.org/D145851 Files:

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/new/ https://reviews.llvm.org/D145564 ___ cfe-commits mailing list

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 505215. jrmolin marked 3 inline comments as done. jrmolin added a comment. respond to code review requests/comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. The description needs to be rewritten to elucidate that this is purely to support old versions of the GNU assembler still in use by various Linux LTS distros.

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

asb accepted this revision. asb added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

SebastianPerta added a comment. @cor3ntin can I close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4344 + (Record->hasTrivialDestructor() || + Record->hasConstexprDestructor()); } For the purposes of CodeGen, checking `Record->hasConstexprDestructor()`

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked 4 inline comments as done. jrmolin added inline comments. Comment at: clang/include/clang/Format/Format.h:827 + /// \code + /// someFunction( + /// int argument1, HazardyKnusperkeks wrote: > That's not a valid declaration (missing

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

efriedma added inline comments. Comment at: clang/test/CodeGenCXX/static-init.cpp:181 +#if __cplusplus >= 202002L +// A const object with constexpr destructor can be emitted as a constant. +namespace test5 { I don't see how this works. For a static local

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. In D125171#4167866 , @owenpan wrote: > Please see > https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. I am doing this for my team, which writes the security endpoint for Elastic Defend.

  1   2   3   >