[PATCH] D148387: remove Demangle/StringView.h

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148387/new/ https://reviews.llvm.org/D148387

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148556/new/ https://reviews.llvm.org/D148556

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148751/new/ https://reviews.llvm.org/D148751 ___ cfe-commits mailing list

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

ikudrin updated this revision to Diff 515215. ikudrin marked an inline comment as done. ikudrin added a comment. - `WIN32` -> `MSVC` Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148751/new/ https://reviews.llvm.org/D148751 Files: clang/CMakeLists.txt Index:

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

mstorsjo added inline comments. Comment at: clang/CMakeLists.txt:616 -DDYLD_LIBRARY_PATH=${LLVM_LIBRARY_OUTPUT_INTDIR}) -elseif(NOT WIN32) +elseif(WIN32) + add_dependencies(clang-bootstrap-deps llvm-lib) I think I’d prefer to have the

[PATCH] D148779: [Sema] Fix spurious warning for printf("%lb", (long)10)

MaskRay updated this revision to Diff 515205. MaskRay added a comment. update test/Sema/format-strings-fixit.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148779/new/ https://reviews.llvm.org/D148779 Files: clang/lib/AST/FormatString.cpp

[PATCH] D148779: [Sema] Fix spurious warning for printf("%lb", (long)10)

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, dim, enh. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/62247 D131057

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

owenpan added a comment. In D148777#4282574 , @rymiel wrote: > (looks like you linked the same issue twice in the summary) Thanks. Fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148777/new/

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

rymiel added a comment. (looks like you linked the same issue twice in the summary) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148777/new/ https://reviews.llvm.org/D148777 ___ cfe-commits mailing

[PATCH] D148777: [clang-format] Hanlde leading whitespaces for JSON files

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Fixes https://github.com/llvm/llvm-project/issues/62228 and

[PATCH] D147989: [clang] Fix Attribute Placement

ipriyanshi1708 updated this revision to Diff 515196. ipriyanshi1708 marked an inline comment as done. ipriyanshi1708 added a comment. Updated the logic in a better way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147989/new/

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai updated this revision to Diff 515194. vsapsai added a comment. Don't touch HeaderSearch.cpp as the actual change in header search will be a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148776/new/

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:358-373 +#if ALLOW_SUBDIRECTORY_MODULE_MAP_SEARCH // If we've already performed the exhaustive search for module maps in this // search directory, don't do it again. if

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai created this revision. vsapsai added reviewers: EricWF, aprantl, chapuni. Herald added subscribers: ributzka, s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a reviewer: deadalnix. Herald added a project: All. vsapsai requested review of this revision. Herald added

[PATCH] D148383: [driver] Enable response file when using lld on baremetal targets

phosek abandoned this revision. phosek added a comment. Addressed by D148760 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148383/new/ https://reviews.llvm.org/D148383

[PATCH] D148760: [Driver] Support response file on baremetal driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG038536acaf27: [Driver] Support response file on baremetal driver (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 038536a - [Driver] Support response file on baremetal driver

Author: Petr Hosek Date: 2023-04-20T02:45:26Z New Revision: 038536acaf271cb614fd2248becf1cc2c5e700c7 URL: https://github.com/llvm/llvm-project/commit/038536acaf271cb614fd2248becf1cc2c5e700c7 DIFF: https://github.com/llvm/llvm-project/commit/038536acaf271cb614fd2248becf1cc2c5e700c7.diff LOG:

[PATCH] D148763: [Driver] Support response file in Fuchsia driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba3a2280398: [Driver] Support response file in Fuchsia driver (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 9ba3a22 - [Driver] Support response file in Fuchsia driver

Author: Petr Hosek Date: 2023-04-20T02:44:40Z New Revision: 9ba3a22803980c1b32aa4371d87fff4d144ff3d0 URL: https://github.com/llvm/llvm-project/commit/9ba3a22803980c1b32aa4371d87fff4d144ff3d0 DIFF: https://github.com/llvm/llvm-project/commit/9ba3a22803980c1b32aa4371d87fff4d144ff3d0.diff LOG:

[PATCH] D148617: [RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f81d25cee70: [RISCV] Remove sx when parsing arch string to match the latest ISA manual (authored by joshua-arch1). Herald added a project: clang.

[clang] 3f81d25 - [RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual

Author: Jun Sha (Joshua) Date: 2023-04-20T10:32:24+08:00 New Revision: 3f81d25cee7065a4a7888bbe9ad7138081dcd4cf URL: https://github.com/llvm/llvm-project/commit/3f81d25cee7065a4a7888bbe9ad7138081dcd4cf DIFF:

[clang] 914b38a - Revert '[RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual'

Author: Jun Sha (Joshua) Date: 2023-04-20T10:27:02+08:00 New Revision: 914b38aa4b9afe5001b0e3d5bc5125af0a5529f2 URL: https://github.com/llvm/llvm-project/commit/914b38aa4b9afe5001b0e3d5bc5125af0a5529f2 DIFF:

[clang] fbc63e5 - [RISCV] Remove 'sx' when parsing arch string to match the latest ISA manual

Author: Jun Sha (Joshua) Date: 2023-04-20T10:19:14+08:00 New Revision: fbc63e5658f67036d4ea57940459074d9ecdd2d8 URL: https://github.com/llvm/llvm-project/commit/fbc63e5658f67036d4ea57940459074d9ecdd2d8 DIFF:

[Diffusion] rG46f5aaa82ca6: [Bazel] Introduce "//clang:bundle_resources" for D146591

chapuni added a comment. I missed the failure since I am using newer version of bazel. BRANCHES main /utils/bazel/llvm-project-overlay/clang/BUILD.bazel:861 It should be moved into "dats" Users: chapuni (Author) https://reviews.llvm.org/rG46f5aaa82ca6

[Diffusion] rG46f5aaa82ca6: [Bazel] Introduce "//clang:bundle_resources" for D146591

chapuni added a subscriber: cfe-commits. chapuni added a comment. Seems this doesn't satisfy buildkite. Could anyone rework? BRANCHES main Users: chapuni (Author) https://reviews.llvm.org/rG46f5aaa82ca6 ___ cfe-commits mailing list

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay updated this revision to Diff 515166. MaskRay added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148665/new/ https://reviews.llvm.org/D148665 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D148573: Allow -fsanitize=function on all targets

MaskRay updated this revision to Diff 515161. MaskRay retitled this revision from "Port -fsanitize=function to AArch64" to "Allow -fsanitize=function on all targets". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: kadircet, ilya-biryukov. allow

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

MaskRay updated this revision to Diff 515157. MaskRay edited the summary of this revision. MaskRay added a comment. remove an assert to make this feature available to all targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148665/new/

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT/VT

chapuni created this revision. Herald added subscribers: luke, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, ormris, foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, atanasyan,

[PATCH] D148767: Restore MVT and LLT into llvm/CodeGen

chapuni updated this revision to Diff 515152. chapuni edited the summary of this revision. chapuni added a comment. - Isolate rename changes to D148768 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/

[clang] de27291 - Add missing header guards so the modules build will succeed.

Author: Jim Ingham Date: 2023-04-19T17:24:11-07:00 New Revision: de27291e25f7398b0b36c0f388eaf272b2b54e37 URL: https://github.com/llvm/llvm-project/commit/de27291e25f7398b0b36c0f388eaf272b2b54e37 DIFF: https://github.com/llvm/llvm-project/commit/de27291e25f7398b0b36c0f388eaf272b2b54e37.diff

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1478 + + struct CallableFinderCallback : MatchFinder::MatchCallback { +UnsafeBufferUsageHandler I think this entire matcher business can easily live in

[PATCH] D148757: [clang] Follow user-provided order for prefix map

gulfem added a comment. In D148757#4282002 , @MaskRay wrote: > Can you add example options in the description and say how this patch is > going to change it? > > I think `std::map` is intended so that for `-f*-prefix-map` values, if both > `a/b=...`

[PATCH] D148763: [Driver] Support response file in Fuchsia driver

phosek created this revision. phosek added reviewers: abrachet, mcgrathr. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. All officially supported linkers should support response files and this

[PATCH] D148383: [driver] Enable response file when using lld on baremetal targets

phosek added a comment. I think we can enable the use of response files unconditionally since it should be supported by all officially supported linkers. This matches the logic used by other driver classes such as `Gnu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148760: [Driver] Support response file on baremetal driver

phosek created this revision. phosek added reviewers: abrachet, mcgrathr. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. All officially supported linkers should support response files and this

[clang] 9516419 - Revert "Revert "[-Wunsafe-buffer-usage] Handle unevaluated contexts that contain unsafe buffer usages""

Author: MalavikaSamak Date: 2023-04-19T16:53:34-07:00 New Revision: 9516419c50a9bb318fdde626716823e14a5fee71 URL: https://github.com/llvm/llvm-project/commit/9516419c50a9bb318fdde626716823e14a5fee71 DIFF: https://github.com/llvm/llvm-project/commit/9516419c50a9bb318fdde626716823e14a5fee71.diff

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

MaskRay added a comment. I hope that we add just one option, instead of aliases. Aliases are usually added for compatibility when something is deprecated or changed, not for new options. My "Request Changes" status still holds. The patch hasn't fixed something obvious: the description

[PATCH] D148757: [clang] Follow user-provided order for prefix map

MaskRay added a comment. Can you add example options in the description and say how this patch is going to change it? I think `std::map` is intended so that for `-f*-prefix-map` values, if both `a/b=...` and `a/b/c=...` match an input path, the longest wins, not the latest wins. Repository:

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav marked 2 inline comments as done. chaitanyav added a comment. @aaron.ballman I have made more changes so that the warning is emitted on other integer expressions where the opertors has higher precedence than conditional operator. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav updated this revision to Diff 515130. chaitanyav added a comment. Emit warning when implicit cast from int to bool in an conditional operator expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/

[PATCH] D148757: [clang] Follow user-provided order for prefix map

gulfem created this revision. Herald added a project: All. gulfem requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch uses llvm::MapVector instead of std::map to ensure that iteration order is the insertion order for file prefix

[PATCH] D148573: Port -fsanitize=function to AArch64

MaskRay added a comment. In D148573#4280335 , @peter.smith wrote: > With moving the signature before the function entry this looks good to me. > I'm not so familiar with the code in https://reviews.llvm.org/D148665 would > ideally find someone a bit

[clang] 7bf5f46 - Revert "[-Wunsafe-buffer-usage] Handle unevaluated contexts that contain unsafe buffer usages"

Author: MalavikaSamak Date: 2023-04-19T16:09:21-07:00 New Revision: 7bf5f4692ad6f9ba2d5c155f6b630049bb59876f URL: https://github.com/llvm/llvm-project/commit/7bf5f4692ad6f9ba2d5c155f6b630049bb59876f DIFF: https://github.com/llvm/llvm-project/commit/7bf5f4692ad6f9ba2d5c155f6b630049bb59876f.diff

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

isuckatcs added a comment. > No because indirectly_recursive called from recursion_helper is noexcept, so > there will be std::terminate called. I missed that in `noexcept` functions thrown exceptions are not propagated. In this case I agree that `recursion_helper()` shouldn't emit a warning.

[PATCH] D144905: [-Wunsafe-buffer-usage] Handle unevaluated contexts that contain unsafe buffer usages

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG777eb4bcfc32: [-Wunsafe-buffer-usage] Handle unevaluated contexts that contain unsafe buffer… (authored by malavikasamak). Herald added a project:

[clang] 777eb4b - [-Wunsafe-buffer-usage] Handle unevaluated contexts that contain unsafe buffer usages

Author: MalavikaSamak Date: 2023-04-19T15:53:21-07:00 New Revision: 777eb4bcfc3265359edb7c979d3e5ac699ad4641 URL: https://github.com/llvm/llvm-project/commit/777eb4bcfc3265359edb7c979d3e5ac699ad4641 DIFF: https://github.com/llvm/llvm-project/commit/777eb4bcfc3265359edb7c979d3e5ac699ad4641.diff

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 515110. NoQ added a comment. Before I forget: Update tests that didn't fail due to my patch because they were testing absence of things (warnings or fixits) and my patch only made them more absent. They need to keep testing absence of these things even when the

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. this regresses clang/test/Headers/mm_malloc.c (added here ) because we now don't run instcombine before the inliner, and we lose return value alignment info when inlining. perhaps this is still a tradeoff worth making Repository:

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. Here are reduced cases. I didn't bother bisecting flags, but the test case is quite small F27199288: clang-crashreports.zip struct a {}; struct b { struct b *c; struct b *d; }; _Bool e; inline void g(struct b *p1)

[PATCH] D148751: [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

ikudrin created this revision. ikudrin added reviewers: smeenai, mstorsjo, phosek, beanz. ikudrin added a project: LLVM. Herald added subscribers: ekilmer, inglorion. Herald added a project: All. ikudrin requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. Yeah. To be clear, though, I'm not asking for the overall data flow of the function to be fixed in this patch; I'm just pointing out problems in the new logic being added by

[PATCH] D146595: [clang] Add "debug_trampoline" attribute

aprantl added a comment. In D146595#4278361 , @dblaikie wrote: > In D146595#4235340 , @augusto2112 > wrote: > >> In D146595#4235333 , @aprantl >> wrote: >> >>> I hope

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality is under the added flag so not expecting any surprises. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. Yeah, things appear to work for the current version of this diff (including GH62110). However, while doing some internal testing I've discovered one suspicious issue (sigh, sigh), but haven't been able to create a standalone repro yet. Need more time for

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:6558 HelpText<"Path to the IR file produced by the frontend for the host.">, - Flags<[CC1Option, NoDriverOption]>; + Flags<[CC1Option, FC1Option, NoDriverOption]>; With

[PATCH] D148369: [DependencyScanning] Canonicalize `CodeGenOptions.RelaxAll`

akyrtzi updated this revision to Diff 515085. akyrtzi added a comment. Rebase on top of `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148369/new/ https://reviews.llvm.org/D148369 Files:

[PATCH] D148387: remove Demangle/StringView.h

MaskRay accepted this revision. MaskRay added a comment. LGTM, but this can only be accepted from a member of #libc_abi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148387/new/

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

nickdesaulniers updated this revision to Diff 515083. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - use @Maskray's recommended commit description, thanks @Maskray! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

MaskRay added a comment. A member from #libc_abi needs to review this as well to make this differential green :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148556/new/ https://reviews.llvm.org/D148556

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

shafik added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1381 +if (Capture.Id == TP->getIdentifier()) { + Diag(Capture.Loc, diag::err_template_param_shadow) << Capture.Id; + Diag(TP->getLocation(), diag::note_template_param_here);

[PATCH] D148556: [libcxxabi][demangle] create helper for std::string_view::starts_with

MaskRay accepted this revision. MaskRay added a comment. > This was added to ADT in https://reviews.llvm.org/D148367 then reverted in > https://reviews.llvm.org/D148547 because it was a layering violation pointed > out in https://reviews.llvm.org/D148384#4270356. This description requires

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay added a comment. In my C# project, these settings give me just what we tend to use. BreakBeforeBraces: Custom BraceWrapping: AfterFunction: true AfterCSharpProperty: true AllowShortCSharpPropertiesOnASingleLine: false AlwaysBreakBetweenShortCSharpProperties: false

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

chaitanyav added a comment. In D147844#4281288 , @aaron.ballman wrote: > In D147844#4278384 , @chaitanyav > wrote: > >> @aaron.ballman am looking into this. If i change it back to >> `operation int();` >> and

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515068. MyDeveloperDay added a comment. Sorry had a clang-format reflow comments moment, revert the unrelated comment changes simplify the if's a little CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148467/new/

[PATCH] D146987: [Assignment Tracking] Enable by default

MaskRay added a comment. In D146987#4281068 , @Orlando wrote: >> I think we may have an issue due to this. I'm basing that on the blamelist, >> but I'm still bisecting our build, which may take some time to confirm. Can >> you take a look, and revert

[PATCH] D148671: [Driver] Make -fsanitize=kcfi,function incompatible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadbdef6a9f39: [Driver] Make -fsanitize=kcfi,function incompatible (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] adbdef6 - [Driver] Make -fsanitize=kcfi, function incompatible

Author: Fangrui Song Date: 2023-04-19T13:15:33-07:00 New Revision: adbdef6a9f39058f390ba285624b0dfb24bad7e8 URL: https://github.com/llvm/llvm-project/commit/adbdef6a9f39058f390ba285624b0dfb24bad7e8 DIFF: https://github.com/llvm/llvm-project/commit/adbdef6a9f39058f390ba285624b0dfb24bad7e8.diff

[PATCH] D148671: [Driver] Make -fsanitize=kcfi,function incompatible

MaskRay updated this revision to Diff 515063. MaskRay edited the summary of this revision. MaskRay added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148671/new/ https://reviews.llvm.org/D148671 Files:

[PATCH] D148467: [clang-format] Add a new AfterCSharpProperty to BraceWrapping

MyDeveloperDay updated this revision to Diff 515060. MyDeveloperDay added a comment. Adds additional options to give us much greater control over how we format C# properties especially auto properties (Submitting this for safe keeping, I need to try and minimize the if expression, I'm sure it

[clang] e67493f - [Driver] -fsanitize=kcfi doesn't need RequiresPIE

Author: Fangrui Song Date: 2023-04-19T13:10:46-07:00 New Revision: e67493f57262862ae2bd4fc5d1d1f552676d815f URL: https://github.com/llvm/llvm-project/commit/e67493f57262862ae2bd4fc5d1d1f552676d815f DIFF: https://github.com/llvm/llvm-project/commit/e67493f57262862ae2bd4fc5d1d1f552676d815f.diff

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1368 + // C++: expr.prim.lambda.capture p5: + // If an identifier in a capture appears as the declarator-id of a parameter Comment at:

[libunwind] ba9b2cd - [libunwind] [SEH] Add debug logging in __libunwind_seh_personality

Author: Martin Storsjö Date: 2023-04-19T23:05:48+03:00 New Revision: ba9b2cdb9c00f68f1759386fdafc2285e0227357 URL: https://github.com/llvm/llvm-project/commit/ba9b2cdb9c00f68f1759386fdafc2285e0227357 DIFF:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG782c59a4eef0: [OpenMP] Prefix outlined and reduction func names with original funcs name (authored by nextsilicon-itay-bookstein). Repository: rG

[clang] da89ed9 - [cmake] Explicitly disable download step

Author: Vitaly Buka Date: 2023-04-19T12:57:12-07:00 New Revision: da89ed99a16920e5986b14853d297322ccf7109e URL: https://github.com/llvm/llvm-project/commit/da89ed99a16920e5986b14853d297322ccf7109e DIFF: https://github.com/llvm/llvm-project/commit/da89ed99a16920e5986b14853d297322ccf7109e.diff

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman updated this revision to Diff 515050. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148601/new/ https://reviews.llvm.org/D148601 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Frontend/VerifyDiagnosticConsumer.cpp Index:

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

shafik added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.lambda/expr.prim.lambda.capture/p5.cpp:7 + // expected-note {{variable 'x' is explicitly captured here}} + auto h = [y = 0](y) { return 0; }; //

[PATCH] D147844: Emit warning when implicit cast to bool happens in an conditional operator expression when used inside an overloaded shift operator expression

aaron.ballman added a comment. In D147844#4278384 , @chaitanyav wrote: > @aaron.ballman am looking into this. If i change it back to > `operation int();` > and add > `Stream& operator<<(bool)` > i get > ` > error: 'warning' diagnostics expected but

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

PiotrZSL added a comment. Overall looks good, didn't found any bugs, just some potential improvements. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlCheck.cpp:23 +void AvoidEndlCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( +

[PATCH] D148696: [clang][Sema][NFC] Sprinkle some const around in Sema

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Changes generally LGTM though I spotted a few places where we might as well update to `auto` and one place where I think a `const` was missed. Comment at:

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4274763 , @cjdb wrote: > I think we should fundamentally rethink this entire category of diagnostic. > Rather than having a static diagnostic per offence stating //what// happened, > we should instead have a

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 added a comment. Well first of all thanks for the feedback. I agree not renaming a check which is already used and splitting each special case into it's own check seems like the easier and better way to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

erichkeane added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.lambda/expr.prim.lambda.capture/p5.cpp:7 + // expected-note {{variable 'x' is explicitly captured here}} + auto h = [y = 0](y) { return 0; }; //

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.lambda/expr.prim.lambda.capture/p5.cpp:7 + // expected-note {{variable 'x' is explicitly captured here}} + auto h = [y = 0](y) { return 0; }; //

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:751 +// Keywords defined by Attr.td. +#define KEYWORD_ATTRIBUTE(X) KEYWORD(X, KEYALL) +#include "clang/Basic/AttrTokenKinds.inc"

[PATCH] D148577: [CMake] Switch back to -fPIC for Fuchsia Toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37a6218f8a0: [CMake] Switch back to -fPIC for Fuchsia Toolchain (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148577/new/

[clang] a37a621 - [CMake] Switch back to -fPIC for Fuchsia Toolchain

Author: Daniel Thornburgh Date: 2023-04-19T11:48:38-07:00 New Revision: a37a6218f8a029093cc439928d5cce67ccf133de URL: https://github.com/llvm/llvm-project/commit/a37a6218f8a029093cc439928d5cce67ccf133de DIFF:

[PATCH] D148700: [clang] Add support for “regular” keyword attributes

rsandifo-arm updated this revision to Diff 515033. rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Add #ifndef guard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148700/new/ https://reviews.llvm.org/D148700 Files:

[clang-tools-extra] d2535be - [pseudo] Use shared copy of bundle_resources.py

Author: Sam McCall Date: 2023-04-19T20:38:36+02:00 New Revision: d2535bed2a7dabc4b3e45d717681a6e5eaf40c87 URL: https://github.com/llvm/llvm-project/commit/d2535bed2a7dabc4b3e45d717681a6e5eaf40c87 DIFF: https://github.com/llvm/llvm-project/commit/d2535bed2a7dabc4b3e45d717681a6e5eaf40c87.diff

[PATCH] D148330: [clang] Do not crash on undefined template partial specialization

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaCXXScopeSpec.cpp:134 "specifier in SFINAE context?"); -if (!hasReachableDefinition(PartialSpec)) +if (PartialSpec->hasDefinition() && +

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

shafik added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.lambda/expr.prim.lambda.capture/p5.cpp:7 + // expected-note {{variable 'x' is explicitly captured here}} + auto h = [y = 0](y) { return 0; }; //

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added inline comments. Comment at: clang/utils/bundle_resources.py:6 +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10307 CXXCastPath Path; CheckPointerConversion(RHS.get(), LHSType, Kind, Path, /*IgnoreBaseAccess=*/false, Diagnose); erichkeane wrote: >

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > I think we may have an issue due to this. I'm basing that on the blamelist, > but I'm still bisecting our build, which may take some time to confirm. Can > you take a look, and revert if it's not a quick fix? That looks related to assignment tracking to me. I'm

[clang] a65ca45 - Revert D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-19T19:16:40+01:00 New Revision: a65ca4546b9ee042d6c40149d3f820893edbd766 URL: https://github.com/llvm/llvm-project/commit/a65ca4546b9ee042d6c40149d3f820893edbd766 DIFF: https://github.com/llvm/llvm-project/commit/a65ca4546b9ee042d6c40149d3f820893edbd766.diff LOG:

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein updated this revision to Diff 515025. nextsilicon-itay-bookstein edited the summary of this revision. nextsilicon-itay-bookstein added a comment. Updated a couple of tests that were introduced in the interim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein reopened this revision. nextsilicon-itay-bookstein marked 2 inline comments as done. nextsilicon-itay-bookstein added a comment. This revision is now accepted and ready to land. Reopening due to revert, will update with a fixed patch Repository: rG LLVM Github

[PATCH] D148730: [C11] Allow initialization of an atomic-qualified pointer from a null pointer constant

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10307 CXXCastPath Path; CheckPointerConversion(RHS.get(), LHSType, Kind, Path, /*IgnoreBaseAccess=*/false, Diagnose); Does the LHSType here need

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

thakis added inline comments. Comment at: clang/utils/bundle_resources.py:6 +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. Sorry, I missed that this was already reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list

  1   2   >