[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. I disagree. Being experimental doesn't mean you should do the wrong thing. Reusing std call in the frontend is ugly, pollutes non-m68k code paths (doing your own thing _avoids_ that

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e accepted this revision. 0x59616e added a comment. This revision is now accepted and ready to land. Though creating our own calling convention is better, I think Min's path is correct at this moment given that m68k is still an experimental target. We can reignite this discussion once

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added inline comments. Comment at: clang/test/Driver/target-as.s:1 // Make sure the -march is passed down to cc1as. // RUN: %clang -target i386-unknown-freebsd -### -c -integrated-as %s \ MaskRay wrote: > aix-as.c will be more appropriate. Do you mean

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

marginstrawberries added a comment. Herald added a subscriber: pcwang-thead. In D128059#3640424 , @cor3ntin wrote: > @aaron.ballman Thanks for the review. I landed the changes and got a bunch of > bots screaming at me for changes that are completely

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

galenelias added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:790 + +**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ ` + Style of aligning consecutive short case labels.

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. Can someone please let me know the following changes that I did in my latest patch? 1. clang/test/OpenMP/generic_loop_ast_print.cpp is failing because of the mapped directives. It is because of –ast-print & -ast-dump. This is because when the Sema comes across "omp loop

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/keep-static-variables.cpp:1 +// RUN: %clang_cc1 -fkeep-static-variables -emit-llvm %s -o - -triple=x86_64-unknown-linux-gnu | FileCheck %s --check-prefixes=CHECK,CHECK-ELF +// RUN: %clang_cc1

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2201-2210 + if ((CodeGenOpts.KeepStaticConsts || CodeGenOpts.KeepStaticVariables) && D && + isa(D)) { const auto *VD = cast(D); -if (VD->getType().isConstQualified() && -

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added a comment. Can you add a test case for the change? Looks like there's something similar already in `clang/test/Frontend/absolute-paths.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1925 if (This && IsMemberCall) { -APValue Val; -This->moveInto(Val); -Val.printPretty(Out, Info.Ctx, -This->Designator.MostDerivedType); -// FIXME: Add parens around

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Could you add a test case for the inverted order of attributes on a template as well? I don't think that there is a test case for that. CHANGES SINCE LAST ACTION

[PATCH] D146664: Apply the same fallbacks as runtimes search for stdlib search

glandium added a comment. In D146664#4352695 , @thakis wrote: > Is it possible to test this? I don't know how. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146664/new/ https://reviews.llvm.org/D146664

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 527261. keith added a comment. Improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir accepted this revision. Amir added a comment. Thanks. Will update the dependencies, removing always-installed symlinks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

ravikandhadai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:623 +def err_drv_darwin_sdk_missing_arclite : Error< + "SDK does not contain 'libarclite' at the path '%0'. This likely means you need to increase your minimum deployment

[clang] bf8fe1c - Fix clang driver tests for cspgo in lld

Author: Ellis Hoag Date: 2023-05-31T18:21:41-07:00 New Revision: bf8fe1c38f1031c88c80e0e86ffea4375e7693ff URL: https://github.com/llvm/llvm-project/commit/bf8fe1c38f1031c88c80e0e86ffea4375e7693ff DIFF: https://github.com/llvm/llvm-project/commit/bf8fe1c38f1031c88c80e0e86ffea4375e7693ff.diff

[clang] 85af42d - [lld] add context-sensitive PGO options for MachO

Author: Ellis Hoag Date: 2023-05-31T17:53:46-07:00 New Revision: 85af42df5dbb964d767feb16a5551dddb36fd4f1 URL: https://github.com/llvm/llvm-project/commit/85af42df5dbb964d767feb16a5551dddb36fd4f1 DIFF: https://github.com/llvm/llvm-project/commit/85af42df5dbb964d767feb16a5551dddb36fd4f1.diff

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85af42df5dbb: [lld] add context-sensitive PGO options for MachO (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

phosek marked 2 inline comments as done. phosek added inline comments. Comment at: bolt/test/CMakeLists.txt:40 llvm-bolt - llvm-boltdiff llvm-bolt-heatmap Amir wrote: > We have a number of dependencies on llvm-boltdiff and perf2bolt, e.g. in > internal

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

phosek updated this revision to Diff 527243. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 Files: bolt/CMakeLists.txt bolt/cmake/modules/AddBOLT.cmake bolt/test/CMakeLists.txt

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527241. fahadnayyar added a comment. Passing -L /bin/../lib/ unconditionally to the linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files:

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-libs.c:27 // // Check that we extract a static library defining an undefined symbol. // tra wrote: > jhuber6 wrote: > > tra wrote: > > > How does this test test the functionality of

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

jhuber6 updated this revision to Diff 527240. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151839/new/ https://reviews.llvm.org/D151839 Files: clang/test/Driver/linker-wrapper-libs.c

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? +

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4381758 , @rjmccall wrote: > The process is pretty lightweight; I'd recommend just doing it if you expect > to make more than one patch. But we don't have a policy against committing > patches for other people as

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes some

[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch

[PATCH] D151853: [clang] NFCI: Split `HeaderSearch::findAllModulesForHeader()`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This mimics the

[PATCH] D151852: [clang] NFCI: Use `FileEntryRef` in `ModuleMapCallbacks`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes path

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

tra added inline comments. Comment at: clang/test/Driver/linker-wrapper-libs.c:27 // // Check that we extract a static library defining an undefined symbol. // jhuber6 wrote: > tra wrote: > > How does this test test the functionality of the undefined symbol?

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir added inline comments. Comment at: bolt/test/CMakeLists.txt:40 llvm-bolt - llvm-boltdiff llvm-bolt-heatmap We have a number of dependencies on llvm-boltdiff and perf2bolt, e.g. in internal and upstream binary tests:

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-libs.c:27 // // Check that we extract a static library defining an undefined symbol. // tra wrote: > How does this test test the functionality of the undefined symbol? E.g. how >

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

tra added a comment. LGTM in general. Comment at: clang/test/Driver/linker-wrapper-libs.c:27 // // Check that we extract a static library defining an undefined symbol. // How does this test test the functionality of the undefined symbol? E.g. how does it

[clang] 0038d6c - [clang] NFCI: Use `DirectoryEntryRef` in framework lookup

Author: Jan Svoboda Date: 2023-05-31T16:04:46-07:00 New Revision: 0038d6c7fe75a9f45076a347e4fd9b1f59051899 URL: https://github.com/llvm/llvm-project/commit/0038d6c7fe75a9f45076a347e4fd9b1f59051899 DIFF: https://github.com/llvm/llvm-project/commit/0038d6c7fe75a9f45076a347e4fd9b1f59051899.diff

[clang] 2d817d0 - [clang] NFCI: Use the `*Ref()` variant on search paths

Author: Jan Svoboda Date: 2023-05-31T16:04:45-07:00 New Revision: 2d817d0368ee72e2bd97bad88434cba2df30be8a URL: https://github.com/llvm/llvm-project/commit/2d817d0368ee72e2bd97bad88434cba2df30be8a DIFF: https://github.com/llvm/llvm-project/commit/2d817d0368ee72e2bd97bad88434cba2df30be8a.diff

[clang] 5be0e83 - [clang] NFCI: Use `FileEntryRef` in `PPLexerChange`

Author: Jan Svoboda Date: 2023-05-31T16:04:45-07:00 New Revision: 5be0e83635a22da0a42aeeeca8d42193ff2f9db6 URL: https://github.com/llvm/llvm-project/commit/5be0e83635a22da0a42aeeeca8d42193ff2f9db6 DIFF: https://github.com/llvm/llvm-project/commit/5be0e83635a22da0a42aeeeca8d42193ff2f9db6.diff

[clang] 80614e1 - [Fuchsia] Pass through LLVM_ENABLE_HTTPLIB to stage 2

Author: Daniel Thornburgh Date: 2023-05-31T15:56:20-07:00 New Revision: 80614e16e857d8767174284701aec69381c4 URL: https://github.com/llvm/llvm-project/commit/80614e16e857d8767174284701aec69381c4 DIFF:

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl updated this revision to Diff 527218. brendandahl marked an inline comment as done. brendandahl added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150803/new/ https://reviews.llvm.org/D150803 Files:

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

brendandahl marked 12 inline comments as done. brendandahl added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7645 + if (FD->isThisDeclarationADefinition()) { +S.Diag(D->getLocation(), diag::err_alias_is_definition) << FD << 0; +return;

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivateForVarInit try ConstExprEmitter fast-path first

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1324 // This is a string literal initializing an array in an initializer. -return CGM.GetConstantArrayFromStringLiteral(E); +return E->isLValue() ? +

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:790 + +**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ ` + Style of aligning consecutive short case labels. Did you

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

galenelias added a comment. In D151761#4385163 , @HazardyKnusperkeks wrote: > When I read the title I thought "Yay, some one is doing what I want and don't > find the time.", but (for me) sadly you're not. > I'd like to align the colon (and thus the

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a subscriber: ngzhian. sbc100 added a comment. In D151820#4385568 , @sbc100 wrote: > In D151820#4385536 , @dschuff wrote: > >>> I don't think it will since `__BIGGEST_ALIGNMENT__ >= >>>

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. In D151820#4385536 , @dschuff wrote: >> I don't think it will since `__BIGGEST_ALIGNMENT__ >= >> XNN_ALLOCATION_ALIGNMENT` will remain true after this change.. so this >> change should have no effect on that code. > > I meant

[clang] 54e4772 - [clang] NFCI: Use `DirectoryEntryRef` in `PrecompiledPreamble`

Author: Jan Svoboda Date: 2023-05-31T14:54:42-07:00 New Revision: 54e47724cfbf12dce05412c5b127ae311066afb3 URL: https://github.com/llvm/llvm-project/commit/54e47724cfbf12dce05412c5b127ae311066afb3 DIFF: https://github.com/llvm/llvm-project/commit/54e47724cfbf12dce05412c5b127ae311066afb3.diff

[clang] 6587d9d - [clang] NFCI: Use `DirectoryEntryRef` for `ModuleMap::BuiltinIncludeDir`

Author: Jan Svoboda Date: 2023-05-31T14:54:42-07:00 New Revision: 6587d9d87a58b08e86484ab25a121c3bfeb68949 URL: https://github.com/llvm/llvm-project/commit/6587d9d87a58b08e86484ab25a121c3bfeb68949 DIFF: https://github.com/llvm/llvm-project/commit/6587d9d87a58b08e86484ab25a121c3bfeb68949.diff

[clang] 20edfae - [clang] NFCI: Use `DirectoryEntryRef` in `ASTWriter`

Author: Jan Svoboda Date: 2023-05-31T14:54:42-07:00 New Revision: 20edfaeef7c55bc6ef320ffe1dcb82b88583c92c URL: https://github.com/llvm/llvm-project/commit/20edfaeef7c55bc6ef320ffe1dcb82b88583c92c DIFF: https://github.com/llvm/llvm-project/commit/20edfaeef7c55bc6ef320ffe1dcb82b88583c92c.diff

[PATCH] D151589: [lld] add context-sensitive PGO options for MachO

ellis updated this revision to Diff 527205. ellis added a comment. Fix paths in clang test to support windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151589/new/ https://reviews.llvm.org/D151589 Files:

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

dschuff added a comment. > I don't think it will since `__BIGGEST_ALIGNMENT__ >= > XNN_ALLOCATION_ALIGNMENT` will remain true after this change.. so this change > should have no effect on that code. I meant that when `__BIGGEST_ALIGNMENT__ >= XNN_ALLOCATION_ALIGNMENT` (which was true before

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir added a comment. In D151595#4385506 , @phosek wrote: > @Amir does this change look good to you? Looks good overall. Thanks for adding AddBolt cmake module. Testing the build internally, will reply shortly. Repository: rG LLVM Github Monorepo

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. In D151820#4385512 , @dschuff wrote: >> I don't think it will change anything in that code since >> `__BIGGEST_ALIGNMENT__ >= XNN_ALLOCATION_ALIGNMENT` will still hold true >> both before and after this change

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

dschuff added a subscriber: tlively. dschuff added a comment. > I don't think it will change anything in that code since > `__BIGGEST_ALIGNMENT__ >= XNN_ALLOCATION_ALIGNMENT` will still hold true both > before and after this change (XNN_ALLOCATION_ALIGNMENT == 4 on wasm) Right, that check

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

phosek added a comment. @Amir does this change look good to you? Comment at: bolt/tools/heatmap/CMakeLists.txt:8 -add_bolt_tool(llvm-bolt-heatmap +add_bolt_executable(llvm-bolt-heatmap heatmap.cpp smeenai wrote: > Why this change? This tool wasn't

[PATCH] D151763: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cf5188c7290: [clang] Fix crash when passing a braced-init list to a parentehsized aggregate… (authored by ayzhao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1cf5188 - [clang] Fix crash when passing a braced-init list to a parentehsized aggregate init expression

Author: Alan Zhao Date: 2023-05-31T13:52:45-07:00 New Revision: 1cf5188c72902e85e85095d788f5dfa138c320f8 URL: https://github.com/llvm/llvm-project/commit/1cf5188c72902e85e85095d788f5dfa138c320f8 DIFF: https://github.com/llvm/llvm-project/commit/1cf5188c72902e85e85095d788f5dfa138c320f8.diff

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. In D151820#4385393 , @dschuff wrote: > I guess this is basically the C version of max_align_t so it should match. Yes, it should match. Having `__BIGGEST_ALIGNMENT__` be 16 for emscripten doesn't make any sense right now. >

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 added a comment. In D151820#4385393 , @dschuff wrote: > I guess this is basically the C version of max_align_t so it should match. > but... this still has the potential to break things. True, but I think it's not as likely the break things as

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. The linker wrapper

[PATCH] D151828: [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

SeanP accepted this revision. SeanP added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151828/new/ https://reviews.llvm.org/D151828 ___

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

eandrews created this revision. eandrews added reviewers: aaron.ballman, erichkeane, compnerd. Herald added a project: All. eandrews requested review of this revision. Clang was rejecting valid code where GNU style attributes preceded C++ style attributes in template declarations as follows:

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

dschuff added a comment. I guess this is basically the C version of max_align_t so it should match. but... this still has the potential to break things. e.g. it will change the allocation in https://github.com/google/XNNPACK/blob/master/src/xnnpack/allocator.h#L66 ISTR that was one of the

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst:79 + +.. option:: StrictMode + mikecrowe wrote: > It turns out that absl::PrintF and absl::FPrintF work like std::format, > fmt::printf, etc. and

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nickdesaulniers added inline comments. Comment at: clang/test/Preprocessor/init-x86.c:1728-1741 +// RUN: %clang_cc1 -triple=i386-none-none -fsyntax-only -verify -DUNDEF %s +// RUN: %clang_cc1 -triple=i686-none-none -fsyntax-only -verify -DUNDEF %s +// RUN: %clang_cc1

[PATCH] D151834: Include math-errno with fast-math

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, jcranmer-intel. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. MSVC includes math-errno with #pragma float_control(precise,on) at O2

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2079 +[{ +enum RVV_VXRM { + VXRM_RNU = 0, enum name needs `__` prefix Comment at: clang/include/clang/Basic/riscv_vector.td:2080 +enum RVV_VXRM { +

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. charmitro requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Charalampos Mitrodimas Repository: rG LLVM Github

[clang] 5a0d53c - [Tooling] Remove unused function setRestoreWorkingDir

Author: Kazu Hirata Date: 2023-05-31T12:43:37-07:00 New Revision: 5a0d53ce41486225fd8be6b1d13f338d19c29f62 URL: https://github.com/llvm/llvm-project/commit/5a0d53ce41486225fd8be6b1d13f338d19c29f62 DIFF: https://github.com/llvm/llvm-project/commit/5a0d53ce41486225fd8be6b1d13f338d19c29f62.diff

[PATCH] D151786: [Tooling] Remove unused function setRestoreWorkingDir

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a0d53ce4148: [Tooling] Remove unused function setRestoreWorkingDir (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151786/new/

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527164. john.brawn added a comment. Move some of the testing to init-x86.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/init-x86.c

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150926/new/ https://reviews.llvm.org/D150926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseLabels

HazardyKnusperkeks added a comment. When I read the title I thought "Yay, some one is doing what I want and don't find the time.", but (for me) sadly you're not. I'd like to align the colon (and thus the statement behind that). Do you think you can add that option too?

[PATCH] D151553: [clang] Fix consteval operators in template contexts

rsmith added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11940-11943 - ExprResult Callee = getDerived().TransformExpr(E->getCallee()); - if (Callee.isInvalid()) -return ExprError(); - Fznamznon wrote: > cor3ntin wrote: > > I don't

[PATCH] D151786: [Tooling] Remove unused function setRestoreWorkingDir

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151786/new/ https://reviews.llvm.org/D151786

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

This revision was automatically updated to reflect the committed changes. yaxunl marked 4 inline comments as done. Closed by commit rG00448a548c4e: [clang] Allow fp in atomic fetch max/min builtins (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 00448a5 - [clang] Allow fp in atomic fetch max/min builtins

Author: Yaxun (Sam) Liu Date: 2023-05-31T15:19:31-04:00 New Revision: 00448a548c4efc4bdcfd6be5f161eacc69b30021 URL: https://github.com/llvm/llvm-project/commit/00448a548c4efc4bdcfd6be5f161eacc69b30021 DIFF:

[clang] dfce185 - [clang] NFCI: Use `FileEntryRef` in `VerifyDiagnosticConsumer`

Author: Jan Svoboda Date: 2023-05-31T12:17:37-07:00 New Revision: dfce18506b7a9354ddc6706c9ca12644a7be9767 URL: https://github.com/llvm/llvm-project/commit/dfce18506b7a9354ddc6706c9ca12644a7be9767 DIFF: https://github.com/llvm/llvm-project/commit/dfce18506b7a9354ddc6706c9ca12644a7be9767.diff

[clang] 53690f8 - [clang] NFCI: Use `FileEntryRef` in `PPDirectives`

Author: Jan Svoboda Date: 2023-05-31T12:17:37-07:00 New Revision: 53690f8f0db78d27a9ab5a7b924faaae627da4c4 URL: https://github.com/llvm/llvm-project/commit/53690f8f0db78d27a9ab5a7b924faaae627da4c4 DIFF: https://github.com/llvm/llvm-project/commit/53690f8f0db78d27a9ab5a7b924faaae627da4c4.diff

[PATCH] D151783: [clang] Use the appropriate definition when checking FunctionDecl::isInlineBuiltinDeclaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG1676b1ff63af: [clang] Use the appropriate definition when checking FunctionDecl… (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1676b1f - [clang] Use the appropriate definition when checking FunctionDecl::isInlineBuiltinDeclaration

Author: serge-sans-paille Date: 2023-05-31T21:13:07+02:00 New Revision: 1676b1ff63afb1cadc523d74f1e8f2c75fd49126 URL: https://github.com/llvm/llvm-project/commit/1676b1ff63afb1cadc523d74f1e8f2c75fd49126 DIFF:

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

shafik added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16163 +// Dependent alignment cannot be resolved -> bail out. +if (any_of(VD->specific_attrs(), + [](auto *A) { return A->isAlignmentDependent(); }))

[PATCH] D151828: Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

zibi created this revision. Herald added a project: All. zibi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151828

[PATCH] D151634: [clang] Add test for CWG253

shafik added a comment. In D151634#4383428 , @Endill wrote: > @shafik Thank you for letting me know! Now I wonder if it was possible to > realize by myself without prior knowledge of CWG 2536, because I feel like > some cross-references are missing. >

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6576-6578 if (!ValType->isFloatingType()) return false; + if (!(AllowedType & AOAVT_FP)) tra wrote: > Collapse into a single

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo reopened this revision. oontvoo added a comment. This revision is now accepted and ready to land. In D144999#4356218 , @thakis wrote: > Reverted in 4980eead4d0b4666d53dad07afb091375b3a13a0 >

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

ributzka accepted this revision. ributzka added a comment. I see. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150689/new/ https://reviews.llvm.org/D150689 ___ cfe-commits mailing list

[PATCH] D151818: [clang][analyzer][NFC] Use the operator new directly with the `BumpPtrAllocator`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ebf64f7e934: [clang][analyzer][NFC] Use the operator new directly with the `BumpPtrAllocator` (authored by gribozavr). Repository: rG LLVM

[clang] 7ebf64f - [clang][analyzer][NFC] Use the operator new directly with the `BumpPtrAllocator`

Author: Dmitri Gribenko Date: 2023-05-31T20:18:30+02:00 New Revision: 7ebf64f7e934a5e42d550194604b613113132bc0 URL: https://github.com/llvm/llvm-project/commit/7ebf64f7e934a5e42d550194604b613113132bc0 DIFF:

[PATCH] D148387: remove Demangle/StringView.h

nickdesaulniers updated this revision to Diff 527132. nickdesaulniers added a comment. - rebase for presubmit testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148387/new/ https://reviews.llvm.org/D148387 Files:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 527127. koops added a comment. 1. Addition of extra test case loop_bind_enclosed.cpp. 2. Changing of name from Map1D to MappedDirective 3. Printing "omp loop bind" instead of the mapped Directives (e.g. "omp simd") when -ast-print option is used. CHANGES

[clang] 731f9ac - [Fuchsia] Add llvm-debuginfod to toolchain

Author: Daniel Thornburgh Date: 2023-05-31T11:01:39-07:00 New Revision: 731f9ac6e53611dabb51c52bfc8011c2aab7790b URL: https://github.com/llvm/llvm-project/commit/731f9ac6e53611dabb51c52bfc8011c2aab7790b DIFF:

[PATCH] D151818: [clang][analyzer][NFC] Use the operator new directly with the `BumpPtrAllocator`

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151818/new/ https://reviews.llvm.org/D151818

[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

sbc100 created this revision. Herald added subscribers: pmatos, wingo, sunfish, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Follow up to

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4413 +// first/next use via ASTReader::updateOutOfDateIdentifier(). +II = ().get(Key); + } benlangmuir wrote: > Why did this change from `getOwn` to `get`?

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few more test nits. Comment at: clang/test/Sema/atomic-ops.c:134 int *I, const int *CI, int **P, float *D, struct S *s1, struct S *s2) {

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet updated this revision to Diff 527104. hazohelet added a comment. I think the proper message here can be obtained by letting the stack frame keep the syntactical structure of the function call, although it introduces additional memory footprint. - Add `const Expr *` new field to

[PATCH] D151818: [clang][analyzer][NFC] Use the operator new directly with the `BumpPtrAllocator`

gribozavr updated this revision to Diff 527115. gribozavr added a comment. Format the edits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151818/new/ https://reviews.llvm.org/D151818 Files: clang/lib/Analysis/CFG.cpp

[PATCH] D151818: [clang][analyzer][NFC] Use the operator new directly with the `BumpPtrAllocator`

gribozavr created this revision. gribozavr added reviewers: NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. gribozavr requested review of this

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

tra added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6576-6578 if (!ValType->isFloatingType()) return false; + if (!(AllowedType & AOAVT_FP)) Collapse into a single if statement: `if (!(ValType->isFloatingType() &&

[PATCH] D151770: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType()

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb069246573: [NFC][CLANG] Fix nullptr dereference issue in SetValueDataBasedOnQualType() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper reopened this revision. craig.topper added a comment. This revision is now accepted and ready to land. The backend patch must go before the clang patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/

  1   2   3   >