[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson added a comment. In D71026#1769340 , @arphaman wrote: > Is the `Tooling/Transformer` library used by clang-format? The problem might > be solved if the `Tooling/Transformer` library was its own module (just like > Clang_ToolingInclusions).

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson added a comment. In D71026#1769340 , @arphaman wrote: > Is the `Tooling/Transformer` library used by clang-format? The problem might > be solved if the `Tooling/Transformer` library was its own module (just like > Clang_ToolingInclusions).

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson created this revision. arichardson added reviewers: EricWF, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using the same approach as d0782a69ff4c04dc4f1dc1c11cb2fb43c6b638f5 and 91cef98d2c41eff0dea474a760d2dce5ba873209. Repository: rG LLVM Github Mo

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. @arphaman Should be fixed by rG09c7e51283dafbfd122cc0d7ab251476c451c9f5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llv

[PATCH] D70119: Improve gen_ast_dump_json_test.py

arichardson marked 2 inline comments as done. arichardson added inline comments. Comment at: clang/test/AST/gen_ast_dump_json_test.py:3 +from __future__ import print_function from collections import OrderedDict aaron.ballman wrote: > Is this needed? I don't se

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. I've split out the update script changes into D70119 to make this easier to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 _

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. Ping. Does this seem an acceptable change to the JSON output @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 ___ c

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

arichardson added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65 -static constexpr unsigned kTagGranuleSize = 16; +static const Align kTagGranuleSize = Align(16); gchatelet wrote: > arichardson wrote: > > Can't the Align

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

arichardson added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64StackTagging.cpp:65 -static constexpr unsigned kTagGranuleSize = 16; +static const Align kTagGranuleSize = Align(16); Can't the Align ctor be constexpr? Will this result in a

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson added a comment. Herald added a project: clang. Ping? I'm not sure if this is still required now that D63508 has been committed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49091/new/ https://reviews.llvm.org/D4909

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Looks good to me but I guess someone else should give the final approval. Comment at: llvm/lib/Target/Mips/MCTargetDesc/MipsMCAsmInfo.cpp:25 if (TheTriple.isMI

[PATCH] D59725: Additions to creduce script

arichardson added a comment. In D59725#1477042 , @lebedev.ri wrote: > I've stumbled into an issue with the script: > It got a line: `clang: > /build/llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2582: bool > {anonymous}::IndVarSimplify::run(llvm::Loop*)

[PATCH] D59725: Additions to creduce script

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM once the tempfile is deleted. Comment at: clang/utils/creduce-clang-crash.py:208 +print("\nTrying to preprocess the source file...") +# use delete=Fals

[PATCH] D59725: Additions to creduce script

arichardson added a comment. In D59725#1443990 , @george.burgess.iv wrote: > Only a few more nits on my side, and this LGTM. WDYT, arichardson? LGTM with the minor tempfile changes. Comment at: clang/utils/creduce-clang-crash.py:201

[PATCH] D59725: Additions to creduce script

arichardson added inline comments. Comment at: clang/utils/creduce-clang-crash.py:145 + matches = re.findall(stacktrace_re, crash_output) + result = filter(lambda x: x and x.strip() not in filters, matches)[:5] + for msg in result: george.burgess.i

[PATCH] D59440: add steps to preprocess file and reduce command line args

arichardson added a comment. @akhuang Thanks for getting this committed. Since it seems like a lot of this is taken from my script, could you please add me as a reviewer for the next patch so that I know which bits still need to be upstreamed? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59118: creduce script for clang crashes

arichardson added a comment. In case anyone is interested, for the CHERI fork of LLVM/Clang I added a similar script that contains additional features such as inferring the crash message (so that you get the minimal reproducer for the issue that you are trying to reduce and not some obscure par

[PATCH] D56650: [lld] [ELF] Support inferring target triple from filename

arichardson added a comment. I'm happy with this approach since the triple can be set on the commandline. If this gets merged I will update CHERI lld to use the triple instead of the new emulation that we added. Comment at: ELF/Driver.cpp:757 + if (!TargetOpt.empty()) { +

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

arichardson requested changes to this revision. arichardson added inline comments. This revision now requires changes to proceed. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + -

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

arichardson added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + If I invoke an unprefixed ld.lld on NetBSD but want to target a different operating sy

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson added a comment. I don't see an easy way of fixing the pragma clang attribute support for this. Would it be okay to commit this change anyway? Since `alloc_size` is only used for very few functions I'd be very surprised if there's any existing code that relies on using `#pragma clang

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

arichardson added a comment. In D56215#1346061 , @mgorny wrote: > For the record, another option is to actually fix other software not to call > LD directly. Or if you really need to call the linker directly without specifying search paths you could al

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

arichardson added inline comments. Comment at: include/clang/Basic/Builtins.def:942 LIBBUILTIN(alloca, "v*z", "f", "stdlib.h", ALL_GNU_LANGUAGES) +LIBBUILTIN(qsort_r, "", "fC<3,-1,-1,4>", "stdlib.h", ALL_GNU_LANGUAGES) // POSIX string.h q

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:15 +// FIXME: After changing the subject from Function to HasFunctionProto, AllocSize is no longer listed (similar to Format, et

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked 5 inline comments as done. arichardson added inline comments. Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:15 +// FIXME: After changing the subject from Function to HasFunctionProto, AllocSize is no longer listed (similar to Format, et

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson updated this revision to Diff 177519. arichardson marked 3 inline comments as done. arichardson added a comment. fix typo Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https://reviews.llvm.org/D55212 Files: include/clang/Basic/Attr.td

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson updated this revision to Diff 177517. arichardson added a comment. clang-format fix a failing test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https://reviews.llvm.org/D55212 Files: include/clang/Basic/Attr.td lib/AST/ExprConstant.cp

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson updated this revision to Diff 177027. arichardson added a comment. Add a C++ test for alloc_size Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https://reviews.llvm.org/D55212 Files: include/clang/Basic/Attr.td lib/AST/ExprConstant.cpp

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; aaron.ballm

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added a comment. Thanks for the review! I'll write a C++ test tomorrow. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectLis

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson updated this revision to Diff 176413. arichardson added a comment. - address review comments - add test that we can assign between function pointers with and without alloc_size attribute. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked 5 inline comments as done. arichardson added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; aaron.ballm

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson updated this revision to Diff 176368. arichardson added a comment. Remove RUN: line added for debugging Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55212/new/ https://reviews.llvm.org/D55212 Files: include/clang/Basic/Attr.td lib/AST/ExprConsta

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson created this revision. arichardson added reviewers: george.burgess.iv, aaron.ballman, jdenny. Herald added a subscriber: cfe-commits. I have been trying to statically find and analyze all calls to heap allocation functions to determine how many of them use sizes known at compile time v

[PATCH] D40016: Use ImplicitConversionSequence::setAsIdentityConversion(QualType). NFC

arichardson updated this revision to Diff 173828. arichardson added a comment. rebased on latest HEAD Repository: rC Clang https://reviews.llvm.org/D40016 Files: lib/Sema/SemaOverload.cpp Index: lib/Sema/SemaOverload.cpp ===

[PATCH] D49067: Stop wrapping __has_include in another macro

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX337824: Stop wrapping __has_include in another macro (authored by arichardson, committed by ). Changed prior to commit: https://reviews.llvm.org/D49067?vs=154566&id=157011#toc Repository: rL LLVM

[PATCH] D49067: Stop wrapping __has_include in another macro

This revision was automatically updated to reflect the committed changes. Closed by commit rL337824: Stop wrapping __has_include in another macro (authored by arichardson, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D49067 Files: lib

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson added a comment. In https://reviews.llvm.org/D49067#1172500, @EricWF wrote: > Where are the special lexing rules specified? In https://bugs.llvm.org/show_bug.cgi?id=37990#c1 @rsmith wrote: > The C++ standard appears to be missing a rule that says that a __has_include > token pr

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson added a comment. Ping? Repository: rCXX libc++ https://reviews.llvm.org/D49067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

arichardson created this revision. arichardson added a reviewer: rsmith. Herald added a subscriber: cfe-commits. The characters after '__has_include(' have special lexing rules that can't possibly be applied when __has_include is generated by a macro. Instead of wrapping __has_include in another m

[PATCH] D49067: Stop wrapping __has_include in another macro

arichardson created this revision. arichardson added reviewers: EricWF, rsmith. Herald added subscribers: cfe-commits, ldionne, christof. This is not guaranteed to work since the characters after '__has_include(' have special lexing rules that can't possibly be applied when __has_include is genera

[PATCH] D45383: Limit types of builtins that can be redeclared.

arichardson added a comment. This broke the build of FreeBSD for me due to the declaration of __builtin_return_address(unsigned int) in https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Base.h#L1281: In file included from /exports/users/alr48/sources/freebsd-x86/sys/contrib/edk2/I

[PATCH] D48549: Use Triple::isMIPS() instead of enumerating all Triples. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rC335495: Use Triple::isMIPS() instead of enumerating all Triples. NFC (authored by arichardson, committed by ). Changed prior to commit: https://reviews.llvm.org/D48549?vs=152696&id=152713#toc Repositor

[PATCH] D48549: Use Triple::isMIPS() instead of enumerating all Triples. NFC

arichardson updated this revision to Diff 152696. arichardson added a comment. Ran clang-format on the diff Repository: rC Clang https://reviews.llvm.org/D48549 Files: lib/Basic/Targets/Mips.cpp lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Arch/M

[PATCH] D48549: Use Triple::isMIPS() instead of enumerating all Triples. NFC

arichardson created this revision. arichardson added a reviewer: atanasyan. Herald added subscribers: cfe-commits, sdardis, emaste. Repository: rC Clang https://reviews.llvm.org/D48549 Files: lib/Basic/Targets/Mips.cpp lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp lib/Dr

[PATCH] D47627: [ASTContext] Make getAddrSpaceQualType replace address spaces.

arichardson added a comment. > Well, the documentation mismatch is worth fixing even if the code isn't. But > I think at best your use-case calls for weakening the assertion to be that > any existing address space isn't *different*, yeah. > > Separately, I'm not sure that's really the right re

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

arichardson accepted this revision. arichardson added a comment. I recently made this change for the CHERI clang fork and as far as I can tell everything works fine. https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote: > Ok, I found the problem. In fact the size of `long` is 4 bytes on your > machine, but 8 bytes on mine. > This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` > fail. > Do you know

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote: > Ok, I found the problem. In fact the size of `long` is 4 bytes on your > machine, but 8 bytes on mine. > This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` > fail. > Do you know

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson accepted this revision. arichardson added a comment. > So, for the moment, we are only handling basic types. That said, for the enum > in C, we will print according to the type of the enum. > In the future versions, I really want to be able to print the name of the > enum so that th

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. I'm also often restricted to using printf for debugging so this looks really useful! However, before committing this I feel like the test should also verify that the format strings that are generated are sensible. Also what should happens when you have enum members

[PATCH] D44604: Make stdarg.h compatible with FreeBSD

arichardson created this revision. arichardson added reviewers: efriedma, dim. Herald added subscribers: cfe-commits, krytarowski, sdardis, emaste. On FreeBSD it is currently not possible to use the clang builtin headers to build the base system. The build will fail with the following error if I d

[PATCH] D42139: Allow passing additional compiler/linker flags for the tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL325914: Allow passing additional compiler/linker flags for the tests (authored by arichardson, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D421

[PATCH] D42139: Allow passing additional compiler/linker flags for the tests

arichardson added a comment. Herald added a subscriber: christof. ping Repository: rCXX libc++ https://reviews.llvm.org/D42139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37057: [clang] Require address space to be specified when creating functions (3/3)

arichardson added a comment. Looks good to me but I guess someone else should approve the change. I added a bunch of hacks in our fork to ensure that functions end up being in address space 200 but this would be much better. Repository: rC Clang https://reviews.llvm.org/D37057 __

[PATCH] D42139: [UPSTREAM] Allow passing additional compiler/linker flags for the tests

arichardson created this revision. arichardson added a reviewer: EricWF. Herald added subscribers: cfe-commits, mgorny. These flags can be specified using the CMake variables LIBCXX_TEST_LINKER_FLAGS and LIBCXX_TEST_COMPILER_FLAGS. When building the tests for CHERI I need to pass additional flags

[PATCH] D40016: Use ImplicitConversionSequence::setAsIdentityConversion(QualType). NFC

arichardson created this revision. Slightly reduces the amount of duplicated code. https://reviews.llvm.org/D40016 Files: lib/Sema/SemaOverload.cpp Index: lib/Sema/SemaOverload.cpp === --- lib/Sema/SemaOverload.cpp +++ lib/Sema

[PATCH] D39537: Rename identifiers named `__output`

This revision was automatically updated to reflect the committed changes. Closed by commit rL318144: Rename identifiers named `__output` (authored by arichardson). Repository: rL LLVM https://reviews.llvm.org/D39537 Files: libcxx/trunk/include/algorithm libcxx/trunk/include/experimental/a

[PATCH] D39537: Rename identifiers named `__output`

arichardson added inline comments. Comment at: test/support/nasty_macros.hpp:55 +#define __output NASTY_MACRO +#define __input NASTY_MACRO EricWF wrote: > Shouldn't these not be defined when running the tests with a CHER compiler? > Otherwise the macro will co

[PATCH] D39537: Rename identifiers named `__output`

arichardson created this revision. In the CHERI clang compiler __output and __input are keywords and therefore we can't compile libc++ with our compiler. Repository: rL LLVM https://reviews.llvm.org/D39537 Files: include/algorithm include/experimental/algorithm include/experimental/ite

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

This revision was automatically updated to reflect the committed changes. Closed by commit rL315871: Convert clang::LangAS to a strongly typed enum (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D38816?vs=118915&id=119090#toc Repository: rL LLVM https://reviews

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() yaxunl wrote: > arichardson wrote: > >

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() arichardson wrote: > Anastasia wrote: >

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() Anastasia wrote: > arichardson wrote: >

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() Anastasia wrote: > arichardson wrote: >

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson updated this revision to Diff 118915. arichardson edited the summary of this revision. arichardson added a comment. This revision is now accepted and ready to land. - Keep old behaviour for clang_getAddressSpace() - renamed to getLangASFromTargetAS() - rebased on latest trunk https:/

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson planned changes to this revision. arichardson added inline comments. Comment at: include/clang/Basic/AddressSpaces.h:66 +inline LangAS LangASFromTargetAS(unsigned TargetAS) { + return static_cast((TargetAS) + yaxunl wrote: > how about `getLangASFro

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: lib/AST/TypePrinter.cpp:1323 OS << "address_space("; -OS << T->getEquivalentType().getAddressSpace(); +OS << T->getEquivalentType() + .getQualifiers() Anastasia wrote: > Why do we need this

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson updated this revision to Diff 118784. arichardson added a comment. Removed the additional namespace https://reviews.llvm.org/D38816 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h include/clang/Basic/TargetInfo.h lib/AST/A

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson added inline comments. Comment at: include/clang/Basic/AddressSpaces.h:51 +namespace LanguageAS { /// The type of a lookup table which maps from language-specific address spaces jlebar wrote: > I wonder if you need this namespace? LangAS right nex

[PATCH] D38816: Convert clang::LangAS to a strongly typed enum

arichardson created this revision. Herald added subscribers: Anastasia, nhaehnle, jholewinski. Currently both clang AST address spaces and target specific address spaces are represented as unsigned which can lead to subtle errors if the wrong type is passed. It is especially confusing in the CodeG

[PATCH] D32425: [mips] Make checks in CodeGen/mips-varargs.c less fragile

arichardson added a comment. I don't have commit access, could you commit for me please? https://reviews.llvm.org/D32425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32425: [mips] Make checks in CodeGen/mips-varargs.c less fragile

arichardson updated this revision to Diff 98059. arichardson retitled this revision from "[mips] Make N32 checks in CodeGen/mips-varargs.c less fragile" to "[mips] Make checks in CodeGen/mips-varargs.c less fragile". arichardson edited the summary of this revision. arichardson added a comment. He

[PATCH] D27140: Allow clang to write compilation database records

arichardson added a comment. It would also be good to append --sysroot=DEFAULT_SYSROOT if DEFAULT_SYSROOT is not empty and there is no explicit --sysroot flag. That way the compilation database can also be consumed by a libclang based too that does not have the same DEFAULT_SYSROOT set. Repos

<    1   2   3   4