[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

thetruestblue added a comment. Thinking about it, we might need to do the opposite as what I proposed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158570/new/ https://reviews.llvm.org/D158570 ___

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

thetruestblue created this revision. thetruestblue added reviewers: kubamracek, yln, rsundahl, wrotki, usama54321, MaskRay, vitalybuka. Herald added a subscriber: Enna1. Herald added a project: All. thetruestblue requested review of this revision. Herald added projects: clang, Sanitizers. Herald

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

thetruestblue updated this revision to Diff 546199. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156718/new/ https://reviews.llvm.org/D156718 Files: clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/ToolChains/Darwin.cpp compiler-rt/test/asan_abi/CMakeLists.txt

[PATCH] D156718: [ASanStableABI][Driver] Stop linking to asan dylib when stable abi is enabled

thetruestblue created this revision. thetruestblue added reviewers: yln, rsundahl, usama54321, wrotki, kubamracek, vitalybuka, MaskRay. Herald added a subscriber: Enna1. Herald added a project: All. thetruestblue requested review of this revision. Herald added projects: clang, Sanitizers. Herald

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added inline comments. Comment at: compiler-rt/test/asan_abi/lit.cfg.py:83 +# Only run the tests on supported OSs. +if config.host_os not in ['Darwin']: + config.unsupported = True MaskRay wrote: > `!=` The thought here was to leave basic lit

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added a comment. Small insignificant note from me: When this lands, please be sure to add me as co-author. https://github.blog/2018-01-29-commit-together-with-co-authors/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

thetruestblue accepted this revision. thetruestblue added a comment. This revision is now accepted and ready to land. This looks good to me. I'm not sure the policy on what should be added to the release notes. But this was a temporary flag only added to slowly deprecate this, and was noted

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added a comment. Currently & ideally asabi_shim.h is unnecessary -- but we hope to use only headers from ../asan/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added inline comments. Comment at: compiler-rt/cmake/config-ix.cmake:734 set(COMPILER_RT_HAS_ASAN TRUE) + set(COMPILER_RT_HAS_ASABI TRUE) else() This was an artifact leftover from some of my cmake changes. This line needs to be removed..

[PATCH] D116182: [ASan] Moved optimized callbacks into a separate library.

thetruestblue added inline comments. Herald added a project: All. Comment at: compiler-rt/lib/asan/CMakeLists.txt:198 +ARCHS ${ASAN_SUPPORTED_ARCH} +OBJECT_LIBS RTAsan_static +CFLAGS ${ASAN_CFLAGS} Can you explain the motivation here? RTAsan_static

[PATCH] D142421: [Sanitizers] fix -fno-sanitize-link-runtime for darwin

thetruestblue accepted this revision. thetruestblue added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142421/new/ https://reviews.llvm.org/D142421 ___ cfe-commits mailing list

[PATCH] D141550: [CompilerRT] Remove ubsan static runtime on Apple

thetruestblue accepted this revision. thetruestblue added a comment. This seems reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141550/new/ https://reviews.llvm.org/D141550 ___

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

thetruestblue added a comment. In D137024#3931497 , @tstellar wrote: > @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? TBD. So far this seems like the only necessary path. But I am working to confirm this. Repository: rG LLVM

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

thetruestblue added a comment. > While I sympathize with you, I don't think this is valid reason to maintain > full compatibility with `llvm-config`. A standalone build with LLVM_TOOLS_BINARY_DIR set directly could be a valid code path. We already have code to mock LLVMConfig.cmake. I

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

thetruestblue added a comment. This breaks our use case. We run sanitizer tests built in a standalone build using an artifact toolchain that contains binaries only. Compiler-rt tests rely on the llvm tools binary being in the PATH. This patch removes the logic that sets the binary tools dir