[PATCH] D106252: Implement P2092

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM upon inspection. There aren't any cases in libc++ that I'm aware of that will break because of this, but I think it's a good practice to try and bootstrap the library for certainty. Please

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:304 + +def pp_pragma_include_instead_not_sysheader : Error< + "'#pragma clang include_instead' cannot be used outside of system headers">, aaron.ballman wrote: > Can you

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 361357. cjdb marked 11 inline comments as done. cjdb added a comment. applies all of @aaron.ballman's remaining feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106394/new/ https://reviews.llvm.org/D106394

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 361014. cjdb marked 12 inline comments as done. cjdb added a comment. - applies all of @aaron.ballman's suggested changes - turns warnings into errors and deletes warning group - replaces `interleave` with `join` - properly abandons LF transmuting The only

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb marked 2 inline comments as done. cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:307-310 +def pp_pragma_include_instead_unexpected_token : Warning< + "'#pragma include_instead' expects '%0' as its next token; got '%1' instead">, +

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. Thanks for the first pass @aaron.ballman! Some clarifying questions, but I think I have enough of your other comments to work on while you ponder these. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:303 InGroup>; +def

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a72580a548d: [clang][Sema] removes -Wfree-nonheap-object reference param false positive (authored by cjdb). Changed prior to commit:

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2893681 , @Quuxplusone wrote: > If IWYU has already developed a de facto standard for this information, I > would recommend libc++ just use it (perhaps with no changes needed in clang > at all). This would have the

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 360519. cjdb added a comment. - renames files - makes it possible for `#pragma GCC system_header` to come after includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106394/new/ https://reviews.llvm.org/D106394

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2892832 , @sammccall wrote: > This is pretty interesting from a tooling perspective! > > Some prior art here are the include-what-you-use "pragmas" >

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 360317. cjdb marked an inline comment as done. cjdb added a comment. - renames test files so they better describe intention - replaces `SmallVector` with `SetVector` - replaces `std::accumulate` with `llvm::interleave` Repository: rG LLVM Github Monorepo

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2891647 , @zoecarver wrote: > Can't wait to start using this! (Note: this is not a full review, just some > thoughts.) > > Do you have a test case where > > // private: header one > *exists* > > // private:

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:437 + diag::pp_pragma_include_instead_system_reserved) +<< Filename << 2 << ('{' + Aliases + '}'); + } I wasn't able to work out how to escape braces inside

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, gbiv, dblaikie, cor3ntin. Herald added a reviewer: george.burgess.iv. Herald added subscribers: usaxena95, kadircet. cjdb requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb updated this revision to Diff 360016. cjdb added a comment. rebases to activate CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102728/new/ https://reviews.llvm.org/D102728 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D104887: [clang] Evaluate strlen of strcpy argument for -Wfortify-source.

cjdb added a comment. Thanks for getting around to this! Just a nit and a clarifying question. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:821 + "'%0' will always overflow; destination buffer has size %1," + " but the source string has length %2 (including

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2874805 , @cjdb wrote: > In D105439#2874733 , @lebedev.ri > wrote: > >> In D105439#2874706 , @ldionne >> wrote: >> >>> I'm not entirely

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2874733 , @lebedev.ri wrote: > In D105439#2874706 , @ldionne wrote: > >> I'm not entirely sure I understand the purpose of this patch. So the idea is >> that let's say a tool

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2874706 , @ldionne wrote: > I'm not entirely sure I understand the purpose of this patch. So the idea is > that let's say a tool suggests including `<__algorithm/find.h>` to get the > definition of `std::find` as a IWYU

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb updated this revision to Diff 358127. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102728/new/ https://reviews.llvm.org/D102728 Files:

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2871429 , @Quuxplusone wrote: > Given that the goal is to get `include-what-you-use` to stop suggesting that > users `#include <__detail/fooimpl.h>` when what they want is spelled > ``, I think what's desired here (if

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. Ping @aaron.ballman and @ldionne Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105439/new/ https://reviews.llvm.org/D105439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. I tried the following, but it doesn't work with modules, so it looks like a compiler solution is necessary. // in #define _LIBCPP_PRIVATE_HEADER_ALLOWED // in <__algorithm/find.h> #ifndef _LIBCPP_PRIVATE_HEADER_ALLOWED #error This is a libc++ detail header.

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. I should note that I didn't use private headers in libc++'s `modules.modulemap` because it created a very noticeable impact to our test suite's run-time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105439/new/

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2858291 , @Quuxplusone wrote: > Step 1 should be to find out if this is even a problem at all. For example, > try using one of these tools to compile a C++ program against GNU libstdc++, > or against a library like

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. A few notes to reviewers: - The patch assumes everything is under a top-level `__libcxx` directory, because it seems there are other system headers that could be prefixed with `__`. libc++ currently has many top-level directories, following the trend of

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb created this revision. cjdb added reviewers: aaron.ballman, rsmith, manojgupta, gbiv, ldionne, EricWF. Herald added a reviewer: george.burgess.iv. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. libc++ has started splicing

[PATCH] D105400: [clangd][iwyu] explicitly includes ``

This revision was automatically updated to reflect the committed changes. Closed by commit rG478092d33116: [clangd][iwyu] explicitly includes `atomic` (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105400/new/

[PATCH] D105400: [clangd][iwyu] explicitly includes ``

cjdb created this revision. Herald added subscribers: usaxena95, kadircet, jfb, arphaman. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Compiling clangd with Clang modules and libc++ revealed that

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb added a comment. Oops, looks like I never submitted my replies! Comment at: clang/lib/Sema/SemaChecking.cpp:10466 if (isa(D)) - return CheckFreeArgumentsOnLvalue(S, CalleeName, UnaryExpr, D); + if (!isa(D) || +

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb added a comment. When should we expect this to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 ___ cfe-commits mailing list

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM, but I'm neither a Clang nor core expert (and I'm not a maintainer), so please wait for others' approval. Comment at:

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb requested changes to this revision. cjdb added a comment. This revision now requires changes to proceed. Thanks for working on this, it'll be a huge win for testing in libc++, methinks! Could we get a few more tests please? I'd like to know what happens when we put a lambda directly

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb created this revision. cjdb added reviewers: gbiv, manojgupta, aaron.ballman. Herald added a reviewer: george.burgess.iv. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester,

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

cjdb abandoned this revision. cjdb added a comment. A different path forward was discussed with @ldionne and @zoecarver. Will experiment this other way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101598/new/ https://reviews.llvm.org/D101598

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

cjdb created this revision. cjdb added reviewers: rsmith, gbiv, aaron.ballman, manojgupta. Herald added a reviewer: george.burgess.iv. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [namespace.std]/p6 indicates that taking the

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

cjdb added a comment. Overall LGTM, thank you for working on this :-) Comment at: clang/lib/Sema/SemaDecl.cpp:13761-13771 +bool VisitDeclRefExpr(const DeclRefExpr *DRE) { + auto iter = M->find(DRE->getFoundDecl()); + if (iter != M->end() && iter->second) { +

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

This revision was automatically updated to reflect the committed changes. Closed by commit rG9830901b341c: [clang] removes check against integral-to-pointer conversion... (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; thakis wrote: > cjdb wrote: > > cjdb wrote: > > > aaron.ballman wrote: > > > > I'm

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; cjdb wrote: > aaron.ballman wrote: > > I'm

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326748. cjdb added a comment. `s/IgnoreImplicitAsWritten/IgnoreParenImpCasts/` since the latter seems to work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 Files:

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb added a subscriber: rsmith. cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10320 + + const clang::CastKind Kind = Cast->getCastKind(); + if (Kind == clang::CK_BitCast && aaron.ballman wrote: > We don't typically use top-level

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326742. cjdb marked 2 inline comments as done. cjdb added a comment. applies comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/ https://reviews.llvm.org/D97512 Files:

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added a comment. In D94640#2590512 , @thakis wrote: > This seems to flag > https://source.chromium.org/chromium/chromium/src/+/master:third_party/libsync/src/sync.c;l=142?q=sync.c=chromium > : > > info->sync_fence_info = (uint64_t)

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb updated this revision to Diff 326723. cjdb edited the summary of this revision. cjdb added a comment. updates commit message to explain what's going on and why the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb created this revision. cjdb added a reviewer: aaron.ballman. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ... unless it's a literal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97512 Files:

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f395db86b5c: adds more checks to -Wfree-nonheap-object (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 326261. cjdb added a comment. applies @aaron.ballman's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 Files:

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 325889. cjdb added a comment. applies @aaron.ballman's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked an inline comment as done. cjdb added a comment. In D94640#2579447 , @aaron.ballman wrote: > In D94640#2560647 , @cjdb wrote: > >> fixes block expressions >> >> @aaron.ballman I'm not sure I follow

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked an inline comment as done. cjdb added a comment. Ping. @aaron.ballman any further requests? I think this is good to land otherwise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked 3 inline comments as done. cjdb added inline comments. Comment at: clang/test/Analysis/free.c:84 + // expected-warning@-1{{Argument to free() is a block, which is not memory allocated by malloc()}} + // expected-warning@-2{{attempt to call free on non-heap object

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 323414. cjdb added a comment. fixes block expressions @aaron.ballman I'm not sure I follow what you're after re lambdas. Could you please provide a test case that I can work with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added inline comments. Comment at: clang/test/Analysis/free.c:84 + // expected-warning@-1{{Argument to free() is a block, which is not memory allocated by malloc()}} + // expected-warning@-2{{attempt to call free on non-heap object : block expression}} }

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 38. cjdb marked 4 inline comments as done. cjdb added a comment. Herald added a subscriber: cfe-commits. addresses comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10267-10277 + if (const auto *Field = dyn_cast(D)) { S.Diag(UnaryExpr->getBeginLoc(), diag::warn_free_nonheap_object) << CalleeName << Field; +return; + } + + if (const auto *Func =

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb closed this revision. cjdb added a comment. Merged in 4a47da2cf440c2f2006d9b04acfef4292de1e263 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb updated this revision to Diff 315471. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Analysis/NewDelete-intersections.mm

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb updated this revision to Diff 315470. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Analysis/NewDelete-intersections.mm

[PATCH] D92176: Don't use sysroot/include when sysroot is empty.

cjdb added a comment. In D92176#2419011 , @manojgupta wrote: > lgtm but not an expert in this area. Ditto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92176/new/ https://reviews.llvm.org/D92176

<    1   2   3   4   5