[PATCH] D152932: [ARM] Adding precommit tests for D146242

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152932/new/ https://reviews.llvm.org/D152932

[PATCH] D153130: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1d7a55a4e06: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3 (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153128: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b7ac6260627: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL1 (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153130: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3

pratlucas created this revision. pratlucas added reviewers: tmatheson, vhscampos. Herald added a subscriber: kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements the new

[PATCH] D153128: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL2

pratlucas created this revision. pratlucas added reviewers: tmatheson, vhscampos, dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds new

[PATCH] D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG852bb68ddb2b: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0753cf2caca7: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pratlucas marked an inline comment as done. Closed by commit rG9ea00fc74c3c: [NFC][AArch64] Use optional returns in target parser instead of invalid… (authored by

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

pratlucas updated this revision to Diff 492491. pratlucas added a comment. Renaming `getDefaultExtensions()` to `getImpliedExtensions()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142540/new/ https://reviews.llvm.org/D142540 Files:

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/unittests/TargetParser/TargetParserTest.cpp:1456 + std::optional Extension = + AArch64::parseArchExtension(ArchExt); + if (!Extension) tmatheson wrote: > I think

[PATCH] D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This updates the AArch64's Target Parser

[PATCH] D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This updates the parsing methods in

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. pratlucas marked an inline comment as done. Closed by commit rG5f6813beed85: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver (authored by

[PATCH] D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8246aceb90c2: [AArch64] Add command line support for v9.4-As Instrumentation Extension (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: clang/test/Driver/aarch64-cssc.c:11 +// RUN: %clang -S -o - -emit-llvm -target aarch64-none-none-eabi -march=armv9.4-a+cssc %s 2>&1 | FileCheck %s +// RUN: %clang -S -o - -emit-llvm

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

pratlucas updated this revision to Diff 491385. pratlucas added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Updated to use the same approach as D141518 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension

pratlucas updated this revision to Diff 491384. pratlucas added a comment. Rebasing, including minor changes due to recent target parser refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141403/new/ https://reviews.llvm.org/D141403

[PATCH] D138792: [AArch64] Improve TargetParser API

pratlucas accepted this revision. pratlucas added a comment. LGTM with a tiny nit. Feel free to fix it when landing the changes. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:164-166 + CPUFeatures CPUFeature; // ? + StringRef DependentFeatures; //

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

pratlucas created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Update the clang driver to include the following features as default

[PATCH] D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension

pratlucas created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces command line support (`+ite`) for the

[PATCH] D140999: [NFC][TargetParser] Deprecate llvm/Support/AArch64TargetParser.h

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/ https://reviews.llvm.org/D140999

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139086/new/ https://reviews.llvm.org/D139086

[PATCH] D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138753/new/ https://reviews.llvm.org/D138753

[PATCH] D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature

pratlucas added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:1686 -TEST(TargetParserTest, AArch64ArchFeatures) { - std::vector Features; Can you keep a unit test covering the new version of the function? Repository: rG LLVM

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:532 + testARMArch("armv9.4-a", "generic", "v9.4a", + ARMBuildAttrs::CPUArch::v8_A)); EXPECT_TRUE( Should this be testing for

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH("armv9-a", ARMV9A, "9-A", "v9a",

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

pratlucas added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:70-76 +AARCH64_ARCH("armv8.9-a", ARMV8_9A, "8.9-A", "v8.9a", + ARMBuildAttrs::CPUArch::v8_A, FK_CRYPTO_NEON_FP_ARMV8, + (AArch64::AEK_CRC | AArch64::AEK_FP | +

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135680/new/ https://reviews.llvm.org/D135680

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

pratlucas added inline comments. Comment at: clang/test/Preprocessor/init-arm.c:404 +// is specified +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi -target-feature +soft-float -target-feature +soft-float-abi < /dev/null | FileCheck -match-full-lines

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70a5c525349b: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 440189. pratlucas added a comment. Updating method to use `MAchineBasickBlock::iterator&`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 439356. pratlucas added a comment. Fixing use-after-poison issue detected by ASAN buildbot. When popping LR on thumb it's value is popped into PC and used as a return. The original return instruction gets erased, invalidating the MachineInstr iterator.

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas added a comment. @RKSimon I was writting my comment above just before I saw your message, lucky they went in in the correct order :) I'm tracking down the source of the invalid `tMOVr` and I'll raise a ticket with the details. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas added a comment. The newly added `frame-chain.ll` test uncovered an issue with an invalid use of the tMOVr instruction, which is only available from V6 onwards. The failure was captured by a buildbot with expensive checks enabled. The issue is unrelated to the codegen changes from

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7625e01d6616: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 436396. pratlucas added a comment. Fixing assertion failure caused by incorrect use of tSTRr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6119053dab67: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas). Repository: rG LLVM Github

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/test/CodeGen/Thumb/frame-access.ll:335 +; CHECK-FP-AAPCS: mov r1, r11 +; CHECK-FP-AAPCS: ldr r0, [r0, r1] +; CHECK: bl i efriedma wrote: > This sequence requires, in

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 435157. pratlucas added a comment. Avoid scavenging extra register when accessing const pool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 2 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:732 + // AAPCS requires use of R11, and PACBTI gets in the way of regular pushes, + // so FP ends up on area two. if (HasFP) {

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 434846. pratlucas marked 2 inline comments as done. pratlucas added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 2 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:1167 + STI.hasV5TOps()); + // Only unused return registers can be used as copy regs at this point + popRegsFromStack(MBB, MI,

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 431634. pratlucas marked 2 inline comments as done. pratlucas added a comment. Avoiding unecessary uses of FP and addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 430991. pratlucas marked 2 inline comments as done. pratlucas added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1844 +for (const auto : MBB) + if (MI.getOpcode() == ARM::tSTRspi || MI.getOpcode() == ARM::tSTRi) +for (const auto :

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 430324. pratlucas marked an inline comment as done. pratlucas added a comment. Fix incorrect use of r11 on load/store instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/Thumb1FrameLowering.cpp:242 + // Find last push instruction for GPRCS2 - spilling of high registers + // (r8-r11) could consist of multiple tPUSH and tMOVr

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 429237. pratlucas added a comment. Adding frame access test coverage, adding check for FrameSetup flag and adjusting calculation of FP value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 427632. pratlucas added a comment. Addressing linting messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files: clang/include/clang/Driver/Options.td

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. pratlucas requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Currently the a AAPCS compliant frame

[PATCH] D115694: [ARM] Introduce an empty "armv8.8-a" architecture.

pratlucas accepted this revision. pratlucas added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115694/new/ https://reviews.llvm.org/D115694 ___ cfe-commits mailing list

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

pratlucas added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:3299 static void setRequiredFeatureString(FeatureBitset FBS, std::string ) { if (FBS[AArch64::HasV8_1aOps]) Str += "ARMv8.1a"; As features can now depend

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110241/new/ https://reviews.llvm.org/D110241

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. The truncate conditions look a lot better and the test coverage seems reasonable now. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b1e25befefc: [AArch64] Adding ACLE intrinsics for the LS64 extension (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93232/new/ https://reviews.llvm.org/D93232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

pratlucas added a comment. No problem! I've pushed the commit on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94233/new/ https://reviews.llvm.org/D94233 ___ cfe-commits mailing list

[PATCH] D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes

This revision was automatically updated to reflect the committed changes. Closed by commit rG59fce6b06616: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function… (authored by jeroen.dobbelaere, committed by pratlucas). Herald added a project: clang. Herald added a subscriber:

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93232/new/ https://reviews.llvm.org/D93232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93231: [ARM] Adding v8.7-A command-line support for the ARM target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5046ebdf6e4: [ARM] Adding v8.7-A command-line support for the ARM target (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4d851b07903: [ARM][AAarch64] Initial command-line support for v8.7-A (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

pratlucas created this revision. Herald added subscribers: danielkiss, jfb, hiraditya, kristof.beyls. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces the ARMv8.7-A LS64 extension's intrinsics for

[PATCH] D93231: [ARM] Adding v8.7-A command-line support for the ARM target

pratlucas created this revision. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This extends the command-line support for the

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

pratlucas updated this revision to Diff 311624. pratlucas added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91776/new/ https://reviews.llvm.org/D91776 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas requested review of this revision. This introduces command-line support for the 'armv8.7-a' architecture name (and an alias

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2c2cc136013: [ARM][AArch64] Adding Neoverse V1 CPU support (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303803. pratlucas added a comment. Removing extra includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303486. pratlucas added a comment. Updating default extensions in target parser to match tablegen features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files:

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas updated this revision to Diff 303091. pratlucas added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90765/new/ https://reviews.llvm.org/D90765 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D90765: [ARM][AArch64] Adding Neoverse V1 CPU support

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas requested review of this revision. Add support for the Neoverse V1 CPU to the ARM and AArch64 backends. This is based on

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas added a comment. Hi @hans , I'll have a look at it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 ___ cfe-commits mailing list

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

This revision was automatically updated to reflect the committed changes. Closed by commit rGa255931c4055: [ARM] Supporting lowering of half-precision FP arguments and returns in… (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rGada4c9dc4a63: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from… (authored by pratlucas). Changed prior to commit: https://reviews.llvm.org/D81451?vs=269453=271677#toc

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

This revision was automatically updated to reflect the committed changes. Closed by commit rG92ad6d57c218: [ARM] Moving CMSE handling of half arguments and return to the backend (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

pratlucas added a comment. Hi @stuij, The changes to the backend only handle the half (f16) type itself, not vectors that have it as their base type. From what I've checked on the AAPCS, the rules for handling those types are a bit different and they would require their own handling in the

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas added a comment. Hi @efriedma, From @SjoerdMeijer's comment and the links he pointed to, it seems to me that making `f16` types legal for all ARM subtargets would be a major undertaking and far from trivial to implement. It's also not clear to me how significant would be the returns

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2267 +// Mask f16 arguments if this is a CMSE nonsecure call +auto ArgVT = Outs[realArgIdx].ArgVT; ostannard wrote: > Could

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 270160. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/lib/Target/ARM/ARMISelLowering.cpp

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 270149. pratlucas added a comment. Rebasing and simplifying function attributes on test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files:

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 270143. pratlucas added a comment. Fixing failure on CodeGen/ARM/GlobalISel/arm-unsupported.ll and making clang-format happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:524 + CallConv)) +return; EVT ValueVT = Val.getValueType(); efriedma wrote:

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269915. pratlucas marked 2 inline comments as done. pratlucas added a comment. Clean-ups + fixing failure in CodeGen/ARM/half.ll test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269466. pratlucas added a comment. Formatting patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 Files: llvm/include/llvm/CodeGen/TargetLowering.h

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269450. pratlucas added a comment. Splitting the patch into two parts: one for introducing the half-precision handling into AArch32's backend and one for removing the existing coercion of those arguments from Clang. Repository: rG LLVM Github Monorepo

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 269452. pratlucas added a comment. Moving the clean-up of the Clang-side handling to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files:

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

pratlucas created this revision. Herald added subscribers: cfe-commits, danielkiss, dmgreen, kristof.beyls. Herald added a project: clang. pratlucas added a parent revision: D81428: [ARM] Moving CMSE handling of half arguments and return to the backend. pratlucas added reviewers: rjmccall, chill,

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas created this revision. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pratlucas added reviewers: chill, rjmccall, ostannard. pratlucas added a parent revision: D75169: [ARM] Enforcing calling convention for

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG8beaba13b8a6: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

pratlucas added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas marked 5 inline comments as done. pratlucas added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10334 Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy)); -auto Alignment = CharUnits::fromQuantity( -BuiltinID ==

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas updated this revision to Diff 267905. pratlucas added a comment. Addressing review comments and extending tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 Files:

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas updated this revision to Diff 266504. pratlucas added a comment. Hi @efriedma and @plotf, Thank you the reduced test and for reverting the original patch. I've updated it to avoid the issue while still capturing the proper argument alignment. Do you mind taking a look before a reland

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

This revision was automatically updated to reflect the committed changes. Closed by commit rG98cad555e291: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts (authored by pratlucas). Changed prior to commit: https://reviews.llvm.org/D79721?vs=263188=266138#toc

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. pratlucas added reviewers: t.p.northover, ostannard, pcc. During CodeGen for AArch64 Neon intrinsics, Clang was incorrectly assuming all the pointers from which loads

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d39df03a984: [Clang][Sema] Capturing section type conflicts between #pragma clang section… (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dac639f285a: [Clang][Sema] Capturing section type conflicts on #pragma clang section (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

pratlucas updated this revision to Diff 262592. pratlucas added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78572/new/ https://reviews.llvm.org/D78572 Files: clang/include/clang/AST/ASTContext.h

  1   2   >