[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 449681. tstellar marked an inline comment as done. tstellar added a comment. Fix option spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc39d7bdd497: libclang.so: Make SONAME the same as LLVM version (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D129160?vs=444843&id=447566#toc Repository: rG LLVM Github Mo

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar added a comment. In D129160#3678441 , @h-vetinari wrote: > In D129160#3678431 , @tstellar > wrote: > >> @h-vetinari Does the release note look OK? > > Basically yes, thank you! I'd still be more precise

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar added a comment. @h-vetinari Does the release note look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

tstellar added a comment. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

tstellar added a comment. I think this commit broke our standalone builds: CMake Error at utils/hmaptool/CMakeLists.txt:1 (install): install PROGRAMS given no DESTINATION! Was the LLVM_TOOLS_INSTALL_DIR in this file supposed to be changed to CLANG_TOOLS_INSTALL_DIR ? Repository: rG LLVM

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Those pre-commit failure seem to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130254/new/ https://reviews.llvm.org/D13

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar updated this revision to Diff 444843. tstellar added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 Files: clang/docs/ReleaseNotes.rst clang/tools/libclang/CMake

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

tstellar added a comment. I similar RFC for this was proposed here: https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621 _

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar created this revision. tstellar added reviewers: MaskRay, h-vetinari. Herald added subscribers: StephenFan, fedor.sergeev, mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This partially

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This has been deprecated for a while, remove it in favor of using cmake's find_package(

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3614298 , @ruiu wrote: > In D125624#3552770 , @tstellar > wrote: > >> In D125624#3552463 , @ruiu wrote: >> OK, as I mentioned. I

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

tstellar added a comment. In D123064#3575503 , @cor3ntin wrote: > @tstellar I saw you say in another path that you got confirmation from > lawyers that it's okay to include UnicodeData.txt (which this patch doesn't > do) and derived data (which this pat

[PATCH] D112916: Confusable identifiers detection

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D112916#3554158 , @Mordante wrote: > In D112916#3113140 , @tstellar > wrote: > >> The LLVM Board of D

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a subscriber: tonic. tstellar added a comment. In D125624#3552463 , @ruiu wrote: >> OK, as I mentioned. I think we need an attorney to review this change and >> confirm that it actually accomplishes this goal. > > Can you add an attorney a

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3552238 , @ruiu wrote: > The motivation of doing this is to be able to build LLVMgold.so without > binutils' source files and make it clear that LLVMgold.so does not include > any GPL code. OK, as I mentioned. I th

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. What is the motivation for this change? I really don't like bundling external headers like this, because it can lead to subtle hard to catch bugs. It also makes it harder to di

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added a comment. I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../ Repository: rG LLVM Github

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

tstellar added inline comments. Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory - ${CMAKE_BINARY_DIR}/$

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

tstellar added a comment. This Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory - ${CMAKE_BINARY_DIR}/

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc behavior

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2156 Prefixes.push_back("/opt/rh/devtoolset-10/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-9/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-8/root/usr"); Mas

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2154 Prefixes.push_back("/opt/rh/gcc-toolset-10/root/usr"); +Prefixes.push_back("/opt/rh/devtoolset-11/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-10/root/usr");

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

tstellar added a comment. In D125165#3504252 , @tra wrote: > LGTM in principle. > > Given that we're introducing a new tool dependency we may want to get a stamp > from someone dealing with build and release. > @tstellar -- do we need to change anything

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 424040. tstellar added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test/CMakeLists.txt clang/test/lit.site.c

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The script is located in the llvm/ sub-directory, so it is not available for when doing a stand-alone build. Repository: rG

[PATCH] D123957: Update the developer policy to mention release notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 __

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

tstellar added a comment. In D123850#3453750 , @cor3ntin wrote: > @tstellar I wasn't sure what the procedure was for backporting fixes, so I > made a PR. I think your suggestion of keeping the old signature works well. > This also modifies the serialized

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

tstellar added a comment. Ok, so maybe my concerns about testing overhead are not that legitimate. That's just something I've heard mentioned in the past. However, I still think this should be fixed in buildkite. It's seems much more sustainable to just bump the timeout in buildkite rather

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

tstellar added a comment. Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

tstellar added a comment. Can you elaborate more on the problem this is solving? Also, what are the user visible changes? Will check-all and check-clang run the same set of tests as before? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/ne

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D122487#3408425 , @rs wrote: > @tstellar thanks for the review. I can't really think of any other way to > test this. I'll wait till Monday if

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar added a comment. The reason I used a minimal check string is because if the warning text changes at all, then the test becomes useful (this is the downside of using -NOT). I wonder if there is another way to test this that might be robust? If not, then I think this change is fine.

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98fd3b359866: Driver: Don't warn on -mbranch-protection when linking (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#3398808 , @JonChesterfield wrote: > It lets applications run with the libomp and libomptarget built with the > toolchain. For users, they don't have to be root. For compiler devs, we test > our work instead of whate

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. Herald added a project: All. Fedora recently banned RUNPATH, so packages built with clang and -fopenmp are rejected by the build system with this change. Can you elaborate more about the intend

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

tstellar created this revision. tstellar added reviewers: chill, vhscampos, stuij, amilendra. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The -mbranch-protection definition in Options.td was not given a Group, so this was causing clang to

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. @xbolva00 I've removed your comment due to inappropriate language and tone. Please find a more constructive way to communicate your point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.or

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. In D118511#3373082 , @dblaikie wrote: > In D118511#3372728 , @jyknight > wrote: > >> In D118511#3371432 , @tstellar >> wrote: >> >>> I'm fine w

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. I'm fine with reverting if you think this is the best solution. I just would like to conclude soon so I can make the final release candidate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. Herald added a project: All. Should we backport this to the release/14.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ c

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar added a comment. Herald added a project: All. @vtjnash There hasn't been consensus on removing support for standalone builds yet, and I'm in favor of keeping them as are some other distribution maintainers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. I have reverted the buildbot configuration change as well: https://github.com/llvm/llvm-zorg/commit/c01d0787c4a11e40d0fed81b0df6841bebc16f7f Now that everything is back to the original state, we can discuss how to proceed. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347177 , @nikic wrote: > Yes, because you reverted the change for that one buildbot, of course it is > green now. You could have also made the buildbot green by disabling tests on > that bot. Or disabling sanitizers

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347161 , @MaskRay wrote: > In D120305#3347160 , @nikic wrote: > >> @MaskRay Please revert the change and all dependent changes you have made. A >> revert is not a personal af

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347151 , @xbolva00 wrote: >>> Given that the bot does not have a high success rate (track record) for at >>> least the past month, I am unsure I am supposed to revert my change. > > What is interesting that always th

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347148 , @MaskRay wrote: > In D120305#3347145 , @tstellar > wrote: > >> In D120305#3347143 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347143 , @MaskRay wrote: > In D120305#3347142 , @tstellar > wrote: > >> In D120305#3347139 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347139 , @MaskRay wrote: > In D120305#3347109 , @tstellar > wrote: > >> [...] >> The issue here has nothing to do with the technical merits of the patch or >> what the root

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347108 , @MaskRay wrote: > In D120305#3347103 , @tstellar > wrote: > >> In D120305#3347058 , @nemanjai >> wrote: >> >>> In D120305#

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347058 , @nemanjai wrote: > In D120305#3346880 , @MaskRay wrote: > >> While I feel sorry for leaving clang-ppc64le-rhel red for some time and am >> willing to fix issues if I

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3346880 , @MaskRay wrote: > In D120305#3346787 , @nemanjai > wrote: > >> In D120305#3346144 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

tstellar created this revision. tstellar requested review of this revision. Herald added a project: clang. Also add some javascript to automatically change that status to "In Progress" when the issue is assigned to someone, and "Clang ToT" when the issue is closed. Note that the feature entries w

[PATCH] D111100: enable plugins for clang-tidy

tstellar added a comment. I've proposed a fix for the standalone builds here D120301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 __

[PATCH] D120301: clang-tools-extra: Make test dependency on LLVMHello optional

tstellar created this revision. tstellar added a reviewer: vtjnash. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang-tools-extra. This fixes clang + clang-tools-extra standalone build after 36892727e4f19a60778e371d78f8fb09d8122c85

[PATCH] D111100: enable plugins for clang-tidy

tstellar added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")

[PATCH] D111100: enable plugins for clang-tidy

tstellar added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. I would like to keep this supported upstream as this is how we build clang in Fedora. If some people find the stand-alone builds burdensome, then I think it would be best to sta

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

tstellar added a comment. @yaxunl This looks good to me, you can go ahead and cherry-pick it directly to release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe80c52986e1b: [docs] Remove hard-coded version numbers from sphinx configs (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a comment. Can you add a release note to go along with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 ___ cfe-commits mailing list

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a comment. So to summarize: this will change the ABI of clang built objects from clang13 -> clang14 in order to make clang14 compatible with gcc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D11

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

tstellar added a comment. We may have time to fit it in to the release, but no guarantees. Can you file an issue for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116272/new/ https://reviews.llvm.org/D116272 ___

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

tstellar added a comment. @ZarkoCA If you are planning to do a lot of this, it might be good to write a script (or a clang-tidy check even) that we can add to CI, so these terms don't get re-introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. In D112730#3133822 , @carlosgalvezp wrote: > @tstellar @tonic I have finally received an answer from AUTOSAR. Let me know > if you'd like me to CC you the mail chain to see the exact discussion. Can you cc bo...@llvm.org on th

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

tstellar added a comment. In D8467#3095610 , @zixuan-wu wrote: > Hi, I am wondering could -fsized-deallocation this be enabled by default > nowadays in 2021? Were you planning to work on this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. @carlosgalvezp The LLVM Foundation Board will conduct a legal reivew of this patch. Would you be able to share any information you have about the license or usage restrictions for the AUTOSAR specification? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730

[PATCH] D112916: Confusable identifiers detection

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. The LLVM Board of Directors will do a legal review of this change. We will give an update in 4-6 weeks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. @carlosgalvezp Did you write this patch or did you get it from someone else? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D112030: [docs] Remove Makefile.sphinx files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc16655f138b1: [docs] Remove Makefile.sphinx files (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. tstellar requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added a subscriber: cfe-commits. This updates all the non-r

[PATCH] D112030: [docs] Remove Makefile.sphinx files

tstellar added a comment. In D112030#3071393 , @sylvestre.ledru wrote: > I am using them but I can move to sphinx calls. How much time do you need to transition? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112030: [docs] Remove Makefile.sphinx files

tstellar created this revision. tstellar added reviewers: sylvestre.ledru, pcc, silvas. tstellar requested review of this revision. Herald added projects: clang, libc++, LLVM. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Does anyone still use these? I wa

[PATCH] D111367: [Driver] Change -dumpmachine to respect --target/LLVM_DEFAULT_TARGET_TRIPLE verbatim

tstellar added a comment. In D111367#3049772 , @MaskRay wrote: > In D111367#3049700 , @hvdijk wrote: > >> Does Red Hat actually use `x86_64-redhat-linux` with LLVM (other than for >> finding the GCC installation)

[PATCH] D111207: Driver: Add a gcc equivalent triple to the list of triples to search

tstellar created this revision. tstellar added reviewers: aaronpuchert, hvdijk, MaskRay. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. There are some gcc triples, like x86_64-redhat-linux, that provide the same behavior as a clang tr

[PATCH] D109727: [Driver] Remove unneeded *-suse-* triples

tstellar added a comment. This patch should depend on D109837 , otherwise clang builds will be broken on SUSE if you don't pass -DLLVM_DEFAULT_TARGET_TRIPLE to cmake when configuring, and I don't think we should require users to pass this option. Repository:

[PATCH] D110899: [Driver][XRay][test] XFAIL on linux with no environment specified

tstellar created this revision. tstellar added a reviewer: dberris. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110899 Files: clang/test/Driver/XRay/xray-instr

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

tstellar added a comment. @aaronpuchert Can you file a bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D109812: [compiler-rt] Move -fno-omit-frame-pointer check to common config-ix

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109812/new/ https://reviews.llvm.org/D109812 ___ cfe-commits mailing l

[PATCH] D109694: Driver: Add preferred gcc triples for Red Hat operating systems

tstellar created this revision. tstellar added reviewers: serge-sans-paille, MaskRay, mgorny. Herald added a subscriber: pengfei. tstellar requested review of this revision. Herald added a project: clang. The GCCInstallationDetector has a list of gcc triples to search for when trying to find a val

[PATCH] D109693: Driver: Remove major release version detection for RHEL

tstellar created this revision. tstellar added a reviewer: serge-sans-paille. tstellar requested review of this revision. Herald added a project: clang. We treat all release of RHEL the same in the driver, so we don't need to detect the RHEL major release version. Repository: rG LLVM Github Mo

[PATCH] D109023: libclang: Document the soname change in the release notes

tstellar accepted this revision. tstellar added a comment. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109023/new/ https://reviews.llvm.org/D109023 ___ cfe-commits mailing list cfe-com

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109000/new/ https://reviews.llvm.org/D109000 ___

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.llvm_external_lit if config.llvm_external_lit else

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

tstellar added a comment. > Not all downstream users may want to build all tools shipped with clang. > clang-repl for us in particular can sometimes lead to flaky builds when > testing a toolchain built with LTO. Can we just fix clang-repl instead? I think there needs to be a more compelling

[PATCH] D107559: [clang] Fix libclang linking on Solaris

tstellar added a comment. In D107559#2928999 , @ro wrote: > In D107559#2928851 , @tstellar > wrote: > >> Is there any kind of comment that is supported by all linkers? > > Seems there isn't. In that case, we cou

[PATCH] D107559: [clang] Fix libclang linking on Solaris

tstellar added a comment. Is there any kind of comment that is supported by all linkers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/ https://reviews.llvm.org/D107559 ___ cfe-commits mailing

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

tstellar added a comment. Can someone file a bug for this and put release-13.0.0 in the blocks field so we can track it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

tstellar added a comment. Do we have all the issues fixed in trunk yet or do we need to revert in the release/13.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

tstellar added a comment. This is something we could merge, just need a code owner ack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 ___ cfe-commits mailing li

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

tstellar added a comment. @mstorsjo Yes, go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

tstellar added a comment. I've backported this as 6eaf46beb4628abf8f5b09a333bcd44d2fb2aff9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/ https://reviews.llvm.org/D1

[PATCH] D106974: libcang: Add missing function to libclang.map

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4edb2b1ba0b: libcang: Add missing function to libclang.map (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106974: libcang: Add missing function to libclang.map

tstellar updated this revision to Diff 362439. tstellar added a comment. Add missing ; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106974/new/ https://reviews.llvm.org/D106974 Files: clang/tools/libclang/libclang.map Index: clang/tools/libcl

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. Can you let me know if D106974 fixes the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527

[PATCH] D106974: libcang: Add missing function to libclang.map

tstellar created this revision. tstellar added a reviewer: jrtc27. tstellar requested review of this revision. Herald added a project: clang. This function is marked with CINDEX_LINKAGE, but was never added to the export list / linker script. Repository: rG LLVM Github Monorepo https://review

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. It looks like that function is missing from libclang.map, I think if you add it there it should fix the test. I'm going to check to see if there are any more missing functions and then commit a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2910319 , @jrtc27 wrote: > I'm seeing the test fail locally (on ca0fe3447fb85762838468537d93d4ef82c5a1af > ) with: > > 000d1799 t clang_Co

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2908944 , @Bigcheese wrote: > Also, this python script just doesn't work. It's missing a sys import, a "w" > flag, and a new line after each write. It also dumps the output into the > source directory. Was this actua

<    1   2   3   4   >