[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:-5568 + if (SS.isNotEmpty() && SS.getScopeRep()) { +NestedNameSpecifier *NNS = SS.getScopeRep(); +if (NNS->getAsNamespace() || NNS->getAsNamespaceAlias()) { + TPA.Revert(); +

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 473485. v.g.vassilev marked 2 inline comments as done. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Address comments. Call `isCurrentClassName` before calling `isConstructorDeclarator`. CHANGES SINCE LAST ACTION

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. In D127284#3902487 , @aaron.ballman wrote: > It looks like precommit CI caught a relevant issue that should be addressed. Yes, I have a comment (starting with "The only

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a subscriber: akyrtzi. v.g.vassilev added inline comments. Comment at: clang/include/clang/Basic/DeclNodes.td:98 def FileScopeAsm : DeclNode; +def TopLevelStmt : DeclNode; def AccessSpec : DeclNode; aaron.ballman wrote: > Oh boy, that node

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 472731. v.g.vassilev marked 21 inline comments as done. v.g.vassilev added a comment. Address more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:28-33 +namespace Ns {namespace Ns { void Ns(); void Fs();}} +void Ns::Ns::Ns() { printf("void Ns::Ns::Ns()\n"); } +void Ns::Ns::Fs() {} + +Ns::Ns::Fs(); +Ns::Ns::Ns();

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 472224. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 47. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a comment. This looks reasonable to me but let's have another pair of eyes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 ___

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a subscriber: sunho. v.g.vassilev added inline comments. Comment at: clang/include/clang/AST/ASTConsumer.h:54-59 + /// HandleTopLevelStmts - Handle the specified top-level statements. This is + /// called by the parser to process every top-level Stmt* in

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 457830. v.g.vassilev marked 9 inline comments as done. v.g.vassilev added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a comment. Adding Aaron as a reviewer who hopefully could speed up the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___

[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Let's move forward with this patch and rely on a post-commit review if necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

v.g.vassilev added a comment. Thanks for working on this! I left some comments. I did not look very deep in the patch but it seems quite consistent to the rest of the code in Sema. Can you provide some performance numbers for this patch. I believe that the less confident reviewers will be more

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

v.g.vassilev added a comment. Maybe we can add a little more context. In the case of static compilation the file system is pretty much read-only and taking a snapshot of it usually is sufficient. In the interactive C++ case the compilation is longer and people can create and include files,

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. @tapaswenipathak, ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3381 ) && isConstructorDeclarator(/*Unqualified*/ false)) goto DoneWithDeclSpec; The only remaining failure is in

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 449066. v.g.vassilev edited the summary of this revision. v.g.vassilev added a comment. Herald added subscribers: sstefan1, Anastasia. Herald added a reviewer: jdoerfert. Rely on the CXXScopeSpec to detect more accurately if we are parsing a constructor

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev accepted this revision. v.g.vassilev added inline comments. Comment at: clang/tools/clang-repl/ClangRepl.cpp:138 - return checkDiagErrors(Interp->getCompilerInstance()); + llvm::llvm_shutdown(); + This seems not needed. We have already

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev added a comment. In D130422#3689397 , @junaire wrote: > In D130422#3689392 , @v.g.vassilev > wrote: > >> Thanks for working on this. This is one of the problems where is hard to >> find the right

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for working on this. This is one of the problems where is hard to find the right behavior. For example, if a repl running in interactive issues an error and then

[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

v.g.vassilev added reviewers: rjmccall, rsmith. v.g.vassilev added a comment. This looks good to me but let’s add more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130831/new/ https://reviews.llvm.org/D130831

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a comment. @Purva-Chaudhari can you rebase this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125944/new/ https://reviews.llvm.org/D125944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

v.g.vassilev added a comment. In D130710#3685470 , @akyrtzi wrote: > @v.g.vassilev is the functionality of "write `ORIGINAL_PCH_DIR` and resolve > headers relative to it if PCH file and headers moved together" used by > `Cling`? We currently use

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 447120. v.g.vassilev retitled this revision from "[WIP] [clang-repl] Support statements on global scope in incremental mode." to "[clang-repl] Support statements on global scope in incremental mode.". v.g.vassilev edited the summary of this revision.

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:179 +bool +HandleTopLevelStmts(const llvm::SmallVectorImpl ) override { + if (Diags.hasErrorOccurred()) Hi @rjmccall, this patch tries to add support for statements

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 447098. v.g.vassilev added a comment. Keep the patch minimal, exclude opencl, etc for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5247-5248 + // ObjC + case tok::at: +return getLangOpts().ObjC; + rsmith wrote: > In Objective-C, both declarations and expressions can start with `@`. In > general we'd need to

[PATCH] D130422: [clang-repl] Fix incorrect return code

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/fail.cpp:6 +// UNSUPPORTED: system-aix +// XFAIL: * +// CHECK-DRIVER: i = 10 Why this is marked as XFAIL? If it is only for the return code we can add the `not` command in front to make the

[PATCH] D130420: [CodeGen] Consider MangleCtx when move lazy emission States

v.g.vassilev added reviewers: rsmith, rjmccall. v.g.vassilev added a comment. Let's add more reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130420/new/ https://reviews.llvm.org/D130420 ___

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125946/new/ https://reviews.llvm.org/D125946 ___ cfe-commits mailing list

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 446817. v.g.vassilev added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h clang/include/clang/Parse/Parser.h

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 446815. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/ASTConsumer.h

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. @tapaswenipathak, ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I would propose to move forward with this patch. It was partially discussed in https://reviews.llvm.org/D126781 and we can rely on a post-commit review if necessary. Repository:

[PATCH] D128974: [RFC] [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128974/new/ https://reviews.llvm.org/D128974 ___ cfe-commits mailing list

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. In D126266#3629145 , @vsapsai wrote: > Hmm, I'm concerned with the pieces added purely for testing. Specifically, > `FileEntriesToReread` and TestHelper friend functions. Need to think how else > we can test it. I am not

[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Let's move forward and we can remove the XFAIL once https://reviews.llvm.org/D128968 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128782: [CodeGen] Keep track of decls that were deferred and have been emitted.

v.g.vassilev added reviewers: rsmith, rjmccall. v.g.vassilev added a subscriber: rjmccall. v.g.vassilev added a comment. I am adding some more reviewers as I think this patch is ready to go. @rjmccall, could you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128853: [Interpreter] Pass target features to JIT

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the clarification! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128853/new/ https://reviews.llvm.org/D128853

[PATCH] D128853: [Interpreter] Pass target features to JIT

v.g.vassilev added a comment. Looks good to me but can we add a test? Do we have builders with that target? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128853/new/ https://reviews.llvm.org/D128853 ___

[PATCH] D128319: Survive #pragma once from virtual file.

v.g.vassilev added a comment. Historically, the patch was developed before the extended support of virtual files in Clang. Given that this is very hard to test and it looks like this is not needed on our end anymore. I'd propose to pause this for now. Repository: rG LLVM Github Monorepo

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Herald added a project: All. This landed slightly modified here: https://github.com/llvm/llvm-project/commit/4d54e543abd5d0a8b0a321f8c292252f4895693a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3/new/

[PATCH] D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5eaf500f244: [clang] Add missing Interpreter - ClangDriverOptions dependency (authored by v.g.vassilev). Repository: rG LLVM Github Monorepo

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe881d85371bf: Allow interfaces to operate on in-memory buffers with no source location info. (authored by tapaswenipathak, committed by v.g.vassilev). Changed prior to commit:

[PATCH] D126682: [clang-repl] Implement code undo

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682

[PATCH] D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent.

v.g.vassilev resigned from this revision. v.g.vassilev added a comment. Herald added a project: All. According to godbolt this example does not crash anymore. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37797/new/ https://reviews.llvm.org/D37797

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a comment. In D125944#3544341 , @v.g.vassilev wrote: > @Purva-Chaudhari, can you rebase this patch, seems that it is not buildable. > > @rsmith, we need to do something similar in cling to handle pending template > instantiations, I

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify dblaikie wrote: > v.g.vassilev

[PATCH] D54986: Make CodeGen choose when to emit vtables.

v.g.vassilev resigned from this revision. v.g.vassilev added a comment. Herald added a project: All. I think this landed in a different form. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986

[PATCH] D128589: [clang-repl] Support destructors of global objects.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, modulo the comment. Comment at: clang/lib/Interpreter/IncrementalExecutor.h:46 llvm::Error runCtors() const; + llvm::Error cleanUp(); llvm::Expected

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. After landing https://reviews.llvm.org/D126682 we might be able to write a test in clang-repl such as: cpp clang-repl> #include clang-repl> #include clang-repl>using namespace std; clang-repl> int write_str (const char* str) { ofstream myfile;

[PATCH] D128257: invalidateCache in addModule and removeModules

v.g.vassilev added a comment. I think this patch is not needed in the `main` branch as https://github.com/llvm/llvm-project/commit/f91b6f8159b101688eef87c75179209699c0d405 removes the need of calling `invalidateCache` altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128319: Survive #pragma once from virtual file.

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a comment. Can we write a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128319/new/ https://reviews.llvm.org/D128319 ___

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + void Restore(PartialTranslationUnit ); + v.g.vassilev wrote: > I am not sure if that's the best function. We Please ignore this comment it was superseded by

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added a comment. Thanks for working on this. Here are some more comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + void Restore(PartialTranslationUnit ); + I am not sure if that's the best function. We

[PATCH] D126183: Implement soft reset of the diagnostics engine.

This revision was automatically updated to reflect the committed changes. Closed by commit rG946c45a4ed5d: Implement soft reset of the diagnostics engine. (authored by tapaswenipathak, committed by v.g.vassilev). Changed prior to commit: https://reviews.llvm.org/D126183?vs=436750=439757#toc

[PATCH] D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency

v.g.vassilev added a comment. Herald added a project: All. @t184256, do we still need this? Should I commit it in case you don't have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115827/new/ https://reviews.llvm.org/D115827

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. I'd propose to move forward here and rely on eventual post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88780/new/

[PATCH] D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Let's move forward with this and rely on eventual post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126620/new/

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added reviewers: sgraenitz, lhames, rjmccall. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. I think we are in a good shape to broaden the list of reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); junaire

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); We should

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added a comment. In D126682#3546865 , @junaire wrote: > this depends on https://reviews.llvm.org/D126684 I would prefer to merge them into one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1500 + +assert(WeakRefReferences.empty() && + "Not all WeakRefRefs have been applied"); It seems that we forgot to move the `WeakRefReferences`? Repository: rG

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, rjmccall, lhames, sgraenitz. Herald added a subscriber: StephenFan. Herald added a project: All. v.g.vassilev requested review of this revision. This patch teaches clang to parse statements on the global scope to allow:

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:200 // FIXME: Do not reset the pragma handlers. +Diags.Reset(true); We should remove this fixme, too. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

v.g.vassilev added a comment. This looks reasonable to me... @shafik, @teemperor what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88780/new/ https://reviews.llvm.org/D88780 ___

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1506 + + struct KeepLazyEmiitedSymRAII { +std::unique_ptr OldBuilder; Would it make sense to make the RAII a friend to avoid adding the accessors of various structures?

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. This looks good to me, modulo the inline comment. Let's wait for @rsmith's green light. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:201 //

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

v.g.vassilev added a comment. In D126781#3554845 , @rjmccall wrote: > Okay, I understand. So, first off, I wouldn't really call that a "weak" > symbol rather than, say, a lazily-emitted symbol; "weak" already has plenty > of different senses, and we

[PATCH] D126781: [CodeGen] Correctly handle weak symbols in the codegen

v.g.vassilev added a comment. Thanks for the prompt reply. We have seen that when there is an inline/weak symbol with no use CodeGen decides not to emit that symbol and moves it into a map. Upon a use it would lazily emit it. However, in cling/clang-repl the use might come on the next line,

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

v.g.vassilev added a comment. In D123674#3546722 , @uabelho wrote: > Hi, > > I noticed that the testcase Interpreter/execute.cpp starts failing with this > patch when run/compiled with asan: > > Failed Tests (1): > Clang :: Interpreter/execute.cpp

[PATCH] D126620: [clang] AST/Print: honor AlwaysIncludeTypeForTemplateArgument policy

v.g.vassilev added a comment. This patch fixes our test case which we intended to fix with: From 17e94a6a2adc3eb8d5fcc532eb1f3e57cc59b0fd Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Mon, 23 May 2022 21:36:43 + Subject: [PATCH] Fix type printing to not include the suffix

[PATCH] D126674: [clang] NFC: introduce test for D126620

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126674/new/ https://reviews.llvm.org/D126674

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/clangtests.cpp:1 +// RUN: clang-repl %S/../Lexer/badstring_in_if0.c -Xcc -E -Xcc -verify +// RUN: clang-repl %S/../Lexer/unknown-char.c -Xcc -E -Xcc -verify dblaikie wrote: > dblaikie wrote:

[PATCH] D125944: Template instantiation error recovery

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. @Purva-Chaudhari, can you rebase this patch, seems that it is not buildable. @rsmith, we need to do something similar in cling to handle pending template instantiations, I guess the

[PATCH] D125946: Handles failing driver tests of clang

v.g.vassilev added reviewers: rsmith, lhames, dblaikie, sgraenitz. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. @Purva-Chaudhari, this looks reasonable to me. I am adding more reviewers to discuss the way we refer other tests from

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ff27fe1ff03: [clang-repl] Recover the lookup tables of the primary context. (authored by Purva-Chaudhari, committed by v.g.vassilev). Herald added a project: clang. Changed prior to commit:

[PATCH] D123674: Clang-Repl Error Recovery Bug Fix

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Apologies for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123674/new/ https://reviews.llvm.org/D123674 ___

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0eb32d2aa0: Also remove the empty StoredDeclsList entry from the lookup table (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev closed this revision. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. Landed in https://github.com/llvm/llvm-project/commit/788e0f7f3e96a9d61c2412e452c4589e2693b79a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121413/new/

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev added reviewers: rsmith, vsapsai. v.g.vassilev added a comment. Just to add that the `invalidateCache` is important for cling and clang-repl where we do something like: clang-repl> #include "file_with_error.h" // error is printed, we

[PATCH] D122546: Let clang-repl link privately against Clang components

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks for the clarification! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122546/new/ https://reviews.llvm.org/D122546

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev updated this revision to Diff 414494. v.g.vassilev added a comment. Order fwd decls alphabetically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121413/new/ https://reviews.llvm.org/D121413 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, lhames, sgraenitz. Herald added a project: All. v.g.vassilev requested review of this revision. This patch will allow better incremental adoption of these changes in downstream cling and other users which want to

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

v.g.vassilev added a comment. Herald added a project: All. ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119675/new/ https://reviews.llvm.org/D119675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, balazske. Herald added a reviewer: shafik. v.g.vassilev requested review of this revision. In case where we have removed all declarations for a given declaration name entry we should remove the whole StoredDeclsMap entry.

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev closed this revision. v.g.vassilev added a comment. That change landed in 4fb0805c6525b13e50067b9ddfe8677a0b7b2d7c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112663/new/

[PATCH] D115827: [clang]: add missing Interpreter -> ClangDriverOptions dependency

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115827/new/ https://reviews.llvm.org/D115827

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); +

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:237-240 + std::string MangledName = MangleName(TmpltSpec); + typedef int (*TemplateSpecFn)(void *); + auto fn = (TemplateSpecFn)cantFail(Interp->getSymbolAddress(MangledName)); +

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/IncrementalProcessingTest.cpp:20 #include "clang/Sema/Sema.h" +#include "clang/Sema/TemplateDeduction.h" #include "llvm/ADT/Triple.h" rsmith wrote: > Given that this file is unchanged,

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev updated this revision to Diff 386098. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments and fix the windows bot failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112663/new/ https://reviews.llvm.org/D112663 Files:

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

v.g.vassilev added a comment. In D112349#3111927 , @erichkeane wrote: > In D112349#3111873 , @ibookstein > wrote: > >> And how is Cling expecting CFE to deal with partial knowledge situations at >> the

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#3099816 , @uabelho wrote: > In D107049#3096807 , @v.g.vassilev > wrote: > >> Can you share your cmake config line, the target triple and architecture? > >

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D107049#3096727 , @uabelho wrote: > Hi, > > We're seeing a problem with this patch in our downstream (not public) > buildbots. With an asan-built compiler we see the

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

v.g.vassilev updated this revision to Diff 382939. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112663/new/ https://reviews.llvm.org/D112663 Files:

<    1   2   3   4   5   6   7   >