[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-03 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Thanks for confirming! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114968/new/ https://reviews.llvm.org/D114968 ___ cfe-commits

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D114968#3168123 , @dexonsmith wrote: > In D114968#3167519 , @jansvoboda11 > wrote: > >> Assuming the filesystem doesn't change during dependency scanning, this >> change keeps the

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D114968#3167519 , @jansvoboda11 wrote: > Assuming the filesystem doesn't change during dependency scanning, this > change keeps

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. Assuming the filesystem doesn't change during dependency scanning, this change keeps the consistency between stat/read calls for minimized files. Thinking about it some more though, the original reason for reading files eagerly (even for stat calls) was most

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 391370. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114968/new/ https://reviews.llvm.org/D114968 Files:

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D114966 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114968 Files: