[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. In D155544#4523857 , @amyk wrote: > Wouldn't this patch need to land before the back-end patch, because I > introduce the option here, and then I use it in the backend patch? Please move the `llvm/` changes into

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Amy Kwan via Phabricator via cfe-commits
amyk added a comment. In D155544#4523536 , @hubert.reinterpretcast wrote: > Patch should not land before back-end patch. I also suggest having the patch > incorporate the new option into the Clang release notes before it lands. I'm currently

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Driver/Options.td:4095 + HelpText<"Produce a faster access sequence for local-exec TLS variables " + "where the offset from the thread pointer value is encoded as an " + "immediate

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Patch should not land before back-end patch. I also suggest having the patch incorporate the new option into the Clang release notes before it lands. Comment at: llvm/lib/Target/PowerPC/PPC.td:324 + "Produce a faster

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Stefan Pintilie via Phabricator via cfe-commits
stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land. I think this patch makes sense to me. LGTM. Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:15 + +; Make sure that the test was

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-21 Thread Digger Lin via Phabricator via cfe-commits
DiggerLin added inline comments. Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:15 + +; Make sure that the test was actually compiled successfully after using the +; -maix-small-local-exec-tls option. since the patch only add a new

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

2023-07-17 Thread Amy Kwan via Phabricator via cfe-commits
amyk created this revision. amyk added reviewers: PowerPC, stefanp, kamaub, nemanjai, hubert.reinterpretcast. amyk added a project: LLVM. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a project: clang. Herald added