This revision was automatically updated to reflect the committed changes.
Closed by commit rL284881: [libcxx] Support
std::regex_constants::match_not_null (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D25595?vs=75186&id=75480#toc
Repository:
rL LLVM
https://review
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D25595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
timshen updated this revision to Diff 75186.
timshen added a comment.
Add tests for regex_match.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass
timshen added a comment.
In https://reviews.llvm.org/D25595#574364, @mclow.lists wrote:
> Do we need to test calling `regex_match` with `match_not_null`?
> If not, then I think this is good to go.
Done.
> Do you have commit access, or would you rather I committed it?
Yes, I have the commit a
mclow.lists added a comment.
Do we need to test calling `regex_match` with `match_not_null`?
If not, then I think this is good to go.
Do you have commit access, or would you rather I committed it?
https://reviews.llvm.org/D25595
___
cfe-commits mai
mclow.lists added a comment.
In https://reviews.llvm.org/D25595#572043, @timshen wrote:
> BTW, `re.const/re.matchflag/match_flag_type.pass.cpp` contains match_not_bow,
> but it doesn't actually test the functionality.
It tests that it exists and that it has a sane value - which are a good thin
timshen added a comment.
In https://reviews.llvm.org/D25595#571171, @mclow.lists wrote:
> I like the fix. :-)
>
> However, I think that the test, rather than going in a bug specific file
> (pr21597.pass.cpp), should be added to the existing tests - where it should
> have been in the first place
timshen updated this revision to Diff 74894.
timshen marked an inline comment as done.
timshen added a comment.
Updated file location and documentation.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libc
mclow.lists added inline comments.
Comment at: libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp:12
+
+// template
+// bool
Rather than this comment about `regex_search`, there should be a comment about
`match_not_null`, which is really what we're te
mclow.lists added a comment.
I like the fix. :-)
However, I think that the test, rather than going in a bug specific file
(pr21597.pass.cpp), should be added to the existing tests - where it should
have been in the first place. (If this test had been there in the first place,
we would have re
timshen created this revision.
timshen added reviewers: mclow.lists, EricWF.
timshen added a subscriber: cfe-commits.
Fixes PR21597.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp
Index: libcxx/test/std/re/re.alg/re.alg
11 matches
Mail list logo
