This revision was automatically updated to reflect the committed changes.
Closed by commit rL350029: [xray] Disable alignas() for thread_local objects on
NetBSD (authored by mgorny, committed by ).
Herald added a subscriber: delcypher.
Changed prior to commit:
mgorny updated this revision to Diff 179414.
mgorny marked 2 inline comments as done.
mgorny added a comment.
Reordered.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56000/new/
https://reviews.llvm.org/D56000
Files:
lib/xray/xray_basic_logging.cc
lib/xray/xray_defs.h
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at: lib/xray/xray_defs.h:22
+#if !SANITIZER_NETBSD
+#define XRAY_TLS_ALIGNAS(x) alignas(x)
dberris wrote:
> krytarowski wrote:
> > I would switch the order, in order to remove
dberris added inline comments.
Comment at: lib/xray/xray_defs.h:22
+#if !SANITIZER_NETBSD
+#define XRAY_TLS_ALIGNAS(x) alignas(x)
krytarowski wrote:
> I would switch the order, in order to remove unneeded negation.
>
> ```
> #if SANITIZER_NETBSD
> ...
> #else
krytarowski added inline comments.
Comment at: lib/xray/xray_defs.h:22
+#if !SANITIZER_NETBSD
+#define XRAY_TLS_ALIGNAS(x) alignas(x)
I would switch the order, in order to remove unneeded negation.
```
#if SANITIZER_NETBSD
...
#else
...
#endif
```
`#define
mgorny marked 3 inline comments as done.
mgorny added a comment.
Updated as requested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56000/new/
https://reviews.llvm.org/D56000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
mgorny updated this revision to Diff 179297.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56000/new/
https://reviews.llvm.org/D56000
Files:
lib/xray/xray_basic_logging.cc
lib/xray/xray_defs.h
lib/xray/xray_fdr_logging.cc
Index: lib/xray/xray_fdr_logging.cc
krytarowski added inline comments.
Comment at: lib/xray/xray_basic_logging.cc:58
-struct alignas(64) ThreadLocalData {
+struct
+/* TLD is not aligned properly on NetBSD, resulting in segfault */
krytarowski wrote:
> mgorny wrote:
> > krytarowski wrote:
> > >
krytarowski added inline comments.
Comment at: lib/xray/xray_basic_logging.cc:58
-struct alignas(64) ThreadLocalData {
+struct
+/* TLD is not aligned properly on NetBSD, resulting in segfault */
mgorny wrote:
> krytarowski wrote:
> > Can we introduce a macro
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at: lib/xray/xray_basic_logging.cc:58
-struct alignas(64) ThreadLocalData {
+struct
+/* TLD is not aligned properly on NetBSD, resulting in segfault */
krytarowski wrote:
> Can we
krytarowski added inline comments.
Comment at: lib/xray/xray_basic_logging.cc:58
-struct alignas(64) ThreadLocalData {
+struct
+/* TLD is not aligned properly on NetBSD, resulting in segfault */
Can we introduce a macro like:
```
#if SANITIZER_NETBSD
#define
mgorny created this revision.
mgorny added reviewers: krytarowski, dberris, vitalybuka.
Herald added subscribers: Sanitizers, llvm-commits.
Disable enforcing alignas() for structs that are used as thread_local
data on NetBSD. The NetBSD ld.so implementation is buggy and does
not enforce correct
12 matches
Mail list logo
