[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2071997 , @sbc100 wrote: > In D80876#2070233 , @mstorsjo wrote: > > > In D80876#2069970 , @sbc100 wrote: > > > > > Do you know how gcc

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. In D80876#2070233 , @mstorsjo wrote: > In D80876#2069970 , @sbc100 wrote: > > > Do you know how gcc handles this case when running on mingw? > > > It uses the gnu/unix quoting style - so

[PATCH] D80876: [clang] Default to windows response files when running on windows

mati865 added a comment. I don't have strong opinion here as I don't know this topic well (things just worked so far). That said if Clang stops working as a drop-in replacement for GCC with commonly used build systems, MSYS2 will have to carry one more patch to bring back old behaviour.

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2069970 , @sbc100 wrote: > Do you know how gcc handles this case when running on mingw? It uses the gnu/unix quoting style - so that's the case for wanting clang to preserve compatibility with that behaviour. The

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. Do you know how gcc handles this case when running on mingw? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org/D80876 ___ cfe-commits mailing

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a subscriber: mati865. mstorsjo added a comment. In D80876#2069418 , @sbc100 wrote: > If we want want to have the default on windows be dependent on mingw vs > not-mingw then we should do it across the board so it applies to llvm-ar, >

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. The problem I ran into regarding the quoting style differences was trying to refer to filenames that contains single quote characters: Here is our test case that I've currently disabled on windows pending the resolution of this issue:

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. If we want want to have the default on windows be dependent on mingw vs not-mingw then we should do it across the board so it applies to llvm-ar, lld, and other tools. Right now I don't think any of those other tools have any special mingw handling. Would it make

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2068428 , @mstorsjo wrote: > But as for keeping the old default in mingw environments, would it make sense > to, if on windows, check the default target triple, and if that's a mingw > target

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a comment. In D80876#2067532 , @rnk wrote: > This seems wrong for mingw, so check with @mstorsjo. Thanks for the headsup! I agree that this change would make sense and would make things more consistent in general, but @rnk is also right

[PATCH] D80876: [clang] Default to windows response files when running on windows

rnk added a comment. This seems wrong for mingw, so check with @mstorsjo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/ https://reviews.llvm.org/D80876 ___ cfe-commits mailing list

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. Re testing, you could copy clang/test/Driver/at_file_win.c, which has an explicit `--rsp-quoting=windows`; remove that option and make it `REQUIRES: system-windows`. That should do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. It looks like your patch will allow us to remove a private patch that has a similar effect. Incidentally if I apply this to an upstream checkout on Windows, I see clang/test/Driver/at_file.c fails, so you'd at least need to do something for that. (`UNSUPPORTED:

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a subscriber: rnk. probinson added a comment. I was about to add @rnk who I remember has been in Windows driver behavior discussions in the past; except he has cleverly left a note that he's away June-Sept. Oh well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. Indeed I am mis-remembering, sorry about that! We use gnu-style command-line options but we change RSPQuoting from Default to Windows; assuming getProcessTriple() is the host not the target, your change should have the same effect. I'll try removing our private

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added a comment. As a functional change it should definitely have a functional test. Let me double-check on how our stuff behaves, I may be mis-remembering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80876/new/

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: clang/tools/driver/driver.cpp:391 +if (ClangCLMode || +llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows()) + Tokenizer = ::cl::TokenizeWindowsCommandLine;

[PATCH] D80876: [clang] Default to windows response files when running on windows

probinson added inline comments. Comment at: clang/tools/driver/driver.cpp:391 +if (ClangCLMode || +llvm::Triple(llvm::sys::getProcessTriple()).isOSWindows()) + Tokenizer = ::cl::TokenizeWindowsCommandLine; Testing the triple is a functional

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin. Herald added a project: clang. sbc100 added a reviewer: ruiu. This matches other tools such as llvm-ar, lld, etc. This consistency is useful when authoring downstream tools as it means they can always use