Re: [PATCH] D20113: Fix mangled name of method with ns_consumed parameters.

thakis added a subscriber: thakis. thakis accepted this revision. thakis added a reviewer: thakis. thakis added a comment. This revision is now accepted and ready to land. We use phabricator not very dogmatically. If John says this looks good, then this looks good, even if phab didn't get the

Re: [PATCH] D20581: [include-fixer] Simplify the code since we won't handle multiple includes at once.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270700: [include-fixer] Simplify the code since we won't handle multiple includes at… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20581?vs=58272=58412#toc Repository: rL

RE: r267590 - [OpenCL] Add predefined macros.

This is because OpenCL sets C99 flag as being superset of it. If you check in clang/Frontend/LangStandards.def LANGSTANDARD(opencl, "cl", "OpenCL 1.0", LineComment | C99 | Digraphs | HexFloat) We should undo this change as it leaves no possibility to specify an OpenCL

r270704 - [AVX512] Don't rely on value names. They're different in release builds.

Author: d0k Date: Wed May 25 09:30:01 2016 New Revision: 270704 URL: http://llvm.org/viewvc/llvm-project?rev=270704=rev Log: [AVX512] Don't rely on value names. They're different in release builds. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified:

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

ioeric added inline comments. Comment at: include-fixer/IncludeFixer.cpp:241 @@ -280,5 +240,3 @@ /// \return true if changes will be made, false otherwise. - bool Rewrite(clang::SourceManager , - clang::HeaderSearch , - std::set , -

r270707 - [Clang][AVX512][Builtin] Fix palignr intrinsics header

Author: mzuckerm Date: Wed May 25 10:05:03 2016 New Revision: 270707 URL: http://llvm.org/viewvc/llvm-project?rev=270707=rev Log: [Clang][AVX512][Builtin] Fix palignr intrinsics header Differential Revision: http://reviews.llvm.org/D20620 Modified: cfe/trunk/lib/Headers/avx512bwintrin.h

Re: [PATCH] D20620: [Clang][AVX512][Builtin] Fix palignr intrinsics header

This revision was automatically updated to reflect the committed changes. Closed by commit rL270707: [Clang][AVX512][Builtin] Fix palignr intrinsics header (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20620?vs=58406=58425#toc Repository: rL LLVM

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58420. hokein added a comment. Fix a nit. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

RE: r267590 - [OpenCL] Add predefined macros.

Great! Thanks! Anastasia -Original Message- From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com] Sent: 25 May 2016 15:46 To: Anastasia Stulova; cfe-commits@lists.llvm.org Cc: nd Subject: RE: r267590 - [OpenCL] Add predefined macros. I will take a look. Thanks. Sam -Original

Re: [PATCH] D20111: [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers.

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4874-4878 @@ -4881,1 +4873,7 @@ +OMP_MAP_IS_PTR = 0x10, +/// \brief This flags signals that an argument is the first one relating to +/// a map/private clause expression. For some cases a

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

bcraig added inline comments. Comment at: include/__threading_support:201 @@ +200,3 @@ +// Mutex +#define _LIBCPP_MUTEX_INITIALIZER nullptr +struct __libcpp_platform_mutex_t; rmaprath wrote: > rmaprath wrote: > > bcraig wrote: > > > rmaprath wrote: > > > > bcraig

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

bcraig added a comment. In http://reviews.llvm.org/D20334#438052, @ahatanak wrote: > My understanding is that typically std::ends is explicitly appended to > null-terminate the stream buffer. The test case in the example does that. > > http://en.cppreference.com/w/cpp/io/ostrstream/str Doh!

[clang-tools-extra] r270701 - Include local header with quotes instead of angle brackets.

Author: d0k Date: Wed May 25 09:14:52 2016 New Revision: 270701 URL: http://llvm.org/viewvc/llvm-project?rev=270701=rev Log: Include local header with quotes instead of angle brackets. This works by accident because we pass '-I.' Modified:

r270702 - Fix mangled name of method with ns_consumed parameters.

Author: nico Date: Wed May 25 09:15:08 2016 New Revision: 270702 URL: http://llvm.org/viewvc/llvm-project?rev=270702=rev Log: Fix mangled name of method with ns_consumed parameters. When a function/method use a parameter with "ns_consumed" attribute, ensure that the mangled name is the same

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58415. hokein added a comment. Rebase http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

[clang-tools-extra] r270703 - [include-fixer] /usr/include/xlocal.h to include/xlocal.h in hardcoded map.

Author: ioeric Date: Wed May 25 09:17:09 2016 New Revision: 270703 URL: http://llvm.org/viewvc/llvm-project?rev=270703=rev Log: [include-fixer] /usr/include/xlocal.h to include/xlocal.h in hardcoded map. Modified:

Re: [PATCH] D20617: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

Can you double check gcc's xmmintrin.h again. I'm pretty sure _mm_store1_ps is calling _mm_storeu_ps. On Wed, May 25, 2016 at 3:31 AM, Simon Pilgrim wrote: > RKSimon created this revision. > RKSimon added reviewers: craig.topper, spatel, andreadb. > RKSimon added a

r270708 - [X86][AVX2] Full set of AVX2 intrinsics tests

Author: rksimon Date: Wed May 25 10:10:49 2016 New Revision: 270708 URL: http://llvm.org/viewvc/llvm-project?rev=270708=rev Log: [X86][AVX2] Full set of AVX2 intrinsics tests llvm/test/CodeGen/X86/avx2-intrinsics-fast-isel.ll will be synced to this Modified:

r270693 - Fix build problem in MSVC

Author: abataev Date: Wed May 25 07:51:24 2016 New Revision: 270693 URL: http://llvm.org/viewvc/llvm-project?rev=270693=rev Log: Fix build problem in MSVC Modified: cfe/trunk/lib/AST/OpenMPClause.cpp Modified: cfe/trunk/lib/AST/OpenMPClause.cpp URL:

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

aturetsk added a comment. Ping. http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:11 @@ +10,3 @@ +#endif +#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable + jvesely wrote: > Anastasia wrote: > > jvesely wrote: > > > Anastasia wrote: > > > >

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added inline comments. Comment at: include/__threading_support:201 @@ +200,3 @@ +// Mutex +#define _LIBCPP_MUTEX_INITIALIZER nullptr +struct __libcpp_platform_mutex_t; rmaprath wrote: > bcraig wrote: > > rmaprath wrote: > > > bcraig wrote: > > > >

[PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20626 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: lib/Headers/avx512fintrin.h

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

bkramer added inline comments. Comment at: include-fixer/IncludeFixer.h:51 @@ -50,6 +50,3 @@ - /// Headers to be added. - std::set - - /// Replacements are written here. - std::vector + /// The context that contains all information about queried symbol. +

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639 @@ -5599,6 +5629,12 @@ // type, the default is 'tofrom'. CurMapTypes.push_back(ElementType->isAggregateType()

[PATCH] D20635: clang-rename: fix renaming heap allocations

vmiklos created this revision. vmiklos added reviewers: klimek, cfe-commits. The check failed, 'Cla *C = new Cla();' was renamed 'D *C = new Cla();'. http://reviews.llvm.org/D20635 Files: clang-rename/USRLocFinder.cpp test/clang-rename/ConstructExpr.cpp Index:

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

thakis added a comment. Looks great, thanks! A few minor questions below. I verified that this has the same effect as my brute-force patch I tried locally. Do we have test coverage for `template class __declspec(dllexport) codecvt;` somewhere already? Comment at:

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao updated this revision to Diff 58453. sfantao marked an inline comment as done. sfantao added a comment. - Create function for the generation of the default map information. http://reviews.llvm.org/D20112 Files: lib/CodeGen/CGOpenMPRuntime.cpp

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

djasper added a comment. Thinking some more, I think this is actually very close to what we do for #include(-like) statements. That is done in TokenAnnotator::parseLine() and TokenAnnotator::parseIncludeDirective(). Could you move the logic there? http://reviews.llvm.org/D20632

Re: [PATCH] D20573: [libcxx] Allow explicit pthread opt-in

bcraig added a comment. r270735 http://reviews.llvm.org/D20573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20574: [libcxxabi] Allow explicit pthread opt-in

bcraig closed this revision. bcraig added a comment. r270732 http://reviews.llvm.org/D20574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20630: [OpenCL] Allow -std=CL|CL1.1|CL1.2|CL2.0 in driver

On 25 May 2016 9:13 a.m., "Yaxun Liu via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > > yaxunl created this revision. > yaxunl added a reviewer: Anastasia. > yaxunl added subscribers: pxli168, bader, tstellarAMD, cfe-commits. > > Fix a regression which forbids using

r270728 - Use new triple API to check comdat /NFC

Author: davidxl Date: Wed May 25 12:25:57 2016 New Revision: 270728 URL: http://llvm.org/viewvc/llvm-project?rev=270728=rev Log: Use new triple API to check comdat /NFC Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

[PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Shebang lines (`#!/bin/blah`) can be used in JavaScript scripts to indicate they should be run using e.g. node. This change treats # lines on the first

Re: [PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

arsenm added a comment. Also some tests for non-kernel functions. We might want to keep this as byval for calling those http://reviews.llvm.org/D20168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. To summarize, there are two scenarios where a warning is warranted when the source language is OpenCL: > > I'm not suggesting it be treated as invalid. This extension is part of at > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > > Clang's

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added a comment. Hi, Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + Taking a look at this again I don't think

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans added a comment. Thanks for the review! In http://reviews.llvm.org/D20608#439480, @thakis wrote: > Do we have test coverage for `template class __declspec(dllexport) > codecvt;` somewhere already? Yes, that's covered by tests in CodeGenCXX/dllexport.cpp Comment at:

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans updated this revision to Diff 58461. hans added a comment. tweaks http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp

[libcxx] r270735 - [libcxx] Allow explicit pthread opt-in

Author: bcraig Date: Wed May 25 12:40:09 2016 New Revision: 270735 URL: http://llvm.org/viewvc/llvm-project?rev=270735=rev Log: [libcxx] Allow explicit pthread opt-in The existing pthread detection code in __config is pretty good for common operating systems. It doesn't allow cmake-time choices

Re: [PATCH] D20630: [OpenCL] Allow -std=cl|CL1.1|CL1.2|CL2.0 in driver

yaxunl added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589 @@ -1579,3 +1586,4 @@ +.Case("cl", LangStandard::lang_opencl) .Case("CL1.1", LangStandard::lang_opencl11) .Case("CL1.2", LangStandard::lang_opencl12) .Case("CL2.0",

r270772 - Add a loop's debug location to its llvm.loop metadata

Author: hfinkel Date: Wed May 25 16:53:24 2016 New Revision: 270772 URL: http://llvm.org/viewvc/llvm-project?rev=270772=rev Log: Add a loop's debug location to its llvm.loop metadata Getting accurate locations for loops is important, because those locations are used by the frontend to generate

Re: [PATCH] D20630: [OpenCL] Allow -std=cl|CL1.1|CL1.2|CL2.0 in driver

rsmith added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589 @@ -1579,3 +1586,4 @@ +.Case("cl", LangStandard::lang_opencl) .Case("CL1.1", LangStandard::lang_opencl11) .Case("CL1.2", LangStandard::lang_opencl12) .Case("CL2.0",

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

On Wed, May 25, 2016 at 2:20 PM, Aleksey Bader wrote: > On Wed, May 25, 2016 at 11:53 PM, Richard Smith > wrote: > >> On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> bader added a

r270775 - [CGDebugInfo] Modify the preferred expression location for member calls.

Author: hfinkel Date: Wed May 25 17:08:27 2016 New Revision: 270775 URL: http://llvm.org/viewvc/llvm-project?rev=270775=rev Log: [CGDebugInfo] Modify the preferred expression location for member calls. If the callee has a valid location (not all do), then use that. Otherwise, fall back to the

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL270775: [CGDebugInfo] Modify the preferred expression location for member calls. (authored by hfinkel). Changed prior to commit: http://reviews.llvm.org/D19708?vs=55610=58521#toc Repository: rL LLVM

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

majnemer added a comment. In http://reviews.llvm.org/D18035#434095, @DmitryPolukhin wrote: > One more friendly ping.. :( I think the best way to make progress on this is to refactor this patch along the lines @rsmith suggested back on May 3. http://reviews.llvm.org/D18035

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak added a comment. In http://reviews.llvm.org/D20407#439951, @rjmccall wrote: > The C standard is poorly-written in this area, but I think it would be > reasonable for CheckFunctionReturnType to just silently remove _Atomic. (You > will not be able to just re-use your new method there;

Re: [PATCH] D19739: Add a loop's debug location to its llvm.loop metadata

hfinkel closed this revision. hfinkel added a comment. r270772, thanks! http://reviews.llvm.org/D19739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r270774 - Fix rejects-valid on constexpr function that accesses a not-yet-defined 'extern

Author: rsmith Date: Wed May 25 17:06:25 2016 New Revision: 270774 URL: http://llvm.org/viewvc/llvm-project?rev=270774=rev Log: Fix rejects-valid on constexpr function that accesses a not-yet-defined 'extern const' variable. That variable might be defined as 'constexpr', so we cannot prove that a

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

- Original Message - > From: "David Blaikie" > To: "Hal Finkel" > Cc: "Richard Smith" , "Adrian Prantl" > , "Duncan P. N. Exon Smith" > , "Eric Christopher" , > "Jun

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rsmith added a comment. In http://reviews.llvm.org/D18035#437715, @rengolin wrote: > The 3.8.1 deadline is tomorrow and I'd really like to see these two patches > (plus the related fixes) in it, Realistically, this seems unlikely to make it in time. > or some LTS Linux distributions will

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

rjmccall added a comment. In http://reviews.llvm.org/D20407#439887, @ahatanak wrote: > I reverted the changes I made in SemaDeclObjC.cpp as they weren't needed to > pass the regression tests I added. clang still asserts when it compiles an > objective-c method returning _Atomic and those

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak updated this revision to Diff 58512. ahatanak added a comment. Rename variables. http://reviews.llvm.org/D20407 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/CodeGen/CGObjC.cpp lib/Sema/SemaObjCProperty.cpp test/CodeGenObjC/property-atomic-bool.m

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

On Wed, May 25, 2016 at 11:53 PM, Richard Smith wrote: > On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> bader added a subscriber: bader. >> bader added a comment. >> >> In http://reviews.llvm.org/D20602#438667,

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:1084 @@ +1083,3 @@ + /// Strip typedefs and atomic from the given type. + QualType getDesugaredAtomicValueType(const ASTContext ) const; + Please name this getAtomicUnqualifiedType() and have

Builder llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal

Hello, Builder http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal. Sorry for the noise. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

mprobst added a comment. How would I disable the formatting using that way? When I special case `parsePreprocessorDirective()`, consume the line, and return `LT_ImportStatement`, clang-format still tries to format tokens within the shebang. E.g. I get `#!/usr/bin / env node`, note the

Re: [PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

kromanova updated this revision to Diff 58472. kromanova added a comment. I attached full svn diff. Thank you Michael! I had to clean up the trailing spaces from doxygen comments (because it mess up our post-processing scripts), but since I was doing it, I decided to clean up the rest of the

Re: r213213 - DebugInfo: Forward HandleTagDeclRequiredDefinition through MultiplexConsumer to fix debug info emission in the presence of plugins.

Zombie review comment: ".test" isn't part of test/lit.cfg::config.suffixes, so the two .test files added in this change never run unless you explicitly run them (e.g. with `bin/llvm-lit ../llvm-rw/tools/clang/test/CodeGenCXX/*.test`). CodeGenCXX/debug-info-class-limited.test fails when I run it

[libcxxabi] r270732 - Allow explicit pthread opt-in

Author: bcraig Date: Wed May 25 12:37:38 2016 New Revision: 270732 URL: http://llvm.org/viewvc/llvm-project?rev=270732=rev Log: Allow explicit pthread opt-in When building libcxxabi in tree (i.e. in llvm/projects/libcxxabi, along with llvm/projects/libcxx), libcxx's config_site.in doesn't get

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

bruno added a comment. You can probably find a way to test this by taking a look at unittests/Basic/VirtualFileSystemTest.cpp Repository: rL LLVM http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [PATCH] D20630: [OpenCL] Allow -std=CL|CL1.1|CL1.2|CL2.0 in driver

I will fix that. Thanks. Sam From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Wednesday, May 25, 2016 2:54 PM To: Liu, Yaxun (Sam) ; reviews+d20630+public+1c58d99d1f368...@reviews.llvm.org Cc: alexey.ba...@intel.com; Anastasia Stulova

Re: [PATCH] D20630: [OpenCL] Allow -std=cl|CL1.1|CL1.2|CL2.0 in driver

yaxunl updated this revision to Diff 58471. yaxunl added a comment. Revised as Richard suggested. http://reviews.llvm.org/D20630 Files: lib/Frontend/CompilerInvocation.cpp test/Driver/opencl.cl test/Frontend/stdlang.c Index: test/Frontend/stdlang.c

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

thakis accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaTemplate.cpp:7382 @@ +7381,3 @@ + if (A->getKind() == AttributeList::AT_DLLExport) { +// dllexport trumps dllexport here. +DLLImport = false;

Re: [PATCH] D20574: [libcxxabi] Allow explicit pthread opt-in

rmaprath accepted this revision. rmaprath added a comment. This revision is now accepted and ready to land. LGTM. (I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance)

Re: [PATCH] D20573: [libcxx] Allow explicit pthread opt-in

rmaprath accepted this revision. rmaprath added a comment. This revision is now accepted and ready to land. LGTM. (I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance)

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a subscriber: rmaprath. rmaprath added a comment. Looks like I've completely missed this patch somehow. Will try to find some time (or someone) to have a look at it from an embedded-systems / ARM point of view asap. Great work!!! http://reviews.llvm.org/D16948

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

rsmith added inline comments. Comment at: lib/Basic/FileManager.cpp:389 @@ -383,2 +388,3 @@ UFE->File.reset(); + UFE->IsVirtual = true; return UFE; Rather than adding this `IsVirtual` flag, could you just set `UFE->IsValid` to `true` here? It looks like

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak updated this revision to Diff 58495. ahatanak added a comment. Address John's review comments. http://reviews.llvm.org/D20407 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/CodeGen/CGObjC.cpp lib/Sema/SemaObjCProperty.cpp test/CodeGenObjC/property-atomic-bool.m

Re: [PATCH] D20630: [OpenCL] Allow -std=cl|CL1.1|CL1.2|CL2.0 in driver

rsmith added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589 @@ -1579,3 +1586,4 @@ +.Case("cl", LangStandard::lang_opencl) .Case("CL1.1", LangStandard::lang_opencl11) .Case("CL1.2", LangStandard::lang_opencl12) .Case("CL2.0",

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits < cfe-commits@lists.llvm.org> wrote: > bader added a subscriber: bader. > bader added a comment. > > In http://reviews.llvm.org/D20602#438667, @rsmith wrote: > > > I'm not suggesting it be treated as invalid. This extension is part of

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak marked 7 inline comments as done. Comment at: lib/AST/Type.cpp:1282 @@ -1277,1 +1281,3 @@ +} + Optional Type::getObjCSubstitutions( I added getTypePtr() because the code didn't compile. Comment at: lib/CodeGen/CGObjC.cpp:901

r270754 - Revert r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)"

Author: hans Date: Wed May 25 15:49:14 2016 New Revision: 270754 URL: http://llvm.org/viewvc/llvm-project?rev=270754=rev Log: Revert r270748 "clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)" It seems to have broken the sanitizer-windows

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak marked 2 inline comments as done. ahatanak added a comment. I reverted the changes I made in SemaDeclObjC.cpp as they weren't needed to pass the regression tests I added. clang still asserts when it compiles an objective-c method returning _Atomic and those changes will become

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

rjmccall added inline comments. Comment at: lib/AST/Type.cpp:1282 @@ -1277,1 +1281,3 @@ +} + Optional Type::getObjCSubstitutions( ahatanak wrote: > I added getTypePtr() because the code didn't compile. Sure. Comment at:

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

etienneb updated this revision to Diff 58502. etienneb marked an inline comment as done. etienneb added a comment. more tests http://reviews.llvm.org/D20347 Files: include/clang/Driver/CLCompatOptions.td lib/Driver/Tools.cpp test/Driver/cl-fallback.c test/Driver/cl-options.c Index:

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

etienneb added a comment. This patch needs land after http://reviews.llvm.org/D20346. thx for the review. http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

sfantao updated this revision to Diff 58469. sfantao marked an inline comment as done. sfantao added a comment. - Add nestings test. http://reviews.llvm.org/D15944 Files: include/clang-c/Index.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/StmtOpenMP.h

Re: Builder llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal

What was the issue? On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > Hello, > > Builder > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast > is back to normal. > Sorry for the noise. > > Thanks > >

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

ioeric added inline comments. Comment at: include-fixer/IncludeFixer.cpp:241 @@ +240,3 @@ + IncludeFixerContext + GetIncludeFixerContext(const clang::SourceManager , + clang::HeaderSearch ) { I think function name should start with lower

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

bkramer added inline comments. Comment at: include-fixer/tool/clang-include-fixer.py:84 @@ +83,3 @@ +index = 1; +for header in lines[1:]: + choices_message += "&" + str(index) + header + "\n" ioeric wrote: > If there is only one candidate, it doesn't

Re: Builder llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal

A factory required a successful step of removing the llvm.obj directory, which could be missing in some cases. The fix is committed as r270773 Thanks Galina On Wed, May 25, 2016 at 12:22 PM, Sean Silva wrote: > What was the issue? > > On Wed, May 25, 2016 at 12:17 PM,

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. > > > I'm not suggesting it be treated as invalid. This extension is part of at > > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > > > Clang's implementation of the OpenCL vector type. Therefore if the user > > > asks us to support OpenCL

r270781 - [Sema] Note when we encounter a problem in ExprConstant.

Author: gbiv Date: Wed May 25 17:31:54 2016 New Revision: 270781 URL: http://llvm.org/viewvc/llvm-project?rev=270781=rev Log: [Sema] Note when we encounter a problem in ExprConstant. Currently, the constexpr evaluator is very conservative about unmodeled side-effects when we're evaluating an

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270781: [Sema] Note when we encounter a problem in ExprConstant. (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D18540?vs=52834=58526#toc Repository: rL LLVM

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added a comment. Looks good other than the recent information about the version of OpenCL that actually specifies this. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7899 @@ +7898,3 @@ +// OpenCL v2.2 s2.1.2.3 - Vector Component Access +def

[PATCH] D20647: Add flag to add InlineHint attribute on implicitly inline functions

Ilod created this revision. Ilod added a subscriber: cfe-commits. Add two flags (-finline-implicit-hint and -fno-inline-implicit-hint) to allow to add InlineHint on implicitly inline functions (constexpr and member functions of class that was defined in the class body). This is needed to add

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

mprobst updated this revision to Diff 58529. mprobst added a comment. - use #include style shebang parsing. http://reviews.llvm.org/D20632 Files: lib/Format/FormatTokenLexer.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58537. pirama added a comment. Renamed diagnostic to use ext_ prefix. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58525. pirama added a comment. Added warnings when rgba is used with OpenCL http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp

r270784 - [Sema] Use the failure bits introduced by r270781.

Author: gbiv Date: Wed May 25 17:38:36 2016 New Revision: 270784 URL: http://llvm.org/viewvc/llvm-project?rev=270784=rev Log: [Sema] Use the failure bits introduced by r270781. r270781 introduced the ability to track whether or not we might have had unmodeled side-effects during constant

[PATCH] D20650: [OpenMP] Codegen for target update directive.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. This patch implements the code generation for the `target update` directive. The implemntation relies on the logic already in place for

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58535. pirama added a comment. Switched to ExtWarn, updated warning's message and made the version check strict w.r.t. 2.2. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added a comment. > Please add some tests for the FixItHint replacement text. See test/FixIt for > examples of how to do this. Thanks for the suggestion. After adding tests for this, I noticed badness with the path separators in the FixIt hint when running on Windows. I'm working

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

djasper added a comment. That's the same for #include directives (with <>). Just turn the tokens into TT_ImplicitStringLiteral, same as is done for #includes. I am not saying it's better, but I don't think we should have to different approaches.. http://reviews.llvm.org/D20632

[PATCH] D20640: [AMDGPU] Set default dwarf version to 2

kzhuravl created this revision. kzhuravl added a reviewer: tstellarAMD. kzhuravl added a subscriber: cfe-commits. Herald added a subscriber: kzhuravl. http://reviews.llvm.org/D20640 Files: lib/Driver/ToolChains.h test/Driver/amdgpu-toolchain.c Index: test/Driver/amdgpu-toolchain.c

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans updated this revision to Diff 58484. hans added a comment. Fix the "dllexport trumps" comment, and add a test. http://reviews.llvm.org/D20608 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7382 @@ +7381,3 @@ + if (A->getKind() == AttributeList::AT_DLLExport) { +// dllexport trumps dllexport here. +DLLImport = false; thakis wrote: > trumps _dllimport_ here > >

  1   2   >