ahatanak added a comment.
In https://reviews.llvm.org/D27304#610944, @thegameg wrote:
> In https://reviews.llvm.org/D27304#610697, @joerg wrote:
>
> > I think this is the absolutely wrong place to put such logic. It really can
> > not be anywhere but the backend.
>
>
> I am aware of this. But th
jhen added a reviewer: kcc.
jhen added a comment.
Before this patch, the following command would fail:
clang++ -fsanitize=address --cuda-gpu-arch=sm_20 -c example.cu
with error:
clang-4.0: error: unsupported option '-fsanitize=address' for target
'nvptx64-nvidia-cuda'
After this patch, th
On 1 Dec 2016 8:37 p.m., "Mads Ravn" wrote:
> I see the idea for the fixit clearly for case 3 & 4. Just erase
.compare(str2) and replace 0 with str2. I have a quick question though:
Given the declRefExpr().bind("str2"), how do I read the name of it in
clang-tidy? Or should I just bind 0 as well an
hfinkel added a comment.
In https://reviews.llvm.org/D25686#571894, @mgorny wrote:
> In https://reviews.llvm.org/D25686#571857, @hfinkel wrote:
>
> > It seems like we should teach Triple how to parse this triples correctly
> > (i.e. to recognize that the vendor is ARM), and then canonicalize the
v.g.vassilev added a comment.
Thanks for working on this Sean!
Since long time we are planning to propose a patch moving some parts of cling
(eg. libInterpreter) mainline.
Now I should have a little more time to do this and it'd be great if we can
share some code between cling and lldb. This t
efriedma added a comment.
The logic to compute whether a calling convention uses SSE registers does exist
in clang/lib/CodeGen/TargetInfo.cpp, so it might be possible to reuse that...
but I'm not sure that's better than just detecting it in the backend.
https://reviews.llvm.org/D27304
_
jlebar added a comment.
> where would be the right place for me to put a test to check that it is
> working (i.e. ASAN still works for CUDA host code).
I just ran the test from https://reviews.llvm.org/rL281680, and it passes
because it doesn't notice clang raising the "unsupported option
'-fs
joerg added a comment.
The frontend is the wrong place as it doesn't even know if the register is ever
going to be used. E.g. if it is a static function, all instances could be
inlined away.
https://reviews.llvm.org/D27304
___
cfe-commits mailing
dcoughlin updated this revision to Diff 79981.
dcoughlin added a comment.
- Update the diagnostic to be explicit about whether the issue occurs during
construction or destruction
- Add test for pure, intraprocedural case (Sema also catches this).
https://reviews.llvm.org/D26768
Files:
includ
kcc added a comment.
at the very least this requires a test... Let me thing about the logic a bit
more...
https://reviews.llvm.org/D27316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
jlebar added a comment.
In https://reviews.llvm.org/D27316#611160, @kcc wrote:
> at the very least this requires a test... Let me thing about the logic a bit
> more...
I think we just need to fix the test from the previous CL, which is buggy and
didn't catch this regression.
https://reviews
kcc added a comment.
I am not sure this is going to work.
You essentially break on the first iteration in the beginning of the loop.
Why not exit the function before the loop?
Also, the loop "claims" the args and by breaking early you leave the args
unclaimed.
I don't remember this code well
jhen added a comment.
In https://reviews.llvm.org/D27316#611162, @kcc wrote:
> I am not sure this is going to work.
> You essentially break on the first iteration in the beginning of the loop.
> Why not exit the function before the loop?
> Also, the loop "claims" the args and by breaking ea
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288436: Extend CompilationDatabase by a field for the output
filename (authored by joerg).
Changed prior to commit:
https://reviews.llvm.org/D27138?vs=79320&id=79993#toc
Repository:
rL LLVM
https://
Author: joerg
Date: Thu Dec 1 17:37:45 2016
New Revision: 288436
URL: http://llvm.org/viewvc/llvm-project?rev=288436&view=rev
Log:
Extend CompilationDatabase by a field for the output filename
In bigger projects like an Operating System, the same source code is
often compiled in slightly differe
dcoughlin updated this revision to Diff 79992.
dcoughlin added a comment.
- Add a PureOnly analyzer-config option that, when set, will limit diagnostics
to calls to only pure virtual functions.
This should have gone in with the prevision updated diff; my apologies for the
noise.
https://revie
dcoughlin marked 2 inline comments as done.
dcoughlin added a comment.
In https://reviews.llvm.org/D26768#607157, @zaks.anna wrote:
> Not sure if we should make pure vs not an option so that users could turn the
> checking off. Is there a way to suppress the warning?
There is not a way to supp
Author: akirtzidis
Date: Thu Dec 1 17:41:27 2016
New Revision: 288438
URL: http://llvm.org/viewvc/llvm-project?rev=288438&view=rev
Log:
[libclang] Add APIs to check the result of an integer expression in
CXEvalResult without overflow
Patch by Emilio Cobos Álvarez!
See https://reviews.llvm.org/D
Author: rjmccall
Date: Thu Dec 1 17:51:30 2016
New Revision: 288440
URL: http://llvm.org/viewvc/llvm-project?rev=288440&view=rev
Log:
Struct GEPs must use i32, not whatever size_t is. It should be safe
to do this unconditionally, given that the indices will always be small
constant integers anyw
ddcc updated this revision to Diff 79996.
ddcc added a comment.
Change definition
https://reviews.llvm.org/D26955
Files:
lib/Basic/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/SemaDeclAttr.cpp
===
--- lib/Sema/Sem
joerg updated the summary for this revision.
joerg set the repository for this revision to rL LLVM.
joerg updated this revision to Diff 79997.
joerg added a comment.
Add test case.
Repository:
rL LLVM
https://reviews.llvm.org/D27140
Files:
include/clang/Basic/DiagnosticDriverKinds.td
inc
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:62-67
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(TwoDoubleA
Author: jroelofs
Date: Thu Dec 1 18:51:58 2016
New Revision: 288444
URL: http://llvm.org/viewvc/llvm-project?rev=288444&view=rev
Log:
Delete tautological assertion.
After r256463, both the LHS and RHS now refer to the same variable. Before,
they referred to the member, the parameter respectively
efriedma added a comment.
There's nothing wrong with this change, as far as I can tell. That said, if
you're planning to use getRealTypeByWidth anywhere other than AddModeAttr, it's
probably a bug; the behavior of getRealTypeByWidth isn't useful for any other
purpose given that clang supports
Author: djg
Date: Thu Dec 1 19:12:40 2016
New Revision: 288447
URL: http://llvm.org/viewvc/llvm-project?rev=288447&view=rev
Log:
[WebAssembly] Add an -mdirect flag for the direct wasm object feature.
Add a target flag for enabling the new direct wasm object emission
feature.
Modified:
cfe/t
jhen updated this revision to Diff 80003.
jhen added a comment.
- "Support" ASAN in CudaToolChain
https://reviews.llvm.org/D27316
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/cuda-no-sanitizers.cu
Index: test/Driver/cuda-no-sanitizers.cu
=
jlebar added a comment.
This takes it back to how it used to be before I regressed it, which I think is
good enough for now. If we want to revisit how we make this work for
offloading toolchains in general, we can do that separately.
https://reviews.llvm.org/D27316
Author: jhen
Date: Thu Dec 1 19:42:54 2016
New Revision: 288448
URL: http://llvm.org/viewvc/llvm-project?rev=288448&view=rev
Log:
[CUDA] "Support" ASAN arguments in CudaToolChain
This fixes a bug that was introduced in rL287285. The bug made it
illegal to pass -fsanitize=address during CUDA comp
Author: rsmith
Date: Thu Dec 1 19:52:28 2016
New Revision: 288449
URL: http://llvm.org/viewvc/llvm-project?rev=288449&view=rev
Log:
Recover better from an incompatible .pcm file being provided by -fmodule-file=.
We try to include the headers of the module textually in this case, still
enforcing t
jhen created this revision.
jhen added a reviewer: jlebar.
jhen added a subscriber: cfe-commits.
The test introduced by https://reviews.llvm.org/rL288448 is currently failing
because
unimportant but unexpected errors appear as output from a test compile
line. This patch removes the faulty test fo
jhen updated this revision to Diff 80012.
jhen added a comment.
- Switch to more specific error
https://reviews.llvm.org/D27328
Files:
test/Driver/cuda-no-sanitizers.cu
Index: test/Driver/cuda-no-sanitizers.cu
===
--- test/Driv
jlebar updated this revision to Diff 80011.
jlebar added a comment.
Suggest std::foo instead of ::foof.
I spoke with rtrieu IRL and he suggested I do this to match what he did in
SemaChecking.cpp for calls to "abs". Seems reasonable to me. This also lets
me sidestep the question of lexing the q
jlebar added a comment.
Thank you very much for the reviews, @alexfh.
https://reviews.llvm.org/D27284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Dec 1 20:02:23 2016
New Revision: 288452
URL: http://llvm.org/viewvc/llvm-project?rev=288452&view=rev
Log:
p0012r1: define corresponding feature test macro
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
cfe/trunk/test/Lexer/cxx-features.cpp
Modified: cfe/
Author: jhen
Date: Thu Dec 1 20:04:43 2016
New Revision: 288453
URL: http://llvm.org/viewvc/llvm-project?rev=288453&view=rev
Log:
[CUDA] Fix faulty test from rL288448
Summary:
The test introduced by rL288448 is currently failing because
unimportant but unexpected errors appear as output from a t
Author: rsmith
Date: Thu Dec 1 20:06:53 2016
New Revision: 288457
URL: http://llvm.org/viewvc/llvm-project?rev=288457&view=rev
Log:
Update implementation of ABI support for throwing noexcept function pointers
and catching as non-noexcept to match the final design per discusson on
cxx-abi-dev.
Mo
Zeson updated this revision to Diff 80021.
Zeson marked 3 inline comments as done.
Zeson added a comment.
Remove some unnecessary cast
https://reviews.llvm.org/D27251
Files:
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-altivec.c
test/CodeGen/builtins-ppc-p8vector.c
test/CodeGen/built
flx added a comment.
Do you have any more comments, Alex?
https://reviews.llvm.org/D27187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tstellar
Date: Thu Dec 1 21:45:53 2016
New Revision: 288470
URL: http://llvm.org/viewvc/llvm-project?rev=288470&view=rev
Log:
Creating release candidate rc2 from release_391 branch
Added:
libcxxabi/tags/RELEASE_391/rc2/ (props changed)
- copied from r288469, libcxxabi/branche
Author: tstellar
Date: Thu Dec 1 21:46:03 2016
New Revision: 288476
URL: http://llvm.org/viewvc/llvm-project?rev=288476&view=rev
Log:
Creating release candidate rc2 from release_391 branch
Added:
libunwind/tags/RELEASE_391/rc2/ (props changed)
- copied from r288475, libunwind/branche
Author: tstellar
Date: Thu Dec 1 21:45:52 2016
New Revision: 288469
URL: http://llvm.org/viewvc/llvm-project?rev=288469&view=rev
Log:
Creating release candidate rc2 from release_391 branch
Added:
libcxx/tags/RELEASE_391/rc2/ (props changed)
- copied from r288468, libcxx/branches/rele
Zeson added a comment.
In https://reviews.llvm.org/D27251#610629, @kbarton wrote:
> Please make explicit the signed for the parameters to the functions you are
> changing and remove unnecessary casts. I marked the first few that I found,
> but stopped marking them after the first several.
I t
anemet created this revision.
anemet added reviewers: hfinkel, mehdi_amini.
anemet added a subscriber: cfe-commits.
This is to match the behavior of non-LTO; when -fsave-optmization-record
is passed and PGO is available we enable the generation of hotness
information in the optimization records.
Author: chapuni
Date: Thu Dec 1 23:09:21 2016
New Revision: 288478
URL: http://llvm.org/viewvc/llvm-project?rev=288478&view=rev
Log:
clang/test/Driver/defsym.s: Appease targeting msc. It is incapable of external
assembler in trunk.
Modified:
cfe/trunk/test/Driver/defsym.s
Modified: cfe/tru
zaks.anna accepted this revision.
zaks.anna added a comment.
Looks great!
Thank you.
https://reviews.llvm.org/D26768
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added inline comments.
Comment at: lib/Sema/SemaStmt.cpp:1165
if (!hasCasesNotInSwitch)
SS->setAllEnumCasesCovered();
This function used to call setAllEnumCasesCovered() when parsing a switch
statement with an opaque enum condition, bu
NoQ added a comment.
Chatted about this a bit more. Because `CallEvent` is an API designed mostly
for convenience, and `ProgramState` is a core API that needs to stay as clean
and separate from other entities and easy to understand as possible, it would
be the best to
1. construct a `CallEvent
101 - 147 of 147 matches
Mail list logo
