[PATCH] D27068: Improve string::find

hiraditya added a comment. Ping https://reviews.llvm.org/D27068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

On Mon, Dec 12, 2016 at 1:11 PM David Gross wrote: > I looked at what's supported by "requires", and couldn't find anything > appropriate. > > The problem is that I want the test to be sensitive to the size of long > double -- either no greater than 64 bits, or greater than 64

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino updated this revision to Diff 81154. firolino marked an inline comment as done. firolino added a comment. Small improvments: - SourceRange -> SourceLocation (malcolms last comment) - added a few consts https://reviews.llvm.org/D27621 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added a comment. Ping. https://reviews.llvm.org/D26949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai planned changes to this revision. smeenai added a comment. Hidden visibility also requires extern template declarations to expand to default visibility (as opposed to just default type visibility) to be feasible. Will fix annotations there and then roll that macro change into this diff.

[libcxx] r289512 - [libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.

Author: stl_msft Date: Mon Dec 12 19:54:58 2016 New Revision: 289512 URL: http://llvm.org/viewvc/llvm-project?rev=289512=rev Log: [libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash. After r289363, these tests were triggering MSVC x64 warning C4267 "conversion from 'size_t' to

[PATCH] D27430: [libc++] Annotate template methods with visibility

smeenai planned changes to this revision. smeenai added a comment. Hidden visibility also requires extern template declarations to expand to default visibility (as opposed to just default type visibility) to be feasible. Will fix annotations there and add those to this diff.

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino marked an inline comment as done. firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:87 + Diag << FixItHint::CreateReplacement(CommaRange, ";") + << FixItHint::CreateReplacement(AfterCommaToVarNameRange, +

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino marked 2 inline comments as done. firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:86 + + Diag << FixItHint::CreateReplacement(CommaRange, ";") + << FixItHint::CreateReplacement(AfterCommaToVarNameRange,

r289487 - Revert "[Headers] Add #include_next for tgmath.h on Darwin"

Author: bruno Date: Mon Dec 12 17:06:58 2016 New Revision: 289487 URL: http://llvm.org/viewvc/llvm-project?rev=289487=rev Log: Revert "[Headers] Add #include_next for tgmath.h on Darwin" Reverts r289181: it's currently breaking modules using simd.h in 10.12 SDK. This reverts commit

[PATCH] D27603: Propagate -fdiagnostics-color to LLD.

ruiu added a comment. Nico suggested I make change to CMake instead of Clang so that CMake adds -Wl,-color-diagnostics if it detects the linker can accept that option. I think that makes sense, so I'll look into it. https://reviews.llvm.org/D27603

r289494 - Revert "[Modules] Make header inclusion order from umbrella dirs deterministic"

Author: bruno Date: Mon Dec 12 17:22:30 2016 New Revision: 289494 URL: http://llvm.org/viewvc/llvm-project?rev=289494=rev Log: Revert "[Modules] Make header inclusion order from umbrella dirs deterministic" Reverts commit r289478. This broke

r289511 - [analyzer] Run clang-format and fix style

Author: ddcc Date: Mon Dec 12 19:40:41 2016 New Revision: 289511 URL: http://llvm.org/viewvc/llvm-project?rev=289511=rev Log: [analyzer] Run clang-format and fix style Summary: Split out formatting and style changes from D26061 Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits

[PATCH] D26691: [analyzer] Run clang-format and fix style

This revision was automatically updated to reflect the committed changes. Closed by commit rL289511: [analyzer] Run clang-format and fix style (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26691?vs=80128=81170#toc Repository: rL LLVM https://reviews.llvm.org/D26691

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

manmanren created this revision. manmanren added reviewers: rsmith, benlangmuir, aprantl. manmanren added subscribers: bruno, cfe-commits, dexonsmith. We change ASTFileSignature from a random 32-bit number to the actual SHA hash of the pcm content. 1> Definition of ASTFileSignature is moved to

[PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak updated this revision to Diff 81171. ahatanak added a comment. Rebase and ping. https://reviews.llvm.org/D23096 Files: lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiate.cpp lib/Sema/TreeTransform.h test/SemaCXX/vartemplate-lambda.cpp

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

rsmith added a comment. Generally this seems reasonable to me. I don't see any particular need to split this patch up into smaller pieces. Comment at: include/clang/Serialization/ASTBitCodes.h:256 EXTENSION_BLOCK_ID, + DIAGNOSTIC_OPTIONS_BLOCK_ID };

[PATCH] D27691: [libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.

STL_MSFT retitled this revision from "[libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp." to "[libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash.". STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 81160. STL_MSFT

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

ahatanak added a comment. This doesn't happen for objective-c block pointers. Sema::CheckCastAlign returns early when the type isn't a PointerType (BlockPointerType isn't a subclass of PointerType). https://reviews.llvm.org/D27478 ___ cfe-commits

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl updated this revision to Diff 81142. yaxunl marked 9 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D21698 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

aprantl added inline comments. Comment at: include/clang/Serialization/ASTBitCodes.h:322 + + /// \brief Record code for the signature that identifiers this AST file. + SIGNATURE, FYI, could be fixed in a separate commit for the entire file: These uses

[PATCH] D27691: [libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp. This test was triggering MSVC x64 warning C4267 "conversion from 'size_t' to 'int', possible

[PATCH] D27153: [libc++] Make __num_get_float hidden

smeenai added a comment. Pinging above question. https://reviews.llvm.org/D27153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

dexonsmith added inline comments. Comment at: include/clang/Serialization/ASTBitCodes.h:256 EXTENSION_BLOCK_ID, + DIAGNOSTIC_OPTIONS_BLOCK_ID }; rsmith wrote: > Add a comment describing this block. > > Please also give this a name that

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak updated this revision to Diff 81172. ahatanak added a comment. Rebase and ping. https://reviews.llvm.org/D24969 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp lib/Sema/TreeTransform.h test/SemaCXX/destructor.cpp Index: test/SemaCXX/destructor.cpp

r289478 - [Modules] Make header inclusion order from umbrella dirs deterministic

Author: bruno Date: Mon Dec 12 16:41:20 2016 New Revision: 289478 URL: http://llvm.org/viewvc/llvm-project?rev=289478=rev Log: [Modules] Make header inclusion order from umbrella dirs deterministic Sort the headers by name before adding the includes in collectModuleHeaderIncludes. This makes the

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

rsmith added a comment. Please add a test to make sure this does not fire on C++17 decomposition declarations: void f() { struct X { int a, b, c; }; auto [a, b, c] = X(); } https://reviews.llvm.org/D27621 ___ cfe-commits mailing list

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

ddcc added a comment. How does this look now? https://reviews.llvm.org/D26061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r289422 - [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

Author: hahnfeld Date: Mon Dec 12 01:53:47 2016 New Revision: 289422 URL: http://llvm.org/viewvc/llvm-project?rev=289422=rev Log: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC) I made the wrong assumption that execution would continue after an error Diag which led to unneeded complex code.

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL289422: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC) (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D25669?vs=74948=81053#toc Repository: rL LLVM

[PATCH] D24933: Enable configuration files in clang

hfinkel added inline comments. Comment at: lib/Driver/Driver.cpp:2695 + // Claim all arguments that come from configuration file, - driver must not + // warn about unused argument on them. Grammar here is a bit odd, how about: // Claim all arguments that

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 81055. sepavloff marked 4 inline comments as done. sepavloff added a comment. Updated patch. - Directories which are searched for config files are now defined during project configuration process using special cmake options. - Driver do not warn on unused

[PATCH] D27655: Fix modernize-deprecated-headers clang-tidy warnings

michael.sharpe updated this revision to Diff 81179. michael.sharpe added a comment. - Address review comments, check headers for C style headers https://reviews.llvm.org/D27655 Files: include/clang/Analysis/Analyses/ThreadSafetyTIL.h include/clang/Basic/Linkage.h

[libcxxabi] r289513 - [libc++abi] Mark failing test on Darwin as XFAIL

Author: smeenai Date: Mon Dec 12 20:43:04 2016 New Revision: 289513 URL: http://llvm.org/viewvc/llvm-project?rev=289513=rev Log: [libc++abi] Mark failing test on Darwin as XFAIL The macOS thread-local variable finalizer routines do not handle the case where a termination function registers

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL289513: [libc++abi] Mark failing test on Darwin as XFAIL (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D27434?vs=80344=81174#toc Repository: rL LLVM

[PATCH] D27655: Fix modernize-deprecated-headers clang-tidy warnings

michael.sharpe added a comment. In https://reviews.llvm.org/D27655#619307, @Eugene.Zelenko wrote: > Did you enable analysis of headers in Clang-tidy? I had not, thanks for the tip. Comment at: lib/Lex/ModuleMap.cpp:35 #if defined(LLVM_ON_UNIX) -#include +#include #endif

[PATCH] D26167: [Clang-tidy] check for malloc, realloc and free calls

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. One important thing is missing. Please run this check on a large enough codebase (LLVM + Clang is a good choice for testing most of kinds of checks usually) and include a summary of

r289514 - CodeGen: clean up -Wpedantic warning (NFC)

Author: compnerd Date: Mon Dec 12 21:27:35 2016 New Revision: 289514 URL: http://llvm.org/viewvc/llvm-project?rev=289514=rev Log: CodeGen: clean up -Wpedantic warning (NFC) lib/CodeGen/CGExpr.cpp:2511:2: warning: extra ';' [-Wpedantic] }; ^ Clean up warning from gcc 6. Modified:

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

rengolin added a comment. We already massage the triple in many cases, and what goes into IR is not always the same as what is used in Clang. Examples are x86_64's "x32" extension to the ABI, ARM -> Thumb triples, adding compulsory dashes and unknowns (ex. x86_64--linux-gnu), etc. You just

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 81057. sepavloff added a comment. Fixed grammar in comment, thanks to Hal Finkel. https://reviews.llvm.org/D24933 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticDriverKinds.td include/clang/Config/config.h.cmake

[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

rmaprath updated this revision to Diff 81059. https://reviews.llvm.org/D27576 Files: CMakeLists.txt include/__threading_support test/CMakeLists.txt test/libcxx/test/config.py test/lit.site.cfg.in Index: test/lit.site.cfg.in

[PATCH] D16901: [Clang driver, ARM] Do not add +long-calls in PIC mode

rengolin added a comment. Was this abandoned? Repository: rL LLVM https://reviews.llvm.org/D16901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Hi Malcolm, I will look into fixing the two cases only. argumentCountIs(1) is sufficient to narrow the matching to only string compare with one argument. Best regards, Mads Ravn On Mon, Dec 12, 2016 at 10:38 AM Malcolm Parsons via Phabricator < revi...@reviews.llvm.org> wrote: >

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

rengolin resigned from this revision. rengolin removed a reviewer: rengolin. rengolin added a comment. I don't know enough about x86_64's ABI to have a solid opinion. https://reviews.llvm.org/D26887 ___ cfe-commits mailing list

[PATCH] D24084: [CMake] Cleanup libunwind lookup code.

rengolin added a comment. So, we found this issue with the different unwinds between Clang and libunwind: https://llvm.org/bugs/show_bug.cgi?id=31035 Is this related? https://reviews.llvm.org/D24084 ___ cfe-commits mailing list

[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

rmaprath added inline comments. Comment at: include/__threading_support:193 +// Execute once +int __libcpp_execute_once(__libcpp_exec_once_flag *flag, + void (*init_routine)(void)) { EricWF wrote: > These should have `inline`. In fact

[PATCH] D27473: Bring back note about not supporting global register variables

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D27473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

malcolm.parsons added inline comments. Comment at: clang-tidy/misc/StringCompareCheck.cpp:25 + callee(cxxMethodDecl(hasName("compare"), + ofClass(classTemplateSpecializationDecl( + hasName("::std::basic_string"),

[PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

rengolin added a comment. Was this abandoned? Merged? https://reviews.llvm.org/D24083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

rmaprath added inline comments. Comment at: CMakeLists.txt:121 option(LIBCXXABI_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread API" OFF) +option(LIBCXXABI_HAS_EXTERNAL_THREAD_API + "Build libc++abi with an externalized threading API. EricWF

[PATCH] D27614: Mark tests as unsupported under libcpp-no-exceptions

rmaprath added a comment. LGTM. Needs approval from @EricWF or @mclow.lists. https://reviews.llvm.org/D27614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r289428 - clang-format: Separate out a language kind for ObjC.

Author: djasper Date: Mon Dec 12 06:42:29 2016 New Revision: 289428 URL: http://llvm.org/viewvc/llvm-project?rev=289428=rev Log: clang-format: Separate out a language kind for ObjC. While C(++) and ObjC are generally formatted the same way and can be mixed, people might want to choose different

r289431 - [StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee.

Author: hokein Date: Mon Dec 12 08:12:10 2016 New Revision: 289431 URL: http://llvm.org/viewvc/llvm-project?rev=289431=rev Log: [StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee. Summary: Remove the CallGraph in addCallee as it is not used in addCallee. It decouples

[PATCH] D27674: [StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee.

This revision was automatically updated to reflect the committed changes. Closed by commit rL289431: [StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D27674?vs=81078=81081#toc Repository: rL

[PATCH] D27501: clang-format-vsix: add command to format document

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. I also think it makes the code nicer by breaking out the right functions. Thanks! Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + +

[PATCH] D27669: [clang-move] Use appendArgumentsAdjuster for adding extra arguments

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Comment at: clang-move/tool/ClangMoveMain.cpp:109 OptionsParser.getSourcePathList()); + // Add "-fparse-all-comments" compile

r289433 - Use function_ref to avoid allocation in std::function. NFC.

Author: d0k Date: Mon Dec 12 08:41:19 2016 New Revision: 289433 URL: http://llvm.org/viewvc/llvm-project?rev=289433=rev Log: Use function_ref to avoid allocation in std::function. NFC. Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaChecking.cpp Modified:

[PATCH] D27535: [analyzer] Add ObjCPropertyChecker - check for autosynthesized copy-properties of mutable types.

NoQ updated this revision to Diff 81083. NoQ added a comment. - Fix crashes on checking properties in categories. - Address both comments. https://reviews.llvm.org/D27535 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added a comment. In https://reviews.llvm.org/D27621#619649, @malcolm.parsons wrote: > The fixit construction looks overly complicated. Yes, you were right. I have changed a couple of things. It looks better now. Still working on a better getUserWrittenType.

r289436 - [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

Author: mgorny Date: Mon Dec 12 09:07:43 2016 New Revision: 289436 URL: http://llvm.org/viewvc/llvm-project?rev=289436=rev Log: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config) Fix the gcc-config code to support multilib gcc installs properly. This solves two problems: -mx32

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

mgorny added a comment. Thanks for the review. Committed now. https://reviews.llvm.org/D26887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27557: Update the default of the Mozilla coding style

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added a comment. In https://reviews.llvm.org/D27621#619649, @malcolm.parsons wrote: > The fixit construction looks overly complicated. > All you need to do is change a `,` to a `;` and insert a copy of the type: > > << FixItHint::CreateReplacement(CommaRange, ";") > <<

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

This revision was automatically updated to reflect the committed changes. Closed by commit rL289436: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config) (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26887?vs=78623=81086#toc Repository: rL LLVM

[PATCH] D27674: [StaticAnalysis] Remove unnecessary parameter in CallGraphNode::addCallee.

hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: ioeric, cfe-commits. Remove the CallGraph in addCallee as it is not used in addCallee. It decouples addCallee from CallGraph, so that we can use CallGraphNode within our customized CallGraph.

[PATCH] D27673: [clang-move] Only move used helper declarations.

hokein updated this revision to Diff 81079. hokein added a comment. Fix code style. https://reviews.llvm.org/D27673 Files: clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/UsedHelperDeclFinder.cpp clang-move/UsedHelperDeclFinder.h

[PATCH] D27673: [clang-move] Only move used helper declarations.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. Herald added a subscriber: mgorny. Instead of moving all the helper declarations blindly, this patch implement an AST-based call graph solution to make clang-move only move used helper decls to

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I believe this is fine. https://reviews.llvm.org/D26887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27546: [ASTReader] Sort RawComments before merging

bruno added a comment. Ping! https://reviews.llvm.org/D27546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

majnemer added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:619 +bool hasLabel(const LabelDecl *LD) const { + return std::find(Labels.begin(), Labels.end(), LD) != Labels.end(); +} This can be written as `llvm::is_contained(Labels,

[PATCH] D27383: Add a new clang-format style option ObjCBlockResetsIndent.

yixiang added a comment. Ping. For the additional requirements of adding a style options: - be used in a project of significant size (have dozens of contributors) - Yes, it's been used by almost all the iOS projects inside Google, including Google Maps. - have a publicly accessible style

[PATCH] D27569: [OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand.

Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:9624 + if (getLangOpts().OpenCL && getLangOpts().OpenCLVersion >= 200) { +if (LHSIsNull && RHSType->isQueueT()) { getLangOpts().OpenCL is redundant because getLangOpts().OpenCLVersion is

[PATCH] D27627: Allow target to specify default address space for codegen

yaxunl added a comment. > Because, notably, if you do that, then an attempt to pass as an int* will > fail, which means this isn't really C++ anymore... and yet that appears to be > exactly what you want. How about when generating alloca instruction, I insert addrspacecast to the default

[PATCH] D26167: [Clang-tidy] check for malloc, realloc and free calls

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/cppcoreguidelines/NoMallocCheck.cpp:54 + +void NoMallocCheck::handleAquisition(const CallExpr *AquisitionCall) { +

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

rnk added inline comments. Comment at: lib/Basic/SourceManager.cpp:1447 +void SourceManager::getChecksumMD5(FileID FID, std::string ) const { + bool Invalid; Let's move this whole thing to CGDebugInfo::getOrCreateFile. SourceManager isn't caching or managing

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

malcolm.parsons added a comment. The fixit construction looks overly complicated. All you need to do is change a `,` to a `;` and insert a copy of the type: << FixItHint::CreateReplacement(CommaRange, ";") << FixItHint::CreateInsertionFromRange(VarLocation, TypeRange) and insert some

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI, RWPI and FPIC

rengolin added a comment. Was this abandoned? Repository: rL LLVM https://reviews.llvm.org/D23610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

rmaprath updated this revision to Diff 81062. https://reviews.llvm.org/D27575 Files: CMakeLists.txt src/config.h src/cxa_exception.cpp src/cxa_exception_storage.cpp src/cxa_guard.cpp src/cxa_thread_atexit.cpp src/fallback_malloc.cpp src/threading_support.h test/CMakeLists.txt

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

rmaprath added a comment. Patch updated with more context. https://reviews.llvm.org/D27575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27671: [OpenCL] Improve address space diagnostics.

echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: cfe-commits, yaxunl, bader. https://reviews.llvm.org/D27671 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/invalid-kernel.cl Index:

[PATCH] D26768: [analyzer] Improve VirtualCallChecker diagnostics and move to optin package.

dcoughlin added a comment. In https://reviews.llvm.org/D26768#619222, @malcolm.parsons wrote: > In https://reviews.llvm.org/D26768#618651, @dcoughlin wrote: > > > The definite false positives were cases where the programmer seemed aware > > of the semantics of virtual calls during

[PATCH] D21453: Add support for attribute "overallocated"

ahatanak updated this revision to Diff 81090. ahatanak added a comment. Address review comments. - Arrays marked "flexible_array" are now treated as flexible arrays. - __builtin_object_size returns a more accurate numbers for normal C99 flexible arrays (see test/CodeGen/object-size.c). Note

r289446 - [Fix] Add missing include from r289444.

Author: filcab Date: Mon Dec 12 10:43:40 2016 New Revision: 289446 URL: http://llvm.org/viewvc/llvm-project?rev=289446=rev Log: [Fix] Add missing include from r289444. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp URL:

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino marked 2 inline comments as done. firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:133 +VariableLocation.setBegin(tidy::utils::lexer::findLocationAfterToken( +VariableLocation.getEnd(), Tokens,

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8127 "invalid prototype, variadic arguments are not allowed in OpenCL">; +def err_requires_extension : Error< + "use of %select{declaration|type }0%1 requires %2 extension to be

[PATCH] D27671: [OpenCL] Improve address space diagnostics.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r289444 - [clang] Version support for UBSan handlers

Author: filcab Date: Mon Dec 12 10:18:40 2016 New Revision: 289444 URL: http://llvm.org/viewvc/llvm-project?rev=289444=rev Log: [clang] Version support for UBSan handlers This adds a way for us to version any UBSan handler by itself. The patch overrides D21289 for a better implementation (we're

[PATCH] D21695: [clang] Version support for UBSan handlers

This revision was automatically updated to reflect the committed changes. Closed by commit rL289444: [clang] Version support for UBSan handlers (authored by filcab). Changed prior to commit: https://reviews.llvm.org/D21695?vs=61817=81089#toc Repository: rL LLVM

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

arphaman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:133 +VariableLocation.setBegin(tidy::utils::lexer::findLocationAfterToken( +VariableLocation.getEnd(), Tokens, *Result.Context)); + } If you use

[PATCH] D27501: clang-format-vsix: add command to format document

amaiorano added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormat.vsct:76 + + Clang Format Document + klimek wrote: > amaiorano wrote: > > klimek wrote: > > > hans wrote: > > > > amaiorano wrote: > > > > > hans

r289440 - [Driver] Attempt to fix new linux-ld tests on Windows

Author: mgorny Date: Mon Dec 12 10:04:37 2016 New Revision: 289440 URL: http://llvm.org/viewvc/llvm-project?rev=289440=rev Log: [Driver] Attempt to fix new linux-ld tests on Windows (broken by r289436) Modified: cfe/trunk/test/Driver/linux-ld.c Modified: cfe/trunk/test/Driver/linux-ld.c

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

mgorny abandoned this revision. mgorny added a comment. I give up. I'm just going to complain to Gentoo ARM people a lot and maybe they'll fix their triples. https://reviews.llvm.org/D25686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24933: Enable configuration files in clang

bruno added inline comments. Comment at: include/clang/Driver/Driver.h:287 + const std::string () const { return ConfigFile; } + void setConfigFile(StringRef x, unsigned N) { +ConfigFile = x; x -> FileName Comment at:

Re: [PATCH] D27597: [DebugInfo] Restore test case for long double constants.

While it's possible to do arbitrary script things - we prefer nto to to ensure the tests are portable. (we have some custom implementations of common unix utilities for portability of those). In this case, can you xfail this on platforms that don't have the feature you want? rather than trying to

r289458 - Fix typo and remove unnecessary statement.

Author: sfantao Date: Mon Dec 12 13:26:31 2016 New Revision: 289458 URL: http://llvm.org/viewvc/llvm-project?rev=289458=rev Log: Fix typo and remove unnecessary statement. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL:

r289460 - [CrashReproducer] Collect PCH included via -include-pch

Author: bruno Date: Mon Dec 12 13:28:25 2016 New Revision: 289460 URL: http://llvm.org/viewvc/llvm-project?rev=289460=rev Log: [CrashReproducer] Collect PCH included via -include-pch Collect the necessary input PCH files. Do not try to validate the AST before copying it out because if the crash

r289459 - [Frontend] Use vfs for directory iteration while searching PCHs. NFCI

Author: bruno Date: Mon Dec 12 13:28:21 2016 New Revision: 289459 URL: http://llvm.org/viewvc/llvm-project?rev=289459=rev Log: [Frontend] Use vfs for directory iteration while searching PCHs. NFCI Use the vfs lookup instead of real filesytem and handle the case where -include-pch is a directory

Re: [PATCH] D21695: [clang] Version support for UBSan handlers

> On Dec 12, 2016, at 10:17 AM, Andrew Ford via Phabricator > wrote: > > andrewford added a comment. > > This broke the build on android due to use of std::to_string. Would someone > mind changing it to llvm::to_string, I don't have commit access to change it >

Re: [PATCH] D21695: [clang] Version support for UBSan handlers

Thanks Vedant! Andrew: does Android not support C++11? I don't understand why it wouldn't have these funcions. Thank you, Filipe On Mon, 12 Dec 2016 at 18:58, Vedant Kumar wrote: > > > > On Dec 12, 2016, at 10:17 AM, Andrew Ford via Phabricator < > revi...@reviews.llvm.org>

r289455 - Bring back note about not supporting global register variables.

Author: mkuper Date: Mon Dec 12 13:11:39 2016 New Revision: 289455 URL: http://llvm.org/viewvc/llvm-project?rev=289455=rev Log: Bring back note about not supporting global register variables. This was accidentally removed in r260506, even though we only support non-allocatable global register

  1   2   >