[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

sammccall added a comment. Thanks for doing this! Some quibbles about the interface, but this makes index useful for lots more features. Comment at: clangd/index/Index.h:268 + virtual bool + getSymbol(const SymbolID , +llvm::function_ref

r327253 - Don't re-format raw string literal contents when formatting is disable

Author: djasper Date: Mon Mar 12 03:11:30 2018 New Revision: 327253 URL: http://llvm.org/viewvc/llvm-project?rev=327253=rev Log: Don't re-format raw string literal contents when formatting is disable Not entirely sure this is the best place to put this check, but it fixes the immediate issue.

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

malcolm.parsons added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:115 + int virt_1() override { return A::virt_1(); } + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::virt_1' is a grand-parent's method, not parent's. Did you mean 'BF'? +

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov updated this revision to Diff 137977. ilya-biryukov marked 8 inline comments as done. ilya-biryukov added a comment. Addressed review comments. The only thing that's left on my todo-list is a test for toLSPDiags(). Everything else should be ready. Repository: rCTE Clang Tools

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

sammccall added a comment. Not sure if you're waiting on comments from me: the changes look good. As discussed I still think Fix should be a separate thing with a name because that's how editors treat it, and this is the right layer to decide how to do that mapping. Comment

[PATCH] D44315: [clangd] Collect the number of files referencing a symbol in the static index.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.h:35 + DiagnosticsEngine::Level Severity; + llvm::SmallVector FixIts; + // Since File is only descriptive, we store a separate flag to distinguish sammccall wrote: > sammccall

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

tbourvon added a comment. @alexfh Do you think we can merge this? I think I've been through every suggestion and it would be nice to finally land the check! https://reviews.llvm.org/D37014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

aaron.ballman added inline comments. Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.cpp:27-30 + auto File = Context->getCurrentFile(); + auto Style = format::getStyle(*Context->getOptionsForFile(File).FormatStyle, +File,

r327255 - clang-format: Properly handle implicit string concatenation in text protos

Author: djasper Date: Mon Mar 12 03:32:18 2018 New Revision: 327255 URL: http://llvm.org/viewvc/llvm-project?rev=327255=rev Log: clang-format: Properly handle implicit string concatenation in text protos Three issues to fix: - char_constants weren't properly treated as string literals -

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov updated this revision to Diff 137987. ilya-biryukov marked 14 inline comments as done. ilya-biryukov added a comment. - Addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44142 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

r327258 - [analyzer] Add scope information to CFG

Author: chefmax Date: Mon Mar 12 05:26:15 2018 New Revision: 327258 URL: http://llvm.org/viewvc/llvm-project?rev=327258=rev Log: [analyzer] Add scope information to CFG This patch adds two new CFG elements CFGScopeBegin and CFGScopeEnd that indicate when a local scope begins and ends

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:201 std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos(); + if (!MacroInfos.empty()) { +for (auto Item : MacroInfos) { I wonder whether we should fix the `DeclrationAndMacrosFinder`

[PATCH] D16403: Add scope information to CFG

This revision was automatically updated to reflect the committed changes. Closed by commit rC327258: [analyzer] Add scope information to CFG (authored by chefmax, committed by ). Repository: rC Clang https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisDeclContext.h

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. ping would be nice if it was commited this week :-) especially the other bits are already https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44222: [AArch64] Add vmulxh_lane FP16 intrinsics

SjoerdMeijer added inline comments. Comment at: include/clang/Basic/arm_neon.td:1504 + // Scalar floating point multiply extended (scalar, by element) + def SCALAR_FMULX_LANEH : IOpInst<"vmulx_lane", "ssdi", "Sh", OP_SCALAR_MUL_LN>; + def SCALAR_FMULX_LANEQH :

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

baloghadamsoftware added a comment. By moving the code that sets the type name of an anoynmous declaration from Import(Decl*) to ImportDefinition(RecordDecl*, RecordDecl*, ImportDefinitionKind) (and the same for Enum) we will not crash upon importing typedefs containing anonymous strcutures.

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Ship it! (but let's drop the extra operator== if possible?) Comment at: clangd/ClangdLSPServer.cpp:329 + {"title", + llvm::formatv("Apply FixIt

r327264 - Update the supported C language standards in the user manual.

Author: aaronballman Date: Mon Mar 12 06:09:13 2018 New Revision: 327264 URL: http://llvm.org/viewvc/llvm-project?rev=327264=rev Log: Update the supported C language standards in the user manual. Remove mention of -std=c94 (it is spelled iso9899:1994, not c94) and add mention of -std=c17 and

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

sammccall added a comment. Sorry, last comments were concurrent with the latest snapshot. Except where noted, the old comments still apply I think. Comment at: clangd/ClangdLSPServer.cpp:317 for (Diagnostic : Params.context.diagnostics) { -auto Edits =

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:329 + {"title", + llvm::formatv("Apply FixIt {0}", GetFixitMessage(D.message))}, {"command",

r327263 - [analyzer] Trying to fix buildbots after r327258

Author: chefmax Date: Mon Mar 12 06:07:54 2018 New Revision: 327263 URL: http://llvm.org/viewvc/llvm-project?rev=327263=rev Log: [analyzer] Trying to fix buildbots after r327258 Modified: cfe/trunk/test/Analysis/scopes-cfg-output.cpp Modified: cfe/trunk/test/Analysis/scopes-cfg-output.cpp

[PATCH] D40731: Integrate CHash into CLang

stettberger added inline comments. Comment at: include/clang/AST/CHashVisitor.h:72-79 + template + void addData(const llvm::iterator_range ) { +addData(std::distance(x.begin(), x.end())); + } + template + void addData(const llvm::ArrayRef ) { +addData(x.size());

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

The tests only failed with module enabled. FWIW, I think the change in ASTImporter (https://reviews.llvm.org/rL327206#change-1q8vFFjJ6Cqk) needs additional changes to make imports work for RecordDecl. On Mon, Mar 12, 2018 at 3:56 PM Eric Liu wrote: > Hi Akira, > > It seems

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

vsk added a comment. The new changes look fine. Do you need someone to commit this for you? https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r327304 - [libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail.cpp.

Author: sqlbyme Date: Mon Mar 12 11:06:37 2018 New Revision: 327304 URL: http://llvm.org/viewvc/llvm-project?rev=327304=rev Log: [libcxx][test] Adding apple-clang-9 to UNSUPPORTED in iter_alloc_deduction.fail.cpp. After two failed attempts last week to make this work I am going back to a known

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

vsapsai updated this revision to Diff 138059. vsapsai added a comment. - Some more cleanup. NFC. https://reviews.llvm.org/D43494 Files: clang/lib/Serialization/ASTReaderDecl.cpp clang/test/Modules/Inputs/self-referencing-lambda/a.h

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. Yes I do ☺ thanks. https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

vsapsai marked 6 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1798 + // already done some merging. Either way, just merge into it. + if (Canon->DefinitionData && Canon->DefinitionData != DD) {

r327270 - [analyzer] Trying to fix Windows buildbots after r327258

Author: chefmax Date: Mon Mar 12 06:44:19 2018 New Revision: 327270 URL: http://llvm.org/viewvc/llvm-project?rev=327270=rev Log: [analyzer] Trying to fix Windows buildbots after r327258 Modified: cfe/trunk/test/Analysis/scopes-cfg-output.cpp Modified:

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 137998. paulsemel added a comment. Applied Francis' suggestions Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp Index: lib/Sema/SemaChecking.cpp

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138000. gtbercea added a comment. Rename folder. Fix test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[clang-tools-extra] r327275 - [clangd] Collect the number of files referencing a symbol in the static index.

Author: sammccall Date: Mon Mar 12 07:49:09 2018 New Revision: 327275 URL: http://llvm.org/viewvc/llvm-project?rev=327275=rev Log: [clangd] Collect the number of files referencing a symbol in the static index. Summary: This is an important ranking signal. It's off for the dynamic index for now.

[PATCH] D44093: [BUILTINS] structure pretty printer

lebedev.ri added a comment. BTW, as far as i can tell this still has zero test coverage (no new tests are being added). I'd expect to see the tests for the actual output - one struct per each type it is able to print - probably some tests showing error handling, and possibly the availability

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138001. gtbercea added a comment. Fixes. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138002. gtbercea added a comment. Add input file. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov updated this revision to Diff 138004. ilya-biryukov added a comment. - Replace equality comparison ops with matchers, they were only used in tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44142 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

[PATCH] D44315: [clangd] Collect the number of files referencing a symbol in the static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327275: [clangd] Collect the number of files referencing a symbol in the static index. (authored by sammccall, committed by ). Changed prior to commit:

[PATCH] D35200: Don't use mmap on Windows

yvvan abandoned this revision. yvvan added a comment. It was the wrong direction https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

ilya-biryukov accepted this revision. ilya-biryukov added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/XRefsTests.cpp:587 - const char *HeaderContents = R"cpp([[]]int a;)cpp"; + const char *HeaderContents = R"cpp([[]]#ifndef

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

Hi Akira, It seems that this commit also changes behavior for compiling C++ code as we are seeing test failures caused by this change in our internal tests. I'm still trying to reduce a reproducer for the failure. In the meantime, could you please double check if this affects C++? Thanks, Eric

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. Hi, In https://reviews.llvm.org/D44093#1034610, @lebedev.ri wrote: > BTW, as far as i can tell this still has zero test coverage (no new tests are > being added). > I'd expect to see the tests for the actual output > > - one struct per each type it is able to print

[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

abeserminji created this revision. abeserminji added reviewers: sdardis, petarj. Herald added a subscriber: arichardson. This patch makes Clang behave more like gcc. - On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when only -fno-pic/-fno-PIC is used. - An error is

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 137999. gtbercea added a comment. Herald added a subscriber: jholewinski. Change name of folder. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/CodeGen/CGDecl.cpp

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

ahatanak reopened this revision. ahatanak added a comment. This revision is now accepted and ready to land. The patch got reverted in r325335 as it broke the Chromium build. I'm reopening this review. Repository: rC Clang https://reviews.llvm.org/D36918

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:213-221 // Use the file manager to deduplicate paths. FileEntries are // automatically canonicalized. - if (const FileEntry *Entry =

r327317 - Check that ubsan is the only supported sanitizer on OpenBSD

Author: vedantk Date: Mon Mar 12 12:18:51 2018 New Revision: 327317 URL: http://llvm.org/viewvc/llvm-project?rev=327317=rev Log: Check that ubsan is the only supported sanitizer on OpenBSD Patch by David Carlier! Differential Revision: https://reviews.llvm.org/D44069 Modified:

r327309 - [analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance

Author: george.karpenkov Date: Mon Mar 12 11:27:36 2018 New Revision: 327309 URL: http://llvm.org/viewvc/llvm-project?rev=327309=rev Log: [analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance rdar://38383753 Differential Revision: https://reviews.llvm.org/D44228 Added:

[PATCH] D44228: [analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance

This revision was automatically updated to reflect the committed changes. Closed by commit rC327309: [analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

r327313 - [Driver] Add text description of --help-hidden so it is shown in help

Author: jkorous Date: Mon Mar 12 11:33:55 2018 New Revision: 327313 URL: http://llvm.org/viewvc/llvm-project?rev=327313=rev Log: [Driver] Add text description of --help-hidden so it is shown in help Modified: cfe/trunk/include/clang/Driver/Options.td Modified:

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

ahatanak updated this revision to Diff 138066. ahatanak added a comment. The new patch passes the calling context to CheckNonDependent so that Sema::CheckAddressOfMemberAccess uses the correct context to check accessibility of explicit template arguments. I initially tried moving the

r327322 - [Tooling] Clear the PreambleSrcLocCache when preamble is discarded during reparsing

Author: arphaman Date: Mon Mar 12 12:36:29 2018 New Revision: 327322 URL: http://llvm.org/viewvc/llvm-project?rev=327322=rev Log: [Tooling] Clear the PreambleSrcLocCache when preamble is discarded during reparsing This ensures that diagnostics are not remapped to incorrect preamble locations

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rC327317: Check that ubsan is the only supported sanitizer on OpenBSD (authored by vedantk, committed by ). Repository: rC Clang https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL327317: Check that ubsan is the only supported sanitizer on OpenBSD (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Introduce pconfig and SGX related intrinsics. Repository: rC Clang https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def

r327284 - [clang-format] Don't detect C++11 attribute specifiers as ObjC

Author: benhamilton Date: Mon Mar 12 08:42:38 2018 New Revision: 327284 URL: http://llvm.org/viewvc/llvm-project?rev=327284=rev Log: [clang-format] Don't detect C++11 attribute specifiers as ObjC Summary: Previously, clang-format would detect C++11 and C++17 attribute specifiers like the

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton marked an inline comment as done. benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:210 -bool MightBeFunctionType = !Contexts[Contexts.size() - 2].IsExpression; -bool ProbablyFunctionType = CurrentToken->isOneOf(tok::star,

[PATCH] D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC327284: [clang-format] Dont detect C++11 attribute specifiers as ObjC (authored by benhamilton, committed by ). Changed

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

benhamilton updated this revision to Diff 138024. benhamilton added a comment. - Restore short functionn type variable names and add clarifying comment. Repository: rC Clang https://reviews.llvm.org/D43906 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp

r327285 - [clang-format] Improve detection of Objective-C block types

Author: benhamilton Date: Mon Mar 12 08:42:40 2018 New Revision: 327285 URL: http://llvm.org/viewvc/llvm-project?rev=327285=rev Log: [clang-format] Improve detection of Objective-C block types Summary: Previously, clang-format would detect the following as an Objective-C block type: FOO(^);

[PATCH] D43906: [clang-format] Improve detection of Objective-C block types

This revision was automatically updated to reflect the committed changes. benhamilton marked an inline comment as done. Closed by commit rC327285: [clang-format] Improve detection of Objective-C block types (authored by benhamilton, committed by ). Changed prior to commit:

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327282: [clangd] Revamp handling of diagnostics. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44142?vs=138004=138018#toc Repository: rCTE Clang Tools

[PATCH] D43902: [clang-format] Don't detect C++11 attribute specifiers as ObjC

djasper accepted this revision. djasper added a comment. Ok, looks good. Repository: rC Clang https://reviews.llvm.org/D43902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40731: Integrate CHash into CLang

stettberger updated this revision to Diff 138019. stettberger marked an inline comment as done. stettberger added a comment. Addressed comments, for more details, please see the mail on cfe-devel Repository: rC Clang https://reviews.llvm.org/D40731 Files:

[clang-tools-extra] r327282 - [clangd] Revamp handling of diagnostics.

Author: ibiryukov Date: Mon Mar 12 08:28:22 2018 New Revision: 327282 URL: http://llvm.org/viewvc/llvm-project?rev=327282=rev Log: [clangd] Revamp handling of diagnostics. Summary: The new implementation attaches notes to diagnostic message and shows the original diagnostics in the message of

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure what's the right way to fix it. I'll revert this commit for now to unblock integration. Let me know if you need more information from us. Regards, Eric On Mon, Mar 12, 2018 at 4:51 PM Eric Liu wrote: >

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

Do you have a reproducer? > On Mar 12, 2018, at 9:07 AM, Eric Liu wrote: > > I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure > what's the right way to fix it. I'll revert this commit for now to unblock > integration. Let me know if you need more

RE: r326946 - CodeGen: Fix address space of indirect function argument

I will try implementing John's suggestions. Thanks. Sam From: rjmcc...@apple.com [mailto:rjmcc...@apple.com] Sent: Saturday, March 10, 2018 12:14 PM To: Richard Smith Cc: Liu, Yaxun (Sam) ; cfe-commits Subject: Re: r326946

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

ilya-biryukov updated this revision to Diff 137985. ilya-biryukov added a comment. - Added unit test for toLSPDiags Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44142 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

boga95 added a subscriber: szepet. boga95 marked 4 inline comments as done. boga95 added inline comments. Comment at: test/clang-tidy/cert-properly-seeded-random-generator.cpp:76 + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: random number generator must be seeded with a

[libclc] r327324 - nan: Implement

Author: jvesely Date: Mon Mar 12 12:46:52 2018 New Revision: 327324 URL: http://llvm.org/viewvc/llvm-project?rev=327324=rev Log: nan: Implement Passes CTS on carrizo and turks Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added:

RE: [clang-tools-extra] r327295 - Reland "[clang-doc] Setup clang-doc frontend framework"

Hi Julie, It looks like this commit is causing Clang tests in Windows bots to crash. Could you take a look? http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9413 Thanks, Matthew -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of

[PATCH] D44346: [clang-tidy] Add Fuchsia checker for temporary objects

aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44 +CheckFactories.registerCheck( +"fuchsia-zx-temporary-objects"); } Do we want a zircon module instead? I'm wondering about people who enable modules by

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this check LGTM. https://reviews.llvm.org/D41655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] r327323 - travis: Add build using llvm-6

Author: jvesely Date: Mon Mar 12 12:46:48 2018 New Revision: 327323 URL: http://llvm.org/viewvc/llvm-project?rev=327323=rev Log: travis: Add build using llvm-6 Acked-by: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Since the commit was reverted, did you mean to either recommit it, or reopen this (with updated diff), so it does not get lost? Repository: rL LLVM https://reviews.llvm.org/D41102 ___ cfe-commits mailing list

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

The patch I committed moved CXXRecordDecl::CanPassInRegisters to RecordDecl. It looks like ASTImporter::ImportDefinition no longer copies the bit for CanPassInRegisters after that change. I’m not sure that is what’s causing tests to fail. > On Mar 12, 2018, at 9:29 AM, Eric Liu

[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327293: [clangd] Fix diagnostic errors in the test code, NFC. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D44294?vs=137712=138039#toc Repository: rCTE

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

hokein added inline comments. Comment at: clangd/XRefs.cpp:201 std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos(); + if (!MacroInfos.empty()) { +for (auto Item : MacroInfos) { ilya-biryukov wrote: > I wonder whether we should fix the

[clang-tools-extra] r327293 - [clangd] Fix diagnostic errors in the test code, NFC.

Author: hokein Date: Mon Mar 12 09:49:24 2018 New Revision: 327293 URL: http://llvm.org/viewvc/llvm-project?rev=327293=rev Log: [clangd] Fix diagnostic errors in the test code, NFC. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: klimek, jkorous-apple, cfe-commits, ioeric

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

I’m not sure if this a bug r327206 introduced or an existing bug in ASTImporter as there are other bits in RecordDecl that are not copied, but I think I should revert the patch for now. > On Mar 12, 2018, at 9:57 AM, Eric Liu wrote: > > I think it's likely as our tests only

[clang-tools-extra] r327295 - Reland "[clang-doc] Setup clang-doc frontend framework"

Author: juliehockett Date: Mon Mar 12 10:05:14 2018 New Revision: 327295 URL: http://llvm.org/viewvc/llvm-project?rev=327295=rev Log: Reland "[clang-doc] Setup clang-doc frontend framework" There was a missing newline in the docs, and a static_assert that needed to be a normal assert. Added:

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1034919, @lebedev.ri wrote: > Since the commit was reverted, did you mean to either recommit it, or reopen > this (with updated diff), so it does not get lost? Relanded in r327295. Comment at:

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

I have been trying to reduce a reproducer for this but haven't gotten any luck yet. The error happens in conversion between different version of STL containers and is a bit hard to reduce. I'll keep trying to create a reproducer. Could you please also take a quick look to see if

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

I think it's likely as our tests only fail with module enabled (without module, ASTImporter isn't really used). On Mon, Mar 12, 2018 at 5:51 PM Akira Hatanaka wrote: > The patch I committed moved CXXRecordDecl::CanPassInRegisters to > RecordDecl. It looks like

r327294 - Revert "[ObjC] Allow declaring __weak pointer fields in C structs in

tch. http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180312/221427.html Removed: cfe/trunk/test/CodeGenObjC/weak-in-c-struct.m Modified: cfe/trunk/include/clang/AST/Decl.h cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/include/clang/AST/Type.h cfe/trunk/lib/AST/ASTImporter.c

Re: r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

Thanks a lot Akira! FWIW, it seems that the FIXME here might be related https://github.com/llvm-mirror/clang/blob/master/include/clang/AST/DeclCXX.h#L1484 On Mon, Mar 12, 2018 at 6:03 PM Akira Hatanaka wrote: > I’m not sure if this a bug r327206 introduced or an existing

[PATCH] D44411: [libc++] Fix Container::insert(value_type const&) tests

jloser created this revision. jloser added reviewers: EricWF, matthew. Herald added subscribers: cfe-commits, christof. [libc++] Fix Container::insert(value_type const&) tests Several unit tests meaning to test the behavior of lvalue insertion incorrectly pass rvalues. Fixes bug 27394.

[PATCH] D44131: [analyzer] Support temporaries conjured by conservatively evaluated functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC327348: [analyzer] Support temporaries conjured by conservatively evaluated functions. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44131 Files:

r327348 - [analyzer] Support temporaries conjured by conservatively evaluated functions.

Author: dergachev Date: Mon Mar 12 16:36:12 2018 New Revision: 327348 URL: http://llvm.org/viewvc/llvm-project?rev=327348=rev Log: [analyzer] Support temporaries conjured by conservatively evaluated functions. Properly perform destruction and lifetime extension of such temporaries. C++

[PATCH] D44273: [CFG] [analyzer] Fix a crash on finding construction context for an lvalue/xvalue call expression.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC327352: [CFG] [analyzer] Dont add construction context to a return-by-reference call. (authored by dergachev, committed

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added a comment. It seems like there are some other changes than just the serialize and deserialize that I'm not opposed to, but am wondering why they're needed. It seems some functions are now `getFoo()` calls and it seems like some declarations moved around. Are those intended

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1035466, @aaron.ballman wrote: > It seems like there are some other changes than just the serialize and > deserialize that I'm not opposed to, but am wondering why they're needed. It > seems some functions are now `getFoo()` calls

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, mgorny, klimek. This patch moves the draft manager closer to the edge of Clangd, from ClangdServer to ClangdLSPServer. This will make it easier to implement incremental document sync, by

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the test comments fixed up. Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5 +// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp +// RUN:

[PATCH] D43737: Improve -Winfinite-recursion

rtrieu added a comment. > I believe you were around this code last, so can you remember why it was > there? Yes, that's an early exit to speed up the check. You can remove that check and add a test case for it. This was a little confusing for me, so let's refactor it a little. These

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 138111. jdenny added a comment. OK, this diff has the svn paths, and I've rebased to a more recent master. https://reviews.llvm.org/D43248 Files: trunk/include/clang/AST/Attr.h trunk/include/clang/Basic/Attr.td trunk/lib/AST/ExprConstant.cpp

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: cfe/trunk/test/Frontend/ast-attr.cpp:5 +// RUN: %clang -emit-ast -o %t.ast %S/../Sema/attr-print.cpp +// RUN: %clang_cc1 %t.ast -ast-print | FileCheck %S/../Sema/attr-print.cpp aaron.ballman wrote: > Just to verify my

[clang-tools-extra] r327346 - Revert "Reland "[clang-doc] Setup clang-doc frontend framework""

Author: juliehockett Date: Mon Mar 12 16:23:24 2018 New Revision: 327346 URL: http://llvm.org/viewvc/llvm-project?rev=327346=rev Log: Revert "Reland "[clang-doc] Setup clang-doc frontend framework"" This reverts commit r327295 since it was causing the Windows bots to fail. Removed:

[clang-tools-extra] r327344 - [clangd] Remove Tagged and some related APIs from ClangdServer.

Author: sammccall Date: Mon Mar 12 16:22:35 2018 New Revision: 327344 URL: http://llvm.org/viewvc/llvm-project?rev=327344=rev Log: [clangd] Remove Tagged and some related APIs from ClangdServer. Context can do what Tagged was intended to support (snapshot filesystems), and less intrusively.

  1   2   >