[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

flyingforyou updated this revision to Diff 142265. flyingforyou added a comment. Addressed SjoerdMeijer' new comments. Thanks. > Also wanted to confirm that macro __ARM_FEATURE_DOTPROD will defined/included > in the next release of the ACLE. Could you check it, please? I saw several codes that

[PATCH] D45596: [libcxx] [test] Avoid unary_function.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Avoid unary_function. Replace unary_function inheritance (which was never required, even in C++98) with argument_type and result_type typedefs. This increases portability, as unary_function was removed

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This would have been fine for post-commit review. https://reviews.llvm.org/D45594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r329932 - NFC - Indentation fixes in predefined-arch-macros.c

Author: gbuella Date: Thu Apr 12 11:15:39 2018 New Revision: 329932 URL: http://llvm.org/viewvc/llvm-project?rev=329932=rev Log: NFC - Indentation fixes in predefined-arch-macros.c Consistently separating tests with empty lines. Helps while navigating this file. Reviewers: craig.topper

r329937 - [X86] Introduce wbinvd intrinsic

Author: gbuella Date: Thu Apr 12 11:42:02 2018 New Revision: 329937 URL: http://llvm.org/viewvc/llvm-project?rev=329937=rev Log: [X86] Introduce wbinvd intrinsic A previously missing intrinsic for an old instruction. Reviewers: craig.topper, echristo Reviewed By: craig.topper Differential

Improve non-void no return warning

I changed the messages like "control may reach end of non-void function" to "non-void function may not return a value" I think this is a lot more understandable. better-nonvoid-no-return-message.patch Description: Binary data ___ cfe-commits mailing

[PATCH] D45217: [ThinLTO] Pass -save-temps to LTO backend for distributed ThinLTO builds

tejohnson added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45109: Remove -cc1 option "-backend-option"

This revision was automatically updated to reflect the committed changes. Closed by commit rL329965: Remove -cc1 option -backend-option. (authored by efriedma, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45109?vs=140484=142277#toc

[PATCH] D45597: [Driver] Android triples are not aliases for other triples.

danalbert created this revision. danalbert added a reviewer: srhines. Android targets should never use tools/libraries for non-Android targets or vice versa. Repository: rC Clang https://reviews.llvm.org/D45597 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/android-ndk-standalone.cpp

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:443 return Sym->getType() == Ty && +APSIntType(Int) == BV.getAPSIntType(Sym->getType()) && (!BinaryOperator::isComparisonOp(Op) || 6. Therefore i conclude that this

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

I composed a test and you are right - for multi-token type names new code returns wrong result. So this new code was a premature optimization. Sorry. I'll see how to fix it in a better way and create a review on it. Thanks for poiting. чт, 12 апр. 2018 г. в 20:01, Alexander Kornienko

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

On Thu, Apr 12, 2018 at 10:47 PM, Zinovy Nis via cfe-commits wrote: > I composed a test and you are right - for multi-token type names new code > returns wrong result. So this new code was a premature optimization. Sorry. > I'll see how to fix it in a better way and

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

MaskRay added inline comments. Comment at: clangd/index/Index.h:32 +// Character offset on a line in a document (zero-based). +int Character = 0; + }; hokein wrote: > sammccall wrote: > > sammccall wrote: > > > Column? > > > > > > LSP calls this

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek added a comment. In https://reviews.llvm.org/D45529#1066394, @EricWF wrote: > OK, so we need to bump the SO version -- However I don't want to generate a > __site_config header because of that if the __config header is sufficient. I > would like to see a solution that takes that into

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file: instead of changing the run lines to use -mllvm you have removed them. Was there a reason for the

[PATCH] D45109: Remove -cc1 option "-backend-option"

george.karpenkov added subscribers: efriedma, george.karpenkov. george.karpenkov added a comment. Hi Eli, The commit makes sense, but I’m not sure about your change to the `test/Driver/apple-kext-mkernel.c ` file:

[PATCH] D45601: Warn on bool* to bool conversion

hiraditya created this revision. hiraditya added reviewers: Eugene.Zelenko, rsmith. We found conversion from bool* to bool to be a common source of bug, so we have implemented this warning. Sample use case: int bar(bool b) { return b; } int baz() { bool *b; bar(b);

[clang-tools-extra] r329949 - Revert "[clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself"

Author: zinovy.nis Date: Thu Apr 12 13:33:24 2018 New Revision: 329949 URL: http://llvm.org/viewvc/llvm-project?rev=329949=rev Log: Revert "[clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself" This reverts r329873 as getting only a single token length is wrong for

[PATCH] D45591: Clean carriage returns from lib/ and include/. NFC.

Quuxplusone created this revision. Herald added subscribers: cfe-commits, krytarowski, emaste. Clean carriage returns from lib/ and include/. NFC. (I have to make this change locally in order for `git diff` to show sane output after I edit a file, so I might as well ask for it to be committed. I

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Fix nodiscard warnings. MSVC's STL has marked to_bytes/from_bytes as nodiscard. https://reviews.llvm.org/D45595 Files:

r329942 - Fix doc typo

Author: vlad.tsyrklevich Date: Thu Apr 12 12:35:39 2018 New Revision: 329942 URL: http://llvm.org/viewvc/llvm-project?rev=329942=rev Log: Fix doc typo Modified: cfe/trunk/docs/ControlFlowIntegrity.rst Modified: cfe/trunk/docs/ControlFlowIntegrity.rst URL:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

phosek updated this revision to Diff 142261. phosek marked an inline comment as done. phosek added a comment. I had something similar in https://reviews.llvm.org/D45304 but Eric suggested removing it. What I haven't realized is that this value is also used to set the SOVERSION so it's indeed

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

EricWF added a comment. OK, so we need to bump the SO version -- However I don't want to generate a __site_config header because of that if the __config header is sufficient. I would like to see a solution that takes that into account. Repository: rCXX libc++

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. [libcxx] [test] Silence MSVC warning C4146. This test code triggers the MSVC warning: "unary minus operator applied to unsigned type, result still unsigned" Although it would be possible to change the test code to

Re: [PATCH] D45109: Remove -cc1 option "-backend-option"

The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli On 4/12/2018 3:55 PM, George Karpenkov wrote: Hi Eli, The commit makes sense, but I’m not sure about your change to the

[PATCH] D45109: Remove -cc1 option "-backend-option"

efriedma added a subscriber: pcc. efriedma added a comment. The test wasn't checking anything useful; the clang driver never passes "-arm-long-calls" to clang -cc1.  See https://reviews.llvm.org/rL241565 . -Eli Repository: rL LLVM https://reviews.llvm.org/D45109

[PATCH] D45237: [RISCV] Fix logic to check if frame pointer should be used

This revision was automatically updated to reflect the committed changes. Closed by commit rL329941: [RISCV] Fix logic to check if frame pointer should be used (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

This revision was automatically updated to reflect the committed changes. Closed by commit rC329946: [MinGW] Look for libc++ headers in a triplet prefixed path as well (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D45500?vs=141894=142243#toc

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL329946: [MinGW] Look for libc++ headers in a triplet prefixed path as well (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r329946 - [MinGW] Look for libc++ headers in a triplet prefixed path as well

Author: mstorsjo Date: Thu Apr 12 13:07:38 2018 New Revision: 329946 URL: http://llvm.org/viewvc/llvm-project?rev=329946=rev Log: [MinGW] Look for libc++ headers in a triplet prefixed path as well This makes it consistent with libstdc++ and the other default include directories. If these

r329952 - [NFC] Fix terrible formatting of CGRecordLower constructor.

Author: erichkeane Date: Thu Apr 12 13:46:31 2018 New Revision: 329952 URL: http://llvm.org/viewvc/llvm-project?rev=329952=rev Log: [NFC] Fix terrible formatting of CGRecordLower constructor. Modified: cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp Modified:

r329965 - Remove -cc1 option "-backend-option".

Author: efriedma Date: Thu Apr 12 15:21:36 2018 New Revision: 329965 URL: http://llvm.org/viewvc/llvm-project?rev=329965=rev Log: Remove -cc1 option "-backend-option". It means the same thing as -mllvm; there isn't any reason to have two options which do the same thing. Differential Revision:

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/Expr.h:3097-3106 + bool isRelationalOp() const { +return isRelationalOp(getOpcode()) || + (getOpcode() == BO_Cmp && IsCmpOrdered); + } static bool

[PATCH] D45068: [NVPTX, CUDA] Added support for m8n32k16 and m32n8k16 variants of wmma instructions.

tra updated this revision to Diff 142262. tra added a comment. Updated BuiltinsNVPTX.def and tests to deal with changes in the way we deal with required features in TARGET_BUILTIN. https://reviews.llvm.org/D45068 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D45217: [ThinLTO] Pass -save-temps to LTO backend for distributed ThinLTO builds

pcc added inline comments. Comment at: include/clang/Driver/Options.td:2255 HelpText<"Save intermediate compilation results.">; -def save_temps : Flag<["-", "--"], "save-temps">, Flags<[DriverOption]>, +def save_temps : Flag<["-", "--"], "save-temps">, Flags<[CC1Option,

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 142279. apazos added a comment. Updated error messages and fixed getExtensionVersion https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index:

[PATCH] D45596: [libcxx] [test] Avoid unary_function.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think this would have been a good candidate for post-commit review. https://reviews.llvm.org/D45596 ___ cfe-commits mailing list

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. There's a macro for this in test_macros.h to make it easier to search for. please use that https://reviews.llvm.org/D45595 ___ cfe-commits

r329968 - Fix test failure caused by r329965.

Author: efriedma Date: Thu Apr 12 15:50:50 2018 New Revision: 329968 URL: http://llvm.org/viewvc/llvm-project?rev=329968=rev Log: Fix test failure caused by r329965. "-mllvm" options get parsed slightly earlier, and -arm-restrict-it is only available if the ARM target is compiled in. Invoke

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai created this revision. vsapsai added a reviewer: bkramer. Herald added a subscriber: jkorous-apple. `__has_include_next` requires correct DirectoryLookup for being evaluated correctly. We were using Preprocessor::GetCurDirLookup() but we were calling it after the preprocessor finished its

[PATCH] D45595: [libcxx] [test] Fix nodiscard warnings.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed with a follow-up to use the requested macro. https://reviews.llvm.org/D45595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Buildbot numbers for the week of 3/25/2018 - 3/31/2018

Hello everyone, Below are some buildbot numbers for the week of 3/25/2018 - 3/31/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 7 inline comments as done. EricWF added inline comments. Comment at: lib/AST/ExprConstant.cpp:6238-6263 +bool VisitBinCmp(const BinaryOperator *E) { + using CCR = ComparisonCategoryResult; + const ComparisonCategoryInfo = +

[PATCH] D45610: [XRay][clang] Make -fxray-modes= additive

dberris created this revision. dberris added reviewers: eizan, kpw, pelikan. This allows us to do the following: clang -fxray-modes=none ... -fxray-modes=xray-basic It's important to be able to do this in cases where we'd like to specialise the configuration for the invocation of the

[PATCH] D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL329984: [CMake][Fuchsia] Dont specify libc++ ABI version for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai added a comment. To simplify reviewing additions to the test, here is the corresponding output # 23 "/Users/vsapsai/Projects/llvm/llvm-project/clang/test/Frontend/rewrite-includes.c" 2 #if 0 /* expanded by -frewrite-includes */ #include "rewrite-includes9.h" #endif /* expanded

[libcxx] r329978 - [libcxx] [test] Fix whitespace, NFC.

Author: stl_msft Date: Thu Apr 12 16:56:22 2018 New Revision: 329978 URL: http://llvm.org/viewvc/llvm-project?rev=329978=rev Log: [libcxx] [test] Fix whitespace, NFC. test/std almost always uses spaces; now it is entirely tab-free. Modified:

[libcxx] r329976 - [libcxx] [test] Silence MSVC warning C4146.

Author: stl_msft Date: Thu Apr 12 16:56:14 2018 New Revision: 329976 URL: http://llvm.org/viewvc/llvm-project?rev=329976=rev Log: [libcxx] [test] Silence MSVC warning C4146. This test code triggers the MSVC warning: "unary minus operator applied to unsigned type, result still unsigned"

[libcxx] r329975 - [libcxx] [test] Fix nodiscard warnings.

Author: stl_msft Date: Thu Apr 12 16:56:12 2018 New Revision: 329975 URL: http://llvm.org/viewvc/llvm-project?rev=329975=rev Log: [libcxx] [test] Fix nodiscard warnings. MSVC's STL has marked to_bytes/from_bytes as nodiscard. Fixes D45595. Modified:

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 5 inline comments as done. EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9377-9378 +def err_implied_comparison_category_type_not_found : Error< + "%0 type was not found; include before defining " + "or using

[libcxx] r329983 - [CMake] Set the default ABI version for Fuchsia in CMake as well

Author: phosek Date: Thu Apr 12 18:59:15 2018 New Revision: 329983 URL: http://llvm.org/viewvc/llvm-project?rev=329983=rev Log: [CMake] Set the default ABI version for Fuchsia in CMake as well This is neeeded since the CMake value is used for the SOVERSION. Differential Revision:

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris updated this revision to Diff 142315. dberris marked 5 inline comments as done. dberris added a comment. - fixup: Address comments https://reviews.llvm.org/D44970 Files: clang/include/clang/Basic/XRayInstr.h clang/include/clang/Driver/Options.td

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

dberris added a comment. Thanks, Martin! Landing now, after suggested changes. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:471 bool CodeGenFunction::AlwaysEmitXRayCustomEvents() const { - return CGM.getCodeGenOpts().XRayAlwaysEmitCustomEvents; + return

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

This revision was automatically updated to reflect the committed changes. Closed by commit rC329985: [XRay][clang] Add flag to choose instrumentation bundles (authored by dberris, committed by ). Changed prior to commit: https://reviews.llvm.org/D44970?vs=142315=142317#toc Repository: rC

r329985 - [XRay][clang] Add flag to choose instrumentation bundles

Author: dberris Date: Thu Apr 12 19:31:58 2018 New Revision: 329985 URL: http://llvm.org/viewvc/llvm-project?rev=329985=rev Log: [XRay][clang] Add flag to choose instrumentation bundles Summary: This change addresses http://llvm.org/PR36926 by allowing users to pick which instrumentation bundles

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 142328. malaperle marked an inline comment as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:113 + auto KindVal = static_cast(Kind); + if (KindVal >= SymbolKindMin && KindVal <= SymbolKindMax) +SupportedSymbolKinds.set(KindVal);

[libcxx] r329973 - [libcxx] [test] Avoid MSVC truncation warnings.

Author: stl_msft Date: Thu Apr 12 16:56:07 2018 New Revision: 329973 URL: http://llvm.org/viewvc/llvm-project?rev=329973=rev Log: [libcxx] [test] Avoid MSVC truncation warnings. MSVC emits "warning C4244: 'initializing': conversion from 'int' to 'short', possible loss of data" when it sees

[libcxx] r329977 - [libcxx] [test] Use TEST_COMPILER_C1XX.

Author: stl_msft Date: Thu Apr 12 16:56:17 2018 New Revision: 329977 URL: http://llvm.org/viewvc/llvm-project?rev=329977=rev Log: [libcxx] [test] Use TEST_COMPILER_C1XX. Also TEST_COMPILER_CLANG in one place. (More could be changed.) Modified:

[libcxx] r329974 - [libcxx] [test] Avoid unary_function.

Author: stl_msft Date: Thu Apr 12 16:56:10 2018 New Revision: 329974 URL: http://llvm.org/viewvc/llvm-project?rev=329974=rev Log: [libcxx] [test] Avoid unary_function. Replace unary_function inheritance (which was never required, even in C++98) with argument_type and result_type typedefs. This

[PATCH] D45594: [libcxx] [test] Silence MSVC warning C4146.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed, with a follow-up to use the C1XX macro. https://reviews.llvm.org/D45594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Approved by Eric. https://reviews.llvm.org/D45016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45601: Warn on bool* to bool conversion

Eugene.Zelenko added a comment. There is Clang-tidy's readability-implicit-bool-conversion check. It may be reasonable to check pointers to integers too, since integers are often implicitly converted to

[PATCH] D45290: [Driver] Use the per-API level Android library directories.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM (did not check the tests). Comment at: lib/Driver/ToolChains/Linux.cpp:25 #include "llvm/Support/Path.h" +#include "llvm/Support/ScopedPrinter.h" #include

[PATCH] D45601: Warn on bool* to bool conversion

Quuxplusone added inline comments. Comment at: test/CXX/expr/expr.unary/expr.unary.op/p6.cpp:18 // -- pointer, bool b6 = ! // expected-warning{{address of 'b4' will always evaluate to 'true'}} +// expected-warning@-1 {{comparing 'bool *' as a boolean}} This

r329984 - [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

Author: phosek Date: Thu Apr 12 19:02:13 2018 New Revision: 329984 URL: http://llvm.org/viewvc/llvm-project?rev=329984=rev Log: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia This is now set automatically in libc++ config header. Differential Revision:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL329983: [CMake] Set the default ABI version for Fuchsia in CMake as well (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45526: [clang-format] Do not break after ObjC category open paren

benhamilton updated this revision to Diff 142182. benhamilton marked an inline comment as done. benhamilton added a comment. - Update comment. Repository: rC Clang https://reviews.llvm.org/D45526 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D45526: [clang-format] Do not break after ObjC category open paren

benhamilton added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2276 + // In Objective-C type declarations, prefer breaking after the category's + // close paren instead of after the open paren. + if (Line.Type == LT_ObjCDecl && Left.is(tok::l_paren) &&

[PATCH] D45004: [clang-format] Always indent wrapped Objective-C selector names

benhamilton updated this revision to Diff 142183. benhamilton marked an inline comment as done. benhamilton added a comment. Update comment. Repository: rC Clang https://reviews.llvm.org/D45004 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

tkrupa added a comment. I'll wait with upstreaming this patch until there's an agreement on mask scalar approach. Repository: rC Clang https://reviews.llvm.org/D41168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45004: [clang-format] Always indent wrapped Objective-C selector names

benhamilton added inline comments. Comment at: unittests/Format/FormatTest.cpp:7666 FormatStyle Style = getLLVMStyle(); + // ObjC ignores IndentWrappedFunctionNames when wrapping methods. Style.IndentWrappedFunctionNames = false; djasper wrote: > maybe:

[PATCH] D45498: [clang-format] Don't insert space between ObjC class and lightweight generic

benhamilton updated this revision to Diff 142186. benhamilton marked an inline comment as done. benhamilton added a comment. Avoid else after return. Clean up logic so it doesn't need a comment. Repository: rC Clang https://reviews.llvm.org/D45498 Files: lib/Format/TokenAnnotator.cpp

[PATCH] D45564: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

xazax.hun added a comment. We encountered the same problem but did not have time yet to submit the patch. We have literally the same fix internally, so it looks good to me. One minor style nit inline. Could you add your repro as a regression test? You can also extend existing CTU tests just

r329917 - [clang-format] Don't insert space between ObjC class and lightweight generic

Author: benhamilton Date: Thu Apr 12 08:11:51 2018 New Revision: 329917 URL: http://llvm.org/viewvc/llvm-project?rev=329917=rev Log: [clang-format] Don't insert space between ObjC class and lightweight generic Summary: In D45185, I added clang-format parser support for Objective-C generics.

r329916 - [clang-format] Always indent wrapped Objective-C selector names

Author: benhamilton Date: Thu Apr 12 08:11:48 2018 New Revision: 329916 URL: http://llvm.org/viewvc/llvm-project?rev=329916=rev Log: [clang-format] Always indent wrapped Objective-C selector names Summary: Currently, indentation of Objective-C method names which are wrapped onto the next line

r329919 - [clang-format] Do not break after ObjC category open paren

Author: benhamilton Date: Thu Apr 12 08:11:55 2018 New Revision: 329919 URL: http://llvm.org/viewvc/llvm-project?rev=329919=rev Log: [clang-format] Do not break after ObjC category open paren Summary: Previously, `clang-format` would break Objective-C category extensions after the opening

[PATCH] D45521: [clang-format] Improve ObjC guessing heuristic by supporting all @keywords

This revision was automatically updated to reflect the committed changes. Closed by commit rL329918: [clang-format] Improve ObjC guessing heuristic by supporting all @keywords (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D45498: [clang-format] Don't insert space between ObjC class and lightweight generic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329917: [clang-format] Dont insert space between ObjC class and lightweight generic (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

r329918 - [clang-format] Improve ObjC guessing heuristic by supporting all @keywords

Author: benhamilton Date: Thu Apr 12 08:11:53 2018 New Revision: 329918 URL: http://llvm.org/viewvc/llvm-project?rev=329918=rev Log: [clang-format] Improve ObjC guessing heuristic by supporting all @keywords Summary: This diff improves the Objective-C guessing heuristic by replacing the

[PATCH] D45004: [clang-format] Always indent wrapped Objective-C selector names

This revision was automatically updated to reflect the committed changes. Closed by commit rC329916: [clang-format] Always indent wrapped Objective-C selector names (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D45004?vs=142183=142187#toc

[PATCH] D45526: [clang-format] Do not break after ObjC category open paren

This revision was automatically updated to reflect the committed changes. Closed by commit rL329919: [clang-format] Do not break after ObjC category open paren (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D45458: MallocChecker refactoring of calls checkers

xazax.hun added a comment. In https://reviews.llvm.org/D45458#1062342, @NoQ wrote: > @xazax.hun: do you think the approach you took in the `Valist` checker is > applicable here? Did you like how it ended up working? Cause i'd love to see > `CallDescription` and initializer lists used for

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, with - consider reverting the bitpacking stuff - comment about utf-16 - clang-format :) Comment at: clangd/index/SymbolCollector.cpp:202 +

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added a comment. Thank you for all your comments so far! I'll probably only be able to update the diff tomorrow (with me being in the GMT + 1 timezone). > That's a lot of code, so it'll take me some time to understand what's going > on here. You might be able to help me by the large

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added inline comments. Comment at: test/Analysis/ctor-uninitialized-member-inheritance.cpp:24 + : NonPolymorphicLeft1(int{}) { +y = 420; +z = 420; Szelethus wrote: > whisperity wrote: > > The literal `420` is repeated //everywhere// in

[PATCH] D45407: [StaticAnalyzer] Added notes to the plist output

Szelethus added a comment. Did you have some time to check on those programs? :) Repository: rC Clang https://reviews.llvm.org/D45407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r329979 - [libcxx] [test] Use TEST_IGNORE_NODISCARD.

Author: stl_msft Date: Thu Apr 12 17:07:48 2018 New Revision: 329979 URL: http://llvm.org/viewvc/llvm-project?rev=329979=rev Log: [libcxx] [test] Use TEST_IGNORE_NODISCARD. Fixes D45595. Modified:

[PATCH] D45529: [CMake] Set the default ABI version for Fuchsia in CMake as well

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Eric accepted on IRC. Repository: rCXX libc++ https://reviews.llvm.org/D45529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Buildbot numbers for the week of 4/1/2018 - 4/7/2018

Hello everyone, Below are some buildbot numbers for the last week of 4/1/2018 - 4/7/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1065632, @sammccall wrote: > In https://reviews.llvm.org/D44882#1065631, @malaperle wrote: > > > In https://reviews.llvm.org/D44882#1065622, @sammccall wrote: > > > > > Still LG, thanks! > > > I'll look into the testing issue. > > >

r329879 - [Sema][ObjC] Ensure that the return type of an ObjC method is a complete

Author: ahatanak Date: Wed Apr 11 23:01:41 2018 New Revision: 329879 URL: http://llvm.org/viewvc/llvm-project?rev=329879=rev Log: [Sema][ObjC] Ensure that the return type of an ObjC method is a complete type. Copy the code in ActOnStartOfFunctionDef that checks a function's return type to

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

TimF added a comment. In https://reviews.llvm.org/D28462#1064789, @enyquist wrote: > As far as I know, there are no updates required from me for this pull > request-- I rebased on the main trunk recently, and will do it again tonight > to be sure. So it should be compiling/working just fine. >

[PATCH] D45403: Make [[maybe_unused]] work with static data members

cpplearner added a comment. I do not have commit access. Could someone commit the change for me? https://reviews.llvm.org/D45403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields short

Author: theraven Date: Wed Apr 11 23:46:15 2018 New Revision: 329882 URL: http://llvm.org/viewvc/llvm-project?rev=329882=rev Log: ObjCGNU: Fix empty v3 protocols being emitted two fields short Summary: Protocols that were being referenced but could not be fully realized were being emitted

[clang-tools-extra] r329881 - [clang-tidy] [modernize-use-auto] Fix test modernize-use-auto-new-remove-stars.cpp after improvement

Author: zinovy.nis Date: Wed Apr 11 23:45:47 2018 New Revision: 329881 URL: http://llvm.org/viewvc/llvm-project?rev=329881=rev Log: [clang-tidy] [modernize-use-auto] Fix test modernize-use-auto-new-remove-stars.cpp after improvement 'tooling::fixit::getText' considers a length of "int *" to be

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

This revision was automatically updated to reflect the committed changes. Closed by commit rC329882: ObjCGNU: Fix empty v3 protocols being emitted two fields short (authored by theraven, committed by ). Repository: rC Clang https://reviews.llvm.org/D45305 Files: lib/CodeGen/CGObjCGNU.cpp

<    1   2