JonasToth updated this revision to Diff 167282.
JonasToth marked 3 inline comments as done.
JonasToth added a comment.
- add space after clang-tidy in banner
- refactor slightly, add better in-code comments to explain whats happening,
add more TODOs and FIXMEs
Repository:
rCTE Clang Tools
kadircet added inline comments.
Comment at: unittests/clangd/ClangdUnitTests.cpp:82
o]]();
- foo()$semicolon[[]]
+ foo()$semicolon[[]]//with comments
$unk[[unknown]]();
ioeric wrote:
> What is this `//with comments` for? Maybe explain it in the
kadircet updated this revision to Diff 167283.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52544
Files:
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Index:
Author: kadircet
Date: Thu Sep 27 05:12:42 2018
New Revision: 343197
URL: http://llvm.org/viewvc/llvm-project?rev=343197=rev
Log:
Improve diagnostics range reporting.
Summary:
If we have some range information coming from clang diagnostic, promote
that one even if it doesn't contain diagnostic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343197: Improve diagnostics range reporting. (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52544
Files:
Author: jonastoth
Date: Thu Sep 27 05:17:59 2018
New Revision: 343198
URL: http://llvm.org/viewvc/llvm-project?rev=343198=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace
Reviewers: aaron.ballman, alexfh, hokein
Subscribers: xazax.hun, cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343198: [clang-tidy] use CHECK-NOTES in tests for
bugprone-forward-declaration-namespace (authored by JonasToth,
atanasyan added a comment.
Could you please update the patch against the current trunk?
Repository:
rC Clang
https://reviews.llvm.org/D50850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: jonastoth
Date: Thu Sep 27 05:22:48 2018
New Revision: 343199
URL: http://llvm.org/viewvc/llvm-project?rev=343199=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move
Reviewers: alexfh, aaron.ballman, hokein
Subscribers: xazax.hun, cfe-commits
Differential
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343199: [clang-tidy] use CHECK-NOTES in tests for
bugprone-use-after-move (authored by JonasToth, committed by ).
Herald
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343201: [clang-tidy] use CHECK-NOTES in tests for bugprone
suspicious-enum-usage (authored by JonasToth, committed by ).
Author: jonastoth
Date: Thu Sep 27 05:30:44 2018
New Revision: 343201
URL: http://llvm.org/viewvc/llvm-project?rev=343201=rev
Log:
[clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage
Reviewers: alexfh, aaron.ballman, hokein
Subscribers: xazax.hun, cfe-commits
Differential
Author: szelethus
Date: Thu Sep 27 05:40:16 2018
New Revision: 343204
URL: http://llvm.org/viewvc/llvm-project?rev=343204=rev
Log:
[Lex] TokenConcatenation now takes const Preprocessor
Differential Revision: https://reviews.llvm.org/D52502
Modified:
kadircet added a comment.
In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:
> A drive-by comment.
> Would it be cleaner to pass this information from clang? Relying on
> completion label seems shaky.
Actually I also wanted to do that at first, but then wasn't really sure
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343204: [Lex] TokenConcatenation now takes const
Preprocessor (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
steveire added a comment.
@JonasToth Once again - `clangStaticAnalyzerCheckers` is not `clangAnalysis`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: szelethus
Date: Thu Sep 27 05:46:37 2018
New Revision: 343205
URL: http://llvm.org/viewvc/llvm-project?rev=343205=rev
Log:
Revert untintentionally commited changes
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
Modified:
Szelethus added inline comments.
Comment at:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:82-84
+ // TODO: This destructor shouldn't be virtual, but breaks buildbots with
+ // -Werror -Wnon-virtual-dtor.
+ virtual ~FieldNode() = default;
JonasToth added a comment.
In https://reviews.llvm.org/D52334#1247809, @steveire wrote:
> @JonasToth Once again - `clangStaticAnalyzerCheckers` is not `clangAnalysis`.
> Also, that commit changes the `mpi` plugin, which is excluded by this patch.
I pinged because of the MPI thing, i did not
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D51686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: svenvh
Date: Thu Sep 27 06:20:29 2018
New Revision: 343207
URL: http://llvm.org/viewvc/llvm-project?rev=343207=rev
Log:
[OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests
Add cl_khr_depth_images to extension-version.cl.
Extend to_addr_builtin.cl to additionally test the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343207: [OpenCL] Improve extension-version.cl and
to_addr_builtin.cl tests (authored by svenvh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52611
Files:
clangd/index/MemIndex.cpp
clangd/index/Merge.cpp
kbobyrev added a comment.
A lot of good improvements and many test cases, thank you!
The comments are mostly nits.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52547#1247794, @kadircet wrote:
> In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:
>
> > A drive-by comment.
> > Would it be cleaner to
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Merge.cpp:42
// 3) now yield all the dynamic symbols we haven't processed.
+ trace::Span Tracer("MergedIndex fuzzyFind");
kadircet updated this revision to Diff 167320.
kadircet marked 2 inline comments as done.
kadircet added a comment.
Preparing the patch to respect client capabilities.
- Add other itemkinds as well.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52547
Author: olista01
Date: Thu Sep 27 07:20:59 2018
New Revision: 343220
URL: http://llvm.org/viewvc/llvm-project?rev=343220=rev
Log:
[AArch64][v8.5A] Test optional Armv8.5-A random number extension
The implementation of this is in TargetParser, so we only need to add a
test for it in clang.
Patch
Author: kadircet
Date: Thu Sep 27 07:21:07 2018
New Revision: 343221
URL: http://llvm.org/viewvc/llvm-project?rev=343221=rev
Log:
Tell whether file/folder for include completions.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryukov, ioeric, jkorous, arphaman, cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343220: [AArch64][v8.5A] Test optional Armv8.5-A random
number extension (authored by olista01, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52492?vs=166909=167322#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343221: Tell whether file/folder for include completions.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52547?vs=167320=167321#toc
Repository:
rCTE
Author: ioeric
Date: Thu Sep 27 07:27:02 2018
New Revision: 343223
URL: http://llvm.org/viewvc/llvm-project?rev=343223=rev
Log:
[clangd] Make IncludeInserter less slow. NFC
Modified:
clang-tools-extra/trunk/clangd/Headers.cpp
clang-tools-extra/trunk/clangd/Headers.h
Modified:
kbobyrev added a comment.
Also, regarding error handling and `llvm::Option` vs `llvm::Expected`: I think
the case where the check most likely wouldn't be able to provide useful
diagnostics and perform enough analysis is when there are macro expansions
within inspected statement `SourceRange`.
kbobyrev added inline comments.
Comment at: clangd/index/dex/Dex.cpp:143
"There must be no :: in query.");
+ trace::Span Tracer("Dex fuzzyFind");
FuzzyMatcher Filter(Req.Query);
sammccall wrote:
> We should attach the query tree to the span here.
>
kbobyrev added inline comments.
Comment at: clangd/index/dex/Dex.cpp:171
}
+ if (Req.AnyScope)
+ScopeIterators.push_back(createBoost(createTrue(Symbols.size()), 0.2));
Probably also check `!ScopeIterators.empty()`: otherwise the latency might
increase
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
kbobyrev wrote:
> JonasToth wrote:
> > kbobyrev
Author: ioeric
Date: Thu Sep 27 07:50:24 2018
New Revision: 343224
URL: http://llvm.org/viewvc/llvm-project?rev=343224=rev
Log:
[Tooling] Get rid of uses of llvm::Twine::str which is slow. NFC
Modified:
cfe/trunk/lib/Tooling/Inclusions/HeaderIncludes.cpp
Modified:
gtbercea updated this revision to Diff 167326.
gtbercea added a comment.
Fix type of chunk size.
Repository:
rC Clang
https://reviews.llvm.org/D52434
Files:
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D52434
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hahnfeld added a comment.
Should we also change the default `schedule` to `static, 1`? I know that's not
really needed for `teams distribute parallel for` (because the new default
`dist_schedule` only leaves one iteration per thread), but this doesn't happen
for `target parallel for`.
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
lebedev.ri wrote:
> kbobyrev wrote:
> > JonasToth
filcab created this revision.
filcab added reviewers: rjmccall, kcc, rsmith.
Repository:
rC Clang
https://reviews.llvm.org/D52615
Files:
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
gtbercea added a comment.
In https://reviews.llvm.org/D52434#1248012, @Hahnfeld wrote:
> Should we also change the default `schedule` to `static, 1`? I know that's
> not really needed for `teams distribute parallel for` (because the new
> default `dist_schedule` only leaves one iteration per
Hahnfeld accepted this revision.
Hahnfeld added a comment.
In https://reviews.llvm.org/D52434#1248032, @gtbercea wrote:
> That is the intention. I just took out that part from here to not confuse
> things since I wanted to have that as a separate patch. :)
Ok, perfect. I was probably confused
filcab added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:305
enum ImplicitConversionCheckKind : unsigned char {
-ICCK_IntegerTruncation = 0,
+ICCK_IntegerTruncation = 0, // Legacy, no longer used.
+ICCK_UnsignedIntegerTruncation = 1,
kadircet updated this revision to Diff 167332.
kadircet added a comment.
- Minimum CompletionItemKind is Text.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
clangd/Protocol.h
Index:
kbobyrev added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
aaron.ballman wrote:
> lebedev.ri wrote:
> > kbobyrev
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
stable_partition on objects is slow (due to copies). Do it on pointers
instead.
Repository:
rCTE Clang Tools Extra
donat.nagy added a comment.
Yes, moving StdCLibraryFunctionsChecker to an always-loaded package is probably
a better solution than adding this one particular dependency link. (Evaluating
these functions may be useful for other checkers as well, although it does not
seem to change the results
JonasToth added a comment.
There are testcases with macro around line 100 in the default tests. I
am not sure yet if `#define I_DECLS int i1, i2, i3;` should be
diagnosed, but the other cases should.
Am 27.09.2018 um 16:28 schrieb Kirill Bobyrev via Phabricator:
> kbobyrev added a comment.
>
>
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Thanks Peter. LGTM!
https://reviews.llvm.org/D52595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
kbobyrev wrote:
> aaron.ballman wrote:
> > lebedev.ri
ioeric updated this revision to Diff 167336.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52611
Files:
clangd/index/MemIndex.cpp
clangd/index/Merge.cpp
clangd/index/dex/Dex.cpp
Index:
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
JonasToth wrote:
> kbobyrev wrote:
> >
wzssyqa updated this revision to Diff 167340.
https://reviews.llvm.org/D51464
Files:
lib/Basic/Targets/Mips.h
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Linux.cpp
test/CodeGen/atomics-inlining.c
test/CodeGen/mips-zero-sized-struct.c
wzssyqa added a subscriber: rsmith.
wzssyqa added a comment.
I updated N32 patch for clang.
Simon Atanasyan via Phabricator
于2018年9月27日周四 下午8:23写道：
> atanasyan added a comment.
>
> Could you please update the patch against the current trunk?
>
> Repository:
>
> rC Clang
>
>
Author: hahnfeld
Date: Thu Sep 27 09:12:32 2018
New Revision: 343230
URL: http://llvm.org/viewvc/llvm-project?rev=343230=rev
Log:
[OpenMP] Improve search for libomptarget-nvptx
When looking for the bclib Clang considered the default library
path first while it preferred directories in
I updated N32 patch for clang.
Simon Atanasyan via Phabricator
于2018年9月27日周四 下午8:23写道：
>
> atanasyan added a comment.
>
> Could you please update the patch against the current trunk?
>
>
> Repository:
> rC Clang
>
> https://reviews.llvm.org/D50850
>
>
>
--
YunQiang Su
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343230: [OpenMP] Improve search for libomptarget-nvptx
(authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51686
Files:
include/clang/Driver/Options.td
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdLSPServer.cpp:108
+ if (Params.capabilities.textDocument.completion.completionItemKind)
+for (CompletionItemKind Kind :
Hahnfeld created this revision.
Hahnfeld added reviewers: atanasyan, rnk.
Herald added subscribers: cfe-commits, jrtc27, arichardson, sdardis.
`ld{{.*}}"` seems to match the complete line for me which is failing
the test. Only allow an optional `.exe` for Windows systems as most
other tests do.
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:325
+CodeCompletion::IncludeCandidates
+moveNonInsertingIncludesToFront(CodeCompletion::IncludeCandidates Includes) {
+ if (Includes.size() <= 1)
this seems a bit overly complicated. It does
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:1251
+ // from any scope.
+ std::pair, bool> QueryScopes;
// Include-insertion and proximity scoring rely on the include
smeenai added a comment.
In https://reviews.llvm.org/D52581#1247409, @theraven wrote:
> > I would have done the same for the GNUstep RTTI here, except I don't
> > actually
> > see the code for that anywhere, and no tests seem to break either, so I
> > believe it's not upstreamed yet.
>
> I'm
sammccall added inline comments.
Comment at: clangd/FS.cpp:29
+PreambleFileStatusCache::lookup(llvm::StringRef File) const {
+ auto I = StatCache.find(File);
+ if (I != StatCache.end())
ioeric wrote:
> sammccall wrote:
> > lock
> After a second thought, I'm
usaxena95 created this revision.
Herald added subscribers: cfe-commits, mgrang.
Some files are only Statted by Clang and not read. Clang mostly uses
them for checking the existence of some files and in rare cases uses the
value of the Status to proceed further (for example while loading
module
kadircet updated this revision to Diff 167346.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
Author: kadircet
Date: Thu Sep 27 10:13:07 2018
New Revision: 343237
URL: http://llvm.org/viewvc/llvm-project?rev=343237=rev
Log:
Introduce completionItemKind capability support.
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: ilya-biryukov, ioeric, jkorous, arphaman, cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343237: Introduce completionItemKind capability support.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52616?vs=167346=167347#toc
Repository:
rCTE Clang
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52619
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: george.karpenkov
Date: Thu Sep 27 10:26:41 2018
New Revision: 343239
URL: http://llvm.org/viewvc/llvm-project?rev=343239=rev
Log:
[analyzer] Highlight nodes which have error reports in them in red in exploded
graph
Differential Revision: https://reviews.llvm.org/D52584
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343239: [analyzer] Highlight nodes which have error reports
in them in red in exploded… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
Author: hahnfeld
Date: Thu Sep 27 10:27:48 2018
New Revision: 343240
URL: http://llvm.org/viewvc/llvm-project?rev=343240=rev
Log:
Fix greedy FileCheck expression in test/Driver/mips-abi.c
'ld{{.*}}"' seems to match the complete line for me which is failing
the test. Only allow an optional '.exe'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343240: Fix greedy FileCheck expression in
test/Driver/mips-abi.c (authored by Hahnfeld, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
jrmuizel added a comment.
Review ping
Repository:
rC Clang
https://reviews.llvm.org/D50318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:7
lebedev.ri added a comment.
Thank you for the review!
Comment at: test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:7
+////
+// Unsigned case.
NoQ added a comment.
As far as i understand, these driver-controlled thingies are for platform
owners to be able to say "hey we clearly don't want this checker to be turned
on on our platform". As long as there's no indication of that sort of issue, we
should instead keep it all in one place,
Author: ioeric
Date: Thu Sep 27 11:23:23 2018
New Revision: 343247
URL: http://llvm.org/viewvc/llvm-project?rev=343247=rev
Log:
[clangd] Add more tracing to index queries. NFC
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343247: [clangd] Add more tracing to index queries. NFC
(authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52611
Files:
JonasToth marked 11 inline comments as done.
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:68
+if (Start.isInvalid() || Start.isMacroID())
+ return SourceLocation();
+ }
kbobyrev wrote:
> Also, I don't think
ioeric updated this revision to Diff 167356.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52364
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/index/Index.h
Author: ioeric
Date: Thu Sep 27 11:46:00 2018
New Revision: 343248
URL: http://llvm.org/viewvc/llvm-project?rev=343248=rev
Log:
[clangd] Initial supoprt for cross-namespace global code completion.
Summary:
When no scope qualifier is specified, allow completing index symbols
from any scope and
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343248: [clangd] Initial supoprt for cross-namespace
global code completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52364?vs=167356=167357#toc
xbolva00 added a comment.
Herald added a subscriber: sanjoy.
Coming from https://reviews.llvm.org/D50039. This patch was accepted but never
merged?
https://reviews.llvm.org/D30806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
smeenai added a subscriber: rnk.
smeenai added a comment.
Adding @rnk, since this'll touch MS ABI mangling. For context, we want `struct
X` to have the same mangling as `@interface X` normally, but we want to be able
to distinguish them for the purpose of exception handling. See this diff's
xbolva00 accepted this revision.
xbolva00 added a comment.
This revision is now accepted and ready to land.
ok, thanks
Repository:
rC Clang
https://reviews.llvm.org/D52574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric updated this revision to Diff 167361.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- simplify the code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52617
Files:
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
Author: lebedevri
Date: Thu Sep 27 12:07:48 2018
New Revision: 343251
URL: http://llvm.org/viewvc/llvm-project?rev=343251=rev
Log:
[clang][ubsan][NFC] Slight test cleanup in preparation for D50901
Reviewers: vsk, vitalybuka, filcab
Reviewed By: vitalybuka
Subscribers: cfe-commits
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343251: [clang][ubsan][NFC] Slight test cleanup in
preparation for D50901 (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ioeric updated this revision to Diff 167370.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address review comments
- address review comments
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52419
Files:
clangd/CMakeLists.txt
ioeric added inline comments.
Comment at: clangd/FS.cpp:29
+PreambleFileStatusCache::lookup(llvm::StringRef File) const {
+ auto I = StatCache.find(File);
+ if (I != StatCache.end())
sammccall wrote:
> ioeric wrote:
> > sammccall wrote:
> > > lock
> > After a
Author: gbercea
Date: Thu Sep 27 12:22:56 2018
New Revision: 343253
URL: http://llvm.org/viewvc/llvm-project?rev=343253=rev
Log:
[OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode
achieve coalescing
Summary: For the OpenMP NVPTX toolchain choose a default distribute
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343253: [OpenMP] Make default distribute schedule for NVPTX
target regions in SPMD mode… (authored by gbercea, committed by ).
Changed prior to commit:
smeenai added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if
JonasToth updated this revision to Diff 167377.
JonasToth added a comment.
- address review comments, most nits solved
- fix typedefs and function pointers with comments as distraction
- make memberpointer detection more accurate
- move functioning member pointer test
- clean debug output
- clean
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343
+ auto Diag =
+ diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables")
+ << static_cast(
aaron.ballman wrote:
> JonasToth wrote:
> > kbobyrev
JonasToth updated this revision to Diff 167381.
JonasToth marked 9 inline comments as done.
JonasToth added a comment.
- simplification on FIXME:/TODO:
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: clang, OpenMP.
Herald added a subscriber: guansong.
Added new `unified_shared_memory` clause to existing OMP5.0 `requires`
1 - 100 of 165 matches
Mail list logo
