r347035 - [clang] - Simplify tools::SplitDebugName.

Author: grimar Date: Thu Nov 15 23:59:24 2018 New Revision: 347035 URL: http://llvm.org/viewvc/llvm-project?rev=347035=rev Log: [clang] - Simplify tools::SplitDebugName. This should be NFC change. SplitDebugName recently started to accept the `Output` that can be used to simplify the logic a

[PATCH] D54576: [clang] - Simplify tools::SplitDebugName.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347035: [clang] - Simplify tools::SplitDebugName. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54269: Introduce shard storage to auto-index.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347038: Introduce shard storage to auto-index. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D54269?vs=174215=174339#toc Repository: rCTE Clang Tools

[clang-tools-extra] r347038 - Introduce shard storage to auto-index.

Author: kadircet Date: Fri Nov 16 01:03:56 2018 New Revision: 347038 URL: http://llvm.org/viewvc/llvm-project?rev=347038=rev Log: Introduce shard storage to auto-index. Reviewers: sammccall, ioeric Reviewed By: sammccall Subscribers: llvm-commits, mgorny, Eugene.Zelenko, ilya-biryukov,

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Commented on that particular idiom, there's two instances where it's used, aside from variable naming issues (`pos` should be `Pos`) it's very non idiomatic as far as rest of LLVM code goes, don't pass string literals around as `const char*`, prefer `StringRef`

[clang-tools-extra] r347039 - [clangd] Fix a compiler warning and test crashes caused in rL347038.

Author: hokein Date: Fri Nov 16 01:41:14 2018 New Revision: 347039 URL: http://llvm.org/viewvc/llvm-project?rev=347039=rev Log: [clangd] Fix a compiler warning and test crashes caused in rL347038. Modified: clang-tools-extra/trunk/clangd/index/Background.cpp

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. Thanks for the fix. I made a quick check of the mentioned patch, and it looks like it does solve the issue. However, besides the previous crash, which remains unfixed as of 7.0.1rc2, there is another instruction selection failure crash that may be caused by the change.

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. The other lost comment was regarding the functions where you're using `strcpy` instead of idiomatic LLVM and also creating unnecessary temporary `std::string` instances on the stack. Repository: rC Clang https://reviews.llvm.org/D54379

[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one more comment. Please address other reviewers' comments though. Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:153 + // required so we provide

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added inline comments. Comment at: lib/Driver/Driver.cpp:418 + replaceString(T, "-pc-gnu", "-pc-hurd-gnu"); + TargetTriple = T; + kristina wrote: > Reference to a local variable? Hm, actually this is fine I guess, just avoid `strlen` and pass literals

[PATCH] D54604: Automatic variable initialization

lebedev.ri added a comment. There is also https://reviews.llvm.org/D54473 `[sanitizers] Initial implementation for -fsanitize=init-locals`. Repository: rC Clang https://reviews.llvm.org/D54604 ___ cfe-commits mailing list

[PATCH] D54091: [RISCV] Add inline asm constraints I, J & K for RISC-V

asb requested changes to this revision. asb added a comment. This revision now requires changes to proceed. Thanks for the patch Lewis. Could I please request the following changes: - It would be handy to link to https://gcc.gnu.org/onlinedocs/gccint/Machine-Constraints.html in the patch

[clang-tools-extra] r347036 - [clangd] Initial clang-tidy diagnostics support.

Author: sammccall Date: Fri Nov 16 00:32:23 2018 New Revision: 347036 URL: http://llvm.org/viewvc/llvm-project?rev=347036=rev Log: [clangd] Initial clang-tidy diagnostics support. Summary: This runs checks over a restricted subset of the TU: - preprocessor callbacks just receive the truncated

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347036: [clangd] Initial clang-tidy diagnostics support. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54204 Files:

[PATCH] D54553: [clangd] Fix crash hovering on non-decltype trailing return

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added inline comments. Comment at: lib/Driver/Driver.cpp:418 + replaceString(T, "-pc-gnu", "-pc-hurd-gnu"); + TargetTriple = T; + Reference to a local variable? Repository: rC Clang https://reviews.llvm.org/D54379

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:44-45 +def warn_drv_avr_family_linking_stdlibs_not_implemented: Warning< + "support for linking stdlibs for microcontroller '%0' is not implemented, " + "please file an AVR backend

[PATCH] D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one

jkorous added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D49736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov created this revision. ilya-biryukov added reviewers: JDevlieghere, arphaman. Herald added a reviewer: EricWF. Herald added subscribers: kadircet, christof, ioeric. The intention is to make the tools replaying compilations from 'compile_commands.json' (clang-tidy, clangd, etc.)

[PATCH] D54379: Add Hurd toolchain support to Clang

kristina added a comment. Also, this needs unit tests and FileCheck tests. Repository: rC Clang https://reviews.llvm.org/D54379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54622: [clangd] Truncate SymbolID to 8 bytes.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. This is our goal. It has a non-zero rick, but so far we haven't see any collision (externally and internally). Repository: rCTE Clang Tools

[clang-tools-extra] r347044 - [clangd] Truncate SymbolID to 8 bytes.

Author: hokein Date: Fri Nov 16 02:58:40 2018 New Revision: 347044 URL: http://llvm.org/viewvc/llvm-project?rev=347044=rev Log: [clangd] Truncate SymbolID to 8 bytes. Summary: This is our goal. It has a non-zero rick, but so far we haven't see any collision (externally and internally).

[PATCH] D54622: [clangd] Truncate SymbolID to 8 bytes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347044: [clangd] Truncate SymbolID to 8 bytes. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54622 Files:

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay updated this revision to Diff 174359. dylanmckay marked 6 inline comments as done. dylanmckay added a comment. - Remove link to BugZilla in diagnostic - Use StringRef for a static string array rather than std::string - Elide braces - Dereference an Optional in-place rather than

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd added a comment. @Anastasia @yaxunl Hi, I am working on generalizing this patch and several questions have raised during this, so I want to discuss them with you: 1. Should #pragma OPENCL EXTENSION ext_name : begin enables the extension as well? For now I see it's not, as an example:

[PATCH] D54047: Check TUScope is valid before use

jkorous added a comment. Could you please add a test? I'd suggest minimizing the testcase you linked and placing it to `clang/test`. Repository: rC Clang https://reviews.llvm.org/D54047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

koalo created this revision. koalo added reviewers: djasper, rsmith. Herald added a subscriber: cfe-commits. Before, clang-format has tried to put enums on a single line whenever possible (unless in styles where the opening brace was put on a seperate line anyway). AllowShortEnumsOnASingleLine

[PATCH] D54091: [RISCV] Add inline asm constraints I, J & K for RISC-V

lewis-revill updated this revision to Diff 174360. lewis-revill edited the summary of this revision. lewis-revill added a comment. Updated to reflect desired changes (and fix an incorrect boundary). I didn't add r & m to riscv-inline-asm.c as I wasn't clear what exactly was desired.

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay updated this revision to Diff 174362. dylanmckay marked an inline comment as done. dylanmckay added a comment. Run clang-format on the whole patch Repository: rC Clang https://reviews.llvm.org/D54334 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:44-45 +def warn_drv_avr_family_linking_stdlibs_not_implemented: Warning< + "support for linking stdlibs for microcontroller '%0' is not implemented, " + "please file an AVR backend bug

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

yaxunl added a comment. In https://reviews.llvm.org/D51341#1301047, @sidorovd wrote: > @Anastasia @yaxunl > Hi, I am working on generalizing this patch and several questions have > raised during this, so I want to discuss them with you: > > 1. Should #pragma OPENCL EXTENSION ext_name : begin

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

aaron.ballman added a comment. I'm not certain if it will be possible to devise test cases for the two diagnostics I pointed out or not, but otherwise, this LGTM as far as the implementation goes. I don't know enough about AVR to sign off on whether the patch logic is correct or not.

[PATCH] D53866: [Preamble] Fix preamble for circular #includes

nik added a comment. I still don't have feedback for a real world case except "unintentional #include". Unfortunately, in real world cases the cyclic include might be not obvious at all. @ilya: As far as I understand you prefer to make the preamble generation rather fail as long as we don't

r347063 - [AST][NFC] Pack CXXNullPtrLiteralExpr

Author: brunoricci Date: Fri Nov 16 08:56:49 2018 New Revision: 347063 URL: http://llvm.org/viewvc/llvm-project?rev=347063=rev Log: [AST][NFC] Pack CXXNullPtrLiteralExpr Use the newly available space in the bit-fields of Stmt. This saves one pointer per CXXNullPtrLiteralExpr. Modified:

r347064 - [AST][NFC] Pack CXXThisExpr

Author: brunoricci Date: Fri Nov 16 09:38:35 2018 New Revision: 347064 URL: http://llvm.org/viewvc/llvm-project?rev=347064=rev Log: [AST][NFC] Pack CXXThisExpr Use the newly available space in the bit-fields of Stmt. This saves 8 bytes per CXXThisExpr. Modified:

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-narrowing-conversions-long-is-32bits.cpp:4-10 + int i;// i.e. int32_t + long l; // i.e. int32_t + long long ll; // i.e. int64_t + + unsigned int ui;// i.e. uint32_t +

r347070 - [PowerPC] Make no-PIC default to match GCC - CLANG

Author: stefanp Date: Fri Nov 16 10:37:01 2018 New Revision: 347070 URL: http://llvm.org/viewvc/llvm-project?rev=347070=rev Log: [PowerPC] Make no-PIC default to match GCC - CLANG Make the default -fno-PIC on Power PC. Differential Revision: https://reviews.llvm.org/D53384 Modified:

[PATCH] D54638: [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, add `NFC` to the title. Repository: rC Clang https://reviews.llvm.org/D54638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54547: PTH-- Remove feature entirely-

voskresensky.vladimir added a comment. I have some experience with PTH implementation, because had to fix it for Java-port of Clang (https://github.com/java-port/clank). It was sometime ago, but making it completely workable was not hard. As I remember the key fix was just to have PTH be

r347059 - [OpenCL] Enable address spaces for references in C++

Author: stulova Date: Fri Nov 16 08:22:56 2018 New Revision: 347059 URL: http://llvm.org/viewvc/llvm-project?rev=347059=rev Log: [OpenCL] Enable address spaces for references in C++ Added references to the addr spaces deduction and enabled CL2.0 features (program scope variables and storage

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL347059: [OpenCL] Enable address spaces for references in C++ (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. I don't think we want to move the logic to add a libc++ path to the driver. `-cc1` with `-resource-dir` and `-stdlib=libc++` should still work as before. In this case the previous patch is better, except it should not set `InstalledDir` except when needed (e.g. for

[PATCH] D54638: OpenMP: remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp

saghir created this revision. saghir added reviewers: cfe-commits, ABataev, kkwli0. saghir added a project: OpenMP. Herald added a subscriber: guansong. In the below statement in ParseOpenMP.cpp: bool IsComma = 1942 (Kind != OMPC_reduction && Kind != OMPC_task_reduction && 1943 Kind !=

[PATCH] D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one

arphaman added a comment. Thanks for working on this, some minor comments: Comment at: Basic/DiagnosticIDs.cpp:612 // Two matches with the same distance, don't prefer one over the other. - Best = ""; + NearestOption = ""; } else if (Distance <

[PATCH] D54547: PTH-- Remove feature entirely-

arphaman added a comment. Would it be better to deprecate the use of PTH right now for the current release, so that the users will be aware that we will remove PTH support in LLVM 9 once they upgrade to LLVM 8? Then we can remove it right after LLVM 8 branch is created.

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet updated this revision to Diff 174374. gchatelet marked 13 inline comments as done. gchatelet added a comment. - Addressed comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53488 Files: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-narrowing-conversions.cpp:79-81 + // TODO: Provide an automatic fix if the number is exactly representable in the destination type. + f += 2.0; + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning:

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3385 + if (IsCommonSaturated) +CommonFixedSema.setSaturated(false); + ebevhan wrote: > Can EmitFixedPointConversion not determine this on its own? What I meant here was that

[PATCH] D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror

jkorous added a reviewer: jkorous. jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch! Repository: rC Clang https://reviews.llvm.org/D53807 ___ cfe-commits mailing

[PATCH] D54547: PTH-- Remove feature entirely-

erichkeane added a comment. In https://reviews.llvm.org/D54547#1301253, @arphaman wrote: > Would it be better to deprecate the use of PTH right now for the current > release, so that the users will be aware that we will remove PTH support in > LLVM 9 once they upgrade to LLVM 8? Then we can

r347072 - [codeview] Expose -gcodeview-ghash for global type hashing

Author: rnk Date: Fri Nov 16 10:47:41 2018 New Revision: 347072 URL: http://llvm.org/viewvc/llvm-project?rev=347072=rev Log: [codeview] Expose -gcodeview-ghash for global type hashing Summary: Experience has shown that the functionality is useful. It makes linking optimized clang with debug info

[clang-tools-extra] r347053 - [clang-tidy] Expanded a test NFC

Author: alexfh Date: Fri Nov 16 06:57:51 2018 New Revision: 347053 URL: http://llvm.org/viewvc/llvm-project?rev=347053=rev Log: [clang-tidy] Expanded a test NFC Expanded the readability-inconsistent-declaration-parameter-name-macros.cpp to check notes and added a test with pasted tokens.

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

anhtuyen updated this revision to Diff 174394. anhtuyen added a comment. 1. Correct the typo on line 3707 clang/lib/Sema/SemaOpenMP.cpp 2. Update the testcase: teams_distribute_simd_loop_messages.cpp https://reviews.llvm.org/D54441 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D54547: PTH-- Remove feature entirely-

erichkeane added a comment. In https://reviews.llvm.org/D54547#1301351, @voskresensky.vladimir wrote: > I have some experience with PTH implementation, because had to fix it for > Java-port of Clang (https://github.com/java-port/clank). > > It was sometime ago, but making it completely workable

Re: [llvm-dev] mips builders on LLVM buildbot?

Thank you! I will remove them for now. Thanks Galina On Thu, Nov 15, 2018 at 9:21 PM Simon Atanasyan wrote: > Hi Galina, > > a) "llvm-mips-linux" buildbot is active now. There are some failed > tests but I'm working to make the buildbot "green". > > b) For now "clang-cmake-mips" and

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

mgorny created this revision. mgorny added reviewers: krytarowski, dberris, labath. Herald added subscribers: Sanitizers, llvm-commits. Copy the fix for determining the correct terminfo library from LLVM -- use distinct variables for check_library_exists() calls. Otherwise, the first check (for

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

krytarowski added a comment. I have got a local patch in pkgsrc-wip/llvm-netbsd: $NetBSD$ --- cmake/config-ix.cmake.orig2017-12-08 18:50:04.615602612 + +++ cmake/config-ix.cmake @@ -153,7 +153,7 @@ if(NOT LLVM_USE_SANITIZER MATCHES "Memor endif()

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

krytarowski added a comment. As I understand it -ltinfo vs -lterminfo is mixing native curses(3) and external ncurses(3) from pkgsrc, while we prefer to use entirely our native version for all LLVM projects. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D54641

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

krytarowski added a comment. Context: > Do not return -ltinfo from llvm-config --system-libs --link-static > > under NetBSD. Bump PKGREVISION > > Rust language 1.20.0 uses these options and Rust build system uses it > as '-l tinfo' and our wrapper does not handle this.

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

rjmccall added inline comments. Comment at: docs/ClangCommandLineReference.rst:799 +command-line. Command-lines in the section are surrounded and separated by null +bytes. Spaces and backslashes in the command-line are escaped with backslashes. +(ELF Only) How

[PATCH] D54641: [compiler-rt] [cmake] Fix detecting terminfo library

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D54641#1301620, @mgorny wrote: > Well, sure but I think changing the order should be done separately from > this. I'm fixing a bug resulting from people

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this check is in good shape for the initial commit. Additional functionality can be added incrementally. Comment at:

r347075 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

Author: stefanp Date: Fri Nov 16 11:21:33 2018 New Revision: 347075 URL: http://llvm.org/viewvc/llvm-project?rev=347075=rev Log: Revert "[PowerPC] Make no-PIC default to match GCC - CLANG" This reverts commit r347070 Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder updated this revision to Diff 174429. scott.linder added a comment. Update documentation for new option and error in the driver when generating for unsupported object-file format. https://reviews.llvm.org/D54489 Files: docs/ClangCommandLineReference.rst

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

shafik added subscribers: rsmith, shafik. shafik added a comment. Herald added a reviewer: shafik. Herald added a subscriber: gamesh411. I think these changes make sense at a high level but I am not sure about the refactoring strategy. I am especially concerned we may end up in place where all

[PATCH] D54547: PTH-- Remove feature entirely-

riccibruno added a comment. > I thought clang-d service is using it to speed up indexing. I believe that clangd is using PCH and not PTH. (by the highly sophisticated method of grepping for pth and pch inside clangd/) https://reviews.llvm.org/D54547

[PATCH] D54634: [OpenCL] Fix address space deduction in template args

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Makes sense. https://reviews.llvm.org/D54634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r347096 - [OPENMP]Fix PR39694: do not capture `this` in non-`this` region.

Author: abataev Date: Fri Nov 16 13:13:33 2018 New Revision: 347096 URL: http://llvm.org/viewvc/llvm-project?rev=347096=rev Log: [OPENMP]Fix PR39694: do not capture `this` in non-`this` region. If lambda is used inside of the OpenMP region and captures `this`, we should recapture it in the

[PATCH] D49736: [Basic] Emit warning flag suggestion only in case there's existing flag *similar* to the unknown one

vsapsai added a comment. Have you considered the same approach as typo correction? I.e. for the max allowed edit distance use percentage of the input size. For example, something similar to `TypoCorrectionConsumer::addName`

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos marked an inline comment as done. vmiklos added inline comments. Comment at: test/clang-tidy/readability-redundant-preprocessor.cpp:53 +// CHECK-NOTES: [[@LINE+1]]:2: warning: nested redundant #if; consider removing it [readability-redundant-preprocessor] +#if FOO == 3

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos added a comment. In https://reviews.llvm.org/D54349#1301663, @aaron.ballman wrote: > I think this check is in good shape for the initial commit. Additional > functionality can be added incrementally. OK, thanks. I'll lcommit this once https://reviews.llvm.org/D54450 is committed.

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

smilewithani added a comment. In https://reviews.llvm.org/D28462#1257259, @mewmew wrote: > Any update on this? There are quite a few people who got excited about this > change and would like to start using it with clang-format. Same here! Repository: rL LLVM

[PATCH] D53850: Declares __cpu_model as dso local

hhb added a comment. Anyone can have a look at this change? Repository: rC Clang https://reviews.llvm.org/D53850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos marked 2 inline comments as done. vmiklos added inline comments. Comment at: clang-tidy/readability/RedundantPreprocessorCheck.cpp:37 +CheckMacroRedundancy(Loc, Condition, IfStack, + "nested redundant if; consider removing it", +

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:73 + case DurationScale::Hours: +if (Multiplier <= 1.0 / 60.0) + return

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

andrew.w.kaylor added a comment. In https://reviews.llvm.org/D53157#1291978, @cameron.mcinally wrote: > In https://reviews.llvm.org/D53157#1291964, @kpn wrote: > > > I don't expect anyone would need to switch between constrained and regular > > floating point at an instruction level of

[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

Quuxplusone updated this revision to Diff 174449. Quuxplusone added a comment. Added a test case (partly copied from `test/SemaCXX/cxx14-compat.cpp`). On the last warning in the file, I omitted the sketchy part of the warning, which on Godbolt looks like this: https://godbolt.org/z/CB4z99

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. Thanks @scott.linder, actually "all or nothing" is what I wanted here. We really want to get the source for these remapped files. Repository: rC Clang https://reviews.llvm.org/D53329 ___ cfe-commits mailing list

[PATCH] D54547: PTH-- Remove feature entirely-

voskresensky.vladimir added a comment. In https://reviews.llvm.org/D54547#1301359, @erichkeane wrote: > > I thought clang-d service is using it to speed up indexing. > > Presumably, I could also just make PTH use another bit or two for the TokenID > and it would work fine. However, when I

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ldionne added a comment. In https://reviews.llvm.org/D54630#1301283, @arphaman wrote: > I don't think we want to move the logic to add a libc++ path to the driver. My opinion is not very educated because I don't have a lot of experience/knowledge of Clang, but from my perspective it does make

r347081 - [OPENMP][NVPTX]Emit correct reduction code for teams/parallel

Author: abataev Date: Fri Nov 16 11:38:21 2018 New Revision: 347081 URL: http://llvm.org/viewvc/llvm-project?rev=347081=rev Log: [OPENMP][NVPTX]Emit correct reduction code for teams/parallel reductions. Fixed previously committed code for the reduction support in teams/parallel constructs taking

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

hwright marked 5 inline comments as done. hwright added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:73 + case DurationScale::Hours: +if (Multiplier <= 1.0 / 60.0) + return std::make_tuple(DurationScale::Minutes, Multiplier * 60.0);

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

hwright added a comment. I think this is ready to go, please advise on next steps. https://reviews.llvm.org/D54246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

vmiklos updated this revision to Diff 174439. https://reviews.llvm.org/D54349 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantPreprocessorCheck.cpp clang-tidy/readability/RedundantPreprocessorCheck.h

[PATCH] D54349: [clang-tidy] new check 'readability-redundant-preprocessor'

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-redundant-preprocessor.cpp:53 +// CHECK-NOTES: [[@LINE+1]]:2: warning: nested redundant #if; consider removing it [readability-redundant-preprocessor] +#if FOO == 3 + 1 +// CHECK-NOTES: [[@LINE-3]]:2:

[PATCH] D54047: Check TUScope is valid before use

trixirt added a comment. Since the crash happens with the iwyu tool, a bit ago i added the testcase at the iwyu project here. https://github.com/include-what-you-use/include-what-you-use/pull/601 I don't know if it makes sense to run iwyu from clang/test. Repository: rC Clang

[PATCH] D54634: [OpenCL] Fix address space deduction in template args

Anastasia created this revision. Anastasia added reviewers: rjmccall, yaxunl. Don't deduce address spaces for non-pointer-like types in template args. This fixes bug reported in https://bugs.llvm.org/show_bug.cgi?id=38603 and enables most of template functionality to work correctly. There is

[PATCH] D54475: [clangd] Allow observation of changes to global CDBs.

ilya-biryukov requested changes to this revision. ilya-biryukov added inline comments. This revision now requires changes to proceed. Comment at: clangd/Function.h:108 +Subscription =(Subscription &) { + std::tie(Parent, ListenerID) = std::tie(Other.Parent,

[PATCH] D53329: Generate DIFile with main program if source is not available

scott.linder added a comment. In https://reviews.llvm.org/D53329#1300435, @dblaikie wrote: > Thanks! > > So I can see where/how this fails now - the LLVM backend seems to require > that if any file has embedded source, they all do. Would you be able to/would > you mind adding a debug info

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

Szelethus updated this revision to Diff 174495. Szelethus retitled this revision from "[analyzer] Emit a warning for unknown -analyzer-config options" to "[analyzer] Emit an error for invalid -analyzer-config inputs". Szelethus set the repository for this revision to rC Clang. Szelethus added a

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone added inline comments. Comment at: include/clang/AST/DeclCXX.h:482 +/// and a defaulted destructor. +unsigned IsNaturallyTriviallyRelocatable : 1; + erichkeane wrote: > Quuxplusone wrote: > > erichkeane wrote: > > > Typically we'd have this

[PATCH] D54047: Check TUScope is valid before use

kimgr added subscribers: zturner, kimgr. kimgr added a comment. Here's some related suggestions/questions for context: - Earlier patch from @zturner with a minimal repro case: https://reviews.llvm.org/D31697. I don't think this is reproducible with Clang proper. - Open question for alternative

[PATCH] D51531: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

Szelethus added a comment. Herald added subscribers: gamesh411, baloghadamsoftware. In https://reviews.llvm.org/D51531#1296256, @NoQ wrote: > In https://reviews.llvm.org/D51531#1286110, @Szelethus wrote: > > > Oh, and the reason why I think it would add a lot of complication: since > > only

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

MTC added a comment. > The "moved-from" terminology we adopt here still feels a bit weird to me, but > i don't have a better suggestion, so i just removed the single-quotes so that > to at least feel proud about what we have. I am personally fine with this terminology, this checker corresponds

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

hfinkel added a comment. In https://reviews.llvm.org/D53157#1291977, @andrew.w.kaylor wrote: > Craig Topper also raised some concerns with me (in person, his desk is right > by mine) about the potential effect this might have on code size. He tells me > that IRBuilder calls are intended to

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

hfinkel added a comment. > Just because FENV_ACCESS can be toggled on that granularity doesn't mean we > have to represent it that way. We've previously agreed (I think) that if > FENV_ACCESS is enabled anywhere in a function we will want to use the > constrained intrinsics for all FP

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

hfinkel added a comment. In https://reviews.llvm.org/D53157#1301991, @hfinkel wrote: > In https://reviews.llvm.org/D53157#1291977, @andrew.w.kaylor wrote: > > > Craig Topper also raised some concerns with me (in person, his desk is > > right by mine) about the potential effect this might have

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

hfinkel added a comment. In https://reviews.llvm.org/D53157#1301782, @cameron.mcinally wrote: > Fair enough. Just for conversation's sake, I was envisioning the FE support a > little differently... > > 1. Add a command line option, say `-ffpe_safe=[true|false]`, that toggles > FPEnv-safe code

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

Quuxplusone updated this revision to Diff 174498. Quuxplusone marked 14 inline comments as done. Quuxplusone edited the summary of this revision. Quuxplusone added a comment. Use `[[clang::trivially_relocatable]]` instead of `[[trivially_relocatable]]`. Canonicalize in

r347133 - Fix unused variable warning.

Author: dlj Date: Fri Nov 16 20:48:54 2018 New Revision: 347133 URL: http://llvm.org/viewvc/llvm-project?rev=347133=rev Log: Fix unused variable warning. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp URL:

  1   2   >