[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

aaron.ballman added a comment. In D63139#1579231 , @rjmccall wrote: > I agree that tools shouldn't be forced to deal with invalid AST that looks > like valid AST. To me that means finding ways to preserve information that > (1) don't badly violate

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

rnk added inline comments. Comment at: clang/include/clang/Driver/CLCompatOptions.td:102 def _SLASH_Gy_ : CLFlag<"Gy-">, HelpText<"Don't put each function in its own section (default)">, Alias; ditto Comment at:

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion added a comment. > Do we really need to support clang-cl syntax here? Can't the user of > -fthinlto-index= use the regular clang driver? We could, of course, require using the clang driver for this feature. But I would argue that clang-cl exists to make it easy for projects that use

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ added a comment. Yeah, and i removed the one in `addrspace-operators.cl` because it has already been fixed in rC365666 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ updated this revision to Diff 209060. NoQ added reviewers: davidxl, aprantl, JDevlieghere. NoQ set the repository for this revision to rL LLVM. NoQ added a project: LLVM. NoQ added a comment. Herald added a subscriber: llvm-commits. Add three more fixes - two with `CHECK-NEXT` and one with

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ added a comment. In D64526#1579174 , @thakis wrote: > (previously: D58061 ) Aha, that explains why most of these are new :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/

[PATCH] D64506: clang-cl: Remove -O0 option

rnk added a comment. Does `clang-cl -O0` without a `/` still work, though? It's used: $ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/ ../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1579154 , @NoQ wrote: > Ugh, i forced a lot of boilerplate on you. Hope it was worth it >.< > > Thank you!~ No problems, thanks for the review! Comment at:

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

rjmccall added a comment. I agree that tools shouldn't be forced to deal with invalid AST that looks like valid AST. To me that means finding ways to preserve information that (1) don't badly violate invariants and (2) are easily discoverable as invalid. For `case`, which has external

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 209053. DiegoAstiazaran added a comment. Use relative paths for references/links within files. Don't fill namespaces of parentInfo in serialization and path is only generated when the parent is the global namespace. Add new fields (Path in Reference

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits mailing list

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

thakis added a comment. (previously: D58061 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

Bigcheese accepted this revision. Bigcheese added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:270 +return false; + if (Prev == '8' && (Cur - 1 != Start) && *(Cur - 2) == 'u') +return false; arphaman wrote: >

r365695 - My first test commit.

Author: saar.raz Date: Wed Jul 10 13:01:44 2019 New Revision: 365695 URL: http://llvm.org/viewvc/llvm-project?rev=365695=rev Log: My first test commit. Modified: cfe/trunk/test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p1.cpp Modified:

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:270 +return false; + if (Prev == '8' && (Cur - 1 != Start) && *(Cur - 2) == 'u') +return false; Bigcheese wrote:

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:265-272 + // Make sure that the L, u, U, u8 prefixes don't get marked as a + // separator though. + char Prev = *(Cur - 1); + if (Prev

[PATCH] D64494: [analyzer]Add user docs rst

Szelethus added a comment. Np, please leave it in! :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64494/new/ https://reviews.llvm.org/D64494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ugh, i forced a lot of boilerplate on you. Hope it was worth it >.< Thank you!~ Comment at: test/Analysis/cfg-openmp.cpp:3 + +// CHECK:void xxx(int argc) +// CHECK:

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ updated this revision to Diff 209046. NoQ added a reviewer: Anastasia. NoQ added a comment. Found one more forgotten colon by grepping for `//CHECK ` instead of `// CHECK `. Removed the FIXME for @ABataev so that not to cause merge conflicts when he fixes the test. P.S. I didn't grep for

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31 + +// FIXME: This line doesn't work. // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x [[S_FLOAT_TY]]]*,

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

Bigcheese added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:270 +return false; + if (Prev == '8' && (Cur - 1 != Start) && *(Cur - 2) == 'u') +return false; Are we sure at this point that it's always safe to jump

r365691 - [OPENMP]Remove not used check line from the test, NFC.

Author: abataev Date: Wed Jul 10 12:30:25 2019 New Revision: 365691 URL: http://llvm.org/viewvc/llvm-project?rev=365691=rev Log: [OPENMP]Remove not used check line from the test, NFC. Modified: cfe/trunk/test/OpenMP/sections_lastprivate_codegen.cpp Modified:

[PATCH] D64494: [analyzer]Add user docs rst

martong added a comment. > In any case, LGTM, if this really is a beginning of porting the already > existing documentation to sphinx. This is really the beginning of porting the existing docs to sphinx which is supposedly going to be done by @dkrupp. And I am planning to add new user manual

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev updated this revision to Diff 209042. ABataev added a comment. Improved code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64356/new/ https://reviews.llvm.org/D64356 Files: include/clang/AST/OpenMPClause.h include/clang/AST/StmtOpenMP.h

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: kristof.beyls, javed.absar. clang currently warns when passing flags for the assembler (e.g. -Wa,-mbig-obj) to an invocation that doesn't run the assembler (e.g. -E). At first sight, that makes sense -- the

[PATCH] D63857: [clang-doc] Add a structured HTML generator

This revision was automatically updated to reflect the committed changes. Closed by commit rL365687: [clang-doc] Add a structured HTML generator (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365687 - [clang-doc] Add a structured HTML generator

Author: juliehockett Date: Wed Jul 10 12:03:25 2019 New Revision: 365687 URL: http://llvm.org/viewvc/llvm-project?rev=365687=rev Log: [clang-doc] Add a structured HTML generator Implements an HTML generator. Nodes are used to represent each part of the HTML file. There are TagNodes that

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

ABataev added inline comments. Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31 + +// FIXME: This line doesn't work. // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x [[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, but I have a suggestion inline for another approach. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:265-272 + // Make sure that the L, u,

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ created this revision. NoQ added reviewers: kkwli0, ABataev, ahatanak, erik.pilkington. Herald added subscribers: cfe-commits, Charusso, jdoerfert, dexonsmith. Herald added a project: clang. I noticed that people occasionally forget that unlike `CHECK:`, directives `CHECK` and `CHECK :` are

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D64525: [clang-scan-deps] Dependency directives source minimizer: single quotes are not digit separators after a valid character literal prefix

arphaman created this revision. arphaman added a reviewer: Bigcheese. Herald added subscribers: tschuett, dexonsmith, jkorous. Herald added a project: clang. The single quote character can act as a c++ digit separator. However, the minimizer shouldn't treat it as such when it's actually

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL365682: Update libc++ include path detection to use VFS on Linux (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365682 - Update libc++ include path detection to use VFS on Linux

Author: juliehockett Date: Wed Jul 10 11:41:35 2019 New Revision: 365682 URL: http://llvm.org/viewvc/llvm-project?rev=365682=rev Log: Update libc++ include path detection to use VFS on Linux The DetectLibcxxIncludePath function had been using llvm::sys::fs::directory_iterator, and this updates

[clang-tools-extra] r365678 - Revert "[clangd] Filter out non-governed files from broadcast"

Author: ormris Date: Wed Jul 10 11:16:35 2019 New Revision: 365678 URL: http://llvm.org/viewvc/llvm-project?rev=365678=rev Log: Revert "[clangd] Filter out non-governed files from broadcast" This reverts commit d5214dfa7b5650745eaeb102857c9e90adb16137. It's causing failures, both in our local

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:73 // This check is for not getting two entries when there are anonymous // structs. It also makes us not highlight namespace qualifiers. For // elaborated types the

[PATCH] D64494: [analyzer]Add user docs rst

Szelethus added a comment. I guess any time we modify analyzer stuff, we may invite the main analyzer developers to the patch review as well. In any case, LGTM, if this really is a beginning of porting the already existing documentation to sphinx. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); rjmccall wrote: > Anastasia wrote: > >

[PATCH] D63192: [Diagnostics] Implement -Wswitch-default

aaron.ballman added a comment. In D63192#1578867 , @xbolva00 wrote: > I see. I should really check clang-tidy codebase :) I have a hunch that this will be equally as trivially implementable in clang-tidy -- if you go that route, feel free to add me as

[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365675: Recommit [CommandLine] Remove OptionCategory and SubCommand caches from the… (authored by dhinton, committed by ). Herald added a subscriber: ilya-biryukov. Changed prior to commit:

[clang-tools-extra] r365675 - Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

Author: dhinton Date: Wed Jul 10 10:57:05 2019 New Revision: 365675 URL: http://llvm.org/viewvc/llvm-project?rev=365675=rev Log: Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." Previously reverted in 364141 due to buildbot breakage, and fixed here by

r365675 - Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

Author: dhinton Date: Wed Jul 10 10:57:05 2019 New Revision: 365675 URL: http://llvm.org/viewvc/llvm-project?rev=365675=rev Log: Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." Previously reverted in 364141 due to buildbot breakage, and fixed here by

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

fhahn added a comment. In D64128#1576391 , @rjmccall wrote: > I wouldn't favor adding something really obscure that was only useful for > clang, but I think builtins to set and clear mask bits while promising to > preserve object-reference identity

[PATCH] D64518: [LibTooling] Relax Transformer to allow rewriting macro expansions

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. Currently, Transformer rejects any changes to source locations inside macro expansions. This change relaxes that constraint to allow rewrites when the entirety of the expansion is replaced,

[PATCH] D63192: [Diagnostics] Implement -Wswitch-default

xbolva00 planned changes to this revision. xbolva00 added a comment. I see. I should really check clang-tidy codebase :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63192/new/ https://reviews.llvm.org/D63192 ___ cfe-commits mailing list

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/TargetInfo.h:274 +return LangAS::Default; + } + rjmccall wrote: > This target hook should just return the address space of the `__cxa_atexit` > argument,

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia updated this revision to Diff 209012. Anastasia added a comment. Changed API for target hook. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62413/new/ https://reviews.llvm.org/D62413 Files: lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/CodeGenModule.cpp

[PATCH] D63192: [Diagnostics] Implement -Wswitch-default

aaron.ballman added a comment. I'm wary of adding this as an on-by-default warning, despite its presence in MSVC (and despite submitting a similar patch years ago to implement the same functionality). Machine-generated code runs into this one frequently (we've been bitten by it numerous times

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

rjmccall added inline comments. Comment at: lib/Sema/SemaType.cpp:7421 + // - template specialization as addr space in template argument doesn't + // affect specialization. + (T->isDependentType() && (!T->isPointerType() && !T->isReferenceType() &&

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:585 + (A && A->getOption().matches(options::OPT_fno_omit_frame_pointer)) || + (!(A && A->getOption().matches(options::OPT_fomit_frame_pointer)) && + (Args.hasArg(options::OPT_pg) ||

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: > rjmccall wrote: > > All of this can be much

r365666 - [clang] Preserve names of addrspacecast'ed values.

Author: vzakhari Date: Wed Jul 10 10:10:05 2019 New Revision: 365666 URL: http://llvm.org/viewvc/llvm-project?rev=365666=rev Log: [clang] Preserve names of addrspacecast'ed values. Differential Revision: https://reviews.llvm.org/D63846 Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp

r365668 - [X86] Add guards to some of the x86 intrinsic tests to skip 64-bit mode only intrinsics when compiled for 32-bit mode.

Author: ctopper Date: Wed Jul 10 10:11:23 2019 New Revision: 365668 URL: http://llvm.org/viewvc/llvm-project?rev=365668=rev Log: [X86] Add guards to some of the x86 intrinsic tests to skip 64-bit mode only intrinsics when compiled for 32-bit mode. All the command lines are for 64-bit mode, but

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365666: [clang] Preserve names of addrspacecasted values. (authored by vzakhari, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365669 - [X86] Change the IR sequence for _mm_storeh_pi and _mm_storel_pi to perform the store as a <2 x float> instead of i64.

Author: ctopper Date: Wed Jul 10 10:11:29 2019 New Revision: 365669 URL: http://llvm.org/viewvc/llvm-project?rev=365669=rev Log: [X86] Change the IR sequence for _mm_storeh_pi and _mm_storel_pi to perform the store as a <2 x float> instead of i64. This is similar to what we do for loadl_pi and

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus added a comment. Please know that I'm currently out of town, so it'll be a while before I can formally accept. Its on top of my list when I get home though! :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:73 // This check is for not getting two entries when there are anonymous // structs. It also makes us not highlight namespace qualifiers. For // elaborated types the

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom updated this revision to Diff 208998. jvikstrom marked 6 inline comments as done. jvikstrom added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64492/new/ https://reviews.llvm.org/D64492 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#1578704 , @Szelethus wrote: > Just thinking aloud! > > We were tinkering with the idea of a checker creator script similar to what > clang-tidy has, that could help on this potentially. > > Is generating the rst

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. In D64454#1578352 , @aaron.ballman wrote: > I'm worried that this will continue to drift out of sync with the static > analyzer checks unless we find some way to automate it. I wonder if we could > write a script to

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov added a comment. This is ready for another round Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:25 /// A kind of a syntax node, used for implementing casts. enum class NodeKind : uint16_t { Leaf, sammccall wrote: > there are going to

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Szelethus added a comment. Just thinking aloud! We were tinkering with the idea of a checker creator script similar to what clang-tidy has, that could help on this potentially. Is generating the rst code with Tblgen a feasable approach? At first glance, it sounds like a nightmare to

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov updated this revision to Diff 208995. ilya-biryukov added a comment. - Mark groups of kinds for statements and expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63835/new/ https://reviews.llvm.org/D63835 Files:

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia marked 2 inline comments as done and 2 inline comments as done. Anastasia added inline comments. Comment at: include/clang/AST/Type.h:6512 +inline bool Type::isTemplateSpecializationType() const { + return isa(this); +} rjmccall wrote: > This is a

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia updated this revision to Diff 208993. Anastasia marked 2 inline comments as done. Anastasia added a comment. - Added handling of similar test case with `InjectedClassNameType` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64400/new/ https://reviews.llvm.org/D64400 Files:

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

NoQ added a comment. In D64454#1578352 , @aaron.ballman wrote: > I'm worried that this will continue to drift out of sync with the static > analyzer checks unless we find some way to automate it. I wonder if we could > write a script to generate these

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Looks like a good change to me, some nits inlined. It shouldn't be difficult to request an account and commit it yourself, which might be useful if you maybe intend to submit more

[PATCH] D63192: [Diagnostics] Implement -Wswitch-default

xbolva00 updated this revision to Diff 208984. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63192/new/ https://reviews.llvm.org/D63192 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmt.cpp test/Sema/switch-availability.c

[PATCH] D64506: clang-cl: Remove -O0 option

thakis added a comment. I did check that we now warn, like you had requested: $ out/gn/bin/clang-cl test.cc /O0 /c clang: warning: argument unused during compilation: '/O0' [-Wunused-command-line-argument] Adding a test for that felt weird though, so I didn't. CHANGES SINCE LAST ACTION

[PATCH] D64506: clang-cl: Remove -O0 option

thakis created this revision. thakis added a reviewer: rnk. cl.exe doesn't understand it; there's /Od instead. See also the review thread for r229575. https://reviews.llvm.org/D64506 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov updated this revision to Diff 208980. ktkachov added a comment. Add more CHECK-LABEL tests, test v8.4a and v8.5a features. Fix formatting in pattern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files:

[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

thakis created this revision. thakis added a reviewer: rnk. - Add back indentation I accidentally removed in r364901 - Wrap two lines to 80 cols - Slightly tighten up help text for several flags - Consistently use "Do not" instead of "Don't" - Make every option description start with a verb - Use

[PATCH] D63192: [Diagnostics] Implement -Wswitch-default

xbolva00 added a comment. In D63192#1539605 , @xbolva00 wrote: > I will work on this after we land https://reviews.llvm.org/D63139. ^ not yet landed, but please @aaron.ballman take a look, this patch is ready for review. CHANGES SINCE LAST ACTION

[PATCH] D63192: [Diagnostics] Implement -Wswitch-default

xbolva00 updated this revision to Diff 208974. xbolva00 added a comment. Rebased, improved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63192/new/ https://reviews.llvm.org/D63192 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

pcc added a comment. Hi Oliver, thanks for working on this. This is something that I've always wanted to do with the type metadata but never had time to work on. I'll try to take a more in depth look later this week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r365643 - [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

Author: cdevadas Date: Wed Jul 10 08:10:08 2019 New Revision: 365643 URL: http://llvm.org/viewvc/llvm-project?rev=365643=rev Log: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG). To enable a new implicit kernel argument, increased the number of argument

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

This revision was automatically updated to reflect the committed changes. Closed by commit rL365643: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and… (authored by cdevadas, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:720 def FJCVTZS : BaseFPToIntegerUnscaled<0b01, 0b11, 0b110, FPR64, GPR32, - "fjcvtzs", []> { + "fjcvtzs",

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:41 +// namespace. +if (const auto UD = dyn_cast(ND)) { + addToken(UD->getIdentLocation(), HighlightingKind::Namespace); nit: const auto *

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:237 +break; + case llvm::AArch64::ArchKind::ARMV8_4A: +getTargetDefinesARMV84A(Opts, Builder); SjoerdMeijer wrote: > It is a good change, but I think you should either

[PATCH] D64494: [analyzer]Add user docs rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL365639: [analyzer]Add user docs rst (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r365639 - [analyzer]Add user docs rst

Author: martong Date: Wed Jul 10 07:49:53 2019 New Revision: 365639 URL: http://llvm.org/viewvc/llvm-project?rev=365639=rev Log: [analyzer]Add user docs rst Summary: Add user documentation page. This is an empty page atm, later patches will add the specific user documentatoins. Reviewers:

r365638 - Remove two unused member variables.

Author: nico Date: Wed Jul 10 07:49:36 2019 New Revision: 365638 URL: http://llvm.org/viewvc/llvm-project?rev=365638=rev Log: Remove two unused member variables. They were added over 10 years ago in r66575 and have never been used as far as I can tell. (r67087 added similar fields to

[PATCH] D64494: [analyzer]Add user docs rst

martong added a comment. In D64494#1578373 , @dkrupp wrote: > I guess this is a placeholder for the subpages of "User Manual" @ > https://clang-analyzer.llvm.org, which will be ported in follow-up patches. Yes. Repository: rG LLVM Github Monorepo

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:237 +break; + case llvm::AArch64::ArchKind::ARMV8_4A: +getTargetDefinesARMV84A(Opts, Builder); It is a good change, but I think you should either add tests for these

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

aaron.ballman added a comment. In D63139#1561891 , @rjmccall wrote: > Are the `CaseStmt`s being dropped in C++ because the expression overflows? I > agree that that's bad AST behavior; we should strive to generate AST whenever > we can, even if it's

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1578245 , @MaskRay wrote: > > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE > > for C++ only, while clang has long been doing it for all languages > > Can you explain more about the hack >

[PATCH] D64494: [analyzer]Add user docs rst

dkrupp accepted this revision. dkrupp added a comment. This revision is now accepted and ready to land. I guess this is a placeholder for the subpages of "User Manual" @ https://clang-analyzer.llvm.org, which will be ported in follow-up patches. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov created this revision. ktkachov added reviewers: t.p.northover, SjoerdMeijer, pbarrio, momchil.velikov. ktkachov added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. The __jcvt intrinsic defined in ACLE [1] is available

[PATCH] D64494: [analyzer]Add user docs rst

martong created this revision. martong added a reviewer: dkrupp. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Add user documentation

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added reviewers: NoQ, Szelethus. aaron.ballman added a subscriber: NoQ. aaron.ballman added a comment. I'm worried that this will continue to drift out of sync with the static analyzer checks unless we find some way to automate it. I wonder if we could write a script to generate

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1947 +def RequireDesignatedInit : InheritableAttr { + let Spellings = [CXX11<"clang", "require_designated_init">]; This should be `RequiresDesignator`.

[PATCH] D64493: [Driver] Don't pass --dynamic-linker to ld on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith, theraven. Herald added subscribers: jrtc27, jyknight. Herald added a project: clang. I noticed that clang currenly passes `--dynamic-linker` to `ld`. This has been the case since Solaris 11 support was added initially back in

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

This revision was automatically updated to reflect the committed changes. Closed by commit rL365634: [clangd] Filter out non-governed files from broadcast (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r365634 - [clangd] Filter out non-governed files from broadcast

Author: kadircet Date: Wed Jul 10 07:11:46 2019 New Revision: 365634 URL: http://llvm.org/viewvc/llvm-project?rev=365634=rev Log: [clangd] Filter out non-governed files from broadcast Summary: This also turns off implicit discovery of additional compilation databases. Reviewers: sammccall

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Added highlightings for namespace specifiers. Repository: rG LLVM Github Monorepo

[PATCH] D64491: [Driver] Enable __cxa_atexit on Solaris

ro created this revision. ro added reviewers: fedor.sergeev, rsmith. Herald added subscribers: dexonsmith, mehdi_amini, jyknight. Herald added a project: clang. Starting with Solaris 11.4 (which is now the required minimal version), Solaris does support `__cxa_atexit`. This patch reflects that.

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64489 Files:

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

MaskRay added a comment. > There's one caveat: gcc defines _LARGEFILE_SOURCE and _LARGEFILE64_SOURCE for > C++ only, while clang has long been doing it for all languages Can you explain more about the hack https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0f97ccfdccc033f543ccbcb220697e62e84bf01f

[PATCH] D64488: [Driver] Support -fsanitize=function on Solaris/x86

ro created this revision. ro added a reviewer: kcc. ro added a project: Sanitizers. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. `UBSan-Standalone-x86_64 :: TestCases/TypeCheck/Function/function.cpp` currently FAILs on Solaris/x86_64: clang-9: error: unsupported

<    1   2   3   >