r370412 - [NFC] Test commit - sorted headers.

Author: nand Date: Thu Aug 29 14:57:47 2019 New Revision: 370412 URL: http://llvm.org/viewvc/llvm-project?rev=370412=rev Log: [NFC] Test commit - sorted headers. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL:

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

lebedev.ri resigned from this revision. lebedev.ri added a comment. Looks about right now, thanks for unbreaking it. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5419-5420 // b relational-op var // if (!S) { + SemaRef.Diag(DefaultLoc,

[PATCH] D66834: Driver tests: set `--sysroot` to "" to support toolchains with default sysroot

broadwaylamb updated this revision to Diff 217987. broadwaylamb added a comment. Herald added subscribers: atanasyan, jrtc27. Add `--sysroot=""` to some driver regression tests These tests otherwise fail if clang is configured with DEFAULT_SYSROOT. Repository: rG LLVM Github Monorepo

r370422 - [Modules] Make ReadModuleMapFileBlock errors reliable

Author: bruno Date: Thu Aug 29 16:14:08 2019 New Revision: 370422 URL: http://llvm.org/viewvc/llvm-project?rev=370422=rev Log: [Modules] Make ReadModuleMapFileBlock errors reliable This prevents a crash when an error should be emitted instead. During implicit module builds, there are cases

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

vsapsai added a comment. For the record, there was another change regarding the delayed typos in `clang::Sema::~Sema()`: D62648 [Sema][Typo] Fix assertion failure for expressions with multiple typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3581 +llvm::DILocalScope *PrevScope = +!LexicalBlockStack.empty() +? dyn_cast(LexicalBlockStack.back()) Is it OK to look up the lexical block stack at this point? The

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver updated this revision to Diff 217973. zoecarver added a comment. - remove rint updates (rint uses runtime-defined rounding method) - add more tests (nan, overflow, round down) - use APFloat rounding methods - if rounding fails, bail out to runtime Repository: rG LLVM Github Monorepo

[PATCH] D66862: Make lround builtin constexpr (and others)

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/math-builtins.cpp:1 +// RUN: %clang_cc1 -std=c++11 %s + -verify ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. "parallel_for_codegen" cannot pass now since it has two test cases for "!=" and it's hard to just add "fopenmp-version=50" since it will break lots of other test cases that have different codegen for OpenMP 5.0. I can remove the "!=" case from "parallel_for_codegen" and

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 217982. NoQ marked 8 inline comments as done. NoQ added a comment. Fixits ♫ Fix the Fixits ♫ Yabba dabba doo ♫ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://reviews.llvm.org/D65182 Files:

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:751 +o << "insert_string\n"; +o << "" << Hint.CodeToInsert << "\n"; +o << " \n"; gribozavr wrote: > Escaping? Oh #@&%! Thanks.

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb updated this revision to Diff 217991. broadwaylamb added a comment. Remove unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66834/new/ https://reviews.llvm.org/D66834 Files: clang/test/Driver/darwin-sdkroot.c

r370419 - Fix silent wrong-code bugs and crashes with designated initialization.

Author: rsmith Date: Thu Aug 29 15:49:34 2019 New Revision: 370419 URL: http://llvm.org/viewvc/llvm-project?rev=370419=rev Log: Fix silent wrong-code bugs and crashes with designated initialization. We failed to correctly handle the 'holes' left behind by designated initializers in VerifyOnly

r370418 - Refactor InitListChecker to check only a single (explicit) initializer

Author: rsmith Date: Thu Aug 29 15:49:33 2019 New Revision: 370418 URL: http://llvm.org/viewvc/llvm-project?rev=370418=rev Log: Refactor InitListChecker to check only a single (explicit) initializer list, rather than recursively checking multiple lists in C. This simplification is in preparation

r370417 - Refactor InitListChecker to make it a bit clearer that hasError is only

Author: rsmith Date: Thu Aug 29 15:49:32 2019 New Revision: 370417 URL: http://llvm.org/viewvc/llvm-project?rev=370417=rev Log: Refactor InitListChecker to make it a bit clearer that hasError is only set to true in VerifyOnly mode in cases where it's also set to true when actually building the

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rsmith added a comment. In D64799#1608085 , @ilya-biryukov wrote: > @rsmith two options for this patch seem to be: > > - silently ignore the errors (behavior before this patch), > - show them to the user at the end of TU (what happens in the current

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

rsmith commandeered this revision. rsmith edited reviewers, added: hintonda; removed: rsmith. rsmith added a comment. I'm taking this over to finish it off and submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66981/new/ https://reviews.llvm.org/D66981

[PATCH] D58214: [CMake][Fuchsia] Enable experimental pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL370421: [CMake][Fuchsia] Enable experimental pass manager by default (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

aganea updated this revision to Diff 217968. aganea retitled this revision from "[DebugInfo] Add debug location to dynamic atexit destructor" to "[DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial". aganea added a comment. More tagging functions as

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

srhines added a comment. In D64666#1650325 , @sylvestre.ledru wrote: > @ziangwan maybe you should add this improvement to the release notes, wdyt? @sylvestre.ledru It's really great to hear that this new diagnostic is helpful. Thanks for the great

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver marked 3 inline comments as done. zoecarver added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9612 + case Builtin::BIlround: + case Builtin::BI__builtin_lround: { rsmith wrote: > It's non-conforming to accept calls to these

[PATCH] D66862: Make lround builtin constexpr (and others)

lebedev.ri added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9616 +return EvaluateFloat(E->getArg(0), Val, Info) && + Success(lround(Val.convertToDouble()), E); + } zoecarver wrote: > rsmith wrote: > > This assumes that the host

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver marked 2 inline comments as done. zoecarver added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9616 +return EvaluateFloat(E->getArg(0), Val, Info) && + Success(lround(Val.convertToDouble()), E); + } lebedev.ri wrote: >

[PATCH] D66862: Make lround builtin constexpr (and others)

craig.topper added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9616 +return EvaluateFloat(E->getArg(0), Val, Info) && + Success(lround(Val.convertToDouble()), E); + } zoecarver wrote: > lebedev.ri wrote: > > zoecarver wrote: > > >

[PATCH] D66862: Make lround builtin constexpr (and others)

craig.topper added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9620 + +if(!EvaluateFloat(E->getArg(0), FPVal, Info)) return false; +APFloat::opStatus status = Space after if Comment at:

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver updated this revision to Diff 217977. zoecarver added a comment. - fix: formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/ https://reviews.llvm.org/D66862 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver updated this revision to Diff 217976. zoecarver added a comment. - fix expected error - fix APInt width - fix nan tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66862/new/ https://reviews.llvm.org/D66862 Files:

[PATCH] D66862: Make lround builtin constexpr (and others)

efriedma added a comment. It's probably worth adding testcases for 0.5 and -0.5. I think the current implementation behaves correctly, but it would be easy to mess up with a small change to the code. Are you intentionally excluding `__builtin_lroundl`/`__builtin_llroundl`?

[PATCH] D66862: Make lround builtin constexpr (and others)

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9617 +APFloat FPVal(0.0); +APSInt IVal(Info.Ctx.getIntWidth(E->getType()), 0); +bool isExact = true; Please use `/*isUnsigned=*/false` for the second argument rather than `0`.

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added a comment. In D66559#1651756 , @cchen wrote: > "parallel_for_codegen" cannot pass now since it has two test cases for "!=" > and it's hard to just add "fopenmp-version=50" since it will break lots of > other test cases that have different

r370420 - [clang-scan-deps] reuse the file manager across invocations of

Author: arphaman Date: Thu Aug 29 15:56:38 2019 New Revision: 370420 URL: http://llvm.org/viewvc/llvm-project?rev=370420=rev Log: [clang-scan-deps] reuse the file manager across invocations of the dependency scanner on a single worker thread This behavior can be controlled using the new

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM: while this isn't a solution to the root cause of the issues here, it puts us in a better situation than the status quo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

broadwaylamb created this revision. broadwaylamb added reviewers: phosek, rnk, mcgrathr, vitalybuka, beanz, hans, filcab, rsmith, compnerd. Herald added subscribers: javed.absar, srhines. Herald added a project: clang. broadwaylamb edited the summary of this revision. Some Driver tests relied on

r370421 - [CMake][Fuchsia] Enable experimental pass manager by default

Author: phosek Date: Thu Aug 29 16:12:06 2019 New Revision: 370421 URL: http://llvm.org/viewvc/llvm-project?rev=370421=rev Log: [CMake][Fuchsia] Enable experimental pass manager by default We plan on using experimental new pass manager for Fuchsia toolchain. Differential Revision:

[PATCH] D66964: Sort Java imports without newline

yannic created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66964 Files: clang/unittests/Format/SortImportsTestJava.cpp Index: clang/unittests/Format/SortImportsTestJava.cpp

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 217940. akhuang marked 4 inline comments as done. akhuang added a comment. - Test that codegen adds the correct address spaces - Modify microsoft mangling to match microsoft mangling. - add comment for overloading Repository: rG LLVM Github Monorepo

r370393 - [X86] Remove what little support we had for MPX

Author: ctopper Date: Thu Aug 29 11:09:02 2019 New Revision: 370393 URL: http://llvm.org/viewvc/llvm-project?rev=370393=rev Log: [X86] Remove what little support we had for MPX -Deprecate -mmpx and -mno-mpx command line options -Remove CPUID detection of mpx for -march=native -Remove MPX from

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added a comment. By the way, I'm open to adding a fix-it hint for zero-parameter K definitions, since the fix is pretty straightforward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66919/new/ https://reviews.llvm.org/D66919

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 217958. jpakkane added a comment. Updated patch to remove #include and the corresponding uint32_t test code snippet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files:

r370401 - Avoid crash when dumping NULL Type as JSON.

Author: aaronballman Date: Thu Aug 29 13:00:40 2019 New Revision: 370401 URL: http://llvm.org/viewvc/llvm-project?rev=370401=rev Log: Avoid crash when dumping NULL Type as JSON. Patch by Bert Belder. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

aaron.ballman added a comment. In D66850#1651519 , @piscisaureus wrote: > @aaron.ballman > I was able to run the tests, I think this is good to go. > Can you help me get it landed? Happy to do so! I landed it in r370401. Thank you for the patch!

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3776 + QualType UnderlyingType = Enum->getIntegerType(); + if (SCS.getToType(1) == UnderlyingType) +return FixedEnumPromotion::ToUnderlyingType; `==` on `QualType` compares the

r370406 - [CFG] Fix CFG for statement-expressions in return values.

Author: dergachev Date: Thu Aug 29 13:37:28 2019 New Revision: 370406 URL: http://llvm.org/viewvc/llvm-project?rev=370406=rev Log: [CFG] Fix CFG for statement-expressions in return values. We're building the CFG from bottom to top, so when the return-value expression has a non-trivial CFG on its

[PATCH] D66404: [CFG] Make destructor calls more accurate

NoQ added a comment. Thanks @nathanchance! I think i fixed it in rC370406 . Comment at: cfe/trunk/lib/Analysis/CFG.cpp:2983-2984 - // Add the return statement to the block. This may create new blocks if R - // contains control-flow

[PATCH] D66669: [X86] Remove what little support we had for MPX

This revision was automatically updated to reflect the committed changes. Closed by commit rL370393: [X86] Remove what little support we had for MPX (authored by ctopper, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[PATCH] D63960: [C++20] Add consteval-specifique semantic

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2317 +def err_invalid_consteval_take_address : Error< + "cannot take address of consteval function %0 in non-constexpr context">; +def err_consteval_address_accessible : Error<

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added a comment. In D66919#1651108 , @dexonsmith wrote: > we just don't warn on non-prototype defining declarations, where the meaning > is unambiguous: > > void foo() {} > "Meaning" is a difficult term. What we know is that this is a K

[PATCH] D66862: Make lround builtin constexpr (and others)

rsmith requested changes to this revision. rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9612 + case Builtin::BIlround: + case Builtin::BI__builtin_lround: { It's non-conforming to accept calls to these non-`__builtin` functions in

[PATCH] D66964: Sort Java imports without newline

SamMaier added a comment. In D66964#1651496 , @yannic wrote: > Right now, this change only adds a test that shows the broken behavior. > > SamMaier@ you're the author of https://reviews.llvm.org/D52800 which > implemented Java import sorting. Is there a

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith added inline comments. Comment at: clang/test/Sema/conversion_function_to_function.cpp:1 +// RUN: not %clang_cc1 -fsyntax-only -std=c++14 %s 2>&1 | FileCheck %s + Use `%clang_cc1 -verify` instead of `not %clang_cc1 | FileCheck` Comment

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:6996 + // a noexcept function can be converted to a noexcept(false) function. + QualType resultTy; + if (getLangOpts().CPlusPlus17 && Please capitalize local variable names

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith added inline comments. Comment at: clang/test/Sema/conversion_function_to_function.cpp:1 +// RUN: not %clang_cc1 -fsyntax-only -std=c++14 %s 2>&1 | FileCheck %s + rsmith wrote: > Use `%clang_cc1 -verify` instead of `not %clang_cc1 | FileCheck` This test

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang marked 2 inline comments as done. akhuang added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1874 +case LangAS::ptr32_sptr: + Extra.mangleSourceName("_ASPtr32_sptr"); + break; rnk wrote: > Hm, we should actually mangle

[PATCH] D66964: Sort Java imports without newline

yannic added reviewers: SamMaier, thakis. yannic added a comment. Right now, this change only adds a test that shows the broken behavior. SamMaier@ you're the author of https://reviews.llvm.org/D52800 which implemented Java import sorting. Is there a reason to not sort imports when there's

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus added a comment. @aaron.ballman I was able to run the tests, I think this is good to go. Can you help me get it landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850

r370400 - Remove `FileManager::invalidateCache` as it has no callers anymore. NFC.

Author: vsapsai Date: Thu Aug 29 12:51:25 2019 New Revision: 370400 URL: http://llvm.org/viewvc/llvm-project?rev=370400=rev Log: Remove `FileManager::invalidateCache` as it has no callers anymore. NFC. Modified: cfe/trunk/include/clang/Basic/FileManager.h

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp:46 +CheckFactories.registerCheck( +"cppcoreguidelines-init-variables"); CheckFactories.registerCheck( Please keep

[PATCH] D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import

bruno created this revision. bruno added reviewers: rsmith, arphaman. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous. Herald added a project: clang. Otherwise the definition (first found) for ObjCInterfaceDecl's might precede the module one, which will eventually lead to

[PATCH] D66839: Fix stack address builtin for negative numbers

efriedma added a comment. In the context of __builtin_frame_address, an arbitrary limit is probably okay. Maybe something like 0x, which is larger than anyone would realistically use, but doesn't take a crazy amount of time to compile. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

sunfish added a comment. Can you say what leads wasm users to maintain such an expectation when, for example, ARM users and x86 users

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66710/new/ https://reviews.llvm.org/D66710 ___ cfe-commits mailing list

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

leonardchan accepted this revision. leonardchan added inline comments. Comment at: clang-tools-extra/clang-misexpect/ClangMisExpect.cpp:64 +break; + default: +llvm_unreachable("Bad Profile Format given to clang-misexpect use one of " Nit: The default

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added a comment. @leonardchan can you revise your review against the latest revision? It looks to me as though you might have reviewed one of the first diffs instead of what is the latest code. For example the files in clang-tools have not been part of this revision for some time.

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218017. paulkirth added a comment. Actually address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 218016. paulkirth added a comment. Address nits - Add pointers to uses of auto - Remove redundant cast - Use consistent type for integers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. Although using `__builtin_shufflevector` and the `shufflevector` instruction works

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

dschuff added a comment. Oh, interesting I didn't notice that those are implementations of the target-specific intrinsics. I wonder if they do that so they can implement the intrinsics on hardware that doesn't support the corresponding instruction? In a situation other than that I think I'd be

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

sunfish added a comment. In D66983#1651977 , @dschuff wrote: > Oh, interesting I didn't notice that those are implementations of the > target-specific intrinsics. I wonder if they do that so they can implement > the intrinsics on hardware that doesn't

r370425 - [clang-scan-deps] NFC, refactor the DependencyScanningWorker to use a consumer

Author: arphaman Date: Thu Aug 29 18:25:57 2019 New Revision: 370425 URL: http://llvm.org/viewvc/llvm-project?rev=370425=rev Log: [clang-scan-deps] NFC, refactor the DependencyScanningWorker to use a consumer to report the dependencies to the client This will allow the scanner to report modular

[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> more closely match the sort order

dsanders updated this revision to Diff 218010. dsanders added a comment. Sort on the check name string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66505/new/ https://reviews.llvm.org/D66505 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

NoQ marked 11 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:75 /// individual bug reports. class BugReport : public llvm::ilist_node { public: gribozavr wrote: > Szelethus

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders updated this revision to Diff 218015. dsanders marked 4 inline comments as done. dsanders added a comment. - Sort order again :-) - Avoid getQualifiedNameAsString() in favour of getName() and checking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:32-33 +"llvm-prefer-register-over-unsigned"); +CheckFactories.registerCheck( +"llvm-namespace-comment"); CheckFactories.registerCheck("llvm-twine-local");

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl updated this revision to Diff 218000. aprantl added a comment. Herald added a subscriber: arphaman. Here is a work-in-progress alternative patch that attacks the problem by changing the AST generation to have an ObjCMethodDecl for the property accessors inside the implementation as

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

dschuff added a comment. I think the expectation is that if you use an intrinsics header that has an intrinsic for each machine instruction, that each intrinsic call should result in exactly one machine instruction with the same arguments you passed to it. If the vector operation is created

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

craig.topper added a comment. x86 is aggressive about optimizing shuffles no matter where they came from. FWIW, InstCombine has a general rule that its not supposed to create a shuffle mask that didn't already exist in the IR except for special things like identity masks that would allow the

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

leonardchan created this revision. leonardchan added reviewers: chandlerc, fedor.sergeev, philip.pfaffe. leonardchan added a project: Sanitizers. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch merges the sancov module and funciton passes into one

[PATCH] D66989: FileManager: Remove ShouldCloseOpenFile argument from getBufferForFile, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, jkorous. Herald added a subscriber: ributzka. Remove this dead code. We always close the file. https://reviews.llvm.org/D66989 Files: clang/include/clang/Basic/FileManager.h clang/lib/Basic/FileManager.cpp

[PATCH] D66828: [clangd] Add distinct highlightings for static fields and methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL370429: [clangd] Add distinct highlightings for static fields and methods (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66348: [ASTImporter] Do not look up lambda classes

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I was concerned about how this would affect LLDB but after thinking about it I realized that in the DWARF we will just end up with one `DW_TAG_class_type`. Repository: rG LLVM Github

[PATCH] D66933: [ASTImporter] Propagate errors during import of overridden methods.

shafik accepted this revision. shafik added a comment. LGTM but I agree w/ Gabor's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66933/new/ https://reviews.llvm.org/D66933 ___ cfe-commits

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge created this revision. nridge added reviewers: hokein, ilya-biryukov, jvikstrom. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66990 Files:

[PATCH] D66404: [CFG] Make destructor calls more accurate

nathanchance added a comment. @NoQ thank you for the fix, I can confirm it works! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66404/new/ https://reviews.llvm.org/D66404 ___ cfe-commits mailing list

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

leonardchan accepted this revision. leonardchan added a comment. Sorry about that. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits

[clang-tools-extra] r370429 - [clangd] Add distinct highlightings for static fields and methods

Author: nridge Date: Thu Aug 29 20:37:24 2019 New Revision: 370429 URL: http://llvm.org/viewvc/llvm-project?rev=370429=rev Log: [clangd] Add distinct highlightings for static fields and methods Reviewers: hokein, ilya-biryukov, jvikstrom Reviewed By: hokein Subscribers: MaskRay, jkorous,

r370297 - [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32

Author: pengfei Date: Wed Aug 28 23:18:34 2019 New Revision: 370297 URL: http://llvm.org/viewvc/llvm-project?rev=370297=rev Log: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32 Summary: Adding support for some missing intrinsics: _mm512_cvtsi512_si32 Reviewers:

r370298 - Removed dead code from clang/AST/NSAPI.h

Author: gribozavr Date: Wed Aug 28 23:30:12 2019 New Revision: 370298 URL: http://llvm.org/viewvc/llvm-project?rev=370298=rev Log: Removed dead code from clang/AST/NSAPI.h Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66884 Modified:

[PATCH] D66884: Removed dead code from clang/AST/NSAPI.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL370298: Removed dead code from clang/AST/NSAPI.h (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

sylvestre.ledru added a comment. FYI, it found a bunch of new warnings in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1577236 https://bugzilla.mozilla.org/show_bug.cgi?id=1577051 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

sylvestre.ledru added a comment. @ziangwan maybe you should add this improvement to the release notes, wdyt? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits

r370300 - [Test][Time profiler] Fix test for python3

Author: anton-afanasyev Date: Wed Aug 28 23:49:05 2019 New Revision: 370300 URL: http://llvm.org/viewvc/llvm-project?rev=370300=rev Log: [Test][Time profiler] Fix test for python3 Summary: Fix test checking time profiler generates correct tracing json-file. `filter` works differently for python2

[PATCH] D66873: [Test][Time profiler] Fix test for python3

This revision was automatically updated to reflect the committed changes. Closed by commit rL370300: [Test][Time profiler] Fix test for python3 (authored by anton-afanasyev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

<    1   2