[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2537 +if (!Actions.CurContext->isTranslationUnit()) { +//FIXME this seems to be the wrong way to check file-scope +//since the token immediately following a function definition

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Please can you regenerate the ClangFormatStyleOptions.rst using docs/tools/dump_style.py and add an entry into the clang release notes in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. I think if you can fix the missing documentation it looks pretty good to go. I do like the use of the static functions and the extensive test cases.. thank you. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1442 +// Search for any

[PATCH] D69868: Allow "callbr" to return non-void values

void updated this revision to Diff 239231. void added a comment. Herald added a subscriber: MatzeB. Split the machine basic block after an INLINEASM_BR instruction that has outputs. The copies then end up in a separate block and the back end doesn't have to deal with COPY instructions between two

[clang] e15fb06 - [RISCV] Pass target-abi via module flag metadata

Author: Zakk Chen Date: 2020-01-20T23:30:54-08:00 New Revision: e15fb06e2d0a068de549464d72081811e7fac612 URL: https://github.com/llvm/llvm-project/commit/e15fb06e2d0a068de549464d72081811e7fac612 DIFF: https://github.com/llvm/llvm-project/commit/e15fb06e2d0a068de549464d72081811e7fac612.diff

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGe15fb06e2d0a: [RISCV] Pass target-abi via module flag metadata (authored by Zakk Chen zakk.c...@sifive.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72984: [TableGen] Use a table to lookup MVE intrinsic names

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72984/new/ https://reviews.llvm.org/D72984

[clang] 514e3c3 - Add missing tests for parent traversal

Author: Stephen Kelly Date: 2020-01-20T11:18:35Z New Revision: 514e3c3694a3457ea5c1b89420246fd845791afd URL: https://github.com/llvm/llvm-project/commit/514e3c3694a3457ea5c1b89420246fd845791afd DIFF: https://github.com/llvm/llvm-project/commit/514e3c3694a3457ea5c1b89420246fd845791afd.diff

[clang] 122443a - Compare traversal for memoization before bound nodes container

Author: Stephen Kelly Date: 2020-01-20T11:20:04Z New Revision: 122443a950521c5d99a0d0479daf57fbd1de2ac2 URL: https://github.com/llvm/llvm-project/commit/122443a950521c5d99a0d0479daf57fbd1de2ac2 DIFF: https://github.com/llvm/llvm-project/commit/122443a950521c5d99a0d0479daf57fbd1de2ac2.diff

[PATCH] D73029: Extend ExprTraversal class with acending traversal

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows ASTContext to store only one parent map, rather than storing an entire parent map for each traversal mode used. This is therefore a partial

[clang-tools-extra] 1f946ee - [clang][CodeComplete] Propogate printing policy to FunctionDecl

Author: Kadir Cetinkaya Date: 2020-01-20T12:20:20+01:00 New Revision: 1f946ee2faba5395a04a081fbe561e3d91aa2b3d URL: https://github.com/llvm/llvm-project/commit/1f946ee2faba5395a04a081fbe561e3d91aa2b3d DIFF:

[clang] 9a3ff47 - Fix the invisible-traversal to ignore more nodes

Author: Stephen Kelly Date: 2020-01-20T11:59:13Z New Revision: 9a3ff478235ccbda23df01a99c5a86eedba54cac URL: https://github.com/llvm/llvm-project/commit/9a3ff478235ccbda23df01a99c5a86eedba54cac DIFF: https://github.com/llvm/llvm-project/commit/9a3ff478235ccbda23df01a99c5a86eedba54cac.diff

Re: [clang] 122443a - Compare traversal for memoization before bound nodes container

On Mon, Jan 20, 2020 at 6:20 AM Stephen Kelly via cfe-commits wrote: > > > Author: Stephen Kelly > Date: 2020-01-20T11:20:04Z > New Revision: 122443a950521c5d99a0d0479daf57fbd1de2ac2 > > URL: > https://github.com/llvm/llvm-project/commit/122443a950521c5d99a0d0479daf57fbd1de2ac2 > DIFF: >

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. So, I ran this check against the cxx directory of llvm, it fired 5 times so let's look at the context and disucss: There are two identical spots in locale.cpp, the first is around line 2717 uint16_t t = static_cast( 0xD800 | wc & 0x1F) >>

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

hokein accepted this revision. hokein added a subscriber: kuhnel. hokein added a comment. This revision is now accepted and ready to land. @kuhnel, I think we should exclude from running clang-format on lint test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kadircet added a comment. In D72746#1827608 , @kbobyrev wrote: > I started using TokenBuffer, but I ran into the following issue: when I'm > creating `TokenBuffer` and `TokenCollector`, they do not contain any tokens. > `Preprocessor` does not seem to

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kuhnel added a comment. thx for the feedback, I created an issue for this: https://github.com/google/llvm-premerge-checks/issues/98 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715

[PATCH] D73028: Extract ExprTraversal class from Expr

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The current implementations are concerned with descending through the AST. An addition to the API will be concerned with ascending through the

[PATCH] D72993: [NFC][Codegen] Use MaybeAlign + APInt::getLimitedValue() when creating Alignment attr

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72993/new/ https://reviews.llvm.org/D72993

[clang] 8248190 - Fix clang-formatting for recent commits

Author: Stephen Kelly Date: 2020-01-20T11:38:23Z New Revision: 8248190a730cd62850afe9bef731ce6726778b4b URL: https://github.com/llvm/llvm-project/commit/8248190a730cd62850afe9bef731ce6726778b4b DIFF: https://github.com/llvm/llvm-project/commit/8248190a730cd62850afe9bef731ce6726778b4b.diff

Re: [clang] 122443a - Compare traversal for memoization before bound nodes container

On Mon, Jan 20, 2020 at 7:56 AM Stephen Kelly wrote: > > > On 20/01/2020 12:42, Aaron Ballman wrote: > > On Mon, Jan 20, 2020 at 6:20 AM Stephen Kelly via cfe-commits > > wrote: > >> > >> Author: Stephen Kelly > >> Date: 2020-01-20T11:20:04Z > >> New Revision:

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri planned changes to this revision. lebedev.ri added a comment. Ah right, hmm, posted too soon. I actually need to synthesize the size/align arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:887 + public: + $1^operator int(); + }; could you rather have a conversion operator to a tag (like `struct Bar`), with

[PATCH] D73025: [AArch64][SVE] Add first-faulting load intrinsic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, andwar, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent revision: D71698:

[clang-tools-extra] 61b5634 - [clangd] Remove a stale FIXME, NFC.

Author: Haojian Wu Date: 2020-01-20T12:07:30+01:00 New Revision: 61b563408012d17e7e619dedfefac5f38dc2d1d9 URL: https://github.com/llvm/llvm-project/commit/61b563408012d17e7e619dedfefac5f38dc2d1d9 DIFF: https://github.com/llvm/llvm-project/commit/61b563408012d17e7e619dedfefac5f38dc2d1d9.diff

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, erichkeane, aaron.ballman, jdoerfert. lebedev.ri added a project: clang. lebedev.ri added a parent revision: D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed

[PATCH] D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed parameters

lebedev.ri created this revision. lebedev.ri added reviewers: erichkeane, rsmith, aaron.ballman, jdoerfert. lebedev.ri added a project: clang. lebedev.ri added a parent revision: D73006: [Codegen] If reasonable, materialize clang's `AllocAlignAttr` as llvm's Alignment Attribute on call-site

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f946ee2faba: [clang][CodeComplete] Propogate printing policy to FunctionDecl (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73026: clang-format: [JS] fix `??` opreator wrapping.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. clang-format currently treats the nullish coalescing operator `??` like the ternary operator. That causes multiple nullish terms to be each indented relative to the last `??`, as they would in a

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

RKSimon added a comment. @rsmith This is failing on http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/3169 - please can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638

[PATCH] D73028: Extract ExprTraversal class from Expr

steveire updated this revision to Diff 239072. steveire added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73028/new/ https://reviews.llvm.org/D73028 Files: clang/include/clang/AST/ExprTraversal.h

[PATCH] D73029: Extend ExprTraversal class with acending traversal

steveire updated this revision to Diff 239075. steveire added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73029/new/ https://reviews.llvm.org/D73029 Files: clang/include/clang/AST/ASTContext.h

Re: [clang] 122443a - Compare traversal for memoization before bound nodes container

On 20/01/2020 12:42, Aaron Ballman wrote: On Mon, Jan 20, 2020 at 6:20 AM Stephen Kelly via cfe-commits wrote: Author: Stephen Kelly Date: 2020-01-20T11:20:04Z New Revision: 122443a950521c5d99a0d0479daf57fbd1de2ac2 URL:

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62027 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

Bouska marked an inline comment as done. Bouska added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:662 "{\n" - " ff();\n" "}", MyDeveloperDay

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

mikhail.ramalho updated this revision to Diff 239186. mikhail.ramalho added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Two changes: - Moved the BoolAssignmentChecker changes to separate revision (D73062 ). -

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. > Is that the desired behavior? This was the previous behavior but I'm not sure > it's the right behavior. Good point. It might be safer to keep that previous behavior though. Thanks for the

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri updated this revision to Diff 239180. lebedev.ri added a comment. Not only do we need to 'insert' size implicit argument, but we may need to insert alignment implicit argument. And while for size we can only insert `nullptr`, for alignment we can actually insert the correct value.

[PATCH] D73035: [clangd] Avoid redundant testcases in rename unittest, NFC.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73035 Files:

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

dmgreen added a comment. What is the reason that this can't be lowered in tablegen, in the same way as the VMOVimm's are? For vbic vs vmovlb, the vmovlb does include a free register move, so may under some circumstances be slightly better. Like you say, it's mostly benign, but may be worth

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM, Thank You! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72755/new/ https://reviews.llvm.org/D72755

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

aaron.ballman added a comment. Btw, do you need me to commit this on your behalf, or have you obtained your commit privileges? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/ https://reviews.llvm.org/D72488

[clang] 4c9d691 - clang-format: [JS] fix `??` opreator wrapping.

Author: Martin Probst Date: 2020-01-20T17:07:14+01:00 New Revision: 4c9d6914453d970b7b8202b7efd7524b2f0a72ac URL: https://github.com/llvm/llvm-project/commit/4c9d6914453d970b7b8202b7efd7524b2f0a72ac DIFF: https://github.com/llvm/llvm-project/commit/4c9d6914453d970b7b8202b7efd7524b2f0a72ac.diff

[PATCH] D62445: [test] Fix plugin tests

mikhail.ramalho added a comment. Herald added a subscriber: Charusso. Hi, I just found this revision. Could you point out how can I run the CSA tests with Z3 as backend? We used to do `$ ninja check-clang-analyzer-z3`, however, it now fails and suggests: $ ninja check-clang-analyzer-z3

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61955 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D73056: [clangd] Fix DocumentOutline for concepts

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73056/new/ https://reviews.llvm.org/D73056

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62027 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. In D73007#1829709 , @xbolva00 wrote: > Yes, but minimal fix is better for release branch, so @hans should merge it. I think `-Wall` shouldn't warn about reference types in a range-based for loop (unless it's the wrong type

[PATCH] D73056: [clangd] Fix DocumentOutline for concepts

kadircet created this revision. kadircet added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/256 Repository: rG LLVM Github Monorepo

[clang-tools-extra] fb3d915 - [clangd] Fix DocumentOutline for concepts

Author: Kadir Cetinkaya Date: 2020-01-20T20:20:27+01:00 New Revision: fb3d9153c01b9a560680465190d6ecd804e4c486 URL: https://github.com/llvm/llvm-project/commit/fb3d9153c01b9a560680465190d6ecd804e4c486 DIFF:

[PATCH] D73019: [Sema] Don't disallow placing `__attribute__((alloc_align(param_idx)))` on `std::align_val_t`-typed parameters

lebedev.ri updated this revision to Diff 239179. lebedev.ri added a comment. NFC, more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73019/new/ https://reviews.llvm.org/D73019 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. In D71124#1792216 , @khchen wrote: > The problem is how `-mcpu` interact with explicitly specified `-march` (or > target features). > > 1. in GCC, -mcpu is only used to chose the pipeline model, I think you mean "in GCC,

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

mikhail.ramalho added a comment. I can give some help here, but my time is quite limited as well :/ Let me at least rebase against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28955/new/ https://reviews.llvm.org/D28955 ___

[PATCH] D68720: Support -fstack-clash-protection for x86

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62035 tests passed, 2 failed and 783 were skipped. failed: Clang.CodeGen/stack-clash-protection.c failed: Clang.Misc/warning-flags.c {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

uweigand added a comment. I've had a quick look at GCC, and it seems there's a couple of different issues. First of all, `-ffast-math` is a "collective" flag that has no separate meaning except setting a bunch of other flags. Currently, these flags are: `-fno-math-errno`, `

[PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

csigg updated this revision to Diff 239160. csigg added a comment. Herald added a subscriber: wuzish. Fix base. I'm so terrible at this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72557/new/ https://reviews.llvm.org/D72557 Files:

[PATCH] D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.

csigg added a comment. Hi David. Thanks a lot for you review. I did another pass to switch to factory methods that catch exceptions without spewing common errors on the GDB console. Would you mind taking another quick peek? Thanks a lot for your patience! Repository: rG LLVM Github Monorepo

[PATCH] D73056: [clangd] Fix DocumentOutline for concepts

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62012 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

hfinkel added a comment. > I'm not sure whether this is deliberate (but it seems weird) or just a bug. I > can ask the GCC developers ... Please do. If there's a rationale, we should know. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.llvm.org/D72675

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 239167. njames93 marked 4 inline comments as done. njames93 added a comment. - Added not type template test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:282 +: DepMemberRef->getBaseType(); +CXXRecordDecl *Base = BaseType.getTypePtr()->getAsCXXRecordDecl(); +if (!Base) JonasToth

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-oop57-cpp.rst:25 + Default is an empty string. + The check will detect the following functions: + `std::memcpy`, `memcpy`, `std::memmove`, `memmove`, `std::strcpy`,

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

peter.smith added a comment. It is also failing on the other 32-bit arm bots, example http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/13052/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Avirtual-compare.cpp Looking at the failure // CHECK-SAME: @_ZThn8_N1AD1Ev and the

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 239166. serge-sans-paille added a comment. - Harmonize esp/rsp usage as hinted by @craig.topper - Fix argument detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev updated this revision to Diff 239182. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Modify the test to address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

mikhail.ramalho created this revision. mikhail.ramalho added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. mikhail.ramalho retitled this revision from "Simplify BoolAssignmentChecker" to "[analyzer] Simplify BoolAssignmentChecker". Herald added

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:905 + public: + ~$1^Foo() {} + kadircet wrote: > this actually looks troublesome, since we are not returning the functiondecl >

[PATCH] D73060: [Clang] Fix expansion of response files in -Wp after integrated-cc1 change

aganea created this revision. aganea added reviewers: hans, thakis, wenlei. aganea added a project: clang. Herald added a subscriber: cfe-commits. aganea edited the summary of this revision. After rGb4a99a061f517e60985667e39519f60186cbb469

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

dnsampaio added a comment. In D72932#1829716 , @ostannard wrote: > Why are you doing this in CodeGen, rather than adjusting the existing layout > code in CGRecordLowering? Doing it this way will result in > AdjustAAPCSBitfieldLValue being called for

[PATCH] D73056: [clangd] Fix DocumentOutline for concepts

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb3d9153c01b: [clangd] Fix DocumentOutline for concepts (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73056/new/

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts :

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12460 - if ((SignExtSrcVT != GLD1SrcMemVT) || !Src.hasOneUse()) + unsigned OpNum = NewOpc == AArch64ISD::LDNF1S ? 3 : 4; + EVT LD1SrcMemVT = cast(Src->getOperand(OpNum))->getVT();

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

dmgreen added a comment. In D72934#1829387 , @simon_tatham wrote: > In D72934#1829331 , @dmgreen wrote: > > > What is the reason that this can't be lowered in tablegen, in the same way > > as the VMOVimm's are? >

patch via mailing list: Use getLocation() in too few/many arguments diagnostic

This small patch improves the diagnostics when calling a function with the wrong number of arguments. For example, given int foo(int a, int b); int bar() { return foo(1); } The existing compiler shows the error message and a note for "foo declared here" showing only

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 updated this revision to Diff 239115. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-extern-variable-basic.c

[clang-tools-extra] 3de9a5d - [clangd] Avoid redundant testcases in rename unittest, NFC.

Author: Haojian Wu Date: 2020-01-20T17:01:05+01:00 New Revision: 3de9a5db629ac9d633576513d025a8f038a3cdec URL: https://github.com/llvm/llvm-project/commit/3de9a5db629ac9d633576513d025a8f038a3cdec DIFF: https://github.com/llvm/llvm-project/commit/3de9a5db629ac9d633576513d025a8f038a3cdec.diff

[PATCH] D73035: [clangd] Avoid redundant testcases in rename unittest, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3de9a5db629a: [clangd] Avoid redundant testcases in rename unittest, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73035/new/

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. njames93 retitled this revision from "First Draft" to "[clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved". njames93 added reviewers: aaron.ballman,

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha marked 2 inline comments as done. Wawha added a comment. Hello, @klimek will you have time to review this patch? The current patch integrate the last remarks and also modification due to inline lambda. Comment at: lib/Format/ContinuationIndenter.cpp:1179 +

[PATCH] D73035: [clangd] Avoid redundant testcases in rename unittest, NFC.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62009 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 updated this revision to Diff 239089. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGDebugInfo.cpp Index: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1827893 , @wristow wrote: > How to handle this seems like an implementation question. The code here is > just deciding whether or not we intend to pass "-ffast-math" to cc1 (it isn't > directly defining

[PATCH] D72934: [ARM,MVE] Support immediate vbicq,vorrq,vmvnq intrinsics.

simon_tatham marked 2 inline comments as done. simon_tatham added a comment. In D72934#1829331 , @dmgreen wrote: > What is the reason that this can't be lowered in tablegen, in the same way as > the VMOVimm's are? In NEON, immediate VBIC is represented

[PATCH] D72830: [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

MarkMurrayARM updated this revision to Diff 239112. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72830/new/ https://reviews.llvm.org/D72830 Files: clang/include/clang/Basic/arm_mve.td

[clang] b10a0eb - [ARM][MVE][Intrinsics] Take abs() of VMINNMAQ, VMAXNMAQ intrinsics' first arguments.

Author: Mark Murray Date: 2020-01-20T14:33:26Z New Revision: b10a0eb04adfc4186cc6198cf8231358b2b04d89 URL: https://github.com/llvm/llvm-project/commit/b10a0eb04adfc4186cc6198cf8231358b2b04d89 DIFF: https://github.com/llvm/llvm-project/commit/b10a0eb04adfc4186cc6198cf8231358b2b04d89.diff LOG:

[clang-tools-extra] a42c3eb - [clang-tidy] Add check for CERT-OOP57-CPP

Author: Nathan Date: 2020-01-20T17:09:03Z New Revision: a42c3eb599cb3b83a07e6296d4ade213f1d74f0f URL: https://github.com/llvm/llvm-project/commit/a42c3eb599cb3b83a07e6296d4ade213f1d74f0f DIFF: https://github.com/llvm/llvm-project/commit/a42c3eb599cb3b83a07e6296d4ade213f1d74f0f.diff LOG:

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

aaron.ballman added a comment. In D71607#1828055 , @sorenj wrote: > Okay, but as you can see the majority of my test cases are intentionally > false negatives `- -Wsign-conversion` triggers so often than many people > don't use it. Then we should be

[PATCH] D73026: clang-format: [JS] fix `??` opreator wrapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c9d6914453d: clang-format: [JS] fix `??` opreator wrapping. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73026/new/

[PATCH] D71566: New checks for fortified sprintf

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:745-746 +def warn_fortify_source_format_overflow : Warning< + "'%0' will always overflow; destination buffer has size %1," + " but format string expands to at least %2">, +

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added a comment. Why are you doing this in CodeGen, rather than adjusting the existing layout code in CGRecordLowering? Doing it this way will result in AdjustAAPCSBitfieldLValue being called for every access to the bitfield, rather than just once. This is probably more fragile too,

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

This revision was automatically updated to reflect the committed changes. Closed by commit rGa42c3eb599cb: [clang-tidy] Add check for CERT-OOP57-CPP (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72488/new/

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added a comment. Hello, Thank you for your useful comments. I think I fixed them all now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware updated this revision to Diff 239103. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001 Files:

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. Added inline reply Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:111 // the corresponding enum in the IR. -static llvm::fp::RoundingMode ToConstrainedRoundingMD( +llvm::fp::RoundingMode

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:282 +: DepMemberRef->getBaseType(); +CXXRecordDecl *Base = BaseType.getTypePtr()->getAsCXXRecordDecl(); +if (!Base) can

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you think this should also be pushed onto the release branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73007/new/

[clang] 3663563 - [OPENMP]Fix PR44578: crash in target construct with captured global.

Author: Alexey Bataev Date: 2020-01-20T11:10:17-05:00 New Revision: 366356361cf3abf97fbcfe9a0467b1ed1610401f URL: https://github.com/llvm/llvm-project/commit/366356361cf3abf97fbcfe9a0467b1ed1610401f DIFF: https://github.com/llvm/llvm-project/commit/366356361cf3abf97fbcfe9a0467b1ed1610401f.diff

[PATCH] D73007: [Sema] Avoid Wrange-loop-analysis false positives

aaronpuchert added a comment. As I wrote on the bug , I think we should only suppress one of the warnings in templates (and maybe always): :18:22: warning: loop variable '_' is always a copy because the range of type 'const Rng' does not return a

  1   2   >