[PATCH] D76452: Use LLD by default for Android.

nickdesaulniers added a comment. Can we use `-DCLANG_DEFAULT_LINKER=lld` to configure AOSP's distribution of LLD, then require the use of `-fuse-ld=` when targeting OSX host tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

saugustine added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break; itollefsen wrote: > If you are building with `-DLIBUNWIND_ENABLE_SHARED:OFF >

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + erichkeane wrote: > yaxunl wrote: > > echristo wrote: > > > rjmccall wrote: > > > > yaxunl wrote: > > > > >

[PATCH] D78190: Add Bfloat IR type

jfb added a comment. Thanks for adding the IR type. At a high-level this looks good to me, but I haven't done an in-depth review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:723 +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context)); +return; Shouldn't we add these attributes if there are no

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + rjmccall wrote: > erichkeane wrote: >

[PATCH] D78190: Add Bfloat IR type

scanon requested changes to this revision. scanon added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/LangRef.rst:3240 +double are represented using the 16-digit form shown above (which matches the +IEEE754 representation for double); half

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rG14aaf4457c64: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds accepted this revision. sameerds added a comment. This revision is now accepted and ready to land. Thanks @saiislam ... this looks much better! Two nitpicks, that must be fixed. But it is okay if you directly submit after fixing them. 1. The change description should use "const char

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 updated this revision to Diff 259792. johnchen902 added a comment. Rebased to HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D78190: Add Bfloat IR type

rjmccall added a comment. Thanks for doing it this way, I think this is going to be much better long-term for LLVM. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point value (8-bit mantissa) + scanon wrote: > bfloat

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + tra wrote: > rjmccall wrote: > > erichkeane wrote: > > > yaxunl wrote: > > > > echristo wrote: > > > > >

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge added a comment. Applies on top of D76451 . Depends on

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 updated this revision to Diff 259789. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge added a comment. Applies on top of D76451 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/ https://reviews.llvm.org/D78784 ___ cfe-commits mailing

[clang] bd6942e - Re-land "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"

Author: Reid Kleckner Date: 2020-04-23T16:22:01-07:00 New Revision: bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581 URL: https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581 DIFF: https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581.diff

[clang] 2c3ee88 - [Sema][test] Fix implicit-int-float-conversion.c on Windows

Author: Fangrui Song Date: 2020-04-23T18:52:04-07:00 New Revision: 2c3ee8812c14ab13203de22e0d0ece90f4a8291e URL: https://github.com/llvm/llvm-project/commit/2c3ee8812c14ab13203de22e0d0ece90f4a8291e DIFF: https://github.com/llvm/llvm-project/commit/2c3ee8812c14ab13203de22e0d0ece90f4a8291e.diff

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:723 +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context)); +return; pfultz2

[PATCH] D78190: Add Bfloat IR type

arsenm added a comment. What's the plan for handling this in LLT where we don't have specific types with the same size? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane created this revision. erichkeane added a reviewer: craig.topper. After speaking with Craig Topper about some recent defects, he pointed out that _ExtInts should be passed indirectly if larger than the largest int register, and like ints when smaller than that. This patch implements

[PATCH] D78733: [OPENMP]Use new interface for task reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. One nit below. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:170 ArrayRef ReductionOps); - /// Emits lvalue for a reduction item. + ///

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 259796. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. In D77621#2000237 , @nikic wrote: > Okay, I'm basically fine with that, if it is our stance that SmallVector > should always be preferred over std::vector. Not really related to this > revision, but it would probably help to

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

Quuxplusone added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2804 +return; + } + Asking silly questions because I don't stand a chance of understanding either the code or the tests... In the x86-64 ABI, an ordinary 16-byte `struct`

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 259751. rnk added a comment. - Lots of documentation words Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259762. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve couple more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Index.cpp:27 +llvm::StringRef SpanName, SymbolIndex::Stub *Stub, ClangdRequestT Request, +std::function>( +SymbolIndex::Stub *, grpc::ClientContext *, const RPCRequestT &)>

[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis

jrtc27 created this revision. jrtc27 added reviewers: rsmith, Anastasia. Herald added subscribers: cfe-commits, arichardson. Herald added a project: clang. This is a small improvement for OpenCL diagnostics, but is also useful for our CHERI fork, as our __capability qualifier is suppressed from

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay added a comment. In D73845#2000455 , @sthibaul wrote: > Thanks! I don't have commit access, could somebody commit this for me? Can you provide your `name `? I need this information to run `git c --amend --author=` CHANGES SINCE LAST ACTION

[clang] 14aaf44 - [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

Author: Fangrui Song Date: 2020-04-23T18:26:06-07:00 New Revision: 14aaf4457c641bd5130072ba2a035e254b92fad3 URL: https://github.com/llvm/llvm-project/commit/14aaf4457c641bd5130072ba2a035e254b92fad3 DIFF: https://github.com/llvm/llvm-project/commit/14aaf4457c641bd5130072ba2a035e254b92fad3.diff

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

itollefsen added a comment. This fails to account for whether you actually //have// the shared and/or static version of the library. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break;

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7670 + Mask, Op.getOperand(0), Op.getOperand(1)); +} + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > If we're going to support these

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity updated this revision to Diff 259508. whisperity retitled this revision from "[clang-tidy] Suspicious Call Argument checker" to "[clang-tidy] Add 'readability-suspicious-call-argument' check". whisperity edited the summary of this revision. whisperity removed reviewers: varjujan,

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

whisperity commandeered this revision. whisperity added a reviewer: barancsuk. whisperity added a comment. Herald added subscribers: martong, Charusso, gamesh411, Szelethus. Assuming direct control. Previous colleagues and university mates departed for snowier pastures, time to try to do

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

krasimir added a comment. Could you please update the patch with full context: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface This helps out when reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen added a comment. It seems a NVIDIA Developer Program Membership is needed in order to download the TRM. I'm not sure if that is just a matter of creating an account, but without it I can't really verify that the architecture version and the features are correct and complete.

[clang] 0021644 - [SveEmitter] Add builtins for FP conversions

Author: Sander de Smalen Date: 2020-04-23T10:49:06+01:00 New Revision: 002164461b52e0ff13fa677a535991f89da0f633 URL: https://github.com/llvm/llvm-project/commit/002164461b52e0ff13fa677a535991f89da0f633 DIFF:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

whisperity added inline comments. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:391 +Currently On-demand analysis is not supported with `scan-build-py`. \ No newline at end of file What's this line? Is this added by Phab, or is this a weird

[clang] 2f9fc8d - [clang-format] Handle C# property accessors when parsing lines

Author: Jonathan Coe Date: 2020-04-23T13:25:10+01:00 New Revision: 2f9fc8d9718fb19c04e169f7ba7ae26ea6a05085 URL: https://github.com/llvm/llvm-project/commit/2f9fc8d9718fb19c04e169f7ba7ae26ea6a05085 DIFF: https://github.com/llvm/llvm-project/commit/2f9fc8d9718fb19c04e169f7ba7ae26ea6a05085.diff

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske updated this revision to Diff 259513. balazske marked 5 inline comments as done. balazske added a comment. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809 Files:

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/CodeGenCXX/trivial-auto-var-init-attribute.cpp:38-50 +// UNINIT-LABEL: test_pragma_attribute_uninitialized_f2( +// UNINIT:

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, rnkovacs, Szelethus, baloghadamsoftware, mikhail.ramalho. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, a.sidorin, szepet, whisperity, mgorny. Herald added a project: clang.

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal updated this revision to Diff 259531. steakhal added a comment. Upload the right diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78704/new/ https://reviews.llvm.org/D78704 Files: clang/unittests/StaticAnalyzer/CMakeLists.txt

[PATCH] D74813: [RFC] Add hash of block contents to function block names

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-cxxfilt/invalid.test:1 -RUN: llvm-cxxfilt -n _Z1fi __Z1fi f ___ZSt1ff_block_invoke | FileCheck %s +RUN: llvm-cxxfilt -n _Z1fi __Z1fi f ___ZSt1ff_block_invoke ___Z7my_mainv_block_invoke_ZTSi_ZTSj_ZTSPVK3sss |

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

balazske updated this revision to Diff 259491. balazske added a comment. - Stream error is stored in separate boolean flags instead of enum. - Removed `PossibleErrors`. - Added "FilePositionIndeterminate". - Updated fread, fwrite, fseek, clearerr. - Added tests. Repository: rG LLVM Github

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. In D78192#1997698 , @Meinersbur wrote: > Is this ready to try out? It is! > > > In D78192#1996859 , > @serge-sans-paille wrote: > >> Note that this should solve in an

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbb7921da97c: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using… (authored by Andi-Bogdan Postelnicu abposteln...@me.com). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 259499. f00kat added a comment. 1. Rewroted ElementRegion processing and fixed tests for this cases. 2. Simplified the code a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rG002164461b52: [SveEmitter] Add builtins for FP conversions (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78239?vs=258426=259504#toc Repository: rG LLVM Github Monorepo

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78642/new/ https://reviews.llvm.org/D78642 ___ cfe-commits mailing list

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 259514. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I agree with the sentiment that it's annoying when clang doesn't just work out of the box. But it will still do, except for asan and profile info etc, for which I think it's reasonable to add to

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

milianw added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

ASDenysPetrov updated this revision to Diff 259521. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. @baloghadamsoftware I've added a test for unscoped SVal, but still can't come up with `if (!LPos || !RPos)` Could you, please, suggest me something? CHANGES

[PATCH] D78214: [libclang]: visit C++17 if init statements

milianw added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks, this looks much better now. Could you also update the description of the revision to match the current status? (E.g. type aliases are now supported.) If you do not plan to solve

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal updated this revision to Diff 259532. steakhal added a comment. - keep the visitor - fix the bug - add test demonstrating the bug and the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/ https://reviews.llvm.org/D78457 Files:

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2871 + // Overwrite the associated constraint of the Symbol. + Constraints = CF.remove(Constraints, Sym); Constraints =

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1044 +class ParamWithoutVarRegion : public TypedValueRegion { + friend class MemRegionManager;

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. @JonasToth could you please clarify if the original author's comment is sufficient grants of rights? If so, from what I can tell if the commit message was adapted to reflect that this removes false positives with system macros like `assert`, this would be good to go?

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. sdesmalen: Could you please take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940 ___ cfe-commits mailing list

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

hokein added a comment. In D50078#1998520 , @Typz wrote: > In D50078#1998398 , @dyung wrote: > > > Hi, this change that you submitted in commit > > 5daa25fd7a184524759b6ad065a8bd7e95aa149a > >

[clang] 47ef09e - Revert "clang-format: support aligned nested conditionals formatting"

Author: Haojian Wu Date: 2020-04-23T09:25:01+02:00 New Revision: 47ef09e4848a970c530928496b54085cfdba5a76 URL: https://github.com/llvm/llvm-project/commit/47ef09e4848a970c530928496b54085cfdba5a76 DIFF: https://github.com/llvm/llvm-project/commit/47ef09e4848a970c530928496b54085cfdba5a76.diff

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 259487. Herald added a reviewer: jhenderson. Herald added a project: libc++abi. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. In D50078#1998398 , @dyung wrote: > Hi, this change that you submitted in commit > 5daa25fd7a184524759b6ad065a8bd7e95aa149a > seems > to be causing the test

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv marked 6 inline comments as done. alexbdv added a comment. For tests - the existing block tests should be enough, just need to update them. I updated a few - want to make sure changes are final before updating all the tests to not have to update tests again. Comment

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz marked an inline comment as done. Typz added a comment. Typz added inline comments. Comment at: clang/lib/Format/WhitespaceManager.h:163 +// it does not increase the indent for "chained" conditionals. +int ConditionalsLevel; + This field is not

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added a comment. Hi Cryptoad, Thank you so much for your comment. I will divide it into two patches according to your suggestion. Best regards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm.org/D62368

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. In D77621#1995673 , @browneee wrote: > Thanks for the revert explanation and notes, nikic. > > @dexonsmith what is your current thinking on going back to the original > std::vector approach? SmallVector has only been limited

[clang-tools-extra] bbb7921 - [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

Author: Andi-Bogdan Postelnicu Date: 2020-04-23T11:36:50+03:00 New Revision: bbb7921da97ce03d2933e185a525c4e452b146b0 URL: https://github.com/llvm/llvm-project/commit/bbb7921da97ce03d2933e185a525c4e452b146b0 DIFF:

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1044 +class ParamWithoutVarRegion : public TypedValueRegion { + friend class MemRegionManager;

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thanks for the updates, @LukeGeeson, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77871/new/ https://reviews.llvm.org/D77871

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259495. serge-sans-paille added a comment. Fix dependency order for extension libraries, as spotted by @Meinersbur CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 Files:

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 259485. saiislam added a comment. Removed documentation from clang doc. Squashed all changes into a single commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge updated this revision to Diff 259483. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 Files:

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:569 ASTResults = locateASTReferent(NearbyIdent->location(), NearbyIdent, AST, - *MainFilePath, Index); + *MainFilePath,

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added inline comments. Comment at: clang/lib/AST/Mangle.cpp:41 + for (ParmVarDecl *PVD : BD->parameters()) { +Context.mangleTypeName(PVD->getType(), Out); + } >>! In D74813#1996143, @alexbdv wrote: > @dexonsmith, @erik.pilkington - how

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 259605. wxz2020 added a comment. Resubmit as the previous one was rejected by test plan changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259604. kbobyrev added a comment. Implement (B) for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan updated this revision to Diff 259602. leonardchan added a comment. Updated to reflect the changes in D72959 which make the vtable 4-byte aligned under the `Relative` layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

kmclaughlin updated this revision to Diff 259610. kmclaughlin added a comment. - Removed changes to handle legalisation from this patch (this will be included in a follow up) - Added AArch64ISD nodes for SDIV_PRED & UDIV_PRED - Changed LowerDIV to use the new ISD nodes rather than lowering to

[PATCH] D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:632 + if (mustEmitDebugInfo(DriverArgs) == EmitSameDebugInfoAsHost) +CC1Args.push_back("-D__CUDACC_DEBUG__"); + Built-in preprocessor macros are defined in

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

jbcoe marked 2 inline comments as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1344 addUnwrappedLine(); FormatTok->Type = TT_FunctionLBrace; parseBlock(/*MustBeDeclaration=*/false);

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9fc8d9718f: [clang-format] Handle C# property accessors when parsing lines (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

NoQ accepted this revision. NoQ added a comment. Yup. Yet another epic bug! Comment at: clang/test/Analysis/CheckThatArraySubsciptNodeIsNotCollected.cpp:18-19 +// time to collect redundant nodes. This GC-like mechanism kicks in only when +// the exploded graph is large enough

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

sdesmalen updated this revision to Diff 259554. sdesmalen marked 3 inline comments as done. sdesmalen added a comment. - Changed UNSIGNED_BYTE etc from upper-case to CamelCase. - Added comment explaining need to expand SV_ALL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78401/new/

[clang] b0a1c0b - [doc] Fix broken link. NFC.

Author: Xing GUO Date: 2020-04-23T22:47:39+08:00 New Revision: b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8 URL: https://github.com/llvm/llvm-project/commit/b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8 DIFF: https://github.com/llvm/llvm-project/commit/b0a1c0b72c9c61f8b0a223e08f43498abb64f5e8.diff

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the enclosing

[PATCH] D46472: [HIP] Support offloading by linker script

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp:1329 + // Get the HIP offload tool chain. + auto *HIPTC = static_cast( + C.getSingleOffloadToolChain()); JonChesterfield

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

bernhard added a comment. > It's for users who want smaller wasm binaries. It's not currently documented, > though yes, it would be nice to document it. But how would a user even end up with wasm-opt in the same directory of clang binaries? > Clang and wasm-ld are free to do anything wasm-opt

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

sdesmalen updated this revision to Diff 259587. sdesmalen marked an inline comment as done. sdesmalen added a comment. - Don't emit bitcast+gep+bitcast when offset is 0. - Added negative tests for _vnum cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78674/new/

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas updated this revision to Diff 259594. pratlucas added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:261 + + if (const VarRegion *TheVarRegion = BaseRegion->getAs()) { +const VarDecl *TheVarDecl = TheVarRegion->getDecl(); Perhaps you could call instead

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7727 + Value *Offset = Ops.size() > 3 ? Ops[2] : Builder.getInt32(0); + BasePtr = Builder.CreateGEP(MemoryTy, BasePtr, Offset); + efriedma

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

sdesmalen updated this revision to Diff 259589. sdesmalen added a comment. - Updated the tests to use `SVE_ACLE_FUNC` for the overloaded builtins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78677/new/ https://reviews.llvm.org/D78677 Files:

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

balazske updated this revision to Diff 259584. balazske added a comment. - Separating test files, fixing alignof problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/ https://reviews.llvm.org/D77809 Files: clang/lib/Analysis/CFG.cpp

[clang] a880256 - [analyzer] Consider array subscripts to be interesting lvalues.

Author: Valeriy Savchenko Date: 2020-04-23T19:52:45+03:00 New Revision: a88025672f89374bfa584e2179a557f44d86da11 URL: https://github.com/llvm/llvm-project/commit/a88025672f89374bfa584e2179a557f44d86da11 DIFF:

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jfb accepted this revision. jfb added inline comments. Comment at: clang/test/Parser/pragma-attribute.cpp:190 +#pragma clang attribute pop +#pragma clang attribute push([[clang::uninitialized]], apply_to = variable) // expected-error {{attribute 'uninitialized' can't be applied

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor nit, thank you! Comment at: clang/lib/Analysis/CFG.cpp:2855 + VA = FindVA(VA->getElementType().getTypePtr())) { + if (CFGBlock *newBlock = addStmt(VA->getSizeExpr())) +

[PATCH] D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode

tambre created this revision. tambre added a reviewer: tra. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. NVCC defines __CUDACC_DEBUG__ when compiling device code in debug mode. Let's do the same to help with compatibility between the two and possibly enable users

  1   2   3   >