[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13122 +if (Base->isVirtual()) { + BaseAlignment = Ctx.getTypeAlignInChars(Base->getType()); + Offset = CharUnits::Zero(); rjmccall wrote: > ahatanak wrote: > > rjmccall

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak updated this revision to Diff 264157. ahatanak marked 2 inline comments as done. ahatanak added a comment. Fix alignment computation of virtual bases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78767/new/

[PATCH] D78862: [IR] Convert null-pointer-is-valid into an enum attribute

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Herald added subscribers: jurahul, kuter. In D78862#2027254 , @arsenm wrote: > In D78862#2012560 ,

[PATCH] D79968: StoreInst should store Align, not MaybeAlign

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, two minor things below. Comment at: clang/lib/CodeGen/CGExpr.cpp:130 + auto *Store = new llvm::StoreInst(Init, Var.getPointer(), false, +

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Interesting that no tests changed but I guess we just start the move to the IRBUilder. I think there are two minor comments from before that need to be addressed and the alloca thing,

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. In D79675#2037484 , @fghanim wrote: > In D79675#2037314 , @jdoerfert wrote: > > > I left some comments on the type stuff. The rest looks good. > > I think if you rebase the type stuff on

[PATCH] D79693: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

hubert.reinterpretcast updated this revision to Diff 264149. hubert.reinterpretcast added a comment. - Use clang_cc1 in arm_cmse.h tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693 Files:

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl updated this revision to Diff 264148. yaxunl added a comment. add a test for nodebug attr. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/ https://reviews.llvm.org/D79967 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/nodebug-attr.c

[PATCH] D79693: [test][ARM][CMSE] Use clang_cc1 in arm_cmse.h tests

hubert.reinterpretcast added a comment. In D79693#2036710 , @chill wrote: > I can also count (`grep -rn '#include.* standard headers. If they don't create a problem, wouldn't it be better to > rewrite this test to use `%clang_cc1` ? @chill, thanks for

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl added a comment. In D79967#2037675 , @dblaikie wrote: > I'm not quite following the test case - could you explain how it's testing > the situation? > > It might be better/easier to have a more intentional test - also, could you > check the commit

[PATCH] D79967: Fix debug info for NoDebug attr

dblaikie added a comment. I'm not quite following the test case - could you explain how it's testing the situation? It might be better/easier to have a more intentional test - also, could you check the commit history for this declaration-emitting functionality (CGDebugInfo::EmitFunctionDecl

[PATCH] D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG592303a53e6b: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

zequanwu updated this revision to Diff 264129. zequanwu added a comment. Use another mapvector `constRefUses` to store uninitialized const reference uses so that the new warning can be easily disable by `-Wno-initialized-const-reference` CHANGES SINCE LAST ACTION

[clang] 592303a - [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

Author: Leonard Chan Date: 2020-05-14T17:03:58-07:00 New Revision: 592303a53e6bc0737c3999e91aab9ea2147f73ab URL: https://github.com/llvm/llvm-project/commit/592303a53e6bc0737c3999e91aab9ea2147f73ab DIFF: https://github.com/llvm/llvm-project/commit/592303a53e6bc0737c3999e91aab9ea2147f73ab.diff

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

rjmccall added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); michele.scandale

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

rjmccall added a comment. Other changes look good to me, thanks. Comment at: clang/lib/Sema/SemaChecking.cpp:13122 +if (Base->isVirtual()) { + BaseAlignment = Ctx.getTypeAlignInChars(Base->getType()); + Offset = CharUnits::Zero(); ahatanak wrote:

[PATCH] D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, don't forget to include full context with your patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79974/new/

[PATCH] D79974: [Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added subscribers: dexonsmith, mikhail.ramalho, mgorny. phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, don't forget to

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. In order not to modify the `tgt_target_data_update` information but still be able to pass the extra information

[PATCH] D79973: [WebAssembly] Update latest implemented SIMD instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Move instructions that have recently been implemented in V8 from the

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. In D79698#2037425 , @aeubanks wrote: > In D79698#2037305 , @leonardchan > wrote: > > > Just to followup on this: We believe the root cause of the error we're > > running into is that

[PATCH] D79877: [clang][SveEmitter] SVE builtins for `svusdot` and `svsudot` ACLE.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1249 +def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone, "aarch64_sve_usdot", [ReverseUSDOT]>; +def SVSUDOT_N_S :

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 3 inline comments as done. fghanim added a comment. In D79675#2037314 , @jdoerfert wrote: > I left some comments on the type stuff. The rest looks good. > I think if you rebase the type stuff on D79739 >

[clang] e9802aa - Revert "Run Coverage pass before other *San passes under new pass manager"

Author: Leonard Chan Date: 2020-05-14T15:19:27-07:00 New Revision: e9802aa4221ba3857041c2328639ce2aac0ace67 URL: https://github.com/llvm/llvm-project/commit/e9802aa4221ba3857041c2328639ce2aac0ace67 DIFF: https://github.com/llvm/llvm-project/commit/e9802aa4221ba3857041c2328639ce2aac0ace67.diff

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG05eedf1f5b44: [clang][VerifyDiagnosticConsumer] Support filename wildcards (authored by arames, committed by jkorous). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 264112. melver added a comment. Fix formatting. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp

[clang] 05eedf1 - [clang][VerifyDiagnosticConsumer] Support filename wildcards

Author: Alexandre Rames Date: 2020-05-14T15:15:49-07:00 New Revision: 05eedf1f5b449ae42f5493576164b0f9a001646c URL: https://github.com/llvm/llvm-project/commit/05eedf1f5b449ae42f5493576164b0f9a001646c DIFF:

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0363ae97abb8: [OPENMP50]Codegen for uses_allocators clause. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks added a comment. In D79698#2037305 , @leonardchan wrote: > Just to followup on this: We believe the root cause of the error we're > running into is that some sancov guards in one comdat are being referenced by > symbols in another comdat, so

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13122 +if (Base->isVirtual()) { + BaseAlignment = Ctx.getTypeAlignInChars(Base->getType()); + Offset = CharUnits::Zero(); rjmccall wrote: > Oh, this — and all the other

[PATCH] D79967: Fix debug info for NoDebug attr

tra added a reviewer: dblaikie. tra added a subscriber: dblaikie. tra added a comment. LGTM. Added @dblaikie as reviewer for debug info expertise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79967/new/ https://reviews.llvm.org/D79967

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

melver updated this revision to Diff 264109. melver added a comment. Add tests checking that when passing the combination of the sanitizer flags to Clang, we generate instrumentation for all enabled sanitizers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak updated this revision to Diff 264106. ahatanak marked 8 inline comments as done. ahatanak added a comment. Address most of the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78767/new/ https://reviews.llvm.org/D78767

[clang] 0363ae9 - [OPENMP50]Codegen for uses_allocators clause.

Author: Alexey Bataev Date: 2020-05-14T18:02:12-04:00 New Revision: 0363ae97abb841114e841a963c95eb6a2202716d URL: https://github.com/llvm/llvm-project/commit/0363ae97abb841114e841a963c95eb6a2202716d DIFF: https://github.com/llvm/llvm-project/commit/0363ae97abb841114e841a963c95eb6a2202716d.diff

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 264096. arames added a comment. Rebase on top of tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst

[PATCH] D79967: Fix debug info for NoDebug attr

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a subscriber: aprantl. NoDebug attr does not totally eliminate debug info about a function when inlining is enabled. This is inconsistent with when inlining is disabled. This patch fixes that.

[PATCH] D79966: [OPENMP]Fix PR45911: Data sharing and lambda capture.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. No need to generate inlined OpenMP region for variables captured in lambdas or block decls, only for implicitly captured variables in the OpenMP region.

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

This revision was automatically updated to reflect the committed changes. Closed by commit rG11d612ac99a6: [clang][Preprocessor] Replace the slow translateFile call by a new, faster… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79830: Add support of __builtin_expect_with_probability

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2195 +Value *ExpectedValue = EmitScalarExpr(E->getArg(1)); +Value *Confidence = EmitScalarExpr(E->getArg(2)); +// Don't generate llvm.expect.with.probability on -O0 as the backend

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 264094. fhahn added a comment. Update to support non-constant-integer-expressions as indices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/ https://reviews.llvm.org/D76791 Files:

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:227 + FMF.setAllowContract(FPFeatures.allowFPContractAcrossStatement() || + FPFeatures.allowFPContractWithinStatement()); } mibintc wrote: > mibintc

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

michele.scandale added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +Opts.setDefaultFPContractMode(LangOptions::FPM_Fast); Opts.HexagonQdsp6Compat = Args.hasArg(OPT_mqdsp6_compat); mibintc wrote:

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

leonardchan added a comment. Just to followup on this: We believe the root cause of the error we're running into is that some sancov guards in one comdat are being referenced by symbols in another comdat, so due to linking order, the other comdat in question is referencing a sancov guard that

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. I left some comments on the type stuff. The rest looks good. I think if you rebase the type stuff on D79739 (which I can merge) we should only need to expand `initializeTypes` to make this work as expected. WDYT?

[clang] 11d612a - [clang][Preprocessor] Replace the slow translateFile call by a new, faster isMainFile check

Author: Alex Lorenz Date: 2020-05-14T14:13:34-07:00 New Revision: 11d612ac99a621c762c2cc8f7bacbb8ae32d7fe9 URL: https://github.com/llvm/llvm-project/commit/11d612ac99a621c762c2cc8f7bacbb8ae32d7fe9 DIFF: https://github.com/llvm/llvm-project/commit/11d612ac99a621c762c2cc8f7bacbb8ae32d7fe9.diff

[clang] 428d0b6 - Fix clang test failures from D77454

Author: Eli Friedman Date: 2020-05-14T14:10:51-07:00 New Revision: 428d0b6f77986efd944df01bb4ae7888c6262c2f URL: https://github.com/llvm/llvm-project/commit/428d0b6f77986efd944df01bb4ae7888c6262c2f DIFF: https://github.com/llvm/llvm-project/commit/428d0b6f77986efd944df01bb4ae7888c6262c2f.diff

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 264089. pestctrl added a comment. Updated test to also expect a warning along with the newly added error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files:

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

rsmith added inline comments. Comment at: clang/include/clang/AST/Expr.h:1062 +return ConstantExprBits.APValueKind != APValue::None && + ConstantExprBits.APValueKind != APValue::Indeterminate; } Why do we need to treat indeterminate values

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264084. serge-sans-paille added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/lib/CodeGen/CodeGenPGO.cpp

[PATCH] D79895: Fix warning about using uninitialized variable as function const reference parameter

zequanwu updated this revision to Diff 264076. zequanwu added a comment. Add new warning as subgroup of `Uninitialized`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 Files: clang/include/clang/Analysis/Analyses/UninitializedValues.h

[PATCH] D79935: [clang-format] [PR44345] Long namespace closing comment is duplicated endlessly

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Awesome! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79935/new/ https://reviews.llvm.org/D79935

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_mmla.c:17 + // CHECK: ret %[[RET]] + return SVE_ACLE_FUNC(svmmla, _s32, , )(x, y, z); +} sdesmalen wrote: > nit: please remove the whitespace between the commas

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

fpetrogalli updated this revision to Diff 264074. fpetrogalli marked 2 inline comments as done. fpetrogalli added a comment. Thank you for the review @sdesmalen! Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79639/new/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille created this revision. serge-sans-paille added reviewers: dexonsmith, zturner. serge-sans-paille added a project: clang. Herald added a subscriber: cfe-commits. Previous implementation was incorrectly passing an integer, that got converted to a pointer, to finalize the hash

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

dexonsmith added a comment. In D74813#2036966 , @alexbdv wrote: > @dexonsmith - Are you OK with that ? SGTM. I suggest @erik.pilkington lands the demangler patch before landing this so there isn't a window where we mangle something that can't be

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

dexonsmith added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:397 +return false; + return FE->getUID() == SourceFile.getUID(); +} arphaman wrote: > jkorous wrote: > > I don't really understand all the details here but shouldn't we use this

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM! Thanks Alex! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 ___ cfe-commits mailing

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

NoQ added a comment. In D79704#2036581 , @Szelethus wrote: > If something tricky like this came up, the `getDecl` function should just > return with a nullptr, shouldn't it? How far are you willing to push it? For instance, are you ok with, say,

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre added a comment. Ping :-) I'm looking for directions on what the next steps are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https://reviews.llvm.org/D77572 ___ cfe-commits mailing

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a3469f58d0c: [ObjC] Add compatibility mode for type checking of qualified id block… (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D79511?vs=263865=264058#toc Repository:

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1805 +const Expr *ProbArg = TheCall->getArg(2); +if (ProbArg->EvaluateAsFloat(Confidence, Context)) { + double P = Confidence.convertToDouble(); LukeZhuang wrote: > rsmith

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

vsapsai added a comment. Thanks everyone for reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79511/new/ https://reviews.llvm.org/D79511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 264048. arames edited the summary of this revision. arames added a comment. Rebase on top of tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files:

[clang] 6a3469f - [ObjC] Add compatibility mode for type checking of qualified id block parameters.

Author: Volodymyr Sapsai Date: 2020-05-14T12:08:19-07:00 New Revision: 6a3469f58d0c230e86043f6975f048968334dfa4 URL: https://github.com/llvm/llvm-project/commit/6a3469f58d0c230e86043f6975f048968334dfa4 DIFF:

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

alexbdv added a comment. @dexonsmith - Are you OK with that ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:397 +return false; + return FE->getUID() == SourceFile.getUID(); +} jkorous wrote: > I don't really understand all the details here but

[PATCH] D79834: Speed up preamble building by replacing the slow translateFile call by a new, faster isMainFile check

arphaman updated this revision to Diff 264044. arphaman added a comment. Added test and a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79834/new/ https://reviews.llvm.org/D79834 Files: clang/include/clang/Basic/SourceManager.h clang/lib/Basic/SourceManager.cpp

[PATCH] D79903: FastMathFlags.allowContract should be init from FPFeatures.allowFPContractAcrossStatement

mibintc marked an inline comment as done. mibintc added a comment. reply about the incorrect setting of 'fast' during OpenCL compilation with option -cl-fast-relaxed-math Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2943 + if (Opts.FastRelaxedMath) +

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

jyu2 added a comment. I don’t know what consequences is of using asm goto under SLH. In general, if asm-goto is not allowed, the diagnostic should be emitted during the parser. If asm-goto is not allowed under specified condition, the diagnostic should be emitted during sema. Diagnostic

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ecb51414637: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79916: Map -O to -O1 instead of -O2

MaskRay updated this revision to Diff 264029. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: dexonsmith, steven_wu, hiraditya. Update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

Xiangling_L accepted this revision. Xiangling_L added a comment. This revision is now accepted and ready to land. LGTM with a minor comment: You may want to add a `TODO` or `FIXME` at `clang/lib/CodeGen/TargetInfo.cpp: 4496` and `clang/lib/CodeGen/TargetInfo.cpp:4418` like: //FIXME: Correct

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

MaskRay updated this revision to Diff 264027. MaskRay edited the summary of this revision. MaskRay added a comment. -O => -O2 (temporarily, pending on the resolution of D79916 ) Add a test for -Ofast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

MaskRay marked an inline comment as done. MaskRay added a comment. Thanks for the review. Will remove D79916 as a parent and commit this one first. Comment at: clang/test/Driver/lto.c:52 +// RUN: %clang -target x86_64-unknown-linux-gnu

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. FWIW, we should directly add new runtime functions we emit into OMPKinds.def. That saves us the trouble of searching for the ones we missed later. Repository: rG LLVM Github

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker updated this revision to Diff 264023. Tyker added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76420/new/ https://reviews.llvm.org/D76420 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp

[PATCH] D79950: [clangd] Avoid wasteful data structures in RefSlab::Builder

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is worth another 10% or so on InedxBenchmark.DexBuild. Repository: rG LLVM

[clang] 5ecb514 - [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

Author: Fangrui Song Date: 2020-05-14T10:37:33-07:00 New Revision: 5ecb51414637402b0f89a96924ac7b015d23bcfa URL: https://github.com/llvm/llvm-project/commit/5ecb51414637402b0f89a96924ac7b015d23bcfa DIFF: https://github.com/llvm/llvm-project/commit/5ecb51414637402b0f89a96924ac7b015d23bcfa.diff

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

jbcoe planned changes to this revision. jbcoe added a comment. I will get the Google Style guide uploaded and update this patch with a link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79715/new/ https://reviews.llvm.org/D79715

[PATCH] D79919: [Driver] Pass -plugin-opt=O2 for -Os -Oz and -plugin-opt=O1 for -Og

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Driver/lto.c:52 +// RUN: %clang -target x86_64-unknown-linux-gnu --sysroot %S/Inputs/basic_cross_linux_tree %s \ +// RUN: -fuse-ld=lld -flto -O -###

[PATCH] D79257: [OPENMP50]Codegen for uses_allocators clause.

ABataev updated this revision to Diff 264020. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79257/new/ https://reviews.llvm.org/D79257 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

chill added a comment. I see. I can also count (`grep -rn '#include.*https://reviews.llvm.org/D79693/new/ https://reviews.llvm.org/D79693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

ZarkoCA added a comment. I'm ok with this now. I will let @Xiangling_L approve if she's ok with it since she had the last few comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 ___

[clang-tools-extra] 10b4931 - [test] NFC, add missing declarations and include to test files to avoid 'implicit-function-declaration' diagnostics in the tests

Author: Alex Lorenz Date: 2020-05-14T10:01:50-07:00 New Revision: 10b49315faa6338eaf52bb782e7c53644ad17dab URL: https://github.com/llvm/llvm-project/commit/10b49315faa6338eaf52bb782e7c53644ad17dab DIFF: https://github.com/llvm/llvm-project/commit/10b49315faa6338eaf52bb782e7c53644ad17dab.diff

[PATCH] D79788: AMDGPU/OpenCL: Accept -nostdlib in place of -nogpulib

arsenm closed this revision. arsenm added a comment. 235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79788/new/ https://reviews.llvm.org/D79788

[PATCH] D79677: [clang][OpenMP][OMPIRBuilder] Adding some Privatization clauses to OpenMP `parallel` Directive

fghanim marked 2 inline comments as done. fghanim added a comment. In D79677#2032942 , @jdoerfert wrote: > Generally you copied the existing Clang logic, correct? Well, Yes and no. I tried to keep as much as I can of the original implementation,

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

arsenm added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:699 + /// Tests whether the target is a GPU i.e. NVPTX or AMDGCN + bool isGPU() const { return isNVPTX() || isAMDGCN(); } + This is skipping out r600, and probably should leave this in

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a project: clang. Implemented codegen for reduction clauses with inscan modifiers in worksharing constructs. Emits the code for the directive with inscan

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

hubert.reinterpretcast added a comment. In D79693#2036599 , @chill wrote: > How do you trigger a problem? If your build was configured with `DEFAULT_SYSROOT` to a toolchain path that has a `/include` directory, then the contents of that directory would

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

fghanim marked 4 inline comments as done. fghanim added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:878 + [this, VDInit, OriginalAddr, VD, ThisFirstprivateIsLastprivate, + OrigVD, , IRef, ]() { // Emit private

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

fghanim updated this revision to Diff 264012. fghanim marked an inline comment as done. fghanim added a comment. updating in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79676/new/ https://reviews.llvm.org/D79676

[clang] 235fb7d - AMDGPU/OpenCL: Accept -nostdlib in place of -nogpulib

Author: Matt Arsenault Date: 2020-05-14T12:33:31-04:00 New Revision: 235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d URL: https://github.com/llvm/llvm-project/commit/235fb7dc24b1cf7034dfc76bb853ffb4ac5dec5d DIFF:

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

MyDeveloperDay added a comment. I'm ok with your suggestion if you want to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79000/new/ https://reviews.llvm.org/D79000 ___ cfe-commits mailing

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

MyDeveloperDay added a comment. I think we can abandon this revision now we support --style=file: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34252/new/ https://reviews.llvm.org/D34252 ___ cfe-commits mailing list

[PATCH] D79465: [clang-format] Fix line lengths w/ comments in align

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:417 +LineLengthAfter += Changes[j].TokenLength; +} unsigned ChangeMaxColumn = Style.ColumnLimit - LineLengthAfter; could you help us here with a comment, I

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Assuming you either work for google and understand their style or are qualified to say this is their style then this LGTM What I couldn't see from the link was where the

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

chill added a comment. I'm sorry, I don't understand the issue. Certainly it's the compiler (driver) responsibility to setup include paths according to the selected target. How do you trigger a problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added a comment. In D79704#2034571 , @NoQ wrote: > In D79704#2032947 , @Szelethus wrote: > > > In D79704#2032271 , @NoQ wrote: > > > > > Blanket reply!

  1   2   >