[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:18 +// CHECK-LD32-ARG-ORDER: "-bnocdtors" +// CHECK-LD32-ARG-ORDER: "-L[[SYSROOT]]/usr/lib" +// CHECK-LD32-ARG-ORDER: "-lc" The main point of the test being that `-

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Reverted in rG429f03089951d62fb370026905c87f1f25cf220f because its late and this is a breaking change to scan-build.

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClass()) { rjmccall wrote: > john.brawn

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

john.brawn updated this revision to Diff 265779. john.brawn retitled this revision from "[Sema] Diagnose static data members in classes nested in unnamed classes" to "[Sema] Diagnose more cases of static data members in local or unnamed classes". john.brawn edited the summary of this revision. jo

[PATCH] D80295: [Sema] Diagnose more cases of static data members in local or unnamed classes

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, looks great. Comment at: clang/lib/Sema/SemaDecl.cpp:6904 << Name << RD->getTagKind(); Invalid = true; +} else if (RD->isLocalClas

[PATCH] D80428: [clang] Optimize SourceManager::getFileIDLocal [WIP]

melver updated this revision to Diff 265780. melver retitled this revision from "[clang] Optimize getFileIDLocal [WIP]" to "[clang] Optimize SourceManager::getFileIDLocal [WIP]". melver edited the summary of this revision. melver added a comment. Improve code-gen further -- another ~5%. Reposit

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265781. stevewan added a comment. Address furthur comments on the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.c

[PATCH] D80454: [Clang] fix limiting -fintegrated-cc1 to only one TU

ychen planned changes to this revision. ychen added a comment. This may not be complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 ___ cfe-commits mailing

[PATCH] D80454: [Clang] fix limiting -fintegrated-cc1 to only one TU

ychen created this revision. ychen added a reviewer: aganea. Herald added a project: clang. Herald added a subscriber: cfe-commits. ychen planned changes to this revision. ychen added a comment. This may not be complete. For D74490 . For cases like where external

[PATCH] D80294: Add support for vmsumudm

This revision was automatically updated to reflect the committed changes. Closed by commit rGa28e9f120860: [PowerPC] Add support for vmsumudm (authored by saghir, committed by kamaub). Changed prior to commit: https://reviews.llvm.org/D80294?vs=265332&id=265790#toc Repository: rG LLVM Github

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 265788. atmnpatel added a comment. Herald added a subscriber: sstefan1. Updated tests and includes changes made by @ABataev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

craig.topper updated this revision to Diff 265787. craig.topper added a comment. Add -Wsign-conversion. Fix two test issues that exposed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251 Files: clang/lib/Headers/avx512bwintrin.h clang/lib/Hea

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen updated this revision to Diff 265791. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 Files: clang/test/Driver/cc1-spawnprocess.c Index: clang/test/Driver/cc1-spawn

[PATCH] D80454: [Clang][test] fix tests when using external assembler

aganea added a comment. Could you please attach a test to demonstrate the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 ___ cfe-commits mailing list cf

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen added a comment. In D80454#2051524 , @aganea wrote: > Could you please attach a test to demonstrate the issue? When a toolchain is not using integrated-as, the test would fail because using external assember would increase job counts. Most toolcha

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen updated this revision to Diff 265792. ychen added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80454/new/ https://reviews.llvm.org/D80454 Files: clang/test/Driver/cc1-spawnprocess.c Index: clang/test/Driver/cc1-spawn

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

ldionne added a comment. In D47092#2049842 , @efriedma wrote: > I think the preferred solution is something like > https://bugs.llvm.org/show_bug.cgi?id=37545#c4, which is slightly different > from both this patch and D46665

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors \ I am wonder

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() mati865 wrote: > thieta wrote: > > mstorsjo wrote: > > > If you say this is the same way it's done elsewhere, then sure - although

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:2648 +/// MatrixSubscriptExpr - Matrix subscript expression for the MatrixType +/// extension. +class MatrixSubscriptExpr : public Expr { Oh, that's interesting. So you've changed this to

[PATCH] D80454: [Clang][test] fix tests when using external assembler

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM. Are you planning on adding another patch for the change that you've sent initially? Ideally, I'd like to relax a bit that constraint in `Driver.cpp`, as in D74447

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors \

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/aix-ld.cpp:2 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and argument order. +// RUN: %clangxx -no-canonical-prefixes %s 2>&1 -### \ +// RUN: -Wl,-bnocdtors \ stevewan wr

[PATCH] D80454: [Clang][test] fix tests when using external assembler

MaskRay added a comment. In D80454#2051527 , @ychen wrote: > In D80454#2051524 , @aganea wrote: > > > Could you please attach a test to demonstrate the issue? > > > When a toolchain is not using integrated-as, the t

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

rjmccall added a comment. I think "the default value is on" is meant to imply that contraction is allowed by default, not that you can write the pragma without an `on-off-switch` and it means "on". FWIW, that would be consistent with C, which also enables contraction by default. CHANGES SINC

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

steveire added a comment. In D69764#2050538 , @MyDeveloperDay wrote: > In D69764#2050226 , @steveire wrote: > > > I like the approach of using clang-format to implement this. It's much > > faster than a `clang-tid

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen added a comment. In D80454#2051668 , @MaskRay wrote: > In D80454#2051527 , @ychen wrote: > > > In D80454#2051524 , @aganea wrote: > > > > > Could you please attach a te

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim marked 2 inline comments as done. fghanim added a comment. I am going to omit parts of the quote, because who wants to look at a wall of test - readability is important ;) In D79675#2051079 , @jdoerfert wrote: > In D79675#2047154

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. In D80369#2051278 , @dblaikie wrote: > @aprantl can you check here? I've attached two IR files for the > ModuleDebugInfo.m test, before/after ('x' is before), stripped of the > metadata numbers to make diffing easier - but I thin

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl added a comment. Hey @efriedma, thanks again for the comments. Yes, you were correct in that this message should only be emitted for relational comparisons. Regarding having the warning off by default, I did want to point out that GCC enables this warning by default: https://c.godbolt

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

tentzen marked 3 inline comments as done. tentzen added a comment. In D80344#2051127 , @lebedev.ri wrote: > This should likely be at least 3 patches: llvm middle-end, llvm codegen, > clang. > Langref changes missing for new intrinsics. > Please post all

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 265807. pestctrl added a comment. Changed error to warning, only emit during a relational operation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/incl

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265813. stevewan added a comment. Incorporate the test case into 'aix-ld.c'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.c

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

efriedma added a comment. Any thoughts on "this diagnostic needs to be restricted to C99 or earlier"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 ___ cfe-co

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

efriedma added a comment. Oh, you're right, sorry, the suggestion was to make asan instrumentation introduce the alias, not the frontend. In which case you'd want that fix plus D46665 , I think: external linkage optimizes better. Repository: rC Clang CHANG

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan added a comment. I'm planning to post an NFC patch after this to fix the formatting for existing cases in 'aix-ld.c' so that everything is consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D8041

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 265812. tentzen retitled this revision from "[Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)" to "[Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1". tentzen edited the summary of this revision. tentzen added a reviewer: lebedev.ri

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks. LGTM with minor nit. In D80415#2051772 , @stevewan wrote: > I'm planning to post an NFC patch after this to fix

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

lebedev.ri resigned from this revision. lebedev.ri added a comment. In D80344#2051697 , @tentzen wrote: > In D80344#2051127 , @lebedev.ri > wrote: > > > This should likely be at least 3 patches: llvm middle-end, ll

[clang] aa5d2d2 - Traverse-ignore invisible CXXConstructExprs with default args

Author: Stephen Kelly Date: 2020-05-23T01:04:44+01:00 New Revision: aa5d2d22485470365cc8f7016c1be672a273c2fe URL: https://github.com/llvm/llvm-project/commit/aa5d2d22485470365cc8f7016c1be672a273c2fe DIFF: https://github.com/llvm/llvm-project/commit/aa5d2d22485470365cc8f7016c1be672a273c2fe.diff

[clang] 8d62eba - Add some explicit use of TK_AsIs

Author: Stephen Kelly Date: 2020-05-23T01:04:44+01:00 New Revision: 8d62eba1053a4156032e5333ce0b1c6d33ca8ec5 URL: https://github.com/llvm/llvm-project/commit/8d62eba1053a4156032e5333ce0b1c6d33ca8ec5 DIFF: https://github.com/llvm/llvm-project/commit/8d62eba1053a4156032e5333ce0b1c6d33ca8ec5.diff

[clang] 26ac5a3 - Fix ignoring traversal of intermediate parens

Author: Stephen Kelly Date: 2020-05-23T01:04:44+01:00 New Revision: 26ac5a34bae7cb5b65e0580b317d4559af847ddb URL: https://github.com/llvm/llvm-project/commit/26ac5a34bae7cb5b65e0580b317d4559af847ddb DIFF: https://github.com/llvm/llvm-project/commit/26ac5a34bae7cb5b65e0580b317d4559af847ddb.diff

[PATCH] D80454: [Clang][test] fix tests when using external assembler

ychen added a comment. In D80454#2051637 , @aganea wrote: > LGTM. > > Are you planning on adding another patch for the change that you've sent > initially? Ideally, I'd like to relax a bit that constraint in `Driver.cpp`, > as in D74447

[PATCH] D80461: HIP: Try to deal with more llvm package layouts

arsenm created this revision. arsenm added reviewers: yaxunl, scchan. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. The various HIP builds are all inconsistent. The default llvm install goes to ${INSTALL_PREFIX}/bin/clang, but the rocm packaging scripts move this under ${INS

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

ychen added a comment. In D74447#1872211 , @thakis wrote: > I'd think that everyone debugging clang always passes a single TU to it, so > I'm not sure debuggability does much here :) > > The `-disable-free` code has never been used in normal compilations,

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. > It may be helpful (even for the reviewers) to first specify their behavior, > instead of writing that after-the-fact "backwardly" based on the > implementation. For reviewers, the purpose of those intrinsic are described in Summary section: - Two intrinsic are create

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan updated this revision to Diff 265818. stevewan added a comment. Update check prefix based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80415/new/ https://reviews.llvm.org/D80415 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 265819. tentzen removed a reviewer: lebedev.ri. tentzen added a comment. fixed tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/clan

[clang] 3a1f0c6 - Fix mistake made while rebasing

Author: Stephen Kelly Date: 2020-05-23T01:26:30+01:00 New Revision: 3a1f0c6bd1e09b6fd081ad83bb67228de83ac9b4 URL: https://github.com/llvm/llvm-project/commit/3a1f0c6bd1e09b6fd081ad83bb67228de83ac9b4 DIFF: https://github.com/llvm/llvm-project/commit/3a1f0c6bd1e09b6fd081ad83bb67228de83ac9b4.diff

[clang] 64356b6 - Add missing unit test

Author: Stephen Kelly Date: 2020-05-23T01:29:39+01:00 New Revision: 64356b6d94eac13780cc36ea12053d61a027561e URL: https://github.com/llvm/llvm-project/commit/64356b6d94eac13780cc36ea12053d61a027561e DIFF: https://github.com/llvm/llvm-project/commit/64356b6d94eac13780cc36ea12053d61a027561e.diff

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale created this revision. michele.scandale added reviewers: rjmccall, mibintc. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the support for changing the state of floating point optimizations within a code block, we need to make sure that the function at

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2051681 , @aprantl wrote: > In D80369#2051278 , @dblaikie wrote: > > > @aprantl can you check here? I've attached two IR files for the > > ModuleDebugInfo.m test, before/after ('

[PATCH] D80463: Debug Info: Mark os_log helper functions as artificial

aprantl created this revision. aprantl added reviewers: vsk, ahatanak, JDevlieghere, friss. aprantl added a project: debug-info. Herald added a subscriber: dexonsmith. aprantl edited the summary of this revision. The os_log helper functions are linkonce_odr and supposed to be uniqued across TUs,

[PATCH] D80464: [CUDA] Missing __syncthreads intrinsic in __clang_cuda_device_functions.h

bstaletic created this revision. bstaletic added a reviewer: aprantl. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. Seems like the `__syncthreads` is missing from the `clang/lib/Headers/__clang_cuda_device_functions.h` file. To be honest, I don't know much about C

[PATCH] D73037: Add a way to set traversal mode in clang-query

steveire updated this revision to Diff 265826. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73037/new/ https://reviews.llvm.org/D73037 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-extra/clang-que

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire updated this revision to Diff 265827. steveire added a comment. Touch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ParentMapContext

[PATCH] D80463: Debug Info: Mark os_log helper functions as artificial

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80463/new/ https://reviews.llvm.org/D80463 ___ cfe-commits mailing list cfe-commit

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145 + // referenced directly, without calling the thread-wrapper, so the linkage + // must not be changed. + // Is this a good idea? It seems to be making `constinit` part of the

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

rjmccall added a comment. `addrspacecast` might be a real conversion. I feel like this is really going well beyond what argument coercion should be expected to do, and we need to step back and re-evaluate how we're doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall added a comment. Would you mind separating these two patches? They don't seem have any interdependencies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 ___

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

hubert.reinterpretcast added subscribers: rsmith, hubert.reinterpretcast. hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145 + // referenced directly, without calling the thread-wrapper, so the linkage + // must not be changed. +

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11989 + else +return false; + I would suggest checking some preconditions and then just calling `PrepareScalarCast`. You should allow implicit conversions from class types, which somew

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

hliao marked an inline comment as done. hliao added a comment. In D80237#2051887 , @rjmccall wrote: > `addrspacecast` might be a real conversion. I feel like this is really going > well beyond what argument coercion should be expected to do, and we need

[PATCH] D80461: HIP: Try to deal with more llvm package layouts

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80461/new/ https://reviews.llvm.org/D80461 ___ cfe-commits mailing list cfe-

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

rjmccall added a comment. In D80237#2051909 , @hliao wrote: > In D80237#2051887 , @rjmccall wrote: > > > `addrspacecast` might be a real conversion. I feel like this is really > > going well beyond what argument c

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8880 + } +} + tambre wrote: > rjmccall wrote: > > Hmm. I'm concerned about not doing any sort of semantic compatibility > > check here before we assign the function special semanti

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145 + // referenced directly, without calling the thread-wrapper, so the linkage + // must not be changed. + // -

[clang] 1b02db5 - [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentation

Author: Craig Topper Date: 2020-05-22T20:12:57-07:00 New Revision: 1b02db52b79e01f038775f59193a49850a34184d URL: https://github.com/llvm/llvm-project/commit/1b02db52b79e01f038775f59193a49850a34184d DIFF: https://github.com/llvm/llvm-project/commit/1b02db52b79e01f038775f59193a49850a34184d.diff

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b02db52b79e: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter… (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

hliao added a comment. In D80237#2051918 , @rjmccall wrote: > In D80237#2051909 , @hliao wrote: > > > In D80237#2051887 , @rjmccall > > wrote: > > > > > `addrspacecast` migh

[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

rjmccall added a comment. Okay. Can you explain why we need to coerce in the first place, though? Especially if the representation is the same, why is your target-lowering requiring parameters to be coerced to involve pointers in a different address space? Repository: rG LLVM Github Monor

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

skan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80289/new/ https://reviews.llvm.org/D80289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

<    1   2