[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz updated this revision to Diff 274482. adamcz added a comment. Changed to just ignore undefs without matching def Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525 Files:

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

baloghadamsoftware added a comment. In D79431#2020951 , @Szelethus wrote: > Sure, this is an improvement because we display more information, but I'd > argue that it isn't really a more readable warning message :) How about > > th argument to the call to

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 274481. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82486/new/ https://reviews.llvm.org/D82486 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82880 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-print-int128.cpp Index:

[clang] 05c4794 - Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

Author: serge-sans-paille Date: 2020-06-30T15:13:53+02:00 New Revision: 05c479491c1d3236cae4eccaa3fcd2794598522c URL: https://github.com/llvm/llvm-project/commit/05c479491c1d3236cae4eccaa3fcd2794598522c DIFF:

[clang] 9945bd5 - Add Metadata to Transformer tooling

Author: Andy Soffer Date: 2020-06-30T15:03:07Z New Revision: 9945bd5911636e7f821ac82fdcf8fdb22126e7dc URL: https://github.com/llvm/llvm-project/commit/9945bd5911636e7f821ac82fdcf8fdb22126e7dc DIFF: https://github.com/llvm/llvm-project/commit/9945bd5911636e7f821ac82fdcf8fdb22126e7dc.diff LOG:

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane updated this revision to Diff 274450. erichkeane marked an inline comment as done. erichkeane added a comment. As @craig.topper suggested, extract the four lookups into 2 bool instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82562/new/ https://reviews.llvm.org/D82562

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:1 +// Tests that aix toolchain adds system includes to the search path + nit: aix->AIX nit: period at end of comment. Comment at:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.h:47 + /// This always produces a usable compiled fragment (errors are recovered). + explicit CompiledFragment(Fragment, DiagnosticCallback); +

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added a comment. True positive confirmed in //PostGreS//: Mailing List Archive . It is fixed by now, so you cannot see it on the link in my previous comment anymore.

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd285f29317d6: [AST][RecoveryExpr] Avoid spurious missing typename diagnostic when the NNS… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 833273a - [clang-tidy] Sanity checks in ClangTidyTest header.

Author: Nathan James Date: 2020-06-30T16:19:15+01:00 New Revision: 833273a81250213d3ba85ca5419d03155604ada2 URL: https://github.com/llvm/llvm-project/commit/833273a81250213d3ba85ca5419d03155604ada2 DIFF: https://github.com/llvm/llvm-project/commit/833273a81250213d3ba85ca5419d03155604ada2.diff

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. After this change, PGO builds of clang on Windows can no longer find `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could potentially make this seamless? Or is it expected that the burden is on the user to set up the paths manually during the

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274493. njames93 marked 2 inline comments as done. njames93 added a comment. Fix missing return statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return; Would it make sense to hoist this

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 marked 7 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274491. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

gribozavr updated this revision to Diff 274495. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82787/new/ https://reviews.llvm.org/D82787 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. In D82663#2117451 , @rjmccall wrote: > Why not legalize to the signed operation? My feeling was that it wasn't right do so in LLVM, because LLVM has no notion of the padding bit and therefore doesn't really care about Clang's

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske added a comment. I checked it with simple debug print, the `LeakedSyms` will contain 2 items with different `StreamOpenNode`. So I think these should be independent problem reports for the bug reporter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

riccibruno added inline comments. Comment at: clang/test/Sema/init-ref-c.c:8 +} \ No newline at end of file ArcsinX wrote: > riccibruno wrote: > > I think it would be better to name this test `varargs-arm.c` since this bug > > can only happen with the

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274496. lh123 added a comment. Add the missing `operator!=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274503. sammccall added a comment. CompiledFragment becomes a std::function, compile interface moved to Fragment.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. In D65543#2123200 , @dmajor wrote: > In that case, more specifically, the problem I'm seeing is that these flags > are not making it through to a small handful of files: LLVMHello.dll, > PrintFunctionNames.dll,

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f4e48c4aca: [clang][docs] Add note about using `-flto` with `-g` on macOS (authored by phil-blain, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang updated this revision to Diff 274541. dang added a comment. Move the call to `UseANSIEscapeCodes` to `CreateFromArgs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files:

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

vabridgers updated this revision to Diff 274542. vabridgers added a comment. fix pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82882/new/ https://reviews.llvm.org/D82882 Files: clang/lib/AST/ASTImporterLookupTable.cpp Index:

[PATCH] D82889: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent

gribozavr2 added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:416 +if (!Queue && getDerived().shouldTraversePostOrder()) \ + TRY_TO(WalkUpFromUnary##NAME(S)); \ return true;

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

vabridgers created this revision. vabridgers added a reviewer: martong. Herald added subscribers: cfe-commits, teemperor, rnkovacs, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a project: clang. Running CTU testing, we found that VisitFriendDecl in ASTImporterLookup.cpp was not

[clang-tools-extra] 2efba0e - [clang-tidy] performance-faster-string-find string-view

Author: Nathan James Date: 2020-06-30T16:45:59+01:00 New Revision: 2efba0e8122aeca29f878c0e3056a4552d20c720 URL: https://github.com/llvm/llvm-project/commit/2efba0e8122aeca29f878c0e3056a4552d20c720 DIFF: https://github.com/llvm/llvm-project/commit/2efba0e8122aeca29f878c0e3056a4552d20c720.diff

[clang] a1f4e48 - [clang][docs] Add note about using `-flto` with `-g` on macOS

Author: Philippe Blain Date: 2020-06-30T09:33:20-07:00 New Revision: a1f4e48c4aca8c7339be2018926baf860a562f13 URL: https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13 DIFF:

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch upstreams support for the Arm-v8 Cortex-A77 processor for AArch64 and ARM. In

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. This amused me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82832/new/ https://reviews.llvm.org/D82832

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

Szelethus added a comment. In D82845#2122984 , @balazske wrote: > I checked it with simple debug print, the `LeakedSyms` will contain 2 items > with different `StreamOpenNode`. So I think these should be independent > problem reports for the bug

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. In D65543#2122942 , @dmajor wrote: > After this change, PGO builds of clang on Windows can no longer find > `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could > potentially make this seamless? Or is it expected

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 274519. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman added a comment. In D82825#2123125 , @njames93 wrote: > In D82825#2122789 , @aaron.ballman > wrote: > > > Other than the documentation and settling on the option name in the parent > > revision, I

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return; njames93 wrote: > aaron.ballman

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

JonChesterfield added a comment. This patch declares the clang builtin as acting on signed values, but the IR intrinsic maps to an instruction which does an unsigned comparison. We don't have ISA support for a signed comparison equivalent. Addition is the same operation on signed or unsigned

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

baloghadamsoftware added a comment. In D82845#2122984 , @balazske wrote: > I checked it with simple debug print, the `LeakedSyms` will contain 2 items > with different `StreamOpenNode`. So I think these should be independent > problem reports for the

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return;

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

Szelethus added a comment. In D82845#2123283 , @baloghadamsoftware wrote: > In D82845#2122984 , @balazske wrote: > > > I checked it with simple debug print, the `LeakedSyms` will contain 2 items > > with

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have

[PATCH] D82901: [libTooling] Fix `maybeExtendRange` to support `CharRange`s.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added a project: clang. ymandel added a subscriber: gmatute. Currently, `maybeExtendRange` takes a `CharSourceRange`, but only works correctly for the `TokenRange` case. This change adds proper support for the `CharRange`

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

clementval added a comment. In D81098#2112159 , @ABataev wrote: > LG Since this revision landed two tests are failing. ` libomp.env::kmp_set_dispatch_buf.c` and `libomp.worksharing/for::kmp_set_dispatch_buf.c`. It was also reported on the mailing

[PATCH] D82900: [analyzer][Z3-refutation] Add statistics tracking invalidated bug report classes

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, Szelethus, martong. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Counts

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

lei added a comment. encoding tests need to be placed in corresponding `ppc64-encoding-ISA31*` files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

This revision was automatically updated to reflect the committed changes. Closed by commit rGa06a5ed97800: [clang-tidy] Added option to readability-else-after-return (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82824?vs=274473=274569#toc Repository: rG LLVM

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. In D82825#2123186 , @aaron.ballman wrote: > I can see arguments either way on this. Personally, I would not want the > check to diagnose this code because that would encourage people to widen the > scope and lifetime of `X` or

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks Vince, looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82882/new/ https://reviews.llvm.org/D82882

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

martong accepted this revision. martong added a comment. Ok, I checked and it seems the parent map context is used only by the AST matchers, and this is okay because it looks like there is not any storing or caching of the parent map objects (the type is never copied). Repository: rG LLVM

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. ellis added a reviewer: clang-tools-extra. The block arguments in `dispatch_async()` and `dispatch_after()` are guaranteed to escape. If those blocks capture any pointers with the

[PATCH] D82815: [clang-tidy] Sanity checks in ClangTidyTest header.

This revision was automatically updated to reflect the committed changes. Closed by commit rG833273a81250: [clang-tidy] Sanity checks in ClangTidyTest header. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82815/new/

[PATCH] D82626: [CodeComplete] Tweak completion for else.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82626/new/ https://reviews.llvm.org/D82626

[PATCH] D82767: clang-format: Explicitly use python3

compnerd added a comment. While I really like this idea of migrating the scripts to python3, I believe that the current plan is to allow until December for users to migrate, so this might be a bit premature :-(. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82767/new/

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

This revision was automatically updated to reflect the committed changes. Closed by commit rG2efba0e8122a: [clang-tidy] performance-faster-string-find string-view (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82720?vs=274200=274512#toc Repository: rG LLVM Github

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return;

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, after mine and Aaron's comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19195-19211 +if (Spec == AvailSpecs.end()) + return None; +if

[PATCH] D82889: Make RecursiveASTVisitor call WalkUpFrom for operators when the data recursion queue is absent

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: eduucaldas, ymandel, rsmith. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82889 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

gribozavr updated this revision to Diff 274497. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82787/new/ https://reviews.llvm.org/D82787 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82626: [CodeComplete] Tweak completion for else.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ba4867c2700: [CodeComplete] Tweak completion for else. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82626/new/

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

steakhal updated this revision to Diff 274510. steakhal added a comment. - adds statistic to undecidable branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82856/new/ https://reviews.llvm.org/D82856 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. Another point is, if we for example have an i16 umul.fix in legalization, we have no way of knowing in the general case that it is safe to replace it with an smul.fix, since the information that the MSB is not significant does not exist on IR level. This is the 'loss

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:969 + // Do not warn for non-closed stream at program exit. + if (Pred && Pred->getCFGBlock() &&

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Thanks, it LGTM now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://reviews.llvm.org/D82185 ___ cfe-commits

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

ributzka accepted this revision. ributzka added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/ https://reviews.llvm.org/D80751 ___ cfe-commits mailing list

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. In D82825#2122789 , @aaron.ballman wrote: > Other than the documentation and settling on the option name in the parent > revision, I think this LGTM (the changes will be mechanical and can be done > without further review once

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags Flags, njames93

[PATCH] D82767: clang-format: Explicitly use python3

arsenm added a comment. In D82767#2123024 , @compnerd wrote: > While I really like this idea of migrating the scripts to python3, I believe > that the current plan is to allow until December for users to migrate, so > this might be a bit premature :-(.

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM once the documentation nit is fixed up. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a subscriber: kkwli0. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson added a comment. In D82887#2123364 , @dmgreen wrote: > Please make sure the switch in AArch64Subtarget::initializeProperties has an > entry too. > > Do you happen to know the cpu id for host.cpp? do you mean the CPU part number used in e.g

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2, hokein. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Handle insertion fix-its when removing incompatible errors by introducting a new EventType

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

hiraditya added a comment. Nice find! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82832/new/ https://reviews.llvm.org/D82832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82898: [clang-tidy] Handled insertion only fixits when determining conflicts.

njames93 marked an inline comment as done. njames93 added a comment. Herald added a subscriber: wuzish. I've not added any specific unit tests for this, Don't think there would be much gained from them. The init-variables and isolate-declaration checks do a good enough job of demonstrating the

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a comment. In D80833#2109172 , @uweigand wrote: > Hmm, with clang-cl it seems the driver is trying to use this: > Target: s390x-pc-windows-msvc > which of course doesn't exist. Not sure what is supposed to be happening > here, but it

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3537939cda86: [X86] Move frontend CPU feature initialization to a look up table based… (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D82731?vs=274161=274586#toc

[clang] 8ba4867 - [CodeComplete] Tweak completion for else.

Author: Nathan James Date: 2020-06-30T16:48:24+01:00 New Revision: 8ba4867c27000ee029ab70a1194050d884fce6c7 URL: https://github.com/llvm/llvm-project/commit/8ba4867c27000ee029ab70a1194050d884fce6c7 DIFF: https://github.com/llvm/llvm-project/commit/8ba4867c27000ee029ab70a1194050d884fce6c7.diff

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko updated this revision to Diff 274504. atrosinenko added a comment. - Rebase onto an up-to-date upstream commit - Recheck against v9.2.0 - Misc fixes and improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2856-2857 Optional IsSAT = RefutationSolver->check(); if (!IsSAT.hasValue()) return; I strongly recommend a statistic for this branch as well. I.e., how

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thank you! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6278 + return true; +// FIXME(liuhui): Ideally, we should check the ctor parameter list to +

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

NoQ added a comment. > I have one question though. Isn't this counting all the reports in an > equivalence class? Yes it is. You have no choice but to run refutation before deduplication; otherwise the otherwise-best report in the class may be false when other reports are true. CHANGES

[PATCH] D82891: [clangd] Fix race in FileIndex that sometimes temporarily lost updates.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. FileIndex was built out of threadsafe components, so update() didn't have data races, but wasn't

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debugify-each-original.c:9 + +// RUN: rm -rf %t.json +// RUN: %clang -g -Xclang -fenable-debugify-each-original \ I

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the fix I mentioned. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3629 #undef MERGE_ASSIGN_VALUE +

[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM with comment addressed. Comment at: clang/lib/Basic/Targets/AArch64.cpp:325 + if ((FPU & SveMode) && HasMatmulInt8) +

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

dmgreen added reviewers: dmgreen, ostannard, SjoerdMeijer. dmgreen added a comment. Please make sure the switch in AArch64Subtarget::initializeProperties has an entry too. Do you happen to know the cpu id for host.cpp? Comment at: clang/test/Driver/aarch64-cpus.c:729 +//

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

This revision was automatically updated to reflect the committed changes. Closed by commit rG89a0c4066b0e: [clang][diagnostics] Add -Wundef-prefix warning option (authored by zixuw, committed by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Petr, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 274589. yaxunl retitled this revision from "[CUDA][HIP] Let non-caputuring lambda be host device" to "[CUDA][HIP] Let lambda be host device by default". yaxunl edited the summary of this revision. yaxunl added a comment. Added diagnostics for capturing host

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

hokein added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + sammccall wrote: > hokein wrote: > > I think if this case happened,

[PATCH] D82908: [SVE] ACLE: Fix builtins for svdup_lane_bf16 and svcvtnt_bf16_f32_x

sdesmalen created this revision. sdesmalen added a reviewer: fpetrogalli. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. bfloat16 variants of svdup_lane were missing, and svcvtnt_bf16_x was implemented

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:65 +if (F.HasUnrecognizedCondition) + Conditions.push_back([&](const Params &) { return false; }); + hokein wrote: > sammccall wrote: > > hokein wrote: > > > I think

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274623. sammccall marked 13 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files:

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274622. ellis added a comment. Add double backtick to doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files:

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

nemanjai accepted this revision. nemanjai added a comment. As far as I'm concerned, this is fine for now. We can remove these once all in-tree target have implemented their support. LGTM but maybe give a couple of days for others to chime in. Comment at:

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100 + + Finds pointers with the `noescape` attribute that are captured by an + asynchronously-executed block. Please use double back-ticks for language constructs.

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis updated this revision to Diff 274618. ellis added a comment. Applied changes suggested in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82904/new/ https://reviews.llvm.org/D82904 Files:

<    1   2   3   >