[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

hokein added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:14 // CHECK-NEXT: `-TemplateArgument {{.*}} type 'int' template R> Foo(R) requires(true); could you also verify what's the end loc for this case? Repository: rG LLVM

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added a comment. Thanks for the update @HsiangKai. I've noticed that we aren't handling the exceptions that state that the `V0` constraint shouldn't be enforced for instructions that generate masks or for reductions. For instance the following (valid) instructions are rejected:

[clang-tools-extra] 40d11a8 - ClangdMain.cpp: this #ifdef should be an #if

Author: Hans Wennborg Date: 2020-07-27T14:05:02+02:00 New Revision: 40d11a878044711708fb6738e4b78a4c9ac3de7b URL: https://github.com/llvm/llvm-project/commit/40d11a878044711708fb6738e4b78a4c9ac3de7b DIFF: https://github.com/llvm/llvm-project/commit/40d11a878044711708fb6738e4b78a4c9ac3de7b.diff

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG90684d154516: [clangd] Collect references for externally visible main-file symbols (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 90684d1 - [clangd] Collect references for externally visible main-file symbols

Author: Aleksandr Platonov Date: 2020-07-27T15:35:53+03:00 New Revision: 90684d1545167ee4e0c93d8eaf6ba4a3c7ab710e URL: https://github.com/llvm/llvm-project/commit/90684d1545167ee4e0c93d8eaf6ba4a3c7ab710e DIFF:

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

erichkeane added a comment. Based on richard's suggestions, that seems about right. However I believe all the asserts should have a message to go along with them as we typicaly do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/

[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

riccibruno added a comment. > Will do. By the way, is there something more tailored than ninja check-clang > to run these ast-dump tests? ninja check-clang takes quite a while to run... You can use `check-clang-ast` for the lit tests in `AST/`, `check-clang-sema` for the lit tests in `Sema/`

[clang-tools-extra] 13c9bbc - [clang-tidy] Refactor IncludeInserter

Author: Nathan James Date: 2020-07-27T12:48:55+01:00 New Revision: 13c9bbc28ef9cf9976a0962e6c930a7dfc52c877 URL: https://github.com/llvm/llvm-project/commit/13c9bbc28ef9cf9976a0962e6c930a7dfc52c877 DIFF: https://github.com/llvm/llvm-project/commit/13c9bbc28ef9cf9976a0962e6c930a7dfc52c877.diff

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

This revision was automatically updated to reflect the committed changes. Closed by commit rG13c9bbc28ef9: [clang-tidy] Refactor IncludeInserter (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83680/new/

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a crash when evaluating a constexpr function which contains recovery-exprs. https://bugs.llvm.org/show_bug.cgi?id=46837 Would be nice to have constant expression evaluator support general

[PATCH] D83817: [clangd] Add option to use remote index as static index

hans added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:702 } + if (RemoteIndexAddress.empty() != ProjectPath.empty()) { +llvm::errs() << "remote-index-address and project-path have to be " hokein wrote: > the new code

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane added a comment. Ping! I believe I've done all of the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/ https://reviews.llvm.org/D84048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

lei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14156 + + // This transformation is only valid if the we are loading either a byte, + // halfword, word, or doubleword. Conanap wrote: > NeHuang wrote: > > nit: if we are

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280840. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve the remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280846. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Move back to duplicated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files:

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev marked 3 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:73 private: + template kbobyrev wrote: > sammccall wrote: > > you don't need both RequestT and ClangdRequest as

[clang-tools-extra] f49a7ad - [clangd] Add marshalling code for all request types

Author: Kirill Bobyrev Date: 2020-07-27T14:16:03+02:00 New Revision: f49a7ad8c0854a01b945c27de2fd313b9013ae0d URL: https://github.com/llvm/llvm-project/commit/f49a7ad8c0854a01b945c27de2fd313b9013ae0d DIFF:

[PATCH] D84525: [clangd] Add marshalling code for all request types

This revision was automatically updated to reflect the committed changes. Closed by commit rGf49a7ad8c085: [clangd] Add marshalling code for all request types (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/

[clang-tools-extra] 08e9556 - llvm_canonicalize_cmake_booleans(CLANGD_ENABLE_REMOTE)

Author: Hans Wennborg Date: 2020-07-27T14:42:04+02:00 New Revision: 08e9556d5d77fb424b8cb99fe16ffe2bc77f555e URL: https://github.com/llvm/llvm-project/commit/08e9556d5d77fb424b8cb99fe16ffe2bc77f555e DIFF: https://github.com/llvm/llvm-project/commit/08e9556d5d77fb424b8cb99fe16ffe2bc77f555e.diff

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM apart from templated-lambdas. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:86 +unsigned FailedToSend = 0; +Index->lookup(Req,

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb marked an inline comment as done. krisb added a comment. @phosek thank you for reviewing this! Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER

[PATCH] D83817: [clangd] Add option to use remote index as static index

hans added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@ I'm guessing this should be @CLANGD_ENABLE_REMOTE@ The gn build was upset:

[clang-tools-extra] 47a0254 - Speculative build fix for clangd/Features.inc.in

Author: Hans Wennborg Date: 2020-07-27T13:39:54+02:00 New Revision: 47a0254229ca425aa4e169c2db14e92b8db86784 URL: https://github.com/llvm/llvm-project/commit/47a0254229ca425aa4e169c2db14e92b8db86784 DIFF: https://github.com/llvm/llvm-project/commit/47a0254229ca425aa4e169c2db14e92b8db86784.diff

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280831. MForster added a comment. Rename test back to ns_error_enum.m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

riccibruno added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -std=c++2a -ast-dump -ast-dump-filter Foo %s | FileCheck -strict-whitespace %s + Can you also test for serialization by

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb updated this revision to Diff 280835. krisb added a comment. Addressed the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/ https://reviews.llvm.org/D80873 Files: clang/CMakeLists.txt

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280848. kbobyrev added a comment. Fix code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! numbers and the patch LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84513/new/ https://reviews.llvm.org/D84513

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280853. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added reviewers: RKSimon, SjoerdMeijer, dexonsmith, rjmccall. Kai added a comment. Still looking for opinions on the clang part! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits

[PATCH] D84525: [clangd] Add marshalling code for all request types

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for bearing with me, LGTM! Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:277 + clangd::LookupRequest Request; + auto ID =

[PATCH] D84525: [clangd] Add marshalling code for all request types

kadircet added a comment. mostly LG. sorry for lots of nits, only two important bits are changing the {1} to {0} in logs, wrapping symbolid generations in `llvm::cantFail` and making sure `Deserialized` is exactly the same thing as `Request` in tests. feel free to ignore the rest (I should've

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280862. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[clang-tools-extra] 529441e - Fix another #ifdef CLANGD_ENABLE_REMOTE

Author: Hans Wennborg Date: 2020-07-27T14:11:29+02:00 New Revision: 529441e88e81a2e7dae6108e3d95e043c670e1a6 URL: https://github.com/llvm/llvm-project/commit/529441e88e81a2e7dae6108e3d95e043c670e1a6 DIFF: https://github.com/llvm/llvm-project/commit/529441e88e81a2e7dae6108e3d95e043c670e1a6.diff

Re: [PATCH] D83817: [clangd] Add option to use remote index as static index

Uh, you're right, thank you for the fix! I wonder why that was building for me... Again, thank you for noticing! Kirill On Mon, Jul 27, 2020 at 2:41 PM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added inline comments. > > > > Comment at:

Re: [PATCH] D83817: [clangd] Add option to use remote index as static index

Ah, that's why... Thank you again and apologies for inconovinience! On Mon, Jul 27, 2020 at 3:06 PM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added inline comments. > > > > Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:702 >} > + if

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5328 + if (!IdentLoc || !IdentLoc->Ident) { +// Try to locate the argument directly +SourceLocation Loc = AL.getLoc(); Comments should be grammatical including punctuation

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:73 private: + template sammccall wrote: > you don't need both RequestT and ClangdRequest as template params: > - the things you're currently doing are all

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280812. kbobyrev marked 14 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files:

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff updated this revision to Diff 280827. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 Files: clang/include/clang/Driver/Compilation.h

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff updated this revision to Diff 280796. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 Files: clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 280797. nridge marked an inline comment as done. nridge added a comment. Herald added a subscriber: mgorny. Finish addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:426 + + // constrained-parameter + Code = R"cpp( I'd like to keep this clangd-specific test coverage as I think it's

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280819. kbobyrev added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[clang-tools-extra] 974ffee - [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

Author: Kirill Bobyrev Date: 2020-07-27T10:44:23+02:00 New Revision: 974ffee9ccd70703c6edb880ac4934a5dc12e56d URL: https://github.com/llvm/llvm-project/commit/974ffee9ccd70703c6edb880ac4934a5dc12e56d DIFF:

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

This revision was automatically updated to reflect the committed changes. kbobyrev marked an inline comment as done. Closed by commit rG974ffee9ccd7: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Adding output files property is a prerequisite for D78903 (Add option -fproc-stat-report). Despite large size of the patch, the change is very simple: it only adds new state variable `OutputFilenames` initialized by the new parameter

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 280810. saiislam added a comment. Generalized regex in one of the test to pass harbormaster build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files:

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280820. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[PATCH] D83817: [clangd] Add option to use remote index as static index

hokein added a comment. mostly good, just a concern about the linking dependence. Comment at: clang-tools-extra/clangd/CMakeLists.txt:143 clangToolingSyntax + clangdRemoteIndex ) the dependence here seems to be a layer violation. we add remote-index

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280828. MForster marked 3 inline comments as done. MForster added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files:

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280829. MForster marked an inline comment as done. MForster added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files:

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang/test/Sema/ns_error_enum.c:25 + +const char *MyErrorDomain; +typedef NS_ERROR_ENUM(unsigned char, MyErrorEnum, MyErrorDomain) { gribozavr2 wrote: > const char * =>

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280806. MForster added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td

[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny. Herald added a reviewer: MaskRay. Herald added projects: clang, LLDB, LLVM. This preprocessor define was meant to be used to conditionally include headers

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev marked 5 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:159 Deserialized = ProtobufMarshaller.fromProtobuf(*Serialized); EXPECT_TRUE(Deserialized); kbobyrev

[PATCH] D83817: [clangd] Add option to use remote index as static index

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

MyDeveloperDay added a comment. a new minor Nits but looks good. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1488 (Style.ExperimentalAutoDetectBinPacking && - (Current.PackingKind == PPK_OnePerLine || + (Current.getPackingKind() ==

[PATCH] D84622: [PowerPC] Implement Vector Extract Low/High Order Builtins in LLVM/Clang

biplmish created this revision. biplmish added reviewers: amyk, lei, steven.zhang, PowerPC. Herald added subscribers: cfe-commits, shchenz, wuzish, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. This patch implements builtins for the following prototypes: vector unsigned long

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280822. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files:

[PATCH] D84525: [clangd] Add marshalling code for all request types

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:111 + Req.IDs = std::move(*IDs); + Req.Filter = static_cast(Message->filter()); + if (Message->limit()) can you also add tests for these? (well

[clang-tools-extra] 37ac559 - [clangd] Add option to use remote index as static index

Author: Kirill Bobyrev Date: 2020-07-27T11:24:15+02:00 New Revision: 37ac559fccd46dcec246ceb3907c8d3910728c69 URL: https://github.com/llvm/llvm-project/commit/37ac559fccd46dcec246ceb3907c8d3910728c69 DIFF:

[PATCH] D83817: [clangd] Add option to use remote index as static index

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ac559fccd4: [clangd] Add option to use remote index as static index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/

[PATCH] D84005: Introduce ns_error_domain attribute.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:3340 + +const char *MyErrorDomain; +typedef NS_ERROR_ENUM(unsigned char, MyErrorEnum, MyErrorDomain) {

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev planned changes to this revision. kbobyrev added a comment. As discussed in PM, should move back to duplicated code  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 ___

[PATCH] D84136: [clangd] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1843 + if (const auto *TC = D->getTypeConstraint()) { +TRY_TO(TraverseStmt(TC->getImmediatelyDeclaredConstraint()));

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 280804. MForster marked 8 inline comments as done. MForster edited the summary of this revision. MForster added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. I have updated the attribute documentation to include the additional information provided by Doug. I think adding additional diagnostics would rather be separate changes. I think I have addressed all remaining review comments. Comment at:

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks. Could you elaborate on the lldb issue? I'd like to take a look at that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84520: [Analyzer] Improve invalid dereference bug reporting in DereferenceChecker.

balazske added a comment. Change of the existing error messages and checker category is not necessary but it would be improvement because more the uniform error messages. (And not the "logic error" is the best category for this checker, if this value is used at all. Other checkers have bad

[PATCH] D84315: [libTooling] Add a `between` range-selector combinator.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/RangeSelector.h:59 +/// Convenience constructor of the range between two ranges. +inline RangeSelector

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Background: --- There are two related argument types which can be sent into a diagnostic to display the name of an

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280899. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. - Answer code review - Simpler logic for `getUnqualifiedIdSourceRange` and inline it - Remove ambiguously named variable NNS Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics.

riccibruno added a comment. In D84656#2175813 , @erichkeane wrote: > I looked through the code changes, and they all seem quite mechanical. I > believe they are all correct. > > After reading through the test changes, I believe that this change is >

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas marked 2 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:834 + // FIXME: I feel like this could be upstreamed. + SourceRange getUnqualifiedIdSourceRange(DeclRefExpr *S) { +if

[PATCH] D81865: use string tables for static diagnostic descriptions

froydnj added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

sberg added inline comments. Comment at: clang/include/clang/AST/Expr.h:513 - /// isIntegerConstantExpr - Return true if this expression is a valid integer - /// constant expression, and, if so, return its value in Result. If not a - /// valid i-c-e, return false and fill

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

erichkeane added a comment. This seems like a strict improvement as well. That said, there are two opportunities to clean up the code that I suggest evaluating. Comment at: clang/lib/AST/Decl.cpp:2032 + // additional complexity needed to prevent this is not worthwhile. +

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. In D66035#2175906 , @vchuravy wrote: > In D66035#2175839 , @pmatos wrote: > > > I am interested in continuing this work and have a patch in progress based > > on the current available one

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4609 +// their own llvm.global_dtors entry. +CGM.AddCXXStermFinalizerToGlobalDtor(StermFinalizer, 65535); + else Handling template instantiation seems fairly orthogonal to

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked 3 inline comments as done. MForster added a comment. Two clarifying questions... Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident));

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. I am interested in continuing this work and have a patch in progress based on the current available one here. Should I post the new patch here or under a new bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

erichkeane added inline comments. Comment at: clang/lib/AST/Decl.cpp:2032 + // additional complexity needed to prevent this is not worthwhile. + OS << (Policy.MSVCFormatting ? '`' : '(') + << (IsAnonymousStructOrUnion ? "anonymous" : "unnamed") << ' '

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno marked 2 inline comments as done. riccibruno added inline comments. Comment at: clang/lib/AST/Decl.cpp:2032 + // additional complexity needed to prevent this is not worthwhile. + OS << (Policy.MSVCFormatting ? '`' : '(') + << (IsAnonymousStructOrUnion ?

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman added a comment. In D83501#2173534 , @sammccall wrote: > (Sorry this has been pending a while - I think it's basically there. Only > things we really need to address to land this is have a consistent view of > what the canonical decl is for the

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 280930. dgoldman marked 7 inline comments as done. dgoldman added a comment. - More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D84666: [NFC] Sema: use checkArgCount instead of custom checking

jfb created this revision. jfb added a reviewer: rsmith. Herald added subscribers: cfe-commits, ributzka, dexonsmith, jkorous, kbarton, nemanjai. Herald added a project: clang. As requested in D79279 . Repository: rG LLVM Github Monorepo

[PATCH] D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84564/new/ https://reviews.llvm.org/D84564

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

hokein updated this revision to Diff 280890. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84461/new/ https://reviews.llvm.org/D84461 Files:

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L updated this revision to Diff 280897. Xiangling_L added a comment. Fix clang-tidy errors; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 Files: clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CodeGenModule.h

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); MForster wrote: > aaron.ballman wrote: > > Shouldn't we also be

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman, erichkeane. riccibruno added a project: clang. Herald added subscribers: cfe-commits, arphaman, dexonsmith. See D84656 for the background on `NamedDecl::printName`. This patch

[PATCH] D81865: use string tables for static diagnostic descriptions

riccibruno added a comment. Add some reviewers based on `git diff --name-only | xargs -n 1 git blame --porcelain | grep "^author " | sort | uniq -c | sort -nr | head -30`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

balazske added a comment. From the beginning on in this patch I assumed that the location of the bug report should be the end of the bug path. But this is probably a wrong approach, specially if the bug report has uniqueing location. In that case the uniqueing location may be a better place

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

logan-5 added a comment. In D84554#2175012 , @labath wrote: > Could you elaborate on the lldb issue? I'd like to take a look at that... It looks like lldb/unittests/TestingSupport/CMakeLists.txt and lldb/unittests/TestingSupport/Symbol/CMakeLists.txt

[clang] a52aea0 - Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

Author: Logan Smith Date: 2020-07-27T08:37:01-07:00 New Revision: a52aea0ba624fcf46602bff8463b7b831e87ba55 URL: https://github.com/llvm/llvm-project/commit/a52aea0ba624fcf46602bff8463b7b831e87ba55 DIFF: https://github.com/llvm/llvm-project/commit/a52aea0ba624fcf46602bff8463b7b831e87ba55.diff

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

This revision was automatically updated to reflect the committed changes. Closed by commit rGa52aea0ba624: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that… (authored by logan-5). Changed prior to commit: https://reviews.llvm.org/D84554?vs=280564=280933#toc

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl updated this revision to Diff 280938. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[CUDA][HIP] Defer all diagnostics for host device functions" to "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions". yaxunl edited the summary of

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. AFAIK, BuiltinBug is deprecated and we should be using BugType anyway. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >