LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] fb5588b - [clangd] Propagate remote index errors via Expected

Author: Kirill Bobyrev Date: 2020-07-31T11:48:32+02:00 New Revision: fb5588b0ad59522031d037b0d1a3fdcf8ada8a79 URL: https://github.com/llvm/llvm-project/commit/fb5588b0ad59522031d037b0d1a3fdcf8ada8a79 DIFF:

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if

[clang-tools-extra] 0d25d3b - [clang-tidy] Fix build problem after commit 45a720a864320bbbeb596a

Author: Bjorn Pettersson Date: 2020-07-31T14:29:03+02:00 New Revision: 0d25d3b7e3e3acb86d93acb2291c1d26e056746b URL: https://github.com/llvm/llvm-project/commit/0d25d3b7e3e3acb86d93acb2291c1d26e056746b DIFF:

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim added a comment. In D6#2187334 , @myfreeweb wrote: > In D6#2187273 , @dim wrote: > >>> +#ifdef __FreeBSD__ >>> + return __FreeBSD_version / 10; >>> +#else >>> + return 10; >>> +#endif

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 282166. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Good points, thanks! Addressed post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5588b0ad59: [clangd] Propagate remote index errors via Expected (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1618828 - [clang][Syntax] syntax::Arena doesnt own TokenBuffer

Author: Kadir Cetinkaya Date: 2020-07-31T11:50:01+02:00 New Revision: 161882816540fc011554e4a820ab896278491b6a URL: https://github.com/llvm/llvm-project/commit/161882816540fc011554e4a820ab896278491b6a DIFF:

[PATCH] D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG161882816540: [clang][Syntax] syntax::Arena doesnt own TokenBuffer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84973/new/

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos updated this revision to Diff 282194. pmatos added a comment. Update externref patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/ https://reviews.llvm.org/D66035 Files: clang/lib/Basic/Targets/WebAssembly.cpp

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim added a comment. In D6#1993211 , @arichardson wrote: > I don't like the fact that this only changes one of the users of > `getTriple().getOSMajorVersion()`. Why not, if this is a one-off case, it's perfectly OK to put it in here. Maybe add a

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 282168. MForster added a comment. Pretty-print VarDecl arguments correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td

[PATCH] D85022: Need to ensure the datalayout differs when using externref

pmatos abandoned this revision. pmatos added a comment. Mistakingly created - this should have gone to D66035 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85022/new/ https://reviews.llvm.org/D85022

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

myfreeweb added a comment. ping. can we get *some* solution to this included in llvm 11.0 final release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro added a comment. In D84029#2170105 , @MaskRay wrote: > Can you add a test to `test/Driver/solaris-ld.c`? No, this needs a separate testcase: the `-C` option unconditionally passed to the linker is only understood by the native `ld`. I've added

[PATCH] D85026: [analyzer] Minor refactoring of SVal::getSubKind function

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, vsavchenko, Eugene.Zelenko, krememek, steakhal. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, dexonsmith, mikhail.ramalho, a.sidorin, szepet,

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

myfreeweb added a comment. In D6#2187273 , @dim wrote: >> +#ifdef __FreeBSD__ >> +return __FreeBSD_version / 10; >> +#else >> +return 10; >> +#endif > > No, that would hardcode something at build time. We need to respect whatever

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

hokein added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:70 SymbolCollector::Options Opts; +Opts.FileFilter = FileFilter; Opts.CountReferences = true; `FileFilter` seems more promising, but there are some FIXMEs

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill requested changes to this revision. chill added a comment. This revision now requires changes to proceed. Let's postpone this just for a little bit, to settle on an approach to `depth > 0`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill added a comment. In D75044#2186973 , @chill wrote: > Let's postpone this just for a little bit, to settle on an approach to `depth > > 0`. This is with regard to https://reviews.llvm.org/D84502#inline-779900 CHANGES SINCE LAST ACTION

[PATCH] D85016: [clang-format] Add space between method modifier and a tuple return type in C#

lbk created this revision. lbk added reviewers: jbcoe, krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. lbk requested review of this revision. "public (string name, int age) methodTuple() {}" is now properly spaced Repository: rG LLVM Github Monorepo

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

pmatos added a comment. In D66035#2181659 , @pmatos wrote: > I will be splitting the part enabling the target feature through clang into a > separate revision as suggested by @tlively I just noticed that most of this work landed in an earlier commit:

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:332 << "()->getName() : \"\") << \""; + else if (type == "VarDecl *") +OS << "\" << get" << getUpperName() << "()->getName() << \""; I think this

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko added a comment. @kadircet I decided to add `OnlyChildren` to `enum VisitKind` instead of making a `VisitKindSet` - this helped to minimize the changes in `shouldVisit()`. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 638f0cf - [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

Author: Haojian Wu Date: 2020-07-31T14:34:56+02:00 New Revision: 638f0cf565f2121151c32d7eb52a1de0e333d5f6 URL: https://github.com/llvm/llvm-project/commit/638f0cf565f2121151c32d7eb52a1de0e333d5f6 DIFF: https://github.com/llvm/llvm-project/commit/638f0cf565f2121151c32d7eb52a1de0e333d5f6.diff

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG638f0cf565f2: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

njames93 updated this revision to Diff 282172. njames93 added a comment. Added Option GetConfigPerFile to control this behaviour. Ensure the check is enabled in the header files configuration before using any configuration found. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/global-style-disabled/header.h:4

[PATCH] D85022: Need to ensure the datalayout differs when using externref

pmatos created this revision. Herald added subscribers: cfe-commits, jgravelle-google, sbc100, dschuff. Herald added a project: clang. pmatos requested review of this revision. Herald added a subscriber: aheejin. externref needs address space 256. Repository: rG LLVM Github Monorepo

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

ro updated this revision to Diff 282192. ro added a comment. Herald added subscribers: llvm-commits, ormris, delcypher. Herald added a project: LLVM. Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84029/new/

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 282197. ilya-golovenko added a comment. Changes afte code review, add test for export context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files:

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal added a comment. It seems the Pre-merge clang-format went crazy. I think just ignore the lint warnings for the unchanged lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84979/new/ https://reviews.llvm.org/D84979

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 282198. ilya-golovenko added a comment. Remove invalid comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files: clang-tools-extra/clangd/FindSymbols.cpp

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe704aa4f254a: DR2303: Prefer nearer base classes during template deduction. (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[clang] e704aa4 - DR2303: Prefer 'nearer' base classes during template deduction.

Author: Erich Keane Date: 2020-07-31T05:39:55-07:00 New Revision: e704aa4f254a26505d4bb9dc38bdee0ff4efa4ba URL: https://github.com/llvm/llvm-project/commit/e704aa4f254a26505d4bb9dc38bdee0ff4efa4ba DIFF: https://github.com/llvm/llvm-project/commit/e704aa4f254a26505d4bb9dc38bdee0ff4efa4ba.diff

[PATCH] D85025: [RecoveryExpr]WIP: Support dependence in C-only codepath

hokein created this revision. Herald added subscribers: cfe-commits, dang, arphaman, kbarton, nemanjai. Herald added a project: clang. hokein requested review of this revision. Herald added a subscriber: wuzish. This is a large patch containing all required changes, want early feedback. what

[PATCH] D85016: [clang-format] Add space between method modifier and a tuple return type in C#

lbk updated this revision to Diff 282210. lbk added a comment. Extend test set by additional values of method_modifier Updating D85016 : [clang-format] Add space between method modifier and a tuple return type in C# Repository: rG LLVM Github Monorepo

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

simon_tatham added a comment. In D85009#2187549 , @jfb wrote: > Is that true of all vector bfloat implementations? It seems like arithmetic > on these types is something implementations would likely support. As I understand it, Arm currently has the

[PATCH] D85033: [clang] Provide a better name for unnamed parameters, lambda classes and lambda captures.

riccibruno created this revision. riccibruno added reviewers: erichkeane, rsmith. riccibruno added a project: clang. Herald added subscribers: cfe-commits, arphaman. riccibruno requested review of this revision. As a follow up to D84658 : For an unnamed

[PATCH] D81346: [KernelAddressSanitizer] Ensure global array size remains multiple of type-size

melver added a comment. Note: We landed globals support for KASAN with https://reviews.llvm.org/rGd3f89314ff20ce1612bd5e09f9f90ff5dd5205a7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81346/new/ https://reviews.llvm.org/D81346

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

LukeGeeson added a comment. In D85009#2187621 , @jfb wrote: > In D85009#2187603 , @simon_tatham > wrote: > >> In D85009#2187549 , @jfb wrote: >> >>> Is that true of all

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:76 + + Added an option GetConfigPerFile to support including files which use + different naming styles. Please enclose GetConfigPerFile in single back-quotes.

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

19n07u5 added a comment. The title is a little bit confusing because only the C-string size model is going to be separated and be accessible. Other than that as @NoQ pointed out we need lot more of these common-API-separation patches. It is a great starting point for the `CStringChecker`.

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko added a comment. Here are the benchmark and fuzzing harness used to test this patch. F12453076: fuzz_divXf3.sh F12453075: divXf3_fuzzer.c F12453074: bench_divXf3.sh

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko updated this revision to Diff 282225. atrosinenko added a comment. Revert auto-linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85031/new/ https://reviews.llvm.org/D85031 Files: compiler-rt/lib/builtins/divdf3.c

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert added a comment. @davezarzycki The bots reported this as well, didn't build MLIR locally, this should have been fixed by 4d83aa4771d84940626d86c883193af390812281 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Some results with an improved version of this checker: tmux: 6 results duckdb: 23 results (1-2 false positive) vim: 1 result emacs: 25 results (more false positives mostly because ? operator that is easy to fix) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D85032: [builtins] Make divXf3 handle denormal results

atrosinenko created this revision. atrosinenko added reviewers: koviankevin, joerg, efriedma, compnerd, scanon. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. atrosinenko requested review of this revision. This is the last patch from the patchset introducing proper

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

ilya-golovenko updated this revision to Diff 282236. ilya-golovenko added a comment. Simplify logic in traverseDecl method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84839/new/ https://reviews.llvm.org/D84839 Files:

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

jfb added a comment. Is that true of all vector bfloat implementations? It seems like arithmetic on these types is something implementations would likely support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4e574323210: [PowerPC] Implement low-order Vector Modulus Builtins, and add Vector… (authored by amyk). Changed prior to commit:

[clang] c4e5743 - [PowerPC] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

Author: Amy Kwan Date: 2020-07-31T10:58:07-05:00 New Revision: c4e574323210feda1a3988e85fdd93b90a63d1b1 URL: https://github.com/llvm/llvm-project/commit/c4e574323210feda1a3988e85fdd93b90a63d1b1 DIFF: https://github.com/llvm/llvm-project/commit/c4e574323210feda1a3988e85fdd93b90a63d1b1.diff

[PATCH] D85028: [clangd] Support new/deleta operator in TargetFinder.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D85034: [analyzer] Simplified functions SVal::getAsSymbolicExpression and similar ones

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: vsavchenko, NoQ, steakhal, dcoughlin. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware,

[PATCH] D84839: Add document outline symbols from unnamed contexts, e.g. extern "C".

kadircet added a comment. In D84839#2187222 , @ilya-golovenko wrote: > @kadircet I decided to add `OnlyChildren` to `enum VisitKind` instead of > making a `VisitKindSet` - this helped to minimize the changes in > `shouldVisit()`. What do you think?

[PATCH] D85031: [builtins] Unify the softfloat division implementation

atrosinenko created this revision. atrosinenko added reviewers: koviankevin, joerg, efriedma, compnerd, scanon. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. atrosinenko requested review of this revision. atrosinenko updated this revision to Diff 282225. atrosinenko

[PATCH] D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. The mangling agrees with https://itanium-cxx-abi.github.io/cxx-abi/abi.html#mangling-builtin LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

LukeGeeson accepted this revision. LukeGeeson added a comment. This revision is now accepted and ready to land. This seems sensible and benign, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ https://reviews.llvm.org/D85009

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

jfb added a comment. In D85009#2187603 , @simon_tatham wrote: > In D85009#2187549 , @jfb wrote: > >> Is that true of all vector bfloat implementations? It seems like arithmetic >> on these types is something

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

simon_tatham added a comment. In D85009#2187621 , @jfb wrote: > You mean: only aarch64 backend supports lowering bfloat16 vectors at the > moment? Yes, sorry – I should have said that Arm has the only implementation //in an LLVM target//. I meant the

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/docs/Modules.rst:295 + +A trick to prebuilt required modules in one command is to generate implicit modules using the ``-fdisable-module-hash`` option. + Bigcheese wrote: >

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:70 SymbolCollector::Options Opts; +Opts.FileFilter = FileFilter; Opts.CountReferences = true; hokein wrote: > `FileFilter` seems more promising, but there

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added a comment. Need tot resolve `FIXME`s around `shouldIndexFile()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84811/new/ https://reviews.llvm.org/D84811

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

ldionne added a comment. Gentle ping. This is blocking the implementation of `std::bit_cast` in libc++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 ___ cfe-commits mailing list

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2183383 , @tejohnson wrote: > I just noticed that generateParamAccessSummary is taking a bit over 5% of the > ThinLTO thin link step in an internal build (and will soon be more than 5% as > I found another analysis

[libunwind] 46591b9 - [libunwind] Add -Wno-suggest-override to CMakeLists.txt.

Author: kristina Date: 2020-07-31T19:04:13+01:00 New Revision: 46591b95362325d262ca29ce13e7b5ddda624bc8 URL: https://github.com/llvm/llvm-project/commit/46591b95362325d262ca29ce13e7b5ddda624bc8 DIFF: https://github.com/llvm/llvm-project/commit/46591b95362325d262ca29ce13e7b5ddda624bc8.diff

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 282281. jfb marked 9 inline comments as done. jfb added a comment. Address Richard's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files:

[PATCH] D85039: [DO NOT SUBMIT][WIP] prototype

zbrid created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. zbrid requested review of this revision. Not intended to be reviewed. I only uploaded this patch to have a link to share. Repository: rG

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added a comment. In D84316#2187372 , @19n07u5 wrote: > The title is a little bit confusing because only the C-string size model is > going to be separated and be accessible. Could you elaborate on why is the title not precise? It seems that the

[PATCH] D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures.

riccibruno updated this revision to Diff 282296. riccibruno added a comment. Make the unit tests in `NamedDeclPrinterTest.cpp` more robust. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85033/new/ https://reviews.llvm.org/D85033 Files:

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

jfb added a comment. In D85009#2187631 , @LukeGeeson wrote: > In D85009#2187621 , @jfb wrote: > >> In D85009#2187603 , @simon_tatham >> wrote: >> >>> In D85009#2187549

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

rsandifo-arm added a subscriber: lenary. rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

riccibruno added a comment. In D84678#2184687 , @Jac1494 wrote: > Hi @aaron.ballman , > Address your review comments. > Thank you for accepting this. I don't have commit access please commit this. > Thanks. As discussed with Aaron on IRC I can commit it

[PATCH] D85026: [analyzer] Minor refactoring of SVal::getSubKind function

vsavchenko added a comment. Hey, nice catch! However, I'm going to complain about commit messages again  I would prefer having imperative mood in the message, something like "Refactor ..." or "Introduce minor refactoring..." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. In D66035#2187021 , @pmatos wrote: > In D66035#2181659 , @pmatos wrote: > >> I will be splitting the part enabling the target feature through clang into >> a separate revision as suggested

[PATCH] D84197: [PowerPC][Power10] Vector String Isolate instruction definitions and MC Tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93fd8dbdc250: [PowerPC] Add Vector String Isolate instruction definitions and MC Tests (authored by Conanap, committed by amyk). Repository: rG

[PATCH] D85026: [analyzer] Minor refactoring of SVal::getSubKind function

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I like the change. I also proved the equivalence, just for fun really :D from z3 import * def proof_equality(F, G): s = Solver() s.add(Not(F == G)) r = s.check() if

[PATCH] D85034: [analyzer] Simplified functions SVal::getAsSymbolicExpression and similar ones

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. It would be great to simplify these. I have also wondered once why those different functions exist. Does anyone know what was the original intention of these functions? Since I'm not confident in

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. This is almost ready I think! There are a few things still open, I'd love feedback on them. Comment at: clang/docs/LanguageExtensions.rst:2435-2437 +* ``__builtin_memcpy_overloaded(QUAL void *dst, QUAL const void *src, size_t byte_size, size_t

[PATCH] D85034: [analyzer] Simplified functions SVal::getAsSymbolicExpression and similar ones

vsavchenko added a comment. Thanks for working on improving the quality of the codebase! I again have to nitpick about the commit message, can you please change it to "Simplify ..."? Comment at: clang/lib/StaticAnalyzer/Core/SVals.cpp:135-149 -/// getAsSymbolicExpression - If

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

riccibruno added a comment. In D84678#2187747 , @riccibruno wrote: > In D84678#2184687 , @Jac1494 wrote: > >> Hi @aaron.ballman , >> Address your review comments. >> Thank you for accepting this. I don't have

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 282263. Jac1494 added a comment. Hi @riccibruno, Address your review comment.Add please use Name :- Jaydeep Chauhan Mail id:- jaydeepchauhan1...@gmail.com Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/

[clang] 18eba16 - [OpenMP][docs] Update loop tiling status.

Author: Michael Kruse Date: 2020-07-31T13:01:55-05:00 New Revision: 18eba165e7ba80328a910cad3407599d8ff60f4f URL: https://github.com/llvm/llvm-project/commit/18eba165e7ba80328a910cad3407599d8ff60f4f DIFF: https://github.com/llvm/llvm-project/commit/18eba165e7ba80328a910cad3407599d8ff60f4f.diff

[PATCH] D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures.

riccibruno updated this revision to Diff 282312. riccibruno added a comment. Add `-fno-delayed-template-parsing` to the new unit tests to also pass on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85033/new/

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

yonghong-song updated this revision to Diff 282325. yonghong-song edited the summary of this revision. yonghong-song added a comment. enum value relocation change: use ld_imm64 so we support 64bit enum value from day one. put enumerator name as the AccessString. Repository: rG LLVM Github

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 282307. nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. - rebase, add captures to tests, simplify NODBG-NOT cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked an inline comment as not done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3842-3846 + if (EmitDwarf && + Args.hasFlag(options::OPT_fno_eliminate_unused_debug_types, +

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG38d3e7533279: [clang] Use the location of the void parameters when complaining that only a… (authored by Jac1494, committed by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 38d3e75 - [clang] Use the location of the void parameters when complaining that only a single void parameter should be present.

Author: Jaydeep Chauhan Date: 2020-07-31T20:36:58+01:00 New Revision: 38d3e7533279fd4bfefcd88eac7d3b64f804c53a URL: https://github.com/llvm/llvm-project/commit/38d3e7533279fd4bfefcd88eac7d3b64f804c53a DIFF:

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 282335. arames marked an inline comment as done. arames added a comment. Addressed review comments. - Fixed typos in the doc. - Added doc about module compatibility. - Cleaned and tested commands in the doc. - Reworked module hash code to not require

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames updated this revision to Diff 282336. arames added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 Files: clang/docs/Modules.rst clang/include/clang/Driver/Options.td

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Heads-up: This causes Chromium's build to fail with clang-cl: /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/clang/lib/AST/ASTContext.cpp:4823: clang::QualType clang::ASTContext::getPackExpansionType(clang::QualType, llvm::Optional, bool): Assertion `(!ExpectPackInType ||

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Sorry, the repro link should've pointed to https://bugs.chromium.org/p/chromium/issues/detail?id=1110981#c22 which has a nicer stack. On Fri, Jul 31, 2020 at 7:22 PM Nico Weber wrote: > Heads-up: This causes Chromium's build to fail with > > clang-cl: >

[clang] 721d93f - Support experimental v extension v0.9.

Author: Hsiangkai Wang Date: 2020-08-01T07:42:06+08:00 New Revision: 721d93fc5aa8c9f9fc9b86a9d3d1a58c6790213e URL: https://github.com/llvm/llvm-project/commit/721d93fc5aa8c9f9fc9b86a9d3d1a58c6790213e DIFF:

[PATCH] D81213: [RISCV] Support experimental v extension v0.9.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG721d93fc5aa8: Support experimental v extension v0.9. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2430 + +These overloads support destinations and sources which are a mix of the +following qualifiers: Comment at: clang/docs/LanguageExtensions.rst:2454 +and might

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +

[PATCH] D85034: [analyzer] Simplified functions SVal::getAsSymbolicExpression and similar ones

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. *standing ovation* This was long overdue, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85034/new/ https://reviews.llvm.org/D85034

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

Thanks, was just an overzealous assertion. Should be fixed in llvmorg-12-init-1765-g234f51a65a4. On Fri, 31 Jul 2020 at 16:23, Nico Weber wrote: > Sorry, the repro link should've pointed to > https://bugs.chromium.org/p/chromium/issues/detail?id=1110981#c22 which > has a nicer stack. > > On

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:408-412 +SmallString<128> Msg; +llvm::raw_svector_ostream Out(Msg); +TagDetails.trackValidExpr(BR); +TagDetails.explainSmartPtrAction(Out); +

  1   2   >