[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

nemanjai added a comment. In D92935#2477171 , @kiausch wrote: > Regarding similar GCC options: > > AFAIK GCC has had the spe options -msingle-float and -mdouble-float until spe > support was dropped after version 8.3. > These options would kind of match

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein abandoned this revision. hokein added a comment. Closing it as Richard has landed a better patch in https://github.com/llvm/llvm-project/commit/638867afd4bce4a2c56dea041299428af3727d61. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314594. Anastasia marked an inline comment as done. Anastasia added a comment. Addressed comments from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:727 + virtual bool IsMatchingChildrenNotSpelledInSource() const = 0; + virtual void SetMatchingChildrenNotSpelledInSource(bool Set) = 0; + aaron.ballman wrote: >

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 314597. Anastasia added a comment. Further change suggested by Marco CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index:

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:69 ++==+==+==+===+ +|

[PATCH] D94030: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e4f53f748d3: [ASTMatchers] Fix traversal matchers with explicit and defaulted methods (authored by stephenkelly). Changed prior to commit:

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

sammccall added a comment. Ah, thanks for working on this! A few thoughts: - when we're pseudoparsing the file we're going to modify as we do here, using the new content is strictly better, no downside :-) - the old method here of accessing the content through the FS attached to the AST is a

[clang] 7e4f53f - [ASTMatchers] Fix traversal matchers with explicit and defaulted methods

Author: Stephen Kelly Date: 2021-01-05T15:22:21Z New Revision: 7e4f53f748d3c97f0b9b852bfbcab0740aba521b URL: https://github.com/llvm/llvm-project/commit/7e4f53f748d3c97f0b9b852bfbcab0740aba521b DIFF: https://github.com/llvm/llvm-project/commit/7e4f53f748d3c97f0b9b852bfbcab0740aba521b.diff

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

erichkeane added a comment. I'm not sure how well Attr.td's constraints are enforced on type attributes, as these often happen before parsing is completely done. I'd imagine this code was put into place at least the 1st time for good reason, but I'm curious as to why we wouldn't have tests

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. We don't really have anywhere specific to put extra matchers, and we don't want to add stuff to the actual gtest folder so it's easy to merge updates. So this is fine.

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

erichkeane added a comment. In D94092#2479733 , @fhahn wrote: > In D94092#2479684 , @erichkeane > wrote: > >> I'm not sure how well Attr.td's constraints are enforced on type attributes, >> as these often happen

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D94092#2479765 , @fhahn wrote: > In D94092#2479753 , @erichkeane > wrote: > >>> I tried a few

[PATCH] D94098: [Clang] Inline assembly support for the ACLE type 'data512_t'.

labrinea created this revision. labrinea added reviewers: cfe-commits, t.p.northover, ab, kristof.beyls, simon_tatham. labrinea requested review of this revision. Herald added a project: clang. This patch emits the new LLVM IR type introduced in https://reviews.llvm.org/D94091 when generating

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:822 + /// calling the parameter itself, but rather uses it as the argument. + template + void checkIndirectCall(const CallLikeExpr *CallOrMessage) { NoQ wrote: > vsavchenko

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

peterwaller-arm marked an inline comment as done. peterwaller-arm added inline comments. Comment at: llvm/test/Transforms/InstCombine/debuginfo-scalable-typesize.ll:13 + +; ERR-NOT: TypeSize is not scalable + peterwaller-arm wrote: > sdesmalen wrote: > > After

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7855 + return; +RowsExpr = Columns.get(); + } else { fhahn wrote: > RKSimon wrote: > > @fhahn Should this be ColsExpr? > > ``` > > ColsExpr = Columns.get(); > > ``` > > Noticed when

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn added a comment. Comment at: clang/lib/Sema/SemaType.cpp:7661 - Expr *SizeExpr; - // Special case where the argument is a template id. - if (Attr.isArgIdent(0)) { -CXXScopeSpec SS; -SourceLocation TemplateKWLoc; -UnqualifiedId Id; -

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

aaron.ballman added a comment. In D94092#2479684 , @erichkeane wrote: > I'm not sure how well Attr.td's constraints are enforced on type attributes, > as these often happen before parsing is completely done. Type (and statement) attributes do not have

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

fhahn added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:1756 + +class VectorTypeLoc : public ConcreteTypeLoc { Can we reuse/unify this with `MatrixTypeLoc`? And then have `MatrixTypeLoc` just deal with the row/column operands. CHANGES SINCE

[PATCH] D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94081/new/ https://reviews.llvm.org/D94081 ___

[clang] 3d5b18a - [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

Author: Joe Ellis Date: 2021-01-05T15:18:21Z New Revision: 3d5b18a3fdf47ae2286642131e4a92968dd01c2a URL: https://github.com/llvm/llvm-project/commit/3d5b18a3fdf47ae2286642131e4a92968dd01c2a DIFF: https://github.com/llvm/llvm-project/commit/3d5b18a3fdf47ae2286642131e4a92968dd01c2a.diff LOG:

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d5b18a3fdf4: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments (authored by joechrisellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

balazske added a comment. The problem is reproduced and fixed in D94067 . It is caused by import of default template arguments indirectly, because that import causes lot of other things to be imported. And the import of default arguments happens in a incomplete

[PATCH] D94029: [clang-tidy] Add extra tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG53c3acb89fcc: [clang-tidy] Add extra tests (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94029/new/

[clang-tools-extra] 53c3acb - [clang-tidy] Add extra tests

Author: Stephen Kelly Date: 2021-01-05T15:43:56Z New Revision: 53c3acb89fcc25ba7ef1f1d76a79c241eeacb7f0 URL: https://github.com/llvm/llvm-project/commit/53c3acb89fcc25ba7ef1f1d76a79c241eeacb7f0 DIFF: https://github.com/llvm/llvm-project/commit/53c3acb89fcc25ba7ef1f1d76a79c241eeacb7f0.diff

[clang] 51d5991 - [Clang] Add AArch64 VCMLA LANE variants.

Author: Florian Hahn Date: 2021-01-05T16:14:00Z New Revision: 51d5991f04dda76c2f07123569b5c31ed3dfcfe8 URL: https://github.com/llvm/llvm-project/commit/51d5991f04dda76c2f07123569b5c31ed3dfcfe8 DIFF: https://github.com/llvm/llvm-project/commit/51d5991f04dda76c2f07123569b5c31ed3dfcfe8.diff LOG:

[PATCH] D93014: [Clang] Add AArch64 VCMLA LANE variants.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d5991f04dd: [Clang] Add AArch64 VCMLA LANE variants. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D93014?vs=314452=314620#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

peterwaller-arm updated this revision to Diff 314629. peterwaller-arm added a comment. Update for review comment. - Generalize WARN-NOT to disallow any warnings, not just those with specific text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2479343 , @vsavchenko wrote: > In D93630#2479260 , @aaron.ballman > wrote: > >> In D93630#2478977 , @vsavchenko >> wrote: >> >>> I

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4020 bool IsListInit = false, bool IsInitListCopy = false) { assert(((!IsListInit && !IsInitListCopy) ||

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske updated this revision to Diff 314604. balazske added a comment. Found a better solution. And the decl chain looks more normal if this change is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

balazske added a comment. There are still problems related to import type argument default values: If there are forward declarations of the same template, the "inheritedness" of these arguments (in AST) is not set correctly and the default arguments can appear at more places instead of at only

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel updated this revision to Diff 314615. ymandel added a comment. added comment known smart pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93637/new/ https://reviews.llvm.org/D93637 Files:

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel marked an inline comment as done. ymandel added a comment. Thanks for the review! Comment at: clang/unittests/Tooling/StencilTest.cpp:273 + std::string Snippet = R"cc( +Smart x; +x; tdl-g wrote: > You're only testing the "QuacksLike" case. I

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aaron.ballman added a comment. The frontend parts LGTM, but you should wait for someone else to review the backend parts before landing. Comment at: clang/test/Sema/callingconv-darwin_abi.c:10 + +void(__attribute__((darwin_abi)) * pfoo2)(void) = foo; //

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 added a comment. In D93701#2477239 , @jansvoboda11 wrote: > Another solution would be to create a "dummy" `DiagnosticsEngine` for the > `ParseDiagnosticArgs` calls, but I didn't find a way to do that. Something like

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

tdl-g added a comment. Ah, if it's just an optimization that makes sense. I still think it's worth having a test case to confirm that one of the specially-handled cases works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93637/new/

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn updated this revision to Diff 314632. fhahn added a comment. Also remove Attr.isArgIdent check from AddressSpaceTypeAttribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94092/new/ https://reviews.llvm.org/D94092 Files:

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93700/new/ https://reviews.llvm.org/D93700

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

saiislam marked 3 inline comments as done. saiislam added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:1048-1049 +while (!CurKindTriple.empty()) { + if (hasHostKind(CurKindTriple)) { +// Do nothing, we don't extract host

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Gentle post-holiday ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

clementval accepted this revision. clementval added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301

[PATCH] D93587: [hip] Fix HIP version parsing.

hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93587/new/ https://reviews.llvm.org/D93587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

fhahn updated this revision to Diff 314640. fhahn added a comment. Address Simon's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94092/new/ https://reviews.llvm.org/D94092 Files: clang/lib/Sema/SemaType.cpp Index:

[clang] 55488bd - CGExpr - EmitMatrixSubscriptExpr - fix getAs<> null-dereference static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2021-01-05T17:08:11Z New Revision: 55488bd3cd1a468941e26ad4cf94f2bad887fc02 URL: https://github.com/llvm/llvm-project/commit/55488bd3cd1a468941e26ad4cf94f2bad887fc02 DIFF: https://github.com/llvm/llvm-project/commit/55488bd3cd1a468941e26ad4cf94f2bad887fc02.diff

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT,

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg marked an inline comment as done. thezbyg added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:111-115 + Out << "u8'" << Val << "'"; +else if (T->isUnsignedIntegerType() && T->isChar16Type()) + Out << "u16'" << Val << "'"; +else if (T->isUnsignedIntegerType() &&

[clang] f88a797 - [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

Author: Atmn Patel Date: 2021-01-05T09:56:16-05:00 New Revision: f88a7975210fc995197af4b393e3bb5030e97a5c URL: https://github.com/llvm/llvm-project/commit/f88a7975210fc995197af4b393e3bb5030e97a5c DIFF: https://github.com/llvm/llvm-project/commit/f88a7975210fc995197af4b393e3bb5030e97a5c.diff

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1)

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh updated this revision to Diff 314703. GGanesh edited the summary of this revision. GGanesh added a comment. Updaing the patch so that the simplified patch adds only few missing znver3 tests. The subsequent patches will comprehensively enable other znver3 features. Repository: rG LLVM

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478431 , @aeubanks wrote: > In D94019#2478423 , @dblaikie wrote: > >> In D94019#2478378 , @aeubanks wrote: >> >>> Oh sorry, yeah this

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

yaxunl added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/ymath.h:16 + +#pragma clang force_cuda_host_device begin + I am wondering whether we only want to do this for windows, since ymath.h may be an ordinary users' header file on linux.

[clang] 2168942 - [Coverage] Fix Profile test failures from commit rG9f2967bcfe2f

Author: Alan Phipps Date: 2021-01-05T14:53:07-06:00 New Revision: 216894211713bbb1e8beb249f2b008c11a9d8c2c URL: https://github.com/llvm/llvm-project/commit/216894211713bbb1e8beb249f2b008c11a9d8c2c DIFF: https://github.com/llvm/llvm-project/commit/216894211713bbb1e8beb249f2b008c11a9d8c2c.diff

[clang] 16c6e9c - [ASTMatchers] Fix child traversal over range-for loops

Author: Stephen Kelly Date: 2021-01-05T21:29:37Z New Revision: 16c6e9c58e9ae50a775945e6b407f1891f353d2f URL: https://github.com/llvm/llvm-project/commit/16c6e9c58e9ae50a775945e6b407f1891f353d2f DIFF: https://github.com/llvm/llvm-project/commit/16c6e9c58e9ae50a775945e6b407f1891f353d2f.diff

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16c6e9c58e9a: [ASTMatchers] Fix child traversal over range-for loops (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

tra added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:959 + = = = + ``EF_AMDGPU_FEATURE_XNACK_V2``0x01 Indicates if the ``xnack`` +

[PATCH] D92954: [clang-offload-bundler] Add option -list

tra added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:176 + /// List bundle IDs in \a Input. + virtual Error listBundleIDs(MemoryBuffer ) { +if (Error Err = ReadHeader(Input)) Now that listBundleIDs is only used

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added a comment. In D78058#2471735 , @sammccall wrote: > @dexonsmith thanks for sharing! > Some initial thoughts since abstracting outputs is something we're starting > to care about too... Thanks for looking. > This doesn't appear to be an

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic updated this revision to Diff 314718. rapgenic marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93763/new/ https://reviews.llvm.org/D93763 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) ||

[PATCH] D93587: [hip] Fix HIP version parsing.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:91 -void RocmInstallationDetector::ParseHIPVersionFile(llvm::StringRef V) { +bool RocmInstallationDetector::parseHIPVersionFile(llvm::StringRef V) { SmallVector VersionParts; A

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. >> In D93747#2470178 , @tmsriram wrote: >> >>> In D93747#2469556 , @hoy wrote: >>> > In D93656 , @dblaikie wrote: > Though the C case is interesting

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic marked 4 inline comments as done. rapgenic added a comment. > In the future it may make sense to have other documentLinks too. (e.g. > imagine a comment Configures the Frobnicator - we should linkify Frobnicator > to point to a class, once documentLink supports target ranges). So we

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a simple utility which allows matching on binaryOperator and cxxOperatorCallExpr. It can also be

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes them composable with mapAnyOf(). Repository: rG LLVM Github Monorepo

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; Is this to fix the bug or is this for efficiency

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked an inline comment as done. alanphipps added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l

[clang] b12e473 - Allow dependent alias template specializations in the preferred_name

Author: Richard Smith Date: 2021-01-05T15:33:51-08:00 New Revision: b12e4735317ec96e1b35deee68b90d62a23a9353 URL: https://github.com/llvm/llvm-project/commit/b12e4735317ec96e1b35deee68b90d62a23a9353 DIFF: https://github.com/llvm/llvm-project/commit/b12e4735317ec96e1b35deee68b90d62a23a9353.diff

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

steveire added a comment. This is part of a series of commits. See them in context here: https://github.com/steveire/llvm-project/commits/mapAnyOf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94127/new/ https://reviews.llvm.org/D94127

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

dblaikie added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l -instr-profile %t.profdata

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

dblaikie added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l -instr-profile %t.profdata

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94130 Files:

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36024: [analyzer] Improved bug reporting in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When debugging a matcher it is convenient to be able to comment out nested matchers experimentally. This

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make it possible to compose a matcher for different base nodes. This accepts one or more node matcher

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

steveire updated this revision to Diff 314739. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94131/new/ https://reviews.llvm.org/D94131 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36023: [analyzer] Add array support for MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D93772: [Clang][Driver] Fix read-after-free when using /clang:

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93772/new/ https://reviews.llvm.org/D93772 ___

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added a comment. In D78058#2480411 , @dexonsmith wrote: > In D78058#2471735 , @sammccall wrote: > >> @dexonsmith thanks for sharing! >> Some initial thoughts since abstracting outputs is something we're

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > >> @tmsriram - any ideas what your case/example was like that might've caused >> degraded debugging

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481163 , @dblaikie wrote: > In D93747#2481095 , @hoy wrote: > >> In D93747#2481073 , @dblaikie wrote: >> >>> In D93747#2481053

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

rnk added a comment. Reposting my comment here, since this is where the discussion was: I think this change broke -gline-tables-only functionality. I compared object files before and after this change. The new object file had a large .debug_loc section, which is only present when full debug

[clang] 74f93bc - [Sema] Fix deleted function problem in implicitly movable test

Author: Yang Fan Date: 2021-01-06T10:05:40+08:00 New Revision: 74f93bc373d089e757bb65cf8b30b63a4eae8b69 URL: https://github.com/llvm/llvm-project/commit/74f93bc373d089e757bb65cf8b30b63a4eae8b69 DIFF: https://github.com/llvm/llvm-project/commit/74f93bc373d089e757bb65cf8b30b63a4eae8b69.diff

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f93bc373d0: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > In D93747#2470178 , @tmsriram wrote: > In

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481073 , @dblaikie wrote: > In D93747#2481053 , @tmsriram wrote: > >> In D93747#2480442 , @dblaikie wrote: >> >>> @tmsriram - any ideas what

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

<    1   2   3   >