[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 346515. jamieschmeiser edited the summary of this revision. jamieschmeiser added a comment. As requested, I have added a new warning option -Wnull-pointer-subtraction (and added it to -Wextra) that does not trigger on system headers. In addition, I

[PATCH] D102715: Fix LIT failure on native aix

hubert.reinterpretcast added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. Xiangling_L wrote: > aaron.ballman wrote: > >

[PATCH] D102715: Fix LIT failure on native aix

Xiangling_L added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. aaron.ballman wrote: > Xiangling_L wrote: > > aaron.ballman

[PATCH] D102784: [Diagnostics] Allow emitting analysis and missed remarks on functions

jhuber6 updated this revision to Diff 346516. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixing Clang tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102784/new/

[PATCH] D102715: Fix LIT failure on native aix

aaron.ballman added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. Xiangling_L wrote: > aaron.ballman wrote: > > We're not really

[PATCH] D102715: Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346503. Xiangling_L marked an inline comment as done. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Adjust the comment; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L marked an inline comment as done. Xiangling_L added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. aaron.ballman

[PATCH] D102495: [clang][deps] Support inferred modules

frgossen added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-15 +// RUN: %clang @%t.inferred.cc1.rsp -pedantic -Werror +// RUN: %clang @%t.system.cc1.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only

[PATCH] D102568: [Driver] Delete -mimplicit-it=

nickdesaulniers added a comment. In D102568#2768224 , @mstorsjo wrote: > I would request that this commit should be reverted. Sure, @MaskRay would you mind reverting? > But this change did break my build in these places: >

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278 if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) == -SanitizerMask()) +SanitizerMask() && +SanitizerName != "coverage") melver

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278 if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) == -SanitizerMask()) +SanitizerMask() && +SanitizerName != "coverage") aaron.ballman

[clang] 76b8754 - Revert "Reapply "[clang][deps] Support inferred modules""

Author: Frederik Gossen Date: 2021-05-19T19:19:37+02:00 New Revision: 76b8754d1bba6a8490c0f7e8a9e2fb3d181f0b03 URL: https://github.com/llvm/llvm-project/commit/76b8754d1bba6a8490c0f7e8a9e2fb3d181f0b03 DIFF:

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

aaron.ballman added a comment. The clang parts look good to me, but someone else should do the final sign-off. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7276-7278 if (parseSanitizerValue(SanitizerName, /*AllowGroups=*/true) == -SanitizerMask()) +

[PATCH] D102715: [AIX] Fix LIT failure on native aix

aaron.ballman added inline comments. Comment at: clang/test/Sema/struct-packed-align.c:170 +#elif defined(_AIX) +// On AIX, [bool, char, short] bitfields have the same alignment as unsigned +// int. We're not really testing the behavior of `bool` or `short`

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. (Tabbed on the Submit button instead of finishing that quote block...) So I assume the stage2- targets are just invoking some ninja invocations in sequence? Anyway, what I think it would be helpful to see what link jobs were in progress. But I guess even with 32

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. In D96033#2768940 , @phosek wrote: > In D96033#2767884 , @teemperor wrote: > >> In D96033#2766502 , @phosek wrote: >> >>> In D96033#2766372

[PATCH] D102715: [AIX] Fix LIT failure on native aix

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. This LGTM. I've added additional reviewers based on the history of the file in case they will have comments. Please hold on committing this until tomorrow.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. In D96033#2767884 , @teemperor wrote: > In D96033#2766502 , @phosek wrote: > >> In D96033#2766372 , @v.g.vassilev >> wrote: >> >>> In D96033#2766332

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver updated this revision to Diff 346484. melver added a comment. Test that always_inline works as expected with no_sanitize("coverage") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/ https://reviews.llvm.org/D102772 Files:

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic created this revision. Herald added subscribers: dexonsmith, dang. rsanthir.quic requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this implementation "-Wstack-usage" acts as an alias to "-Wframe-larger-than" Repository:

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

vsavchenko added a comment. My take on this: for whatever approach, we definitely will be able to construct a more nested/complex example so that it doesn't work. For this patch, I'm wondering about something like this: int foo() { if (z != 0) return 0; if (x + y + z != 0)

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set);

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2244-2247 +and is an optimization hint. It is mandatory to use this attribute in some +situations. Because when the attribute is absent, the compiler assumes the +default maximum workgroup size

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:48-61 +void assign2() { + struct st_long_double st; +#ifndef NOERROR + // expected-error@+2{{long double is not supported on this target}} +#endif + st.ld = 0.42; +} pengfei wrote: >

[PATCH] D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}

bsmith accepted this revision. bsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102623/new/ https://reviews.llvm.org/D102623

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30dfa86760c: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer… (authored by mibintc). Repository: rG LLVM Github

[clang] d30dfa8 - [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

Author: Melanie Blower Date: 2021-05-19T10:59:56-04:00 New Revision: d30dfa86760ced9ac57f676340b34f2247898102 URL: https://github.com/llvm/llvm-project/commit/d30dfa86760ced9ac57f676340b34f2247898102 DIFF:

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346462. Xiangling_L added a comment. Adjusted the testcase so that it also tests the property well on aix; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715 Files:

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

OikawaKirie added a comment. In D102149#2768541 , @martong wrote: > Thank you for the patch! > > Though, the idea is nice, there is a serious technical obstacle here: we > cannot use the clangTooling lib as a dependency of the CTU lib because that >

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan added a comment. In D102724#2768663 , @stevewan wrote: > Might be a dumb question, but I see this is a revert to rGb116ded > , do we > also want to revert the changes added

[PATCH] D102779: [clang-tidy] cppcoreguidelines-explicit-constructor-and-conversion: new alias

mgartmann created this revision. Herald added subscribers: jeroen.dobbelaere, shchenz, kbarton, xazax.hun, nemanjai. mgartmann requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Since the `google-explicit-constructor` check

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

stevewan added a comment. Might be a dumb question, but I see this is a revert to rGb116ded , do we also want to revert the changes added to `llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp`? Comment at:

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver updated this revision to Diff 346452. melver marked 2 inline comments as done. melver added a comment. Address Aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/ https://reviews.llvm.org/D102772 Files:

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a comment. There are quite a few places where the extdef mappings should be updated. For discovering them I suggest you asserting the new file format (only for detecting them!). This way if you miss one, it wouldn't silently 'work' somehow, but raise your attention. There are a

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

steakhal added a comment. There are quite a few places where the extdef mappings should be updated. For discovering them I suggest you asserting the new file format (only for detecting them!). This way if you miss one, it wouldn't silently 'work' somehow, but raise your attention. There are a

[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

OikawaKirie abandoned this revision. OikawaKirie added a comment. In D102062#2768569 , @martong wrote: > First of all, thank you for the patch! > We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in > the following. > > We'd like

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

aaron.ballman added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:319 +It is possible to disable coverage instrumentation for select functions via the +function attribute ``__attribute__((no_sanitize("coverage")))``. + I would expect to see this

[PATCH] D102062: [analyzer][ctu] Append ctu-dir to ctu-invocation-list for non-absolute paths

martong added a comment. First of all, thank you for the patch! We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the following. We'd like to keep the current behavior because this way the behavior is similar that we got used to with any other command line tools.

[PATCH] D101763: [analyzer][ctu] Avoid parsing invocation list again and again during on-demand parsing of CTU

martong added a comment. First of all, thank you for the patch! We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the following. This is indeed an issue and the fix is okay. About the test, we'd like to ask if you could create a small test lib with its own 'open'

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

martong added a comment. Thank you for the patch! Though, the idea is nice, there is a serious technical obstacle here: we cannot use the clangTooling lib as a dependency of the CTU lib because that would introduce a circular dependency. Actually, this was the reason for introducing the

[PATCH] D102773: [clang] Invalide a non-dependent-type RecordDecl when it has any dependent-type base class specifier.

hokein created this revision. hokein added a reviewer: adamcz. hokein requested review of this revision. Herald added a project: clang. This happens during the error-recovery, and it would esacpe all dependent-type check guards in getTypeInfo/constexpr-evaluator code paths, which lead to crashes.

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

melver created this revision. melver added reviewers: vitalybuka, morehouse, glider, dvyukov. Herald added subscribers: dexonsmith, jdoerfert, pengfei, hiraditya. Herald added a reviewer: aaron.ballman. melver requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

martong added a comment. First of all, thank you for the patch! We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the following. This issue you are trying to solve here is indeed a serious problem, but we'd like to suggest an alternative and perhaps more durable

[PATCH] D102770: [clang-tidy] Fix a crash for raw-string-literal check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. hokein requested review of this revision. Herald added a project: clang-tools-extra. getSourceText could return an empty string for error cases (e.g. invalid source locaiton), this patch makes

[PATCH] D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}

peterwaller-arm updated this revision to Diff 346423. peterwaller-arm added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Move test per review comment. - Update ACLE test. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 346421. urnathan added a comment. Added ASTmatchers for UsingEnumDecl along with unit-tests (both of which I was previously unaware of) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files:

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 346418. jansvoboda11 added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser reopened this revision. jamieschmeiser added a comment. This revision is now accepted and ready to land. Re-opening because it was reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102752/new/ https://reviews.llvm.org/D102752

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

hans added a comment. Interesting, I hadn't seen __identifier before. It seems like a pretty esoteric feature. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1817 +else if (Tok.is(tok::string_literal)) { + const StringRef StrData(Tok.getLiteralData() + 1,

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos added a comment. @deadalnix @tlively @sbc100 anything missing here to get this landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 ___ cfe-commits

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 346411. pmatos added a comment. Rebase and update minor details and fix a few lint warnings... Non-functional changes only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/

[PATCH] D102761: [clangd] New ParsingCallback for semantics changes

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously

[PATCH] D102495: [clang][deps] Support inferred modules

jansvoboda11 added a comment. Re-landed this in c98833cdaad01787ea70ecdfabb05a7e142a6671 after reproducing and fixing the Windows failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c98833c - Reapply "[clang][deps] Support inferred modules"

Author: Michael Spencer Date: 2021-05-19T13:35:51+02:00 New Revision: c98833cdaad01787ea70ecdfabb05a7e142a6671 URL: https://github.com/llvm/llvm-project/commit/c98833cdaad01787ea70ecdfabb05a7e142a6671 DIFF:

[PATCH] D102750: [clang] Fix a crash on CheckArgAlignment.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b5426433c9: [clang] Fix a crash on CheckArgAlignment. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102750/new/

[clang] f5b5426 - [clang] Fix a crash on CheckArgAlignment.

Author: Haojian Wu Date: 2021-05-19T13:29:28+02:00 New Revision: f5b5426433c9e6c24615ef1286d72c527b0b15dd URL: https://github.com/llvm/llvm-project/commit/f5b5426433c9e6c24615ef1286d72c527b0b15dd DIFF: https://github.com/llvm/llvm-project/commit/f5b5426433c9e6c24615ef1286d72c527b0b15dd.diff

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Sorry, I removed it but didn't update this review. All set now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list

[PATCH] D102568: [Driver] Delete -mimplicit-it=

mstorsjo added a comment. I would request that this commit should be reverted. > This is a GNU as This is true > and Clang cc1as option, not a GCC option. Users should specify > -Wa,-mimplicit-it= instead. This is not true if you look at any existing stable release - Clang 12.0 doesn't

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

This revision was automatically updated to reflect the committed changes. Closed by commit rG722c39fef5ab: [HIP] Tighten checks in hip-include-path.hip test case (authored by bjope). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102723/new/

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

vsavchenko added a comment. Oh, I'm late to the party! Glad to see you back @Szelethus ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102683/new/ https://reviews.llvm.org/D102683 ___ cfe-commits

[clang] 722c39f - [HIP] Tighten checks in hip-include-path.hip test case

Author: Bjorn Pettersson Date: 2021-05-19T13:11:57+02:00 New Revision: 722c39fef5ab611b3196e964bb3177a5ab473355 URL: https://github.com/llvm/llvm-project/commit/722c39fef5ab611b3196e964bb3177a5ab473355 DIFF:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @uweigand, thanks again for confirming the patch works for you. The differential revision is here https://reviews.llvm.org/D102756 @teemperor and @Hahnfeld, thanks for the diagnosis. I forgot to mention that we had some exchange on Discord and @phosek kindly

[PATCH] D102756: [clang-repl] Tell the LLJIT the exact target triple we use.

v.g.vassilev created this revision. v.g.vassilev added reviewers: hubert.reinterpretcast, lhames, uweigand. v.g.vassilev requested review of this revision. Some systems use a different data layout. For instance, s390x the layout of machines with vector registers is different from the ones

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

Hahnfeld added a comment. In D96033#2767884 , @teemperor wrote: > In D96033#2766502 , @phosek wrote: > >> In D96033#2766372 , @v.g.vassilev >> wrote: >> >>> In

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

This revision was automatically updated to reflect the committed changes. Closed by commit rG479ea2a8ed95: [analyzer] Check the checker name, rather than the ProgramPointTag when… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 479ea2a - [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

Author: Kristóf Umann Date: 2021-05-19T12:40:09+02:00 New Revision: 479ea2a8ed95544d2f5aaede34bfe5c298ae8bdb URL: https://github.com/llvm/llvm-project/commit/479ea2a8ed95544d2f5aaede34bfe5c298ae8bdb DIFF: https://github.com/llvm/llvm-project/commit/479ea2a8ed95544d2f5aaede34bfe5c298ae8bdb.diff

[PATCH] D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks

steakhal updated this revision to Diff 346382. steakhal added a comment. Introduce the test fixture, and use its `setUp()` method for implementing this `GTEST_SKIP` stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102643/new/

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/test/CodeGenOpenCL/printf.cl:9 -#ifdef cl_khr_fp64 +#if defined(cl_khr_fp64) || defined(__opencl_c_fp64) typedef __attribute__((ext_vector_type(2))) double double2;

[PATCH] D102750: [clang] Fix a crash on CheckArgAlignment.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102750/new/ https://reviews.llvm.org/D102750

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 346380. azabaznov added a comment. Drop one more formatting change from Sema.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 Files:

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

azabaznov updated this revision to Diff 346379. azabaznov added a comment. Drop formatting changes from Sema.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96524/new/ https://reviews.llvm.org/D96524 Files: clang/docs/OpenCLSupport.rst

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille added inline comments. Comment at: docs/CommandGuide/clang.rst:319 + + Specify the architecture to build for (Linux and others) To be clear: this is probably misleading and should be `(all platforms)` Repository: rC Clang CHANGES SINCE

[PATCH] D102752: [clang-offload-bundler] Delimit input/output file names by '--' for llvm-objcopy

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a subscriber: abrachet. sdmitriev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

uweigand added a comment. Yes, this patch fixes the problem for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list

[PATCH] D102576: [clang-tidy] cppcoreguidelines-avoid-do-while: a new check

DNS320 updated this revision to Diff 346360. DNS320 added a comment. I updated the check according to the last review. It ignores now do-while statements which are inside a macro and have a false condition. (false condition part was taken from bugprone-terminating-continue

[PATCH] D102750: [clang] Fix a crash on CheckArgAlignment.

hokein created this revision. hokein added a reviewer: kadircet. hokein requested review of this revision. Herald added a project: clang. We might encounter an undeduced type before calling getTypeAlignInChars. NOTE: this retrieve the fix from 8f80c66bd2982788a8eede4419684ca72f48b9a2

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong added a comment. > In this case the equations are $y == 0 and $x + 0 == 0 which is much easier > to solve. Yes, you are right. > This happens for the same reason that your patch is needed in the first > place: we're eagerly substituting a constant. Absolutely, that's the point. On

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. In D96033#2766502 , @phosek wrote: > In D96033#2766372 , @v.g.vassilev > wrote: > >> In D96033#2766332 , @phosek wrote: >> >>> We've started

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

dmgreen accepted this revision. dmgreen added a comment. Sorry. I think we were waiting for the foldl comment to be removed. If you remove that, this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238

[PATCH] D102714: [clang-tidy] Fix a crash on invalid code for memset-usage check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f36306cc9ac: [clang-tidy] Fix a crash on invalid code for memset-usage check. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9f36306 - [clang-tidy] Fix a crash on invalid code for memset-usage check.

Author: Haojian Wu Date: 2021-05-19T09:53:18+02:00 New Revision: 9f36306cc9ac6d1d1019831d40865d0d54563379 URL: https://github.com/llvm/llvm-project/commit/9f36306cc9ac6d1d1019831d40865d0d54563379 DIFF: https://github.com/llvm/llvm-project/commit/9f36306cc9ac6d1d1019831d40865d0d54563379.diff

<    1   2