[PATCH] D105331: [CFE][X86] Enable complex _Float16.

LuoYuanke added a comment. Would you check the failure of the test cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105331/new/ https://reviews.llvm.org/D105331 ___ cfe-commits mailing list

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

benshi001 updated this revision to Diff 365089. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107682/new/ https://reviews.llvm.org/D107682 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/test/Driver/avr-toolchain.c

[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

kbobyrev updated this revision to Diff 365094. kbobyrev marked 15 inline comments as done. kbobyrev added a comment. Thank you for the great suggestions! Indeed, we already have the confusion regarding IWYU having the CLI flag and users are thinking we provide some sort of

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

NoQ added a comment. In D107078#2927899 , @steakhal wrote: > I did not fix the extra blue 'bubble' note issue, and I think that is out of > the scope of this patch. This is an on-by-default checker. We should not knowingly regress it, even if

[PATCH] D101641: [Sema] Preserve invalid CXXCtorInitializers using RecoveryExpr in initializer

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4475 // name that denotes that base class type. - bool Dependent = BaseType->isDependentType() ||

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM, but may wait 1 or 2 days for the comments from others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105263/new/

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff added a comment. In D104854#2932444 , @nemanjai wrote: > Rather than reverting this commit again, I pushed 62fe3dcf98d1 > to use > the same expansion as before (using

[PATCH] D107137: clangd: Provide hover info for include directives

ckandeler added a comment. Thanks for the review. Can you please merge it? I don't have the permissions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107137/new/ https://reviews.llvm.org/D107137 ___

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

MTC added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:454 + + if (AllFieldsToInit.empty()) +return; MTC wrote: > `FieldsToInit` being empty implies `AllFieldsToInit` is empty. We have > checked

[clang] f9ffe61 - [OpenCL] Factor out OpenCLBuiltinFileEmitterBase; NFC

Author: Sven van Haastregt Date: 2021-08-09T11:41:25+01:00 New Revision: f9ffe61fb53f595b7be136c340508c094482fcff URL: https://github.com/llvm/llvm-project/commit/f9ffe61fb53f595b7be136c340508c094482fcff DIFF:

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Btw I think we could also use this helper in another diagnostic (`err_opencl_unknown_type_specifier`) in `include/clang/Basic/DiagnosticCommonKinds.td`. But it can be

[PATCH] D107693: [Parser] Fix attr infloop on "int x [[c"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107693/new/ https://reviews.llvm.org/D107693

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2934378 , @erichkeane wrote: > I've just been watching this from the sideline, but the cases where this > breaks code are unacceptable for this tool, it is a complete direction change > for the tool, and making

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39ca3e5541d0: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX (authored by madanial, committed by Whitney). Changed prior

[clang] 39ca3e5 - Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

Author: Mark Danial Date: 2021-08-09T14:57:38Z New Revision: 39ca3e5541d0f9634ee22e3bcd932c47cb37306a URL: https://github.com/llvm/llvm-project/commit/39ca3e5541d0f9634ee22e3bcd932c47cb37306a DIFF: https://github.com/llvm/llvm-project/commit/39ca3e5541d0f9634ee22e3bcd932c47cb37306a.diff LOG:

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 365134. v.g.vassilev added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst clang/examples/CMakeLists.txt

[PATCH] D102325: [clang-tidy] cppcoreguidelines-virtual-base-class-destructor: a new check

mgartmann updated this revision to Diff 365161. mgartmann added a comment. - Updated this patch with the current state of the LLVM project GitHub repository Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102325/new/

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

sammccall added a comment. For my part, I'm convinced and now +1 (or at least +0.5) on this being OK to include. In users' minds this is a formatting/style operation, and the UX of clang-format and its integrations is much better than clang-tidy. Implementation quality problems are a risk, but

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

akuegel added a comment. Already landed as https://github.com/llvm/llvm-project/commit/19bd806a1a443e4ce45ccc670861848fb1579022, I will close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760

[PATCH] D107703: [AST][clangd] Expose documentation of Attrs on hover.

aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:4220 + )cpp"; + std::vector Attrs = Records.getAllDerivedDefinitions("Attr"); + for (const auto *A : Attrs) { FWIW, this will miss `omp::sequence` and `omp::directive`,

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane added a comment. In D69764#2934473 , @MyDeveloperDay wrote: > In D69764#2934378 , @erichkeane > wrote: > >> I've just been watching this from the sideline, but the cases where this >> breaks code are

[PATCH] D105331: [CFE][X86] Enable complex _Float16.

pengfei added a comment. In D105331#2933893 , @LuoYuanke wrote: > Would you check the failure of the test cases? They failed due to they are built based on the ToT instead of the 1st patch of FP16. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added subscribers: djasper, klimek. MyDeveloperDay added a comment. In D69764#2932929 , @steveire wrote: > @steveire, thanks for your comments, I also agree that a second tool shouldn't be needed, especially as this functionality is off

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 marked an inline comment as done. gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120 + OptimizationRemarkEmitter *ORE, + OptimizationRemark OptRemark) { + ORE->emit([&]() { return

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12120 + OptimizationRemarkEmitter *ORE, + OptimizationRemark OptRemark) { + ORE->emit([&]() { return OptRemark; }); gandhi21299 wrote: >

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 364891. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - turned reportAtomicExpand(...) into a lambda as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane added a comment. In D69764#2934489 , @MyDeveloperDay wrote: > In D69764#2934378 , @erichkeane > wrote: > >> I've just been watching this from the sideline, but the cases where this >> breaks code are

[PATCH] D105462: [X86] Add CRC32 feature.

pengfei added inline comments. Comment at: clang/lib/Headers/crc32intrin.h:13 + +#define __DEFAULT_FN_ATTRS \ + __attribute__((__always_inline__, __nodebug__, __target__("crc32"))) Better to follow Lint's suggestions. Comment at:

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

Whitney added a comment. In D106815#2926363 , @madanial wrote: > I need some help to commit this change as I do not have commit access as of > now. I will commit it for you today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5f99670 - [RISCV] Half-precision for vget/vset.

Author: Hsiangkai Wang Date: 2021-08-09T17:38:15+08:00 New Revision: 5f996705e0cadc43771da12dec0670680230ca56 URL: https://github.com/llvm/llvm-project/commit/5f996705e0cadc43771da12dec0670680230ca56 DIFF:

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f996705e0ca: [RISCV] Half-precision for vget/vset. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107433/new/

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

steakhal updated this revision to Diff 365133. steakhal marked 2 inline comments as done. steakhal added a comment. Removed the extra note about the temporary expression. --- In D107078#2933682 , @NoQ wrote: > In D107078#2927899

[PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. Herald added subscribers: libcxx-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwind. gAlfonso-bit requested review of this revision. Herald added

[PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365039. Herald added a subscriber: JDevlieghere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365066. gandhi21299 added a comment. refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: llvm/include/llvm/CodeGen/TargetLowering.h

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

klimek added a comment. In D69764#2934032 , @MyDeveloperDay wrote: > In D69764#2932929 , @steveire wrote: > >> > > @steveire, thanks for your comments, I also agree that a second tool > shouldn't be needed,

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2934124 , @klimek wrote: > In D69764#2934032 , @MyDeveloperDay > wrote: > >> It was suggested to me that I write up and RFC on the matter, I'm not a >> massive fan of

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

aaron.ballman added a comment. It looks like there are still test failures happening from these changes. We're now getting more `return state set for an unconsumable type ` diagnostics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. I've just been watching this from the sideline, but the cases where this breaks code are unacceptable for this tool, it is a complete direction change for the tool, and

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. Thank you for working on this, I think it's fantastic functionality! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope)

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

balazske updated this revision to Diff 365175. balazske added a comment. Simplified a lambda usage. Moved some functions, changed documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106644/new/ https://reviews.llvm.org/D106644 Files:

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

zahiraam added a comment. This patch was reverted because SPEC2006 and SPEC2017 are failing. More information here: https://bugs.llvm.org/show_bug.cgi?id=51346 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added a comment. thanks, mostly looks good couple of nits! Comment at: clang-tools-extra/clangd/CollectMacros.cpp:42 +if (isInsideMainFile(Loc, SM)) { + Position Start = sourceLocToPosition(SM, Loc); + Position End = {Start.line + 1, 0};

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > It _IS_ a democracy where we can find a fair consensus! And the mechanism > with which to obtain said `fair consensus` is an RFC. Then I think in the interest of finding one we should start with the RFC. CHANGES SINCE LAST ACTION

[clang] 19bd806 - [OpenCL] Add missing virtual destructor

Author: Sven van Haastregt Date: 2021-08-09T13:49:52+01:00 New Revision: 19bd806a1a443e4ce45ccc670861848fb1579022 URL: https://github.com/llvm/llvm-project/commit/19bd806a1a443e4ce45ccc670861848fb1579022 DIFF:

[PATCH] D107506: [PowerPC][AIX] Warn when using pragma align(packed) on AIX.

cebowleratibm accepted this revision. cebowleratibm added a comment. The new version is better than the previous. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107506/new/ https://reviews.llvm.org/D107506

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

cebowleratibm added a comment. In D107242#2932289 , @joerg wrote: > I'm puzzled by this change. I don't think we have any case so far where the > compiler behavior changes with the host OS and I don't think it should. > What's the point / use case of

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4441 if (Linkage != llvm::GlobalValue::InternalLinkage && - (D->hasAttr() || D->hasAttr())) + (D->hasAttr() || D->hasAttr() || +

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna updated this revision to Diff 365179. Topotuna added a comment. Diagnostic `err_opencl_unknown_type_specifier` addressed. Deprecation conditions changed in `nosvm` attribute test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107648/new/ https://reviews.llvm.org/D107648

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane added a comment. In D69764#2934535 , @MyDeveloperDay wrote: >> My 'requires changes' is that this needs an LLVM-project-level RFC to change >> the charter of one of its projects, doing so in a 15 month long patch, >> against the wishes of

[PATCH] D107760: [lldb] Fix warning -Wnon-virtual-dtor.

akuegel created this revision. akuegel added a reviewer: bkramer. akuegel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When making the emit function virtual, the destructor needs to become virtual as well. Repository: rG LLVM Github

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:136 +CheckFactories.registerCheck( +"readability-variable-length"); } 0x8000- wrote: > aaron.ballman wrote: > > Is there a

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

peixin updated this revision to Diff 365170. peixin added a comment. Revise the implementation by not generating "kmp_ordered" runtime functions when -fopenmp-enable-irbuilder is not enabled, which is consistent with that not using OpenMPIRBuilder. CHANGES SINCE LAST ACTION

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2934483 , @erichkeane wrote: > In D69764#2934473 , @MyDeveloperDay > wrote: > >> In D69764#2934378 , @erichkeane >> wrote: >> >>>

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > My 'requires changes' is that this needs an LLVM-project-level RFC to change > the charter of one of its projects, doing so in a 15 month long patch, > against the wishes of TWO maintainers is a violation of the LLVM community > practice. I'm completely

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

zahiraam added a comment. This patch had to be reverted because SPEC2006 and SPEC2017 are failing. More information here: https://bugs.llvm.org/show_bug.cgi?id=51346 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna updated this revision to Diff 365157. Topotuna added a comment. Herald added a subscriber: dexonsmith. Diagnostics reworded. Helper function `getOpenCLVersionString()` added. Tests updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107648/new/

[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 365159. Sockke added a comment. Format and add some description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107641/new/ https://reviews.llvm.org/D107641 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

Quuxplusone added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:311 : OpenCLBuiltinFileEmitterBase(Records, OS) {} + virtual ~OpenCLBuiltinTestEmitter() = default; Tip: When you're putting a defaulted virtual

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2934378 , @erichkeane wrote: > I've just been watching this from the sideline, but the cases where this > breaks code are unacceptable for this tool, it is a complete direction change > for the tool, and making

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel added a comment. > Main points in the implementation are: > > - simplify the exposed interface Good point, I added a new function `indexStandardLibrary()` as external interface. > - i don't think we need to mess with VFS at all actually Yes, removed that. > - we should think a little

[PATCH] D105177: [clangd] Implemented indexing of standard library

kuhnel updated this revision to Diff 365181. kuhnel marked 29 inline comments as done. kuhnel edited the summary of this revision. kuhnel added a comment. Herald added a subscriber: mgrang. addressed code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope) { aaron.ballman wrote: > Should we also add some

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:599 * SPIR +* X86 Might be worth mentioning that it requires AVX512FP16 here Comment at: clang/lib/CodeGen/TargetInfo.cpp:2817 Current = SSE; +}

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2934666 , @erichkeane wrote: >> Someone internally pointed out the anti-inclusivity of the terminology, so I >> figured I'd bring it up. I apologise if I'm proliferating that, but could you educate me why its

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

erichkeane added a comment. In D69764#2935218 , @MyDeveloperDay wrote: > In D69764#2934666 , @erichkeane > wrote: > >>> Someone internally pointed out the anti-inclusivity of the terminology, so >>> I figured

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > I was referring to @rsmith and @aaron.ballman (to clarify), both are > maintainers in 'clang', the former of which is the 'superset' maintainer of > this format project based on its directory. While Aaron is a peer-maintainer > to this project, his

[PATCH] D106644: [clang][analyzer] Add standard streams to alpha.unix.Stream checker.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It's fine on my part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106644/new/ https://reviews.llvm.org/D106644

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope) { sammccall wrote: > aaron.ballman wrote: > >

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

hliao added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4441 if (Linkage != llvm::GlobalValue::InternalLinkage && - (D->hasAttr() || D->hasAttr())) + (D->hasAttr() || D->hasAttr() || +

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall planned changes to this revision. sammccall added a comment. Thanks, I know what to do next! While I have you here, any thoughts on future patches: > Only the bare name is completed, with no args. > For args to be useful we need arg names. These *are* in the tablegen but > not

[PATCH] D107667: [clang/test] Run thinlto-clang-diagnostic-handler-in-be.c on x86

steven_wu added a comment. Please don't use `x86_64` as target or triple since it might default to some weird platform. Can you spell out a valid triple/platform? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107667/new/

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

arsenm added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:626-632 + if (AI->isFloatingPointOperation()) +emitAtomicExpansionRemarks( +AI, Kind, +Remark << "A hardware CAS loop generated: if the memory is " +

[PATCH] D107633: Set supported target for asan-use-callbacks test

vitalybuka added a comment. Why other tests, like CodeGen/asan-strings.c do not need REQUIRES: ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/ https://reviews.llvm.org/D107633 ___

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2935036 , @klimek wrote: > Happy to go the RFC route if @MyDeveloperDay wants to do that. I'm happy to do that (in fact I've written a draft), do people want to code review the RFC draft (as I could easily be

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. Alright, I think we're almost ready to go! I left a few comments, please make sure to mark those done that you feel are properly addressed. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:393-394 + /// in this sense if a resource

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2934612 , @MyDeveloperDay wrote: >> I was referring to @rsmith and @aaron.ballman (to clarify), both are >> maintainers in 'clang', the former of which is the 'superset' maintainer of >> this format project

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

yaxunl added a comment. LGTM on HIP side. I am not sure whether CUDA needs this. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4441 if (Linkage != llvm::GlobalValue::InternalLinkage && - (D->hasAttr() || D->hasAttr())) + (D->hasAttr() || D->hasAttr()

[PATCH] D104854: Introduce intrinsic llvm.isnan

nemanjai added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:6964 +return DAG.getSetCC(DL, ResultVT, Op, DAG.getConstantFP(0.0, DL, OperandVT), +ISD::SETUO); + sepavloff wrote: > nemanjai wrote: > >

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365199. gandhi21299 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

gandhi21299 updated this revision to Diff 365202. gandhi21299 added a comment. - emit CAS loop remark only if the instruction is of floating point type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D107633: Set supported target for asan-use-callbacks test

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. All but line 1 is LGTM Line 1 is probably not needed, but I don't know why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107633/new/

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 365253. JonasToth added a comment. - retry upload of patch to be a diff to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers added a comment. I'll add a test and repost. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 ___ cfe-commits mailing list

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit created this revision. gAlfonso-bit added reviewers: clang, LLVM. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ObjCObjectPointer is NOT a type specifier, so remove it from the list Repository: rG LLVM

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. Whats left from my personal todo is adjusting the documentation. I think then this check can work as linter and if you want as fixer as well, but this has to be enable explicitly. I think that fixing still has more value than harm, e.g. in your IDE/editor. The most

[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

joerg added a comment. clang is fundamentally a cross-compiler only. I don't see any point for having host-specific branches in this case at all. Either the macro should be specified for the target all the time or not at all, but it should most definitely not depend on the host. That's

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > I find it weird that we aren't handling ALL of the CV qualifiers. I will probably try and address this, I do have some ideas, but this will I believe complicate the implementation. For now I really want to understand if conceptually such a feature can be

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 365252. JonasToth marked an inline comment as done. JonasToth added a comment. - rebase to master - fix a crash where a scope matched but non of its variables, leading to nullptr dereference (found with the current test-suite) - remove outcommenting of

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 365257. JonasToth marked 4 inline comments as done. JonasToth added a comment. - remove transformation as default option, now it must be activated by the user explicitly - register only for C++ - add a test-case for VLAs Repository: rG LLVM Github

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2935269 , @erichkeane wrote: > In D69764#2935218 , @MyDeveloperDay > wrote: > >> In D69764#2934666 , @erichkeane >> wrote: >>

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added reviewers: Anastasia, airlied, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Currently, -fdeclare-opencl-builtins always adds the

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. CUDA lowers texture/surface types into a special handle. I do not think `externally_initialized` matters for it. AFAICT this change is a no-op for CUDA. Repository: rG LLVM Github Monorepo

[clang] 6ec36d1 - [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

Author: Michael Liao Date: 2021-08-09T13:27:40-04:00 New Revision: 6ec36d18ec7b29b471bbe50502beb5b35de3975c URL: https://github.com/llvm/llvm-project/commit/6ec36d18ec7b29b471bbe50502beb5b35de3975c DIFF: https://github.com/llvm/llvm-project/commit/6ec36d18ec7b29b471bbe50502beb5b35de3975c.diff

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec36d18ec7b: [cuda] Mark builtin texture/surface reference variable as… (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107718/new/

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. In D107696#2934881 , @sammccall wrote: > Thanks, I know what to do next! > > While I have you here, any thoughts on future patches: > >> Only the bare name is completed, with no args. >> For args to be useful we need arg

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 365249. gAlfonso-bit added a comment. Remove other changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:441 + if (Preamble) +Marks = Preamble->Marks; + Clang->getPreprocessor().addPPCallbacks(

  1   2   >