[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1623 if (!Constraint.containsZero()) { - State = RCM.assumeSymNE(State, LHS, Zero, Zero); + State = RCM.assumeSymRel(State, LHS, BO_NE, Zero); if (!State)

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou added a comment. ping Just a ping, to see if there are any comments :-P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112050/new/ https://reviews.llvm.org/D112050 ___ cfe-commits mailing

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf added a comment. I think this should work-around end-to-end test failure on Windows: diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test index 1197e1ab07c3..68ef54808f09 100644 --- a/clang-tools-extra/clangd/test/crash.test +++

[clang-tools-extra] 51be706 - [clangd] Remove tricky integration test that flakes/fails on some platforms.

Author: Sam McCall Date: 2021-10-26T14:19:05+02:00 New Revision: 51be7061d025139ba66869d5d99c7157a3ae9edd URL: https://github.com/llvm/llvm-project/commit/51be7061d025139ba66869d5d99c7157a3ae9edd DIFF: https://github.com/llvm/llvm-project/commit/51be7061d025139ba66869d5d99c7157a3ae9edd.diff

[PATCH] D109506: [clangd] Print current request context along with the stack trace

thakis added a comment. Thanks for the fixes! My bots are happy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 ___ cfe-commits mailing list

[PATCH] D112398: [RISCV] Add ABI testing for Float16.

frasercrmck added a comment. It looks as though all checks are checking the same thing? Presumably this is expected? I wonder if allowing an extra combined check (`--check-prefixes=CHECK,CHECK-ZFH-ILP32F` or something) would make it more obvious when things *are* different between the

[PATCH] D112334: [clang-tidy] Suppress readability-static-access-through-instance for CUDA built-in variables

carlosgalvezp added a comment. @whisperity Understood, thanks for the help! I'll take more care to remember the reference next time :) I added it as a comment in Github for reference so there's at least some traceability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112334/new/

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

fhahn created this revision. fhahn added reviewers: aaron.ballman, erichkeane, rjmccall. Herald added a subscriber: tschuett. fhahn requested review of this revision. Herald added a project: clang. Replace some custom matrix diagnostic kinds with the more generic err_builtin_invalid_arg_type

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:271 + DeclForComment = TSD->getSpecializedTemplate(); if (const auto *TIP =

[PATCH] D112459: [AArch64] Enablement of Cortex-X2

mubashar_ updated this revision to Diff 382309. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Made adjustments to AArch64.td and AArch64Subtarget.cpp files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112459/new/ https://reviews.llvm.org/D112459 Files:

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:284 +// Remove the template arguments from the name. +NameRange =

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske updated this revision to Diff 382312. balazske added a comment. Improved the documentation. Small code layout changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409 Files:

[PATCH] D111529: Specify Clang vector builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rG025988ded6b2: Specify Clang vector builtins. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111529/new/

[clang] 025988d - Specify Clang vector builtins.

Author: Florian Hahn Date: 2021-10-26T15:34:31+01:00 New Revision: 025988ded6b2a57022dbf9775f35a1a933584bfa URL: https://github.com/llvm/llvm-project/commit/025988ded6b2a57022dbf9775f35a1a933584bfa DIFF: https://github.com/llvm/llvm-project/commit/025988ded6b2a57022dbf9775f35a1a933584bfa.diff

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:328 Opts["cert-str34-c.DiagnoseSignedUnsignedCharComparisons"] = "false"; +Opts["cert-err33-c.CheckedFunctions"] = CertErr33CCheckedFunctions; return Options;

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. And make it final while here. No behavior change. https://reviews.llvm.org/D112542 Files: clang/include/clang/AST/StmtObjC.h Index: clang/include/clang/AST/StmtObjC.h

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/lib/Sema/SemaChecking.cpp:3382 +if (() != ::APFloat::PPCDoubleDouble()) + return Diag(TheCall->getBeginLoc(),

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

MyDeveloperDay added a comment. @lodato are you blocking this review for a reason? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90996/new/ https://reviews.llvm.org/D90996 ___ cfe-commits mailing list

[clang-tools-extra] e8f4a01 - [clangd] Fix a hover crash on templated spaceship operator.

Author: Adam Czachorowski Date: 2021-10-26T17:28:40+02:00 New Revision: e8f4a01189143854f30e2bb622baa729a42f152d URL: https://github.com/llvm/llvm-project/commit/e8f4a01189143854f30e2bb622baa729a42f152d DIFF:

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8f4a0118914: [clangd] Fix a hover crash on templated spaceship operator. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. In D112409#3087517 , @carlosgalvezp wrote: >> I was not sure how the aliasing is to be handled if the check is not exactly >> the same as the original. > > I agree that the alias

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nathanchance added a comment. `check-llvm` does not pass with this revision nor does it resolve the boot failure that Nick mentioned, just in case that was the intention of the revision :) I ran the kernel through `gdb` and it still does not appear to get to `start_kernel`. Repository: rG

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn added a comment. In D110065#3087330 , @labrinea wrote: > Added v8.1a_ops on AppleA10. However, the target parser lists it as v8.0a, > which seems odd. Out of the scope of this patch anyway. Looking at the definition of A10 in target parser

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

tlively added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18262-18267 +case WebAssembly::BI__builtin_wasm_relaxed_trunc_zero_s_i32x4_f64x2: + IntNo = Intrinsic::wasm_relaxed_trunc_zero_signed; + break; +case

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added a comment. In D111400#3087877 , @aaron.ballman wrote: > So your concern is that allowing this patch to be used as an extension in > older language modes may change the behavior of existing code? Or is your > concern more

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1643-1654 + const VarRegion *VR = dyn_cast(R->getSuperRegion()); + SmallVector SValOffsets; + SValOffsets.push_back(R->getIndex()); + if (const ElementRegion *ER =

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1011 + case PPC::TDI: + case PPC::TWI: { +MachineInstr *LiMIA = getVRegDefOrNull((1), MRI); nemanjai wrote: > Seems that we should be able to handle all 4 in the

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske marked 8 inline comments as done. balazske added a comment. I was not sure how the aliasing is to be handled if the check is not exactly the same as the original. (This was a topic on the mailing list.) I like it more if only those checks are aliases that are exactly the same. But for

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131 +; CHECK: # %bb.0: +; CHECK-NEXT:tdi 3, 3, 32767 +; CHECK-NEXT:blr nemanjai wrote: > Can we add `-ppc-asm-full-reg-names` to the RUN

Re: [PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

Yes, I'm aware and actively working on this one. I think I have the fix but I'm trying to run all the tests (Clang etc) to make sure it doesn't break anything else. On Tue, Oct 26, 2021 at 5:01 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > >

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unused-return-value.rst:31 semget, setjmp, shm_open, shmget, sigismember, strcasecmp, strsignal, ttyname`` Change this to a list? Repository: rG LLVM

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap F128Builtins{ + {Builtin::BI__builtin_printf, "__printfieee128"}, + {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"}, Why only these printf

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2174524116a8: [clangd] AddUsing: Fix support for template specializations. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 2174524 - [clangd] AddUsing: Fix support for template specializations.

Author: Adam Czachorowski Date: 2021-10-26T17:32:33+02:00 New Revision: 2174524116a8379fb7a6453253524ec972b158df URL: https://github.com/llvm/llvm-project/commit/2174524116a8379fb7a6453253524ec972b158df DIFF:

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

This revision was automatically updated to reflect the committed changes. fhahn marked 3 inline comments as done. Closed by commit rG1ef25d28c19e: [Clang] Add elementwise min/max builtins. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1ef25d2 - [Clang] Add elementwise min/max builtins.

Author: Florian Hahn Date: 2021-10-26T16:53:40+01:00 New Revision: 1ef25d28c19e3b2e956ffcb39c91f98c154f9b3f URL: https://github.com/llvm/llvm-project/commit/1ef25d28c19e3b2e956ffcb39c91f98c154f9b3f DIFF: https://github.com/llvm/llvm-project/commit/1ef25d28c19e3b2e956ffcb39c91f98c154f9b3f.diff

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D111400#3052314 , @hubert.reinterpretcast wrote: > I am concerned that the general direction of this patch (to allow the > previously ill-formed constexpr functions as an

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

fhahn updated this revision to Diff 382373. fhahn marked an inline comment as done. fhahn added a comment. Reabsed after landing D111985 . Also turned the custom message parts into a select as suggested. In D112532#3087371

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

sugak added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5640 + DeducedTemplateSpecializationType::Profile( + ID, Template, DeducedType, IsDependent || Template.isDependent()); if (DeducedTemplateSpecializationType *DTST = bruno wrote: >

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

sugak updated this revision to Diff 382375. sugak added a comment. Updated following @bruno's suggestion, and fixed tests (thanks @weiwang)! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112481/new/ https://reviews.llvm.org/D112481 Files:

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 382397. jcking1034 marked an inline comment as done. jcking1034 added a comment. Update comment with example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:140 +// locations for the found macros. +void findReferencedMacros(ParsedAST , ReferencedLocations ) { + auto Tokens = sammccall wrote: > sammccall wrote: > > can you add a

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382221. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Try another strategy to reduce the number of processed tokens (doesn't work in all cases). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

benshi001 created this revision. benshi001 added reviewers: tra, fodinabor, Hahnfeld, yaxunl. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112521 Files:

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 382240. fhahn added a comment. Rebased after recent changes in D111985 https://reviews.llvm.org/D111985: changes the return type of SemaBuiltinReduceMath to bool and drop the CallResult argument. Also added tests with const

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

whisperity added a comment. I think this is becoming okay and looks safe enough. I can't really grasp what `HasCheckedMoveSet` means, and how it synergises with storing `CallExpr`s so maybe a better name should be added. Do you mean `AlreadyCheckedMoves`? When is it possible that the same

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, just some nits. Comment at: clang/lib/Analysis/CFG.cpp:485 - // This can point either to a try or a __try block. The frontend forbids - // mixing both kinds in one

[PATCH] D111985: [Clang] Add elementwise min/max builtins.

fhahn marked 3 inline comments as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8747-8748 +def err_elementwise_math_arg_types_mismatch : Error < + "argument types do not match, %0 != %1">; + aaron.ballman

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske updated this revision to Diff 382323. balazske added a comment. Added to release notes, added new links to documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409 Files:

[PATCH] D112491: Add `LambdaCapture`-related matchers.

ymandel added a comment. Nice! Per Aaron's comment, it's probably worth expanding the patch description to explain the motivation. I assume that the key is making these first-class and therefore bindable? Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:170

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. No behavior change. https://reviews.llvm.org/D112543 Files: clang/include/clang/AST/StmtObjC.h clang/lib/AST/StmtPrinter.cpp clang/lib/Analysis/CFG.cpp clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz updated this revision to Diff 382335. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz removed a reviewer: usaxena95. adamcz added a comment. Thanks Kadir! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 ___ cfe-commits mailing list

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:46-49 +if (Assumption) { + return assumeSymRel(State, SIE, BO_NE, Zero); +} +return assumeSymRel(State, SIE, BO_EQ, Zero); Repository:

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:181 } + if (MinVLen) { please add a note in commit or comment here for those macros are proposed in the PR https://github.com/riscv-non-isa/riscv-c-api-doc/pull/21

[PATCH] D112559: [clangd] Fix filename ranges while replaying preamble

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Wow, nice find! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112559/new/ https://reviews.llvm.org/D112559

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 382391. jcking1034 marked 3 inline comments as done. jcking1034 added a comment. Revert changes to ASTMatchFinder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491

[PATCH] D90996: [clang-format] Add --staged/--cached option to git-clang-format

lodato accepted this revision. lodato added a comment. This revision is now accepted and ready to land. Oops, I'm sorry. I meant to test it but ran out of time and then forgot to click approve. My apologies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0350672 - [clang] Do not traverse EnumDecl's type in RecursiveASTVisitor

Author: Kirill Bobyrev Date: 2021-10-26T17:17:10+02:00 New Revision: 03506722e0c348ce52d87f7f37f024d7adec5c43 URL: https://github.com/llvm/llvm-project/commit/03506722e0c348ce52d87f7f37f024d7adec5c43 DIFF:

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382358. kbobyrev added a comment. Add an elaborate comment on potential future improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files:

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov updated this revision to Diff 382361. ASDenysPetrov added a comment. @martong @steakhal Thank you for your remarks. Updated according to them (at least the best I could do for now). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111654/new/

Re: [PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

Hey Kirill, If you mean removing traversal of the enumdecl->enumtype in RecursiveASTVisitor, that's a subtle change that potentially affects a lot of callers. We'd need to be able to revert it, so we shouldn't rely on it to get the tests back to green. It looks like there's a single assertion

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn updated this revision to Diff 382376. fhahn marked 2 inline comments as done. fhahn added a comment. Rebased and updated to use `err_builtin_invalid_arg_type`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111986/new/

[PATCH] D111986: [Clang] Add elementwise abs builtin.

fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8754 +def err_elementwise_math_invalid_arg_type_2: Error < + "argument must have a %0 type, but was %1">; + aaron.ballman wrote: > I feel like we must already have a

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

nickdesaulniers added a comment. thanks for this patch @mstorsjo ! This is help AOSP LLVM move our windows builds of LLVM away from MinGW to LLVM! https://android-review.googlesource.com/c/toolchain/llvm_android/+/1867380/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112519: parallel-libs: remove some artifacts

dblaikie added inline comments. Comment at: clang/docs/ClangFormattedStatus.rst:7807-7821 - * - parallel-libs/acxxel - - `6` - - `4` - - `2` - - :part:`66%` - * - parallel-libs/acxxel/examples - - `1` I didn't touch this because I think

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-err33-c.rst:1 +.. title:: clang-tidy - cert-err33-c + carlosgalvezp wrote: > I believe we usually mention that this is an alias to another check, and then > redirect the

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz updated this revision to Diff 382326. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ https://reviews.llvm.org/D112527 Files:

[PATCH] D112209: [clangd] IncludeCleaner: Complicated rules for enum usage

thakis added a comment. Follow-up commit https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897 (which doesn't seem to have its own phab link) broke clangd tests everywhere, e.g. http://45.33.8.238/linux/59134/step_9.txt Please take a look. This is like the

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382337. serge-sans-paille added a comment. - Add a test case to ensure we keep the right behavior for non-intrinsic gnu inline - walk the redecl chain before doing an extra string alloc CHANGES SINCE LAST ACTION

[PATCH] D112059: Fix inline builtin handling in case of redefinition

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though codegen is not my area of expertise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1623 if (!Constraint.containsZero()) { - State = RCM.assumeSymNE(State, LHS, Zero, Zero); + State =

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1706-1743 + // Check offsets for being out of bounds. // C++20 [expr.add] 7.6.6.4 (excerpt): // If P points to an array element i of an array object x with n // elements,

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong updated this revision to Diff 382367. martong added a comment. - Remove superflous change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112296/new/ https://reviews.llvm.org/D112296 Files:

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16654 +Diag(PtrExpr->getBeginLoc(), diag::err_builtin_invalid_arg_type) +<< PtrArgIdx + 1 << "pointer to a valid matrix element type" +<< PtrExpr->getType(); erichkeane

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

ASDenysPetrov requested changes to this revision. ASDenysPetrov added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:44-49 +// Handle adjustment with non-comparison ops. +const

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo added a comment. In D100756#3088035 , @nickdesaulniers wrote: > thanks for this patch @mstorsjo ! This is help AOSP LLVM move our windows > builds of LLVM away from MinGW to LLVM! >

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam updated this revision to Diff 382392. zahiraam marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112094/new/ https://reviews.llvm.org/D112094 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

aaron.ballman added a comment. In D107450#3087103 , @whisperity wrote: > There has been a new release since the patch was proposed so a rebase should > be needed. > @aaron.ballman What do you think, does this warrant a ReleaseNotes entry? I think a

[PATCH] D112459: [AArch64] Enablement of Cortex-X2

mubashar_ added a comment. Addressed comments from @dmgreen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112459/new/ https://reviews.llvm.org/D112459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

carlosgalvezp added a comment. > I was not sure how the aliasing is to be handled if the check is not exactly > the same as the original. I agree that the alias situation is a bit of a mess. I'll leave it to people with stronger opinion/experience. Repository: rG LLVM Github Monorepo

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

ASDenysPetrov added inline comments. Comment at: clang/test/Analysis/initialization.cpp:17-23 -int const arr[2][2] = {}; -void arr2init() { - int i = 1; - // FIXME: Should recognize that it is 0. - clang_analyzer_eval(arr[i][0]); // expected-warning{{UNKNOWN}} -} -

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382344. serge-sans-paille added a comment. Formatting nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[clang] c184072 - [analyzer] Fix StringChecker for Unknown params

Author: Balazs Benics Date: 2021-10-26T18:15:00+02:00 New Revision: c18407217e91abea73555e07956d7132dd093bd2 URL: https://github.com/llvm/llvm-project/commit/c18407217e91abea73555e07956d7132dd093bd2 DIFF: https://github.com/llvm/llvm-project/commit/c18407217e91abea73555e07956d7132dd093bd2.diff

[PATCH] D112551: [analyzer] Fix StringChecker for Unknown params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc18407217e91: [analyzer] Fix StringChecker for Unknown params (authored by steakhal). Herald added a project: clang. Herald added a subscriber:

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong updated this revision to Diff 382362. martong added a comment. - Handle adjustment in `assumeSym` for non-comparison ops. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112296/new/ https://reviews.llvm.org/D112296 Files:

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:52 + + if (const SymSymExpr *SSE = dyn_cast(Sym)) { BinaryOperator::Opcode Op = SSE->getOpcode(); Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16582 +Diag(Matrix->getBeginLoc(), diag::err_builtin_invalid_arg_type) +<< 1 << 1 << Matrix->getType(); return ExprError(); 1 nit: On the 'select' lines, please put a

[PATCH] D112559: [clangd] Fix filename ranges while replaying preamble

kadircet created this revision. kadircet added reviewers: sammccall, nridge. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Clangd used first token

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3608-3609 +within a language linkage specification or at the start of a compound statement +(excluding comments). When used within a compound statement, the pragma is +active within the scope of the

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 382225. eopXD added a comment. Fix test fail and clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 382244. linjamaki added a comment. Improve `--offload` option description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files:

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382278. kbobyrev added a comment. Rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D112532: [Matrix] Replace some err kinds with err_builtin_invalid_arg_type. (NFC)

aaron.ballman added a comment. In general, I like the direction of this cleanup. Thanks! In D112532#3087293 , @erichkeane wrote: > I'm fine with this change in general... but did this not manage to break any > tests? Precommit CI says things are

[PATCH] D112521: [CUDA][NFC] Fix inexact warning message about lambdas

benshi001 added a comment. Acutally lambdas with CUDA attributes can have non-empty parameter list, and the original warning message is inexact. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112521/new/ https://reviews.llvm.org/D112521

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, let's ship it! Only nits on the text, feel free to ignore any you don't like Comment at: clang-tools-extra/clangd/ConfigFragment.h:213 +/// Controls how

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, Oct 25, 2021 at 8:41 PM Nico Weber wrote: > > Was this reviewed anywhere? Post-commit review (as attribute code owner). > I'll note that some internal project apparently used to check `#if > __has_attribute(__unsafe_unretained)`. That used to silently (and incorrectly > I think)

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, yaxunl. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We make assumption that:

  1   2   3   >