[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after pars

2021-12-02 Thread James Farrell via Phabricator via cfe-commits
jamesfarrell updated this revision to Diff 391323. jamesfarrell added a comment. Don't use the preprocessor to hide test cases, so we can at least tell if it compiles when testing on platforms other than Apple and AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114890: [OpenMP] Make the new device runtime the default

2021-12-02 Thread Joseph Huber via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc99407e31c39: [OpenMP] Make the new device runtime the default (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c99407e - [OpenMP] Make the new device runtime the default

2021-12-02 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2021-12-02T11:11:45-05:00 New Revision: c99407e31c3977bf397531bf115a63b0fda68e4d URL: https://github.com/llvm/llvm-project/commit/c99407e31c3977bf397531bf115a63b0fda68e4d DIFF: https://github.com/llvm/llvm-project/commit/c99407e31c3977bf397531bf115a63b0fda68e4d.diff

[PATCH] D114890: [OpenMP] Make the new device runtime the default

2021-12-02 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. thx for trying it out, please revert so we can look into it more on the AMDGPU target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

2021-12-02 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Here is a smaller reproducer: void bar(short k) { ++k; // k1 = k0 + 1 assert(k == 1); // k1 == 1 --> k0 == 0 (long)k << 16; // k0 + 1 << 16 } And the explanation is the following. With this patch, when the analyzer evaluates the `(long)k

[clang] 2a2b3a3 - [clang-cl] Define _MSVC_LANG for -std=c++2b

2021-12-02 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-12-02T12:09:20-05:00 New Revision: 2a2b3a3e3df7b89e18be9ffab1e08d7ca578cf57 URL: https://github.com/llvm/llvm-project/commit/2a2b3a3e3df7b89e18be9ffab1e08d7ca578cf57 DIFF: https://github.com/llvm/llvm-project/commit/2a2b3a3e3df7b89e18be9ffab1e08d7ca578cf57.diff

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

2021-12-02 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2b3a3e3df7: [clang-cl] Define _MSVC_LANG for -std=c++2b (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114938: [Analyzer] SValBuilder: Simlify a SymExpr to the absolute simplest form

2021-12-02 Thread Gabor Marton via Phabricator via cfe-commits
martong updated this revision to Diff 391352. martong marked 2 inline comments as done. martong added a comment. - Rename simplifySValImpl to simplifySValOnce - Remove a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114938/new/

[PATCH] D114971: [clang][deps] Handle symlinks in minimizing FS

2021-12-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 391371. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114971/new/ https://reviews.llvm.org/D114971 Files:

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D114957#3166936 , @foad wrote: > In D114957#3166858 , @yaxunl wrote: > >> In D114957#3166817 , @foad wrote: >> >>> This is a flag-day change to

[PATCH] D112626: Convert float to double on __builtin_dump_struct

2021-12-02 Thread Rafael Franco via Phabricator via cfe-commits
rafaelfranco added a comment. Hey all! Thanks for taking the time to review my patch and writing the Compiler Explorer examples and everything. I had no idea this was the essentially the wrong approach to this, I'd be happy to do a bigger overhaul of the whole builtin if that would make it

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

2021-12-02 Thread Mike Rice via Phabricator via cfe-commits
mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114560/new/ https://reviews.llvm.org/D114560

[clang] 2f0a571 - Reapply "OpenMP: Start calling setTargetAttributes for generated kernels"

2021-12-02 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2021-12-02T14:55:56-05:00 New Revision: 2f0a5714184cca9325004506a22a2a3193c825aa URL: https://github.com/llvm/llvm-project/commit/2f0a5714184cca9325004506a22a2a3193c825aa DIFF:

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Demo patch here: https://reviews.llvm.org/D114981. Still needs fixes to the tests and any potential plumbing from flags in clang-tidy main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108560/new/

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. Thanks for the investigation. Just exploring the options... With regards to reverting it, is the cat out of the bag? I already see some usage of the NOLINTBEGIN feature in other projects. There's also a NOLINT check globbing feature that builds on top of this,

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D108560#3167847 , @salman-javed-nz wrote: > Thanks for the investigation. Just exploring the options... > > With regards to reverting it, is the cat out of the bag? I already see some > usage of the NOLINTBEGIN feature

[clang] ef8e9be - Revert "xfail: reduction_implicit_map.cpp after reapply of Start calling setTargetAttributes"

2021-12-02 Thread Ron Lieberman via cfe-commits
Author: Ron Lieberman Date: 2021-12-02T20:30:03Z New Revision: ef8e9bee1a9b87ee750b193ed4a1f9b5d310daef URL: https://github.com/llvm/llvm-project/commit/ef8e9bee1a9b87ee750b193ed4a1f9b5d310daef DIFF: https://github.com/llvm/llvm-project/commit/ef8e9bee1a9b87ee750b193ed4a1f9b5d310daef.diff

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D114957#3167700 , @arsenm wrote: > I think this macro is purely terrible and should not be added (and at least > should be all caps?). If we can't just hard break users, I would rather just > leave the builtin signatures

[PATCH] D114981: [clang-tidy] Disable support for NOLINTBEGIN/NOLINTEND blocks by default.

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This patch parameterizes the clang-tidy diagnostic consumer with a boolean that controls

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D114957#3167703 , @arsenm wrote: > In D114957#3167700 , @arsenm wrote: > >> I think this macro is purely terrible and should not be added (and at least >> should be all caps?). If we

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D108560#3167830 , @carlosgalvezp wrote: > Good catch! That explains the performance drop we observed as well. > > We are however currently relying on this feature so it would be sad to revert > it. Would it be

[clang] 8b646f2 - xfail: reduction_implicit_map.cpp after reapply of Start calling setTargetAttributes

2021-12-02 Thread Ron Lieberman via cfe-commits
Author: Ron Lieberman Date: 2021-12-02T20:22:11Z New Revision: 8b646f212e9ccc8e0fbf1a84603d0a40bfca1338 URL: https://github.com/llvm/llvm-project/commit/8b646f212e9ccc8e0fbf1a84603d0a40bfca1338 DIFF: https://github.com/llvm/llvm-project/commit/8b646f212e9ccc8e0fbf1a84603d0a40bfca1338.diff

[PATCH] D112626: Convert float to double on __builtin_dump_struct

2021-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D112626#3167520 , @rafaelfranco wrote: > Hey all! Thanks for taking the time to review my patch and writing the > Compiler Explorer examples and everything. I had no idea this was the > essentially the wrong approach to

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

2021-12-02 Thread Mike Rice via Phabricator via cfe-commits
mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151

[PATCH] D112110: [OpenCL] queue_t and ndrange_t can't be defined in program scope.

2021-12-02 Thread Chuang-Yu Cheng via Phabricator via cfe-commits
cycheng added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6853 +if (R->isReserveIDT() || R->isClkEventT() || R->isEventT() || +R.getUnqualifiedType().getAsString() == "ndrange_t" || R->isQueueT()) { Se.Diag(NewVD->getLocation(),

[PATCH] D114966: [clang][deps] Split filesystem caches

2021-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. Thanks for working on this; seems like a great start. At a high-level: - We should check overhead. It'd be good to benchmark scanning LLVM with `clang-scan-deps` before and after this change. - The locking is getting harder to track, since the acquisition and release

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

2021-12-02 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. Nice, assiduous work! The tests are awesome! LGTM, with minor revisions. Please check out my suggestions about the tests' formatting and there are those disturbing (LHS, RHS) swaps in the comments. I am going to continue with the next

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. In D108560#3167883 , @aaron.ballman wrote: > In D108560#3167847 , > @salman-javed-nz wrote: > >> If the current code stayed in the main repo, how long could you afford to >>

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Thanks, all, for the prompt response to these concerns!! In D108560#3167847 , @salman-javed-nz wrote: > Thanks for the investigation. Just exploring the options... > > With regards to reverting it, is the cat out of the bag? I

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 391451. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

2021-12-02 Thread Oleg Smolsky via Phabricator via cfe-commits
oleg.smolsky created this revision. Herald added a subscriber: carlosgalvezp. oleg.smolsky requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - we want to deal with non-default constructors that just happen to contain constant

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D114968#3167519 , @jansvoboda11 wrote: > Assuming the filesystem doesn't change during dependency scanning, this > change keeps

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:16-17 + +The exception handler is

[PATCH] D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

2021-12-02 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thank you for a quick workaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114981/new/ https://reviews.llvm.org/D114981

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

2021-12-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Changing how types are printed can effect LLDB expression parsing tests. I ran the LLDB test suite with this change: ninja check-lldb and it changes to the results for `TestScalarURem.py` which can be run using: llvm-lit -sv lldb/test --filter TestScalarURem.py

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. +1 to the request for a release note, but otherwise this LGTM (with or without the `static_cast` changes) in general. Should we also do something special for `[[no_unique_address]]` (if we should, I'm fine doing that in a follow-up)? Repository: rG LLVM Github

[clang-tools-extra] 081074e - [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

2021-12-02 Thread Yitzhak Mandelbaum via cfe-commits
Author: Yitzhak Mandelbaum Date: 2021-12-02T22:19:05Z New Revision: 081074e1ea5353a3775591f7306b6fb6da02b004 URL: https://github.com/llvm/llvm-project/commit/081074e1ea5353a3775591f7306b6fb6da02b004 DIFF: https://github.com/llvm/llvm-project/commit/081074e1ea5353a3775591f7306b6fb6da02b004.diff

[PATCH] D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG081074e1ea53: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks. (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

2021-12-02 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added a comment. Can we not consider a modulemap used when we load an AST that depends on that modulemap? It's possible this breaks if the module only includes textual headers though. It really feels like we should have a single place where we actually know if a module is used or

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

2021-12-02 Thread Oleg Smolsky via Phabricator via cfe-commits
oleg.smolsky updated this revision to Diff 391470. oleg.smolsky added a comment. Fixing the uploaded diff... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114995/new/ https://reviews.llvm.org/D114995 Files:

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Aaron, Salman, We've seen a serious perfomance regression caused by this patch. The issue is that the new code scans every file in its entirety for every single diagnostic encountered in that file. In fact, each lines is copied and scanned twice (respectively), so

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. I think this macro is purely terrible and should not be added (and at least should be all caps?). If we can't just hard break users, I would rather just leave the builtin signatures broken Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114454: [CSA]Skip unstable CSA tests failing on several platforms

2021-12-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I think it looks good. Sorry for the delay. I'll fix the test later, to pass on all targets :) Thanks again for making it support multiple triples. Repository: rG LLVM Github Monorepo

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. I'm happy to help reviewing the fix if we decide to go that way. I agree that a simple revert might not be straightforward due to other patches building on top of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a9036f2 - [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

2021-12-02 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2021-12-02T12:59:03-08:00 New Revision: a9036f2eb42d2311d84198868e9e8ff060c79a95 URL: https://github.com/llvm/llvm-project/commit/a9036f2eb42d2311d84198868e9e8ff060c79a95 DIFF: https://github.com/llvm/llvm-project/commit/a9036f2eb42d2311d84198868e9e8ff060c79a95.diff

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

2021-12-02 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9036f2eb42d: [OPENMP]Fix error emission for dependent expressions in iterators for depend… (authored by ABataev). Repository: rG LLVM Github

[clang] a0839c1 - [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

2021-12-02 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2021-12-02T13:33:44-08:00 New Revision: a0839c13fd321bb852870ffab916ad90f691161b URL: https://github.com/llvm/llvm-project/commit/a0839c13fd321bb852870ffab916ad90f691161b DIFF: https://github.com/llvm/llvm-project/commit/a0839c13fd321bb852870ffab916ad90f691161b.diff

[PATCH] D114560: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template.

2021-12-02 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0839c13fd32: [OPENMP]Fix PR51327: Range based for loop not working if ranges type is a… (authored by ABataev). Repository: rG LLVM Github

[PATCH] D114981: [clang-tidy] Disable support for NOLINTBEGIN/NOLINTEND blocks by default.

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 391450. ymandel added a comment. change to "enabled-by-default" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114981/new/ https://reviews.llvm.org/D114981 Files:

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. In D108560#3168006 , @ymandel wrote: > In D108560#3167847 , > @salman-javed-nz wrote: > >> With regards to reverting it, is the cat out of the bag? I already see some >> usage

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D108560#3168182 , @salman-javed-nz wrote: > Update: OK I see you have already changed your patch to make the feature > enabled by default. > As far as the performance is concerned, I will have a go at improving it and >

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

2021-12-02 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/ https://reviews.llvm.org/D114974 ___ cfe-commits mailing list

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. LGTM from clang side. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114957/new/ https://reviews.llvm.org/D114957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

2021-12-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. Committed as 6c27d389c8a00040aad998fe959f38ba709a8750 , recommitted as 2f0a5714184cca9325004506a22a2a3193c825aa

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Good catch! That explains the performance drop we observed as well. We are however currently relying on this feature so it would be sad to revert it. Would it be possible/make sense to enable/disable via CLI/config? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. In D108560#3167847 , @salman-javed-nz wrote: > I can have a go at coming up with a solution where it does caching of the > NOLINT marker positions when a diagnostic is generated in a file. That would > probably help a

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

2021-12-02 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. \o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/ https://reviews.llvm.org/D114974 ___

[PATCH] D114454: [CSA]Skip unstable CSA tests failing on several platforms

2021-12-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Ah, please retitle this to have the [analyzer] tag. I think we dont use the CSA tag or any other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D108560#3167912 , @salman-javed-nz wrote: > In D108560#3167883 , @aaron.ballman > wrote: > >> In D108560#3167847 , >>

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Update: I modified https://reviews.llvm.org/D114981 to leave it enabled by default. That makes it essentially an NFC while still allowing clients to disable it easily in tooling that uses it. We can still disable by default, but that will be a separate patch from

[PATCH] D114937: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

2021-12-02 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114937/new/ https://reviews.llvm.org/D114937

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

2021-12-02 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8a2c7a241099: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. Update: OK I see you have already changed your patch to make the feature enabled by default. As far as the performance is concerned, I will have a go at improving it and hope to have something to share next week. How does that sound? Repository: rG LLVM

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D108560#3167621 , @ymandel wrote: > Aaron, Salman, > > We've seen a serious perfomance regression caused by this patch. The issue is > that the new code scans every file in its entirety for every single > diagnostic

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

2021-12-02 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. In D108560#3167838 , @aaron.ballman wrote: > In D108560#3167830 , @carlosgalvezp > wrote: > >> Good catch! That explains the performance drop we observed as well. >> >> We are

[clang] 740057d - [funcattrs] Infer writeonly argument attribute

2021-12-02 Thread Philip Reames via cfe-commits
Author: Philip Reames Date: 2021-12-02T13:04:09-08:00 New Revision: 740057d185ea0e8b5a4f8b7c78fdf38ae7a66f76 URL: https://github.com/llvm/llvm-project/commit/740057d185ea0e8b5a4f8b7c78fdf38ae7a66f76 DIFF: https://github.com/llvm/llvm-project/commit/740057d185ea0e8b5a4f8b7c78fdf38ae7a66f76.diff

[PATCH] D114963: [funcattrs] Infer writeonly argument attribute

2021-12-02 Thread Philip Reames via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG740057d185ea: [funcattrs] Infer writeonly argument attribute (authored by reames). Herald added subscribers: cfe-commits, kerbowa, atanasyan,

[PATCH] D114981: [clang-tidy] Allow disabling support for NOLINTBEGIN/NOLINTEND blocks.

2021-12-02 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 391455. ymandel added a comment. remove incorrect line in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114981/new/ https://reviews.llvm.org/D114981 Files:

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

2021-12-02 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. LGTM Comment at: clang/test/CodeGen/asan-globals.cpp:62 // CHECK: ![[ATTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true} +// CHECK: ![[DISABLE_INSTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true} // CHECK:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

2021-12-02 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:372 QualType resultTy) { NonLoc InputLHS = lhs; NonLoc InputRHS = rhs; @martong, you simplified the operands, but you

[PATCH] D114975: [clang-tidy][objc] Finds and fixes improper usages of XCTAssertEquals and XCTAssertNotEquals.

2021-12-02 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 391472. oontvoo added a comment. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114975/new/ https://reviews.llvm.org/D114975 Files: clang-tools-extra/clang-tidy/objc/AssertEquals.cpp

[clang] 89d645d - [Clang] Fix LTO pipeline test after 770a50b28c00211f9a.

2021-12-02 Thread Florian Hahn via cfe-commits
Author: Florian Hahn Date: 2021-12-02T15:42:52Z New Revision: 89d645dd3a60cd5bb3cc9a78ad17d3b063cc98bf URL: https://github.com/llvm/llvm-project/commit/89d645dd3a60cd5bb3cc9a78ad17d3b063cc98bf DIFF: https://github.com/llvm/llvm-project/commit/89d645dd3a60cd5bb3cc9a78ad17d3b063cc98bf.diff LOG:

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

2021-12-02 Thread Christian Kühnel via Phabricator via cfe-commits
kuhnel added a comment. Looking at the documentation, this looks like a bug in the clang-tidy check: https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html The rule `llvm-qualified-auto` should not add a `const` qualifier. Repository:

[PATCH] D114890: [OpenMP] Make the new device runtime the default

2021-12-02 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Fails on CI pretty much like it fails locally https://lab.llvm.org/buildbot/#/builders/193/builds/2569 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890

[PATCH] D113896: [clangd] cleanup of header guard names

2021-12-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. > This looks to be a deliberate decision: > https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.h#L32 > > Looking at the code under `clang/include`, it looks like most headers don't > have the `#endif // COMMENT`, so this

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

2021-12-02 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked 4 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155 + llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName()); + return Ver >= 7 || AK == llvm::ARM::ArchKind::ARMV6T2 || +

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

2021-12-02 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 391393. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files:

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

2021-12-02 Thread Keith Smiley via Phabricator via cfe-commits
keith created this revision. keith added reviewers: int3, MaskRay, oontvoo, thakis. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This now assumes that for the darwin driver any lld is the "new" macho lld implementation.

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

2021-12-02 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 391316. junaire added a comment. I didn't know if I understand Aaron's words right, but I think I can update the patch first... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files:

[PATCH] D113638: [xray] Add support for hexagon architecture

2021-12-02 Thread Sid Manning via Phabricator via cfe-commits
sidneym added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

2021-12-02 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh requested changes to this revision. svenvh added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/Driver.cpp:3728 + // Linking separate translation units for SPIR-V is not supported yet. + // It can be done either by LLVM IR

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

2021-12-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D114688#3166870 , @junaire wrote: > I didn't know if I understand Aaron's words right, but I think I can update > the patch first... I think you understood my suggestion pretty well, thanks! Comment

[PATCH] D114965: [OpenMP] Remove the new runtime default for AMDGPU

2021-12-02 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. I feel like I should make these options only enabled if we're in an OpenMP device. I just realized that this will probably enable it for anything that goes through here, even non-OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 391370. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114968/new/ https://reviews.llvm.org/D114968 Files:

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Jay Foad via Phabricator via cfe-commits
foad updated this revision to Diff 391403. foad added a comment. Define __amdgcn_bvh_use_vec3__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114957/new/ https://reviews.llvm.org/D114957 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D114957#3166817 , @foad wrote: > This is a flag-day change to the signatures of the LLVM intrinsics and the > OpenCL builtins. Is that OK? This breaks users' code. If we have to do this, at least let clang emit a pre-defined

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D114957#3166974 , @foad wrote: > In D114957#3166948 , @b-sumner > wrote: > >> In D114957#3166936 , @foad wrote: >> >>> In D114957#3166858

[PATCH] D114890: [OpenMP] Make the new device runtime the default

2021-12-02 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. The consensus internally seems to be to land this and see what happens on the amdgpu buildbot. Go for it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/

[PATCH] D114890: [OpenMP] Make the new device runtime the default

2021-12-02 Thread Ron Lieberman via Phabricator via cfe-commits
ronlieb added a comment. yes, thanks, sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114890/new/ https://reviews.llvm.org/D114890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114965: [OpenMP] Remove the new runtime default for AMDGPU

2021-12-02 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D114965#3167241 , @jhuber6 wrote: > I feel like I should make these options only enabled if we're in an OpenMP > device. I just realized that this will probably enable it for anything that > goes through here, even

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

2021-12-02 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

2021-12-02 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 391390. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - use @peter.smith's suggestion re: ARMV8MBaseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114116/new/

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

2021-12-02 Thread Mike Rice via Phabricator via cfe-commits
mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114653/new/ https://reviews.llvm.org/D114653

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D114957#3166861 , @arsenm wrote: > In D114957#3166858 , @yaxunl wrote: > >> In D114957#3166817 , @foad wrote: >> >>> This is a flag-day change

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Jay Foad via Phabricator via cfe-commits
foad added a comment. In D114957#3166858 , @yaxunl wrote: > In D114957#3166817 , @foad wrote: > >> This is a flag-day change to the signatures of the LLVM intrinsics and the >> OpenCL builtins. Is that OK? > >

[clang] 53adfa8 - [clang] Do not duplicate "EnableSplitLTOUnit" module flag

2021-12-02 Thread David Greene via cfe-commits
Author: David Greene Date: 2021-12-02T08:24:56-08:00 New Revision: 53adfa8750eaf4558c41a50f699616545eb0151b URL: https://github.com/llvm/llvm-project/commit/53adfa8750eaf4558c41a50f699616545eb0151b DIFF: https://github.com/llvm/llvm-project/commit/53adfa8750eaf4558c41a50f699616545eb0151b.diff

[PATCH] D112177: [clang] Do not duplicate "EnableSplitLTOUnit" module flag

2021-12-02 Thread David Greene via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG53adfa8750ea: [clang] Do not duplicate EnableSplitLTOUnit module flag (authored by greened). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112177/new/

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

2021-12-02 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D114966 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114968 Files:

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D114957#3166858 , @yaxunl wrote: > In D114957#3166817 , @foad wrote: > >> This is a flag-day change to the signatures of the LLVM intrinsics and the >> OpenCL builtins. Is that OK? > >

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

2021-12-02 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. In D114957#3166882 , @yaxunl wrote: > In D114957#3166861 , @arsenm wrote: > >> In D114957#3166858 , @yaxunl wrote: >> >>> In D114957#3166817

  1   2   3   >