[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge added a comment. In D119077#3339812 , @iannisdezwart wrote: > About your comment on the implicit calls to `operator[]` and `operator()`, > this was also a workaround. Do you have any idea how to get both parentheses > from a single

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Abandoning as replaced with a better solution D120217: [clang-format] Add an option to insert braces after control statements CHANGES SINCE LAST ACTION

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske added a comment. The current build errors are probably not related, the Windows test failure shows up in other differential objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 411812. awarzynski added a comment. Fix formatting and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 Files: clang/include/clang/Driver/Options.td

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. In D120159#3348927 , @jyknight wrote: > In D120159#3341224 , @aaron.ballman > wrote: > >> Btw, I think there may be some functionality missing for AST dumping, so I'd >> like to

[clang] a64d3c6 - [NFC][Lexer] Make Lexer::LangOpts const reference

Author: Dawid Jurczak Date: 2022-02-28T15:42:19+01:00 New Revision: a64d3c602fb7e533855a64cb4d9fec77ea0a079e URL: https://github.com/llvm/llvm-project/commit/a64d3c602fb7e533855a64cb4d9fec77ea0a079e DIFF: https://github.com/llvm/llvm-project/commit/a64d3c602fb7e533855a64cb4d9fec77ea0a079e.diff

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa64d3c602fb7: [NFC][Lexer] Make Lexer::LangOpts const reference (authored by yurai007). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114903: [clang] Support array placement new in constant expressions

erichkeane added a comment. In D114903#3285144 , @Quuxplusone wrote: > I have no special knowledge of this. Seems like "it can't be that easy," but > I don't know. I agree with this. I have a little knowledge of the constant evaluator, but not

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. LGTM Let me know if you need help landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119816/new/ https://reviews.llvm.org/D119816

[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

ztong0001 added a comment. Hi Marco, Yes I need help landing it. Please use Tong Zhang Thanks, - Tong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119816/new/ https://reviews.llvm.org/D119816 ___

[PATCH] D120629: [clang] Remove unused variable AllElementsInt. NFC.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120629/new/ https://reviews.llvm.org/D120629 ___

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. I have reverted the buildbot configuration change as well: https://github.com/llvm/llvm-zorg/commit/c01d0787c4a11e40d0fed81b0df6841bebc16f7f Now that everything is back to the original state, we can discuss how to proceed. Repository: rG LLVM Github Monorepo

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. LGTM. For the record, this is related to the issues with the `-fuse-ld` option in that a cmake flag globally overrides a toolchain default: https://reviews.llvm.org/D115045. Repository:

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2917-2920 Create(const ASTContext , SourceLocation StartLoc, SourceLocation EndLoc, ArrayRef Clauses, Stmt *AssociatedStmt, Expr *X, Expr *V, - Expr *E, Expr *UE, Expr *D, Expr

[clang] 220da12 - [NFC][Clang][AArch64] Clean up AArch64TargetInfo::hasFeature

Author: Archibald Elliott Date: 2022-02-28T14:25:12Z New Revision: 220da125c423b71ce1507df84b75f54d274bc63d URL: https://github.com/llvm/llvm-project/commit/220da125c423b71ce1507df84b75f54d274bc63d DIFF: https://github.com/llvm/llvm-project/commit/220da125c423b71ce1507df84b75f54d274bc63d.diff

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 411803. awarzynski added a comment. Incorproate suggestions from Eric Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 Files:

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

colavitam added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119063/new/ https://reviews.llvm.org/D119063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116439/new/ https://reviews.llvm.org/D116439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

Meinersbur added a comment. This patch also caused https://github.com/llvm/llvm-project/issues/54082. I noticed due to the revert making the openmp-offload-cuda-project bot green again (https://lab.llvm.org/staging/#/builders/155/builds/2482)

[clang] cd1489b - Clarify documentation of cpu_dispatch/cpu_specific

Author: Erich Keane Date: 2022-02-28T07:03:55-08:00 New Revision: cd1489bb58bb61276e73c91ff42dcf6a3febe650 URL: https://github.com/llvm/llvm-project/commit/cd1489bb58bb61276e73c91ff42dcf6a3febe650 DIFF: https://github.com/llvm/llvm-project/commit/cd1489bb58bb61276e73c91ff42dcf6a3febe650.diff

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight updated this revision to Diff 411811. jyknight marked 15 inline comments as done. jyknight added a comment. Update per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159 Files:

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight added a comment. In D120159#3341224 , @aaron.ballman wrote: > Btw, I think there may be some functionality missing for AST dumping, so I'd > like to see some additional tests for that. I'm not sure what test would actually show a problem (or

[PATCH] D119926: [Clang][AArch64] Enable _Float16 _Complex type

MattDevereau abandoned this revision. MattDevereau added a comment. Abandoning this patch as it is redundant due to changes in D105331 . This patch also drew attention to unused code removed in 841355c1e4e35fc02b5b171419979f5f9af0ebc8

[clang] 12d3679 - [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

Author: Timm Bäder Date: 2022-02-28T14:55:56+01:00 New Revision: 12d3679256c9a544699f9894c16c2918da17e4af URL: https://github.com/llvm/llvm-project/commit/12d3679256c9a544699f9894c16c2918da17e4af DIFF: https://github.com/llvm/llvm-project/commit/12d3679256c9a544699f9894c16c2918da17e4af.diff

[PATCH] D120644: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12d3679256c9: [clang][tests] Fix ve-toolchain tests with CLANG_DEFAULT_UNWINDLIB (authored by tbaeder). Repository: rG LLVM Github Monorepo

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski marked 3 inline comments as done. awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:43 using namespace Fortran::frontend; +using namespace llvm; schweitz wrote: > You'll want to keep in mind that some class names

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan created this revision. scchan added a reviewer: yaxunl. Herald added subscribers: asavonic, kerbowa, jvesely. Herald added a reviewer: alexander-shaposhnikov. scchan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2917-2920 Create(const ASTContext , SourceLocation StartLoc, SourceLocation EndLoc, ArrayRef Clauses, Stmt *AssociatedStmt, Expr *X, Expr *V, - Expr *E, Expr *UE, Expr *D,

[clang] d3db74e - [clang] Remove unused variable AllElementsInt.

Author: Arthur O'Dwyer Date: 2022-02-28T12:27:34-05:00 New Revision: d3db74eadbfc06425668b39c41eeeca22f747978 URL: https://github.com/llvm/llvm-project/commit/d3db74eadbfc06425668b39c41eeeca22f747978 DIFF:

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas created this revision. Herald added a subscriber: mgorny. manas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, manpage for scan-build is installed as a program, with permission of 755. This patch makes installation of

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

MyDeveloperDay added a comment. once again thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120631/new/ https://reviews.llvm.org/D120631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Oh, that's unfortunate. Thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646

[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

salman-javed-nz added a comment. Hi @curdeius, have you had the chance to look at this since the last round of comments? The only thing I think this module still needs for now (until a new generic header guard check is developed), is a check that there aren't consecutive underscores in the

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry added a comment. In D120631#3348337 , @MyDeveloperDay wrote: > once again thank you! You're welcome :) Could someone please deliver this one for me? My name and email in git format is "Krystian Kuzniarek " Repository: rG LLVM Github

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Please check the docs if they are still in sync with the content. I think it looks great overall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 34a7387 - [analyzer] Add more sources to Taint analysis

Author: Endre Fülöp Date: 2022-02-28T11:33:02+01:00 New Revision: 34a7387986a68835680a8b7bef0ea091d57d28b0 URL: https://github.com/llvm/llvm-project/commit/34a7387986a68835680a8b7bef0ea091d57d28b0 DIFF: https://github.com/llvm/llvm-project/commit/34a7387986a68835680a8b7bef0ea091d57d28b0.diff

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34a7387986a6: [analyzer] Add more sources to Taint analysis (authored by gamesh411). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

rovka added a comment. I'm having trouble building this on Windows on Arm. I'm still investigating if it's a problem with the patch or just growing pains on the WoA side :) I'll try to get to the bottom of it as soon as I can. Comment at:

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

gamesh411 updated this revision to Diff 411765. gamesh411 added a comment. fix readlinkat arg index extend testcase for readlinkat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 Files:

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Herald added a subscriber: manas. Approved, given that it looks and compiles fine with oxygen. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

gamesh411 marked 3 inline comments as done. gamesh411 added a comment. readlinkat fix incoming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 ___ cfe-commits

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno'.

balazske updated this revision to Diff 411750. balazske added a comment. Herald added a subscriber: manas. Removed the static variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120310/new/ https://reviews.llvm.org/D120310 Files:

[PATCH] D120555: [clang-tidy] Fix `readability-suspicious-call-argument` crash for arguments without name-like identifier

whisperity added a comment. In D120555#3345707 , @njames93 wrote: > If you backport, the release notes change on trunk should then be reverted. Indeed, this is not the first time I mess this up... Ugh. I'll wait a little bit for that to make sure the

[clang] 24d4f60 - [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

Author: Luis Penagos Date: 2022-02-28T11:55:04+01:00 New Revision: 24d4f601aa6dd83b46ca41913452d0771a97d603 URL: https://github.com/llvm/llvm-project/commit/24d4f601aa6dd83b46ca41913452d0771a97d603 DIFF: https://github.com/llvm/llvm-project/commit/24d4f601aa6dd83b46ca41913452d0771a97d603.diff

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24d4f601aa6d: [clang-format] Treat followed by noexcept operator as a binary operator… (authored by penagos, committed by curdeius). Changed

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. One final note: many of the methods I've suggested produce a `SourceRange`, and we'll need to convert it to `Range`. I think it should be fine to convert the begin and end

[PATCH] D120236: [analyzer] Add more sources to Taint analysis

gamesh411 updated this revision to Diff 411763. gamesh411 added a comment. Herald added a subscriber: manas. add readlinkat rename _IO_getc testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120236/new/ https://reviews.llvm.org/D120236 Files:

[PATCH] D120217: [clang-format] Add an option to insert braces after control statements

MyDeveloperDay added a comment. @owenpan I didn't get to this one to review it, but it looks good to me and thank you for following through with this, I'll abandon the other implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120217/new/

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas added a comment. This patch fixes #53967 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 ___

[clang] b3fcfcb - [C++20][Modules][7/8] Find the primary interface name for a module.

Author: Iain Sandoe Date: 2022-02-28T08:50:25Z New Revision: b3fcfcb9464b90dd56a591e6269d33b124b96fee URL: https://github.com/llvm/llvm-project/commit/b3fcfcb9464b90dd56a591e6269d33b124b96fee DIFF: https://github.com/llvm/llvm-project/commit/b3fcfcb9464b90dd56a591e6269d33b124b96fee.diff LOG:

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3fcfcb9464b: [C++20][Modules][7/8] Find the primary interface name for a module. (authored by iains). Repository: rG LLVM Github Monorepo

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 updated this revision to Diff 411770. yurai007 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120334/new/ https://reviews.llvm.org/D120334 Files: clang/include/clang/Lex/Lexer.h

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

yurai007 added a comment. All comments were addressed. Since broken libarcher/libomp/libomptarget UT are seen on others patches too I think it has nothing to do with this particular change. There is no speed degradation in comparison to LangOptionsBase approach so I believe now change is

[PATCH] D120629: [clang] Remove unused variable AllElementsInt. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3db74eadbfc: [clang] Remove unused variable AllElementsInt. (authored by arthur.j.odwyer). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411825. aeubanks added a comment. add header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index:

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

FWIW, I think it's probably simpler/more maintainable to default capture by reference ("[&]") if a lambda doesn't escape its scope (if it's never type erased/put in a std::function or equivalent). Avoids assert/non-assert unused issues, having to maintain/update the list when the code changes and

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 411856. lichray added a comment. - Revert some auto's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/include/clang/AST/DeclTemplate.h

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666

[clang] 96dea20 - [NFC] Make 1st param to getTemplateInstantiationArgs const correct

Author: Erich Keane Date: 2022-02-28T12:14:14-08:00 New Revision: 96dea2015554d1bf1e095ea82bc57d9229bd5fd5 URL: https://github.com/llvm/llvm-project/commit/96dea2015554d1bf1e095ea82bc57d9229bd5fd5 DIFF: https://github.com/llvm/llvm-project/commit/96dea2015554d1bf1e095ea82bc57d9229bd5fd5.diff

[PATCH] D111457: [test] Add lit helper for windows paths

probinson added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ rnk wrote: > It is pretty common to run the LLVM test suite on secondary drives, > especially on

[clang-tools-extra] de9611b - [NFC] Don't pass temporary LangOptions to Lexer

Author: Jorge Gorbe Moya Date: 2022-02-28T12:53:59-08:00 New Revision: de9611befeebeb85324062cb1ae8978a82a09e26 URL: https://github.com/llvm/llvm-project/commit/de9611befeebeb85324062cb1ae8978a82a09e26 DIFF:

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

aaron.ballman added reviewers: erichkeane, Quuxplusone. aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes here LGTM, but I'd appreciate a second set of eyes on it in case I missed anything before this lands.

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

rnk added a comment. Thanks for writing docs, apologies for bikeshedding. Comment at: clang/docs/ClangPlugins.rst:207 + +If the main AST action is codegen, having any plugins that run after the +codegen action automatically turns off ``-clear-ast-before-backend``.

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

rjmccall added a comment. This is one of those patches that's difficult to review because it's so hard to foresee the consequences of changing the concepts. That said, I think the basic idea here seems reasonable. Comment at:

[clang] b3e2dac - [NFC] Don't pass temporary LangOptions to Lexer

Author: Dawid Jurczak Date: 2022-02-28T20:43:28+01:00 New Revision: b3e2dac27c0cd4562e4ece5d5e24a1e59705c746 URL: https://github.com/llvm/llvm-project/commit/b3e2dac27c0cd4562e4ece5d5e24a1e59705c746 DIFF: https://github.com/llvm/llvm-project/commit/b3e2dac27c0cd4562e4ece5d5e24a1e59705c746.diff

[PATCH] D120132: [HIP] Fix HIP include path

tra added a comment. In D120132#3345534 , @yaxunl wrote: > I just found one issue with the current patch. It adds HIP include path for > non-HIP programs. > > We should only add HIP include path for JobAction with HIP offloading kind. > However,

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } lichray wrote: > aaron.ballman wrote: > > We're also missing `\?` right? > `?` does not seem to need

[clang] 092f15a - [HIP] File device library ABI version file name

Author: Yaxun (Sam) Liu Date: 2022-02-28T16:24:50-05:00 New Revision: 092f15ac40ce35d077e0225a4462bc4dfa379391 URL: https://github.com/llvm/llvm-project/commit/092f15ac40ce35d077e0225a4462bc4dfa379391 DIFF:

[PATCH] D120557: [HIP] File device library ABI version file name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG092f15ac40ce: [HIP] File device library ABI version file name (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

[PATCH] D120159: [Clang] Implement __builtin_source_location.

jyknight marked 8 inline comments as done. jyknight added a comment. In D120159#3349069 , @aaron.ballman wrote: > Ah, okay, that's a good point. I was thinking this would show up in the AST > in places like: > > template > auto func() -> Ty; >

[clang] d5b2055 - [OpenMP] Add verbose output for linker wrapper

Author: Joseph Huber Date: 2022-02-28T13:28:19-05:00 New Revision: d5b2055769f40386a818e9df0a173eafa0e7dc5f URL: https://github.com/llvm/llvm-project/commit/d5b2055769f40386a818e9df0a173eafa0e7dc5f DIFF: https://github.com/llvm/llvm-project/commit/d5b2055769f40386a818e9df0a173eafa0e7dc5f.diff

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 411839. lichray added a comment. Use the right copy of clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files: clang/docs/ReleaseNotes.rst

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D120159#3349271 , @jyknight wrote: > In D120159#3349069 , @aaron.ballman > wrote: > >> Ah, okay, that's a good point. I was thinking

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added inline comments. Comment at: clang/test/Modules/merge-anon-record-definition-in-objc.m:5 +// RUN: %clang_cc1 -fsyntax-only -F%t/Frameworks %t/test.m -Wno-objc-property-implementation -Wno-incomplete-implementation \ +// RUN:-fmodules

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 ___

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

aeubanks updated this revision to Diff 411829. aeubanks added a comment. reword Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120666/new/ https://reviews.llvm.org/D120666 Files: clang/docs/ClangPlugins.rst Index: clang/docs/ClangPlugins.rst

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

I agree, but clearly this person chose a particular style, and I wasn't trying to revise their code style, just to fix some the Bazel build, which uses -Werror. The way that `assert` can affect a lambda's capture list seems like a particularly good argument for having a project wide style

[clang] 223b824 - [Clang] noinline call site attribute

Author: Dávid Bolvanský Date: 2022-02-28T21:21:17+01:00 New Revision: 223b8240223541d3feb0c96b7f9bac114cd72f46 URL: https://github.com/llvm/llvm-project/commit/223b8240223541d3feb0c96b7f9bac114cd72f46 DIFF:

[PATCH] D119061: [Clang] noinline call site attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG223b82402235: [Clang] noinline call site attribute (authored by xbolva00). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

urnathan added a comment. In D120397#3340256 , @erichkeane wrote: > Linkage stuff is where I get lost quickly, hopefully @urnathan can comment > here. Codewise I think this looks right. looks right to me too -- take the linkage from the most general

[PATCH] D119061: [Clang] noinline call site attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6216 - KindsEncountered.contains(OMPC_capture)) { -IsCompareCapture = true; Kind = OMPC_compare; tianshilei1992 wrote: > ABataev wrote: > > Can this be fixed in a

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

lichray added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if (InitStyle) { -if (InitStyle == CXXNewExpr::CallInit) + auto InitStyle = E->getInitializationStyle(); + if

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 411835. awarzynski added a comment. Update how target IR analysis passes are initialised (use `TargetMachine::getTargetIRAnalysis()` instead of calling the constructor directly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2155 - CXXNewExpr::InitializationStyle InitStyle = E->getInitializationStyle(); - if (InitStyle) { -if (InitStyle == CXXNewExpr::CallInit) + auto InitStyle = E->getInitializationStyle(); +

[PATCH] D111457: [test] Add lit helper for windows paths

rnk added inline comments. Comment at: llvm/docs/TestingGuide.rst:577 +``${fssep}`` + Exp``ands to the file system separator, i.e. ``/`` or ``\`` on Windows. + Stray backticks in "Expands"? Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

urnathan added inline comments. Comment at: clang/test/Modules/inconsist-export-template.cpp:26-34 +export template +class C { + +}; + +template<> +class C { I think you'll need a member fn to have something to check the linkage of? Might be worth checking

[PATCH] D120437: [HWASAN] erase lifetime intrinsics if tag is outside.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/lifetime-sanitizer.c:9 +// RUN: %clang -target aarch64-linux-gnu -S -emit-llvm -o /dev/null -O0 \ +// RUN: -fsanitize=hwaddress

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

thakis added inline comments. Comment at: clang/docs/ClangPlugins.rst:209 +codegen action automatically turns off ``-clear-ast-before-backend``, which +saves peak memory by clearing the Clang AST after generating IR and before +running IR optimizations. Use

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

NoQ added inline comments. Comment at: clang/test/Analysis/bstring.c:310 - clang_analyzer_eval(p == [4]); // expected-warning{{TRUE}} + clang_analyzer_eval(p == [4]); // no-warning (above is fatal) } Hmm, given that your change suppresses some existing

[PATCH] D120589: [Clang] Implement decltype(auto)(x) from P0849R2

lichray updated this revision to Diff 411842. lichray added a comment. Nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120589/new/ https://reviews.llvm.org/D120589 Files: clang/lib/AST/StmtPrinter.cpp

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked 3 inline comments as done. lichray added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:199-200 +return "\\t"; + case '\v': +return "\\v"; + } aaron.ballman wrote: > We're also missing `\?` right? `?` does not seem to

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

HazardyKnusperkeks added a comment. I have a similar structure to Qt regarding the headers and use clangd trough the QtCreator, so for my own libraries I cannot use the auto completion. In D112996#3102782 , @sammccall wrote: >> the files are located in

[clang] f1315c6 - [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

Author: Arthur Eubanks Date: 2022-02-28T12:53:09-08:00 New Revision: f1315c61a03ea6ef72ec11522f9abecd782f4856 URL: https://github.com/llvm/llvm-project/commit/f1315c61a03ea6ef72ec11522f9abecd782f4856 DIFF:

[PATCH] D120666: [docs] Add note about interaction between clang plugins and -clear-ast-before-backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1315c61a03e: [docs] Add note about interaction between clang plugins and -clear-ast-before… (authored by aeubanks). Repository: rG LLVM Github

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119910/new/ https://reviews.llvm.org/D119910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120608: [Clang] Remove redundant init-parens in AST print

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a59eefd3a0: [Clang] Remove redundant init-parens in AST print (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d1a59ee - [Clang] Remove redundant init-parens in AST print

Author: Zhihao Yuan Date: 2022-02-28T19:31:16-06:00 New Revision: d1a59eefd3a09f08ba425a20899fbd1766babc45 URL: https://github.com/llvm/llvm-project/commit/d1a59eefd3a09f08ba425a20899fbd1766babc45 DIFF: https://github.com/llvm/llvm-project/commit/d1a59eefd3a09f08ba425a20899fbd1766babc45.diff

  1   2   >