[libunwind] 43c84e4 - [libunwind, EHABI, ARM] Fix get/set of RA_AUTH_CODE.

Author: Simon Tatham Date: 2022-06-27T09:36:21+01:00 New Revision: 43c84e463426ca35fe9fc2d38063d75fed944f23 URL: https://github.com/llvm/llvm-project/commit/43c84e463426ca35fe9fc2d38063d75fed944f23 DIFF: https://github.com/llvm/llvm-project/commit/43c84e463426ca35fe9fc2d38063d75fed944f23.diff

[PATCH] D128411: [syntax] Introduce a BaseToken class.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenManager.h:9 +// +// Defines Token interfaces for the syntax-tree, decoupling the syntax-tree from +// the TokenBuffer. It enables producers (e.g. clang pseudoparser) to produce a

[clang] fd47894 - [NFC] Add parentheses around && within || to avoid warning

Author: Chuanqi Xu Date: 2022-06-27T14:44:10+08:00 New Revision: fd47894d88faf9147bcdb99cb5cae33519e418dd URL: https://github.com/llvm/llvm-project/commit/fd47894d88faf9147bcdb99cb5cae33519e418dd DIFF: https://github.com/llvm/llvm-project/commit/fd47894d88faf9147bcdb99cb5cae33519e418dd.diff

[clang] 663e47a - [OpenCL] Reduce emitting candidate notes for builtins

Author: Sven van Haastregt Date: 2022-06-27T09:55:44+01:00 New Revision: 663e47a50f50c9ff0da9ba805f804c06645638ed URL: https://github.com/llvm/llvm-project/commit/663e47a50f50c9ff0da9ba805f804c06645638ed DIFF:

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

nikic added a comment. In D103874#3611507 , @aqjune wrote: > In D103874#3611483 , @nikic wrote: > >> Which intrinsic are you working on here? If this is about the mm_undefined >> intrinsics, why do we need to

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

This revision was automatically updated to reflect the committed changes. Closed by commit rG869385b11c32: [flang][driver] Add support for `-O{0|1|2|3}` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/

[clang] 869385b - [flang][driver] Add support for `-O{0|1|2|3}`

Author: Andrzej Warzynski Date: 2022-06-27T10:06:14Z New Revision: 869385b11c32032d02f5f24fcd21c694fb073850 URL: https://github.com/llvm/llvm-project/commit/869385b11c32032d02f5f24fcd21c694fb073850 DIFF: https://github.com/llvm/llvm-project/commit/869385b11c32032d02f5f24fcd21c694fb073850.diff

[clang] 4588b6f - Fix clang docs build; NFC

Author: Aaron Ballman Date: 2022-06-27T07:12:36-04:00 New Revision: 4588b6fd266243eaa0d970d34fd4e11e4082cd1e URL: https://github.com/llvm/llvm-project/commit/4588b6fd266243eaa0d970d34fd4e11e4082cd1e DIFF: https://github.com/llvm/llvm-project/commit/4588b6fd266243eaa0d970d34fd4e11e4082cd1e.diff

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

zahiraam accepted this revision. zahiraam added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 ___ cfe-commits mailing list

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:197 - "${" + - std::to_string(SnippetArg == CursorSnippetArg ? 0 : SnippetArg) + ':'; appendEscapeSnippet(Chunk.Text, Snippet); as you've

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

anton-afanasyev created this revision. anton-afanasyev added reviewers: MaskRay, kito-cheng, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, abidh, jocewei, PkmX, the_o,

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 440118. balazske marked an inline comment as done. balazske added a comment. Applied the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files:

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3609511 , @fmayer wrote: > FWIW this is not really NFC, I found this as the culprit in bisecting the > Android LLVM toolchain build, causing the following error: > > FAILED:

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

ilya-biryukov added a comment. My 2 cents here. We should probably try hard to keep the cursor inside braces/parentheses for those patterns. Having namespace foo { decls }^ <- cursor here hurts UX. It would be nice to get the old behavior back somehow. I still have hopes for the VSCode

[clang] 5830da1 - [AArch64] Define __FP_FAST_FMA[F]

Author: Jolanta Jensen Date: 2022-06-27T11:37:40+01:00 New Revision: 5830da1f8625d2bf94180df997ae78c37f378480 URL: https://github.com/llvm/llvm-project/commit/5830da1f8625d2bf94180df997ae78c37f378480 DIFF:

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

This revision was automatically updated to reflect the committed changes. Closed by commit rG5830da1f8625: [AArch64] Define __FP_FAST_FMA[F] (authored by jolanta.jensen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127655/new/

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG663e47a50f50: [OpenCL] Reduce emitting candidate notes for builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added a comment. In D103874#3611483 , @nikic wrote: > Which intrinsic are you working on here? If this is about the mm_undefined > intrinsics, why do we need to change those from the current status quo of > using a zero value instead of undef?

[PATCH] D128411: [syntax] Introduce a BaseToken class.

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:463 +/// It tracks the underlying token buffers, source manager, etc. +class SyntaxTokenManager : public TokenManager { +public: sammccall wrote: > conceptually this is

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. This seems to have broken standalone builds for Gentoo. While building Clang, I get: CMake Error at /usr/lib/llvm/15/lib/cmake/llvm/LLVM-Config.cmake:138 (message): Target Sparc is not in the set of libraries. Call Stack (most recent call first):

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

rjmccall accepted this revision. rjmccall added a comment. Thank you, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://reviews.llvm.org/D128571 ___ cfe-commits mailing list

[PATCH] D128359: [clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`.

wyt updated this revision to Diff 440123. wyt marked an inline comment as done. wyt added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128359/new/ https://reviews.llvm.org/D128359 Files:

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

nikic added a comment. Which intrinsic are you working on here? If this is about the mm_undefined intrinsics, why do we need to change those from the current status quo of using a zero value instead of undef? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

rovka accepted this revision. rovka added a comment. Cool, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 ___ cfe-commits mailing list

[clang] bdfe556 - [clang][dataflow] Implement functionality for flow condition variable substitution.

Author: Wei Yi Tee Date: 2022-06-27T11:37:46+02:00 New Revision: bdfe556dd837007c5671f33384d26e9ea315db53 URL: https://github.com/llvm/llvm-project/commit/bdfe556dd837007c5671f33384d26e9ea315db53 DIFF: https://github.com/llvm/llvm-project/commit/bdfe556dd837007c5671f33384d26e9ea315db53.diff

[PATCH] D128363: [clang][dataflow] Implement functionality for flow condition variable substitution.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdfe556dd837: [clang][dataflow] Implement functionality for flow condition variable… (authored by wyt, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen updated this revision to Diff 440141. jolanta.jensen added a comment. Removed an unnecessary local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128182/new/ https://reviews.llvm.org/D128182 Files:

[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:240-241 + // Index used to avoid recreating pointer values for null pointers of the + // same canonical pointee type. + //

[PATCH] D128624: [RISCV] Zero immediate for vget/vset builtins to match vector.insert/extract intrinsics.

fakepaper56 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128624/new/ https://reviews.llvm.org/D128624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128612: RISC-V big-endian support implementation

jhenderson added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:864 /// Tests whether the target is RISC-V (32- and 64-bit). bool isRISCV() const { Perhaps worth updating to mention big and little endian here, like `isPPC64` above?

[PATCH] D128363: [clang][dataflow] Implement functionality for flow condition variable substitution.

wyt updated this revision to Diff 440119. wyt marked an inline comment as done. wyt added a comment. Address comments - add example to `buildAndSubstituteFlowCondition` doc comment, add tests for atomic and negated flow condition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 440134. mboehme marked an inline comment as done. mboehme added a comment. Turn off clang-format for attr-declspec-ignored.cpp. It has existing formatting (indentation within namespaces) that's incompatible with clang-format. Repository: rG LLVM Github

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa83aa33d1bf9: [IR] Move vector.insert/vector.extract out of experimental namespace (authored by bsmith). Changed prior to commit:

[PATCH] D128624: [RISCV] Zero immediate for vget/vset builtins to match vector.insert/extract intrinsics.

craig.topper created this revision. craig.topper added reviewers: liaolucy, kito-cheng, fakepaper56, frasercrmck, rogfer01. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:246 +- Improved :doc:`bugprone-signal-handler + ` check. Partial LegalizeAdulthood wrote: > Please keep the section sorted by check,

[PATCH] D128411: [syntax] Introduce a BaseToken class.

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:569 struct Forest { -Forest(syntax::Arena ) { - assert(!A.getTokenBuffer().expandedTokens().empty()); - assert(A.getTokenBuffer().expandedTokens().back().kind() == tok::eof);

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added a comment. In D103874#3594617 , @aqjune wrote: > It seems llvm/lib/Target/X86/X86ISelLowering.cpp's LowerAVXCONCAT_VECTORS is > relevant to efficient lowering of `shufflevector %x, freeze(poison), mask`. After patching

[clang] 12c7352 - [clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`.

Author: Wei Yi Tee Date: 2022-06-27T11:16:51+02:00 New Revision: 12c7352fa4885a61997cff26f9578bacc166df3b URL: https://github.com/llvm/llvm-project/commit/12c7352fa4885a61997cff26f9578bacc166df3b DIFF: https://github.com/llvm/llvm-project/commit/12c7352fa4885a61997cff26f9578bacc166df3b.diff

[PATCH] D128359: [clang][dataflow] Move logic for `createStorageLocation` from `DataflowEnvironment` to `DataflowAnalysisContext`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG12c7352fa488: [clang][dataflow] Move logic for `createStorageLocation` from… (authored by wyt, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

wyt updated this revision to Diff 440162. wyt marked 2 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128056/new/ https://reviews.llvm.org/D128056 Files:

[clang] 70a5c52 - [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

Author: Lucas Prates Date: 2022-06-27T14:08:48+01:00 New Revision: 70a5c525349be3ce9ad2bfdf9c995355ba07c864 URL: https://github.com/llvm/llvm-project/commit/70a5c525349be3ce9ad2bfdf9c995355ba07c864 DIFF: https://github.com/llvm/llvm-project/commit/70a5c525349be3ce9ad2bfdf9c995355ba07c864.diff

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70a5c525349b: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas). Repository: rG LLVM Github

[clang] f5d781d - [X86] Support `_Float16` on SSE2 and up

Author: Phoebe Wang Date: 2022-06-27T21:37:30+08:00 New Revision: f5d781d6273cc56dd8b44ee9e4cfb2ae5579bb04 URL: https://github.com/llvm/llvm-project/commit/f5d781d6273cc56dd8b44ee9e4cfb2ae5579bb04 DIFF: https://github.com/llvm/llvm-project/commit/f5d781d6273cc56dd8b44ee9e4cfb2ae5579bb04.diff

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5d781d6273c: [X86] Support `_Float16` on SSE2 and up (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely marked 7 inline comments as done. futogergely added a comment. In D91000#3506605 , @whisperity wrote: > Just one question if you could try this out for me: what happens if you run > `clang-tidy a.c b.c` (two TUs in the invocation) where **one

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 440211. samestep added a comment. - Merge branch 'main' into diagnose-api Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files:

[PATCH] D108469: Improve handling of static assert messages.

aaron.ballman added reviewers: tahonermann, clang-language-wg. aaron.ballman added a comment. Thanks for picking this back up! I have mostly nits, a few questions, and am adding some extra reviewers who may have an opinion. Also, I think the summary needs to be updated (this is no longer

[PATCH] D108469: Improve handling of static assert messages.

erichkeane added inline comments. Comment at: llvm/lib/Support/Unicode.cpp:268 + // hyphen in most terminals. + return Printables.contains(UCS) || UCS == 0x00AD; +} As a nit, this condition might be worth reversing to get the 'fast thing' on the LHS of the

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff updated this revision to Diff 440241. sepavloff added a comment. Rebased, optimized FPOptions::diffWith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123952/new/ https://reviews.llvm.org/D123952 Files:

[clang] aa89bb3 - [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD

Author: Frederic Cambus Date: 2022-06-27T17:38:31+02:00 New Revision: aa89bb3435e0abe6e80eac9d1ac43aaf5e04d1c8 URL: https://github.com/llvm/llvm-project/commit/aa89bb3435e0abe6e80eac9d1ac43aaf5e04d1c8 DIFF:

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87-91 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the web interface - `_ ). If you use a - different tool, make sure

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440270. vaibhav.y added a comment. Factor dependency on `Lexer::MeasureTokenLength` into externally provided functor Introduces a type: `TokenLengthMetric` which measures the length of a token starting at the given SLoc Repository: rG LLVM Github

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood added a comment. I pushed this change, but for some reason phabricator doesn't show it and close the review... I wonder if it's because I rebased it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440286. abrahamcd added a comment. Removed old test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files:

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

myhsu added a comment. > I pushed this change, but for some reason phabricator doesn't show it and > close the review... I wonder if it's because I rebased it? You forgot to add "Differential Revison:

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 440216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128182/new/ https://reviews.llvm.org/D128182 ___ cfe-commits mailing list

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440227. thieta added a comment. Fixed missing -- in test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D125669: Adding support for target in_reduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8322fe200d60: Adding support for target in_reduction (authored by RitanyaB, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:452 + : getCurCompoundScope().FPFeatures; + FPOptionsOverride FPDiff = getCurFPFeatures().diffWith(FPO); + rjmccall wrote: > How cheap is this? Is this something it

[PATCH] D128659: [clang][dataflow] Add `buildAndSubstituteFlowCondition` to `DataflowEnvironment`

wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D128658 Repository: rG

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 ___ cfe-commits

[PATCH] D128649: [clang-cl] Handle some pragma alloc_text corner cases handled by MSVC

hans added a comment. In D128649#3612626 , @steplong wrote: > I think we have to use `isInExternCContext()` to accept the following (MSVC > accepts this): > > extern "C" { static void f(); } > static void f() {} I'm probably missing something. Is

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam closed this revision. jspam added a comment. No idea, I'll just close this then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 ___ cfe-commits

[PATCH] D128667: [WIP] Add Zstd ELF support

ckissane updated this revision to Diff 440296. ckissane added a comment. simplifed codeflow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128667/new/ https://reviews.llvm.org/D128667 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440178. thieta added a comment. Added tests and moved the check for TY_Plist and TY_AST to it's own if statement block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409

[clang] ca47ab1 - [Clang] Remove unused function declaration after 77475ffd22418ca72.

Author: Florian Hahn Date: 2022-06-27T14:17:53+01:00 New Revision: ca47ab128bf33d1e2aa753da76f1224b53c37661 URL: https://github.com/llvm/llvm-project/commit/ca47ab128bf33d1e2aa753da76f1224b53c37661 DIFF: https://github.com/llvm/llvm-project/commit/ca47ab128bf33d1e2aa753da76f1224b53c37661.diff

[PATCH] D128643: [clang] -fsanitize=array-bounds: treat all trailing size-1 arrays as flexible

serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/Expr.h:455 + bool isFlexibleArrayMember(ASTContext , int StrictFlexArraysLevel, + bool IgnoreSizeFromMacro) const; Maybe default to `false` here?

[PATCH] D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa89bb3435e0: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD (authored by fcambus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

rjmccall added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:214 +OverrideMask |= NAME##Mask; +#include "clang/Basic/FPOptions.def" + return FPOptionsOverride(*this, OverrideMask); Hmm. If we can assume that all of the options are single

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 440261. cor3ntin marked 5 inline comments as done. cor3ntin added a comment. - Address Aaron's and Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This looks a great improvement. A few nits, it looks good to me overall. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:136 + // check whether

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

Eugene.Zelenko added a comment. Locations for tests and check documentation was changed recently. Please rebase from `main` and adjust your code accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000

[PATCH] D128645: Update developer policy.

aaron.ballman added subscribers: cfe-commits, aaron.ballman. aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:87-91 -#. Patches should be made with ``git format-patch``, or similar (see special - commands for `Requesting Phabricator review via the

[PATCH] D128649: [clang-cl] Accept a pragma alloc_text corner case accepted by MSVC

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC's pragma alloc_text accepts a function that was redeclared in a non extern-C context if the previous declaration was

[PATCH] D128649: [clang-cl] Accept a pragma alloc_text corner case accepted by MSVC

hans added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:811 return; } Since the pragma only applies to functions, maybe we should error here if the decl is not a FunctionDecl? Comment at:

[PATCH] D125916: [PowerPC] Defined and lowered llvm.ppc.kill.canary intrinsic

pscoro abandoned this revision. pscoro added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11136 +MachineFrameInfo = MF.getFrameInfo(); +int SPI = MFI.getStackProtectorIndex(); // should return -1 + shchenz wrote: > Why

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 440264. fhahn added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:161 +Region["endColumn"] = adjustColumnPos( +R.getEnd(), Lexer::MeasureTokenLength(R.getEnd().getLocWithOffset(0), + R.getEnd().getManager(), LO));

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440279. vaibhav.y added a comment. Discard unused includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 440189. pratlucas added a comment. Updating method to use `MAchineBasickBlock::iterator&`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit in the testing. Comment at: clang/lib/Sema/SemaDecl.cpp:4633-4637 Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS,

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely added a comment. In D91000#3612090 , @Eugene.Zelenko wrote: > Locations for tests and check documentation was changed recently. Please > rebase from `main` and adjust your code accordingly. Done. CHANGES SINCE LAST ACTION

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Herald added a project: All. This landed slightly modified here: https://github.com/llvm/llvm-project/commit/4d54e543abd5d0a8b0a321f8c292252f4895693a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D3/new/

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. Fixed the test issue. Regarding `/Fo` bit - if you want I can change it to only handle `/o` in this if statement. I don't mind either way. Comment at: clang/test/Driver/ast.c:30 +// Also check clang-cl since the driver is slightly different +// RUN:

[PATCH] D128620: [Driver][test] Add libclang_rt.profile{{.*}}.a tests for NetBSD

fcambus added a comment. In D128620#3611156 , @MaskRay wrote: > It's best to switch to LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on layout at some > point. Noted, thanks. I will investigate switching both NetBSD and OpenBSD in the future. Repository: rG

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

peixin added a comment. In summary: > If you want to use the updated name, flang, set FLANG_USE_LEGACY_NAME to ON > when configuring LLVM Flang. OFF? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 440259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 440267. sunshaoce added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:51-57 +auto Methods = MemberCall->getRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { + return

[PATCH] D128319: Survive #pragma once from virtual file.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. +1, this needs some test coverage for the changes. It should also have a release note to notify users of the fix. Comment at: clang/lib/Lex/Pragma.cpp:415-419 + if

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:148 +- New :doc:`bugprone-unsafe-functions ` check. + Please keep checks entries in alphabetical order. Comment at:

[clang] 8322fe2 - Adding support for target in_reduction

Author: Ritanya B Bharadwaj Date: 2022-06-27T10:36:46-05:00 New Revision: 8322fe200d60919bcf19700138f04f9fdc909360 URL: https://github.com/llvm/llvm-project/commit/8322fe200d60919bcf19700138f04f9fdc909360 DIFF:

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440242. thieta added a comment. Just handle /o for AST and plist files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440243. thieta added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D128645: Update developer policy.

vext01 added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:112-114 -When submitting patches, please do not add confidentiality or non-disclosure -notices to the patches themselves. These notices conflict with the LLVM -licensing terms and may result in your

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski added a comment. In D125788#3612533 , @peixin wrote: > In summary: > >> If you want to use the updated name, flang, set FLANG_USE_LEGACY_NAME to ON >> when configuring LLVM Flang. > > OFF? Updated, thanks! Repository: rG LLVM Github

[PATCH] D128446: [clang][dataflow] Use annotations for optional diagnostic tests

ymandel added a comment. This looks quite nice. I really like how you solved the problem of diagnostics representation/checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128446/new/ https://reviews.llvm.org/D128446

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 440283. awarzynski added a comment. Incorporate @clementval 's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://reviews.llvm.org/D125788 Files: clang/lib/Driver/Driver.cpp

  1   2   3   >