[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:78 +Status Status; +std::optional> Solution; }; `#include "llvm/ADT/DenseMap.h"` Comment at:

[PATCH] D129258: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core functionalities of the clang-offload-bundler into a user-facing

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added a comment. I feel obliged to point out that the sheer number of updates is too large. Every update triggers an email to all reviewers and subscribers, so please be mindful. Personally I don't mind how many updates I receive, but others may do. It's usually not too bad to have too

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

steakhal added a comment. Sorry about my delayed response. I was busy. I've left a couple comments inline. Nothing serious. Thanks for the patch! Comment at: clang/docs/ReleaseNotes.rst:593 + +- clang-extdef-mapping now accepts .ast files as input. This is faster than to +

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

yurai007 created this revision. yurai007 added reviewers: nikic, ChuanqiXu, lxfind, GorNishanov. Herald added a project: All. yurai007 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Recently C++ snippet included in this patch popped up at

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442845. wyt added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442848. wyt added a comment. Replace std::optional with llvm::Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files:

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson marked 3 inline comments as done. royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; +

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers created this revision. vabridgers added reviewers: martong, steakhal. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All.

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:42 + : Ctx(Context), SM(Context.getSourceManager()) { +CurrentFileName = astFilePath.str(); + } steakhal wrote: > Why is this not initialized in the

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442828. wyt added a comment. Make scope resolution consistent (Solver:: instead of WatchedLiteralsSolver::). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files:

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 442844. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take review into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files:

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

steakhal added a comment. In D127874#3628112 , @martong wrote: >> I don't think any of the issues mentioned in this patch relates to strongly >> connected components, thus I don't think I can answer to this question. > > In your example above, repeated

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442825. wyt marked 3 inline comments as done. wyt added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files:

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. First of all, I am really sorry about the noise and the misbehavior here. I have to admit that some of the changes here are because I am still in the way of getting familiar with the patch system. I apologize for being careless in the progress. > I don't know

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2db2a4e11240: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209 (authored by peterwaller-arm). Repository: rG LLVM Github Monorepo

[clang] 2db2a4e - [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

Author: Peter Waller Date: 2022-07-07T10:55:40Z New Revision: 2db2a4e112406e97bad82b8e78492a472c13588e URL: https://github.com/llvm/llvm-project/commit/2db2a4e112406e97bad82b8e78492a472c13588e DIFF: https://github.com/llvm/llvm-project/commit/2db2a4e112406e97bad82b8e78492a472c13588e.diff LOG:

[clang] 14c30c7 - [clang-format] Avoid crash in LevelIndentTracker.

Author: Marek Kurdej Date: 2022-07-07T10:15:45+02:00 New Revision: 14c30c70c4595d8f410c74a72357a5a31fdd5507 URL: https://github.com/llvm/llvm-project/commit/14c30c70c4595d8f410c74a72357a5a31fdd5507 DIFF: https://github.com/llvm/llvm-project/commit/14c30c70c4595d8f410c74a72357a5a31fdd5507.diff

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c30c70c459: [clang-format] Avoid crash in LevelIndentTracker. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129064/new/

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:266 + /// - `Unsatisfiable`: A satisfying assignment does not exist. + /// -

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 442849. iains marked 25 inline comments as done. iains added a comment. rebased, addressed review comments, added another test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. @rsmith, @ChuanqiXu apologies for the multiple revisions, this has turned out to be much more involved than I imagined from the standard's text. In D126694#3629254 , @ChuanqiXu wrote: > In D126694#3629251

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442824. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files:

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

ABataev added a comment. In D129008#3634073 , @jdoerfert wrote: > cleanup/destructor test missing. > > @ABataev WDYT? Looks good in general, extra tests would be good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442840. wyt marked 3 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files:

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:67 +/// boolean formula if available. Otherwise, an empty optional is returned. +std::optional> +getSolution() const { Please use llvm::Optional, we

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

steakhal added a comment. Actually, there is one more bug there. If the string has an embedded null-terminator; a wrong length will be returned. Please add tests to demonstrate the wrong behavior. Try different target triples for having irregular char sizes and pin that. Repository: rG LLVM

[PATCH] D128535: [analyzer] Improve loads from reinterpret-cast fields

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1897 + QualType Ty = SubReg->getValueType(); + if (BaseTy->isScalarType() && Ty->isScalarType()) { +if (Ctx.getTypeSizeInChars(BaseTy) >= Ctx.getTypeSizeInChars(Ty)) {

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, rnk, shafik. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. The two first parameters of checkPreprocessorOptions are "PPOpts, ExistingPPOpts". All other callers of

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

clementval added a comment. @pengfei We are also hitting the following assertion with this patch. Do you have any idea why? /llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4333: void {anonymous}::SelectionDAGLegalize::ConvertNodeToLibcall(llvm::SDNode*): Assertion

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:60 + +std::string symbolName(clang::pseudo::SymbolID SID, + const clang::pseudo::Grammar ) { This code is copied right? Comment at:

[clang] 2d01a85 - [Driver] Improve linking options for target AVR

Author: KOLANICH Date: 2022-07-07T22:45:21+08:00 New Revision: 2d01a8572076a93fa40c4af934e78a859f3096ee URL: https://github.com/llvm/llvm-project/commit/2d01a8572076a93fa40c4af934e78a859f3096ee DIFF: https://github.com/llvm/llvm-project/commit/2d01a8572076a93fa40c4af934e78a859f3096ee.diff

[PATCH] D127501: [AVR] Fixed broken linking using `avr-gcc`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d01a8572076: [Driver] Improve linking options for target AVR (authored by KOLANICH, committed by benshi001). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM),

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j updated this revision to Diff 442945. lamb-j added a comment. Adding clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 Files: clang/tools/clang-offload-bundler/CMakeLists.txt

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. Thanks @clementval for reporting it and the reproducer. Put a patch D129294 to address it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D129303: [clang-offload-bundler] Library-ize ClangOffloadBundler (2/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lifting the core

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

martong created this revision. martong added reviewers: isuckatcs, NoQ, bruntib, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus.

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire updated this revision to Diff 442902. junaire added a comment. extern printf so we can use, another copy paster mistake... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 Files:

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jdoerfert added a comment. Generally makes sense, some notes though Comment at: clang/test/Frontend/embed-object.ll:17 + +; CHECK: !llvm.embedded.object = !{![[METADATA_1:[0-9]+]], ![[METADATA_2:[0-9]+]]} +; CHECK: ![[METADATA_1]] = !{ptr @[[OBJECT_1]], !".llvm.offloading"}

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. the revised diagnostics look like this: ` error: {un-}exported inline function not defined before the private module fragment` with ` note: private module fragment begins here` pointing to the start of the PMF If there is no PMF then we just say: ` error:

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

junaire updated this revision to Diff 442879. junaire added a comment. Correct copy paster error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 Files: clang/test/Interpreter/execute-weak.cpp

[PATCH] D129305: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

wyt updated this revision to Diff 442874. wyt added a comment. Remove decomposing declarations which are not available in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129180/new/ https://reviews.llvm.org/D129180 Files:

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

jhuber6 updated this revision to Diff 442941. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Addressing comments. Metadata is now empty and must be empty for the flag to be emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129151/new/ https://reviews.llvm.org/D129151

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains updated this revision to Diff 442942. iains marked 3 inline comments as done. iains added a comment. rebased, reworked - to follow the changes proposed by core - to make the diagnostics follow that and a compromise for the proposed revision before the core amendment. Repository: rG

[PATCH] D129298: Add denormal-fp-math attribute for f16

arsenm added a comment. Missing ARM changes that demonstrate the use of the control? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129298/new/ https://reviews.llvm.org/D129298 ___ cfe-commits mailing

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + royjacobson wrote: > erichkeane wrote: > > royjacobson

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added a comment. Note that the build failure seems unrelated, as it's due to a failing clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed801ad5e5fe: [Clang] Use metadata to make identifying embedded objects easier (authored by jhuber6). Changed prior to commit:

[PATCH] D129151: [Metadata] Add 'exclude' metadata to add the exclude flags on globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41fba3c107a5: [Metadata] Add exclude metadata to add the exclude flags on globals (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] 41fba3c - [Metadata] Add 'exclude' metadata to add the exclude flags on globals

Author: Joseph Huber Date: 2022-07-07T12:20:40-04:00 New Revision: 41fba3c107a5bc99065f3bf8b9f5b9d52eab2d98 URL: https://github.com/llvm/llvm-project/commit/41fba3c107a5bc99065f3bf8b9f5b9d52eab2d98 DIFF: https://github.com/llvm/llvm-project/commit/41fba3c107a5bc99065f3bf8b9f5b9d52eab2d98.diff

[clang] ed801ad - [Clang] Use metadata to make identifying embedded objects easier

Author: Joseph Huber Date: 2022-07-07T12:20:25-04:00 New Revision: ed801ad5e5fef76c4303d04fd8de21662b428bee URL: https://github.com/llvm/llvm-project/commit/ed801ad5e5fef76c4303d04fd8de21662b428bee DIFF: https://github.com/llvm/llvm-project/commit/ed801ad5e5fef76c4303d04fd8de21662b428bee.diff

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

njames93 added a subscriber: klimek. njames93 added a comment. Sorry to do this again, but could this be split up again, one patch for the new matcher and the tests associated with it, then another for the actual bug fix. Also cc @klimek as he is the code owner of ASTMatchers Repository: rG

[PATCH] D129298: Add denormal-fp-math attribute for f16

dcandler created this revision. dcandler added reviewers: arsenm, spatel, echristo, andrew.w.kaylor, cameron.mcinally. Herald added subscribers: jsji, kosarev, jdoerfert, pengfei, hiraditya, kristof.beyls, tpr. Herald added a project: All. dcandler requested review of this revision. Herald added

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added a comment. In D129100#3634548 , @vitalybuka wrote: > This looks flaky https://lab.llvm.org/buildbot/#/builders/5/builds/25929 Sorry about that, I believe this is fixed in eb64dbd6e0e617298579d32372fb92e595816d45

[clang] 6c3990a - [OpenMP][NFC] Claim order clause modifiers (reproducible and unconstrained)

Author: Chi Chun Chen Date: 2022-07-07T11:30:03-05:00 New Revision: 6c3990acfbb933a61e2c74332bb252121c06bd14 URL: https://github.com/llvm/llvm-project/commit/6c3990acfbb933a61e2c74332bb252121c06bd14 DIFF: https://github.com/llvm/llvm-project/commit/6c3990acfbb933a61e2c74332bb252121c06bd14.diff

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

MaskRay accepted this revision. MaskRay added a comment. You may push this patch and its prerequisite while other patches are still to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129279/new/ https://reviews.llvm.org/D129279

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jdoerfert added a subscriber: jhuber6. jdoerfert added a comment. Isn't the offload bundler on it's "way out" (=replaced and then deleted soon)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 443123. ChuanqiXu added a comment. Minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/test/Modules/Inputs/redundant-template-default-arg/foo.cppm

[clang-tools-extra] cd3aa33 - [pseudo] NFC, fix the header guard for Language.h

Author: Haojian Wu Date: 2022-07-07T14:42:26+02:00 New Revision: cd3aa338c720b9ee296348e3670c284cfead969d URL: https://github.com/llvm/llvm-project/commit/cd3aa338c720b9ee296348e3670c284cfead969d DIFF: https://github.com/llvm/llvm-project/commit/cd3aa338c720b9ee296348e3670c284cfead969d.diff

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

steakhal added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:149 + if (!CI) +CI = new CompilerInstance(); + thieta wrote: > steakhal wrote: > > What takes the ownership of `CI`? When is it deleted? > I don't think

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jhuber6 updated this revision to Diff 442926. jhuber6 added a comment. Updating to use `objects` and adding documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129033/new/ https://reviews.llvm.org/D129033 Files:

[PATCH] D129033: [Clang] Use metadata to make identifying embedded objects easier

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129033/new/ https://reviews.llvm.org/D129033

[PATCH] D129300: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (4/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a subscriber: mgorny. Herald added a project: All. lamb-j requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Lifting the core

[clang-tools-extra] eb64dbd - [clangd] Fix flaky throttler test

Author: Sam McCall Date: 2022-07-07T18:09:54+02:00 New Revision: eb64dbd6e0e617298579d32372fb92e595816d45 URL: https://github.com/llvm/llvm-project/commit/eb64dbd6e0e617298579d32372fb92e595816d45 DIFF: https://github.com/llvm/llvm-project/commit/eb64dbd6e0e617298579d32372fb92e595816d45.diff

[PATCH] D129304: [clang-offload-bundler] Library-ize ClangOffloadBundler (3/4)

lamb-j created this revision. lamb-j added reviewers: kzhuravl, scott.linder, yaxunl. Herald added a reviewer: alexander-shaposhnikov. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lifting the core

[clang] 42e1035 - [LinkerWrapper] Identify offloading sections using ELF type

Author: Joseph Huber Date: 2022-07-07T12:38:00-04:00 New Revision: 42e10354d4553cdce131add80a4bf135f01d40db URL: https://github.com/llvm/llvm-project/commit/42e10354d4553cdce131add80a4bf135f01d40db DIFF: https://github.com/llvm/llvm-project/commit/42e10354d4553cdce131add80a4bf135f01d40db.diff

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. Consider adding `have_zstd` to `compiler-rt/test/lit.common.cfg.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5247-5248 + // ObjC + case tok::at: +return getLangOpts().ObjC; + In Objective-C, both declarations and expressions can start with `@`. In general we'd need to look at the next token

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo updated this revision to Diff 443075. mstorsjo added a comment. Add `/*Diags=*/nullptr` for clarity, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129277/new/ https://reviews.llvm.org/D129277 Files:

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

This revision was automatically updated to reflect the committed changes. Closed by commit rGc84d29acbfa6: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c84d29a - [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

Author: owenca Date: 2022-07-07T15:33:09-07:00 New Revision: c84d29acbfa671b4a7fb24764cbd4bfa5f6aad5c URL: https://github.com/llvm/llvm-project/commit/c84d29acbfa671b4a7fb24764cbd4bfa5f6aad5c DIFF: https://github.com/llvm/llvm-project/commit/c84d29acbfa671b4a7fb24764cbd4bfa5f6aad5c.diff LOG:

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:202 +return print_diff(old_tree, new_tree) elif opts.diffstat: +return print_diffstat(old_tree, new_tree) Comment at:

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers added a comment. Thanks Balazs, you mean something like this correct? void strcpy_no_overflow_2(char *y) { char x[3]; strcpy(x, "12\0"); // this produces a warning, but should not. } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers updated this revision to Diff 443101. vabridgers added a comment. a proposal to handle embedded null case caught by @steakhal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D129269 Files:

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3635207 , @iains wrote: > @rsmith, @ChuanqiXu apologies for the multiple revisions, this has turned out > to be much more involved than I imagined from the standard's text. > > In D126694#3629254

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. It looks like the tests would work in CI in the clang-cl configurations with this modification: diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot index 65155ba173ed..407e93ef1575 100755 --- a/libcxx/utils/ci/run-buildbot +++

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. In D111081#3633908 , @mstorsjo wrote: > LGTM, thanks, and sorry for losing track of it earlier. > > Do you need someone to push the patch for you? In that case, can you provide > your preferred git author line for the patch?

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added inline comments. Comment at: llvm/test/LTO/Resolution/X86/alias-indirect-function-lto.ll:15 + +@foo = ifunc i32 (i32), i32 (i32)* ()* @foo_resolver + Replace all these `xxx*` to `ptr` (opaque pointers). See recent clang's codegen. Repository:

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; hokein wrote: > sammccall

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 443124. ChuanqiXu added a comment. Minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu closed this revision. ChuanqiXu added a comment. Committed in https://reviews.llvm.org/rG354a597b9f3aad2a6a37518d47351adb99688cd2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until

[PATCH] D128372: [Clang-Tidy] Empty Check

denik accepted this revision. denik added a comment. Thanks Abraham! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay accepted this revision. MaskRay added a comment. Please check both `LLVM_ENABLE_ZSTD={on,off}` work. Ideally, check that when zstd' cmake (`libzstd-dev` on Debian) is unavailable, `LLVM_ENABLE_ZSTD=on` works (there is no zstd functionality but the cmake invocation should succeed).

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:892 + return false; if (CAT->getSize().ugt(1)) return false; Similar to SemaChecking below, could use a comment like: FIXME: While the default -fstrict-flex-arrays=0

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 443070. python3kgae added a comment. Fix test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files: clang/include/clang/Basic/TargetOptions.h

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo added a comment. In D129277#3636795 , @aaron.ballman wrote: > In D129277#3636596 , @mstorsjo > wrote: > >> In D129277#3636567 , >> @aaron.ballman wrote: >>

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j added a comment. @yaxunl Are you recommending I combine all 4 patches down into 1 patch? Or combine a subset of patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11155 +def err_export_inline_not_defined : Error< + "exported inline functions must be defined within the module purview" + " and before any private module fragment">;

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jhuber6 added a comment. In D129301#3637642 , @jdoerfert wrote: > Isn't the offload bundler on it's "way out" (=replaced and then deleted soon)? HIP still uses it to create their `fatbinary` format for CUDA-like support for multi-architecture binaries

[clang] 354a597 - [C++20] [Modules] Don't complain about duplicated default template argument across modules

Author: Chuanqi Xu Date: 2022-07-08T11:10:51+08:00 New Revision: 354a597b9f3aad2a6a37518d47351adb99688cd2 URL: https://github.com/llvm/llvm-project/commit/354a597b9f3aad2a6a37518d47351adb99688cd2 DIFF: https://github.com/llvm/llvm-project/commit/354a597b9f3aad2a6a37518d47351adb99688cd2.diff

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu added a comment. The direction is approved in https://reviews.llvm.org/D113545. @MaskRay might you help to review the style? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 ___

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added a comment. OK, I think the approach is fine. Comment at: llvm/include/llvm/IR/GlobalIFunc.h:97 + + /// Method to apply specific operation to all resolver-related values. + /// If resolver target is already a global object, then apply the operation to

[clang] 8e21802 - [clang] [MinGW] Fix paths on Gentoo

Author: Mark Harmstone Date: 2022-07-08T00:37:08+03:00 New Revision: 8e218026f8d5eabfdef9141ae5e26aa91d1933e6 URL: https://github.com/llvm/llvm-project/commit/8e218026f8d5eabfdef9141ae5e26aa91d1933e6 DIFF:

  1   2   >