[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Ah... I remember now, and I think that solution isn't quite right. The idea is that we want to defer constraint evaluation when the constraint is on a function decl/template decl. The PROBLEM I need to solve is when it is in a body of a struct or function.

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h:49-56 +debugString(std::vector , Solver::Result , +llvm::DenseMap AtomNames = {{}}); +inline std::string

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b89d1d59f82: [Sema] Add deprecation warnings for some compiler provided __has_* type traits (authored by royjacobson). Repository: rG LLVM

[clang] 0b89d1d - [Sema] Add deprecation warnings for some compiler provided __has_* type traits

Author: Roy Jacobson Date: 2022-07-12T19:24:17+03:00 New Revision: 0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9 URL: https://github.com/llvm/llvm-project/commit/0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9 DIFF: https://github.com/llvm/llvm-project/commit/0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9.diff

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645660 , @nickdesaulniers wrote: > - add more links to commit message as they come in Oh, right, updating the commit message doesn't update the description in phab. Oops! Repository: rG LLVM Github

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Some nits inline, but looks good to me. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:119-133 +std::vector> LinesData; +for (auto :

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2240d72f15f3: [X86] initial -mfunction-return=thunk-extern support (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Please update the comment, then LGTM Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:801 +

[clang] 2240d72 - [X86] initial -mfunction-return=thunk-extern support

Author: Nick Desaulniers Date: 2022-07-12T09:17:54-07:00 New Revision: 2240d72f15f3b7b9d9fb65450f9bf635fd310f6f URL: https://github.com/llvm/llvm-project/commit/2240d72f15f3b7b9d9fb65450f9bf635fd310f6f DIFF:

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:33-34 + explicit DebugStringGenerator( + llvm::DenseMap UserSpecifiedAtomNames) + : Counter(0),

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers updated this revision to Diff 443986. nickdesaulniers added a comment. - add more links to commit message as they come in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129572/new/ https://reviews.llvm.org/D129572 Files:

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

craig.topper accepted this revision. craig.topper added a comment. I also reviewed off-list and the X86 parts LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129572/new/ https://reviews.llvm.org/D129572

[PATCH] D128974: [RFC] [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5791bcf9db0a: [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[clang] 5791bcf - [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

Author: Chuanqi Xu Date: 2022-07-13T00:13:56+08:00 New Revision: 5791bcf9db0a3ec8bbce586dd99fce71fd773134 URL: https://github.com/llvm/llvm-project/commit/5791bcf9db0a3ec8bbce586dd99fce71fd773134 DIFF: https://github.com/llvm/llvm-project/commit/5791bcf9db0a3ec8bbce586dd99fce71fd773134.diff

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 443983. wyt added a comment. Change propagated from parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129548/new/ https://reviews.llvm.org/D129548 Files:

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443982. wyt added a comment. Move `DebugStringGenerator` class into anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files:

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:263 +private: + std::vector> Vals; +}; `#include ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. > Many thanks for folks that provided discrete review off list due to the > embargoed nature of this hardware vulnerability. I was one of those off-list reviewers, and the Clang

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers created this revision. Herald added subscribers: jsji, jdoerfert, pengfei, hiraditya, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D129570: Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 created this revision. pfultz2 added reviewers: aaron.ballman, alexfh. pfultz2 added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. pfultz2 requested review of this revision. Herald added a subscriber: cfe-commits. This check

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b0ae144ed8: [AST] Accept identical TypeConstraint referring to other template (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f6b0ae1 - [AST] Accept identical TypeConstraint referring to other template

Author: Chuanqi Xu Date: 2022-07-12T23:57:44+08:00 New Revision: f6b0ae144ed8085618c12ba83d95affd786e6a49 URL: https://github.com/llvm/llvm-project/commit/f6b0ae144ed8085618c12ba83d95affd786e6a49 DIFF: https://github.com/llvm/llvm-project/commit/f6b0ae144ed8085618c12ba83d95affd786e6a49.diff

[PATCH] D129373: [NFC] Minor cleanup of usage of FloatModeKind with bitmask enums

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:894 bool useObjCFPRetForRealType(FloatModeKind T) const { -return RealTypeUsesObjCFPRetMask & llvm::BitmaskEnumDetail::Underlying(T); +return

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:28 + +class DebugStringGenerator { +public: This class could be in anonymous

[PATCH] D129569: [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

thakis created this revision. thakis added a reviewer: akyrtzi. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. Like https://reviews.llvm.org/D129226, but for iOS. No behavior change. https://reviews.llvm.org/D129569 Files:

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 443971. wyt added a comment. Remove unnecessary enum keyword. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129548/new/ https://reviews.llvm.org/D129548 Files:

[PATCH] D129568: [clang][dataflow] Rename `Status` field in a `Solver::Result` struct to `SATCheckStatus`.

wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, `Status` was named after the enum

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443968. wyt added a comment. Fix use after move. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-formatted-files.txt

[clang] 1586b59 - [LinkerWrapper] Clean-up unused definitions

Author: Joseph Huber Date: 2022-07-12T11:46:46-04:00 New Revision: 1586b5952894c9ba1941fd38a1f7a6b8ca4ee8df URL: https://github.com/llvm/llvm-project/commit/1586b5952894c9ba1941fd38a1f7a6b8ca4ee8df DIFF: https://github.com/llvm/llvm-project/commit/1586b5952894c9ba1941fd38a1f7a6b8ca4ee8df.diff

[clang] 86a49a4 - [LinkerWrapper] Make ThinLTO work inside the linker wrapper

Author: Joseph Huber Date: 2022-07-12T11:46:46-04:00 New Revision: 86a49a4f4f50c2590716bdc440a97e89f5858a4f URL: https://github.com/llvm/llvm-project/commit/86a49a4f4f50c2590716bdc440a97e89f5858a4f DIFF: https://github.com/llvm/llvm-project/commit/86a49a4f4f50c2590716bdc440a97e89f5858a4f.diff

[PATCH] D129104: [Modules] Add ODR Check for concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b95a5a77253: [Modules] Add ODR Check for concepts (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4b95a5a - [Modules] Add ODR Check for concepts

Author: Chuanqi Xu Date: 2022-07-12T23:45:53+08:00 New Revision: 4b95a5a772530f78326941f26e5cb2c33212460f URL: https://github.com/llvm/llvm-project/commit/4b95a5a772530f78326941f26e5cb2c33212460f DIFF: https://github.com/llvm/llvm-project/commit/4b95a5a772530f78326941f26e5cb2c33212460f.diff

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 443961. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:187 +- Clang now would check ODR violations when merging concepts from different modules. + Note that it may break existing codes and the behavior is intended. + Fixes `Issue 56310

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:341-342 + !MDC.OriginalInvocation.getDependencyOutputOpts().OutputFile.empty(); + // FIXME: HadSerializedDiagnostics and HadDependencyFile should be included in +

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/docs/ReleaseNotes.rst:187 +- Clang now would check ODR violations when merging concepts from different modules. + Note that it may break existing codes and the behavior is intended.

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 443958. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTContext.cpp

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 template function. Fixes `Issue 55560 `_. +- Clang now would check ODR violations when merging concepts from different modules. + Note that it

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 443957. ChuanqiXu added a comment. Add ReleaseNotes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ASTContext.cpp

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:963-964 + Entity(Entity), + EvaluatingAConstraint(EvaluatingConstraint || +!SemaRef.CurContext->isDependentContext()) {}

[clang] d6ef3d2 - [mlir] Remove VectorToROCDL

Author: Krzysztof Drewniak Date: 2022-07-12T15:21:22Z New Revision: d6ef3d20b4e3768dc30fb229dfa938d8059fffef URL: https://github.com/llvm/llvm-project/commit/d6ef3d20b4e3768dc30fb229dfa938d8059fffef DIFF: https://github.com/llvm/llvm-project/commit/d6ef3d20b4e3768dc30fb229dfa938d8059fffef.diff

[PATCH] D129308: [mlir] Remove VectorToROCDL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6ef3d20b4e3: [mlir] Remove VectorToROCDL (authored by krzysz00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128974: [RFC] [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128974/new/ https://reviews.llvm.org/D128974 ___ cfe-commits mailing list

[clang] 6626f6f - [clang][deps] Override dependency and serialized diag files for modules

Author: Ben Langmuir Date: 2022-07-12T08:19:52-07:00 New Revision: 6626f6fec3d37b78b628b858bdadbbb8301e1a2f URL: https://github.com/llvm/llvm-project/commit/6626f6fec3d37b78b628b858bdadbbb8301e1a2f DIFF: https://github.com/llvm/llvm-project/commit/6626f6fec3d37b78b628b858bdadbbb8301e1a2f.diff

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG6626f6fec3d3: [clang][deps] Override dependency and serialized diag files for modules (authored by benlangmuir). Changed prior to commit: https://reviews.llvm.org/D129389?vs=443755=443955#toc

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443951. mizvekov marked 2 inline comments as done. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked 7 inline comments as done. mizvekov added a subscriber: sammccall. mizvekov added a comment. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. In D112374#3535949 , @rsmith wrote: > I've not looked at the test changes in

[clang] 2b9055c - [PS4/PS5] NFC: Use preferred predicate in a triple check

Author: Paul Robinson Date: 2022-07-12T08:10:25-07:00 New Revision: 2b9055cee657fbec1afa93da3751bb923649fbde URL: https://github.com/llvm/llvm-project/commit/2b9055cee657fbec1afa93da3751bb923649fbde DIFF: https://github.com/llvm/llvm-project/commit/2b9055cee657fbec1afa93da3751bb923649fbde.diff

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

vsapsai accepted this revision as: vsapsai. vsapsai added a comment. This revision is now accepted and ready to land. My comments are addressed, thanks for making the changes! Please wait for @ilya-biryukov's approval to confirm he has nothing else to add. CHANGES SINCE LAST ACTION

[PATCH] D129226: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd489268392d2: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx… (authored by thakis). Herald added a project: clang.

[clang] d489268 - [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

Author: Nico Weber Date: 2022-07-12T11:03:51-04:00 New Revision: d489268392d231492827c5b0a3be88b707e1fd31 URL: https://github.com/llvm/llvm-project/commit/d489268392d231492827c5b0a3be88b707e1fd31 DIFF: https://github.com/llvm/llvm-project/commit/d489268392d231492827c5b0a3be88b707e1fd31.diff

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 443947. wyt added a comment. Fix comment, remove unused import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129548/new/ https://reviews.llvm.org/D129548 Files:

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:963-964 + Entity(Entity), + EvaluatingAConstraint(EvaluatingConstraint || +!SemaRef.CurContext->isDependentContext()) {}

[PATCH] D129563: [docs] Document git-clang-format

thakis added a comment. (does anyone know why git-clang-format isn't implemented in terms of clang-format-diff.py? I suppose it's easier to use if it's standalone?) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129563/new/ https://reviews.llvm.org/D129563

[PATCH] D129563: [docs] Document git-clang-format

thakis created this revision. thakis added reviewers: curdeius, MyDeveloperDay. Herald added a project: All. thakis requested review of this revision. clang-format's documentation documented the more general clang-format-diff.py script. Add documentation for the less general but arguably

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:963-964 + Entity(Entity), + EvaluatingAConstraint(EvaluatingConstraint || +!SemaRef.CurContext->isDependentContext()) {}

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu added a comment. Thanks for reviewing and noting! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. In D126907#3645198 , @erichkeane wrote: > In D126907#3644127 , @ChuanqiXu > wrote: > >> In D126907#3642530 , @erichkeane >> wrote: >> >>>

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:226 + // Add the PowerPC intrinsic headers (/include/ppc_wrappers) + if (!DriverArgs.hasArg(clang::driver::options::OPT_nostdinc) && + !DriverArgs.hasArg(options::OPT_nobuiltininc)) {

[PATCH] D129562: [SystemZ] Enable `-mtune=` option in clang.

Kai created this revision. Kai added reviewers: uweigand, jnspaulsson, yusra.syeda, Everybody0523. Herald added subscribers: luke957, s.egerton, simoncook. Herald added a project: All. Kai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project:

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 443941. wyt marked 2 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129548/new/ https://reviews.llvm.org/D129548 Files:

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443940. wyt marked 10 inline comments as done. wyt added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files:

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

wyt updated this revision to Diff 443938. wyt marked 2 inline comments as done. wyt added a comment. Address comments on renaming. Removed test fixture class, replacing TEST_F with TEST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129546/new/

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6851 Group, Flags<[DXCOption, NoXarchOption]>, Alias; +def dxc_I : DXCJoinedOrSeparateConflict<"I">, + HelpText<"Add directory to include search path">, beanz wrote: > This option

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:1110 + // Ai is ignored; + if (PartialOrdering && ArgIdx + 1 == NumArgs && + isa(Args[ArgIdx])) aaron.ballman wrote: > Why are you checking `ArgIdx + 1 == NumArgs`

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added a comment. Should have a release note on commit! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

sammccall added a comment. In D128621#3645123 , @ilya-biryukov wrote: > Another alternative that I think should give the best UX is to replace > `${0:named}` with `$0`. > The items will look different, but will behave identically to the old > behavior

[PATCH] D129226: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

dexonsmith added a reviewer: akyrtzi. dexonsmith added a subscriber: akyrtzi. dexonsmith added a comment. LGTM too, but I’m not at Apple these days. @akyrtzi, can you help find someone appropriate to take a quick look since @arphaman seems busy? CHANGES SINCE LAST ACTION

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 ___ cfe-commits mailing

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:341-342 +

[PATCH] D128462: [HLSL] add -I option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6851 Group, Flags<[DXCOption, NoXarchOption]>, Alias; +def dxc_I : DXCJoinedOrSeparateConflict<"I">, + HelpText<"Add directory to include search path">, This option has the same

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

c-rhodes added a comment. In D129476#3643382 , @efriedma wrote: > Are you saying that it's faster to use clasta targeting a float register, > then move the result to an integer register, rather than use the integer form > directly? Or is the issue

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

aaron.ballman added a comment. I admit that I'm feeling a bit out of my element with all the template machinery involved, so I've reviewed as best I'm able (so if any of my questions seem odd to you, push back on them if you want). Comment at:

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

beanz added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:575 + if (IK.getLanguage() == Language::HLSL) +DefaultOpt = llvm::CodeGenOpt::Aggressive; Is there a way to tie this to using the DXC driver instead of the language

[PATCH] D129226: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, but maybe wait a few more days in case the apple folks want to chime in CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129226/new/ https://reviews.llvm.org/D129226

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3644127 , @ChuanqiXu wrote: > In D126907#3642530 , @erichkeane > wrote: > >> This version passes check-runtimes, so libc++ is fine, and it passes >> everything I have

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

sammccall added a comment. In D124447#3608747 , @aaron.ballman wrote: > In general, I think this is looking pretty close to good. Whether clang-tidy > should get this functionality in this form or not is a bit less clear to me. > *I* think it's

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:143 + +return formatv("{0:$[\n]}", llvm::make_range(Lines.begin(), Lines.end())); + } I appreciate the table, but it looks quite bulky... Could we switch to a

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

erichkeane added a comment. This patch makes sense to me, but please clean up the test as @ilya-biryukov suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new/ https://reviews.llvm.org/D129499

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127304/new/ https://reviews.llvm.org/D127304

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h:24-25 +namespace dataflow { +/// Utility functions which return a string representation for a boolean value +/// `B`. +/// Comment at:

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze added a comment. In D124244#3588671 , @steakhal wrote: > Sorry for my late reply. > > It feels like we have some serious obstacles. > The `check::PostCall` handler wants to mark some memory region immutable. > Currently, the checker creates

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:223 +/// Utility class for creating boolean values. +class BoolValueManager {

[PATCH] D128449: [clang] Introduce -Warray-parameter

alexfh added a comment. Serge, this diagnostic doesn't handle non-type template parameters correctly in some cases. Here's an example derived from a real code: https://gcc.godbolt.org/z/cvP8od5c6 template struct T { static void F(int a[8 * K]); }; template void T::F(int a[8 * K])

[PATCH] D129514: Thread safety analysis: Support builtin pointer-to-member operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129514/new/ https://reviews.llvm.org/D129514

[PATCH] D126742: [RISCV][Clang] Support RVV policy functions.

StephenFan added inline comments. Herald added a subscriber: nlopes. Comment at: clang/lib/Sema/SemaRVVLookup.cpp:378-388 +} else { + if (IsPrototypeDefaultTU) { +DefaultPolicy = Policy::TU; +if (HasPolicy) + BuiltinName += "_tu"; + } else

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

ilya-biryukov added a comment. Another alternative that I think should give the best UX is to replace `${0:named}` with `$0`. The items will look different, but will behave identically to the old behavior before VSCode change, i.e. won't "eat" an extra tab press at the end of completion

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc309721d20c: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] cc30972 - [Clang] Add a warning on invalid UTF-8 in comments.

Author: Corentin Jabot Date: 2022-07-12T14:34:30+02:00 New Revision: cc309721d20c8e544ae7a10a66735ccf4981a11c URL: https://github.com/llvm/llvm-project/commit/cc309721d20c8e544ae7a10a66735ccf4981a11c DIFF:

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

thakis added a comment. Bot's happy again. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128914/new/ https://reviews.llvm.org/D128914 ___ cfe-commits mailing list

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein updated this revision to Diff 443922. hokein added a comment. remove all TokenBufferTokenManager cast usage, make it as a contract in the APIs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411/new/ https://reviews.llvm.org/D128411

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

aaron.ballman accepted this revision. aaron.ballman added a comment. In D128059#3643081 , @cor3ntin wrote: > Fix crash on PowerPC > > (I forgot to removed a non-sense line that > could cause the CurPtr to move incorrectly > past a / in the ALTIVEC code

[PATCH] D129534: [OpenMP] Do not link static library with `-nogpulib`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd214bfe78d8d: [OpenMP] Do not link static library with `-nogpulib` (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129534/new/

[clang] d214bfe - [OpenMP] Do not link static library with `-nogpulib`

Author: Joseph Huber Date: 2022-07-12T08:15:15-04:00 New Revision: d214bfe78d8d79a9c6bce5a7daf8d70135ebc670 URL: https://github.com/llvm/llvm-project/commit/d214bfe78d8d79a9c6bce5a7daf8d70135ebc670 DIFF: https://github.com/llvm/llvm-project/commit/d214bfe78d8d79a9c6bce5a7daf8d70135ebc670.diff

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

wyt updated this revision to Diff 443917. wyt added a comment. Use std::vector as input to `debugString` to maintain order stability of boolean constraints to enable testing. `debugString` which takes a `llvm::DenseSet` is now a wrapper around the logic applied to std::vector. Repository:

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

wyt updated this revision to Diff 443914. wyt added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129170/new/ https://reviews.llvm.org/D129170

[PATCH] D129362: Undeprecate ATOMIC_FLAG_INIT in C++

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 3cfa32a71ecfbc1bf993358e32b916cf3483299f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2   3   >