[clang] ae002f8 - Use isa instead of dyn_cast (NFC)

Author: Kazu Hirata Date: 2022-07-25T23:00:58-07:00 New Revision: ae002f8bca11bf652fa4d2683c8a627fa77158a8 URL: https://github.com/llvm/llvm-project/commit/ae002f8bca11bf652fa4d2683c8a627fa77158a8 DIFF: https://github.com/llvm/llvm-project/commit/ae002f8bca11bf652fa4d2683c8a627fa77158a8.diff

[clang-tools-extra] 3f3930a - Remove redundaunt virtual specifiers (NFC)

Author: Kazu Hirata Date: 2022-07-25T23:00:59-07:00 New Revision: 3f3930a451e118e82885a6dd20e3918427b816c2 URL: https://github.com/llvm/llvm-project/commit/3f3930a451e118e82885a6dd20e3918427b816c2 DIFF: https://github.com/llvm/llvm-project/commit/3f3930a451e118e82885a6dd20e3918427b816c2.diff

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:40-41 // Synthetic boolean values are either atomic values or composites that // represent conjunctions, disjunctions, and negations.

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

gribozavr updated this revision to Diff 447609. gribozavr added a comment. Actually visit a subexpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130522/new/ https://reviews.llvm.org/D130522 Files:

[PATCH] D117973: [cmake] Support custom package install paths

sebastian-ne added a comment. I found a regression when llvm is added with CMake’s add_subdirectory. D130555 has a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

steakhal added a comment. Looks good to me, but I think you should wait for @NoQ for approval as he had some concerns previously. @NoQ, do you think it's in a good shape for landing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534

[clang] ad17e69 - [analyzer] Fix unused variable warning in release builds. NFC.

Author: Benjamin Kramer Date: 2022-07-26T11:29:38+02:00 New Revision: ad17e69923ec39b6439ac0041e69de1f1f5ecec4 URL: https://github.com/llvm/llvm-project/commit/ad17e69923ec39b6439ac0041e69de1f1f5ecec4 DIFF:

[clang] bc4eef5 - [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC)

Author: Zakk Chen Date: 2022-07-26T09:35:34Z New Revision: bc4eef509b21e5ba72dcf18f949eae27087a7b9c URL: https://github.com/llvm/llvm-project/commit/bc4eef509b21e5ba72dcf18f949eae27087a7b9c DIFF: https://github.com/llvm/llvm-project/commit/bc4eef509b21e5ba72dcf18f949eae27087a7b9c.diff LOG:

[PATCH] D126740: [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc4eef509b21: [RISCV][Clang] Refactor and rename rvv intrinsic related stuff. (NFC) (authored by khchen). Changed prior to commit:

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

awarzynski added a comment. Thanks for working on this. This is not my area of expertise, so I focused on the implementation in the driver. Comment at: clang/include/clang/Driver/Options.td:4897 def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Group,

[clang] f3fbbe1 - [clang][analyzer][NFC] Use value_or instead of ValueOr

Author: David Spickett Date: 2022-07-26T09:16:45Z New Revision: f3fbbe1cf33bf4da8e2620c770997d9ff68a5384 URL: https://github.com/llvm/llvm-project/commit/f3fbbe1cf33bf4da8e2620c770997d9ff68a5384 DIFF: https://github.com/llvm/llvm-project/commit/f3fbbe1cf33bf4da8e2620c770997d9ff68a5384.diff

[PATCH] D130551: [pseudo] Allow opaque nodes to represent terminals

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks good, are you planning to use it in the cxx.bnf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130551/new/

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. AutoUpgrade is added due to similar issue at a user. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/

[clang] a618d5e - [analyzer] Structured binding to tuple-like types

Author: isuckatcs Date: 2022-07-26T10:24:29+02:00 New Revision: a618d5e0dd5d6fee5d73e823dbf8301663be0b4f URL: https://github.com/llvm/llvm-project/commit/a618d5e0dd5d6fee5d73e823dbf8301663be0b4f DIFF: https://github.com/llvm/llvm-project/commit/a618d5e0dd5d6fee5d73e823dbf8301663be0b4f.diff

[PATCH] D128837: [analyzer] Structured binding to tuple-like types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa618d5e0dd5d: [analyzer] Structured binding to tuple-like types (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG

[clang] 3281138 - [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

Author: Dmitri Gribenko Date: 2022-07-26T10:26:44+02:00 New Revision: 3281138aad80fcefc7f266c7e3b2e359d5dbc8da URL: https://github.com/llvm/llvm-project/commit/3281138aad80fcefc7f266c7e3b2e359d5dbc8da DIFF:

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3281138aad80: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X` (authored by gribozavr). Repository: rG LLVM Github Monorepo

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein added a comment. In D130511#3677423 , @sammccall wrote: > My main concern here is that this might reject valid code (and if it doesn't, > it's not obvious why). > It does look like C++ forbids the cases I can come up with (e.g. trying to >

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. Looks good to me Comment at: openmp/CMakeLists.txt:3 -# Add cmake directory to search for custom cmake functions. -set(CMAKE_MODULE_PATH

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:273 + +// Visit a sub-value of `Val` (pick any, they are identical). + } else { Let's visit `C->getLeftSubValue()`

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng marked 9 inline comments as done. kito-cheng added a comment. @aaron.ballman thanks for your review! Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:400 + // Number of fields, greater than 1 if it's segment load/store. + uint8_t NF; +};

[PATCH] D130514: [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0df7d8bc355d: [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build (authored by abrachet). Herald added a project: clang. Herald added

[clang] 0df7d8b - [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build

Author: Alex Brachet Date: 2022-07-26T06:09:38Z New Revision: 0df7d8bc355dd506bb1a330b9f73e611f0deaf9f URL: https://github.com/llvm/llvm-project/commit/0df7d8bc355dd506bb1a330b9f73e611f0deaf9f DIFF: https://github.com/llvm/llvm-project/commit/0df7d8bc355dd506bb1a330b9f73e611f0deaf9f.diff LOG:

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130551: [pseudo] Allow opaque nodes to represent terminals

sammccall created this revision. sammccall added reviewers: hokein, usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This allows incomplete code such as `namespace

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added a comment. @ChuanqiXu , the release notes were updated. Could you check and merge please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792

[clang] 996b092 - [analyzer] Lambda capture non-POD type array

Author: isuckatcs Date: 2022-07-26T09:40:25+02:00 New Revision: 996b092c5e170786572e925345e502e5376feaee URL: https://github.com/llvm/llvm-project/commit/996b092c5e170786572e925345e502e5376feaee DIFF: https://github.com/llvm/llvm-project/commit/996b092c5e170786572e925345e502e5376feaee.diff

[PATCH] D129967: [analyzer] Lambda capture non-POD type array

This revision was automatically updated to reflect the committed changes. Closed by commit rG996b092c5e17: [analyzer] Lambda capture non-POD type array (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kito-cheng marked an inline comment as done. Closed by commit rG7a5cb15ea6fa: [RISCV]

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126744: [RISCV][Clang] Support policy functions for vneg, vnot, vncvt, vwcvt, vwcvtu, vfabs and vfneg.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126744/new/

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[clang] 8a13326 - [analyzer] ArrayInitLoopExpr with array of non-POD type

Author: isuckatcs Date: 2022-07-26T09:07:22+02:00 New Revision: 8a13326d184c2829a51d7c00f467ded06412f858 URL: https://github.com/llvm/llvm-project/commit/8a13326d184c2829a51d7c00f467ded06412f858 DIFF: https://github.com/llvm/llvm-project/commit/8a13326d184c2829a51d7c00f467ded06412f858.diff

[PATCH] D129496: [analyzer] ArrayInitLoopExpr with array of non-POD type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a13326d184c: [analyzer] ArrayInitLoopExpr with array of non-POD type (authored by isuckatcs). Herald added a project: clang. Herald added a

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, sebastian-ne, mstorsjo. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't need to

[PATCH] D126750: [RISCV][Clang] Support policy function for all vector segment load.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126748/new/ https://reviews.llvm.org/D126748

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126745/new/ https://reviews.llvm.org/D126745

[PATCH] D126750: [RISCV][Clang] Support policy function for all vector segment load.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126750/new/ https://reviews.llvm.org/D126750

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu added a comment. Sorry for the frequent ping since 15.x is going to be branched. @aaron.ballman @tahonermann I know this might not look good to you. But I want to ask if there is any objection? Personally, the preferred_name attribute is not so important and it blocks something

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130411: [clang-format] Fix a hang when formatting C# $@ string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffb3dd33ee1: [clang-format] Fix a hang when formatting C# $@ string literals (authored by owenpan). Changed prior to commit:

[clang] 0ffb3dd - [clang-format] Fix a hang when formatting C# $@ string literals

Author: owenca Date: 2022-07-25T23:17:54-07:00 New Revision: 0ffb3dd33ee1a50a6ab5db80bb8caee9133e66dc URL: https://github.com/llvm/llvm-project/commit/0ffb3dd33ee1a50a6ab5db80bb8caee9133e66dc DIFF: https://github.com/llvm/llvm-project/commit/0ffb3dd33ee1a50a6ab5db80bb8caee9133e66dc.diff LOG:

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if

[PATCH] D130550: [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Previously we were calling glrRecover() ad-hoc at the end

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[clang] 7a5cb15 - [RISCV] Lazily add RVV C intrinsics.

Author: Kito Cheng Date: 2022-07-26T15:47:47+08:00 New Revision: 7a5cb15ea6facd82756adafae76d60f36a0b60fd URL: https://github.com/llvm/llvm-project/commit/7a5cb15ea6facd82756adafae76d60f36a0b60fd DIFF: https://github.com/llvm/llvm-project/commit/7a5cb15ea6facd82756adafae76d60f36a0b60fd.diff

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:81 # path is removed. -set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") +set(INCLUDE_DIRS ${LLVM_INCLUDE_DIRS}) set(LLVM_OBJ_DIR "${LLVM_BINARY_DIR}") Do we need to add

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

steakhal added a comment. Other than nits, I think it looks great. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1359 +void CStringChecker::evalMemcmp(CheckerContext , const CallExpr *CE, +bool IsWide) const { // int

[clang] c73adba - [clang] [docs] Update the changes of C++20 Modules in clang15

Author: Chuanqi Xu Date: 2022-07-26T18:47:53+08:00 New Revision: c73adbad6a9964e0700865b7c786cc6885898c68 URL: https://github.com/llvm/llvm-project/commit/c73adbad6a9964e0700865b7c786cc6885898c68 DIFF: https://github.com/llvm/llvm-project/commit/c73adbad6a9964e0700865b7c786cc6885898c68.diff

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

This revision was automatically updated to reflect the committed changes. Closed by commit rGc73adbad6a99: [clang] [docs] Update the changes of C++20 Modules in clang15 (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130476: [NFC] Fix some C++20 warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130476/new/ https://reviews.llvm.org/D130476

[PATCH] D130081: Add foldings for multi-line comment.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:1782 unsigned endCharacter; - std::string kind; + FoldingRangeKind kind; }; hokein wrote: > sorry for not being clear on my previous comment, I think the current `string >

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:40-41 // Synthetic boolean values are either atomic values or composites that // represent conjunctions, disjunctions, and negations. AtomicBool,

[clang] b5e3dac - [clang][dataflow] Add explicit "AST" nodes for implications and iff

Author: Dmitri Gribenko Date: 2022-07-26T14:19:22+02:00 New Revision: b5e3dac33d42cdf8a3b19b1f64b726e700363ded URL: https://github.com/llvm/llvm-project/commit/b5e3dac33d42cdf8a3b19b1f64b726e700363ded DIFF:

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e3dac33d42: [clang][dataflow] Add explicit AST nodes for implications and iff (authored by gribozavr). Changed prior to commit:

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

gribozavr2 requested changes to this revision. gribozavr2 added a comment. This revision now requires changes to proceed. Sorry, could you rebase the patch? It does not apply cleanly anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz abandoned this revision. sgraenitz added a comment. Close in favor of the D128190 , which covers both cases at once: emit (was D124762 ) and inline (was D127962 ) Repository: rG

[PATCH] D128535: [analyzer] Improve loads from reinterpret-cast fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. steakhal marked 2 inline comments as done. Closed by commit rGa80418eec001: [analyzer] Improve loads from reinterpret-cast fields (authored by steakhal). Changed

[clang] a80418e - [analyzer] Improve loads from reinterpret-cast fields

Author: Balazs Benics Date: 2022-07-26T12:31:21+02:00 New Revision: a80418eec001d91f9573456b31704a350e421560 URL: https://github.com/llvm/llvm-project/commit/a80418eec001d91f9573456b31704a350e421560 DIFF: https://github.com/llvm/llvm-project/commit/a80418eec001d91f9573456b31704a350e421560.diff

[PATCH] D130551: [pseudo] Allow opaque nodes to represent terminals

sammccall added a comment. In D130551#3679021 , @hokein wrote: > The change looks good, are you planning to use it in the cxx.bnf? I want to land a recovery rule that completes scopes (e.g. namespaces) rather than discarding them. But i have to fix

[PATCH] D129174: [C++20][Modules] Update ADL to handle basic.lookup.argdep p4 [P1815R2 part 1]

ChuanqiXu added a comment. FYI When I implements/tests the modularized STL for libstdc++ (https://github.com/ChuanqiXu9/stdmodules), I find the patch blocks it. Due to the time is limited (I really wish we could have something workable in clang15), I made a pre-review commit in:

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D129138#3674619 , @iains wrote: > In D129138#3670708 , @ChuanqiXu > wrote: > >> @iains I'm going

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. Thanks for working on this! I have some suggestions, but you'll also need to add a release note at some point. Comment at: clang/lib/Analysis/CFG.cpp:970-980 +if (LHSExpr->EvaluateAsInt(IntExprResult, *Context)) { + // Evaluating

[clang] ba198e3 - [NFC] Fix some C++20 warnings

Author: Evgeny Mandrikov Date: 2022-07-26T14:04:12+02:00 New Revision: ba198e35fd380350ff7bf5b47d8cf5fa9a43d3e6 URL: https://github.com/llvm/llvm-project/commit/ba198e35fd380350ff7bf5b47d8cf5fa9a43d3e6 DIFF:

[PATCH] D130476: [NFC] Fix some C++20 warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba198e35fd38: [NFC] Fix some C++20 warnings (authored by Godin, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126741: [RISCV][Clang] Refactor RISCVVEmitter. (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93f8657c743b: [RISCV][Clang] Refactor RISCVVEmitter. (NFC) (authored by khchen). Changed prior to commit:

[clang] 93f8657 - [RISCV][Clang] Refactor RISCVVEmitter. (NFC)

Author: Zakk Chen Date: 2022-07-26T10:15:04Z New Revision: 93f8657c743ba9ce9696e5f0c9487207cf8ccb6b URL: https://github.com/llvm/llvm-project/commit/93f8657c743ba9ce9696e5f0c9487207cf8ccb6b DIFF: https://github.com/llvm/llvm-project/commit/93f8657c743ba9ce9696e5f0c9487207cf8ccb6b.diff LOG:

[clang] 15ddc09 - [C++20] [Modules] Handle linkage properly for specializations when overloading

Author: Chuanqi Xu Date: 2022-07-26T18:30:48+08:00 New Revision: 15ddc09ef9b05ffd5398165049b5202264fa203a URL: https://github.com/llvm/llvm-project/commit/15ddc09ef9b05ffd5398165049b5202264fa203a DIFF: https://github.com/llvm/llvm-project/commit/15ddc09ef9b05ffd5398165049b5202264fa203a.diff

[PATCH] D130476: [NFC] Fix some C++20 warnings

Godin added a comment. @aaron.ballman thanks for the review! could you please commit this on my behalf since I do not have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130476/new/ https://reviews.llvm.org/D130476

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

sammccall added a comment. TL;DR: I suspect this is valid but guarding `nested-name-specifier := :: [guard=PrevNotIdentifier]` may be equivalent and clearer. In D130511#3678938 , @hokein wrote: > In D130511#3677423

[clang-tools-extra] 07b7ff9 - [pseudo] Allow opaque nodes to represent terminals

Author: Sam McCall Date: 2022-07-26T13:56:26+02:00 New Revision: 07b7ff983837dbc20749682673d09992f71b0c59 URL: https://github.com/llvm/llvm-project/commit/07b7ff983837dbc20749682673d09992f71b0c59 DIFF: https://github.com/llvm/llvm-project/commit/07b7ff983837dbc20749682673d09992f71b0c59.diff

[PATCH] D130551: [pseudo] Allow opaque nodes to represent terminals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b7ff983837: [pseudo] Allow opaque nodes to represent terminals (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { usaxena95 wrote: > sammccall wrote: > > hokein wrote: > > > why there is a dummy namespace here? > > for each

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added a comment. @xazax.hun Do you have anything else you'd like addressed/changed (either here or in the doc we shared with you) before I land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep updated this revision to Diff 447656. samestep added a comment. Rebase and add Yitzie's assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130270/new/ https://reviews.llvm.org/D130270 Files:

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep added a comment. In D130270#3679273 , @gribozavr2 wrote: > Sorry, could you rebase the patch? It does not apply cleanly anymore. Done; I didn't see any conflicts when I rebased, but hopefully the issue on your end is resolved now?

[PATCH] D130550: [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:74 bool GCParity; +// Have we already used this node for error recovery? (prevents loops) +mutable bool Recovered = false; hokein wrote: > haven't look

[PATCH] D130374: [Passes] add a tail-call-elim pass near the end of the opt pipeline

spatel added a comment. In D130374#3679550 , @hiraditya wrote: > In D130374#3675677 , @vdsered wrote: > >> Just JFYI :) >> Yes, probably not worth it > > that is interesting. do we know why? Based on this data:

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28e665fa054d: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs (authored by Ericson2314). Repository: rG LLVM Github

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added inline comments. Comment at: openmp/CMakeLists.txt:3 -# Add cmake directory to search for custom cmake functions. -set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH}) +set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)

[PATCH] D130575: clang: include ManagedStatic.h for llvm_shutdown

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added a project: All. nhaehnle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The code relied on ManagedStatic.h being included indirectly. This is about

[PATCH] D130574: ClangLinkerWrapper: explicitly #include

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added a project: All. nhaehnle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This code relied on implicitly having std::atomic available via the

[PATCH] D129118: CommandLine: add and use cl::SubCommand::get{All,TopLevel}

nhaehnle updated this revision to Diff 447694. nhaehnle added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129118/new/ https://reviews.llvm.org/D129118 Files: bolt/lib/Utils/CommandLineOpts.cpp

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130576: ManagedStatic: remove from ASTMatchersInternal.h

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added a project: All. nhaehnle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130576

[PATCH] D130577: clang-driver: use llvm_fast_shutdown

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner, mehdi_amini. Herald added a project: All. nhaehnle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid running almost all global destructors in the common case.

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux [clang-linux-sparc-libatomic.patch, submitted 2022-07-26]

glaubitz accepted this revision. glaubitz added a comment. This revision is now accepted and ready to land. This should address the current CI issues on sparc64 together with D130571 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130578: ManagedStatic: remove a use from Clang

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added a project: All. nhaehnle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130578

  1   2   3   >