[PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4047785 , @erichkeane wrote: > @mizvekov : I'm looking at the revert of this since no work seems to have > been done to fix @steven_wu 's problem. Unfortunately, it seems that > reverting this requires

[PATCH] D140415: [flang] stack arrays pass

tblah updated this revision to Diff 488685. tblah added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, Flang. - Do not move allocations outside of openmp regions - Detect loops in the control flow graph - Attempt to

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

arsenm added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:531-537 + CmdArgs.push_back(*ClangPath); + CmdArgs.push_back("-o"); + CmdArgs.push_back(*TempFileOrErr); + CmdArgs.push_back("-fPIC"); + CmdArgs.push_back("-c"); +

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488609. pmatos marked an inline comment as done. pmatos added a comment. Deal with Itanium Mangle and assert false outside Wasm triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/

[clang] a74bc43 - Add a warning comment that this file is generated

Author: Aaron Ballman Date: 2023-01-12T08:10:57-05:00 New Revision: a74bc436703057ab0f53ad78ab3f84227a45e37f URL: https://github.com/llvm/llvm-project/commit/a74bc436703057ab0f53ad78ab3f84227a45e37f DIFF: https://github.com/llvm/llvm-project/commit/a74bc436703057ab0f53ad78ab3f84227a45e37f.diff

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2480-2481 #include "clang/Basic/RISCVVTypes.def" +#define WASM_TYPE(Name, Id, SingletonId) case BuiltinType::Id: +#include "clang/Basic/WebAssemblyReferenceTypes.def" case BuiltinType::ShortAccum:

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jhuber6 added a comment. In D141105#4046400 , @gribozavr2 wrote: > FYI: I fixed the problem in > https://github.com/llvm/llvm-project/commit/0a11a1b1868dd2ab183c4313ccbfbe126e91ca08. Thanks, I forgot to update that test after fixing a similar problem

[PATCH] D141608: [include-cleaner] Don't consider the underlying type of Decltype MemberProvider as a use

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. For this case, the argument of `decltype` is the provider. This fixes the sample in

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

philnik added a comment. In D141572#4047428 , @aaron.ballman wrote: > Thank you for working on this! I think the Debian CI failure is unrelated, > but the libc++ one looks plausibly related: > > >

[clang] 452115e - Reword diagnostic slightly; NFC

Author: Aaron Ballman Date: 2023-01-12T10:12:57-05:00 New Revision: 452115eaec6a493f8c8308b1eb2334100e2b6320 URL: https://github.com/llvm/llvm-project/commit/452115eaec6a493f8c8308b1eb2334100e2b6320 DIFF: https://github.com/llvm/llvm-project/commit/452115eaec6a493f8c8308b1eb2334100e2b6320.diff

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

aaron.ballman added a comment. In D140860#4045224 , @dblaikie wrote: > In D140860#4044937 , @aaron.ballman > wrote: > >> In D140860#4031872 , @dblaikie >> wrote: >> >>>

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo updated this revision to Diff 488653. VitaNuo added a comment. Change implementation from using "print" to using "sys.stderr.write". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141611/new/ https://reviews.llvm.org/D141611 Files:

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

VitaNuo added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:145 path = os.path.join(root_dir, symbol_page_path) - results.append((symbol_name, + if os.path.isfile(path): +results.append((symbol_name,

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng marked 3 inline comments as done. kito-cheng added a comment. > (I probably need to update my > https://maskray.me/blog/2022-08-28-march-mcpu-mtune) At least the behavior of RISC-V GCC need to update: Architecture extension: - Take from -march if present. - Take from -mcpu if

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 +- Deprecate the global configuration file option `AnalyzeTemporaryDtors`, + which is no longer in use. The option will be fully removed in clang-tidy 18. +

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 488646. pmatos added a comment. Undo last patch. Submitted change to incorrect revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files:

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mati865 added a comment. In D141206#4043375 , @mstorsjo wrote: > Updated with some testcases. This does test that the include directory is > omitted when cross compiling, but those kinds of tests, which set up a > simulated toolchain environment with

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/tools/include-mapping/cppreference_parser.py:149 + else: +sys.stderr.write("Could not parse page: %s. Page does not exist.\n" %

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp updated this revision to Diff 488657. carlosgalvezp added a comment. Update clang-tidy formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D141583 Files:

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:106 +- Deprecate the global configuration file option `AnalyzeTemporaryDtors`, + which is no longer in use. The option will be fully removed

[PATCH] D136565: [clang] Instantiate alias templates with sugar

erichkeane added a comment. In D136565#4032150 , @erichkeane wrote: > Note that the Clang 16 branch is coming up approximately on January 24, and > this needs to be reverted or perf-regression fixed by then. @mizvekov : If > you or someone else don't

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

kadircet added inline comments. Comment at: clang/cmake/modules/AddGRPC.cmake:7 generate_proto_sources(ProtoSource ${ProtoFile} ${PROTO_UNPARSED_ARGUMENTS}) + set(LINKED_GRPC_LIBRARIES protobuf gpr grpc grpc++) Hi @sylvestre.ledru this seem to have broken

[clang] 0d0dab4 - Fix the Clang sphinx bot again

Author: Aaron Ballman Date: 2023-01-12T07:59:07-05:00 New Revision: 0d0dab4e5fbec4efb31de6b877574d0d278f6809 URL: https://github.com/llvm/llvm-project/commit/0d0dab4e5fbec4efb31de6b877574d0d278f6809 DIFF: https://github.com/llvm/llvm-project/commit/0d0dab4e5fbec4efb31de6b877574d0d278f6809.diff

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4012-4018 + if (Target->getTriple().isWasm() && Target->hasFeature("reference-types")) { +#define WASM_REF_TYPE(Name, MangledName, Id, SingletonId, AS) \ + if (BuiltinType::Id ==

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:806-807 + SingletonId = \ +

[PATCH] D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver

tmatheson added a comment. I agree the approach in D141518 makes more sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141404/new/ https://reviews.llvm.org/D141404

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm updated this revision to Diff 488638. arsenm added a comment. Fix patch split. update_cc_test_checks misses the calling convention, so I'm going to precommit a test which verifies those are correct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked an inline comment as done. pmatos added a comment. @aaron.ballman many thanks for the thorough reviews on the patches. Happy to see this moving in the right direction. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2480-2481 #include

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. So if I understand completely its so its easier to pick up an option and share as a hyperlink i.e. `<.>/llvm-project/clang/html/ClangFormatStyleOptions.html#allowallconstructorinitializersonnextline` F26159404:

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. On my laptop running import os; import multiprocessing def main(): num = len(os.sched_getaffinity(0)) numcpu = multiprocessing.cpu_count()

[PATCH] D141580: [clang] Don't consider a nullptr returned from ActOnTag() as a valid result in ParseClassSpecifier.

shafik added subscribers: aaron.ballman, shafik. shafik added a comment. I wonder if `ActionResult` needs a overload that takes `std::nullptr_t` the current interface seems easy to use wrong like we have seen here. @aaron.ballman wdyt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4047799 , @v.g.vassilev wrote: > In D131858#4047785 , @erichkeane > wrote: > >> @mizvekov : I'm looking at the revert of this since no work seems to have >> been done to

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#4047677 , @inclyc wrote: > ping :) Oh! I missed your pings because this was already marked as accepted, I'm sorry for the delay in answering your question. In D133574#3994050

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos marked 5 inline comments as done. pmatos added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4012-4018 + if (Target->getTriple().isWasm() && Target->hasFeature("reference-types")) { +#define WASM_REF_TYPE(Name, MangledName, Id, SingletonId, AS)

[PATCH] D141297: [OpenCL] Allow undefining header-only features

svenvh added a comment. In D141297#4043122 , @Anastasia wrote: > Btw I wonder if in the future we could add some error or warning in case > someone uses the same approach for frontend specific features, i.e. > > #ifdef

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

alvinhochun added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. Thank you for working on this! I think the Debian CI failure is unrelated, but the libc++ one looks plausibly related:

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 ___

[PATCH] D141414: [clang] add warning on shifting boolean type

aaron.ballman added a comment. Thank you for working on this! It seems that precommit CI found valid failures that should be addressed: Clang :: AST/Interp/shifts.cpp Clang :: Analysis/svalbuilder-simplify-no-crash.c Clang :: CXX/over/over.built/p18.cpp Clang :: Misc/warning-flags.c

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. @mizvekov : I'm looking at the revert of this since no work seems to have been done to fix @steven_wu 's problem. Unfortunately, it seems that reverting this requires reverting https://reviews.llvm.org/D134604 plus all of the "Instantiate" patches, which undoes

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. I am trying this in the wild and getting some false positives where it tries to call std::move inside loop conditions and in the boolean condition for an if statement. Stuff like: if (auto* new_ptr = steal_ptr(std::move(old_ptr))) { ... } else { return

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 488632. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 Files:

[PATCH] D141182: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c9a51bf456: [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a5c9a51 - [mips][clang] Do not define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros for MIPS-I

Author: Brad Smith Date: 2023-01-12T09:08:05-05:00 New Revision: a5c9a51bf456a505386660d9be4c641fc804b7fe URL: https://github.com/llvm/llvm-project/commit/a5c9a51bf456a505386660d9be4c641fc804b7fe DIFF: https://github.com/llvm/llvm-project/commit/a5c9a51bf456a505386660d9be4c641fc804b7fe.diff

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

aaron.ballman added a comment. In D138446#4047487 , @MyDeveloperDay wrote: > So if I understand completely its so its easier to pick up an option and > share as a hyperlink i.e. >

[PATCH] D141509: [include-mapping] Fix parsing of html_book_20190607.zip (https://en.cppreference.com/w/File:html_book_20190607.zip). Skip entries that have been added to the index (C++20 symbols), bu

kadircet added inline comments. Comment at: clang/tools/include-mapping/cppreference_parser.py:145 path = os.path.join(root_dir, symbol_page_path) - results.append((symbol_name, + if os.path.isfile(path): +results.append((symbol_name,

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos added a comment. In D128440#4047535 , @pmatos wrote: > @aaron.ballman Added support for externref mangling in Microsoft. This > follows the pattern implemented by OpenCL types. Wrong revision - sorry. Repository: rG LLVM Github Monorepo

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

erichkeane added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2481 + case BuiltinType::Id: \ +Out << "PA"; \ +mangleArtificialTagType(TTK_Struct,

[PATCH] D140860: [Diagnostics][NFC] Fix -Wlogical-op-parentheses warning inconsistency for const and constexpr values

hazohelet added a comment. In D140860#4047534 , @aaron.ballman wrote: > In D140860#4045224 , @dblaikie > wrote: > >> In D140860#4044937 , >> @aaron.ballman wrote: >>

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo updated this revision to Diff 488659. VitaNuo added a comment. Mention symbol name in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141611/new/ https://reviews.llvm.org/D141611 Files:

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107 + which is no longer in use. The option will be fully removed in + :program:`clang-tidy-18`. + But isn't such naming artifact of packaging? May be

[clang] 278d6f0 - [Clang] Clean up some offloading driver tests

Author: Joseph Huber Date: 2023-01-12T07:54:55-06:00 New Revision: 278d6f065a63930d33d10785ec3de03ce6c3bc3c URL: https://github.com/llvm/llvm-project/commit/278d6f065a63930d33d10785ec3de03ce6c3bc3c DIFF: https://github.com/llvm/llvm-project/commit/278d6f065a63930d33d10785ec3de03ce6c3bc3c.diff

[PATCH] D141546: [clang] Reland parenthesized aggregate init patches

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, mostly based on the previous review. I have not noticed any significant changes, so have not looked too cautiously. Let me know if there are any particular places that you

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 488645. pmatos added a comment. @aaron.ballman Added support for externref mangling in Microsoft. This follows the pattern implemented by OpenCL types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

VitaNuo created this revision. Herald added a subscriber: arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141611 Files:

[clang] ed00101 - [include-mapping] Print an error message in case the symbol index points to a non-existent page.

Author: Viktoriia Bakalova Date: 2023-01-12T15:59:32Z New Revision: ed001018a02b3d8da699317cad7f7727d126f01d URL: https://github.com/llvm/llvm-project/commit/ed001018a02b3d8da699317cad7f7727d126f01d DIFF: https://github.com/llvm/llvm-project/commit/ed001018a02b3d8da699317cad7f7727d126f01d.diff

[PATCH] D141611: [include-mapping] Print an error message in case the symbol index points to a non-existent page.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed001018a02b: [include-mapping] Print an error message in case the symbol index points to a… (authored by VitaNuo). Repository: rG LLVM Github

[clang] a013839 - [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

Author: Shafik Yaghmour Date: 2023-01-12T08:04:04-08:00 New Revision: a0138390dd2ac2130c9f76e6778d6e45e4dc5526 URL: https://github.com/llvm/llvm-project/commit/a0138390dd2ac2130c9f76e6778d6e45e4dc5526 DIFF:

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0138390dd2a: [Clang] Diagnose undefined behavior in a constant expression while evaluating a… (authored by shafik). Herald added a project: clang.

[clang] 77c5eac - [LinkerWrapper] Fix errors from missing files during a dry run

Author: Joseph Huber Date: 2023-01-12T10:49:27-06:00 New Revision: 77c5eac2aa9b9b1a12850295abf84d51f87745de URL: https://github.com/llvm/llvm-project/commit/77c5eac2aa9b9b1a12850295abf84d51f87745de DIFF: https://github.com/llvm/llvm-project/commit/77c5eac2aa9b9b1a12850295abf84d51f87745de.diff

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl. Herald added subscribers: kosarev, jdoerfert, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This was missing important environment context, like

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 488686. tblah added a comment. Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Updated to construct StackArrays as a ModuleOp pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138446: [clang-format][docs] Add ability to link to specific config options

aaron.ballman accepted this revision. aaron.ballman added a comment. In D138446#3942006 , @rymiel wrote: > I consulted a little bit with a friend who has a little bit of experience > with sphinx and they suggested making a simple custom extension for

[PATCH] D140809: [clang][Interp] Implement logical and/or operators

aaron.ballman accepted this revision. aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:376 +this->emitLabel(LabelTrue); +this->emitConstBool(true, E); +this->fallthrough(LabelEnd); tbaeder wrote: >

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488648. pmatos added a comment. Now under the correct revision: @aaron.ballman Added support for externref mangling in Microsoft. This follows the pattern implemented by OpenCL types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng updated this revision to Diff 488656. kito-cheng added a comment. Changes: - Address Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140693/new/ https://reviews.llvm.org/D140693 Files: clang/docs/ReleaseNotes.rst

[PATCH] D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option

carlosgalvezp updated this revision to Diff 488663. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Fix name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141583/new/ https://reviews.llvm.org/D141583 Files:

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

fdeazeve updated this revision to Diff 488611. fdeazeve added a comment. Address review comments: - Remove unncesarry `const` qualifier from function declaration. - Add an item in Clang's release notes. I surveyed Clang's release notes in all major releases from 12.0 and couldn't find anything

[PATCH] D141206: [clang] [MinGW] Avoid adding /include and /lib when cross compiling

mstorsjo added inline comments. Comment at: clang/test/Driver/mingw-sysroot.cpp:25-38 // RUN: env "PATH=%T/testroot-gcc/bin:%PATH%" %clang -target x86_64-w64-mingw32 -rtlib=platform -stdlib=libstdc++ --sysroot="" -c -### %s 2>&1 | FileCheck -check-prefix=CHECK_TESTROOT_GCC %s

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 488634. pmatos marked an inline comment as done. pmatos added a comment. Address all comments except a couple of issues related to ABI and mangling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman added a subscriber: rnk. aaron.ballman added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:2479-2483 +#define WASM_REF_TYPE(InternalName, MangledName, Id, SingletonId, AS) \ + case BuiltinType::Id:

[PATCH] D141543: [LinkerWrapper] Emit assembly files from LTO with `save-temps`

jhuber6 updated this revision to Diff 488679. jhuber6 added a comment. Fix test, should be good to go now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141543/new/ https://reviews.llvm.org/D141543 Files: clang/test/Driver/linker-wrapper.c

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

li.zhe.hua updated this revision to Diff 488780. li.zhe.hua added a comment. Try this again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141634/new/ https://reviews.llvm.org/D141634 Files:

[clang] 439ba4c - [LinkerWrapper] Improve -save-temps behaviour

Author: Joseph Huber Date: 2023-01-12T16:43:30-06:00 New Revision: 439ba4c9026db6ab4c0a06737638ac42ebc445fd URL: https://github.com/llvm/llvm-project/commit/439ba4c9026db6ab4c0a06737638ac42ebc445fd DIFF: https://github.com/llvm/llvm-project/commit/439ba4c9026db6ab4c0a06737638ac42ebc445fd.diff

[clang] 7d0cdbf - [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

Author: Eric Li Date: 2023-01-12T17:44:29-05:00 New Revision: 7d0cdbf69edf5b14101d9c11fe9ca4cf5228e81d URL: https://github.com/llvm/llvm-project/commit/7d0cdbf69edf5b14101d9c11fe9ca4cf5228e81d DIFF: https://github.com/llvm/llvm-project/commit/7d0cdbf69edf5b14101d9c11fe9ca4cf5228e81d.diff LOG:

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d0cdbf69edf: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit` (authored by li.zhe.hua). Repository: rG LLVM Github

[PATCH] D141555: [CUDA] added cmath wrappers to unbreak CUDA compilation after D79555

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. LGTM. Do we need changes to the test-suite to cover this too? (test-suite being in a separate repo, so it would be a separate patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D135488#4049035 , @paulkirth wrote: > Actually if we add > > if (!isFunctionInPrintList(MF.getName())) >return false; > > we can filter by name Does name mangling

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. In D135488#4049050 , @nickdesaulniers wrote: > In D135488#4049035 , @paulkirth > wrote: > >> Actually if we add >> >> if (!isFunctionInPrintList(MF.getName())) >>return

[PATCH] D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check.

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan, mgehre. Herald added a reviewer: njames93. Herald added projects: clang-tools-extra, All. This review seems to be stuck/dead,

[PATCH] D96223: [clang-tidy] Simplify static assert check

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Herald added subscribers: carlosgalvezp, StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7910ee7d8c6d: [clang-tidy] dont warn when returning the result for bugprone-standalone-empty (authored by v1nh1shungry, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 7910ee7 - [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

Author: v1nh1shungry Date: 2023-01-13T01:14:51Z New Revision: 7910ee7d8c6dcb679200ba171fba5d8d5f237007 URL: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007 DIFF: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007.diff LOG:

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140686: [Clang][RISCV] Update operand order for vmerge and vcompress

This revision was automatically updated to reflect the committed changes. Closed by commit rG2532aa57665a: [Clang][RISCV] Update operand order for vmerge and vcompress (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a reviewer: NoQ. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM

[PATCH] D97204: [RFC] Clang 64-bit source locations

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added subscribers: steakhal, StephenFan. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to

[PATCH] D121629: clang: also check alloc_alignment claims in return

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. This review may be stuck/dead, consider abandoning if no longer relevant. Removing myself as reviewer in attempt to clean dashboard. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D43153: [clang] Implement P0692 "Access Checking on Specializations"

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. This review seems to be stuck/dead, consider abandoning if no longer relevant. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D141575: [WIP][3/N][Clang][RISCV][NFC] Clarify edge cases of RVVIntrinsic::getSupportedMaskedPolicies for clarity

eopXD updated this revision to Diff 488824. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141575/new/ https://reviews.llvm.org/D141575 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index:

[PATCH] D141577: [WIP][4/N][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

eopXD updated this revision to Diff 488826. eopXD added a comment. Bump CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141577/new/ https://reviews.llvm.org/D141577 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp Index:

[clang] 485ba40 - [clang][test] Remove unnecessary 'REQUIRES'

Author: Ben Shi Date: 2023-01-13T10:04:22+08:00 New Revision: 485ba407a6a903b2443a8b6b7912de234cc60ffd URL: https://github.com/llvm/llvm-project/commit/485ba407a6a903b2443a8b6b7912de234cc60ffd DIFF: https://github.com/llvm/llvm-project/commit/485ba407a6a903b2443a8b6b7912de234cc60ffd.diff LOG:

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG485ba407a6a9: [clang][test] Remove unnecessary REQUIRES (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 488842. paulkirth marked 5 inline comments as done. paulkirth retitled this revision from "[codegen] Add a remarks based Stack Layout Analysis pass" to "[codegen] Add StackFrameLayoutAnalysisPass". paulkirth edited the summary of this revision. paulkirth

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth added a comment. In D135488#4049075 , @thegameg wrote: > I would rather have a more generic mechanism for remarks or diagnostics in > general. Even if it uses `isFunctionInPrintList`, I'd rather have a real flag > that doesn't require

[PATCH] D141636: [libTooling] Rename `getRangeForEdit` as `getFileRangeForEdit`

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With the addition of `getFileRange`, we rename `getRangeForEdit` as

[PATCH] D141634: [libTooling] Add `getFileRange` as an alternative to `getRangeForEdit`

li.zhe.hua updated this revision to Diff 488779. li.zhe.hua added a comment. Upload correct commit this time... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141634/new/ https://reviews.llvm.org/D141634 Files:

[PATCH] D141620: clang/OpenCL: Make enqueued blocks inherit the parent attributes

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12488 + // FIXME: The invoke isn't applying the right attributes either + llvm::AttrBuilder KernelAttrs(C, CGF.CurFn->getAttributes().getFnAttrs()); + KernelAttrs.addAttribute("enqueued-block");

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:60 +// Checks if T1 is convertible to T2. +static bool isMultiLevelConvertiblePointer(QualType P1, QualType P2, + unsigned CurrentLevel

  1   2   3   4   >