[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD updated this revision to Diff 497223. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 Files: clang/include/clang/Basic/RISCVVTypes.def

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

eopXD updated this revision to Diff 497224. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143665/new/ https://reviews.llvm.org/D143665 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaRISCVVectorLookup.cpp

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:91 set(WINDOWS_LINK_FLAGS -/vfsoverlay:${LLVM_VFSOVERLAY} -# TODO: On Windows, linker is

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:85 +Hints isPublicHeader(const FileEntry *FE, const PragmaIncludes *PI) { + return

[clang] 46cdf7f - [Tooling][Stdlib][NFC] Reflow comments and strip clang-format pragmas

Author: Kadir Cetinkaya Date: 2023-02-14T09:46:41+01:00 New Revision: 46cdf7f0991280a3601a777a80fbc460196fb033 URL: https://github.com/llvm/llvm-project/commit/46cdf7f0991280a3601a777a80fbc460196fb033 DIFF:

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein updated this revision to Diff 497233. hokein marked 2 inline comments as done. hokein added a comment. handle the case where PI is null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143906/new/ https://reviews.llvm.org/D143906 Files:

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

hokein marked an inline comment as done. hokein added a comment. Thanks for the review! Comment at: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp:85 +Hints isPublicHeader(const FileEntry *FE, const PragmaIncludes *PI) { + return (PI->isPrivate(FE) ||

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

sdesmalen added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:332 + # Generate arm_sme.h + clang_generate_header(-gen-arm-sme-header arm_sme.td arm_sme.h) # Generate arm_bf16.h bryanpkc wrote: > bryanpkc wrote: > > sdesmalen wrote: > > > The

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

carlosgalvezp added a comment. @donat.nagy Are you available to push the commit yourself? Otherwise I can help you with that, please let me know your name and email (must match those on your Github account) for attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1ba93c3 - [Modules] Don't re-generate template specialization in the importer

Author: Chuanqi Xu Date: 2023-02-14T17:15:33+08:00 New Revision: 1ba93c3c30dcdf2659e3020ba462e0025187d8e1 URL: https://github.com/llvm/llvm-project/commit/1ba93c3c30dcdf2659e3020ba462e0025187d8e1 DIFF: https://github.com/llvm/llvm-project/commit/1ba93c3c30dcdf2659e3020ba462e0025187d8e1.diff

[PATCH] D142893: [NFC] Class for building MultilibSet

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Driver/MultilibBuilder.h:117 + /// Add an optional Multilib segment + MultilibSetBuilder (const MultilibBuilder ); +

[clang-tools-extra] 504aa8a - [include-cleaner] Better support ambiguous std symbols

Author: Haojian Wu Date: 2023-02-14T10:18:38+01:00 New Revision: 504aa8ae941ea8e09b89a91cfbbbeb8a7b8fdc24 URL: https://github.com/llvm/llvm-project/commit/504aa8ae941ea8e09b89a91cfbbbeb8a7b8fdc24 DIFF: https://github.com/llvm/llvm-project/commit/504aa8ae941ea8e09b89a91cfbbbeb8a7b8fdc24.diff

[PATCH] D143906: [include-cleaner] Better support ambiguous std symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG504aa8ae941e: [include-cleaner] Better support ambiguous std symbols (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 64dad4b - Use llvm::bit_cast (NFC)

Author: Kazu Hirata Date: 2023-02-14T01:22:12-08:00 New Revision: 64dad4ba9af603330458a7673e39a873afdf3d4d URL: https://github.com/llvm/llvm-project/commit/64dad4ba9af603330458a7673e39a873afdf3d4d DIFF: https://github.com/llvm/llvm-project/commit/64dad4ba9af603330458a7673e39a873afdf3d4d.diff

[PATCH] D143989: [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags

CarolineConcatto created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang feature flag names for: AEK_SMEF6 to

[PATCH] D142932: [NFC] Multilib YAML parsing

phosek added a comment. For the existing YAML files within LLVM, we most commonly used the `PascalCase` for field names and less commonly `lisp-case`. This change uses `camelCase` which is unusual and unless there's a particular reason for using this scheme such as compatibility with an

[clang] 6240627 - [docs] Fix bullet list formatting

Author: KAWASHIMA Takahiro Date: 2023-02-14T19:14:03+09:00 New Revision: 6240627cfda444550975ccaea20a3b6d68c9ad15 URL: https://github.com/llvm/llvm-project/commit/6240627cfda444550975ccaea20a3b6d68c9ad15 DIFF:

[clang] e8d4484 - [docs] Update the ACLE URL

Author: KAWASHIMA Takahiro Date: 2023-02-14T19:14:04+09:00 New Revision: e8d44841c5d5f1e7ca2013ab2ae23bb4cec45d1e URL: https://github.com/llvm/llvm-project/commit/e8d44841c5d5f1e7ca2013ab2ae23bb4cec45d1e DIFF:

[PATCH] D142473: [UTC] Add --version argument

nikic added a comment. Sorry, I did not interpret those comments as blocking concerns. Happy to revert this if they were intended as such -- this is effectively an NFC patch until DEFAULT_VERSION gets bumped, so we can still backtrack to a different approach (though I'm not aware of any that

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

nikic added a comment. It looks like this causes a minor compile-time regression (about 0.2% on `O0` builds): http://llvm-compile-time-tracker.com/compare.php?from=ad81d019a62d33e5d1f232844b83d3e164e4b160=6470706bc0ed2425704bc8c9e121a72e2d272616=instructions:u I wanted to check whether this is

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2836 + Tok = Tok->getNextNonComment(); + } else if (Tok->is(tok::hashhash)) { +// Concatenation. Skip. are we covering these cases in the unit tests

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143755/new/ https://reviews.llvm.org/D143755 ___ cfe-commits mailing

[PATCH] D143630: [clang] update test case

tbaeder added a comment. Added Nikita as reviewer, since this is about opaque pointers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143630/new/ https://reviews.llvm.org/D143630 ___ cfe-commits

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

bjosv created this revision. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. bjosv requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Remove mention of a

[PATCH] D143630: [clang] update test case

nikic added a comment. Hm, I don't think the clang/test/CodeGen/X86/x86-builtins-intrinsic.cl file exists on current main? Is this based on top of some other patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143630/new/

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

bipmis added a comment. Herald added a subscriber: StephenFan. @fhahn We are also observing scenarios where this maybe necessary. A couple of points on where it may be missing 1. createScalarTypeNode(OutName, AnyPtr, Size) -> This will generate different Base type. However the accessTy being

[PATCH] D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message

donat.nagy added a comment. Thanks for the feedback! I can push the commit and I'll do so after a few days (if no changes are suggested). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143917/new/ https://reviews.llvm.org/D143917

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 497276. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Context.h

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1560 + // is the furthest we might go up in the hierarchy. + ThisPtr = ThisPtr.getDeclPtr(); +} I think this test case was from the function pointer review, but this fixes:

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4125098 , @vedgy wrote: >> `uint32_t Size; // = sizeof(struct CIndexOptions), used for option >> versioning` > > 1. `uint32_t` was introduced in C99. Can/should it be used in //Index.h//? > Only built-in

[clang] 463fa25 - [clang][NFC] Adjust tests to not un/define predefined macros

Author: John Brawn Date: 2023-02-14T13:55:03Z New Revision: 463fa25c34d6e569862a9b74b24db3aa5522d84b URL: https://github.com/llvm/llvm-project/commit/463fa25c34d6e569862a9b74b24db3aa5522d84b DIFF: https://github.com/llvm/llvm-project/commit/463fa25c34d6e569862a9b74b24db3aa5522d84b.diff LOG:

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 497293. VincentWu added a comment. Herald added subscribers: luke, emaste. update to v1.0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files:

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

donat.nagy added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:44-45 +return BinOp->getOpcode() == BO_Assign && + BinOp->getRHS()->IgnoreParenCasts() == E; + + return isa(ParentE); In

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as attributes code owner. Comment at: clang/lib/AST/ASTContext.cpp:2154 + if (uint64_t Result = SubstTypeVisitor(Ctx, SubType->getReplacementType()) +

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added subscribers: jhuber6, aaronmondal. aaronmondal added a comment. Would it be possible to backport this to Clang 16? If https://github.com/RadeonOpenCompute/ROCm-Device-Libs/commit/8dc779e19cbf2ccfd3307b60f7db57cf4203a5be makes it into ROCm 5.5 no distro would be able to build

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

erichkeane added a comment. In D143891#4122731 , @aaron.ballman wrote: > In D143891#4122668 , @royjacobson > wrote: > >> In D143891#4122660 , >> @aaron.ballman wrote:

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. @reames Thank you for fixing documentation, missed this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

erichkeane added a comment. In D143891#4125954 , @erichkeane wrote: > In D143891#4122731 , @aaron.ballman > wrote: > >> In D143891#4122668 , @royjacobson >> wrote: >>

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz updated this revision to Diff 497309. rmaz added a comment. remove `header_file_size()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson abandoned this revision. probinson added a comment. Discussion on the GCC bug has persuaded me this is not a good idea. I'll solve my user's problem a different way. @MaskRay you can close the GCC bug, it looks like I can't do it myself. CHANGES SINCE LAST ACTION

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

asb added a comment. Thanks Philip. I started looking at this too, and agree that something like this is a good next step. I've been looking more closely at the GCC behaviour and noticed a couple of things that might be of interest: - `-march=rv64gc` results

[PATCH] D144011: [clang]Fix warning for signed conversion

yaxunl created this revision. yaxunl added reviewers: tra, rsmith, MaskRay, rtrieu. Herald added a project: All. yaxunl requested review of this revision. Currently clang emits warning with -Wconversion for the following code: long foo(long x) { return 1LL

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal updated this revision to Diff 497317. Ayal added a comment. Use `-verify=expected,ocl12` instead of #ifdef'ing the test to check diagnostics emitted for 1.2 but not emitted for 2.0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143849/new/ https://reviews.llvm.org/D143849 Files:

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal added inline comments. Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:90 +#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2 typedef struct FooImage2D // expected-note{{within field of type 'FooImage2D' declared here}} yaxunl wrote: > Ayal

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2154 + if (uint64_t Result = SubstTypeVisitor(Ctx, SubType->getReplacementType()) +.TryEval(Attr->getAlignmentExpr())) { +TI.Align = Result; aaron.ballman

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

Eugene.Zelenko requested changes to this revision. Eugene.Zelenko added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst:35 -Variables: ``a``, ``c``,

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve updated this revision to Diff 497321. fdeazeve added a comment. Added verifier test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143921/new/ https://reviews.llvm.org/D143921 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D143921: [debug-info][codegen] Prevent creation of self-referential SP node

fdeazeve added a comment. In D143921#4124533 , @aprantl wrote: > In D143921#4123218 , @fdeazeve > wrote: > >> Any testing suggestions here? I can use what we have on GH (cpp -> codegen >> test), but I'm not

[PATCH] D143430: [C2x] Implement the `unreachable` macro for WG14 N2826

erichkeane added inline comments. Comment at: clang/lib/Headers/stddef.h:108 +__STDC_VERSION__ >= 202000L +#define unreachable() __builtin_unreachable() +#endif /* defined(__need_STDDEF_H_misc) && >= C23 */ Is this REALLY required to be a macro by standard?

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

yaxunl added a comment. In D143495#4123119 , @pvellien wrote: > @yaxunl Could you please commit this change on my behalf? I don't have a > write access to the trunk. > Thank you sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

erichkeane added a comment. On the fence about the diagnostic at all, but definitely should not be doing string magic to make it quoted. Otherwise this is a LGTM. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5620 +std::string Spelling = "'" +

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 2 inline comments as done. pmatos added a comment. @aaron.ballman I have finished addressing all the concerns on this patch. Do you have any further comments? Comment at: clang/lib/Sema/SemaType.cpp:7289-7290 + QualType Pointee = Type->getPointeeType(); +

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:95 +QualType ArgT, BasicValueFactory , +

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497328. reames edited the summary of this revision. reames added a comment. Add docs, and rework description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files:

[PATCH] D144015: [OpenMP]Fix PR55970: Miscompile of collapse(3) with non-rectangular loop nest.

ABataev created this revision. ABataev added a reviewer: mikerice. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ABataev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: openmp-commits, sstefan1. Herald added projects:

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497336. reames added a comment. Address @jrtc27's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. You still have clang-format issues in your patch. Can you update that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140795/new/ https://reviews.llvm.org/D140795 ___ cfe-commits mailing list

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. We seem to have rough consensus here, but I'm going to wait roughly 24 hours before landing to give others time to comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

ahatanak created this revision. ahatanak added reviewers: arphaman, fahad, aaron.ballman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. The assertion fails when the expression causing the this pointer to be captured is part of a

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:135 +def CM_JT : RVInst16CJ<0b101, 0b10, (outs), (ins uimm5:$index), + "cm.jt", "$index">{ + bits<5> index; Indent 1 more space Repository: rG

[PATCH] D143142: [clang][lex] Enable Lexer to grow its buffer

v.g.vassilev added a comment. We should probably add some tests here. Alternatively we can add the tests from https://reviews.llvm.org/D143148 but that'd make this patch bulkier and probably harder to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142569: [OpenMP] Introduce kernel environment

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3888 + + Function *Kernel = Builder.GetInsertBlock()->getParent(); Function *Fn = getOrCreateRuntimeFunctionPtr( That is not the kernel, at least not when clang emits a

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127421 , @b-sumner wrote: > I have no objection to backporting this, but it may need to be accompanied > with a device-libs patch, and I don't know where that patch would be checked > in. The ROCm-Device-Libs in

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:64-66 +/// Dependency scanner callbacks that are used during scanning to influence the +/// behaviour of the scan - for example, to customize the scanned

[PATCH] D144037: [clang-tidy] allow tests to use -config-file instead of -config

ClockMan added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:111 if not any( -[arg.startswith('-config=') for arg in self.clang_tidy_extra_args]): +[arg.startswith('-config=') or arg.startswith('-config-file=') for arg

[libunwind] 33d0d1e - [runtimes] Rename newconfig.py to config.py -- it's not new anymore

Author: Louis Dionne Date: 2023-02-14T17:21:34-05:00 New Revision: 33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9 URL: https://github.com/llvm/llvm-project/commit/33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9 DIFF: https://github.com/llvm/llvm-project/commit/33d0d1e36ffac3ff7fb29e5f8e34a6b6957ad8e9.diff

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/60722. Repository: rG LLVM Github Monorepo

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

shafik added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1023 Partition = All.take_while([&](const Token ) { - return T.getLocation() >= BeginLoc && T.getLocation() < Limit && - NearLast(T.getLocation()); + // NOTE: the Limit is included!

[clang] aef76fe - [clang-format][NFC] Reformat clang/tools/clang-format/fuzzer/

Author: Owen Pan Date: 2023-02-14T18:58:01-08:00 New Revision: aef76fe554ee9426b8915e67ae50cecb8dba2e0e URL: https://github.com/llvm/llvm-project/commit/aef76fe554ee9426b8915e67ae50cecb8dba2e0e DIFF: https://github.com/llvm/llvm-project/commit/aef76fe554ee9426b8915e67ae50cecb8dba2e0e.diff

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

Esme added a comment. Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. +

[clang] 54cf24d - [NFC] Refactor ModuleDeclStateTest to make it not dependent on Frontend

Author: Chuanqi Xu Date: 2023-02-15T11:30:18+08:00 New Revision: 54cf24dc6e6317f7a77f8a320f1fbccc31ea7291 URL: https://github.com/llvm/llvm-project/commit/54cf24dc6e6317f7a77f8a320f1fbccc31ea7291 DIFF: https://github.com/llvm/llvm-project/commit/54cf24dc6e6317f7a77f8a320f1fbccc31ea7291.diff

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

ChuanqiXu added inline comments. Comment at: clang/unittests/Lex/CMakeLists.txt:21 clangBasic + clangFrontend clangLex ChuanqiXu wrote: > thakis wrote: > > It seems strange layering-wise that the Lex unit tests would depend on > > Frontend. Is there any

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127275 , @aaronmondal wrote: >> I cannot say there was much choice. The only real choice was to postpone the >> split and magnify the problem in the future. As for the ifdefs, this might >> be possible in the

[PATCH] D142507: [AMDGPU] Split dot7 feature

rampitec added a comment. In D142507#4127374 , @aaronmondal wrote: > I think unless conflicts arise creating an issue similar to this > https://github.com/llvm/llvm-project/issues/60600 with the `cherry-pick` line > set to this commit should be

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added a comment. Yeah sorry about that, I reverted it here: b5f239363a3 Revert "[NFC][IR] Make Module::getGlobalList() private" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[clang] 8704674 - [Driver] Allow test to use lld-link.exe not just lld-link

Author: Alex Brachet Date: 2023-02-14T23:54:25Z New Revision: 87046744e6a8f7b78dffb61c29cbac1e0abd6921 URL: https://github.com/llvm/llvm-project/commit/87046744e6a8f7b78dffb61c29cbac1e0abd6921 DIFF: https://github.com/llvm/llvm-project/commit/87046744e6a8f7b78dffb61c29cbac1e0abd6921.diff LOG:

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, akyrtzi, steven_wu. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The idea is to split the callbacks that are used to

[clang] 82c6e90 - [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool substitutions list

Author: Weining Lu Date: 2023-02-15T09:16:14+08:00 New Revision: 82c6e90d6a3d6773372b845a246adfed1682cb65 URL: https://github.com/llvm/llvm-project/commit/82c6e90d6a3d6773372b845a246adfed1682cb65 DIFF: https://github.com/llvm/llvm-project/commit/82c6e90d6a3d6773372b845a246adfed1682cb65.diff

[PATCH] D143665: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e794ba0b238: [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis (authored by eopXD). Repository: rG LLVM Github Monorepo

[clang] 6e794ba - [Clang][RISCV] Guard vector int64, float32, float64 with semantic analysis

Author: eopXD Date: 2023-02-14T17:38:25-08:00 New Revision: 6e794ba0b238832611e649c826b204e680a81e98 URL: https://github.com/llvm/llvm-project/commit/6e794ba0b238832611e649c826b204e680a81e98 DIFF: https://github.com/llvm/llvm-project/commit/6e794ba0b238832611e649c826b204e680a81e98.diff LOG:

[clang] 8d995b2 - [C++20] [Modules] [ClangScanDeps] Ensure that we can mix the use of and clang modules

Author: Chuanqi Xu Date: 2023-02-15T11:00:03+08:00 New Revision: 8d995b26c7559f273809d0d29e5042850e47165a URL: https://github.com/llvm/llvm-project/commit/8d995b26c7559f273809d0d29e5042850e47165a DIFF: https://github.com/llvm/llvm-project/commit/8d995b26c7559f273809d0d29e5042850e47165a.diff

[clang] cb5f239 - Revert "[NFC][IR] Make Module::getGlobalList() private"

Author: Vasileios Porpodas Date: 2023-02-14T14:29:42-08:00 New Revision: cb5f239363a3c94db5425c105fcd45e77d2a16a9 URL: https://github.com/llvm/llvm-project/commit/cb5f239363a3c94db5425c105fcd45e77d2a16a9 DIFF:

[clang] 823186b - Recommit: [NFC][IR] Make Module::getGlobalList() private

Author: Vasileios Porpodas Date: 2023-02-14T15:12:51-08:00 New Revision: 823186b14dc97c950a808f6f4b434d399da9a220 URL: https://github.com/llvm/llvm-project/commit/823186b14dc97c950a808f6f4b434d399da9a220 DIFF:

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

fmayer added a comment. This seems to have broken our buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/16797/steps/8/logs/stdio CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /b/sanitizer-x86_64-linux-qemu/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein added inline comments. Comment at: clang/test/Lexer/update_consecutive_macro_crash.cpp:8 +void foo() { + X(int{,}); // expected-error {{too many arguments provided to function-like macro invocation}} \ + expected-error {{expected expression}} \

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:64-66 +/// Dependency scanner callbacks that are used during scanning to influence the +/// behaviour of the scan - for example, to customize the scanned

[PATCH] D143806: [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool substitutions list

This revision was automatically updated to reflect the committed changes. Closed by commit rG82c6e90d6a3d: [Clang][Test] Add llvm-lto, llvm-lto2 and llvm-profdata to the tool… (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

ChuanqiXu added a comment. In D137526#4125578 , @nikic wrote: > It looks like this causes a minor compile-time regression (about 0.2% on `O0` > builds): >

[PATCH] D144064: [WIP][-Wunsafe-buffer-usage] Match unsafe pointers being casted to bool or participating in pointer subtractions

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, malavikasamak, t-rasmud. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To add two new unique cases to the

[clang] ac835ec - [Fuchsia] Set /winsysroot in Windows runtimes linker flags

Author: Haowei Wu Date: 2023-02-14T13:31:48-08:00 New Revision: ac835ecb5feacdbf3fd9fcfc72fd2972067c26b4 URL: https://github.com/llvm/llvm-project/commit/ac835ecb5feacdbf3fd9fcfc72fd2972067c26b4 DIFF: https://github.com/llvm/llvm-project/commit/ac835ecb5feacdbf3fd9fcfc72fd2972067c26b4.diff

[PATCH] D143960: [Fuchsia] Set /winsysroot in windows runtimes linker flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac835ecb5fea: [Fuchsia] Set /winsysroot in Windows runtimes linker flags (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142507: [AMDGPU] Split dot7 feature

aaronmondal added a comment. Well, I can already feel the pain that distro maintainers having to build the next ROCm releases  I wonder what the better course of action is here: 1. Port this patch to Clang 16 so that users with new hardware will be able to build ROCm 5.5, but make it

[PATCH] D142507: [AMDGPU] Split dot7 feature

b-sumner added a comment. In D142507#4127382 , @rampitec wrote: > In D142507#4127374 , @aaronmondal > wrote: > >> I think unless conflicts arise creating an issue similar to this >>

[PATCH] D142507: [AMDGPU] Split dot7 feature

b-sumner added a comment. > My current understanding is the c-p will go into already forked clang-16, but > not to rocm 5.4. So rocm device-libs will be accompanied by the older > clang-16 w/o this and stay compatible. Someone building from scratch will use > latest clang-16 and staging

[PATCH] D144016: [Sema] Relax a failing assertion in TransformBlockExpr

ahatanak updated this revision to Diff 497530. ahatanak added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144016/new/ https://reviews.llvm.org/D144016 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 497531. junaire added a comment. Herald added a subscriber: mstorsjo. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

shangwuyao created this revision. shangwuyao added reviewers: jlebar, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp, ThomasRaoux. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private (authored by vporpo). Changed prior to commit:

[clang] ed3e3ee - [NFC][IR] Make Module::getGlobalList() private

Author: Vasileios Porpodas Date: 2023-02-14T14:25:10-08:00 New Revision: ed3e3ee9e30dfbffd2170a770a49b36a7f444916 URL: https://github.com/llvm/llvm-project/commit/ed3e3ee9e30dfbffd2170a770a49b36a7f444916 DIFF:

  1   2   >