[clang] 684955a - [Modules] [doc] Document the problem that we can't include headers before import declarations

Author: Chuanqi Xu Date: 2023-03-17T15:10:37+08:00 New Revision: 684955a2302daacb4136b0247c00f6f95472614b URL: https://github.com/llvm/llvm-project/commit/684955a2302daacb4136b0247c00f6f95472614b DIFF: https://github.com/llvm/llvm-project/commit/684955a2302daacb4136b0247c00f6f95472614b.diff

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains marked 10 inline comments as done. iains added a comment. General comments (at least my opinion). 1. One intention of this patch is to make Implementation Module Units regular (i.e. they should behave the same as any other module unit). So I would tend to avoid changes that make this

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel requested review of this revision. rymiel added a comment. This revision is now accepted and ready to land. Okay, I planned changes because I had more ambitious plans for fixing this, but those didn't work out, so instead I made a separate issue

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! I have just one final nit, then please feel free to merge. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60 +bool

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. > The lookup problems might be considered to be quite a serious bug, and so we > should consider possible back porting and try to avoid making large changes > in theses patches (once that problem is solved, then we can refactor, I > think). I agree it is important

[PATCH] D143704: [flang] Feature list plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde91fd03f72: [flang] Feature list plugin (authored by elmcdonough). Changed prior to commit: https://reviews.llvm.org/D143704?vs=502691=505991#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4a2757d - Make globals used for array initialization codegen constant

Author: Hans Wennborg Date: 2023-03-17T09:23:34+01:00 New Revision: 4a2757d80f0af48e65d90e7eaf268f78bcfa997f URL: https://github.com/llvm/llvm-project/commit/4a2757d80f0af48e65d90e7eaf268f78bcfa997f DIFF: https://github.com/llvm/llvm-project/commit/4a2757d80f0af48e65d90e7eaf268f78bcfa997f.diff

[PATCH] D146211: Make globals used for array initialization codegen constant

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a2757d80f0a: Make globals used for array initialization codegen constant (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146211/new/

[PATCH] D146275: [libclang] Fix documentation; NFC

vedgy added a reviewer: aaron.ballman. vedgy added a comment. Noticed the mistake while reviewing the generated documentation . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jplehr. LGTM. Please wait a day before submission. Move the flang portion to a separate commit. Comment at:

[libunwind] 5d27638 - [libunwind][AArch64] Unbreak building with GNU assembler

Author: Xi Ruoyao Date: 2023-03-17T09:28:20+01:00 New Revision: 5d276380b0b45c3f02ef3c8614c3be95ce1bcb1e URL: https://github.com/llvm/llvm-project/commit/5d276380b0b45c3f02ef3c8614c3be95ce1bcb1e DIFF: https://github.com/llvm/llvm-project/commit/5d276380b0b45c3f02ef3c8614c3be95ce1bcb1e.diff

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah created this revision. tblah added reviewers: jeanPerier, vzakhari, clementval. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers:

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. You have some failed buildbots. Can you revert it if you don't have a quick fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak marked an inline comment as done. dhruvachak added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_hold.cpp:211 +// CHECK-NOUSE-I386: @llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 0, ptr

[PATCH] D146275: [libclang] Fix documentation; NFC

vedgy created this revision. Herald added subscribers: mikhail.ramalho, arphaman. Herald added a project: All. vedgy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes cc929590ad305f0d068709c7c7999f5fc6118dc9

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 506001. zyounan marked an inline comment as done. zyounan added a comment. Add description to shouldPatchPlaceholder0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60 +bool shouldPatchPlaceholder0(CodeCompletionResult::ResultKind ResultKind, + CXCursorKind CursorKind) { nridge wrote: > nit: let's add

[clang-tools-extra] 138adb0 - [clangd] Refine logic on $0 in completion snippets

Author: Younan Zhang Date: 2023-03-17T17:57:24+08:00 New Revision: 138adb0980328d6b958a732d6853d0111aa9cb51 URL: https://github.com/llvm/llvm-project/commit/138adb0980328d6b958a732d6853d0111aa9cb51 DIFF: https://github.com/llvm/llvm-project/commit/138adb0980328d6b958a732d6853d0111aa9cb51.diff

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

This revision was automatically updated to reflect the committed changes. Closed by commit rG138adb098032: [clangd] Refine logic on $0 in completion snippets (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

hans created this revision. hans added reviewers: aaron.ballman, MaskRay. Herald added projects: Flang, All. hans requested review of this revision. Herald added a subscriber: jdoerfert. Herald added a project: clang. in order to provide as much information as possible to the user. The diagnostic

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGd60d3455eb2b: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D143436?vs=505030=506030#toc Repository: rG

[clang] d60d345 - [clangd] Move standard options adaptor to CommandMangler

Author: Dmitry Polukhin Date: 2023-03-17T03:10:36-07:00 New Revision: d60d3455eb2b375d026a4aa74c4ba0c38f5d323c URL: https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c DIFF:

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 505987. dhruvachak added a comment. Fixed clang test OpenMP/target_map_codegen_hold.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 Files:

[clang] a8f6b57 - [PassBuilder] Support O0 in default pipelines

Author: Nikita Popov Date: 2023-03-17T10:00:05+01:00 New Revision: a8f6b5763e89cfeec94d3fcf0f6b70f96b293f7d URL: https://github.com/llvm/llvm-project/commit/a8f6b5763e89cfeec94d3fcf0f6b70f96b293f7d DIFF: https://github.com/llvm/llvm-project/commit/a8f6b5763e89cfeec94d3fcf0f6b70f96b293f7d.diff

[PATCH] D146200: [PassBuilder] Support O0 in default pipelines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8f6b5763e89: [PassBuilder] Support O0 in default pipelines (authored by nikic). Herald added projects: clang, OpenMP, Flang. Herald added

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

bgraur added a comment. What's the resolution here? Can we revert this and continue the discussions independently? We can always re-land this change if the conclusion is that the approach here is the one that we want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146281: [clang-format] Don't wrap struct return types as structs

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using

[clang] c21790d - [NFC] [C++20] [Modules] Tests that the duplicated declarations in GMF

Author: Chuanqi Xu Date: 2023-03-17T15:58:10+08:00 New Revision: c21790d02302ca0c00fab15c49c14db6514ceb5e URL: https://github.com/llvm/llvm-project/commit/c21790d02302ca0c00fab15c49c14db6514ceb5e DIFF: https://github.com/llvm/llvm-project/commit/c21790d02302ca0c00fab15c49c14db6514ceb5e.diff

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

cor3ntin added a comment. Do we need a release note for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 ___ cfe-commits mailing list

[PATCH] D146279: [clangd] Extend CollectMainFileMacros.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Extend the existing

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The noexcept

[PATCH] D143704: [flang] Feature list plugin

DavidSpickett added a comment. Specifically https://lab.llvm.org/buildbot/#/builders/181/builds/15552. Though it is only the sharedlibs build failing, I don't know why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/

[PATCH] D145639: [Coroutines] Fix premature conversion of return object

ilya-biryukov added a comment. I suspect D145641 won't land today in the EU working hours. My suggestion would be to revert this patch and reland together with D145641 . This should be in line with @ChuanqiXu's suggestions to

[clang] 2d91b0d - [libclang] Fix documentation; NFC

Author: Igor Kushnir Date: 2023-03-17T08:40:08-04:00 New Revision: 2d91b0dae0a902317d384a44f588107d04c9ad3c URL: https://github.com/llvm/llvm-project/commit/2d91b0dae0a902317d384a44f588107d04c9ad3c DIFF: https://github.com/llvm/llvm-project/commit/2d91b0dae0a902317d384a44f588107d04c9ad3c.diff

[PATCH] D146275: [libclang] Fix documentation; NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d91b0dae0a9: [libclang] Fix documentation; NFC (authored by vedgy, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:190 +- Improved :doc:`bugprone-use-after-move + ` check to also cover constructor Please keep alphabetical order (by check name) in this section. CHANGES SINCE LAST

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito planned changes to this revision. ManuelJBrito added a comment. Implementing the 128 to 512 casts by filling the rest of the vector with the same definition of a nondeterministic_value is not correct because : a = freeze poison v = is not the same as v = freeze poison The only

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146280/new/ https://reviews.llvm.org/D146280 ___

[clang] 68b3396 - Roll back claims that we implement P0960R3 and P1975R0

Author: Aaron Ballman Date: 2023-03-17T08:01:51-04:00 New Revision: 68b33965239484d0bb1848aaf91b48e132874bb7 URL: https://github.com/llvm/llvm-project/commit/68b33965239484d0bb1848aaf91b48e132874bb7 DIFF: https://github.com/llvm/llvm-project/commit/68b33965239484d0bb1848aaf91b48e132874bb7.diff

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. All comments addressed so bump on review please :) Also, a build has failed but I don't think my changes caused it - it looks like an old version of

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added a comment. Could you add some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146187: [docs] Update the status for coroutines

aaron.ballman added a comment. In D146187#4201910 , @cor3ntin wrote: > In D146187#4201905 , @aaron.ballman > wrote: > >> In D146187#4201223 , @ChuanqiXu >> wrote: >>

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

erichkeane added a comment. In D146140#4201481 , @cor3ntin wrote: > Do we need a release note for this? Yes, good catch! @rymiel : can you please add one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added a comment. Is it possible you need to look only at the immediately preceding field, and not iterate? For example, struct zero_bitfield { char a : 8; char : 0; char b : 8; char c : 8; }; If processing `b` sees the zero-length bitfield and does the needful,

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. In D143704#4202146 , @elmcdonough wrote: > Haven't been able to check this yet, but I think it might be due to the tests > expecting a deterministic output. I've only ever tested on Ubuntu WSL, so > its possible the order

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

thakis added a comment. (if the presubmit is related, maybe some flang test needs updating? Weird that flang uses clang's diags.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146280/new/ https://reviews.llvm.org/D146280

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe495eabd3268: [clang] Include the error message in file reading error diagnostic (authored by hans). Repository: rG LLVM Github Monorepo CHANGES

[clang] e495eab - [clang] Include the error message in file reading error diagnostic

Author: Hans Wennborg Date: 2023-03-17T13:47:02+01:00 New Revision: e495eabd326801c1e00508898dbcb04073a31014 URL: https://github.com/llvm/llvm-project/commit/e495eabd326801c1e00508898dbcb04073a31014 DIFF: https://github.com/llvm/llvm-project/commit/e495eabd326801c1e00508898dbcb04073a31014.diff

[PATCH] D146280: [clang] Include the error message in file reading error diagnostic

hans added a comment. In D146280#4201769 , @thakis wrote: > (if the presubmit is related, maybe some flang test needs updating? Weird > that flang uses clang's diags.) The presubmit errors look unrelated and the flang tests seem fine locally.

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added a comment. Please add a release note as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089 ___ cfe-commits mailing list

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Haven't been able to check this yet, but I think it might be due to the tests expecting a deterministic output. I've only ever tested on Ubuntu WSL, so its possible the order is different on different platforms. I think replacing CHECK-NEXT with CHECK-DAG might

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1696 if (TC.getTriple().isOSAIX()) { + if (Args.hasArg(options::OPT_r)) +break; I think this is redundant, we guard out this whole function call in the block

[PATCH] D146187: [docs] Update the status for coroutines

aaron.ballman added a comment. In D146187#4201223 , @ChuanqiXu wrote: >> but we don't define __cpp_­impl_­coroutine: >> http://eel.is/c++draft/tab:cpp.predefined.ft > > We defined `__cpp_­impl_­coroutine`. And `__cpp_coroutines` is for > Coroutines

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506055. MarcoFalke added a comment. clang-format+doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D146146: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rG62f09d788f9f: [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4200821 , @rsmith wrote: > The approach of attempting to adjust the depth here is not correct, and we > should rip this whole mechanism out and reimplement it. Consider this > closely related testcase: > >

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 506062. 4vtomat added a comment. Resolved Craig and Kito's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

Re: [clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

Thanks for the heads up. Looks like we have a different default C++ standard enabled than what the tests got in my local testing. I’ll revert and make a fix. > On Mar 16, 2023, at 7:53 PM, Voss, Matthew wrote: > > Hi Craig, > > There are some failures on the PS5 buildbot after this change.

Re: [PATCH] D126959: [C++20][Modules] Introduce an implementation module.

Hi Chuanqi > On 17 Mar 2023, at 02:49, Chuanqi Xu via Phabricator > wrote: > > ChuanqiXu added a comment. > > (I don't why I can't send emails in the original mail address. It told me > that your email addressed is not recorded by MX, while I don't know what is > MX. So I tried to reply

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added a comment. In D146101#4195293 , @owenpan wrote: > Please see > https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options. > Is there a way to fix the issue without adding a new option? @owenpan We could

[PATCH] D146187: [docs] Update the status for coroutines

cor3ntin added a comment. In D146187#4201905 , @aaron.ballman wrote: > In D146187#4201223 , @ChuanqiXu > wrote: > >>> but we don't define __cpp_­impl_­coroutine: >>>

[PATCH] D146187: [docs] Update the status for coroutines

aaron.ballman added a comment. In D146187#4201271 , @ChuanqiXu wrote: >> Should we also be updating InitPreprocessor.cpp at the same time, for >> non-Windows targets? > > I didn't address this since we didn't do this before. (Defining feature macro >

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506054. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addresed reviewer comments. Removed flang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1523 + auto bodyCB = [&](InsertPointTy allocaIP, InsertPointTy codeGenIP) { +// DataOp has only one region associated with it. +auto = cast(op).getRegion();

[PATCH] D144878: __builtin_FILE_NAME()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2147e940e8a8: Add __builtin_FILE_NAME() (authored by karapsinie, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D144878?vs=505468=506078#toc Repository: rG LLVM

[clang] 2147e94 - Add __builtin_FILE_NAME()

Author: Ilya Karapsin Date: 2023-03-17T09:52:41-04:00 New Revision: 2147e940e8a8f85f97f28407989c628886b5cd7e URL: https://github.com/llvm/llvm-project/commit/2147e940e8a8f85f97f28407989c628886b5cd7e DIFF: https://github.com/llvm/llvm-project/commit/2147e940e8a8f85f97f28407989c628886b5cd7e.diff

[clang] 482d22d - [clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on MC from clangTesting

Author: Alex Bradbury Date: 2023-03-17T14:45:48Z New Revision: 482d22d05a4a30a4f8594273bd359f7d311c9d4c URL: https://github.com/llvm/llvm-project/commit/482d22d05a4a30a4f8594273bd359f7d311c9d4c DIFF: https://github.com/llvm/llvm-project/commit/482d22d05a4a30a4f8594273bd359f7d311c9d4c.diff

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

PiotrZSL added a comment. I will check this more deeply during weekend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke created this revision. MarcoFalke added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. MarcoFalke requested review of this revision. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 506044. michaelplatings added a comment. fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D146275: [libclang] Fix documentation; NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146275/new/ https://reviews.llvm.org/D146275

[clang] 62f09d7 - [Clang] Stop demoting ElementCount/TypeSize conversion errors to warnings.

Author: Paul Walker Date: 2023-03-17T12:49:45Z New Revision: 62f09d788f9fc540db12f3cfa2f98760071fca96 URL: https://github.com/llvm/llvm-project/commit/62f09d788f9fc540db12f3cfa2f98760071fca96 DIFF: https://github.com/llvm/llvm-project/commit/62f09d788f9fc540db12f3cfa2f98760071fca96.diff LOG:

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:805-807 +/// [C++11] simple-type-specifier braced-init-list [C++11 5.2.3] /// [C++] typename-specifier '(' expression-list[opt] ')' [C++ 5.2.3] +/// [C++11] typename-specifier

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 506081. MarcoFalke added a comment. sort doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +// Add directory to library search path. +Args.AddAllArgs(CmdArgs, options::OPT_L); +ToolChain.AddFilePathLibArgs(Args, CmdArgs); This mostly looks good, but I'm not

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added a comment. In D146089#4202374 , @erichkeane wrote: > To highlight the fix. See the rest of our release notes. 4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 506132. VitaNuo marked 15 inline comments as done. VitaNuo added a comment. Address review comments, simplify test. Take care of main file as provider handling: - provider list [main-file,foo.h] and foo.h \#include'd - not show any providers on hover. -

[PATCH] D146310: [clang-format] Fix dropped 'else' in 398cddf6acec

jaredgrubb created this revision. jaredgrubb added a reviewer: klimek. jaredgrubb added a project: clang-format. Herald added a project: All. jaredgrubb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A patch (398cddf6acec

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

asb added a comment. This broke `-DBUILD_SHARED_LIBS=True` builds - I committed rG482d22d05a4a30a4f8594273bd359f7d311c9d4c to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

aaron.ballman added a comment. Checking: are the libc++ precommit CI failures related to these changes? It's a modules-specific build config, so I figured it's worth double-checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145737/new/

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

aaron.ballman added a comment. In D146041#4198056 , @AryanGodara wrote: > I will try to split this commit, and update on this asap (Sorry for the late > update, I have mid-sem exams going on, I haven't abandoned this issue, still > working on it). No

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 3 inline comments as done. pmatos added a comment. Thanks all for the comments, fixed and will soon land after running a check-all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440

[clang] 807d397 - [clang] Fix two unused variable warnings from if statements. NFC

Author: Craig Topper Date: 2023-03-17T09:18:13-07:00 New Revision: 807d397c751355ae02a89cb5178192752b832203 URL: https://github.com/llvm/llvm-project/commit/807d397c751355ae02a89cb5178192752b832203 DIFF: https://github.com/llvm/llvm-project/commit/807d397c751355ae02a89cb5178192752b832203.diff

[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda

rymiel updated this revision to Diff 506121. rymiel added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146140/new/ https://reviews.llvm.org/D146140 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaConcept.cpp

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. I reverted your patch since the buildbot was failing for couple of hours. Feel free to re-land it when you have a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143704/new/ https://reviews.llvm.org/D143704

[clang] 4361ba7 - Revert "[Coroutines] Fix premature conversion of return object"

Author: Ilya Biryukov Date: 2023-03-17T17:01:43+01:00 New Revision: 4361ba791cd6ab6e41fca4df3fd337da0c116132 URL: https://github.com/llvm/llvm-project/commit/4361ba791cd6ab6e41fca4df3fd337da0c116132 DIFF: https://github.com/llvm/llvm-project/commit/4361ba791cd6ab6e41fca4df3fd337da0c116132.diff

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cd31a7d3087: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to… (authored by agozillon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 506125. Leporacanthicus added a comment. Rebase and fix conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 Files:

[clang] 8d0c889 - [clang][WebAssembly] Initial support for reference type funcref in clang

Author: Paulo Matos Date: 2023-03-17T18:31:44+01:00 New Revision: 8d0c889752121e62e7258570c592b905f544d36f URL: https://github.com/llvm/llvm-project/commit/8d0c889752121e62e7258570c592b905f544d36f DIFF: https://github.com/llvm/llvm-project/commit/8d0c889752121e62e7258570c592b905f544d36f.diff

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d0c88975212: [clang][WebAssembly] Initial support for reference type funcref in clang (authored by pmatos). Changed prior to commit:

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 506141. VitaNuo added a comment. Finish the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. May I please request a final acceptance from both @jhuber6 and @awarzynski before I commit this upstream! If you have no further comments to add or requests of course. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143704: [flang] Feature list plugin

elmcdonough added a comment. Sorry about that. I was trying to look for a fix, and I think it has something to do with these recent changes . I'll have a new revision soon. Repository: rG LLVM Github

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added a comment. In D146089#4202037 , @erichkeane wrote: > Please add a release note as requested. To highlight the fix or highlight the missing warning? Or both? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 506107. dhruvachak marked an inline comment as done. dhruvachak added a comment. Removed attributes (as original) from clang test OpenMP/target_map_codegen_hold.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143704: [flang] Feature list plugin

clementval added a comment. pre-commit ci is showing a different failure: TEST 'Flang :: Examples/feature-list-class.f90' FAILED Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/flang-new -fc1 -load

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should also add a release note for the fix. Comment at: clang/lib/Serialization/ASTReader.cpp:1593 +if (Record[3]) { +

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

erichkeane added a comment. To highlight the fix. See the rest of our release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089 ___ cfe-commits mailing

[clang] 4743c03 - [Docs] Add release notes for D146089.

Author: Craig Topper Date: 2023-03-17T09:03:08-07:00 New Revision: 4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd URL: https://github.com/llvm/llvm-project/commit/4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd DIFF: https://github.com/llvm/llvm-project/commit/4743c03ca8fcb61b8fa4022c38cf93cf55d7f6fd.diff

[clang] 0cd31a7 - [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

Author: Andrew Gozillon Date: 2023-03-17T11:12:16-05:00 New Revision: 0cd31a7d308714d26f49391ac4ea9f6bce5fa324 URL: https://github.com/llvm/llvm-project/commit/0cd31a7d308714d26f49391ac4ea9f6bce5fa324 DIFF:

  1   2   >