[clang] c5301cc - [Clang][NFC] Fix the title of P2361 in the release notes

Author: Corentin Jabot Date: 2023-07-07T16:41:17+02:00 New Revision: c5301cc5ce5edc56ba5ec27bb79ec2b2957d1974 URL: https://github.com/llvm/llvm-project/commit/c5301cc5ce5edc56ba5ec27bb79ec2b2957d1974 DIFF:

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/docs/ReleaseNotes.rst:138 - Implemented `P2738R1: constexpr cast from void* `_. +- Partially implemented `P2361R6: constexpr cast from void* `_. + The changes to

[PATCH] D105759: Implement P2361 Unevaluated string literals

barannikov88 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:138 - Implemented `P2738R1: constexpr cast from void* `_. +- Partially implemented `P2361R6: constexpr cast from void* `_. + The changes to

[clang] d54cad7 - [Clang][NFC] Mark that P2280 was approved as a DR

Author: cor3ntin Date: 2023-07-07T16:36:47+02:00 New Revision: d54cad79857fdb7af7fac4a2718238e5d4c8273b URL: https://github.com/llvm/llvm-project/commit/d54cad79857fdb7af7fac4a2718238e5d4c8273b DIFF: https://github.com/llvm/llvm-project/commit/d54cad79857fdb7af7fac4a2718238e5d4c8273b.diff

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG051cb7c1f57d: [amdgpu] start documenting amdgpu support by clang (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[clang] 051cb7c - [amdgpu] start documenting amdgpu support by clang

Author: Yaxun (Sam) Liu Date: 2023-07-07T10:35:34-04:00 New Revision: 051cb7c1f57dd769ad05a5dc1d734d2ecd46530c URL: https://github.com/llvm/llvm-project/commit/051cb7c1f57dd769ad05a5dc1d734d2ecd46530c DIFF:

[PATCH] D154591: [OpenMP][OMPIRBuilder] Rename IsEmbedded and IsTargetCodegen flags

skatrak updated this revision to Diff 538135. skatrak added a comment. Rebase and fix issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154591/new/ https://reviews.llvm.org/D154591 Files: clang/docs/OffloadingDesign.rst

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25808 +TEST_F(FormatTest, RemoveParentheses) { + FormatStyle Style = getLLVMStyle(); owenpan wrote: > HazardyKnusperkeks wrote: > > Should check for `__attribute((what

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Please wait for other opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154550/new/

[PATCH] D154716: [SemaCXX] Fix bug where unexpanded lambda captures where assumed to be expanded

MitalAshok created this revision. Herald added a project: All. MitalAshok edited the summary of this revision. MitalAshok added reviewers: rsmith, cor3ntin. MitalAshok published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When instantiating the

[PATCH] D154000: HIP: Directly call round builtins

arsenm closed this revision. arsenm added a comment. 9a317516a515f3c5b15f9060329a503e8f261c7f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154000/new/ https://reviews.llvm.org/D154000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 9a31751 - HIP: Directly call round builtins

Author: Matt Arsenault Date: 2023-07-07T09:26:40-04:00 New Revision: 9a317516a515f3c5b15f9060329a503e8f261c7f URL: https://github.com/llvm/llvm-project/commit/9a317516a515f3c5b15f9060329a503e8f261c7f DIFF:

[clang] 9a97e3b - HIP: Directly call ceil builtins

Author: Matt Arsenault Date: 2023-07-07T09:26:07-04:00 New Revision: 9a97e3bf8c3f576b29dfcd76925b6c23b3961b99 URL: https://github.com/llvm/llvm-project/commit/9a97e3bf8c3f576b29dfcd76925b6c23b3961b99 DIFF:

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy added a comment. I looked through most of the open source results, and they look promising. However I've seen one questionable tendency: there are many reports (e.g. this one

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139629/new/ https://reviews.llvm.org/D139629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

Michael137 updated this revision to Diff 538111. Michael137 added a comment. - Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/new/ https://reviews.llvm.org/D154709 Files: clang/include/clang/AST/ASTImportError.h

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 added a comment. Didn't add tests for this since checking the contents of the error message didn't seem worth testing. But don't mind adding tests if reviewers feel more comfortable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 updated this revision to Diff 538110. Michael137 added a comment. - Remove redundant header additions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/new/ https://reviews.llvm.org/D154709 Files:

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 created this revision. Michael137 added reviewers: martong, balazske. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project:

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

uabelho added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue ); sammccall

[PATCH] D154509: [clang][analyzer] StdLibraryFunctionsChecker: Allow NULL buffer in `fread` and `fwrite` if size is zero.

donat.nagy added a comment. By the way here is a concrete example where this patch is needed to squash a false positive:

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

jhuber6 added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:50 +#else + return printGPUsByHSA(); +#endif arsenm wrote: > The HIP path should work on linux too. I generally think we should build as > much code as possible on all hosts, so

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

arsenm added inline comments. Comment at: clang/tools/amdgpu-arch/AMDGPUArch.cpp:50 +#else + return printGPUsByHSA(); +#endif The HIP path should work on linux too. I generally think we should build as much code as possible on all hosts, so how about ```

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue ); uabelho

[clang] 9d5cfed - [dataflow] Remove [[deprecated]] from deprecated functions

Author: Sam McCall Date: 2023-07-07T14:35:29+02:00 New Revision: 9d5cfed2443aa294e67bea694d5aab02c40fa278 URL: https://github.com/llvm/llvm-project/commit/9d5cfed2443aa294e67bea694d5aab02c40fa278 DIFF: https://github.com/llvm/llvm-project/commit/9d5cfed2443aa294e67bea694d5aab02c40fa278.diff

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Need to start somewhere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/ https://reviews.llvm.org/D154133 ___ cfe-commits

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1532 InGroup; +def warn_omp_depend_in_ordered_deprecated : Warning<"denpend clause for ordered is deprecated; use doacross instaed">, InGroup; ABataev wrote:

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1532 InGroup; +def warn_omp_depend_in_ordered_deprecated : Warning<"denpend clause for ordered is deprecated; use doacross instaed">, InGroup; denpend->depend

[PATCH] D154478: [analyzer][NFC] Use unique_ptrs for PathDiagnosticConsumers

steakhal abandoned this revision. steakhal added a comment. Okay, I'm done. It's just a complete mess. I'll come back to this once I have some time, but not now. Here is what I found: Unittests call `AnalysisConsumer->addDiagnosticConsumer()` after the `AnalysisConsumer` is constructed, but

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Conclusion seems to be this should have a separate cast operation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151087/new/

[PATCH] D153954: [WIP][clang][analyzer] Relax alpha.cplusplus.EnumCastOutOfRange checker

donat.nagy added a comment. In D153954#4480296 , @steakhal wrote: > [...] I'd not recommend moving the actual implementation anywhere. I agree, I mostly spoke figuratively, suggesting that this checker could end up in the optin group when it's

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

uabelho added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue ); sammccall

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin marked an inline comment as done. yronglin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng updated this revision to Diff 538094. kito-cheng added a comment. Chagnes: - Update header comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154706/new/ https://reviews.llvm.org/D154706 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/Targets/AMDGPU.cpp:520 +static llvm::StructType *getAMDGPUKernelDescriptorType(llvm::LLVMContext ) { + llvm::Type *Int8 = llvm::IntegerType::getInt8Ty(C); + llvm::Type *Int16 = llvm::IntegerType::getInt16Ty(C);

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng created this revision. kito-cheng added a reviewer: asb. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. Thanks, landed! I have benefited a lot from your comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 ___ cfe-commits mailing

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue ); uabelho

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36f67434f724: [AST] Stop evaluate constant expression if the condition expression which in… (authored by yronglin). Repository: rG LLVM Github

[clang] 36f6743 - [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

Author: yronglin Date: 2023-07-07T19:56:47+08:00 New Revision: 36f67434f724f2cdf36735b243fdaace726afb85 URL: https://github.com/llvm/llvm-project/commit/36f67434f724f2cdf36735b243fdaace726afb85 DIFF: https://github.com/llvm/llvm-project/commit/36f67434f724f2cdf36735b243fdaace726afb85.diff

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1274 if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) -if (StringRef(A->getValue()) == "single") +if (StringRef(A->getValue()) == "single" && Output.isFilename())

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin added a comment. In D154689#4480282 , @Fznamznon wrote: > In D154689#4480249 , @cor3ntin > wrote: > >> I think this makes sense and it implements richard's suggestion. >> However, it's missing a

[clang] d68aae3 - [analyzer][NFC] Simplify CStringChecker strong types

Author: Balazs Benics Date: 2023-07-07T13:48:18+02:00 New Revision: d68aae3ff5d484e0792fdd86d444739edff0b56d URL: https://github.com/llvm/llvm-project/commit/d68aae3ff5d484e0792fdd86d444739edff0b56d DIFF: https://github.com/llvm/llvm-project/commit/d68aae3ff5d484e0792fdd86d444739edff0b56d.diff

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added a comment. In D154495#4479481 , @jdoerfert wrote: > FWIW, I assume we want this also for OpenMP offload. I'd be surprised if OpenMP let you do this by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/

[PATCH] D153954: [WIP][clang][analyzer] Relax alpha.cplusplus.EnumCastOutOfRange checker

steakhal added a comment. In D153954#4480103 , @donat.nagy wrote: > I think the old "report when the value stored in an enum type is not equal to > one of the enumerators" behavior would be useful as an opt-in checker that > could be adopted by some

[PATCH] D153130: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1d7a55a4e06: [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3 (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES

[clang] f1d7a55 - [Clang][AArch64] Implement ACLE feature macro for FEAT_LRCPC3

Author: Lucas Prates Date: 2023-07-07T12:33:34+01:00 New Revision: f1d7a55a4e0627302881957d225342d5b1531675 URL: https://github.com/llvm/llvm-project/commit/f1d7a55a4e0627302881957d225342d5b1531675 DIFF: https://github.com/llvm/llvm-project/commit/f1d7a55a4e0627302881957d225342d5b1531675.diff

[PATCH] D153128: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b7ac6260627: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL1 (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added a comment. In D154689#4480249 , @cor3ntin wrote: > I think this makes sense and it implements richard's suggestion. > However, it's missing a release note, can you add that before landing? > Thanks Thank you for the review. I think I

[clang] 2b7ac62 - [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL1

Author: Lucas Prates Date: 2023-07-07T12:31:55+01:00 New Revision: 2b7ac6260627654def127598e0099938869f765a URL: https://github.com/llvm/llvm-project/commit/2b7ac6260627654def127598e0099938869f765a DIFF: https://github.com/llvm/llvm-project/commit/2b7ac6260627654def127598e0099938869f765a.diff

[PATCH] D105759: Implement P2361 Unevaluated string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95f50964fbf5: Implement P2361 Unevaluated string literals (authored by cor3ntin). Changed prior to commit:

[clang-tools-extra] 95f5096 - Implement P2361 Unevaluated string literals

Author: Corentin Jabot Date: 2023-07-07T13:30:27+02:00 New Revision: 95f50964fbf59dc6394898c0719ce8772cc24d25 URL: https://github.com/llvm/llvm-project/commit/95f50964fbf59dc6394898c0719ce8772cc24d25 DIFF:

[PATCH] D154481: [analyzer] Remove deprecated analyzer-config options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd1f3ad22e4: [analyzer] Remove deprecated analyzer-config options (authored by steakhal). Changed prior to commit:

[clang] 7cd1f3a - [analyzer] Remove deprecated analyzer-config options

Author: Balazs Benics Date: 2023-07-07T13:24:33+02:00 New Revision: 7cd1f3ad22e48924e7061539eb0acb0e0c49eb63 URL: https://github.com/llvm/llvm-project/commit/7cd1f3ad22e48924e7061539eb0acb0e0c49eb63 DIFF: https://github.com/llvm/llvm-project/commit/7cd1f3ad22e48924e7061539eb0acb0e0c49eb63.diff

[PATCH] D105759: Implement P2361 Unevaluated string literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor tweak to the wording on the status page, thank you! Comment at: clang/www/cxx_status.html:118-120 + Clang 17 (Partial) +Attributes

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM. thank you! In D153296#4480243 , @hokein wrote: > In D153296#4480141 , @yronglin >

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I think this makes sense and it implements richard's suggestion. However, it's missing a release note, can you add that before landing? Thanks Repository: rG LLVM Github Monorepo

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein added a comment. In D153296#4480141 , @yronglin wrote: > In D153296#4479718 , @hokein wrote: > >> Thanks, this looks good. > > Thanks for your review! I don't know why the reversion status still `Needs >

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 538073. cor3ntin added a comment. I removed the changes to attributes. Nothing else changes except cxx_status/ReleaseNotes. Unevaluated strings in attributes will be back (in a separate PR) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154701: Overridden CXXMethodDecl::isVirtual() assertion failed before fully imported.

danix800 created this revision. danix800 added a project: clang. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. For non-pure methods with no written `virtual`, `isVirtual()` tries to count size of overridden methods. For

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. In D153296#4479718 , @hokein wrote: > Thanks, this looks good. Thanks for your review! I don't know why the reversion status still `Needs Review`, and the `libcxx ci` often fails to start. Repository: rG LLVM Github

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

zixuan-wu added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:66 return CSR_XLEN_F32_Interrupt_SaveList; return CSR_Interrupt_SaveList; } Here also need adjust for rve. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 538058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/Frontend/verify-any-file.c clang/test/Frontend/verify-fatal.c

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

uabelho added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:532 + void addToFlowCondition(const Formula &); + LLVM_DEPRECATED("Use Formula version instead", "") void addToFlowCondition(BoolValue ); There are

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

wangpc added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:908 static const MCPhysReg CSRegs[] = { RISCV::X1, /* ra */ RISCV::X5, RISCV::X6, RISCV::X7, /* t0-t2 */ zixuan-wu wrote: > Hi, @wangpc

[PATCH] D153954: [WIP][clang][analyzer] Relax alpha.cplusplus.EnumCastOutOfRange checker

donat.nagy added a comment. I think the old "report when the value stored in an enum type is not equal to one of the enumerators" behavior would be useful as an opt-in checker that could be adopted by some projects; while the new "relaxed" version is too bland to be really useful. I'd suggest

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); Fznamznon wrote: > cor3ntin wrote: > > Maybe we should do that now, by

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); cor3ntin wrote: > Maybe we should do that now, by passing `TemplateArgs` to

[PATCH] D154543: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 538047. IncludeGuardian added a comment. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Fix `XCOFFDump.cpp` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154543/new/ https://reviews.llvm.org/D154543 Files:

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

cor3ntin added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); Maybe we should do that now, by passing `TemplateArgs` to computeDependence?

[PATCH] D154696: [Clang] Diagnose jumps into statement expressions

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Such jumps are not allowed by GCC and allowing them can lead to situations where we jumps into unevaluated statements.

[PATCH] D140727: [XRay] Add initial support for loongarch64

xen0n added inline comments. Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:22-25 + RN_T0 = 0xC, + RN_T1 = 0xD, + RN_RA = 0x1, + RN_SP = 0x3, I think people usually just declare the register ABI names with decimal numbers for readability? This is

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

zixuan-wu added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:908 static const MCPhysReg CSRegs[] = { RISCV::X1, /* ra */ RISCV::X5, RISCV::X6, RISCV::X7, /* t0-t2 */ Hi, @wangpc it's hidden bug

[PATCH] D154693: [RISCV] Remote redundant _ta suffix in RVV intrinsics builtins. NFC

eopXD created this revision. eopXD added a reviewer: craig.topper. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D154509: [clang][analyzer] StdLibraryFunctionsChecker: Allow NULL buffer in `fread` and `fwrite` if size is zero.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:413-414 +using ValueConstraint::ValueConstraint; +ArgNo SizeArg1N; +

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

RIscRIpt updated this revision to Diff 538026. RIscRIpt added a comment. Rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134475/new/ https://reviews.llvm.org/D134475 Files: clang/include/clang/Basic/Attr.td

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

RIscRIpt updated this revision to Diff 538025. RIscRIpt added a comment. Rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/ https://reviews.llvm.org/D153914 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:625 auto D = E->getBase()->getDependence(); + D |= getDependenceInExpr(E->getMemberNameInfo()); + While implementing this patch I was following Richard's guide from

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to incorrect calculation false positive diagnostics were emitted. Fixes

[PATCH] D154578: [ARM][Driver] Change float-abi warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79165735e11e: [ARM][Driver] Change float-abi warning (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7916573 - [ARM][Driver] Change float-abi warning

Author: Michael Platings Date: 2023-07-07T09:41:18+01:00 New Revision: 79165735e11e40e1fbbb91ccbdd4df24d6349837 URL: https://github.com/llvm/llvm-project/commit/79165735e11e40e1fbbb91ccbdd4df24d6349837 DIFF:

[PATCH] D140727: [XRay] Add initial support for loongarch64

Ami-zhang updated this revision to Diff 538022. Ami-zhang added a comment. Rebase and make some improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140727/new/ https://reviews.llvm.org/D140727 Files: clang/lib/Driver/XRayArgs.cpp

[PATCH] D154603: [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker

donat.nagy added a comment. The commit looks good in general, I have a few minor suggestions and a serious question about the state transition bureaucracy. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:65-66 + // If set to true, consider getenv

[PATCH] D140727: [XRay] Add initial support for loongarch64

Ami-zhang added inline comments. Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:23 +enum PatchOpcodes : uint32_t { + PO_ADDID = 0x02c0, // addi.d rd, rj, imm + PO_SD = 0x29c0, // st.d rd, base, offset MaskRay wrote: > I think the `PO_`

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154688 Files:

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

nikic added a comment. In D145265#4478621 , @aeubanks wrote: > @nikic could you try running this over the rust tests again? Ignoring some unrelated powerpc data layout failures, these codegen tests fail: [codegen] tests/codegen/issues/issue-45222.rs

[PATCH] D154636: [8/8][RISCV] Add rounding mode control variant for vfredosum, vfredusum, vfwredosum, vfwredusum

eopXD updated this revision to Diff 538018. eopXD added a comment. Add sema checking and corresponding test case for added intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154636/new/ https://reviews.llvm.org/D154636 Files:

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

eopXD updated this revision to Diff 538016. eopXD added a comment. Remove rounding mode variant of vfwcvt.f.x, vfwcvt.f.xu Add out-of-range semantic check and its corresponding test cases for the intrinsics added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

eopXD updated this revision to Diff 538012. eopXD marked 3 inline comments as done. eopXD added a comment. Remove rounding mode variant of vfwcvt.f.f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154635/new/ https://reviews.llvm.org/D154635

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining added a comment. Since `R_LARCH_64_PCREL` has been supported, we can use version 2 xray and the patch summary should be modified accordingly. Comment at: llvm/lib/Target/LoongArch/LoongArchAsmPrinter.cpp:187 + OutStreamer->emitLabel(EndOfSled); +

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein accepted this revision. hokein added a comment. Thanks, this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 ___ cfe-commits mailing list

[PATCH] D154634: [6/8][RISCV] Add rounding mode control variant for vfsqrt, vfrec7

eopXD updated this revision to Diff 538008. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154634/new/ https://reviews.llvm.org/D154634 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D154633: [5/8][RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac

eopXD updated this revision to Diff 538007. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154633/new/ https://reviews.llvm.org/D154633 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D154632: [4/8][RISCV] Add rounding mode control variant for vfmacc, vfnmacc, vfmsac, vfnmsac, vfmadd, vfnmadd, vfmsub, vfnmsub

eopXD updated this revision to Diff 538006. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154632/new/ https://reviews.llvm.org/D154632 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D154631: [3/8][RISCV] Add rounding mode control variant for vfmul, vfdiv, vfrdiv, vfwmul

eopXD updated this revision to Diff 538004. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154631/new/ https://reviews.llvm.org/D154631 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

eopXD updated this revision to Diff 538003. eopXD added a comment. Update test case for vfwsub under clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154629/new/ https://reviews.llvm.org/D154629

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

eopXD updated this revision to Diff 538001. eopXD marked 2 inline comments as done. eopXD added a comment. Address comment from Craig: - Remove unnecessary added header - Reduce code duplication Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

tbaeder added a comment. @cjdb LGTY? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/ https://reviews.llvm.org/D153359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin updated this revision to Diff 537996. cor3ntin added a comment. Address Tom's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153621/new/ https://reviews.llvm.org/D153621 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:182 +namespace GH63605 { +struct { + unsigned : 2; Should we add bases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/

<    1   2   3   >