[PATCH] D155501: Add new option -fkeep-persistent-storage-variables to Clang release notes

qianzhen created this revision. Herald added a project: All. qianzhen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates the Clang release notes with the new option -fkeep-persistent-storage-variables added at

[PATCH] D155475: [Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate

rZhBoYao updated this revision to Diff 541151. rZhBoYao retitled this revision from "[Clang][Sema] Add -Wctad-copy-not-wrap to diagnose copy deduction candidate" to "[Clang][Sema] Add -Wctad-selects-copy to diagnose copy deduction candidate". rZhBoYao edited the summary of this revision.

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

porglezomp updated this revision to Diff 541157. porglezomp added a comment. Update to check the target OSes more precisely Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155408/new/ https://reviews.llvm.org/D155408 Files:

[PATCH] D155445: [analyzer][docs] Add CSA release notes

steakhal updated this revision to Diff 541175. steakhal marked 4 inline comments as done. steakhal added a comment. Currentl look: F28285701: image.png let me know if you like it. Feel free to propose changes. I'm not sure about the relative ordering. We

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have rjmccall wrote: > You can pull the

[clang] f0a955d - [HIP] Rename predefined macros

Author: Yaxun (Sam) Liu Date: 2023-07-17T15:45:49-04:00 New Revision: f0a955d3fa54d2b8600e646bbfb6bf3217a18d0c URL: https://github.com/llvm/llvm-project/commit/f0a955d3fa54d2b8600e646bbfb6bf3217a18d0c DIFF:

[PATCH] D155480: [HIP] Rename predefined macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0a955d3fa54: [HIP] Rename predefined macros (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155509: Revert "Remove rdar links; NFC"

mehdi_amini created this revision. mehdi_amini added reviewers: lattner, aaron.ballman. Herald added subscribers: steakhal, jdoerfert, martong, pengfei, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. mehdi_amini requested review of this revision. Herald added subscribers:

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare added a comment. I addressed the comments, and I have redesigned this option to simplify it further. Now there are only two options at the top for `SpacesInParens` to be either `Never` or `Custom`. Then within `Custom` the individual behavior of the spaces can be controlled. This

[PATCH] D155501: Add new option -fkeep-persistent-storage-variables to Clang release notes

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:259-260 +- ``-fkeep-persistent-storage-variables`` has been implemented to keep all + variables that have a persistent storage duration, including global, static + and thread-local variables,

[PATCH] D155270: [clang][Interp] Basic support for bit fields

shafik added inline comments. Comment at: clang/test/AST/Interp/bitfields.cpp:36 + // TODO: +=, -=, etc. operators. +} This is an interesting test case: ``` struct A {int c:3;}; constexpr int f() { A a1{3}; return a1.c++; } void g() { constexpr int x

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

MaskRay added a comment. Reverse ping @philnik :) The `release/17.x` branch will be created soon (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/

[PATCH] D155525: WIP

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Alternate to D155522 based on https://reviews.llvm.org/D155342#4507805

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have nickdesaulniers wrote: > nickdesaulniers wrote:

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541269. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pragma-fixit.cpp Index:

[PATCH] D155534: fix arg validation issue and void return issue, tests pass

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155534 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 541155. koops added a comment. 1. Removing the size for the template constructor, llvm::SmallVectorImpl 2. In the diagnostic message of err_omp_bind_required_on_loop, using single quotes for the name 'loop' construct. 3. Minor changes to the tests

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 541178. nickdesaulniers added a comment. - fix typo in release doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 Files: clang/docs/ReleaseNotes.rst

[clang] 6c30b78 - Reland "[PS4/PS5] Tidy up driver warnings finding the SDK"

Author: Paul Robinson Date: 2023-07-17T13:57:08-07:00 New Revision: 6c30b7886919eb19289f5ed9216e72de9700c9fb URL: https://github.com/llvm/llvm-project/commit/6c30b7886919eb19289f5ed9216e72de9700c9fb DIFF: https://github.com/llvm/llvm-project/commit/6c30b7886919eb19289f5ed9216e72de9700c9fb.diff

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have nickdesaulniers wrote: > rjmccall wrote: > > You can

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have rjmccall wrote: > nickdesaulniers wrote: > >

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have nickdesaulniers wrote: > rjmccall wrote: > >

[PATCH] D155509: Revert "Remove rdar links; NFC"

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 541265. yonghong-song edited the summary of this revision. yonghong-song added a comment. - Dropping 'CPUv4' in some variable/function names and also in debug flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

t-rasmud accepted this revision. t-rasmud added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346 + // computed above. We do not want to generate fix-its for such variables, + // since they are

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

rjmccall added a comment. In D155506#4508176 , @gribozavr2 wrote: > I'm not sure it is actually an anti-pattern. `dyn_cast` will transparently > handle subclasses, should any be added in the future, but a switch wouldn't. Yeah, I don't think we have a

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4214-4220 +/// Put a space in parentheses around the outside of attribute specifier +/// lists. +/// \code +///true: false: +///

[PATCH] D155509: Revert "Remove rdar links; NFC"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0ac46e69d7a: Revert Remove rdar links; NFC (authored by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); eopXD wrote: >

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153273/new/ https://reviews.llvm.org/D153273 ___ cfe-commits mailing

[PATCH] D140745: Generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

nridge added a comment. In D140745#4505829 , @sammccall wrote: > ping on this one for when you have time (Just wanted to double-check, is this ping directed to me or Kadir (or both)? I haven't looked at this because Kadir has done a round of review and

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

aaron.ballman added a comment. In D155457#4507107 , @xgupta wrote: > In D155457#4506405 , @xbolva00 > wrote: > >> You should add a testcase which uses “expected no diagnostics”. > > There is some issue writing

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194 + + S.Stk.push>(Integral<32, true>::from(Arg.isFinite())); + return true; We have platforms on which the width of an integer is not 32-bits; because this is pushing

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel added a comment. Thanks for the very helpful feedback! I think I've addressed all of the suggestions/concerns. I suspect there's yet more room for improvement in the algorithm, but I think we're converging on "good enough". Comment at:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:343 + /// This may also be used in a similar way for other constructs. + OpenMPDirectiveKind MappedDirective = OMPD_unknown; + ABataev wrote: > I assume it shall be a member of

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 541169. nickdesaulniers added a comment. This revision is now accepted and ready to land. - remove AsmJumps Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

rZhBoYao added a comment. There seems to be no clear objection to this and https://reviews.llvm.org/D152632 and the CI are passing for both. Any chance that I merge these two before llvm 17 branch out (IIRC the next Monday)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153156/new/

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45ff63ba6112: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min (authored by porglezomp). Repository: rG LLVM Github Monorepo

[clang] 45ff63b - [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

Author: Cassie Jones Date: 2023-07-17T13:26:52-07:00 New Revision: 45ff63ba6112c199897b4117d54f19d28161b632 URL: https://github.com/llvm/llvm-project/commit/45ff63ba6112c199897b4117d54f19d28161b632 DIFF: https://github.com/llvm/llvm-project/commit/45ff63ba6112c199897b4117d54f19d28161b632.diff

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare updated this revision to Diff 541219. gedare marked 3 inline comments as done. gedare added a comment. Properly deprecate old options, and simplify top-level to Never and Custom Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5336 + // least zve64x + if ((Ty->isRVVType(/* Bitwidth */ 64, /* IsFloat */ false) && + !TI.hasFeature("zve64x")) || Can we do ``` if ((Ty->isRVVType(/* Bitwidth */ 64, /*

[clang] f7623f4 - Enable zba and zbs for RISCV64 Android

Author: AdityaK Date: 2023-07-17T16:16:13-07:00 New Revision: f7623f4f692d10ef0f764876d670968cba3c9981 URL: https://github.com/llvm/llvm-project/commit/f7623f4f692d10ef0f764876d670968cba3c9981 DIFF: https://github.com/llvm/llvm-project/commit/f7623f4f692d10ef0f764876d670968cba3c9981.diff LOG:

[PATCH] D155339: Enable zba and zbs for RISCV64 Android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7623f4f692d: Enable zba and zbs for RISCV64 Android (authored by AdityaK 1894981+hiradi...@users.noreply.github.com). Repository: rG LLVM Github

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

gribozavr2 added a comment. I'm not sure it is actually an anti-pattern. `dyn_cast` will transparently handle subclasses, should any be added in the future, but a switch wouldn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155506/new/

[PATCH] D155525: WIP

rjmccall added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:362 // it. This makes the second scan not have to walk the AST again. +RecordJumpScope: LabelAndGotoScopes[S] = ParentScope; I would indent this at the same level as the

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2249 } UnsafeOps = groupWarningGadgetsByVar(std::move(WarningGadgets)); Maybe early-return here when there are no gadgets? CHANGES SINCE LAST ACTION

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///__attribute__(( noreturn ))vs.

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vwsll.c:12 +// +vint16mf4_t test_vwsll_vv_i16mf4(vint8mf8_t op1, vint8mf8_t op2, size_t vl) { + return __riscv_vwsll_vv_i16mf4(op1, op2, vl);

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth added a comment. In D155490#4507061 , @MaskRay wrote: > I find that `See patch` is used elsewhere. Does this change fix a sphinx bot? yes: https://lab.llvm.org/buildbot#builders/92/builds/47401 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

ahatanak accepted this revision. ahatanak added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155408/new/ https://reviews.llvm.org/D155408 ___ cfe-commits mailing list

[PATCH] D150292: [clang][modules] Serialize `Module::DefinitionLoc`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabcf7ce45794: [clang][modules] Serialize `Module::DefinitionLoc` (authored by jansvoboda11). Changed prior to commit:

[clang] 227f719 - [clang][modules][deps] Avoid checks for relocated modules

Author: Jan Svoboda Date: 2023-07-17T13:50:24-07:00 New Revision: 227f71995804fa5df3f917ae3a7b1499cd24726c URL: https://github.com/llvm/llvm-project/commit/227f71995804fa5df3f917ae3a7b1499cd24726c DIFF: https://github.com/llvm/llvm-project/commit/227f71995804fa5df3f917ae3a7b1499cd24726c.diff

[clang] be01456 - [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

Author: Jan Svoboda Date: 2023-07-17T13:50:24-07:00 New Revision: be014563f2f492658abcfa68cfaffc58a4ed7d9a URL: https://github.com/llvm/llvm-project/commit/be014563f2f492658abcfa68cfaffc58a4ed7d9a DIFF: https://github.com/llvm/llvm-project/commit/be014563f2f492658abcfa68cfaffc58a4ed7d9a.diff

[clang] abcf7ce - [clang][modules] Serialize `Module::DefinitionLoc`

Author: Jan Svoboda Date: 2023-07-17T13:50:23-07:00 New Revision: abcf7ce45794839a473a236d55d163016cde5ba6 URL: https://github.com/llvm/llvm-project/commit/abcf7ce45794839a473a236d55d163016cde5ba6 DIFF: https://github.com/llvm/llvm-project/commit/abcf7ce45794839a473a236d55d163016cde5ba6.diff

[PATCH] D155419: [Clang][CMake][WIP] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 541222. Amir added a comment. More plumbing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/utils/perf-training/CMakeLists.txt

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 updated this revision to Diff 541294. bob80905 added a comment. fix void return, and incorrect expectation of arg count Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files:

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

eopXD added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); Valid range of

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 541153. ymandel marked 12 inline comments as done. ymandel added a comment. tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files:

[clang] 0f6cf55 - [clang][dataflow] Bugfix for `refreshStructValue()`.

Author: Martin Braenne Date: 2023-07-17T18:56:25Z New Revision: 0f6cf555674959d0b21769fc1c46e23584561f2a URL: https://github.com/llvm/llvm-project/commit/0f6cf555674959d0b21769fc1c46e23584561f2a DIFF: https://github.com/llvm/llvm-project/commit/0f6cf555674959d0b21769fc1c46e23584561f2a.diff

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 541173. nickdesaulniers added a comment. This revision is now accepted and ready to land. - remove stale asm goto comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:934-936 + // Default to the /../lib and + // /../runtimes/runtimes-bins/lib directories. This works fine + // on the platforms that we have tested so far. We will probably have to

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:726 // Collect a single representative of every scope containing an // indirect or asm goto. For most code bases, this substantially

[PATCH] D155465: [clang][dataflow] Bugfix for `refreshStructValue()`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6cf5556749: [clang][dataflow] Bugfix for `refreshStructValue()`. (authored by mboehme). Changed prior to commit:

[PATCH] D155081: Specify the developer policy around links to external resources

probinson added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345; to automate closing + the issue in GitHub. If the patch has been

[clang] cbc4bbb - [HIP] Ignore host linker flags for device-only

Author: Siu Chi Chan Date: 2023-07-17T16:29:15-04:00 New Revision: cbc4bbb85c729f34bf0cba84ccd2e116af1454f5 URL: https://github.com/llvm/llvm-project/commit/cbc4bbb85c729f34bf0cba84ccd2e116af1454f5 DIFF: https://github.com/llvm/llvm-project/commit/cbc4bbb85c729f34bf0cba84ccd2e116af1454f5.diff

[PATCH] D154881: [HIP] Ignore host linker flags for device-only

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbc4bbb85c72: [HIP] Ignore host linker flags for device-only (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154881/new/

[clang] dba2b5c - [clang][modules] Skip submodule & framework re-definitions in module maps

Author: Jan Svoboda Date: 2023-07-17T13:50:25-07:00 New Revision: dba2b5c9314e1d127ee5200e739e6c8ca53a9831 URL: https://github.com/llvm/llvm-project/commit/dba2b5c9314e1d127ee5200e739e6c8ca53a9831 DIFF: https://github.com/llvm/llvm-project/commit/dba2b5c9314e1d127ee5200e739e6c8ca53a9831.diff

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe014563f2f4: [clang][modules][deps] Parse FW_Private module map even after loading FW PCM (authored by jansvoboda11). Repository: rG LLVM

[PATCH] D150479: [clang][modules] Skip submodule & framework re-definitions in module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdba2b5c9314e: [clang][modules] Skip submodule framework re-definitions in module maps (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D150320: [clang][modules][deps] Avoid checks for relocated modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227f71995804: [clang][modules][deps] Avoid checks for relocated modules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155339: Enable zba and zbs for RISCV64 Android

hiraditya added inline comments. Comment at: clang/test/Driver/riscv-features.c:13 +// ANDROID: "-target-feature" "+zba" // ANDROID: "-target-feature" "+zbb" MaskRay wrote: > If the features are adjacent, test them on one line. `// ANDROID: >

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. When some unsafe operations are

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:197-200 +DiagnoseAccess(std::move(Other.DiagnoseAccess)), +DiagnoseAmbiguous(std::move(Other.DiagnoseAmbiguous)),

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers updated this revision to Diff 541139. nickdesaulniers marked 5 inline comments as done. nickdesaulniers added a comment. This revision is now accepted and ready to land. - test just asm goto targets, as per @rjmccall (this lead to many cleanups) - add release note and test case as

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/test/Sema/asm-goto.cpp:71 +l1:; +} cor3ntin wrote: > can you add more tests? Maybe something like that > > ```cpp > void f() { > try{ > __label__ label; > asm goto("" : : : : label); >

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

Sedeniono added a comment. I don't see how the failed test cases could be my fault; they deal with the address sanitizer. So maybe some one could please commit this to main using `Sedenion <39583823+sedeni...@users.noreply.github.com>`? Thanks! Repository:

[PATCH] D154774: [Sema] Respect instantiated-from template's VisibilityAttr for two implicit/explicit instantiation cases

MaskRay added a comment. ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154774/new/ https://reviews.llvm.org/D154774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

nathanchance added a comment. I took the most recent version for a spin against the Linux kernel. The couple of issues that a previous revision of the warning flagged (https://github.com/ClangBuiltLinux/linux/issues/1806, https://github.com/ClangBuiltLinux/linux/issues/1807) are no longer

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

shafik added a comment. I think we at least need some tests for this, looks like we have the AST tests in `clang/test/AST/ast-dump*` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added a comment. I do like the look of https://reviews.llvm.org/D155522, yeah, since we have so many of these that aren't top-level in a case anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pragma-fixit.cpp Index:

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346 + // computed above. We do not want to generate fix-its for such variables, + // since they are neither warned nor reachable from a

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154755/new/ https://reviews.llvm.org/D154755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154880: [-Wunsafe-buffer-usage][WIP] Add a facility for debugging low fixit coverage.

t-rasmud added a comment. I will add debug notes for the rest of the cases not addressed in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154880/new/ https://reviews.llvm.org/D154880 ___ cfe-commits mailing list

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

Sedeniono updated this revision to Diff 541146. Sedeniono marked an inline comment as done. Sedeniono added a comment. Implemented review changes as suggested by @owenpan. If this is finally ok, someone please commit it to main using the following: `Sedenion

[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

aaron.ballman added a subscriber: jcranmer-intel. aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:121-130 + char classify_nan [__builtin_fpclassify(+1, -1, -1, -1, -1, __builtin_nan(""))]; + char classify_snan

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

Sedeniono marked 6 inline comments as done. Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:641-646 + Style = getLLVMStyle(); + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:75 SmallVector IndirectJumps; SmallVector AsmJumps; SmallVector MustTailStmts; `AsmJumps` can now be removed, too.

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid the anti-pattern of: if dyn_cast: ... elif dyn_cast: ... elif dyn_cast: ... And

[PATCH] D114173: [clang][modules] Apply local submodule visibility to includes

jansvoboda11 updated this revision to Diff 541218. jansvoboda11 edited the summary of this revision. jansvoboda11 added a comment. Rebase on top of D155503 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. There are many ast-dump tests about decls but there are nearly no other type tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383

[PATCH] D155523: [clang] Fix a crash when casting to an array type

ayzhao created this revision. ayzhao added a reviewer: aaron.ballman. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In C++20, if Clang fails to perform constructor overload on a RecordType, then Clang

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4508209 , @MaskRay wrote: > Reverse ping @philnik :) > > The `release/17.x` branch will be created soon > (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). I know. I just didn't have the

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. The __attribute((specifier-list)) currently is formatted

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

owenpan accepted this revision. owenpan added a comment. LGTM except for D151047#4508359 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047

[PATCH] D155537: [ASTImporter] Fix import failed when anonymous union defined in class

jcsxky created this revision. jcsxky added a reviewer: danix800. jcsxky added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. jcsxky requested review of this revision. Herald added a subscriber:

[PATCH] D155368: [clang][Interp] __builtin_copysign

aaron.ballman added a comment. Missing test coverage for copysign. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:141 + +static bool interp__builtin_fmin(InterpState , CodePtr OpPC, + const InterpFrame *Frame, const Function *F) {

[PATCH] D155503: [clang][modules] Track included files per submodule

jansvoboda11 added a comment. Note to self: lost the change that bumps PCM format version during a rebase. Make sure to increment the major version before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155503/new/

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added a comment. Thanks, that's way better. Just a couple minor requests. Comment at: clang/docs/ReleaseNotes.rst:629 +- Fixed false positive error diagnostic observed from mixing ``asm goto`` with + ``__attribute__((cleanup()))`` variables falsly warning that jumps

  1   2   3   >