Author: majnemer
Date: Wed Jul 6 23:43:07 2016
New Revision: 274732
URL: http://llvm.org/viewvc/llvm-project?rev=274732&view=rev
Log:
[AST] Use ArrayRef in more interfaces
ArrayRef is a little better than passing around a pointer/length
pair.
No functional change is intended.
Modified:
cfe
Author: majnemer
Date: Wed Jul 6 23:43:11 2016
New Revision: 274733
URL: http://llvm.org/viewvc/llvm-project?rev=274733&view=rev
Log:
[AST] Tighten up the bitfield in TemplateSpecializationType
Optimize the bitfield types to conserve space for the MSVC ABI.
Modified:
cfe/trunk/include/clang
hfinkel updated this revision to Diff 63029.
hfinkel added a comment.
Thanks everyone. I've rebased this and changed the name to __libcpp_*.
Marshall, how do you recommend rewriting the functions to reduce the
boilerplate?
http://reviews.llvm.org/D18639
Files:
include/cmath
include/comple
Author: etienneb
Date: Wed Jul 6 23:03:05 2016
New Revision: 274731
URL: http://llvm.org/viewvc/llvm-project?rev=274731&view=rev
Log:
[clang-tidy] Enhance redundant-expression check
Summary: This patch is adding support to recognize more complex redundant
expressions.
Reviewers: alexfh
Subscr
mehdi_amini added inline comments.
Comment at: docs/CSI.rst:78
@@ +77,3 @@
+Notice that in the final stage of linking, the tool user also needs to link in
+the static library of the CSI runtime to produce the final TIX. The runtime
+archive is distributed under the ``build/lib/cl
bruening added inline comments.
Comment at: docs/CSI.rst:78
@@ +77,3 @@
+Notice that in the final stage of linking, the tool user also needs to link in
+the static library of the CSI runtime to produce the final TIX. The runtime
+archive is distributed under the ``build/lib/clang
etienneb updated this revision to Diff 63020.
etienneb marked 2 inline comments as done.
etienneb added a comment.
nits
http://reviews.llvm.org/D21392
Files:
clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tidy/misc/RedundantExpressionCheck.h
test/clang-tidy/misc-redundant-expression.c
compnerd accepted this revision.
This revision is now accepted and ready to land.
Comment at: src/Registers.hpp:1497
@@ -1479,3 +1496,3 @@
_LIBUNWIND_ABORT("unsupported arm register");
}
Early returns would be nicer imo.
Comment at: src/R
mehdi_amini added inline comments.
Comment at: docs/CSI.rst:46
@@ +45,3 @@
+allows the LTO to later elide hooks irrelevant to the tool entirely from the
+program-under-test.
+
The long thread on llvm-dev went to conclude that LTO should not be needed.
===
Author: jlebar
Date: Wed Jul 6 20:06:59 2016
New Revision: 274713
URL: http://llvm.org/viewvc/llvm-project?rev=274713&view=rev
Log:
[CUDA] Fix "control reaches end of non-void function" warnings in Cuda.cpp.
Some compilers are too dumb to realize that the switch statement covers
all cases.
(Don
jlebar added a comment.
Friendly ping.
http://reviews.llvm.org/D21869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi David,
Thanks for the fix!
Comment at: lib/Sema/SemaOpenMP.cpp:10639
@@ -10638,2 +10638,3 @@
break;
}
+while(SI != SE) {
You have to document what you are trying to accomplish here, something like
`"Che
NoQ added a comment.
I also never noticed that the block count gets reset on every stack frame,
that's pretty unobvious. Uhm, and it's already there in SymbolConjured. Anyway,
fixing the block count itself seems to be pretty complicated.
Also, maybe once the ScopeContext thing is ready, we'd be
davidsh created this revision.
davidsh added reviewers: carlo.bertolli, arpith-jacob, sfantao, ABataev, kkwli0.
davidsh added a subscriber: cfe-commits.
Having the following code pattern will result in incorrect diagnostic
int main() {
int arr[10];
#pragma omp target data map(arr[:])
#pragma omp t
jfb created this revision.
jfb added a reviewer: cfe-commits.
libc++ implements std::atomic<_Tp> using __atomic_base<_Tp> with
`mutable _Atomic(_Tp) __a_`. That member must be suitably aligned on
relevant ISAs for instructions such as cmpxchg to work properly, but
this alignment isn't checked anyw
Author: amccarth
Date: Wed Jul 6 18:28:34 2016
New Revision: 274706
URL: http://llvm.org/viewvc/llvm-project?rev=274706&view=rev
Log:
Revert "Retry "Include debug info for nested structs and classes""
Reverting because it causes a test failure on build bots
(Modules/ModuleDebugInfo.cpp). Failu
NoQ accepted this revision.
NoQ added a comment.
LGTM, all clear to me now :)
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: amccarth
Date: Wed Jul 6 17:39:15 2016
New Revision: 274698
URL: http://llvm.org/viewvc/llvm-project?rev=274698&view=rev
Log:
Retry "Include debug info for nested structs and classes"
This should work now that the LLVM-side of the change has landed successfully.
Original Differential Re
Author: aaronballman
Date: Wed Jul 6 17:06:19 2016
New Revision: 274695
URL: http://llvm.org/viewvc/llvm-project?rev=274695&view=rev
Log:
Ensuring the bit-fields have the same type; MSVC will place the fields in
different allocation units otherwise.
Modified:
cfe/trunk/include/clang/Basic/S
Author: dcoughlin
Date: Wed Jul 6 16:52:55 2016
New Revision: 274691
URL: http://llvm.org/viewvc/llvm-project?rev=274691&view=rev
Log:
[analyzer] Suppress false positives in std::shared_ptr
The analyzer does not model C++ temporary destructors completely and so
reports false alarms about leaks o
Author: jlebar
Date: Wed Jul 6 16:45:44 2016
New Revision: 274689
URL: http://llvm.org/viewvc/llvm-project?rev=274689&view=rev
Log:
[CUDA] Add missing namespace qualification on CudaArch in Action.cpp.
Fix build breakage with MSVC.
Modified:
cfe/trunk/lib/Driver/Action.cpp
Modified: cfe/tr
dcoughlin updated the summary for this revision.
dcoughlin updated this revision to Diff 62978.
dcoughlin added a comment.
Address Artem's comments: fix a copy-pasta mistake and separate out std stubs
with deliberate divide-by-zero bugs into their own simulated header file. This
required moving
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274681: [CUDA] Add utility functions for dealing with CUDA
versions / architectures. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21867?vs=62409&id=62975#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274682: [CUDA] Rename member variables in
CudaInstallationDetector. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21868?vs=62300&id=62976#toc
Repository:
rL LLVM
http://rev
Author: jlebar
Date: Wed Jul 6 16:21:43 2016
New Revision: 274682
URL: http://llvm.org/viewvc/llvm-project?rev=274682&view=rev
Log:
[CUDA] Rename member variables in CudaInstallationDetector.
Summary:
Remove the "Cuda" prefix from these variables -- it's clear that they
related to CUDA given the
Author: jlebar
Date: Wed Jul 6 16:21:39 2016
New Revision: 274681
URL: http://llvm.org/viewvc/llvm-project?rev=274681&view=rev
Log:
[CUDA] Add utility functions for dealing with CUDA versions / architectures.
Summary:
Currently our handling of CUDA architectures is scattered all around
clang. T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274680: [CUDA] Add support for CUDA 8 and sm_60-62.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D21778?vs=62908&id=62974#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
Author: jlebar
Date: Wed Jul 6 16:21:14 2016
New Revision: 274680
URL: http://llvm.org/viewvc/llvm-project?rev=274680&view=rev
Log:
[CUDA] Add support for CUDA 8 and sm_60-62.
Summary: Also add sm_32, which was missing.
Reviewers: tra
Subscribers: cfe-commits
Differential Revision: http://rev
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
alexfh added a comment.
Thank you for fixing the bug! One comment below.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:525
@@ +524,3 @@
+ DeclarationType = DeclarationType.getNonReferenceType();
+if (Descriptor.ElemType.isNull() || DeclarationType.isNull() ||
+
kzhuravl updated this revision to Diff 62971.
kzhuravl added a comment.
Rebase
http://reviews.llvm.org/D21724
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen/synchscopes.cpp
Index: test/CodeGen/synchscopes.cpp
yaxunl updated this revision to Diff 62966.
yaxunl added a comment.
Removed the old representation of sampler type by i32.
http://reviews.llvm.org/D21567
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/OperationKinds.def
include/clang/AST/Type.
jlebar added a comment.
> They will need to wait for corresponding patch on LLVM side to deal with new
> SM variants, though.
This is in now, http://reviews.llvm.org/D22068.
Comment at: lib/Driver/ToolChains.cpp:1715
@@ -1714,2 +1714,3 @@
CudaPathCandidates.push_back(D.S
Author: majnemer
Date: Wed Jul 6 16:07:53 2016
New Revision: 274677
URL: http://llvm.org/viewvc/llvm-project?rev=274677&view=rev
Log:
[CodeGen, DebugInfo] Use hasLocalLinkage instead of hasInternalLinkage
For the purpose of emitting debug info, entities with private linkage
should be treated the
mgehre created this revision.
mgehre added reviewers: alexfh, klimek.
mgehre added a subscriber: cfe-commits.
Previoly, the added test failed with the fillowing fixit:
char v[5];
-for(size_t i = 0; i < 5; ++i)
+for(char value : v)
{
-unsigned char value = v[i];
yaxunl added a comment.
I think you also need to set Opts.NoSignedZeros in CompilerInvocation.cpp.
Repository:
rL LLVM
http://reviews.llvm.org/D22067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
dcoughlin added inline comments.
Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:349
@@ +348,3 @@
+// No warning is expected as we are suppressing warning coming
+// out of std::basic_string.
+int z = 0;
NoQ wrote:
> You mean std::shared
ashi1 created this revision.
ashi1 added reviewers: Anastasia, jvesely.
ashi1 added subscribers: yaxunl, nhaustov, rsmith, bader, pxli168, cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
Add OCL option -cl-no-signed-zeros to driver options.
Also added to opencl.cl testcases.
NoQ added inline comments.
Comment at: test/Analysis/Inputs/system-header-simulator-cxx.h:349
@@ +348,3 @@
+// No warning is expected as we are suppressing warning coming
+// out of std::basic_string.
+int z = 0;
You mean std::shared_ptr here?
Also, p
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D22048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Justin Bogner via cfe-commits writes:
> Author: bogner
> Date: Wed Jul 6 14:52:32 2016
> New Revision: 274663
>
> URL: http://llvm.org/viewvc/llvm-project?rev=274663&view=rev
> Log:
> NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl
>
> To match "NVPTX: Make the llvm.nvvm.shfl intrinsics and built
Author: bogner
Date: Wed Jul 6 14:52:32 2016
New Revision: 274663
URL: http://llvm.org/viewvc/llvm-project?rev=274663&view=rev
Log:
NVPTX: Rename __builtin_ptx_shfl -> __nvvm_shfl
To match "NVPTX: Make the llvm.nvvm.shfl intrinsics and builtin names
consistent" in LLVM.
Modified:
cfe/trunk/
Author: aaronballman
Date: Wed Jul 6 13:33:01 2016
New Revision: 274654
URL: http://llvm.org/viewvc/llvm-project?rev=274654&view=rev
Log:
Ensuring the bit-fields have the same type; MSVC will place the fields in
different allocation units otherwise.
Modified:
cfe/trunk/lib/Sema/SemaChecking
Hi Marshall,
I reverted this in r274651, since it broke a bot. Feel free to re-commit it
later.
Manman
> On Jul 6, 2016, at 12:16 AM, Diana Picus via cfe-commits
> wrote:
>
> Hi Marhsall,
>
> This seems to be breaking our libcxx bot:
> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-arm-
Author: mren
Date: Wed Jul 6 13:24:53 2016
New Revision: 274651
URL: http://llvm.org/viewvc/llvm-project?rev=274651&view=rev
Log:
Revert r274605 due to bot failure:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/244/
Modified:
libcxx/trunk/test/std/utilities/meta/meta.u
Author: aaronballman
Date: Wed Jul 6 13:25:16 2016
New Revision: 274652
URL: http://llvm.org/viewvc/llvm-project?rev=274652&view=rev
Log:
Add AST matchers for handling bit-fields and narrowing based on their width.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/c
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#475551, @majnemer wrote:
> In http://reviews.llvm.org/D22034#475540, @DmitryPolukhin wrote:
>
> > Here is B::foo is not exported but required to build vftable for D.
>
>
> What happens if D also had a virtual destructor?
It seems
majnemer added a comment.
Thinking about this some more, it is possible for clang to emit code that will
make everybody happy:
If a class is being constructed in a constexpr context and all the vftable
entries it references are marked import, emit local vftables and reference them
in the objec
Reverted because this depended upon an LLVM patch that was reverted because
of test failures on the buildbots. I'm still investigating the root cause.
SVN revision was rL274628.
On Wed, Jul 6, 2016 at 8:15 AM, Adrian McCarthy via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: amccar
bruno closed this revision.
bruno added a comment.
Thanks Reid,
Committed r274646.
http://reviews.llvm.org/D21700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Wed Jul 6 13:05:23 2016
New Revision: 274646
URL: http://llvm.org/viewvc/llvm-project?rev=274646&view=rev
Log:
[SemaExpr] Support assignments from vector to scalars with same size
Before r266366, clang used to support constructs like:
typedef __attribute__((vector_size(8))
rnk added a comment.
In http://reviews.llvm.org/D22034#475540, @DmitryPolukhin wrote:
> Here is B::foo is not exported but required to build vftable for D. Also user
> may want to explicitly control what should be exported from his library and
> may decide to remove some functions from exported
wolfgangp added inline comments.
Comment at: test/CodeGen/forwarding-blocks-if.c:17
@@ +16,3 @@
+return 0;
+}
+
mehdi_amini wrote:
> Any reason to not stick with LLVM coding convention here?
No reason, thanks for pointing this out.
http://reviews.llvm.org/D1
wolfgangp updated this revision to Diff 62916.
wolfgangp added a comment.
Addressed review comments: documented changes and clang-formatted the test case.
http://reviews.llvm.org/D11360
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/forwarding-blocks-if.c
Index: test/CodeGen/forwarding-blocks-
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix MSVC "warning C4100: 'val': unreferenced formal parameter".
http://reviews.llvm.org/D22059
Files:
test/std/utilities/tuple/tuple.tuple/tuple.assign/convert_move.pass.cpp
majnemer added a comment.
In http://reviews.llvm.org/D22034#475540, @DmitryPolukhin wrote:
> In http://reviews.llvm.org/D22034#475331, @majnemer wrote:
>
> > Wait, can you give an example of MSVC exporting a vftable but not all the
> > virtual methods (other than the deleting destructor)? I don
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D22034#475331, @majnemer wrote:
> Wait, can you give an example of MSVC exporting a vftable but not all the
> virtual methods (other than the deleting destructor)? I don't believe I've
> ever come across an example of this.
It is pos
Sunil_Srivastava created this revision.
Sunil_Srivastava added a reviewer: rsmith.
Sunil_Srivastava added a subscriber: cfe-commits.
This review is for a fix for PR 27895, but it requires some discussion. The
bugzilla and the email exchange with Richard Smith in
http://lists.llvm.org/pipermail/c
jlebar updated this revision to Diff 62908.
jlebar marked an inline comment as done.
jlebar added a comment.
Don't pull in the cuda 8 headers by default.
http://reviews.llvm.org/D21778
Files:
lib/Basic/Targets.cpp
lib/Driver/Action.cpp
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChai
tra added a comment.
The changes look good.
They will need to wait for corresponding patch on LLVM side to deal with new SM
variants, though.
Comment at: lib/Driver/ToolChains.cpp:1715
@@ -1714,2 +1714,3 @@
CudaPathCandidates.push_back(D.SysRoot + "/usr/local/cuda");
+
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D21914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
teemperor updated this revision to Diff 62899.
teemperor added a comment.
- Fixed a few typos in comments and documentation.
http://reviews.llvm.org/D20795
Files:
include/clang/AST/CloneDetection.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/AST/CMakeLists.txt
lib/AST/CloneDet
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D21913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, faisalv.
erik.pilkington added a subscriber: cfe-commits.
This is a regression that only affects -std=c++1z, introduced in r273754. The
following test case (thanks rsmith!) fails to compile:
```
template struct X {};
rmaprath added a reviewer: compnerd.
rmaprath removed a subscriber: compnerd.
rmaprath updated this revision to Diff 62890.
rmaprath added a comment.
- Use `__ARM_WMMX` instead of `_LIBUNWIND_ARM_WMMX`
- Add a comment to the cmake option `LIBUNWIND_ENABLE_ARM_WMMX` to explain why
it is done this
teemperor updated this revision to Diff 62888.
teemperor added a comment.
- Using doxygen-style comments for all private members.
http://reviews.llvm.org/D20795
Files:
include/clang/AST/CloneDetection.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/AST/CMakeLists.txt
lib/AST/Clo
STL_MSFT closed this revision.
STL_MSFT added a comment.
Closing - Marshall fixed the typo and uncommented the code.
http://reviews.llvm.org/D21349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
The analyzer does not model C++ temporary destructors completely and so reports
false alarms about leaks of memory allocated by the internals
majnemer added a comment.
In http://reviews.llvm.org/D22034#475002, @DmitryPolukhin wrote:
> In http://reviews.llvm.org/D22034#474985, @majnemer wrote:
>
> > In http://reviews.llvm.org/D22034#474937, @DmitryPolukhin wrote:
> >
> > > David, do you know real programs that relay on constexpr and dll
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
http://reviews.llvm.org/D21989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a reviewer: bkramer.
klimek added a comment.
I think we really want 2 tools:
a) one that is optimized for oldname->newname renames, and supports the
multi-TU case really well
b) one that is meant to be integrated with editors and works mainly off of a
location in a file
I'm a bit t
When reverting something, please say why in the commit description.
On Wed, Jul 6, 2016 at 11:15 AM, Adrian McCarthy via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: amccarth
> Date: Wed Jul 6 10:15:38 2016
> New Revision: 274633
>
> URL: http://llvm.org/viewvc/llvm-project?rev=274
Anastasia updated this revision to Diff 62880.
Anastasia added a comment.
- Fixed misc formatting issues
- Added restrictions and testing for return types
http://reviews.llvm.org/D21989
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
lib/Sema/SemaExpr.cpp
lib/Sem
Author: amccarth
Date: Wed Jul 6 10:15:38 2016
New Revision: 274633
URL: http://llvm.org/viewvc/llvm-project?rev=274633&view=rev
Log:
Revert "Include debug info for nested structs and classes"
This reverts commit 0af5ee9631c7c167dc40498b415876553e314c95.
Modified:
cfe/trunk/lib/CodeGen/CGDe
teemperor retitled this revision from "Added ASTStructure for analyzing the
structure of Stmts." to "Added basic capabilities to detect source code
clones.".
teemperor updated the summary for this revision.
teemperor updated this revision to Diff 62877.
teemperor added a comment.
- Patch now onl
carlo.bertolli updated this revision to Diff 62878.
carlo.bertolli added a comment.
[OpenMP] Remove 'brief' comment tags and change error report to standard
'expected' form.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/Recu
carlo.bertolli marked 4 inline comments as done.
carlo.bertolli added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D21904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274628: Include debug info for nested structs and classes
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D21705?vs=62283&id=62869#toc
Repository:
rL LLVM
http://reviews.llv
Author: amccarth
Date: Wed Jul 6 09:46:42 2016
New Revision: 274628
URL: http://llvm.org/viewvc/llvm-project?rev=274628&view=rev
Log:
Include debug info for nested structs and classes
This includes nested types in the member list, even if there are no members of
that type. Note that structs and
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Seems OK for now. :)
http://reviews.llvm.org/D21700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
yaxunl added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
Anastasia wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > I can't get wh
compnerd added a comment.
Right, we make it a cmake define corresponding to the AEABI name. In the
future when clang knows to correctly emit the macro, we just rely on that.
Figuring it out based on the target in my case means: `${CMAKE_C_COMPILER} -x c
-E - -dM <<< "__ARM_WMMX"`. Thats not
thakis created this revision.
thakis added a reviewer: alexfh.
thakis added a subscriber: cfe-commits.
Currently, to be able to process a source file including e.g. stddef.h with
clang-tidy, one has to build both clang-tidy and the clang-headers target.
Since stddef.h is needed for virtually an
rnk added a comment.
In http://reviews.llvm.org/D22034#474889, @majnemer wrote:
> Hmm, I'm not so sure this will work with constexpr:
> ...
Hah, my version of MSVC fails to install the vtable into 's', and crashes on
the call to x.fn().
http://reviews.llvm.org/D22034
aaboud created this revision.
aaboud added reviewers: ABataev, DavidKreitzer, hjl.tools, qcolombet.
aaboud added a subscriber: cfe-commits.
This patch implements the Clang part for no_caller_saved_registers attribute as
appear in [[
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=5ed3cc7b66af4758f
alexfh added a comment.
Gergely, it seems that the last diff is missing
clang-tidy/readability/MisleadingIndentationCheck.cpp. A few more comments
below.
Comment at: docs/clang-tidy/checks/readability-misleading-indentation.rst:13
@@ +12,3 @@
+
+The way to avoid dangling else
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:436
@@ +435,3 @@
+ CXX11<"clang", "xray_never_instrument">];
+ let Subjects = SubjectList<[CXXMethod, ObjCMethod, Function], WarnDiag,
+ "ExpectedFunctionOr
omtcyf0 added a comment.
http://en.cppreference.com/w/cpp/header for reference
http://reviews.llvm.org/D17990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
LGTM. As usual, you'll want to get one of the code owner's sign off first
though.
http://reviews.llvm.org/D21968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
omtcyf0 added a comment.
@alexfh same applies to the other headers. All of them are marked as
"deprecated" there.
Not sure if I should also mark and since they are in
"has no effect in C++" section now, though.
http://reviews.llvm.org/D17990
__
alexfh added inline comments.
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:39
@@ +38,3 @@
+* `` -> ``
+* `` -> `` // deprecated since C++11
+* `` -> ``
alexfh wrote:
> Not sure if "deprecated" is the right word here. The wording seems to
djasper added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:166
@@ -159,1 +165,3 @@
QueryString = ExtendNestedNameSpecifier(Range);
+ SymbolRange =
tooling::Range(SM.getDecomposedLoc(Range.getBegin()).second,
+ QueryStri
theraven added a comment.
Looks fine to me, though I wonder if we want to move to the new ABI for
FreeBSD11 and use the old one for <=10.
http://reviews.llvm.org/D21329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
bkramer accepted this revision.
bkramer added a reviewer: bkramer.
bkramer added a comment.
This revision is now accepted and ready to land.
I think this can go in now.
http://reviews.llvm.org/D21603
___
cfe-commits mailing list
cfe-commits@lists.ll
omtcyf0 updated this revision to Diff 62850.
omtcyf0 marked 3 inline comments as done.
http://reviews.llvm.org/D17990
Files:
clang-tidy/modernize/DeprecatedHeadersCheck.cpp
docs/clang-tidy/checks/modernize-deprecated-headers.rst
test/clang-tidy/modernize-deprecated-headers-cxx03.cpp
test/
omtcyf0 added a comment.
resolved small problems
http://reviews.llvm.org/D17990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
In http://reviews.llvm.org/D21603#475011, @bkramer wrote:
> In the future I'd prefer to have patches like this split up in a part that
> refactors and a part that contains the actual change. Having that in one
> patch makes it really hard to review.
Acknowledged. I'm s
hokein updated this revision to Diff 62849.
hokein marked 2 inline comments as done.
hokein added a comment.
Address Ben's comments.
http://reviews.llvm.org/D21603
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/SymbolIndexManager.cpp
include-fixe
rmaprath updated this revision to Diff 62847.
rmaprath added a comment.
Improve comment. NFC.
http://reviews.llvm.org/D21968
Files:
CMakeLists.txt
include/__config
include/__config_site.in
include/__threading_support
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/test/config.p
rmaprath marked 2 inline comments as done.
rmaprath added a comment.
http://reviews.llvm.org/D21968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 117 matches
Mail list logo
