Author: djasper
Date: Tue Oct 11 01:13:18 2016
New Revision: 283853
URL: http://llvm.org/viewvc/llvm-project?rev=283853&view=rev
Log:
Explicitly ignore return code in test for test systems that use pipefail
Modified:
cfe/trunk/test/Driver/show-option-names.c
Modified: cfe/trunk/test/Driver/s
vsk added inline comments.
Comment at: test/Preprocessor/dump_include.c:3
+// RUN: %clang_cc1 -w -E -dI -isystem %S %s -o - | grep '^#include *"dump_'
+// RUN: %clang_cc1 -w -E -dI -isystem %S %s -o - | grep '^#include_next
*"dump_'
+// RUN: %clang_cc1 -w -E -dI -isystem %S -ima
- Original Message -
> From: "Justin Lebar"
> To: "Hal Finkel"
> Cc: "Clang Commits"
> Sent: Saturday, October 8, 2016 10:56:37 PM
> Subject: Re: r283680 - [CUDA] Support and std::min/max on the
> device.
>
> > > The fix is not as simple as simply changing our implementation of
> > e.
hfinkel added a comment.
In https://reviews.llvm.org/D25403#565603, @jlebar wrote:
> Although these pass the CUDA test-suite tests (which I haven't yet committed
> because they're broken without this change), I could use some help running
> the libcxx tests.
>
> I cannot find any documentation
rsmith added a comment.
It sounds like this will hinder our ability to typo-correct to builtins. I
think we only want to suppress implicitly declaring *library* builtins here
(those that are expected to be provided by a header), not all builtins.
https://reviews.llvm.org/D25458
agutowski added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:800
+ case Builtin::BI_byteswap_ulong:
+ case Builtin::BI_byteswap_uint64:
case Builtin::BI__builtin_bswap16:
thakis wrote:
> Is this an unrelated change?
Yeah, mostly - I had to fix this
elsteveogrande added a comment.
cc a few more devs who have dealt with frontend lately and might be familiar
with this part. :)
https://reviews.llvm.org/D25153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
thakis added a comment.
rtrieu: Is there some global "are we in typo correction?" bit somewhere already?
Comment at: lib/CodeGen/CGBuiltin.cpp:800
+ case Builtin::BI_byteswap_ulong:
+ case Builtin::BI_byteswap_uint64:
case Builtin::BI__builtin_bswap16:
Is
Author: hfinkel
Date: Mon Oct 10 20:05:45 2016
New Revision: 283839
URL: http://llvm.org/viewvc/llvm-project?rev=283839&view=rev
Log:
Fixup test/Driver/opt-record.c for nvptx pointer size
On some systems, it looks like nvptx is used instead of nvptx64.
Modified:
cfe/trunk/test/Driver/opt-rec
majnemer added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8795-8798
+if (S.Diags.getDiagnosticLevel(
+diag::warn_typecheck_vector_element_sizes_not_equal, Loc) ==
+DiagnosticsEngine::Level::Error)
+ return Qual
agutowski created this revision.
agutowski added reviewers: rnk, hans, majnemer, thakis.
agutowski added a subscriber: cfe-commits.
Declarations for the builtins were created when suspected of being corrections
for a typo. That could trigger some absurd warnings about missing headers.
https://r
Author: hfinkel
Date: Mon Oct 10 19:26:09 2016
New Revision: 283834
URL: http://llvm.org/viewvc/llvm-project?rev=283834&view=rev
Log:
Add an option to save the backend-produced YAML optimization record to a file
The backend now has the capability to save information from optimizations, the
same i
Author: jlebar
Date: Mon Oct 10 19:23:53 2016
New Revision: 283833
URL: http://llvm.org/viewvc/llvm-project?rev=283833&view=rev
Log:
[Sema] Add explicit move constructor for ExpressionEvaluationContextRecord.
This is needed to keep MSVC 2013 happy.
Modified:
cfe/trunk/include/clang/Sema/Sema
Author: rsmith
Date: Mon Oct 10 19:21:10 2016
New Revision: 283830
URL: http://llvm.org/viewvc/llvm-project?rev=283830&view=rev
Log:
Aligned allocation versus CUDA: make deallocation function preference order
match other CUDA preference orders, per discussion with jlebar. We now model
this in an a
hfinkel added a comment.
In https://reviews.llvm.org/D25225#566854, @rsmith wrote:
> As discussed on IRC, I have a mild concern about using
> `-fsave-optimization-record` (with no argument) to enable the feature, and
> `-fsave-optimization-record=X` to enable the feature and specify a filename;
bruno closed this revision.
bruno added a comment.
Committed r283827
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-NO-SHOW-OPTION-NAMES %s
+// CH
rsmith added a comment.
As discussed on IRC, I have a mild concern about using
`-fsave-optimization-record` (with no argument) to enable the feature, and
`-fsave-optimization-record=X` to enable the feature and specify a filename; in
most (but not all) cases, `-option arg` and `-option=arg` mea
Author: bruno
Date: Mon Oct 10 19:01:22 2016
New Revision: 283827
URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev
Log:
[Driver][Diagnostics] Make 'show option names' default for driver warnings
Currently, driver level warnings do not show option names (e.g. warning:
complain about fo
manmanren added a comment.
Nice cleanup! Thanks for working on this,
Manman
Comment at: include/clang/Sema/DelayedDiagnostic.h:232
union {
/// Deprecation
struct DD DeprecationData;
Can you update this comment now we have generalized this to handl
jbangert updated this revision to Diff 74187.
jbangert marked 15 inline comments as done.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/NamespaceAliaser.cpp
clang-tidy/utils/NamespaceAliaser.h
clang-tidy/utils/UsingInse
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Lgtm, with one potential nit.
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | Fi
bruno updated this revision to Diff 74185.
bruno added a comment.
Update after Vedant's review!
https://reviews.llvm.org/D24516
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Frontend/CompilerInvocation.cpp
test/Driver/show-option-names.c
Index: test/Driver/show-option-names.c
=
Author: mehdi_amini
Date: Mon Oct 10 18:24:16 2016
New Revision: 283819
URL: http://llvm.org/viewvc/llvm-project?rev=283819&view=rev
Log:
Fix clang-tools-extra build after r283815 (Store FileEntry::Filename as a
StringRef instead of raw pointer)
Modified:
clang-tools-extra/trunk/clang-apply
jhen added a comment.
I just found and fixed another bug in this patch. Before, I wasn't using the
spelling location for the fixit hint. This meant that a macro argument that was
expanded to two locations, for example, would have the same fixit hint applied
to it twice. My new test case verifie
jhen updated this revision to Diff 74184.
jhen added a comment.
- Prevent multiple fixes for macro expansion
https://reviews.llvm.org/D25450
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifi
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL283543.
https://reviews.llvm.org/D25210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283777.
https://reviews.llvm.org/D25244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mehdi_amini
Date: Mon Oct 10 17:52:47 2016
New Revision: 283815
URL: http://llvm.org/viewvc/llvm-project?rev=283815&view=rev
Log:
Store FileEntry::Filename as a StringRef instead of raw pointer (NFC)
Modified:
cfe/trunk/include/clang/Basic/FileManager.h
cfe/trunk/lib/Basic/FileMan
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Closed in rL283788.
Repository:
rL LLVM
https://reviews.llvm.org/D25414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/AST/Decl.h:1222
+ void demoteThisDefinitionToDeclaration() {
+assert (!isThisDeclarationADemotedDefinition() && "Aleady demoted!");
+as
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/1f062cda84f537547021640c8bcd9c589c418d96
https://reviews.llvm.org/D25405
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/7c4b8c0a7921b999f5a73d6ba47ee8350676f747
https://reviews.llvm.org/D25420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/7b7c816e52feba6f89acde8b43bb0d67b5042697
https://reviews.llvm.org/D25421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/dd0969a0ae3b6421685a9d78953bb1127a8cfe9c
https://reviews.llvm.org/D25422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
https://github.com/llvm-mirror/clang/commit/be96a853a5dd33cce210617fb11575d33df7
https://reviews.llvm.org/D25423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jlebar closed this revision.
jlebar added a comment.
Phab seemed to be having trouble closing revisions today.
https://github.com/llvm-mirror/clang/commit/c4e9e7b35a2d113c8aa3bcdaf858c5bac4d78b03
https://reviews.llvm.org/D25424
___
cfe-commits mail
jlebar accepted this revision.
jlebar added a reviewer: jlebar.
jlebar marked an inline comment as done.
jlebar added a comment.
This revision is now accepted and ready to land.
https://github.com/llvm-mirror/clang/commit/b28828e8b38c7e208386f783e6502305c42cb479
https://reviews.llvm.org/D25427
jhen added a comment.
I found a bug in my first patch that I have fixed now. I was trying to iterate
over the source range by using `SourceLocation::getLocWithOffset`, but I
realized that doesn't work, so I removed it and went back to the original
method of checking `SourceRange.getBegin().isMa
jhen updated this revision to Diff 74181.
jhen added a comment.
- Return to original checking for macro in range
https://reviews.llvm.org/D25450
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-iden
Author: adrian
Date: Mon Oct 10 16:56:20 2016
New Revision: 283810
URL: http://llvm.org/viewvc/llvm-project?rev=283810&view=rev
Log:
[Driver] Let -gline-tables-only win when it comes after -gmodules.
The -gmodules option is all about putting debug type info into clang
modules and for line tables t
vsk added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:965
+ Opts.ShowOptionNames = Args.hasArg(OPT_fdiagnostics_show_option) ||
+ (DefaultShowOpt && !Args.hasArg(OPT_fno_diagnostics_show_option));
Does it make sense to use: hasFlag (O
bruno added a reviewer: vsk.
bruno added a comment.
Ping!!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > Besides `__ext_vector_typ
Author: marshall
Date: Mon Oct 10 16:37:16 2016
New Revision: 283804
URL: http://llvm.org/viewvc/llvm-project?rev=283804&view=rev
Log:
Mark 2777 as complete
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
Author: mehdi_amini
Date: Mon Oct 10 16:34:29 2016
New Revision: 283802
URL: http://llvm.org/viewvc/llvm-project?rev=283802&view=rev
Log:
Change Builtins name to be stored as StringRef instead of raw pointers (NFC)
Modified:
cfe/trunk/include/clang/Basic/Builtins.h
cfe/trunk/lib/CodeGen/C
Author: vitalybuka
Date: Mon Oct 10 16:31:50 2016
New Revision: 283801
URL: http://llvm.org/viewvc/llvm-project?rev=283801&view=rev
Log:
Add -fno-sanitize-address-use-after-scope flag
Reviewers: eugenis
Differential Revision: https://reviews.llvm.org/D25453
Modified:
cfe/trunk/include/clang
vitalybuka updated this revision to Diff 74176.
vitalybuka added a comment.
resolved comments
https://reviews.llvm.org/D25453
Files:
include/clang/Driver/Options.td
lib/Driver/SanitizerArgs.cpp
lib/Frontend/CompilerInvocation.cpp
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
vitalybuka marked an inline comment as done.
vitalybuka added inline comments.
Comment at: test/Driver/fsanitize.c:124
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=address %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-ASAN-WITHOUT-USE-AFTER-SCOPE
+// CHECK-ASAN-WITHOUT
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
mgorny wrote:
> bruno wrote:
> > You should kee
jlebar added a comment.
Heh, all right. So long as I didn't screw anything up, I'm happy with it being
a mystery.
https://reviews.llvm.org/D25426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko added a comment.
Look like problem with Phabricator itself. I noticed several other reviews
which were not closed with valid reference to review in commit summary.
Weirdly, **https://reviews.llvm.org/diffusion/L/** prefix doesn't work too.
https://reviews.llvm.org/D25426
jlebar added a comment.
Do you know why phab didn't pick up this change when I pushed it?
https://reviews.llvm.org/D25426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
bruno wrote:
> You should keep using the VFS t
Galina, I've already reverted the offending changes in iterator.h.
The MSVC build is now broken due to a different change.
Sorry for the noise (but not really sorry, MSVC shouldn't crash :).
On Mon, Oct 10, 2016 at 2:15 PM, Galina Kistanova wrote:
> Hello Justin,
>
> Some of your resent commits
Hello Justin,
Some of your resent commits broke the next builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12710
Please have a look at it?
Thanks
Galina
On Mon, Oct 10, 2016 at 9:26 AM, Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org
Author: marshall
Date: Mon Oct 10 16:00:12 2016
New Revision: 283799
URL: http://llvm.org/viewvc/llvm-project?rev=283799&view=rev
Log:
Update with the rest of the results from the 7-Oct Telecom
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
aaron.ballman added inline comments.
Comment at: test/clang-tidy/misc-unused-using-decls.cpp:191
+// n::N is using in the explicit template instantiations.
+template void h(n::M* t);
Can you add a test using a non-type template argument, like an integer literal?
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/CompilerInvocation.cpp:739
+ UasArg &&
+ UasArg->getOption().matches(OPT_fsanitize_address_use_after_scope);
Opts.SSPBufferSize =
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283774.
https://reviews.llvm.org/D25426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283785.
https://reviews.llvm.org/D25353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283793.
https://reviews.llvm.org/D25442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added inline comments.
Comment at: CMakeLists.txt:198
+set(CLANG_DEFAULT_LINKER "" CACHE STRING
+ "Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform
default")
mgorny wrote:
> Is there a reason not to allow using the absolute path
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
limited_allocator must grant friendship in order to be rebindable. Found by
MSVC, which rebinds allocators in more situations than libc++ does.
This raises an interesting ques
jhen added a comment.
alexfh, sorry if you are not the right person to review this change. I based my
choice on this history of this file.
https://reviews.llvm.org/D25450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
jhen created this revision.
jhen added a reviewer: alexfh.
jhen added a subscriber: cfe-commits.
Herald added a subscriber: jlebar.
clang-tidy should fix identifier naming even when the identifier is
referenced inside a macro expansion, provided that the identifier enters
the macro expansion compl
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
Abandoning, as this machinery has been replaced.
https://reviews.llvm.org/D22973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
CaseyCarter abandoned this revision.
CaseyCarter added a comment.
Ignoring the assignment from in_place_t issue for now, r283606 is good modulo a
couple of tiny things that I'll just email you directly.
https://reviews.llvm.org/D25249
___
cfe-commi
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:378
+ Lexer::getLocForEndOfToken(Range.getEnd(), 0, SM,
Context->getLangOpts());
+ bool Whitespace = isWhitespace(*FullSourceLoc(Next, SM).getCharacterData());
+
malcolm
dim created this revision.
dim added reviewers: EricWF, emaste, rsmith, theraven.
dim added a subscriber: cfe-commits.
On FreeBSD, for ABI compatibility reasons, the pair trivial copy
constructor is disabled, using the aptly-named
`_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR` define.
Di
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D25308#566176, @arphaman wrote:
> The updated patch now makes clang warn every time it encounters this
> attribute in C++ mode. Would that be the desi
I don't see any .ll files for the tests. I see the directory
build/tools/clang/test/OpenMP/Output has a bunch of .script and .tmp(binary
files), but no obvious .ll files.
-Original Message-
From: Alexey Bataev [mailto:a.bat...@hotmail.com]
Sent: Monday, October 10, 2016 1:22 PM
To: Ke
ahatanak accepted this revision.
ahatanak added a comment.
LGTM with a few nits.
Please fix lib/Headers/intrin.h too and commit it as a separate patch.
Comment at: lib/Sema/SemaStmtAsm.cpp:142
+// Extracting the register name from the Expression value,
+// if there is no regis
I mean, could you send new .ll files, which you get after these changes?
Best regards,
Alexey Bataev
> 10 окт. 2016 г., в 22:26, Keane, Erich написал(а):
>
> Sure, attached. So far, there are a few changes that seem curious and
> concerning. A few cases of loads going missing, and a few more
Author: nicholas
Date: Mon Oct 10 15:07:13 2016
New Revision: 283795
URL: http://llvm.org/viewvc/llvm-project?rev=283795&view=rev
Log:
Make the LValue created in EmitValueForIvarAtOffset have the same Qualifiers in
the LValue as the QualType in the LValue. No functionality change intended.
Modif
LGTM
> On Oct 9, 2016, at 2:39 PM, Nick Lewycky via cfe-commits
> wrote:
>
> The attached patch makes the LValue created in EmitValueForIvarAtOffset have
> the same Qualifiers in the LValue as the QualType in the LValue. Noticed when
> auditing for reasons the QualType would different from th
thakis added a comment.
I noticed that using this slows down clang-format about 300% --
https://llvm.org/bugs/show_bug.cgi?id=30656
Repository:
rL LLVM
https://reviews.llvm.org/D10840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:252-254
+ anyOf(hasType(autoType()),
+hasType(pointerType(pointee(autoType(,
+hasType(referenceType(pointee(autoType())
vsk created this revision.
vsk added reviewers: pcc, rjmccall.
vsk added subscribers: krasin, cfe-commits.
ubsan reports a false positive 'invalid member call' diagnostic on the
following example (PR30478):
struct Base1 {
virtual int f1() { return 1; }
};
struct Base2 {
virtual i
zaks.anna added a comment.
I am in support of this as well.
https://reviews.llvm.org/D25429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: agutowski
Date: Mon Oct 10 14:40:51 2016
New Revision: 283793
URL: http://llvm.org/viewvc/llvm-project?rev=283793&view=rev
Log:
Implement MS read/write barriers and __faststorefence intrinsic
Reviewers: hans, rnk, majnemer
Subscribers: cfe-commits
Differential Revision: https://reviews.
manmanren added a comment.
This is a nice cleanup!
Manman
Comment at: lib/Sema/SemaDeclAttr.cpp:6348
+
+ auto IsContextGreater = [&](const Decl *C) {
+if (K == AR_NotYetIntroduced) {
Can you add a comment for the lambda?
Comment at: lib
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
Yes, this looks good to me. For trunk r283783, this brought the number of
unexpected failures down from 61 to 41. Tests fixed by this change:
libc++ :: std/algorithms/alg.sorting/alg.min.max/min
malcolm.parsons updated this revision to Diff 74163.
malcolm.parsons added a comment.
Really mention in release notes.
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/modernize-
alexfh added a comment.
The change seems to be reasonable, and the size increase is not huge. However,
I'm not sure who should make the call.
https://reviews.llvm.org/D25429
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: jlebar
Date: Mon Oct 10 14:26:22 2016
New Revision: 283790
URL: http://llvm.org/viewvc/llvm-project?rev=283790&view=rev
Log:
[AST] Don't use make_pointee_iterator in VTableBuilder.
Our implementation of make_pointee_iterator seems to be causing MSVC
2015 to crash, so I'm going to remove i
malcolm.parsons updated this revision to Diff 74162.
malcolm.parsons added a comment.
Use std::function
https://reviews.llvm.org/D25316
Files:
clang-tidy/modernize/UseAutoCheck.cpp
clang-tidy/modernize/UseAutoCheck.h
docs/clang-tidy/checks/modernize-use-auto.rst
test/clang-tidy/moderniz
majnemer added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7610
+Value *SizeVal = EmitScalarExpr(E->getArg(2));
+EmitNonNullArgCheck(RValue::get(Dest.getPointer()),
E->getArg(0)->getType(),
+E->getArg(0)->getExprLoc(), FD, 0);
-
- Original Message -
> From: "Richard Smith"
> To: reviews+d25308+public+96c9b20dd11b9...@reviews.llvm.org, "Hal
> Finkel"
> Cc: "Alex L" , "Reid Kleckner" ,
> "Aaron Ballman" , "cfe-commits"
>
> Sent: Monday, October 10, 2016 2:16:13 PM
> Subject: Re: [PATCH] D25308: [Sema] Ignore tran
rSerge added a comment.
I have extended this feature to check for OS support too (currently Linux
only). I can't commit it so far because I don't know how to implement a test.
XFAIL cannot check for both CPU and OS: it can only check for one of them. I
tried to implement 2 tests instead like th
alexfh updated this revision to Diff 74160.
alexfh marked 6 inline comments as done.
alexfh added a comment.
Herald added subscribers: mgorny, beanz.
- Addressed review comments
https://reviews.llvm.org/D24572
Files:
clang-tidy/CMakeLists.txt
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyD
Could you send the new results for these tests?
Best regards,
Alexey Bataev
On 10/10/2016 09:22 PM, Keane, Erich wrote:
> This causes a massive number of openmp test failures (obviously), and I'm not
> terribly comfortable with how OpenMP works. I can update the tests (and
> will), but would l
On Mon, Oct 10, 2016 at 10:45 AM, Hal Finkel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hfinkel added a comment.
>
> In https://reviews.llvm.org/D25308#566176, @arphaman wrote:
>
> > The updated patch now makes clang warn every time it encounters this
> attribute in C++ mode. Would tha
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:39
+ bool MultiVar = false;
+ if (const auto *VD = dyn_cast(D)) {
+if (VD && VD->getPrevi
agutowski marked 2 inline comments as done.
agutowski added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:7610
+Value *SizeVal = EmitScalarExpr(E->getArg(2));
+EmitNonNullArgCheck(RValue::get(Dest.getPointer()),
E->getArg(0)->getType(),
+
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
agutowski updated this revision to Diff 74157.
agutowski added a comment.
remove nullptr check; don't repeat EmitScalarExpr
https://reviews.llvm.org/D25334
Files:
include/clang/Basic/BuiltinsX86.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/ms-intrinsics.c
test/Heade
Author: rsmith
Date: Mon Oct 10 13:54:32 2016
New Revision: 283789
URL: http://llvm.org/viewvc/llvm-project?rev=283789&view=rev
Log:
Re-commit r283722, reverted in r283750, with a fix for a CUDA-specific use of
past-the-end iterator.
Original commit message:
P0035R4: Semantic analysis and code g
Author: phosek
Date: Mon Oct 10 13:53:32 2016
New Revision: 283788
URL: http://llvm.org/viewvc/llvm-project?rev=283788&view=rev
Log:
[libcxx] Add support for Fuchsia
Fuchsia is a new operating system which uses musl as the standard
C library, libc++ and libc++abi as the C++ standard library.
Dif
Hi Galina,
Hmm, this sounds strange to me, because this commit has been instantly
reverted three days ago (replaced with correct code later), and current
errors on this buildbot do not seem to be related.
On 10/10/16 9:36 PM, Galina Kistanova wrote:
Hi Artem,
This revision broke one our our
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:331
+void UseAutoCheck::replaceExpr(const DeclStmt *D, ASTContext *Context,
+ Ty
1 - 100 of 233 matches
Mail list logo
