[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

rjmccall added a comment. Well, internal and external types are important cases. I'm fine with this. It's a pity that we can't express what we want with aliases, though. Repository: rC Clang https://reviews.llvm.org/D46685 ___ cfe-commits

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

rjmccall added a comment. I agree that the new-expression case doesn't use the destructor, and all the other cases of list-initialization presumably use the destructor for the initialized type for separate reasons. Ok. Comment at:

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

phosek added a comment. Applied, thanks so much for looking into it. Repository: rC Clang https://reviews.llvm.org/D46910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple

phosek updated this revision to Diff 147431. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D46910 Files: clang/lib/Frontend/CompilerInvocation.cpp llvm/cmake/modules/GetHostTriple.cmake llvm/lib/Support/Unix/Host.inc

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

rsmith added a comment. As it happens, the C++ committee fixed the language wording hole here very recently. The new rule can be found here: http://wg21.link/p0968r0#2227 In summary: we should to consider the destructor for all elements of the aggregate to be potentially-invoked. @rjmccall

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

dberris added a comment. In https://reviews.llvm.org/D46998#1103397, @dblaikie wrote: > "In the future we can revisit this when we have a better idea as to why not > depending on the C++ ABI functionality is a better solution." - this was > discussed previously in the thread linked from the

[PATCH] D45898: [SemaCXX] Mark destructor as referenced

ahatanak added a comment. Richard and Doug, do you have any thoughts on John's suggestion? Comment at: test/CodeGenObjCXX/arc-list-init-destruct.mm:1 +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.13.0 -std=c++1z -fobjc-arc -fobjc-exceptions -fcxx-exceptions -fexceptions

[PATCH] D47044: Ensure that we only visit a destructor for a reference if type information is available.

NoQ added a comment. Mmm, i think loop widening simply shouldn't invalidate references (though it should invalidate objects bound to them). Simply because you can't really reassign a reference. Could we mark them as "preserve contents", like in https://reviews.llvm.org/D45491? Repository:

[PATCH] D47044: Ensure that we only visit a destructor for a reference if type information is available.

ormris created this revision. ormris added reviewers: dcoughlin, NoQ, xazax.hun, george.karpenkov. Herald added a subscriber: rnkovacs. Loop widening can invalidate an object reference. If the analyzer attempts to visit the destructor to a non-existent object it will crash. This patch ensures

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. Eric, do you have more thoughts on this issue? Repository: rC Clang https://reviews.llvm.org/D45015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 147406. leonardchan marked an inline comment as done. leonardchan added a comment. Undid git-clang-formatting on ASTBitcodes.h Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h

[libclc] r332677 - Add initial support for half precision builtins

Author: jvesely Date: Thu May 17 15:55:30 2018 New Revision: 332677 URL: http://llvm.org/viewvc/llvm-project?rev=332677=rev Log: Add initial support for half precision builtins v2: fix fmax implementation use consistent checks for __CLC_FP_SIZE add missing TODOs fix whitespace in

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Index/USRGeneration.cpp:691 +case BuiltinType::ULongAccum: + llvm_unreachable("No USR name mangling for fixed point types."); case BuiltinType::Float16:

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 147400. leonardchan added a comment. Added break. We still assign `Result` since it cannot be null at the end of the switch stmt, though the value doesn't matter. Added character `~` to indicate fixed point type followed by string detailing the type. I

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. I admit I do not due to much longer compilation time, I ll recompile all with and will see tomorrow if I can reproduce. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

alexfh added a comment. In https://reviews.llvm.org/D45177#1103774, @devnexen wrote: > In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > > > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. > > > I was unable to reproduce both FreeBSD and Linux. Plus my changes come

r332675 - Support: Add a raw_ostream::write_zeros() function. NFCI.

Author: pcc Date: Thu May 17 15:11:43 2018 New Revision: 332675 URL: http://llvm.org/viewvc/llvm-project?rev=332675=rev Log: Support: Add a raw_ostream::write_zeros() function. NFCI. This will eventually replace MCObjectWriter::WriteZeros. Part of PR37466. Differential Revision:

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1103162, @alexfh wrote: > See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. I was unable to reproduce both FreeBSD and Linux. Plus my changes come after checkNonNull. Repository: rC Clang

[PATCH] D44954: [clangd] Add "member" symbols to the index

ioeric added a comment. > It's also for textDocument/documentSymbol. For this, we technically don't > need them in the static index since we could collect symbols when the > document is opened, but we also want them for workspaceSymbols so we might as > well use the same symbol collector, etc.

Re: r332639 - Fix a mangling failure on clang-cl C++17

Thanks! Added in 332646 On Thu, May 17, 2018 at 11:30 AM Nico Weber wrote: > You might've forgotten to svn add the test :-) > > On Thu, May 17, 2018, 2:16 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Thu May 17 11:12:18

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

leonardchan updated this revision to Diff 147386. leonardchan added a comment. Ran git-clang-tidy on all affected files Repository: rC Clang https://reviews.llvm.org/D46084 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def

[PATCH] D44954: [clangd] Add "member" symbols to the index

malaperle added a comment. In https://reviews.llvm.org/D44954#1102807, @ilya-biryukov wrote: > A few questions regarding class members. To pinpoint some interesting cases > and agree on how we want those to behave in the long run. > > How do we handle template specializations? What will the

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

rja added inline comments. Comment at: clang-doc/generators/MDGenerator.cpp:57 + sys::path::native(NamespacesPath, Path); + // for (const auto : I->Namespace) + // sys::path::append(Path, IS->find(Namespace)->Name); remove commented code? Repository:

[PATCH] D46994: [test-suite] Test CUDA in C++14 mode with C++11 stdlibs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332659: [test-suite] Test CUDA in C++14 mode with C++11 stdlibs. (authored by jlebar, committed by ). Changed prior to commit: https://reviews.llvm.org/D46994?vs=147225=147383#toc Repository: rL

[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL332660: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved. (authored by jlebar, committed by ). Repository: rL LLVM

[PATCH] D46994: [test-suite] Test CUDA in C++14 mode with C++11 stdlibs.

jlebar marked an inline comment as done. jlebar added a comment. Thanks for the reviews, Art. Submitting with this change... Repository: rT test-suite https://reviews.llvm.org/D46994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.

jlebar marked an inline comment as done. jlebar added inline comments. Comment at: External/CUDA/complex.cu:24 // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L || STDLIB_VERSION >= 2014) +#if

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

devnexen added a comment. In https://reviews.llvm.org/D47007#1103551, @george.karpenkov wrote: > Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ? Nope. more for last NoQ comment. Will try for this one once I finish setting it up. Repository: rC Clang

[PATCH] D46472: [HIP] Support offloading by linker script

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM except for minor suggestions. Comment at: lib/CodeGen/CGCUDANV.cpp:361-373 + if (IsHIP) +FatbinConstantName = ".hip_fatbin"; + else if (RelocatableDeviceCode)

[PATCH] D47030: [Fixed Point Arithmetic] Checks for Precision Macros

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. Herald added a subscriber: mgorny. This patch includes checks that the precision macros used for the fixed point fractional and integral bits meet the requirements

[PATCH] D47007: [Sanitizer] CStringChecker fix for strlcpy when no bytes are copied to the dest buffer

george.karpenkov added a comment. Is it a fix for https://bugs.llvm.org/show_bug.cgi?id=37503 ? Repository: rC Clang https://reviews.llvm.org/D47007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47029: [X86] Remove some preprocessor feature checks from intrinsic headers

craig.topper created this revision. craig.topper added reviewers: echristo, RKSimon, spatel. These look to be a couple things that weren't remvoed when we switched to target attribute. The popcnt makes including just smmintrin.h also include popcntintrin.h. The popcnt file itself already

[PATCH] D47028: [clang-format/ObjC] Correctly annotate single-component ObjC method invocations

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. Previously, clang-format's parser would fail to annotate the selector in a single-component Objective-C method invocation with `TT_SelectorName`. For example, the

[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

kimgr added a comment. >> Can you test what happens when you do clang-cl.exe /Yc stdafx.h /Tp >> stdafx.h, i.e. compile the header > > directly as C++ code and generate .pch from it? The normal MSVC modus > operandi is to have stdafx.h > > included in all source files (with /Yu) and

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

yaxunl added a comment. ping https://reviews.llvm.org/D45212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46472: [HIP] Support offloading by linker script

yaxunl added a comment. ping https://reviews.llvm.org/D46472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46476: [HIP] Add action builder for HIP

yaxunl added a comment. ping https://reviews.llvm.org/D46476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332646 - Add missing test case for r332639

Author: rnk Date: Thu May 17 11:34:05 2018 New Revision: 332646 URL: http://llvm.org/viewvc/llvm-project?rev=332646=rev Log: Add missing test case for r332639 Added: cfe/trunk/test/CodeGenCXX/PR37481.cpp Added: cfe/trunk/test/CodeGenCXX/PR37481.cpp URL:

Re: r332639 - Fix a mangling failure on clang-cl C++17

You might've forgotten to svn add the test :-) On Thu, May 17, 2018, 2:16 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu May 17 11:12:18 2018 > New Revision: 332639 > > URL: http://llvm.org/viewvc/llvm-project?rev=332639=rev > Log: > Fix a

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

dblaikie added a comment. "In the future we can revisit this when we have a better idea as to why not depending on the C++ ABI functionality is a better solution." - this was discussed previously in the thread linked from the bug. A big thing, so far as I understand it, is that Clang doesn't

[PATCH] D46918: [Coverage] Discard the last uncompleted deferred region in a decl

vsk updated this revision to Diff 147360. vsk added a comment. - Add a regression test for switches. https://reviews.llvm.org/D46918 Files: lib/CodeGen/CoverageMappingGen.cpp test/CoverageMapping/deferred-region.cpp test/CoverageMapping/label.cpp test/CoverageMapping/moremacros.c

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

This revision was automatically updated to reflect the committed changes. Closed by commit rC332639: Fix a mangling failure on clang-cl C++17 (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D46929?vs=147244=147359#toc Repository: rC Clang

r332639 - Fix a mangling failure on clang-cl C++17

Author: rnk Date: Thu May 17 11:12:18 2018 New Revision: 332639 URL: http://llvm.org/viewvc/llvm-project?rev=332639=rev Log: Fix a mangling failure on clang-cl C++17 MethodVFTableLocations in MigrosoftVTableContext contains canonicalized decl. But, it's sometimes asked to lookup for

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

This revision was automatically updated to reflect the committed changes. Closed by commit rC332635: [sanitizer] Dont add --export-dynamic for Myriad (authored by waltl, committed by ). Changed prior to commit: https://reviews.llvm.org/D46452?vs=147233=147355#toc Repository: rC Clang

r332635 - [sanitizer] Don't add --export-dynamic for Myriad

Author: waltl Date: Thu May 17 11:04:39 2018 New Revision: 332635 URL: http://llvm.org/viewvc/llvm-project?rev=332635=rev Log: [sanitizer] Don't add --export-dynamic for Myriad This is to work around a bug in some versions of gnu ld, where --export-dynamic implies -shared even if -static is

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

thakis added a comment. Please do, tzik doesn't have commit access yet. Repository: rC Clang https://reviews.llvm.org/D46929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Shall I go ahead and commit this for you? Comment at: lib/AST/VTableBuilder.cpp:2507 const MethodInfo = I.second; + assert(MD == MD->getCanonicalDecl()); +

[PATCH] D46995: [test-suite] Enable CUDA complex tests with libc++ now that D25403 is resolved.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: External/CUDA/complex.cu:24 // libstdc++ (compile errors in ). -#if __cplusplus >= 201103L && !defined(_LIBCPP_VERSION) && \ -(__cplusplus < 201402L ||

[PATCH] D46994: [test-suite] Test CUDA in C++14 mode with C++11 stdlibs.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: External/CUDA/CMakeLists.txt:339-345 # Same as above, but for libc++ # Tell clang to use libc++ # We also need to add compiler's include

[PATCH] D46550: Support Swift calling convention for PPC64 targets

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D46550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46485: Add python tool to dump and construct header maps

dexonsmith added inline comments. Comment at: test/Preprocessor/headermap-rel.c:2-3 // This uses a headermap with this entry: // Foo.h -> Foo/Foo.h Should we delete this comment now that the header map is human-readable? Comment at:

[PATCH] D46881: [X86][CET] Changing -fcf-protection behavior to comply with gcc (clang part)

craig.topper added a comment. LGTM https://reviews.llvm.org/D46881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332621 - [CUDA] Allow "extern __shared__ Foo foo[]" within anon. namespaces.

Author: jlebar Date: Thu May 17 09:15:07 2018 New Revision: 332621 URL: http://llvm.org/viewvc/llvm-project?rev=332621=rev Log: [CUDA] Allow "extern __shared__ Foo foo[]" within anon. namespaces. Summary: Previously this triggered a -Wundefined-internal warning. But it's not an undefined

[PATCH] D46782: [CUDA] Allow "extern __shared__ Foo foo[]" within anon. namespaces.

This revision was automatically updated to reflect the committed changes. Closed by commit rC332621: [CUDA] Allow extern __shared__ Foo foo[] within anon. namespaces. (authored by jlebar, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang-tools-extra] r332620 - Disable a failing clang-move test on windows.

Author: ioeric Date: Thu May 17 09:13:36 2018 New Revision: 332620 URL: http://llvm.org/viewvc/llvm-project?rev=332620=rev Log: Disable a failing clang-move test on windows. This was broken by r332590 but is likely caused by a bug in clang-move.

[PATCH] D46993: [CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib.

This revision was automatically updated to reflect the committed changes. Closed by commit rC332619: [CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib. (authored by jlebar, committed by ). Changed prior to commit:

r332619 - [CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib.

Author: jlebar Date: Thu May 17 09:12:42 2018 New Revision: 332619 URL: http://llvm.org/viewvc/llvm-project?rev=332619=rev Log: [CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib. Reviewers: rsmith Subscribers: sanjoy, cfe-commits, tra Differential Revision:

[PATCH] D46993: [CUDA] Make std::min/max work when compiling in C++14 mode with a C++11 stdlib.

jlebar added a comment. Thank you for the review! https://reviews.llvm.org/D46993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

alexfh added a comment. See https://bugs.llvm.org/show_bug.cgi?id=37503 for a test case. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46820: Fix __uuidof handling on non-type template parameter in C++17

thakis closed this revision. thakis added a comment. r332614, thanks! Repository: rC Clang https://reviews.llvm.org/D46820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332614 - Fix __uuidof handling on non-type template parameter in C++17

Author: nico Date: Thu May 17 08:26:37 2018 New Revision: 332614 URL: http://llvm.org/viewvc/llvm-project?rev=332614=rev Log: Fix __uuidof handling on non-type template parameter in C++17 Clang used to pass the base lvalue of a non-type template parameter to the template instantiation phase when

[PATCH] D44954: [clangd] Add "member" symbols to the index

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:113 - // We only want: - // * symbols in namespaces or translation unit scopes (e.g. no class - // members) - // * enum constants in unscoped enum decl (e.g. "red" in "enum {red};") - auto

[PATCH] D47017: [Fixed Point Arithmetic] Validation Test for Saturated Shift Left, Saturated Unsigned _Fract Types, and Fix for Saturated Unsigned Addition

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. This patch includes changes for the shift left operator involving saturated fixed point types. For unsigned shifting, overflow occurs if the number of bits we

[clang-tools-extra] r332612 - Second attempt to fix clang-move tests broken by r332590 on windows

Author: ioeric Date: Thu May 17 07:59:15 2018 New Revision: 332612 URL: http://llvm.org/viewvc/llvm-project?rev=332612=rev Log: Second attempt to fix clang-move tests broken by r332590 on windows http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12010 Add back a path

[PATCH] D47016: [Fixed Point Arithmetic] Validation Test for Saturated Division and Comparison Fix

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, jakehehrlich. leonardchan added a project: clang. This patch includes changes for division on saturated fixed point types. Overflow occurs when the resulting value cannot fit into the number of data bits for the

[PATCH] D46975: Implement deduction guides for `std::deque`

mclow.lists updated this revision to Diff 147317. mclow.lists added a comment. Added tests (and fix!) for the implicit deduction guides. https://reviews.llvm.org/D46975 Files: include/deque test/std/containers/sequences/deque/deque.cons/deduct.pass.cpp Index:

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov added inline comments. Comment at: clangd/Quality.cpp:24 + if (SemaCCResult.Declaration) +AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration); if (SemaCCResult.Availability == CXAvailability_Deprecated) ioeric wrote: > ioeric

[PATCH] D46685: [CodeGen] Disable structor optimizations at -O0

labath updated this revision to Diff 147315. labath added a comment. Updating with a new version of the patch. The problem with the previous version was that it caused us to use C5/https://reviews.llvm.org/D5 comdats very aggressively (at -O0), and this is not always correct. This uses a more

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ioeric added inline comments. Comment at: clangd/Quality.cpp:24 + if (SemaCCResult.Declaration) +AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration); if (SemaCCResult.Availability == CXAvailability_Deprecated) ioeric wrote: > ilya-biryukov

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ioeric added inline comments. Comment at: clangd/Quality.cpp:24 + if (SemaCCResult.Declaration) +AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration); if (SemaCCResult.Availability == CXAvailability_Deprecated) ilya-biryukov wrote: >

[clang-tools-extra] r332609 - [clang-tidy] Add a flag to enable alpha checkers

Author: alexfh Date: Thu May 17 07:04:27 2018 New Revision: 332609 URL: http://llvm.org/viewvc/llvm-project?rev=332609=rev Log: [clang-tidy] Add a flag to enable alpha checkers Summary: The alpha checkers can already be enabled using the clang driver, this allows them to be enabled using the

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL332609: [clang-tidy] Add a flag to enable alpha checkers (authored by alexfh, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D44954: [clangd] Add "member" symbols to the index

ioeric added a comment. In https://reviews.llvm.org/D44954#1101922, @malaperle wrote: > @ioeric You mentioned in https://reviews.llvm.org/D46751 that it would make > sense to add a flag to disable indexing members. Could you comment on that? > What kind of granularity were you thinking? Would

[PATCH] D46932: [AArch64] Correct inline assembly test case for S modifier [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rC332606: [AArch64] Correct inline assembly test case for S modifier [NFC] (authored by psmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D46932 Files:

[PATCH] D46867: [ASTImporter] Add unit tests for structural equivalence

martong updated this revision to Diff 147304. martong marked an inline comment as done. martong added a comment. - Address aleksei's comments Repository: rC Clang https://reviews.llvm.org/D46867 Files: unittests/AST/ASTImporterTest.cpp unittests/AST/CMakeLists.txt

r332606 - [AArch64] Correct inline assembly test case for S modifier [NFC]

Author: psmith Date: Thu May 17 06:17:33 2018 New Revision: 332606 URL: http://llvm.org/viewvc/llvm-project?rev=332606=rev Log: [AArch64] Correct inline assembly test case for S modifier [NFC] The existing test for the AArch64 inline assembly constraint S uses the A and L modifiers. These

[PATCH] D46867: [ASTImporter] Add unit tests for structural equivalence

martong marked 14 inline comments as done. martong added a comment. > Do you plan to enable this functionality for AST import checking? Yes. We'd like to test the structural equivalency independently from ASTImporter, because in certain cases it may have faulty behavior. This can be very handy

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov added inline comments. Comment at: clangd/AST.h:32 +/// Returns true iff all redecls of \p D are in the main file. +bool allDeclsInMainFile(const Decl *D); sammccall wrote: > Do you expect this to be reused? > If so, unit test? Otherwise this

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov updated this revision to Diff 147301. ilya-biryukov added a comment. - Move tests to QualityTests.cpp - Fix findDecl() assertion on redecls of the same thing - Fix file comment of TestTU.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46943 Files:

[clang-tools-extra] r332603 - Attempt to fix clang-move tests broken by r332590 on windows

Author: ioeric Date: Thu May 17 05:40:50 2018 New Revision: 332603 URL: http://llvm.org/viewvc/llvm-project?rev=332603=rev Log: Attempt to fix clang-move tests broken by r332590 on windows http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/12007 Modified:

[PATCH] D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r332588 - [ASTImporter] Fix missing implict CXXRecordDecl

Author: martong Date: Thu May 17 02:46:07 2018 New Revision: 332588 URL: http://llvm.org/viewvc/llvm-project?rev=332588=rev Log: [ASTImporter] Fix missing implict CXXRecordDecl Summary: Implicit CXXRecordDecl is not added to its DeclContext during import, but in the original AST it is. This

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. In https://reviews.llvm.org/D45177#1102887, @alexfh wrote: > This is reproducible in r332425. I posted this PR https://reviews.llvm.org/D47007 hopes it helps. Repository: rC Clang https://reviews.llvm.org/D45177 ___

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

This revision was automatically updated to reflect the committed changes. Closed by commit rL332598: Use dotted format of version tuple for availability diagnostics (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r332598 - Use dotted format of version tuple for availability diagnostics

Author: jkorous Date: Thu May 17 04:51:49 2018 New Revision: 332598 URL: http://llvm.org/viewvc/llvm-project?rev=332598=rev Log: Use dotted format of version tuple for availability diagnostics E. g. use "10.11" instead of "10_11". We are maintaining backward compatibility by parsing

[PATCH] D33440: clang-format: better handle statement macros

Typz updated this revision to Diff 147293. Typz marked an inline comment as done. Typz added a comment. Address review comments Repository: rC Clang https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h

[PATCH] D33440: clang-format: better handle statement macros

Typz marked an inline comment as done. Typz added inline comments. Comment at: lib/Format/Format.cpp:647-648 LLVMStyle.SortUsingDeclarations = true; + LLVMStyle.StatementMacros.push_back("Q_UNUSED"); + LLVMStyle.StatementMacros.push_back("QT_REQUIRE_VERSION");

[PATCH] D46881: [X86][CET] Changing -fcf-protection behavior to comply with gcc (clang part)

mike.dvoretsky updated this revision to Diff 147292. mike.dvoretsky added a comment. Removed the unused HasIBT variable declaration from X86.h. https://reviews.llvm.org/D46881 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added inline comments. Comment at: lib/CodeGen/CGException.cpp:1241-1245 +while (llvm::TerminatorInst *TI = RethrowBlock->getTerminator()) { + llvm::BranchInst *BI = cast(TI); + assert(BI->isConditional()); + RethrowBlock = BI->getSuccessor(1); +}

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

alexfh added a comment. This is reproducible in r332425. Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

alexfh added a comment. This patch seems to cause an assertion failure: assert.h assertion failed at clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:427 in clang::ento::SVal clang::ento::SValBuilder::evalBinOp(clang::ento::ProgramStateRef, BinaryOperator::Opcode, clang::ento::SVal,

[PATCH] D45900: CodeGen: Fix invalid bitcast for lifetime.start/end

This revision was automatically updated to reflect the committed changes. Closed by commit rL332593: CodeGen: Fix invalid bitcast for lifetime.start/end (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r332593 - CodeGen: Fix invalid bitcast for lifetime.start/end

Author: yaxunl Date: Thu May 17 04:16:35 2018 New Revision: 332593 URL: http://llvm.org/viewvc/llvm-project?rev=332593=rev Log: CodeGen: Fix invalid bitcast for lifetime.start/end lifetime.start/end expects pointer argument in alloca address space. However in C++ a temporary variable is in

[PATCH] D46943: [clangd] Boost scores for decls from current file in completion

ilya-biryukov added inline comments. Comment at: clangd/Quality.cpp:24 + if (SemaCCResult.Declaration) +AllDeclsInMainFile = allDeclsInMainFile(SemaCCResult.Declaration); if (SemaCCResult.Availability == CXAvailability_Deprecated) sammccall wrote: >

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin added a comment. Thank you for the reviews! Comment at: lib/CodeGen/CGException.cpp:1173 +cast(CatchStartBlock->getFirstNonPHI()); +CurrentFuncletPad = CPI; + } majnemer wrote: > Hmm, why is this done? Won't RestoreCurrentFuncletPad undo

[PATCH] D44931: [WebAssembly] Use Windows EH instructions for Wasm EH

aheejin updated this revision to Diff 147287. aheejin marked an inline comment as done. aheejin added a comment. `CatchStartBlock` -> `WasmCatchStartBlock` Repository: rC Clang https://reviews.llvm.org/D44931 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCleanup.cpp

[PATCH] D46942: Add vfs::FileSystem::getRealPath

This revision was automatically updated to reflect the committed changes. Closed by commit rL332590: Add vfs::FileSystem::getRealPath (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46942 Files:

r332590 - Add vfs::FileSystem::getRealPath

Author: ioeric Date: Thu May 17 03:26:23 2018 New Revision: 332590 URL: http://llvm.org/viewvc/llvm-project?rev=332590=rev Log: Add vfs::FileSystem::getRealPath Summary: And change `FileManager::getCanonicalName` to use getRealPath. Reviewers: bkramer Reviewed By: bkramer Subscribers:

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

asb added a comment. I wonder if it would be safer to change this patch so it adds -mrelax and -mno-relax but doesn't compile with linker relaxation by default. That makes it easier to test linker relaxation support, and gives more time for testing before then flipping to -mrelax as the

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

ioeric added inline comments. Comment at: clang-doc/generators/Generators.h:44 +class MDGenerator : public Generator { +public: Could you add high-level comment on what this does? This seems to build up some directory structure and write different infos into

  1   2   >